On 09/25/2014 10:32 PM, Jon Medhurst (Tixy) wrote:
On Thu, 2014-09-25 at 18:08 +0800, Alex Shi wrote:
Thanks for Tixy's reminder! The following commits are general thermal fixes which purpose on thermal-framework Any comments are appreciated!
Regards! Alex
[PATCH 01/11] thermal: cpu_cooling: fix 'descend' check in [PATCH 02/11] thermal: Fix binding problem when there is thermal zone [PATCH 03/11] thermal: fix cpu_cooling max_level behavior [PATCH 04/11] Thermal cpu cooling: return error if no valid cpu [PATCH 05/11] Thermal: thermal zone governor fix [PATCH 06/11] Thermal: Allow first update of cooling device state [PATCH 07/11] thermal: Bind cooling devices with the correct [PATCH 08/11] Thermal/cpu_cooling: Return directly for the cpu out of [PATCH 09/11] Thermal: update thermal zone device after setting [PATCH 10/11] thermal: Add braces around suspect code [PATCH 11/11] thermal: cpu_cooling: fix return value check in
Did you deliberately not include commit 50e66c7ed8 (drivers: thermal: add check when unregistering cpu cooling)?
Uh, that is better to be inclueded in LSK, Why I overlooked this? :(
Of the others you have in this series, 5 are those I spotted, and 2 (05/11 and 07/11) are included in the patches I received from ARM as part of their Juno delivery, so assume they are good to have too :-)
That leaves patches 02, 06, 09 and 10 which all look like they are fixing real bugs or at least inefficient and undesirable behaviour.
So, these patches all look good to me, however, as I only looked at this area of code for the first time yesterday I'm not sure how much my opinion is worth.
Thanks a lot for review! :)