Hi,
On Monday, June 15, 2015 05:27:31 PM Viresh Kumar wrote:
This adds support in OPP library to parse and create list of OPPs from operating-points-v2 bindings. It takes care of most of the properties of new bindings (except shared-opp, which will be handled separately).
For backward compatibility, we keep supporting earlier bindings. We try to search for the new bindings first, in case they aren't present we look for the old deprecated ones.
There are few things marked as TODO:
- Support for multiple OPP tables
- Support for multiple regulators
They should be fixed separately.
Signed-off-by: Viresh Kumar viresh.kumar@linaro.org
drivers/base/power/opp.c | 238 ++++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 213 insertions(+), 25 deletions(-)
diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c index 2ac48ff9c1ef..3198c3e77224 100644 --- a/drivers/base/power/opp.c +++ b/drivers/base/power/opp.c
[...]
@@ -675,6 +692,100 @@ static int _opp_add_dynamic(struct device *dev, unsigned long freq, } /**
- _opp_add_static_v2() - Allocate static OPPs (As per 'v2' DT bindings)
- @dev: device for which we do this operation
- @np: device node
- This function adds an opp definition to the opp list and returns status. The
- opp can be controlled using dev_pm_opp_enable/disable functions and may be
- removed by dev_pm_opp_remove.
- Locking: The internal device_opp and opp structures are RCU protected.
- Hence this function internally uses RCU updater strategy with mutex locks
- to keep the integrity of the internal data structures. Callers should ensure
- that this function is *NOT* called under RCU protection or in contexts where
- mutex cannot be locked.
- Return:
- 0 On success OR
Duplicate OPPs (both freq and volt are same) and opp->available
- -EEXIST Freq are same and volt are different OR
Duplicate OPPs (both freq and volt are same) and !opp->available
- -ENOMEM Memory allocation failure
- -EINVAL Failed parsing the OPP node
- */
+static int _opp_add_static_v2(struct device *dev, struct device_node *np) +{
- struct device_opp *dev_opp;
- struct dev_pm_opp *new_opp;
- int ret;
- /* Hold our list modification lock here */
- mutex_lock(&dev_opp_list_lock);
- new_opp = _allocate_opp(dev, &dev_opp);
- if (!new_opp) {
ret = -ENOMEM;goto unlock;- }
- ret = of_property_read_u32(np, "opp-hz", (u32 *)&new_opp->rate);
- if (ret < 0) {
dev_err(dev, "%s: opp-hz not found\n", __func__);goto free_opp;- }
Isn't using u32 for storing frequency (in Hz) too small by today's standards?
[ Please note that the old v1 binding uses kHz not Hz. ]
Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics