Re: [PATCH v3] common/board_f.c: fix compile error when tracing disabled

On 15 December 2014 at 13:07, Kevin Hilman khilman@kernel.org wrote:

From: Kevin Hilman khilman@linaro.org

When CONFIG_TRACE is disabled, linking fails with:

common/built-in.o:(.data.init_sequence_f+0x8): undefined reference to `trace_early_init'

To fix, wrap trace init calls with #ifdef CONFIG_TRACE.

While at it, remove the static inline version of the init call from trace.h as suggested by Simon Glass, since it doesnt work.

Cc: Simon Glass sjg@chromium.org Cc: Tom Rini trini@ti.com Signed-off-by: Kevin Hilman khilman@linaro.org

---

Applies to v2015.01-rc3

v3: Actually remove the static inlines this time. :/

common/board_f.c | 2 ++ include/trace.h | 7 ------- 2 files changed, 2 insertions(+), 7 deletions(-)

Acked-by: Simon Glass sjg@chromium.org