On 05/26/2014 10:13 AM, Viresh Kumar wrote:
On 26 May 2014 09:47, Viresh Kumar viresh.kumar@linaro.org wrote:
On 25 May 2014 14:58, Preeti U Murthy preeti@linux.vnet.ibm.com wrote:
You have left out CLOCK_EVT_MODE_ONESHOT here. We support this mode, in that, we do not need to do anything specific. In the above code it falls to default and returns "unsupported".
So you should have the below too.
case CLOCK_EVT_MODE_ONESHOT: break;
Well, I tried to take care of this and somehow got skipped for you. Will fix it.
Okay I did another review of the all 102 files manually and found only this fix:
diff --git a/arch/powerpc/kernel/time.c b/arch/powerpc/kernel/time.c index f552041..a6be92c 100644 --- a/arch/powerpc/kernel/time.c +++ b/arch/powerpc/kernel/time.c @@ -835,6 +835,8 @@ static int decrementer_set_mode(enum clock_event_mode mode, case CLOCK_EVT_MODE_RESUME: decrementer_set_next_event(DECREMENTER_MAX, dev); break;
case CLOCK_EVT_MODE_ONESHOT:break; default: return -ENOSYS; }
Yes this looks good.
Regards Preeti U Murthy