On 27-03-17, 15:58, Peter Zijlstra wrote:
On Thu, Mar 23, 2017 at 05:05:55PM +0530, Viresh Kumar wrote:
Hi,
Here are few minor cleanups for the sched core. The first three tries to avoid reinitializing memory which is already set to zero and the last one drops an unused statement.
I'm OK with the kzalloc/memset thing,
I assume that you are fine with removal of memset as done in the first 3 patches. Or you are fine with just the first patch?
but I'd prefer to keep all those other bits.
Yes they're superfluous, but this is init code, so nobody cares about performance and having those things explitic makes it easier to read.
Sure.
As to the very latest patch, that's there so that if/when we extend that array we can simply continue. Also its more symmetric/consistent. Any half sane DCE pass should get rid of it anyway, as the result is unused.
But we aren't going to extend the array all the time and keeping a statement like that just for symmetry doesn't sound that great :). Anyway, I will drop the last patch as you suggested.