On 2 July 2014 17:08, Preeti U Murthy preeti@linux.vnet.ibm.com wrote:
While I was re-verifying this piece of code I came across commit 79bf2bb3. As we discussed offline, commit 79bf2bb3 had this check when support to dynamic tick was being added.
But as you pointed out, the commit fb02fbc removed this check to keep jiffies updated for the sake of long running softirqs but was later again reverted in ae99286b due to spurious wakeups. However it was not entirely reverted. The long running softirqs were asked to fix themselves.
So adding back this check in here makes sense for the sake of the problem explained in the changelog. Besides, you might want to have the history as mentioned in the previous paragraph in this changelog too so that people do not wonder why the check was removed in the first place.
Added this to bottom of existing log.
Similar piece of code was present initially when dynticks functionality was first added: 79bf2bb3. But was later commit fb02fbc removed this check to keep jiffies updated for the sake of long running softirqs but was later again reverted in ae99286b due to spurious wakeups. However it was not entirely reverted. The long running softirqs were asked to fix themselves.