Re: [PATCH v4 4/4] drm: allow to use mmuless SoC

2016-12-07 11:27 GMT+01:00 Daniel Vetter daniel@ffwll.ch:

On Wed, Dec 07, 2016 at 11:06:51AM +0100, Benjamin Gaignard wrote:

...

Some SoC without MMU have display driver where a drm/kms driver could be implemented.

Before doing such kind of thing drm/kms must allow to use mmuless devices. This patch propose to remove MMU configuration flag and add a cma helper function to help implementing mmuless display driver

version 4:

• add documentation about drm_gem_cma_get_unmapped_area()
• stub it MMU case

Signed-off-by: Benjamin Gaignard benjamin.gaignard@linaro.org

Shouldn't we also update DRM_FB_HELPER_DEFAULT_OPS? With that addressed this all looks good to me.

Those changes shouldn't impact fb_ops but only fbdev file_operations like it is done in fbmem patch

-Daniel

[snip]