Re: [PATCH V3 07/14] cpufreq: Don't allow updating inactive-policies from sysfs

On 16-05-15, 03:10, Rafael J. Wysocki wrote:

The dash after "inactive" in the subject is not necessary IMO.

Okay

On Friday, May 08, 2015 11:53:50 AM Viresh Kumar wrote:

...

• /*

• * Policy might not be active currently, and so we shouldn't try
  

• * updating any values here. policy->cpus is cleared for inactive policy
  

• * and so cpufreq_cpu_get_raw() should fail.
  

These comments don't really clarify things. It'd be better to say something like "Updating inactive policies is invalid, so avoid doing that."

Okay..

...

• */
  

• if (unlikely(policy_is_inactive(policy))) {

• ret = -EPERM;
  

This doesn't seem to be the appropriate error code to return here.

-EBUSY or -EAGAIN would be better IMO.

Okay