On Wed, Oct 08, 2014 at 11:09:59PM +0100, Mark Brown wrote:
Description of regulators should generally be optional so if there is no DT node for the regulators container then we shouldn't print an error message. Lower the severity of the message to debug level (it might help someone work out what went wrong) and while we're at it say what we were looking for.
Reported-by: Guenter Roeck linux@roeck-us.net Signed-off-by: Mark Brown broonie@kernel.org
Excellent.
Reviewed-by: Guenter Roeck linux@roeck-us.net
Would it also be possible to lower the severity of the "no parameters" message ?
Thanks, Guenter
drivers/regulator/of_regulator.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c index 7a51814abdc5..5a1d4afa4776 100644 --- a/drivers/regulator/of_regulator.c +++ b/drivers/regulator/of_regulator.c @@ -211,7 +211,8 @@ struct regulator_init_data *regulator_of_get_init_data(struct device *dev, search = dev->of_node; if (!search) {
dev_err(dev, "Failed to find regulator container node\n");
dev_dbg(dev, "Failed to find regulator container node '%s'\n",desc->regulators_node);2.1.1