Re: [PATCH] devfreq: rk3399_dmc: Remove dangling rcu_read_unlock()

Hi Viresh,

On 2016년 12월 01일 19:42, Viresh Kumar wrote:

This call never had the rcu_read_lock() counterpart. Remove the unlock part as well.

Signed-off-by: Viresh Kumar viresh.kumar@linaro.org

drivers/devfreq/rk3399_dmc.c | 1 - 1 file changed, 1 deletion(-)

diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c index 192240423fee..4cc5be08720a 100644 --- a/drivers/devfreq/rk3399_dmc.c +++ b/drivers/devfreq/rk3399_dmc.c @@ -408,7 +408,6 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev) */ if (dev_pm_opp_of_add_table(dev)) { dev_err(dev, "Invalid operating-points in device tree.\n");

• rcu_read_unlock();
  

  return -EINVAL; }

Looks good to me.

Reviewed-by: Chanwoo Choi cw00.choi@samsung.com