Re: [Qemu-devel] [PATCH] migration: Fix debug print type

See my comment below.

Am 23.08.2013 09:06, schrieb Christoffer Dall:

The printf args are uint64_t and with -Werr QEMU doesn't compile with migration debugging turned on unless this is fixed. Fix it.

Signed-off-by: Christoffer Dall christoffer.dall@linaro.org

migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/migration.c b/migration.c index 1402fa7..0d8706f 100644 --- a/migration.c +++ b/migration.c @@ -566,7 +566,7 @@ static void *migration_thread(void *opaque) if (!qemu_file_rate_limit(s->file)) { DPRINTF("iterate\n"); pending_size = qemu_savevm_state_pending(s->file, max_size);

•        DPRINTF("pending size %lu max %lu\n", pending_size, max_size);
  

•        DPRINTF("pending size %llu max %llu\n", pending_size, max_size);
  

Please use PRIu64 for uint64_t.

         if (pending_size && pending_size >= max_size) {
             qemu_savevm_state_iterate(s->file);
         } else {