Re: [PATCH 07/14] cpufreq: cpu0: OPPs can be populated at runtime

On 07/01/14 09:32, Viresh Kumar wrote:

OPPs can be populated statically, via DT, or added at run time with dev_pm_opp_add().

While this driver handles the first case correctly, it would fail to populate OPPs added at runtime. Because call to of_init_opp_table() would fail as there are no OPPs in DT and probe will return early.

To fix this, remove error checking and call dev_pm_opp_init_cpufreq_table() unconditionally.

Suggested-by: Stephen Boyd sboyd@codeaurora.org Signed-off-by: Viresh Kumar viresh.kumar@linaro.org

---

drivers/cpufreq/cpufreq-cpu0.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)

Please update the binding as well to indicate that this property is now optional.