26 Apr
2013
26 Apr
'13
8:39 p.m.
On Fri, Apr 26, 2013 at 12:11 PM, Anup Patel anup@brainfault.org wrote:
On Fri, Apr 26, 2013 at 11:57 PM, Christoffer Dall cdall@cs.columbia.edu wrote:
Sure, I incorporate all above comments and send revised patch.
Hi Anup,
Now when we're at it, your commit message is exessively long, both the title and the actual content. Please try to keep the commit message under 80 chars at least and the title of the patch even shorter if possible: think doing a 'git log' on an 80 char terminal...
-Christoffer
Oke, I'll keep the commit message shorter.
thanks, just to be clear, the body of the message can be as long as appropriate, but the lines should be wrapped at 80 chars max.