On 24 June 2014 13:33, Peter Zijlstra peterz@infradead.org wrote:
All true; but does it change anything? That is, does your compiler generate better code because of this?
Compilers are smart enough now a days and may not perform !! at all I believe.. And so this patch is more about code clarity ..
I tried comparing results for ARM and got this with/without this patch ..
$ size ../bexynos/kernel/sched/idle.o text data bss dec hex filename 690 30 0 720 2d0 ../bexynos/kernel/sched/idle.o
Don't know if some architectures are using somewhat dumb compilers which might result in better code with this patch :)