On 10/28/2015 06:19 PM, Viresh Kumar wrote:
On 28-10-15, 11:36, Alex Shi wrote:
Hi Viresh,
Thanks for your great work on OPP v2 support!
LSK was requested to backport this feature on 3.18/4.1 kernel https://projects.linaro.org/browse/LSK-3 I have 2 draft branches for this purpose git://git.linaro.org/kernel/linux-linaro-stable.git v3.18/topic/OPPv2/v4.1/topic/OPPv2
Would you like review those branches? And if they're ok. Any suggestions for this feature testing?
Hey Alex,
I did go through the branches, but there are too many patches (sorry for adding so many of them). And I am not sure if you missed anything, I have to believe you for that :)
So, it is fine if you have picked all OPP patches between 3.18 and the latest release.
Thanks for review! I am sure all 'PM / OPP' commits are picked up as well as cpufreq-dt. but not all cpufreq commit...
Regarding testing, there are two important things you need to test:
- Old bindings: A lot of users are using the old v1 bindings and you need to do some sanity cpufreq tests on them to see if the old bindings are still working well.
Sorry for a newbies on cpufreq! Could you like to give some detailed suggestions like, with which kinds of boards, using some testcase, like pmtest to do function checking...
And for OPPv2, I just find the arch/arm/boot/dts/exynos4412.dtsi is the only one which support OPPv2, is it right? What test did you do for upstream?
- New bindings: You need to convert few of them (and maybe upstream that as well) to use the new bindings and then repeat the same tests.