On 15-10-15, 12:25, Saravana Kannan wrote:
Btw, does a Review-by have an implicit Acked-by?
I have attended a session at Linaro Connect where this was discussed and the answer was:
Acked-by: is more of a general agreement from the person that he is fine with the patch, but he might not have done a very careful review and he isn't really responsible for the patch's content.
Reviewed-by: is a more strict tag and implies that the reviewer has reviewed it at his best and he is as much responsible for the content of the patch as the author.
Kinda unrelated to this patch, but shouldn't this function undo the symlinks is has created so far before returning? Otherwise, we'd be leaving around broken symlinks.
Hmm, yeah. Will fix it separately.