Re: [PATCH 1/2] regulators: Add definition of regulator_set_voltage_time() for !CONFIG_REGULATOR

On Tue, May 27, 2014 at 05:37:29PM +0530, Viresh Kumar wrote:

Liam/Broonie: Please see if this can go through Rafael as 2nd patch is dependent on it.

Is that likely to happen before the merge window?

+static inline int regulator_set_voltage_time(struct regulator *regulator,

• 			     int old_uV, int new_uV)
  

+{

• return 0;

+}

Hrm, I'd have expected this to return -EINVAL when stubbed. I'd also have expected regulator_set_voltage() to return -EINVAL mind you. I *suppose* that something that doesn't actually depend on regulator like cpufreq might not care if the voltage really did change (I bet this was added for cpufreq) but it's not awesome.