Re: [PATCH 3/7] ARM: dts: Add basic PM domains for EXYNOS5420

Hi Vikas, Yadwinder,

Please see my comments inline.

On Monday 29 of July 2013 19:19:27 Vikas Sajjan wrote:

From: Yadwinder Singh Brar yadi.brar@samsung.com

Add DT nodes for gsc, isp, mfc, disp, mau, g2d and msc PM domains.

Signed-off-by: Yadwinder Singh Brar yadi.brar@samsung.com

arch/arm/boot/dts/exynos5420.dtsi | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi index 8c54c4b..bd6b310 100644 --- a/arch/arm/boot/dts/exynos5420.dtsi +++ b/arch/arm/boot/dts/exynos5420.dtsi @@ -90,6 +90,41 @@ }; };

• gsc_pd: pd@10044000 {

Please use power-domain for node names. We might have "pd" for other Exynos SoCs, but this needs to be fixed.

Best regards, Tomasz