From: Mark Brown broonie@linaro.org
Since all the voltage tables for ab8500 are sorted in ascending order we can improve performance by using regulator_map_voltage_ascend(). A couple of the regulators can actually use linear maps which would be even better.
Signed-off-by: Mark Brown broonie@linaro.org --- drivers/regulator/ab8500.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c index 603f192..43cb354 100644 --- a/drivers/regulator/ab8500.c +++ b/drivers/regulator/ab8500.c @@ -651,6 +651,7 @@ static struct regulator_ops ab8500_regulator_volt_mode_ops = { .get_voltage_sel = ab8500_regulator_get_voltage_sel, .set_voltage_sel = ab8500_regulator_set_voltage_sel, .list_voltage = regulator_list_voltage_table, + .map_voltage = regulator_map_voltage_ascend, };
static struct regulator_ops ab8540_aux3_regulator_volt_mode_ops = { @@ -663,6 +664,7 @@ static struct regulator_ops ab8540_aux3_regulator_volt_mode_ops = { .get_voltage_sel = ab8540_aux3_regulator_get_voltage_sel, .set_voltage_sel = ab8540_aux3_regulator_set_voltage_sel, .list_voltage = regulator_list_voltage_table, + .map_voltage = regulator_map_voltage_ascend, };
static struct regulator_ops ab8500_regulator_volt_ops = { @@ -672,6 +674,7 @@ static struct regulator_ops ab8500_regulator_volt_ops = { .get_voltage_sel = ab8500_regulator_get_voltage_sel, .set_voltage_sel = ab8500_regulator_set_voltage_sel, .list_voltage = regulator_list_voltage_table, + .map_voltage = regulator_map_voltage_ascend, };
static struct regulator_ops ab8500_regulator_mode_ops = { @@ -682,6 +685,7 @@ static struct regulator_ops ab8500_regulator_mode_ops = { .set_mode = ab8500_regulator_set_mode, .get_mode = ab8500_regulator_get_mode, .list_voltage = regulator_list_voltage_table, + .map_voltage = regulator_map_voltage_ascend, };
static struct regulator_ops ab8500_regulator_ops = { @@ -689,6 +693,7 @@ static struct regulator_ops ab8500_regulator_ops = { .disable = ab8500_regulator_disable, .is_enabled = ab8500_regulator_is_enabled, .list_voltage = regulator_list_voltage_table, + .map_voltage = regulator_map_voltage_ascend, };
static struct regulator_ops ab8500_regulator_anamic_mode_ops = { @@ -698,6 +703,7 @@ static struct regulator_ops ab8500_regulator_anamic_mode_ops = { .set_mode = ab8500_regulator_set_mode, .get_mode = ab8500_regulator_get_mode, .list_voltage = regulator_list_voltage_table, + .map_voltage = regulator_map_voltage_ascend, };
/* AB8500 regulator information */
On Wed, Jul 3, 2013 at 11:16 AM, Mark Brown broonie@kernel.org wrote:
From: Mark Brown broonie@linaro.org
Since all the voltage tables for ab8500 are sorted in ascending order we can improve performance by using regulator_map_voltage_ascend(). A couple of the regulators can actually use linear maps which would be even better.
Signed-off-by: Mark Brown broonie@linaro.org
Hm. Have you looked closer at this one voltage table in this driver:
static const unsigned int ldo_vaux56_voltages[] = { 1800000, 1050000, 1100000, 1200000, 1500000, 2200000, 2500000, 2790000, };
Or this one:
static const unsigned int ldo_sdio_voltages[] = { 1160000, 1050000, 1100000, 1500000, 1800000, 2200000, 2910000, 3050000, };
Yours, Linus Walleij
On Sun, Jul 21, 2013 at 04:45:23PM +0200, Linus Walleij wrote:
Hm. Have you looked closer at this one voltage table in this driver:
static const unsigned int ldo_vaux56_voltages[] = { 1800000, 1050000,
Meh, that's annoying - 8 looks too close to zero and it's the first time I've ever seen non-ascending hardware :/
On Mon, Jul 22, 2013 at 1:34 AM, Mark Brown broonie@kernel.org wrote:
On Sun, Jul 21, 2013 at 04:45:23PM +0200, Linus Walleij wrote:
Hm. Have you looked closer at this one voltage table in this driver:
static const unsigned int ldo_vaux56_voltages[] = { 1800000, 1050000,
Meh, that's annoying - 8 looks too close to zero and it's the first time I've ever seen non-ascending hardware :/
Yeah it totally kills my obsessive-compulsive side ... but it seems the HW engineer didn't care :-(
Yours, Linus Walleij
linaro-kernel@lists.linaro.org