changes since v2: - split the 5250 related modifications into a separate patch. - placed the RTC node as per the alphabetical order in the DTS file as suggested by Kukjin Kim kgene@kernel.org.
changes since v1: - made DT node status as "okay" in the dtsi file itself. - Vikas Sajjan (2): ARM: dts: Add RTC DT node to Exynos5420 SoC ARM: dts: Fix the RTC DT node name for Exynos5250 SoC
arch/arm/boot/dts/exynos5.dtsi | 2 +- arch/arm/boot/dts/exynos5250.dtsi | 3 ++- arch/arm/boot/dts/exynos5420.dtsi | 6 ++++++ 3 files changed, 9 insertions(+), 2 deletions(-)
Adds RTC DT node to Exynos5420 SoC
Signed-off-by: Vikas Sajjan vikas.sajjan@linaro.org --- arch/arm/boot/dts/exynos5.dtsi | 2 +- arch/arm/boot/dts/exynos5420.dtsi | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi index f65e124..4a8e223 100644 --- a/arch/arm/boot/dts/exynos5.dtsi +++ b/arch/arm/boot/dts/exynos5.dtsi @@ -95,7 +95,7 @@ interrupts = <0 54 0>; };
- rtc { + rtc@101E0000 { compatible = "samsung,s3c6410-rtc"; reg = <0x101E0000 0x100>; interrupts = <0 43 0>, <0 44 0>; diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi index 9e90d1e..713bb5a 100644 --- a/arch/arm/boot/dts/exynos5420.dtsi +++ b/arch/arm/boot/dts/exynos5420.dtsi @@ -126,6 +126,12 @@ interrupts = <0 47 0>; };
+ rtc@101E0000 { + clocks = <&clock 317>; + clock-names = "rtc"; + status = "okay"; + }; + serial@12C00000 { clocks = <&clock 257>, <&clock 128>; clock-names = "uart", "clk_uart_baud0";
Fixes the RTC DT node name for Exynos5250 SoC and also makes status of the node as "okay".
Signed-off-by: Vikas Sajjan vikas.sajjan@linaro.org --- arch/arm/boot/dts/exynos5250.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi index 88589b7..c82137b 100644 --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -178,9 +178,10 @@ samsung,power-domain = <&pd_mfc>; };
- rtc { + rtc@101E0000 { clocks = <&clock 337>; clock-names = "rtc"; + status = "okay"; };
tmu@10060000 {
Hi Vikas,
On Wednesday 14 of August 2013 16:32:59 Vikas Sajjan wrote:
changes since v2:
- split the 5250 related modifications into a separate patch.
I'm not sure whether Kukjin's comment was about this, as it introduces a short bisect breakage between patch 1 and patch 2 from this series.
IMHO it would be more sensible to make first patch simply fix name of the node and then a separate patch adding the rtc node for exynos5420.
Best regards, Tomasz
- placed the RTC node as per the alphabetical order in the DTS file as
suggested by Kukjin Kim kgene@kernel.org.
changes since v1:
- made DT node status as "okay" in the dtsi file itself.
Vikas Sajjan (2): ARM: dts: Add RTC DT node to Exynos5420 SoC ARM: dts: Fix the RTC DT node name for Exynos5250 SoC
arch/arm/boot/dts/exynos5.dtsi | 2 +- arch/arm/boot/dts/exynos5250.dtsi | 3 ++- arch/arm/boot/dts/exynos5420.dtsi | 6 ++++++ 3 files changed, 9 insertions(+), 2 deletions(-)
Hi Tomasz,
On 14 August 2013 17:00, Tomasz Figa t.figa@samsung.com wrote:
Hi Vikas,
On Wednesday 14 of August 2013 16:32:59 Vikas Sajjan wrote:
changes since v2: - split the 5250 related modifications into a separate patch.
I'm not sure whether Kukjin's comment was about this, as it introduces a short bisect breakage between patch 1 and patch 2 from this series.
IMHO it would be more sensible to make first patch simply fix name of the node and then a separate patch adding the rtc node for exynos5420.
Are you saying that patch 1: should contain modifications for exynos5.dtsi and exynos5250.dtsi ( basically the RTC name change and status as "okay") patch 2: should contain modifications only for exynos5420.dtsi ( new RTC DT node )
Best regards, Tomasz
- placed the RTC node as per the alphabetical order in the DTS file as suggested by Kukjin Kim <kgene@kernel.org>.changes since v1: - made DT node status as "okay" in the dtsi file itself.
Vikas Sajjan (2): ARM: dts: Add RTC DT node to Exynos5420 SoC ARM: dts: Fix the RTC DT node name for Exynos5250 SoC
arch/arm/boot/dts/exynos5.dtsi | 2 +- arch/arm/boot/dts/exynos5250.dtsi | 3 ++- arch/arm/boot/dts/exynos5420.dtsi | 6 ++++++ 3 files changed, 9 insertions(+), 2 deletions(-)
On Wednesday 14 of August 2013 17:37:47 Vikas Sajjan wrote:
Hi Tomasz,
On 14 August 2013 17:00, Tomasz Figa t.figa@samsung.com wrote:
Hi Vikas,
On Wednesday 14 of August 2013 16:32:59 Vikas Sajjan wrote:
changes since v2: - split the 5250 related modifications into a separate patch.
I'm not sure whether Kukjin's comment was about this, as it introduces a short bisect breakage between patch 1 and patch 2 from this series.
IMHO it would be more sensible to make first patch simply fix name of the node and then a separate patch adding the rtc node for exynos5420.
Are you saying that patch 1: should contain modifications for exynos5.dtsi and exynos5250.dtsi ( basically the RTC name change and status as "okay") patch 2: should contain modifications only for exynos5420.dtsi ( new RTC DT node )
Oh, I forgot about the status property. So ideally there should be 3 patches: - patch 1 changing exynos5.dtsi and exynos5250.dtsi to fix RTC node name, - patch 2 adding status="okay" to exynos5250.dtsi, - patch 3 adding RTC node to exynos5420.dtsi.
Best regards, Tomasz
linaro-kernel@lists.linaro.org
-
Tomasz Figa -
Vikas Sajjan