Using the generic function saves looking up this custom one in a source navigator.
Signed-off-by: Daniel Thompson daniel.thompson@linaro.org Cc: Thomas Gleixner tglx@linutronix.de Cc: Jason Cooper jason@lakedaemon.net --- drivers/irqchip/irq-nvic.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/irqchip/irq-nvic.c b/drivers/irqchip/irq-nvic.c index 70bdf6e..c935c61 100644 --- a/drivers/irqchip/irq-nvic.c +++ b/drivers/irqchip/irq-nvic.c @@ -49,14 +49,6 @@ nvic_handle_irq(irq_hw_number_t hwirq, struct pt_regs *regs) handle_IRQ(irq, regs); }
-static void nvic_eoi(struct irq_data *d) -{ - /* - * This is a no-op as end of interrupt is signaled by the exception - * return sequence. - */ -} - static int __init nvic_of_init(struct device_node *node, struct device_node *parent) { @@ -102,7 +94,7 @@ static int __init nvic_of_init(struct device_node *node, gc->chip_types[0].regs.disable = NVIC_ICER; gc->chip_types[0].chip.irq_mask = irq_gc_mask_disable_reg; gc->chip_types[0].chip.irq_unmask = irq_gc_unmask_enable_reg; - gc->chip_types[0].chip.irq_eoi = nvic_eoi; + gc->chip_types[0].chip.irq_eoi = irq_gc_noop;
/* disable interrupts */ writel_relaxed(~0, gc->reg_base + NVIC_ICER);
On Wed, Jun 04, 2014 at 01:37:05PM +0100, Daniel Thompson wrote:
Using the generic function saves looking up this custom one in a source navigator.
Signed-off-by: Daniel Thompson daniel.thompson@linaro.org
Acked-by: Uwe Kleine-König u.kleine-koenig@pengutronix.de
thanks Uwe
On Wed, 4 Jun 2014, Daniel Thompson wrote:
Using the generic function saves looking up this custom one in a source navigator.
Signed-off-by: Daniel Thompson daniel.thompson@linaro.org Cc: Thomas Gleixner tglx@linutronix.de Cc: Jason Cooper jason@lakedaemon.net
drivers/irqchip/irq-nvic.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/irqchip/irq-nvic.c b/drivers/irqchip/irq-nvic.c index 70bdf6e..c935c61 100644 --- a/drivers/irqchip/irq-nvic.c +++ b/drivers/irqchip/irq-nvic.c @@ -49,14 +49,6 @@ nvic_handle_irq(irq_hw_number_t hwirq, struct pt_regs *regs) handle_IRQ(irq, regs); } -static void nvic_eoi(struct irq_data *d) -{
- /*
* This is a no-op as end of interrupt is signaled by the exception
* return sequence.
*/
You shred that information. Please move the comment above the irq_gc_noop assignment.
Thanks,
tglx
Using the generic function saves looking up this custom one in a source navigator.
Signed-off-by: Daniel Thompson daniel.thompson@linaro.org Cc: Thomas Gleixner tglx@linutronix.de Cc: Jason Cooper jason@lakedaemon.net --- drivers/irqchip/irq-nvic.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/irqchip/irq-nvic.c b/drivers/irqchip/irq-nvic.c index 70bdf6e..4ff0805 100644 --- a/drivers/irqchip/irq-nvic.c +++ b/drivers/irqchip/irq-nvic.c @@ -49,14 +49,6 @@ nvic_handle_irq(irq_hw_number_t hwirq, struct pt_regs *regs) handle_IRQ(irq, regs); }
-static void nvic_eoi(struct irq_data *d) -{ - /* - * This is a no-op as end of interrupt is signaled by the exception - * return sequence. - */ -} - static int __init nvic_of_init(struct device_node *node, struct device_node *parent) { @@ -102,7 +94,10 @@ static int __init nvic_of_init(struct device_node *node, gc->chip_types[0].regs.disable = NVIC_ICER; gc->chip_types[0].chip.irq_mask = irq_gc_mask_disable_reg; gc->chip_types[0].chip.irq_unmask = irq_gc_unmask_enable_reg; - gc->chip_types[0].chip.irq_eoi = nvic_eoi; + /* This is a no-op as end of interrupt is signaled by the + * exception return sequence. + */ + gc->chip_types[0].chip.irq_eoi = irq_gc_noop;
/* disable interrupts */ writel_relaxed(~0, gc->reg_base + NVIC_ICER);
On Wed, Jun 04, 2014 at 04:01:52PM +0100, Daniel Thompson wrote:
Using the generic function saves looking up this custom one in a source navigator.
Signed-off-by: Daniel Thompson daniel.thompson@linaro.org Cc: Thomas Gleixner tglx@linutronix.de Cc: Jason Cooper jason@lakedaemon.net
drivers/irqchip/irq-nvic.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-)
Applied to irqchip/core with Uwe's Ack.
thx,
Jason.
linaro-kernel@lists.linaro.org