Hi Alex, Mark
I see that the thermal-framework LSK topic is missing fixes that are upstream, specifically
24c7a381720843f17efb42de81f7e85aefd6f616 1cc4feed174dc5834faccc2d61d3bc7189d603d6 73b9bcd76d13716cc0e0ab053f8c1ae41f47636e e361f81b04d81fb3f56f95446d4266a270246c2d 771423447242882445322faa62bdc9afb146415e 0a5d1934d88b8797113fd5f6bb7c521d4f1fb11b
Actually, commit 73b9bcd is in LSK, but not as a separate commit, it's changes were included in the cherry-pick of 39d99cff76bf2992fd6dd4b1fc62da139e62e90c which is in LSK as 17dcbf41efd82fd7a1c997d87e23e97f6c993c2e
All the above commits are those which affect drivers/thermal/cpu_cooling.c - I've not checked other files.
I discovered all as I'm trying to get a thermal driver working on Juno with LSK and in debugging saw obvious code bugs which made me go to mainline Linux looking for fixes.
Thanks a lots for the reminder, Tixy! I will look into the new commits and try pick up some.
Thanks Alex
On 09/25/2014 12:15 AM, Jon Medhurst (Tixy) wrote:
Hi Alex, Mark
I see that the thermal-framework LSK topic is missing fixes that are upstream, specifically
24c7a381720843f17efb42de81f7e85aefd6f616 1cc4feed174dc5834faccc2d61d3bc7189d603d6 73b9bcd76d13716cc0e0ab053f8c1ae41f47636e e361f81b04d81fb3f56f95446d4266a270246c2d 771423447242882445322faa62bdc9afb146415e 0a5d1934d88b8797113fd5f6bb7c521d4f1fb11b
Actually, commit 73b9bcd is in LSK, but not as a separate commit, it's changes were included in the cherry-pick of 39d99cff76bf2992fd6dd4b1fc62da139e62e90c which is in LSK as 17dcbf41efd82fd7a1c997d87e23e97f6c993c2e
All the above commits are those which affect drivers/thermal/cpu_cooling.c - I've not checked other files.
I discovered all as I'm trying to get a thermal driver working on Juno with LSK and in debugging saw obvious code bugs which made me go to mainline Linux looking for fixes.
Thanks Alex
On 09/25/2014 12:15 AM, Jon Medhurst (Tixy) wrote:
Hi Alex, Mark
I see that the thermal-framework LSK topic is missing fixes that are upstream, specifically
24c7a381720843f17efb42de81f7e85aefd6f616 1cc4feed174dc5834faccc2d61d3bc7189d603d6 73b9bcd76d13716cc0e0ab053f8c1ae41f47636e e361f81b04d81fb3f56f95446d4266a270246c2d 771423447242882445322faa62bdc9afb146415e 0a5d1934d88b8797113fd5f6bb7c521d4f1fb11b
Hi, Tixy,
Thanks a lot for the bug fix commit reminders.
I found the 1st and 3rd commits in upstream kernel. but missed the others neither in linus tree, nor in linux-next/master. Could you like to tell me where the others commits come from?
Actually, commit 73b9bcd is in LSK, but not as a separate commit, it's changes were included in the cherry-pick of 39d99cff76bf2992fd6dd4b1fc62da139e62e90c which is in LSK as 17dcbf41efd82fd7a1c997d87e23e97f6c993c2e
All the above commits are those which affect drivers/thermal/cpu_cooling.c - I've not checked other files.
I checked all files under drivers/thermal/. seems no more general bug fixed from lsk thermal-framework. nor sth interesting for LSK.
So till now, I am going to pick up the 1st commit only, 24c7a3817. But if you find sth is good to have, let me know. :)
I discovered all as I'm trying to get a thermal driver working on Juno with LSK and in debugging saw obvious code bugs which made me go to mainline Linux looking for fixes.
On Thu, 2014-09-25 at 13:33 +0800, Alex Shi wrote:
Thanks Alex
On 09/25/2014 12:15 AM, Jon Medhurst (Tixy) wrote:
Hi Alex, Mark
I see that the thermal-framework LSK topic is missing fixes that are upstream, specifically
24c7a381720843f17efb42de81f7e85aefd6f616 1cc4feed174dc5834faccc2d61d3bc7189d603d6 73b9bcd76d13716cc0e0ab053f8c1ae41f47636e e361f81b04d81fb3f56f95446d4266a270246c2d 771423447242882445322faa62bdc9afb146415e 0a5d1934d88b8797113fd5f6bb7c521d4f1fb11b
Hi, Tixy,
Thanks a lot for the bug fix commit reminders.
I found the 1st and 3rd commits in upstream kernel. but missed the others neither in linus tree, nor in linux-next/master. Could you like to tell me where the others commits come from?
Sorry, I got the SHA1s wrong (used those of my cherry-pick, not original upstream) the correct commits are...
24c7a381720843f17efb42de81f7e85aefd6f616 (thermal: cpu_cooling: fix 'descend' check in get_property()) 044d5c26da262fa433dacbe1c6962459050d6b06 (Thermal/cpu_cooling: Return directly for the cpu out of allowed_cpus in the cpufreq_thermal_notifier()) 73b9bcd76d13716cc0e0ab053f8c1ae41f47636e (thermal: cpu_cooling: fix return value check in cpufreq_cooling_register()) 50e66c7ed8a1cd7e933628f9f5cf2617394adf5a (drivers: thermal: add check when unregistering cpu cooling) 1c9573a40c1d34494419f32560f28c763c504d79 (thermal: fix cpu_cooling max_level behavior) a116776f7b6052599df0c67db29c30ea9d69d7ee (Thermal cpu cooling: return error if no valid cpu frequency entry)
24c7a381720843f17efb42de81f7e85aefd6f616 (thermal: cpu_cooling: fix 'descend' check in get_property()) 044d5c26da262fa433dacbe1c6962459050d6b06 (Thermal/cpu_cooling: Return directly for the cpu out of allowed_cpus in the cpufreq_thermal_notifier()) 73b9bcd76d13716cc0e0ab053f8c1ae41f47636e (thermal: cpu_cooling: fix return value check in cpufreq_cooling_register()) 50e66c7ed8a1cd7e933628f9f5cf2617394adf5a (drivers: thermal: add check when unregistering cpu cooling) 1c9573a40c1d34494419f32560f28c763c504d79 (thermal: fix cpu_cooling max_level behavior) a116776f7b6052599df0c67db29c30ea9d69d7ee (Thermal cpu cooling: return error if no valid cpu frequency entry)
Thanks a lot! Indeed!
Although above fixes are not related with thermal-framework, it still seems better to go to thermal-framework topic instead of misc topic. What's your comments, Mark?
linaro-kernel@lists.linaro.org
-
Alex Shi -
Jon Medhurst (Tixy)