When running "mod X" operation, if X is 0 the filter has to be halt. Add new test cases to cover A = A mod X if X is 0, and A = A mod 1.
CC: Xi Wang xi.wang@gmail.com CC: Zi Shen Lim zlim.lnx@gmail.com Signed-off-by: Yang Shi yang.shi@linaro.org --- lib/test_bpf.c | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+)
diff --git a/lib/test_bpf.c b/lib/test_bpf.c index d137739..10cd186 100644 --- a/lib/test_bpf.c +++ b/lib/test_bpf.c @@ -5056,6 +5056,36 @@ static struct bpf_test tests[] = { { {0x1, 0x0 } }, }, { + "MOD default X", + .u.insns = { + /* + * A = 0x42 + * A = A mod X ; this halt the filter execution if X is 0 + * ret 0x42 + */ + BPF_STMT(BPF_LD | BPF_IMM, 0x42), + BPF_STMT(BPF_ALU | BPF_MOD | BPF_X, 0), + BPF_STMT(BPF_RET | BPF_K, 0x42), + }, + CLASSIC | FLAG_NO_DATA, + {}, + { {0x1, 0x0 } }, + }, + { + "MOD default A", + .u.insns = { + /* + * A = A mod 1 + * ret A + */ + BPF_STMT(BPF_ALU | BPF_MOD | BPF_K, 0x1), + BPF_STMT(BPF_RET | BPF_A, 0x0), + }, + CLASSIC | FLAG_NO_DATA, + {}, + { {0x1, 0x0 } }, + }, + { "JMP EQ default A", .u.insns = { /*
On 11/04/2015 08:36 PM, Yang Shi wrote:
When running "mod X" operation, if X is 0 the filter has to be halt. Add new test cases to cover A = A mod X if X is 0, and A = A mod 1.
CC: Xi Wang xi.wang@gmail.com CC: Zi Shen Lim zlim.lnx@gmail.com Signed-off-by: Yang Shi yang.shi@linaro.org
LGTM!
Acked-by: Daniel Borkmann daniel@iogearbox.net
On Wed, Nov 04, 2015 at 11:36:37AM -0800, Yang Shi wrote:
When running "mod X" operation, if X is 0 the filter has to be halt. Add new test cases to cover A = A mod X if X is 0, and A = A mod 1.
CC: Xi Wang xi.wang@gmail.com CC: Zi Shen Lim zlim.lnx@gmail.com Signed-off-by: Yang Shi yang.shi@linaro.org
Acked-by: Alexei Starovoitov ast@kernel.org
On Wednesday, November 4, 2015, Yang Shi yang.shi@linaro.org wrote:
When running "mod X" operation, if X is 0 the filter has to be halt. Add new test cases to cover A = A mod X if X is 0, and A = A mod 1.
CC: Xi Wang <xi.wang@gmail.com javascript:;> CC: Zi Shen Lim <zlim.lnx@gmail.com javascript:;> Signed-off-by: Yang Shi <yang.shi@linaro.org javascript:;>
Acked-by: Zi Shen Lim zlim.lnx@gmail.com
On Wed, Nov 4, 2015 at 11:36 AM, Yang Shi yang.shi@linaro.org wrote:
When running "mod X" operation, if X is 0 the filter has to be halt. Add new test cases to cover A = A mod X if X is 0, and A = A mod 1.
CC: Xi Wang xi.wang@gmail.com CC: Zi Shen Lim zlim.lnx@gmail.com Signed-off-by: Yang Shi yang.shi@linaro.org
Acked-by: Zi Shen Lim zlim.lnx@gmail.com
On Wed, Nov 4, 2015 at 11:36 AM, Yang Shi yang.shi@linaro.org wrote:
When running "mod X" operation, if X is 0 the filter has to be halt. Add new test cases to cover A = A mod X if X is 0, and A = A mod 1.
CC: Xi Wang xi.wang@gmail.com CC: Zi Shen Lim zlim.lnx@gmail.com Signed-off-by: Yang Shi yang.shi@linaro.org
Acked-by: Xi Wang xi.wang@gmail.com
From: Yang Shi yang.shi@linaro.org Date: Wed, 4 Nov 2015 11:36:37 -0800
When running "mod X" operation, if X is 0 the filter has to be halt. Add new test cases to cover A = A mod X if X is 0, and A = A mod 1.
CC: Xi Wang xi.wang@gmail.com CC: Zi Shen Lim zlim.lnx@gmail.com Signed-off-by: Yang Shi yang.shi@linaro.org
Applied, thank you.
linaro-kernel@lists.linaro.org