Tree/Branch: next-20170608 Git describe: next-20170608 Commit: e4689b9aad Add linux-next specific files for 20170608
Build Time: 0 min 12 sec
Passed: 6 / 7 ( 85.71 %) Failed: 1 / 7 ( 14.29 %)
Errors: 1 Warnings: 4 Section Mismatches: 0
Failed defconfigs: arm-allmodconfig
Errors:
arm-allmodconfig ../drivers/hsi/clients/ssi_protocol.c:1069:5: error: 'struct net_device' has no member named 'destructor'
------------------------------------------------------------------------------- defconfigs with issues (other than build errors): 4 warnings 0 mismatches : arm-allmodconfig
-------------------------------------------------------------------------------
Errors summary: 1 1 ../drivers/hsi/clients/ssi_protocol.c:1069:5: error: 'struct net_device' has no member named 'destructor'
Warnings Summary: 4 1 ../drivers/scsi/qla2xxx/qla_init.c:6709:7: warning: format '%lx' expects argument of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Wformat=] 1 ../drivers/scsi/qla2xxx/qla_init.c:6407:7: warning: format '%lx' expects argument of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Wformat=] 1 ../drivers/mtd/nand/fsl_ifc_nand.c:696:7: warning: unused variable 'res' [-Wunused-variable] 1 ../drivers/i2c/i2c-stub.c:18:0: warning: "DEBUG" redefined
=============================================================================== Detailed per-defconfig build reports below:
------------------------------------------------------------------------------- arm-allmodconfig : FAIL, 1 errors, 4 warnings, 0 section mismatches
Errors: ../drivers/hsi/clients/ssi_protocol.c:1069:5: error: 'struct net_device' has no member named 'destructor'
Warnings: ../drivers/i2c/i2c-stub.c:18:0: warning: "DEBUG" redefined ../drivers/mtd/nand/fsl_ifc_nand.c:696:7: warning: unused variable 'res' [-Wunused-variable] ../drivers/scsi/qla2xxx/qla_init.c:6407:7: warning: format '%lx' expects argument of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Wformat=] ../drivers/scsi/qla2xxx/qla_init.c:6709:7: warning: format '%lx' expects argument of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Wformat=] -------------------------------------------------------------------------------
Passed with no errors, warnings or mismatches:
arm-multi_v5_defconfig arm-multi_v7_defconfig x86_64-defconfig arm-allnoconfig x86_64-allnoconfig arm-multi_v4t_defconfig
Hi Dave,
On Thu, 08 Jun 2017 10:57:50 +0100 Build bot for Mark Brown broonie@kernel.org wrote:
Tree/Branch: next-20170608 Git describe: next-20170608 Commit: e4689b9aad Add linux-next specific files for 20170608
Build Time: 0 min 12 sec
Passed: 6 / 7 ( 85.71 %) Failed: 1 / 7 ( 14.29 %)
Errors: 1 Warnings: 4 Section Mismatches: 0
Failed defconfigs: arm-allmodconfig
Errors:
arm-allmodconfig ../drivers/hsi/clients/ssi_protocol.c:1069:5: error: 'struct net_device' has no member named 'destructor'
Looks like Mark has found another one.
From: Stephen Rothwell sfr@canb.auug.org.au Date: Thu, 8 Jun 2017 20:27:04 +1000
Hi Dave,
On Thu, 08 Jun 2017 10:57:50 +0100 Build bot for Mark Brown broonie@kernel.org wrote:
Tree/Branch: next-20170608 Git describe: next-20170608 Commit: e4689b9aad Add linux-next specific files for 20170608
Build Time: 0 min 12 sec
Passed: 6 / 7 ( 85.71 %) Failed: 1 / 7 ( 14.29 %)
Errors: 1 Warnings: 4 Section Mismatches: 0
Failed defconfigs: arm-allmodconfig
Errors:
arm-allmodconfig ../drivers/hsi/clients/ssi_protocol.c:1069:5: error: 'struct net_device' has no member named 'destructor'
Looks like Mark has found another one.
This should fix it, pushed out to 'net'.
Thanks.
==================== [PATCH] hsi: Fix build regression due to netdev destructor fix.
../drivers/hsi/clients/ssi_protocol.c:1069:5: error: 'struct net_device' has no member named 'destructor'
Reported-by: Mark Brown broonie@kernel.org Reported-by: Stephen Rothwell sfr@canb.auug.org.au Signed-off-by: David S. Miller davem@davemloft.net --- drivers/hsi/clients/ssi_protocol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hsi/clients/ssi_protocol.c b/drivers/hsi/clients/ssi_protocol.c index 26b0510..93d28c0 100644 --- a/drivers/hsi/clients/ssi_protocol.c +++ b/drivers/hsi/clients/ssi_protocol.c @@ -1066,7 +1066,7 @@ static void ssip_pn_setup(struct net_device *dev) dev->addr_len = 1; dev->tx_queue_len = SSIP_TXQUEUE_LEN;
- dev->destructor = free_netdev; + dev->needs_free_netdev = true; dev->header_ops = &phonet_header_ops; }
On Thu, Jun 08, 2017 at 10:57:50AM +0100, Build bot for Mark Brown wrote:
Today's -next fails to build an ARM allmodconfig due to:
arm-allmodconfig ../drivers/hsi/clients/ssi_protocol.c:1069:5: error: 'struct net_device' has no member named 'destructor'
due to cf124db566e6 (net: Fix inconsistent teardown and release of private netdev state.) which missed this instance, presumably due to a combination of it not being in one of the normal networking driver directories and only being buildable on ARM.
Hi,
On Thu, Jun 08, 2017 at 11:32:31AM +0100, Mark Brown wrote:
On Thu, Jun 08, 2017 at 10:57:50AM +0100, Build bot for Mark Brown wrote:
Today's -next fails to build an ARM allmodconfig due to:
arm-allmodconfig ../drivers/hsi/clients/ssi_protocol.c:1069:5: error: 'struct net_device' has no member named 'destructor'
due to cf124db566e6 (net: Fix inconsistent teardown and release of private netdev state.) which missed this instance, presumably due to a combination of it not being in one of the normal networking driver directories and only being buildable on ARM.
I assume, that this will be fixed via the net tree. If you Cc me on updated/new patch I will provide Acked-by.
-- Sebastian
From: Sebastian Reichel sre@kernel.org Date: Thu, 8 Jun 2017 13:33:26 +0200
Hi,
On Thu, Jun 08, 2017 at 11:32:31AM +0100, Mark Brown wrote:
On Thu, Jun 08, 2017 at 10:57:50AM +0100, Build bot for Mark Brown wrote:
Today's -next fails to build an ARM allmodconfig due to:
arm-allmodconfig ../drivers/hsi/clients/ssi_protocol.c:1069:5: error: 'struct net_device' has no member named 'destructor'
due to cf124db566e6 (net: Fix inconsistent teardown and release of private netdev state.) which missed this instance, presumably due to a combination of it not being in one of the normal networking driver directories and only being buildable on ARM.
I assume, that this will be fixed via the net tree. If you Cc me on updated/new patch I will provide Acked-by.
It is fixed in the 'net' tree, don't worry about it :-)
Hi,
On Thu, Jun 08, 2017 at 10:17:57AM -0400, David Miller wrote:
On Thu, Jun 08, 2017 at 11:32:31AM +0100, Mark Brown wrote:
On Thu, Jun 08, 2017 at 10:57:50AM +0100, Build bot for Mark Brown wrote:
Today's -next fails to build an ARM allmodconfig due to:
arm-allmodconfig ../drivers/hsi/clients/ssi_protocol.c:1069:5: error: 'struct net_device' has no member named 'destructor'
due to cf124db566e6 (net: Fix inconsistent teardown and release of private netdev state.) which missed this instance, presumably due to a combination of it not being in one of the normal networking driver directories and only being buildable on ARM.
I assume, that this will be fixed via the net tree. If you Cc me on updated/new patch I will provide Acked-by.
It is fixed in the 'net' tree, don't worry about it :-)
https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=ed6...
Looks good, thanks.
-- Sebastian
linaro-kernel@lists.linaro.org