From: Mark Brown broonie@linaro.org
Rather than requiring each board to explicitly disable the SPI controllers it is not using instead require boards to enable those that they are using. This is less work overall since normally at most one of the controllers is in use and avoids issues caused by inappropriate pinmuxing.
Signed-off-by: Mark Brown broonie@linaro.org Acked-by: Tomasz Figa t.figa@samsung.com --- arch/arm/boot/dts/cros5250-common.dtsi | 9 +-------- arch/arm/boot/dts/exynos5250-arndale.dts | 12 ------------ arch/arm/boot/dts/exynos5250-smdk5250.dts | 6 ++---- arch/arm/boot/dts/exynos5250.dtsi | 3 +++ 4 files changed, 6 insertions(+), 24 deletions(-)
diff --git a/arch/arm/boot/dts/cros5250-common.dtsi b/arch/arm/boot/dts/cros5250-common.dtsi index dc259e8b8a73..0fcca2930c61 100644 --- a/arch/arm/boot/dts/cros5250-common.dtsi +++ b/arch/arm/boot/dts/cros5250-common.dtsi @@ -286,19 +286,12 @@ }; };
- spi_0: spi@12d20000 { - status = "disabled"; - }; - spi_1: spi@12d30000 { + status = "okay"; samsung,spi-src-clk = <0>; num-cs = <1>; };
- spi_2: spi@12d40000 { - status = "disabled"; - }; - hdmi { hpd-gpio = <&gpx3 7 0>; }; diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts index 684527087aa4..0385b58116ec 100644 --- a/arch/arm/boot/dts/exynos5250-arndale.dts +++ b/arch/arm/boot/dts/exynos5250-arndale.dts @@ -434,18 +434,6 @@ status = "okay"; };
- spi_0: spi@12d20000 { - status = "disabled"; - }; - - spi_1: spi@12d30000 { - status = "disabled"; - }; - - spi_2: spi@12d40000 { - status = "disabled"; - }; - gpio_keys { compatible = "gpio-keys";
diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts index f86d56760a45..5d0395e07eee 100644 --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts @@ -189,6 +189,8 @@ };
spi_1: spi@12d30000 { + status = "okay"; + w25q80bw@0 { #address-cells = <1>; #size-cells = <1>; @@ -214,10 +216,6 @@ }; };
- spi_2: spi@12d40000 { - status = "disabled"; - }; - hdmi { hpd-gpio = <&gpx3 7 0>; }; diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi index 9db5047812f3..9b58532854e1 100644 --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -349,6 +349,7 @@
spi_0: spi@12d20000 { compatible = "samsung,exynos4210-spi"; + status = "disabled"; reg = <0x12d20000 0x100>; interrupts = <0 66 0>; dmas = <&pdma0 5 @@ -364,6 +365,7 @@
spi_1: spi@12d30000 { compatible = "samsung,exynos4210-spi"; + status = "disabled"; reg = <0x12d30000 0x100>; interrupts = <0 67 0>; dmas = <&pdma1 5 @@ -379,6 +381,7 @@
spi_2: spi@12d40000 { compatible = "samsung,exynos4210-spi"; + status = "disabled"; reg = <0x12d40000 0x100>; interrupts = <0 68 0>; dmas = <&pdma0 7
From: Mark Brown broonie@linaro.org
Ensure that unused I2C controllers are not activated, causing problems due to inappropriate pinmuxing or similar, by marking the controllers as disabled by default and requiring boards to explicitly enable those that are in use.
Signed-off-by: Mark Brown broonie@linaro.org Acked-by: Tomasz Figa t.figa@samsung.com --- arch/arm/boot/dts/cros5250-common.dtsi | 12 ++++++++---- arch/arm/boot/dts/exynos5250-arndale.dts | 32 ++++++++----------------------- arch/arm/boot/dts/exynos5250-smdk5250.dts | 25 +++++------------------- arch/arm/boot/dts/exynos5250.dtsi | 10 ++++++++++ 4 files changed, 31 insertions(+), 48 deletions(-)
diff --git a/arch/arm/boot/dts/cros5250-common.dtsi b/arch/arm/boot/dts/cros5250-common.dtsi index 0fcca2930c61..7dbba0859a1d 100644 --- a/arch/arm/boot/dts/cros5250-common.dtsi +++ b/arch/arm/boot/dts/cros5250-common.dtsi @@ -30,6 +30,7 @@ };
i2c@12C60000 { + status = "okay"; samsung,i2c-sda-delay = <100>; samsung,i2c-max-bus-freq = <378000>;
@@ -173,6 +174,7 @@ };
i2c@12C70000 { + status = "okay"; samsung,i2c-sda-delay = <100>; samsung,i2c-max-bus-freq = <378000>;
@@ -186,6 +188,7 @@ };
i2c@12C80000 { + status = "okay"; samsung,i2c-sda-delay = <100>; samsung,i2c-max-bus-freq = <66000>;
@@ -196,30 +199,31 @@ };
i2c@12C90000 { + status = "okay"; samsung,i2c-sda-delay = <100>; samsung,i2c-max-bus-freq = <66000>; };
i2c@12CA0000 { + status = "okay"; samsung,i2c-sda-delay = <100>; samsung,i2c-max-bus-freq = <66000>; };
i2c@12CB0000 { + status = "okay"; samsung,i2c-sda-delay = <100>; samsung,i2c-max-bus-freq = <66000>; };
- i2c@12CC0000 { - status = "disabled"; - }; - i2c@12CD0000 { + status = "okay"; samsung,i2c-sda-delay = <100>; samsung,i2c-max-bus-freq = <66000>; };
i2c@12CE0000 { + status = "okay"; samsung,i2c-sda-delay = <100>; samsung,i2c-max-bus-freq = <378000>;
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts index 0385b58116ec..6fbe89fd7d41 100644 --- a/arch/arm/boot/dts/exynos5250-arndale.dts +++ b/arch/arm/boot/dts/exynos5250-arndale.dts @@ -34,6 +34,7 @@ samsung,i2c-sda-delay = <100>; samsung,i2c-max-bus-freq = <20000>; samsung,i2c-slave-addr = <0x66>; + status = "okay";
s5m8767_pmic@66 { compatible = "samsung,s5m8767-pmic"; @@ -319,11 +320,9 @@ }; };
- i2c@12C70000 { - status = "disabled"; - }; - i2c@12C80000 { + status = "okay"; + samsung,i2c-sda-delay = <100>; samsung,i2c-max-bus-freq = <66000>; samsung,i2c-slave-addr = <0x50>; @@ -335,7 +334,10 @@ };
i2c@12C90000 { + status = "okay"; + wm1811a@1a { + compatible = "wlf,wm1811"; reg = <0x1a>;
@@ -353,23 +355,9 @@ }; };
- i2c@12CA0000 { - status = "disabled"; - }; - - i2c@12CB0000 { - status = "disabled"; - }; - - i2c@12CC0000 { - status = "disabled"; - }; - - i2c@12CD0000 { - status = "disabled"; - }; - i2c@12CE0000 { + status = "okay"; + samsung,i2c-sda-delay = <100>; samsung,i2c-max-bus-freq = <66000>; samsung,i2c-slave-addr = <0x38>; @@ -380,10 +368,6 @@ }; };
- i2c@121D0000 { - status = "disabled"; - }; - dwmmc_0: dwmmc0@12200000 { num-slots = <1>; supports-highspeed; diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts index 5d0395e07eee..a17b1a0a8abc 100644 --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts @@ -30,6 +30,7 @@ i2c@12C60000 { samsung,i2c-sda-delay = <100>; samsung,i2c-max-bus-freq = <20000>; + status = "okay";
eeprom@50 { compatible = "samsung,s524ad0xd1"; @@ -64,6 +65,7 @@ i2c@12C70000 { samsung,i2c-sda-delay = <100>; samsung,i2c-max-bus-freq = <20000>; + status = "okay";
eeprom@51 { compatible = "samsung,s524ad0xd1"; @@ -89,6 +91,7 @@ samsung,i2c-sda-delay = <100>; samsung,i2c-max-bus-freq = <40000>; samsung,i2c-slave-addr = <0x38>; + status = "okay";
sata-phy { compatible = "samsung,sata-phy"; @@ -103,6 +106,7 @@ i2c@12C80000 { samsung,i2c-sda-delay = <100>; samsung,i2c-max-bus-freq = <66000>; + status = "okay";
hdmiddc@50 { compatible = "samsung,exynos4210-hdmiddc"; @@ -110,29 +114,10 @@ }; };
- i2c@12C90000 { - status = "disabled"; - }; - - i2c@12CA0000 { - status = "disabled"; - }; - - i2c@12CB0000 { - status = "disabled"; - }; - - i2c@12CC0000 { - status = "disabled"; - }; - - i2c@12CD0000 { - status = "disabled"; - }; - i2c@12CE0000 { samsung,i2c-sda-delay = <100>; samsung,i2c-max-bus-freq = <66000>; + status = "okay";
hdmiphy@38 { compatible = "samsung,exynos4212-hdmiphy"; diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi index 9b58532854e1..3a4454620f6b 100644 --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -242,6 +242,7 @@ clock-names = "i2c"; pinctrl-names = "default"; pinctrl-0 = <&i2c0_bus>; + status = "disabled"; };
i2c_1: i2c@12C70000 { @@ -254,6 +255,7 @@ clock-names = "i2c"; pinctrl-names = "default"; pinctrl-0 = <&i2c1_bus>; + status = "disabled"; };
i2c_2: i2c@12C80000 { @@ -266,6 +268,7 @@ clock-names = "i2c"; pinctrl-names = "default"; pinctrl-0 = <&i2c2_bus>; + status = "disabled"; };
i2c_3: i2c@12C90000 { @@ -278,6 +281,7 @@ clock-names = "i2c"; pinctrl-names = "default"; pinctrl-0 = <&i2c3_bus>; + status = "disabled"; };
i2c_4: i2c@12CA0000 { @@ -290,6 +294,7 @@ clock-names = "i2c"; pinctrl-names = "default"; pinctrl-0 = <&i2c4_bus>; + status = "disabled"; };
i2c_5: i2c@12CB0000 { @@ -302,6 +307,7 @@ clock-names = "i2c"; pinctrl-names = "default"; pinctrl-0 = <&i2c5_bus>; + status = "disabled"; };
i2c_6: i2c@12CC0000 { @@ -314,6 +320,7 @@ clock-names = "i2c"; pinctrl-names = "default"; pinctrl-0 = <&i2c6_bus>; + status = "disabled"; };
i2c_7: i2c@12CD0000 { @@ -326,6 +333,7 @@ clock-names = "i2c"; pinctrl-names = "default"; pinctrl-0 = <&i2c7_bus>; + status = "disabled"; };
i2c_8: i2c@12CE0000 { @@ -336,6 +344,7 @@ #size-cells = <0>; clocks = <&clock 302>; clock-names = "i2c"; + status = "disabled"; };
i2c@121D0000 { @@ -345,6 +354,7 @@ #size-cells = <0>; clocks = <&clock 288>; clock-names = "i2c"; + status = "disabled"; };
spi_0: spi@12d20000 {
From: Mark Brown broonie@linaro.org
Make it easier to notice the common file for ChromeOS devices based on the Exynos5250 by giving it the exynos5250 prefix that the boards have.
Signed-off-by: Mark Brown broonie@linaro.org Acked-by: Tomasz Figa t.figa@samsung.com --- arch/arm/boot/dts/{cros5250-common.dtsi => exynos5250-cros-common.dtsi} | 0 arch/arm/boot/dts/exynos5250-snow.dts | 2 +- 2 files changed, 1 insertion(+), 1 deletion(-) rename arch/arm/boot/dts/{cros5250-common.dtsi => exynos5250-cros-common.dtsi} (100%)
diff --git a/arch/arm/boot/dts/cros5250-common.dtsi b/arch/arm/boot/dts/exynos5250-cros-common.dtsi similarity index 100% rename from arch/arm/boot/dts/cros5250-common.dtsi rename to arch/arm/boot/dts/exynos5250-cros-common.dtsi diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts index fd711e245e8d..7e2669c6f7f5 100644 --- a/arch/arm/boot/dts/exynos5250-snow.dts +++ b/arch/arm/boot/dts/exynos5250-snow.dts @@ -10,7 +10,7 @@
/dts-v1/; #include "exynos5250.dtsi" -#include "cros5250-common.dtsi" +#include "exynos5250-cros-common.dtsi"
/ { model = "Google Snow";
On 11/25/13 21:15, Mark Brown wrote:
From: Mark Brownbroonie@linaro.org
Make it easier to notice the common file for ChromeOS devices based on the Exynos5250 by giving it the exynos5250 prefix that the boards have.
Signed-off-by: Mark Brownbroonie@linaro.org Acked-by: Tomasz Figat.figa@samsung.com
arch/arm/boot/dts/{cros5250-common.dtsi => exynos5250-cros-common.dtsi} | 0 arch/arm/boot/dts/exynos5250-snow.dts | 2 +- 2 files changed, 1 insertion(+), 1 deletion(-) rename arch/arm/boot/dts/{cros5250-common.dtsi => exynos5250-cros-common.dtsi} (100%)
diff --git a/arch/arm/boot/dts/cros5250-common.dtsi b/arch/arm/boot/dts/exynos5250-cros-common.dtsi similarity index 100% rename from arch/arm/boot/dts/cros5250-common.dtsi rename to arch/arm/boot/dts/exynos5250-cros-common.dtsi diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts index fd711e245e8d..7e2669c6f7f5 100644 --- a/arch/arm/boot/dts/exynos5250-snow.dts +++ b/arch/arm/boot/dts/exynos5250-snow.dts @@ -10,7 +10,7 @@
/dts-v1/; #include "exynos5250.dtsi" -#include "cros5250-common.dtsi" +#include "exynos5250-cros-common.dtsi"
/ { model = "Google Snow";
+ Doug and Olof.
Doug and Olof,
I need your ack on this. How do you think?
Thanks, Kukjin
On 12/21/13 08:09, Kukjin Kim wrote:
On 11/25/13 21:15, Mark Brown wrote:
From: Mark Brownbroonie@linaro.org
Make it easier to notice the common file for ChromeOS devices based on the Exynos5250 by giving it the exynos5250 prefix that the boards have.
Signed-off-by: Mark Brownbroonie@linaro.org Acked-by: Tomasz Figat.figa@samsung.com
arch/arm/boot/dts/{cros5250-common.dtsi => exynos5250-cros-common.dtsi} | 0 arch/arm/boot/dts/exynos5250-snow.dts | 2 +- 2 files changed, 1 insertion(+), 1 deletion(-) rename arch/arm/boot/dts/{cros5250-common.dtsi => exynos5250-cros-common.dtsi} (100%)
diff --git a/arch/arm/boot/dts/cros5250-common.dtsi b/arch/arm/boot/dts/exynos5250-cros-common.dtsi similarity index 100% rename from arch/arm/boot/dts/cros5250-common.dtsi rename to arch/arm/boot/dts/exynos5250-cros-common.dtsi diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts index fd711e245e8d..7e2669c6f7f5 100644 --- a/arch/arm/boot/dts/exynos5250-snow.dts +++ b/arch/arm/boot/dts/exynos5250-snow.dts @@ -10,7 +10,7 @@
/dts-v1/; #include "exynos5250.dtsi" -#include "cros5250-common.dtsi" +#include "exynos5250-cros-common.dtsi"
/ { model = "Google Snow";
- Doug and Olof.
Oops, I missed. Again +
Doug and Olof,
I need your ack on this. How do you think?
One more, I've applied Mark's 1/3 and 2/3 patches.
Thanks, Kukjin
Kukjin,
On Fri, Dec 20, 2013 at 3:37 PM, Kukjin Kim kgene.kim@samsung.com wrote:
On 12/21/13 08:09, Kukjin Kim wrote:
On 11/25/13 21:15, Mark Brown wrote:
From: Mark Brownbroonie@linaro.org
Make it easier to notice the common file for ChromeOS devices based on the Exynos5250 by giving it the exynos5250 prefix that the boards have.
Signed-off-by: Mark Brownbroonie@linaro.org Acked-by: Tomasz Figat.figa@samsung.com
The rename makes a lot of sense to me.
Reviewed-by: Doug Anderson dianders@chromium.org
On 12/21/13 09:57, Doug Anderson wrote:
Kukjin,
On Fri, Dec 20, 2013 at 3:37 PM, Kukjin Kimkgene.kim@samsung.com wrote:
On 12/21/13 08:09, Kukjin Kim wrote:
On 11/25/13 21:15, Mark Brown wrote:
From: Mark Brownbroonie@linaro.org
Make it easier to notice the common file for ChromeOS devices based on the Exynos5250 by giving it the exynos5250 prefix that the boards have.
Signed-off-by: Mark Brownbroonie@linaro.org Acked-by: Tomasz Figat.figa@samsung.com
The rename makes a lot of sense to me.
Reviewed-by: Doug Andersondianders@chromium.org
I've applied.
Thanks and Merry Christmas :-)
- Kukjin
Hi Kukjin,
On Monday 25 of November 2013 12:15:08 Mark Brown wrote:
From: Mark Brown broonie@linaro.org
Rather than requiring each board to explicitly disable the SPI controllers it is not using instead require boards to enable those that they are using. This is less work overall since normally at most one of the controllers is in use and avoids issues caused by inappropriate pinmuxing.
Signed-off-by: Mark Brown broonie@linaro.org Acked-by: Tomasz Figa t.figa@samsung.com
arch/arm/boot/dts/cros5250-common.dtsi | 9 +-------- arch/arm/boot/dts/exynos5250-arndale.dts | 12 ------------ arch/arm/boot/dts/exynos5250-smdk5250.dts | 6 ++---- arch/arm/boot/dts/exynos5250.dtsi | 3 +++ 4 files changed, 6 insertions(+), 24 deletions(-)
Seems like you have missed this series. Could you apply it?
Best regards, Tomasz
On 12/10/13 00:23, Tomasz Figa wrote:
Hi Kukjin,
Hi,
On Monday 25 of November 2013 12:15:08 Mark Brown wrote:
From: Mark Brownbroonie@linaro.org
Rather than requiring each board to explicitly disable the SPI controllers it is not using instead require boards to enable those that they are using. This is less work overall since normally at most one of the controllers is in use and avoids issues caused by inappropriate pinmuxing.
Signed-off-by: Mark Brownbroonie@linaro.org Acked-by: Tomasz Figat.figa@samsung.com
arch/arm/boot/dts/cros5250-common.dtsi | 9 +-------- arch/arm/boot/dts/exynos5250-arndale.dts | 12 ------------ arch/arm/boot/dts/exynos5250-smdk5250.dts | 6 ++---- arch/arm/boot/dts/exynos5250.dtsi | 3 +++ 4 files changed, 6 insertions(+), 24 deletions(-)
Seems like you have missed this series. Could you apply it?
Yeah, thanks for your gentle reminder.
+ Doug and Olof
BTW, Doug and Olof, are you OK with changing the name of cros5250-common DT file? Basically, I agree with Mark's patch.
- Kukjin
Hi,
On Mon, Dec 9, 2013 at 1:07 PM, Kukjin Kim kgene.kim@samsung.com wrote:
On 12/10/13 00:23, Tomasz Figa wrote:
Hi Kukjin,
Hi,
On Monday 25 of November 2013 12:15:08 Mark Brown wrote:
From: Mark Brownbroonie@linaro.org
Rather than requiring each board to explicitly disable the SPI controllers it is not using instead require boards to enable those that they are using. This is less work overall since normally at most one of the controllers is in use and avoids issues caused by inappropriate pinmuxing.
Signed-off-by: Mark Brownbroonie@linaro.org Acked-by: Tomasz Figat.figa@samsung.com
arch/arm/boot/dts/cros5250-common.dtsi | 9 +-------- arch/arm/boot/dts/exynos5250-arndale.dts | 12 ------------ arch/arm/boot/dts/exynos5250-smdk5250.dts | 6 ++---- arch/arm/boot/dts/exynos5250.dtsi | 3 +++ 4 files changed, 6 insertions(+), 24 deletions(-)
Seems like you have missed this series. Could you apply it?
Yeah, thanks for your gentle reminder.
- Doug and Olof
BTW, Doug and Olof, are you OK with changing the name of cros5250-common DT file? Basically, I agree with Mark's patch.
I don't see anything that's changing a name, so perhaps I'm confused or missing something. Mark's patch looks good to me so I'll add a reviewed by...
-Doug
Hi,
On Mon, Nov 25, 2013 at 4:15 AM, Mark Brown broonie@kernel.org wrote:
From: Mark Brown broonie@linaro.org
Rather than requiring each board to explicitly disable the SPI controllers it is not using instead require boards to enable those that they are using. This is less work overall since normally at most one of the controllers is in use and avoids issues caused by inappropriate pinmuxing.
Signed-off-by: Mark Brown broonie@linaro.org Acked-by: Tomasz Figa t.figa@samsung.com
arch/arm/boot/dts/cros5250-common.dtsi | 9 +-------- arch/arm/boot/dts/exynos5250-arndale.dts | 12 ------------ arch/arm/boot/dts/exynos5250-smdk5250.dts | 6 ++---- arch/arm/boot/dts/exynos5250.dtsi | 3 +++ 4 files changed, 6 insertions(+), 24 deletions(-)
diff --git a/arch/arm/boot/dts/cros5250-common.dtsi b/arch/arm/boot/dts/cros5250-common.dtsi index dc259e8b8a73..0fcca2930c61 100644 --- a/arch/arm/boot/dts/cros5250-common.dtsi +++ b/arch/arm/boot/dts/cros5250-common.dtsi @@ -286,19 +286,12 @@ }; };
spi_0: spi@12d20000 {status = "disabled";};spi_1: spi@12d30000 {
status = "okay"; samsung,spi-src-clk = <0>; num-cs = <1>; };
spi_2: spi@12d40000 {status = "disabled";};hdmi { hpd-gpio = <&gpx3 7 0>; };diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts index 684527087aa4..0385b58116ec 100644 --- a/arch/arm/boot/dts/exynos5250-arndale.dts +++ b/arch/arm/boot/dts/exynos5250-arndale.dts @@ -434,18 +434,6 @@ status = "okay"; };
spi_0: spi@12d20000 {status = "disabled";};spi_1: spi@12d30000 {status = "disabled";};spi_2: spi@12d40000 {status = "disabled";};gpio_keys { compatible = "gpio-keys";diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts index f86d56760a45..5d0395e07eee 100644 --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts @@ -189,6 +189,8 @@ };
spi_1: spi@12d30000 {
status = "okay";w25q80bw@0 { #address-cells = <1>; #size-cells = <1>;@@ -214,10 +216,6 @@ }; };
spi_2: spi@12d40000 {status = "disabled";};hdmi { hpd-gpio = <&gpx3 7 0>; };
I'm a little surprised that I don't see removal of spi_0 on SMDK5250. When I apply your patch to ToT Linux I still see this in "exynos5250-smdk5250.dts":
spi_0: spi@12d20000 { status = "disabled"; };
Other than that things look good to me and you can add my Reviewed-by:
Reviewed-by: Doug Anderson dianders@chromium.org
-Doug
On Mon, Dec 09, 2013 at 04:57:01PM -0800, Doug Anderson wrote:
I'm a little surprised that I don't see removal of spi_0 on SMDK5250. When I apply your patch to ToT Linux I still see this in "exynos5250-smdk5250.dts":
spi_0: spi@12d20000 { status = "disabled"; };
I suspect that one went AWOL during rebasing - these have been kicking around since September. Resent with that added.
linaro-kernel@lists.linaro.org
-
Doug Anderson -
Kukjin Kim -
Mark Brown -
Tomasz Figa