The layerscape PCI host driver needs recognize ls2085a compatible when using firmware with ls2085a compatible property, otherwise the PCI bus won't be detected even though ls2085a compatible is included by the dts.
Signed-off-by: Yang Shi yang.shi@linaro.org --- drivers/pci/host/pci-layerscape.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/pci/host/pci-layerscape.c b/drivers/pci/host/pci-layerscape.c index 3923bed..c40d8b2 100644 --- a/drivers/pci/host/pci-layerscape.c +++ b/drivers/pci/host/pci-layerscape.c @@ -203,6 +203,7 @@ static const struct of_device_id ls_pcie_of_match[] = { { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata }, { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata }, { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata }, + { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata }, { }, }; MODULE_DEVICE_TABLE(of, ls_pcie_of_match);
Correct FSL folks email address to nxp.com, sorry for the inconvenience.
Regards, Yang
On 1/27/2016 9:32 AM, Yang Shi wrote:
The layerscape PCI host driver needs recognize ls2085a compatible when using firmware with ls2085a compatible property, otherwise the PCI bus won't be detected even though ls2085a compatible is included by the dts.
Signed-off-by: Yang Shi yang.shi@linaro.org
drivers/pci/host/pci-layerscape.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/pci/host/pci-layerscape.c b/drivers/pci/host/pci-layerscape.c index 3923bed..c40d8b2 100644 --- a/drivers/pci/host/pci-layerscape.c +++ b/drivers/pci/host/pci-layerscape.c @@ -203,6 +203,7 @@ static const struct of_device_id ls_pcie_of_match[] = { { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata }, { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata }, { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata },
- { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata }, { }, }; MODULE_DEVICE_TABLE(of, ls_pcie_of_match);
On Wed, Jan 27, 2016 at 10:05:40AM -0800, Shi, Yang wrote:
Correct FSL folks email address to nxp.com, sorry for the inconvenience.
Do we need some MAINTAINERS updates in addition to the ack for this patch? I see a bunch of @freescale.com addresses in MAINTAINERS.
On 1/27/2016 9:32 AM, Yang Shi wrote:
The layerscape PCI host driver needs recognize ls2085a compatible when using firmware with ls2085a compatible property, otherwise the PCI bus won't be detected even though ls2085a compatible is included by the dts.
Signed-off-by: Yang Shi yang.shi@linaro.org
drivers/pci/host/pci-layerscape.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/pci/host/pci-layerscape.c b/drivers/pci/host/pci-layerscape.c index 3923bed..c40d8b2 100644 --- a/drivers/pci/host/pci-layerscape.c +++ b/drivers/pci/host/pci-layerscape.c @@ -203,6 +203,7 @@ static const struct of_device_id ls_pcie_of_match[] = { { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata }, { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata }, { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata },
- { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata }, { },
}; MODULE_DEVICE_TABLE(of, ls_pcie_of_match);
On 2/4/2016 2:37 PM, Bjorn Helgaas wrote:
On Wed, Jan 27, 2016 at 10:05:40AM -0800, Shi, Yang wrote:
Correct FSL folks email address to nxp.com, sorry for the inconvenience.
Do we need some MAINTAINERS updates in addition to the ack for this patch? I see a bunch of @freescale.com addresses in MAINTAINERS.
I guess so if the @freescale.com address is not valid anymore.
Thanks, Yang
On 1/27/2016 9:32 AM, Yang Shi wrote:
The layerscape PCI host driver needs recognize ls2085a compatible when using firmware with ls2085a compatible property, otherwise the PCI bus won't be detected even though ls2085a compatible is included by the dts.
Signed-off-by: Yang Shi yang.shi@linaro.org
drivers/pci/host/pci-layerscape.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/pci/host/pci-layerscape.c b/drivers/pci/host/pci-layerscape.c index 3923bed..c40d8b2 100644 --- a/drivers/pci/host/pci-layerscape.c +++ b/drivers/pci/host/pci-layerscape.c @@ -203,6 +203,7 @@ static const struct of_device_id ls_pcie_of_match[] = { { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata }, { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata }, { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata },
- { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata }, { }, }; MODULE_DEVICE_TABLE(of, ls_pcie_of_match);
From: Shi, Yang Sent: Friday, February 05, 2016 5:19 AM
On 2/4/2016 2:37 PM, Bjorn Helgaas wrote:
On Wed, Jan 27, 2016 at 10:05:40AM -0800, Shi, Yang wrote:
Correct FSL folks email address to nxp.com, sorry for the
inconvenience.
Do we need some MAINTAINERS updates in addition to the ack for this
patch?
I see a bunch of @freescale.com addresses in MAINTAINERS.
I guess so if the @freescale.com address is not valid anymore.
All @freescale.com address have shifted to @nxp.com.
Leo, Minghuan - can you kindly review this patch.
Shawn - can you take this through your tree, once Leo and Minghuan have reviewed the code.
Regards, Bhupesh
On 1/27/2016 9:32 AM, Yang Shi wrote:
The layerscape PCI host driver needs recognize ls2085a compatible when using firmware with ls2085a compatible property, otherwise the PCI bus won't be detected even though ls2085a compatible is included
by the dts.
Signed-off-by: Yang Shi yang.shi@linaro.org
drivers/pci/host/pci-layerscape.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/pci/host/pci-layerscape.c b/drivers/pci/host/pci-layerscape.c index 3923bed..c40d8b2 100644 --- a/drivers/pci/host/pci-layerscape.c +++ b/drivers/pci/host/pci-layerscape.c @@ -203,6 +203,7 @@ static const struct of_device_id
ls_pcie_of_match[] = {
{ .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata
},
{ .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata
},
{ .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata
},
- { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata }, { }, }; MODULE_DEVICE_TABLE(of, ls_pcie_of_match);
-- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
The patch is ok to me.
Thanks, Minghuan
-----Original Message----- From: Bhupesh Sharma Sent: Friday, February 05, 2016 1:36 PM To: Shi, Yang yang.shi@linaro.org; Bjorn Helgaas helgaas@kernel.org; Yang-Leo Li leoyang.li@nxp.com; shawn.guo@linaro.org Cc: Mingkai Hu mingkai.hu@nxp.com; Minghuan Lian minghuan.lian@nxp.com; bhelgaas@google.com; linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linaro-kernel@lists.linaro.org Subject: RE: [PATCH] PCI: layerscape: add ls2085a compatible
From: Shi, Yang Sent: Friday, February 05, 2016 5:19 AM
On 2/4/2016 2:37 PM, Bjorn Helgaas wrote:
On Wed, Jan 27, 2016 at 10:05:40AM -0800, Shi, Yang wrote:
Correct FSL folks email address to nxp.com, sorry for the
inconvenience.
Do we need some MAINTAINERS updates in addition to the ack for this
patch?
I see a bunch of @freescale.com addresses in MAINTAINERS.
I guess so if the @freescale.com address is not valid anymore.
All @freescale.com address have shifted to @nxp.com.
Leo, Minghuan - can you kindly review this patch.
Shawn - can you take this through your tree, once Leo and Minghuan have reviewed the code.
Regards, Bhupesh
On 1/27/2016 9:32 AM, Yang Shi wrote:
The layerscape PCI host driver needs recognize ls2085a compatible when using firmware with ls2085a compatible property, otherwise the PCI bus won't be detected even though ls2085a compatible is included
by the dts.
Signed-off-by: Yang Shi yang.shi@linaro.org
drivers/pci/host/pci-layerscape.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/pci/host/pci-layerscape.c b/drivers/pci/host/pci-layerscape.c index 3923bed..c40d8b2 100644 --- a/drivers/pci/host/pci-layerscape.c +++ b/drivers/pci/host/pci-layerscape.c @@ -203,6 +203,7 @@ static const struct of_device_id
ls_pcie_of_match[] = {
{ .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata
},
{ .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata
},
{ .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata
},
- { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata }, { }, }; MODULE_DEVICE_TABLE(of, ls_pcie_of_match);
-- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Feb 05, 2016 at 06:07:10AM +0000, Minghuan Lian wrote:
The patch is ok to me.
Thanks, I'll transform that into an ack.
Who's going to post a patch to update MAINTAINERS to fix the @freescale.com addresses? If we can get that in for v4.5, it will save some hassle.
-----Original Message----- From: Bhupesh Sharma Sent: Friday, February 05, 2016 1:36 PM To: Shi, Yang yang.shi@linaro.org; Bjorn Helgaas helgaas@kernel.org; Yang-Leo Li leoyang.li@nxp.com; shawn.guo@linaro.org Cc: Mingkai Hu mingkai.hu@nxp.com; Minghuan Lian minghuan.lian@nxp.com; bhelgaas@google.com; linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linaro-kernel@lists.linaro.org Subject: RE: [PATCH] PCI: layerscape: add ls2085a compatible
From: Shi, Yang Sent: Friday, February 05, 2016 5:19 AM
On 2/4/2016 2:37 PM, Bjorn Helgaas wrote:
On Wed, Jan 27, 2016 at 10:05:40AM -0800, Shi, Yang wrote:
Correct FSL folks email address to nxp.com, sorry for the
inconvenience.
Do we need some MAINTAINERS updates in addition to the ack for this
patch?
I see a bunch of @freescale.com addresses in MAINTAINERS.
I guess so if the @freescale.com address is not valid anymore.
All @freescale.com address have shifted to @nxp.com.
Leo, Minghuan - can you kindly review this patch.
Shawn - can you take this through your tree, once Leo and Minghuan have reviewed the code.
Regards, Bhupesh
On 1/27/2016 9:32 AM, Yang Shi wrote:
The layerscape PCI host driver needs recognize ls2085a compatible when using firmware with ls2085a compatible property, otherwise the PCI bus won't be detected even though ls2085a compatible is included
by the dts.
Signed-off-by: Yang Shi yang.shi@linaro.org
drivers/pci/host/pci-layerscape.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/pci/host/pci-layerscape.c b/drivers/pci/host/pci-layerscape.c index 3923bed..c40d8b2 100644 --- a/drivers/pci/host/pci-layerscape.c +++ b/drivers/pci/host/pci-layerscape.c @@ -203,6 +203,7 @@ static const struct of_device_id
ls_pcie_of_match[] = {
{ .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata
},
{ .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata
},
{ .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata
},
- { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata }, { }, }; MODULE_DEVICE_TABLE(of, ls_pcie_of_match);
-- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Feb 05, 2016 at 06:07:10AM +0000, Minghuan Lian wrote:
The patch is ok to me.
Thanks, I'll transform that into an ack.
Also Acked-by: Li Yang leoyang.li@nxp.com
Who's going to post a patch to update MAINTAINERS to fix the @freescale.com addresses? If we can get that in for v4.5, it will save some hassle.
The @freescale.com address can still reach us for some time(not sure how long though). I don't know if all the people want to change to an NXP company email address in MAINTAINERS or just update to a personal email address as some already did.
Regards, Leo
-----Original Message----- From: Bhupesh Sharma Sent: Friday, February 05, 2016 1:36 PM To: Shi, Yang yang.shi@linaro.org; Bjorn Helgaas helgaas@kernel.org; Yang-Leo Li leoyang.li@nxp.com; shawn.guo@linaro.org Cc: Mingkai Hu mingkai.hu@nxp.com; Minghuan Lian minghuan.lian@nxp.com; bhelgaas@google.com; linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linaro-kernel@lists.linaro.org Subject: RE: [PATCH] PCI: layerscape: add ls2085a compatible
From: Shi, Yang Sent: Friday, February 05, 2016 5:19 AM
On 2/4/2016 2:37 PM, Bjorn Helgaas wrote:
On Wed, Jan 27, 2016 at 10:05:40AM -0800, Shi, Yang wrote:
Correct FSL folks email address to nxp.com, sorry for the
inconvenience.
Do we need some MAINTAINERS updates in addition to the ack for this
patch?
I see a bunch of @freescale.com addresses in MAINTAINERS.
I guess so if the @freescale.com address is not valid anymore.
All @freescale.com address have shifted to @nxp.com.
Leo, Minghuan - can you kindly review this patch.
Shawn - can you take this through your tree, once Leo and Minghuan have reviewed the code.
Regards, Bhupesh
On 1/27/2016 9:32 AM, Yang Shi wrote: > The layerscape PCI host driver needs recognize ls2085a > compatible when using firmware with ls2085a compatible > property, otherwise the PCI bus won't be detected even though > ls2085a compatible is included
by the dts.
> > Signed-off-by: Yang Shi yang.shi@linaro.org > --- > drivers/pci/host/pci-layerscape.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/host/pci-layerscape.c > b/drivers/pci/host/pci-layerscape.c > index 3923bed..c40d8b2 100644 > --- a/drivers/pci/host/pci-layerscape.c > +++ b/drivers/pci/host/pci-layerscape.c > @@ -203,6 +203,7 @@ static const struct of_device_id
ls_pcie_of_match[] = {
> { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata
},
> { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata
},
> { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata
},
> + { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata > +}, > { }, > }; > MODULE_DEVICE_TABLE(of, ls_pcie_of_match); >
-- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Feb 05, 2016 at 05:36:28AM +0000, Bhupesh Sharma wrote:
From: Shi, Yang Sent: Friday, February 05, 2016 5:19 AM
On 2/4/2016 2:37 PM, Bjorn Helgaas wrote:
On Wed, Jan 27, 2016 at 10:05:40AM -0800, Shi, Yang wrote:
Correct FSL folks email address to nxp.com, sorry for the
inconvenience.
Do we need some MAINTAINERS updates in addition to the ack for this
patch?
I see a bunch of @freescale.com addresses in MAINTAINERS.
I guess so if the @freescale.com address is not valid anymore.
All @freescale.com address have shifted to @nxp.com.
Leo, Minghuan - can you kindly review this patch.
Shawn - can you take this through your tree, once Leo and Minghuan have reviewed the code.
This is a patch that should go through PCI subsystem tree.
Shawn
On 1/27/2016 9:32 AM, Yang Shi wrote:
The layerscape PCI host driver needs recognize ls2085a compatible when using firmware with ls2085a compatible property, otherwise the PCI bus won't be detected even though ls2085a compatible is included
by the dts.
Signed-off-by: Yang Shi yang.shi@linaro.org
drivers/pci/host/pci-layerscape.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/pci/host/pci-layerscape.c b/drivers/pci/host/pci-layerscape.c index 3923bed..c40d8b2 100644 --- a/drivers/pci/host/pci-layerscape.c +++ b/drivers/pci/host/pci-layerscape.c @@ -203,6 +203,7 @@ static const struct of_device_id
ls_pcie_of_match[] = {
{ .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata
},
{ .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata
},
{ .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata
},
- { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata }, { }, }; MODULE_DEVICE_TABLE(of, ls_pcie_of_match);
-- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
[+cc Rob, et al]
On Wed, Jan 27, 2016 at 09:32:05AM -0800, Yang Shi wrote:
The layerscape PCI host driver needs recognize ls2085a compatible when using firmware with ls2085a compatible property, otherwise the PCI bus won't be detected even though ls2085a compatible is included by the dts.
Signed-off-by: Yang Shi yang.shi@linaro.org
drivers/pci/host/pci-layerscape.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/pci/host/pci-layerscape.c b/drivers/pci/host/pci-layerscape.c index 3923bed..c40d8b2 100644 --- a/drivers/pci/host/pci-layerscape.c +++ b/drivers/pci/host/pci-layerscape.c @@ -203,6 +203,7 @@ static const struct of_device_id ls_pcie_of_match[] = { { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata }, { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata }, { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata },
- { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata },
Hmm, "fsl,ls2085a-pcie" doesn't appear in Documentation/devicetree/bindings/pci/.
Aren't we supposed to add these strings to the bindings before or at the same time we add them to drivers?
checkpatch doesn't complain though, so maybe I'm wrong about this.
{ }, }; MODULE_DEVICE_TABLE(of, ls_pcie_of_match); -- 2.0.2
-- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2/5/2016 12:38 PM, Bjorn Helgaas wrote:
[+cc Rob, et al]
On Wed, Jan 27, 2016 at 09:32:05AM -0800, Yang Shi wrote:
The layerscape PCI host driver needs recognize ls2085a compatible when using firmware with ls2085a compatible property, otherwise the PCI bus won't be detected even though ls2085a compatible is included by the dts.
Signed-off-by: Yang Shi yang.shi@linaro.org
drivers/pci/host/pci-layerscape.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/pci/host/pci-layerscape.c b/drivers/pci/host/pci-layerscape.c index 3923bed..c40d8b2 100644 --- a/drivers/pci/host/pci-layerscape.c +++ b/drivers/pci/host/pci-layerscape.c @@ -203,6 +203,7 @@ static const struct of_device_id ls_pcie_of_match[] = { { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata }, { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata }, { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata },
- { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata },
Hmm, "fsl,ls2085a-pcie" doesn't appear in Documentation/devicetree/bindings/pci/.
Aren't we supposed to add these strings to the bindings before or at the same time we add them to drivers?
The below patch will add it into dts and binding doc. I should mentioned this in the commit log.
https://patchwork.kernel.org/patch/7767061/
Thanks, Yang
checkpatch doesn't complain though, so maybe I'm wrong about this.
{ }, }; MODULE_DEVICE_TABLE(of, ls_pcie_of_match); -- 2.0.2
-- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Feb 05, 2016 at 12:45:25PM -0800, Shi, Yang wrote:
On 2/5/2016 12:38 PM, Bjorn Helgaas wrote:
[+cc Rob, et al]
On Wed, Jan 27, 2016 at 09:32:05AM -0800, Yang Shi wrote:
The layerscape PCI host driver needs recognize ls2085a compatible when using firmware with ls2085a compatible property, otherwise the PCI bus won't be detected even though ls2085a compatible is included by the dts.
Signed-off-by: Yang Shi yang.shi@linaro.org
drivers/pci/host/pci-layerscape.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/pci/host/pci-layerscape.c b/drivers/pci/host/pci-layerscape.c index 3923bed..c40d8b2 100644 --- a/drivers/pci/host/pci-layerscape.c +++ b/drivers/pci/host/pci-layerscape.c @@ -203,6 +203,7 @@ static const struct of_device_id ls_pcie_of_match[] = { { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata }, { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata }, { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata },
- { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata },
Hmm, "fsl,ls2085a-pcie" doesn't appear in Documentation/devicetree/bindings/pci/.
Aren't we supposed to add these strings to the bindings before or at the same time we add them to drivers?
The below patch will add it into dts and binding doc. I should mentioned this in the commit log.
OK. This is really annoying as a reviewer. To me, adding "fsl,ls2085a-pcie" to:
- the binding in Documentation/devicetree/bindings/pci/layerscape-pci.txt - the DT in arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi - the driver in drivers/pci/host/pci-layerscape.c
are all logically related, and it would make sense to have them all in a single patch.
But whatever. I applied this to pci/host-layerscape for v4.6.
checkpatch doesn't complain though, so maybe I'm wrong about this.
{ }, }; MODULE_DEVICE_TABLE(of, ls_pcie_of_match); -- 2.0.2
-- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
-- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
-----Original Message----- From: Bjorn Helgaas [mailto:helgaas@kernel.org] Sent: Saturday, February 06, 2016 6:25 AM To: Shi, Yang Cc: Mingkai.Hu@freescale.com; Minghuan.Lian@freescale.com; bhelgaas@google.com; linux-pci@vger.kernel.org; linux- kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linaro- kernel@lists.linaro.org; Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; Kumar Gala; devicetree@vger.kernel.org Subject: Re: [PATCH] PCI: layerscape: add ls2085a compatible
On Fri, Feb 05, 2016 at 12:45:25PM -0800, Shi, Yang wrote:
On 2/5/2016 12:38 PM, Bjorn Helgaas wrote:
[+cc Rob, et al]
On Wed, Jan 27, 2016 at 09:32:05AM -0800, Yang Shi wrote:
The layerscape PCI host driver needs recognize ls2085a compatible when using firmware with ls2085a compatible property, otherwise the PCI bus won't be detected even though ls2085a compatible is included
by the dts.
Signed-off-by: Yang Shi yang.shi@linaro.org
drivers/pci/host/pci-layerscape.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/pci/host/pci-layerscape.c b/drivers/pci/host/pci-layerscape.c index 3923bed..c40d8b2 100644 --- a/drivers/pci/host/pci-layerscape.c +++ b/drivers/pci/host/pci-layerscape.c @@ -203,6 +203,7 @@ static const struct of_device_id
ls_pcie_of_match[] = {
{ .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata }, { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata }, { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata },
- { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata },
Hmm, "fsl,ls2085a-pcie" doesn't appear in Documentation/devicetree/bindings/pci/.
Aren't we supposed to add these strings to the bindings before or at the same time we add them to drivers?
The below patch will add it into dts and binding doc. I should mentioned this in the commit log.
OK. This is really annoying as a reviewer. To me, adding "fsl,ls2085a- pcie" to:
- the binding in Documentation/devicetree/bindings/pci/layerscape-
pci.txt
- the DT in arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
- the driver in drivers/pci/host/pci-layerscape.c
are all logically related, and it would make sense to have them all in a single patch.
But whatever. I applied this to pci/host-layerscape for v4.6.
Bojon,
I have sent version3 of the patch to add strings to the bindings and dts file. https://patchwork.kernel.org/patch/8333761/
Sorry for the delayed response due to Chinese New Year holiday.
Thanks, Mingkai
linaro-kernel@lists.linaro.org
-
Bhupesh Sharma -
Bjorn Helgaas -
Minghuan Lian -
Mingkai Hu -
Shawn Guo -
Shi, Yang -
Yang Shi
-
Yang-Leo Li