Hello Andy,
I forward ported the following patches from you to linaro-2.6.39:
Author: Andy Green andy@warmcat.com Date: Thu Mar 24 21:27:29 2011 +0000
OMAP2+: add cpu id register to MAC address helper
Introduce a generic helper function that can set a MAC address using data from the OMAP unique CPU ID register.
For comparison purposes this produces a MAC address of
2e:40:70:f0:12:06
for the ethernet device on my Panda.
Signed-off-by: Andy Green andy.green@linaro.org Acked-by: Arnd Bergmann arnd@arndb.de
Author: Andy Green andy@warmcat.com Date: Thu Mar 24 21:27:38 2011 +0000
OMAP2+: PANDA: Fix up random or missing MAC addresses for eth0 and wlan0
This patch registers a network device notifier callback to set the mac addresses for the onboard network assets of Panda correctly, despite the drivers involved have used a random or all-zeros MAC address.
The technique was suggested by Alan Cox on lkml.
It works by device path so it corrects the MAC addresses even if the drivers are in modules loaded in an order that changes their interface name from usual (eg, the onboard module might be "wlan1" if there is a USB wireless stick plugged in and its module is inserted first.)
Cc: Alan Cox alan@lxorguk.ukuu.org.uk Signed-off-by: Andy Green andy.green@linaro.org Acked-by: Arnd Bergmann arnd@arndb.de
Could you please follow up with the appropriate maintainer (probably Tony Lindgren) to ensure those patches are merged upstream and not forgotten about? You may add my ACK as well.
Thanks
Nicolas
On 06/13/2011 09:14 PM, Somebody in the thread at some point said:
Hi -
I forward ported the following patches from you to linaro-2.6.39:
OMAP2+: add cpu id register to MAC address helper
OMAP2+: PANDA: Fix up random or missing MAC addresses for eth0 and wlan0
Could you please follow up with the appropriate maintainer (probably Tony Lindgren) to ensure those patches are merged upstream and not forgotten about? You may add my ACK as well.
OK. I made a small additional casting fix patch on the version on my master branch to stop a warning on the second one.
http://git.linaro.org/gitweb?p=people/andygreen/kernel-tilt.git%3Ba=patch%3B...
I'll merge that then post those two again to the lists tomorrow with your ACK.
-Andy
Andy,
Have you sent a pull-request or patch set to linux-omap? For OMAP patches, why are we leaving linux-omap out of the discussion?
Regards, Jason
On Mon, Jun 13, 2011 at 4:19 PM, "Andy Green (林安廸)" andy@warmcat.com wrote:
On 06/13/2011 09:14 PM, Somebody in the thread at some point said:
Hi -
I forward ported the following patches from you to linaro-2.6.39:
OMAP2+: add cpu id register to MAC address helper
OMAP2+: PANDA: Fix up random or missing MAC addresses for eth0 and wlan0
Could you please follow up with the appropriate maintainer (probably Tony Lindgren) to ensure those patches are merged upstream and not forgotten about? You may add my ACK as well.
OK. I made a small additional casting fix patch on the version on my master branch to stop a warning on the second one.
http://git.linaro.org/gitweb?p=people/andygreen/kernel-tilt.git%3Ba=patch%3B...
I'll merge that then post those two again to the lists tomorrow with your ACK.
-Andy
linaro-kernel mailing list linaro-kernel@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-kernel
On 06/17/2011 01:22 PM, Somebody in the thread at some point said:
Hi -
Have you sent a pull-request or patch set to linux-omap? For OMAP
Yes.
patches, why are we leaving linux-omap out of the discussion?
linux-omap is not being left out of any discussion. I sent these patches to the relevant lists on 24th March -->
http://www.mail-archive.com/linux-omap@vger.kernel.org/msg47365.html
Currently I'm under a mild DoS with other stuff to take care about, I will resend them to have another go shortly.
If folks think this code belongs elsewhere in the tree, that's fine by me if they'd like to suggest where and support it if and when it migrates there.
-Andy
linaro-kernel@lists.linaro.org