This patch series adds support for DP on Exynos5250 based Arndale Board
Is based on branch "for-next" http://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
Vikas Sajjan (3): ARM: dts: Add DT node for DP controller for Arndale Board ARM: dts: Add clock provider information for DP controller in Exynos5250 SoC ARM: dts: Add display timing node to exynos5250-arndale.dts
arch/arm/boot/dts/exynos5250-arndale.dts | 26 ++++++++++++++++++++++++++ arch/arm/boot/dts/exynos5250.dtsi | 2 ++ 2 files changed, 28 insertions(+)
Add DT node for DP controller to exynos5250 based Arndale Board
Signed-off-by: Vikas Sajjan vikas.sajjan@linaro.org --- arch/arm/boot/dts/exynos5250-arndale.dts | 10 ++++++++++ 1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts index 02cfc76..f68b820 100644 --- a/arch/arm/boot/dts/exynos5250-arndale.dts +++ b/arch/arm/boot/dts/exynos5250-arndale.dts @@ -449,4 +449,14 @@ clock-frequency = <24000000>; }; }; + + dp-controller { + samsung,color-space = <0>; + samsung,dynamic-range = <0>; + samsung,ycbcr-coeff = <0>; + samsung,color-depth = <1>; + samsung,link-rate = <0x0a>; + samsung,lane-count = <4>; + }; + };
On Wednesday, May 08, 2013 3:02 PM, Vikas Sajjan wrote:
Add DT node for DP controller to exynos5250 based Arndale Board
Signed-off-by: Vikas Sajjan vikas.sajjan@linaro.org
Hi Vikas Sajjan,
Reviewed-by: Jingoo Han jg1.han@samsung.com
Best regards, Jingoo Han
arch/arm/boot/dts/exynos5250-arndale.dts | 10 ++++++++++ 1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts index 02cfc76..f68b820 100644 --- a/arch/arm/boot/dts/exynos5250-arndale.dts +++ b/arch/arm/boot/dts/exynos5250-arndale.dts @@ -449,4 +449,14 @@ clock-frequency = <24000000>; }; };
- dp-controller {
samsung,color-space = <0>;samsung,dynamic-range = <0>;samsung,ycbcr-coeff = <0>;samsung,color-depth = <1>;samsung,link-rate = <0x0a>;samsung,lane-count = <4>;- };
};
1.7.9.5
-- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Jingoo Han wrote:
On Wednesday, May 08, 2013 3:02 PM, Vikas Sajjan wrote:
Add DT node for DP controller to exynos5250 based Arndale Board
Signed-off-by: Vikas Sajjan vikas.sajjan@linaro.org
Hi Vikas Sajjan,
Reviewed-by: Jingoo Han jg1.han@samsung.com
Applied, thanks.
- Kukjin
Best regards, Jingoo Han
arch/arm/boot/dts/exynos5250-arndale.dts | 10 ++++++++++ 1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts
b/arch/arm/boot/dts/exynos5250-arndale.dts
index 02cfc76..f68b820 100644 --- a/arch/arm/boot/dts/exynos5250-arndale.dts +++ b/arch/arm/boot/dts/exynos5250-arndale.dts @@ -449,4 +449,14 @@ clock-frequency = <24000000>; }; };
- dp-controller {
samsung,color-space = <0>;samsung,dynamic-range = <0>;samsung,ycbcr-coeff = <0>;samsung,color-depth = <1>;samsung,link-rate = <0x0a>;samsung,lane-count = <4>;- };
};
1.7.9.5
-- To unsubscribe from this list: send the line "unsubscribe linux-samsung-
soc" in
the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Kukjin Kim wrote:
Jingoo Han wrote:
On Wednesday, May 08, 2013 3:02 PM, Vikas Sajjan wrote:
Add DT node for DP controller to exynos5250 based Arndale Board
Signed-off-by: Vikas Sajjan vikas.sajjan@linaro.org
Hi Vikas Sajjan,
Reviewed-by: Jingoo Han jg1.han@samsung.com
Applied, thanks.
Ooops, already v2 series in my tree :-(
- Kukjin
Best regards, Jingoo Han
arch/arm/boot/dts/exynos5250-arndale.dts | 10 ++++++++++ 1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts
b/arch/arm/boot/dts/exynos5250-arndale.dts
index 02cfc76..f68b820 100644 --- a/arch/arm/boot/dts/exynos5250-arndale.dts +++ b/arch/arm/boot/dts/exynos5250-arndale.dts @@ -449,4 +449,14 @@ clock-frequency = <24000000>; }; };
- dp-controller {
samsung,color-space = <0>;samsung,dynamic-range = <0>;samsung,ycbcr-coeff = <0>;samsung,color-depth = <1>;samsung,link-rate = <0x0a>;samsung,lane-count = <4>;- };
};
1.7.9.5
-- To unsubscribe from this list: send the line "unsubscribe linux-
samsung-
soc" in
the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Adds clock provider information for DP controller required by CCF.
Signed-off-by: Vikas Sajjan vikas.sajjan@linaro.org Signed-off-by: Arun Kumar K arun.kk@samsung.com --- arch/arm/boot/dts/exynos5250.dtsi | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi index 4bd9e9c..2773d22 100644 --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -651,6 +651,8 @@ reg = <0x145b0000 0x1000>; interrupts = <10 3>; interrupt-parent = <&combiner>; + clocks = <&clock 342>; + clock-names = "dp"; #address-cells = <1>; #size-cells = <0>;
On Wednesday, May 08, 2013 3:02 PM, Vikas Sajjan wrote:
Adds clock provider information for DP controller required by CCF.
Signed-off-by: Vikas Sajjan vikas.sajjan@linaro.org Signed-off-by: Arun Kumar K arun.kk@samsung.com
Hi Vikas Sajjan,
Acked-by: Jingoo Han jg1.han@samsung.com
Best regards, Jingoo Han
arch/arm/boot/dts/exynos5250.dtsi | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi index 4bd9e9c..2773d22 100644 --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -651,6 +651,8 @@ reg = <0x145b0000 0x1000>; interrupts = <10 3>; interrupt-parent = <&combiner>;
clocks = <&clock 342>;clock-names = "dp";-- 1.7.9.5
-- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Jingoo Han wrote:
On Wednesday, May 08, 2013 3:02 PM, Vikas Sajjan wrote:
Adds clock provider information for DP controller required by CCF.
Signed-off-by: Vikas Sajjan vikas.sajjan@linaro.org Signed-off-by: Arun Kumar K arun.kk@samsung.com
Hi Vikas Sajjan,
Acked-by: Jingoo Han jg1.han@samsung.com
Applied, thanks.
- Kukjin
Best regards, Jingoo Han
arch/arm/boot/dts/exynos5250.dtsi | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi
b/arch/arm/boot/dts/exynos5250.dtsi
index 4bd9e9c..2773d22 100644 --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -651,6 +651,8 @@ reg = <0x145b0000 0x1000>; interrupts = <10 3>; interrupt-parent = <&combiner>;
clocks = <&clock 342>;clock-names = "dp";-- 1.7.9.5
-- To unsubscribe from this list: send the line "unsubscribe linux-samsung-
soc" in
the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Adds display timing node for a DP panel to Arndale Board DTS file
Signed-off-by: Vikas Sajjan vikas.sajjan@linaro.org --- arch/arm/boot/dts/exynos5250-arndale.dts | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts index f68b820..c831a5c 100644 --- a/arch/arm/boot/dts/exynos5250-arndale.dts +++ b/arch/arm/boot/dts/exynos5250-arndale.dts @@ -459,4 +459,20 @@ samsung,lane-count = <4>; };
+ display-timings { + native-mode = <&timing0>; + timing0: timing@0 { + /* 2560x1600 DP panel */ + clock-frequency = <50000>; + hactive = <2560>; + vactive = <1600>; + hfront-porch = <48>; + hback-porch = <80>; + hsync-len = <32>; + vback-porch = <16>; + vfront-porch = <8>; + vsync-len = <6>; + }; + }; + };
Hi Vikas,
On Wednesday 08 of May 2013 11:31:34 Vikas Sajjan wrote:
Adds display timing node for a DP panel to Arndale Board DTS file
Signed-off-by: Vikas Sajjan vikas.sajjan@linaro.org
arch/arm/boot/dts/exynos5250-arndale.dts | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts index f68b820..c831a5c 100644 --- a/arch/arm/boot/dts/exynos5250-arndale.dts +++ b/arch/arm/boot/dts/exynos5250-arndale.dts @@ -459,4 +459,20 @@ samsung,lane-count = <4>; };
- display-timings {
native-mode = <&timing0>;timing0: timing@0 {/* 2560x1600 DP panel */clock-frequency = <50000>;hactive = <2560>;vactive = <1600>;hfront-porch = <48>;hback-porch = <80>;hsync-len = <32>;vback-porch = <16>;vfront-porch = <8>;vsync-len = <6>;};- };
What display are those timings used for? Shouldn't they be placed inside node of that display?
Best regards, Tomasz
Hi Tomasz,
On 10 May 2013 05:35, Tomasz Figa tomasz.figa@gmail.com wrote:
Hi Vikas,
On Wednesday 08 of May 2013 11:31:34 Vikas Sajjan wrote:
Adds display timing node for a DP panel to Arndale Board DTS file
Signed-off-by: Vikas Sajjan vikas.sajjan@linaro.org
arch/arm/boot/dts/exynos5250-arndale.dts | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts index f68b820..c831a5c 100644 --- a/arch/arm/boot/dts/exynos5250-arndale.dts +++ b/arch/arm/boot/dts/exynos5250-arndale.dts @@ -459,4 +459,20 @@ samsung,lane-count = <4>; };
display-timings {native-mode = <&timing0>;timing0: timing@0 {/* 2560x1600 DP panel */clock-frequency = <50000>;hactive = <2560>;vactive = <1600>;hfront-porch = <48>;hback-porch = <80>;hsync-len = <32>;vback-porch = <16>;vfront-porch = <8>;vsync-len = <6>;};};What display are those timings used for? Shouldn't they be placed inside node of that display?
This timing information will be used parsed by the FIMD probe with the help of "Video Helper function" as done in this link
https://git.kernel.org/cgit/linux/kernel/git/daeinki/drm-exynos.git/commit/?...
Please refer to this patch which is used for exynos4412-origen and exynos5250-smdk5250 respectively in similar way
https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/commit/...
https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/commit/...
Best regards,
Tomasz
Hi Tomasz,
On 10 May 2013 08:25, Vikas Sajjan vikas.sajjan@linaro.org wrote:
Hi Tomasz,
On 10 May 2013 05:35, Tomasz Figa tomasz.figa@gmail.com wrote:
Hi Vikas,
On Wednesday 08 of May 2013 11:31:34 Vikas Sajjan wrote:
Adds display timing node for a DP panel to Arndale Board DTS file
Signed-off-by: Vikas Sajjan vikas.sajjan@linaro.org
arch/arm/boot/dts/exynos5250-arndale.dts | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts index f68b820..c831a5c 100644 --- a/arch/arm/boot/dts/exynos5250-arndale.dts +++ b/arch/arm/boot/dts/exynos5250-arndale.dts @@ -459,4 +459,20 @@ samsung,lane-count = <4>; };
display-timings {native-mode = <&timing0>;timing0: timing@0 {/* 2560x1600 DP panel */clock-frequency = <50000>;hactive = <2560>;vactive = <1600>;hfront-porch = <48>;hback-porch = <80>;hsync-len = <32>;vback-porch = <16>;vfront-porch = <8>;vsync-len = <6>;};};What display are those timings used for? Shouldn't they be placed inside node of that display?
This timing information will be used parsed by the FIMD probe with the
help of "Video Helper function" as done in this link
https://git.kernel.org/cgit/linux/kernel/git/daeinki/drm-exynos.git/commit/?...
Please refer to this patch which is used for exynos4412-origen and exynos5250-smdk5250 respectively in similar way
https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/commit/...
https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/commit/...
And also you can refer to Documentation/devicetree/bindings/video/display-timing.txt
Best regards,
Tomasz
-- Thanks and Regards Vikas Sajjan
On Thu, May 9, 2013 at 7:55 PM, Vikas Sajjan vikas.sajjan@linaro.org wrote:
Hi Tomasz,
On 10 May 2013 05:35, Tomasz Figa tomasz.figa@gmail.com wrote:
Hi Vikas,
On Wednesday 08 of May 2013 11:31:34 Vikas Sajjan wrote:
Adds display timing node for a DP panel to Arndale Board DTS file
Signed-off-by: Vikas Sajjan vikas.sajjan@linaro.org
arch/arm/boot/dts/exynos5250-arndale.dts | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts index f68b820..c831a5c 100644 --- a/arch/arm/boot/dts/exynos5250-arndale.dts +++ b/arch/arm/boot/dts/exynos5250-arndale.dts @@ -459,4 +459,20 @@ samsung,lane-count = <4>; };
display-timings {native-mode = <&timing0>;timing0: timing@0 {/* 2560x1600 DP panel */clock-frequency = <50000>;hactive = <2560>;vactive = <1600>;hfront-porch = <48>;hback-porch = <80>;hsync-len = <32>;vback-porch = <16>;vfront-porch = <8>;vsync-len = <6>;};};What display are those timings used for? Shouldn't they be placed inside node of that display?
This timing information will be used parsed by the FIMD probe with the help of "Video Helper function" as done in this link
https://git.kernel.org/cgit/linux/kernel/git/daeinki/drm-exynos.git/commit/?...
That function passes in a device node pointer to the FIMD device node, and only looks for a display-timings node under there. Tomasz is right, as far as I can tell.
Placing display timings at the root of the device tree seems completely wrong.
Please refer to this patch which is used for exynos4412-origen and exynos5250-smdk5250 respectively in similar way
https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/commit/...
https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/commit/...
That needs to be fixed up as well, thanks for pointing it out.
-Olof
linaro-kernel@lists.linaro.org
-
Jingoo Han -
Kukjin Kim -
Olof Johansson -
Tomasz Figa -
Vikas Sajjan