Tree/Branch: next-20160914 Git describe: next-20160914 Commit: b224027bb7 Add linux-next specific files for 20160914
Build Time: 83 min 32 sec
Passed: 8 / 10 ( 80.00 %) Failed: 2 / 10 ( 20.00 %)
Errors: 1 Warnings: 3 Section Mismatches: 0
Failed defconfigs: arm64-allmodconfig arm-allmodconfig
Errors:
arm64-allmodconfig ERROR: "irq_set_parent" [drivers/mfd/tps65217.ko] undefined!
arm-allmodconfig ERROR: "irq_set_parent" [drivers/mfd/tps65217.ko] undefined!
------------------------------------------------------------------------------- defconfigs with issues (other than build errors): 6 warnings 0 mismatches : arm-multi_v5_defconfig 6 warnings 0 mismatches : arm-multi_v7_defconfig 3 warnings 0 mismatches : arm-allmodconfig 3 warnings 0 mismatches : arm-multi_v4t_defconfig 3 warnings 0 mismatches : arm-allnoconfig
-------------------------------------------------------------------------------
Errors summary: 1 2 ERROR: "irq_set_parent" [drivers/mfd/tps65217.ko] undefined!
Warnings Summary: 3 7 <stdin>:1322:2: warning: #warning syscall pkey_free not implemented [-Wcpp] 7 <stdin>:1319:2: warning: #warning syscall pkey_alloc not implemented [-Wcpp] 7 <stdin>:1316:2: warning: #warning syscall pkey_mprotect not implemented [-Wcpp]
=============================================================================== Detailed per-defconfig build reports below:
------------------------------------------------------------------------------- arm64-allmodconfig : FAIL, 1 errors, 0 warnings, 0 section mismatches
Errors: ERROR: "irq_set_parent" [drivers/mfd/tps65217.ko] undefined!
------------------------------------------------------------------------------- arm-multi_v5_defconfig : PASS, 0 errors, 6 warnings, 0 section mismatches
Warnings: <stdin>:1316:2: warning: #warning syscall pkey_mprotect not implemented [-Wcpp] <stdin>:1319:2: warning: #warning syscall pkey_alloc not implemented [-Wcpp] <stdin>:1322:2: warning: #warning syscall pkey_free not implemented [-Wcpp] <stdin>:1316:2: warning: #warning syscall pkey_mprotect not implemented [-Wcpp] <stdin>:1319:2: warning: #warning syscall pkey_alloc not implemented [-Wcpp] <stdin>:1322:2: warning: #warning syscall pkey_free not implemented [-Wcpp]
------------------------------------------------------------------------------- arm-multi_v7_defconfig : PASS, 0 errors, 6 warnings, 0 section mismatches
Warnings: <stdin>:1316:2: warning: #warning syscall pkey_mprotect not implemented [-Wcpp] <stdin>:1319:2: warning: #warning syscall pkey_alloc not implemented [-Wcpp] <stdin>:1322:2: warning: #warning syscall pkey_free not implemented [-Wcpp] <stdin>:1316:2: warning: #warning syscall pkey_mprotect not implemented [-Wcpp] <stdin>:1319:2: warning: #warning syscall pkey_alloc not implemented [-Wcpp] <stdin>:1322:2: warning: #warning syscall pkey_free not implemented [-Wcpp]
------------------------------------------------------------------------------- arm-allmodconfig : FAIL, 1 errors, 3 warnings, 0 section mismatches
Errors: ERROR: "irq_set_parent" [drivers/mfd/tps65217.ko] undefined!
Warnings: <stdin>:1316:2: warning: #warning syscall pkey_mprotect not implemented [-Wcpp] <stdin>:1319:2: warning: #warning syscall pkey_alloc not implemented [-Wcpp] <stdin>:1322:2: warning: #warning syscall pkey_free not implemented [-Wcpp]
------------------------------------------------------------------------------- arm-multi_v4t_defconfig : PASS, 0 errors, 3 warnings, 0 section mismatches
Warnings: <stdin>:1316:2: warning: #warning syscall pkey_mprotect not implemented [-Wcpp] <stdin>:1319:2: warning: #warning syscall pkey_alloc not implemented [-Wcpp] <stdin>:1322:2: warning: #warning syscall pkey_free not implemented [-Wcpp]
------------------------------------------------------------------------------- arm-allnoconfig : PASS, 0 errors, 3 warnings, 0 section mismatches
Warnings: <stdin>:1316:2: warning: #warning syscall pkey_mprotect not implemented [-Wcpp] <stdin>:1319:2: warning: #warning syscall pkey_alloc not implemented [-Wcpp] <stdin>:1322:2: warning: #warning syscall pkey_free not implemented [-Wcpp] -------------------------------------------------------------------------------
Passed with no errors, warnings or mismatches:
x86_64-allnoconfig arm64-allnoconfig x86_64-defconfig arm64-defconfig
On Wed, Sep 14, 2016 at 09:18:08AM +0100, Build bot for Mark Brown wrote:
Today's -next fails to build both arm and arm64 allmodconfig due to:
arm64-allmodconfig ERROR: "irq_set_parent" [drivers/mfd/tps65217.ko] undefined!
arm-allmodconfig ERROR: "irq_set_parent" [drivers/mfd/tps65217.ko] undefined!
due to 262d5cc6ceb293 (mfd: tps65217: Add support for IRQs) since irq_set_parent() isn't exported.
On Wed, 14 Sep 2016, Mark Brown wrote:
On Wed, Sep 14, 2016 at 09:18:08AM +0100, Build bot for Mark Brown wrote:
Today's -next fails to build both arm and arm64 allmodconfig due to:
arm64-allmodconfig ERROR: "irq_set_parent" [drivers/mfd/tps65217.ko] undefined!
arm-allmodconfig ERROR: "irq_set_parent" [drivers/mfd/tps65217.ko] undefined!
due to 262d5cc6ceb293 (mfd: tps65217: Add support for IRQs) since irq_set_parent() isn't exported.
Arnd is talking to Thomas about a possible solution.
Mark Brown broonie@kernel.org writes:
[ Unknown signature status ] On Wed, Sep 14, 2016 at 09:18:08AM +0100, Build bot for Mark Brown wrote:
Today's -next fails to build both arm and arm64 allmodconfig due to:
arm64-allmodconfig ERROR: "irq_set_parent" [drivers/mfd/tps65217.ko] undefined!
arm-allmodconfig ERROR: "irq_set_parent" [drivers/mfd/tps65217.ko] undefined!
due to 262d5cc6ceb293 (mfd: tps65217: Add support for IRQs) since irq_set_parent() isn't exported.
And powerpc too.
cheers
On Wed, Sep 14, 2016 at 06:11:37PM +0100, Mark Brown wrote:
On Wed, Sep 14, 2016 at 09:18:08AM +0100, Build bot for Mark Brown wrote:
Today's -next fails to build both arm and arm64 allmodconfig due to:
arm64-allmodconfig ERROR: "irq_set_parent" [drivers/mfd/tps65217.ko] undefined!
arm-allmodconfig ERROR: "irq_set_parent" [drivers/mfd/tps65217.ko] undefined!
due to 262d5cc6ceb293 (mfd: tps65217: Add support for IRQs) since irq_set_parent() isn't exported.
This is still breaking the build, do we have any ETA on getting the export added?
On Monday, September 19, 2016 11:21:50 AM CEST Mark Brown wrote:
On Wed, Sep 14, 2016 at 06:11:37PM +0100, Mark Brown wrote:
On Wed, Sep 14, 2016 at 09:18:08AM +0100, Build bot for Mark Brown wrote:
Today's -next fails to build both arm and arm64 allmodconfig due to:
arm64-allmodconfigERROR: "irq_set_parent" [drivers/mfd/tps65217.ko] undefined!
arm-allmodconfigERROR: "irq_set_parent" [drivers/mfd/tps65217.ko] undefined!
due to 262d5cc6ceb293 (mfd: tps65217: Add support for IRQs) since irq_set_parent() isn't exported.
This is still breaking the build, do we have any ETA on getting the export added?
Thomas said he'd add it if the export is needed, but so far nobody could tell if it is, or if the correct fix is something else, so I have not sent a patch for inclusion.
My guess is that this is indeed the correct fix, but I don't understand at all what the function does, and Marcin Niestroj said the same thing, he just copied the code from a driver that is always built-in.
FWIW, the original function is
static int regmap_irq_map(struct irq_domain *h, unsigned int virq, irq_hw_number_t hw) { struct regmap_irq_chip_data *data = h->host_data;
irq_set_chip_data(virq, data); irq_set_chip(virq, &data->irq_chip); irq_set_nested_thread(virq, 1); irq_set_parent(virq, data->irq); irq_set_noprobe(virq);
return 0; }
and this is the new one:
static int tps65217_irq_map(struct irq_domain *h, unsigned int virq, irq_hw_number_t hw) { struct tps65217 *tps = h->host_data;
irq_set_chip_data(virq, tps); irq_set_chip_and_handler(virq, &tps65217_irq_chip, handle_edge_irq); irq_set_nested_thread(virq, 1); irq_set_parent(virq, tps->irq); irq_set_noprobe(virq);
return 0; }
twl6030_irq_map() has another almost identical copy, and the only other caller of irq_set_parent() is gpiochip_set_chained_irqchip(), which is completely different.
Arnd
On Mon, Sep 19, 2016 at 12:31:04PM +0200, Arnd Bergmann wrote:
My guess is that this is indeed the correct fix, but I don't understand at all what the function does, and Marcin Niestroj said the same thing, he just copied the code from a driver that is always built-in.
Yes, most of the code is copied from regmap-irq. Setting the parent is needed for edge triggered interrupts that don't latch state when disabled but isn't needed in the general case.
On Monday, September 19, 2016 11:54:29 AM CEST Mark Brown wrote:
On Mon, Sep 19, 2016 at 12:31:04PM +0200, Arnd Bergmann wrote:
My guess is that this is indeed the correct fix, but I don't understand at all what the function does, and Marcin Niestroj said the same thing, he just copied the code from a driver that is always built-in.
Yes, most of the code is copied from regmap-irq. Setting the parent is needed for edge triggered interrupts that don't latch state when disabled but isn't needed in the general case.
I found this in the tps65217 data sheet:
9.3.7 Interrupt Pin (nINT) The interrupt pin is used to signal any event or fault condition to the host processor. Whenever a fault or event occurs in the IC the corresponding interrupt bit is set in the INT register, and the open-drain output is pulled low. The nINT pin is released (returns to Hi-Z state) and fault bits are cleared when the INT register is read by the host. However, if a failure persists, the corresponding INT bit remains set and the nINT pin is pulled low again after a maximum of 32 µs.
Interrupt events include pushbutton pressed/released, USB and AC voltage status change. The MASK bits in the INT register are used to mask events from generating interrupts. The MASK settings affect the nINT pin only and have no impact on protection and monitor circuits themselves. Note that persisting event conditions such as ISINK enabled shutdown can cause the nINT pin to be pulled low for an extended period of time which can keep the host in a loop trying to resolve the interrupt. If this behavior is not desired, set the corresponding mask bit after receiving the interrupt and keep polling the INT register to see when the event condition has disappeared. Then unmask the interrupt bit again.
Does this tell us if it's needed or not?
Arnd
On 09/19/2016 02:30 PM, Arnd Bergmann wrote:
On Monday, September 19, 2016 11:54:29 AM CEST Mark Brown wrote:
On Mon, Sep 19, 2016 at 12:31:04PM +0200, Arnd Bergmann wrote:
My guess is that this is indeed the correct fix, but I don't understand at all what the function does, and Marcin Niestroj said the same thing, he just copied the code from a driver that is always built-in.
Yes, most of the code is copied from regmap-irq. Setting the parent is needed for edge triggered interrupts that don't latch state when disabled but isn't needed in the general case.
I found this in the tps65217 data sheet:
9.3.7 Interrupt Pin (nINT) The interrupt pin is used to signal any event or fault condition to the host processor. Whenever a fault or event occurs in the IC the corresponding interrupt bit is set in the INT register, and the open-drain output is pulled low. The nINT pin is released (returns to Hi-Z state) and fault bits are cleared when the INT register is read by the host. However, if a failure persists, the corresponding INT bit remains set and the nINT pin is pulled low again after a maximum of 32 µs.
Interrupt events include pushbutton pressed/released, USB and AC voltage status change. The MASK bits in the INT register are used to mask events from generating interrupts. The MASK settings affect the nINT pin only and have no impact on protection and monitor circuits themselves. Note that persisting event conditions such as ISINK enabled shutdown can cause the nINT pin to be pulled low for an extended period of time which can keep the host in a loop trying to resolve the interrupt. If this behavior is not desired, set the corresponding mask bit after receiving the interrupt and keep polling the INT register to see when the event condition has disappeared. Then unmask the interrupt bit again.
Does this tell us if it's needed or not?
The irq_set_parent() is required for proper supporting of lazy irq disabling for threaded nested irqs and allow them to be re-triggered in the following case:
driverX: disable(nested_irq); ... parent irq triggered |- handle_nested_irq() |- mark nested_irq with IRQS_PENDING
... driverX: enable(nested_irq); |- if IRQS_PENDING -> resend parent_irq [*], because nested threaded irq can't be resend by itself
[*] if parent_irq is not set the IRQS_PENDING status will be ignored and irq might be lost.
Also, it was "mandatory" to be done before commit 75a06189fc5 "genirq: Prevent resend to interrupts marked IRQ_NESTED_THREAD" which made setting of parent_irq optional.
So, if is it required or not depends not only on HW, but, rather, on MFD drivers implementation (Interrupt controller and MFD cell drivers).
linaro-kernel@lists.linaro.org
-
Arnd Bergmann -
Build bot for Mark Brown -
Grygorii Strashko -
Lee Jones -
Mark Brown
-
Michael Ellerman