Hi Kevin
Here is a pull request for the patches to move move psci firmware calls out of line. This is needed to fix arm64 compilation errors seen with the latest versions of GCC. Note however that the patch for 32-bit arm that you requested I include: - Isn't in mainline Linux. - Seems to have outstanding questions from it's review, see https://www.marc.info/?l=linux-arm-kernel&m=142667534218278&w=3 - From what I can see, nobody has actually hit compilation problems on 32-bit arm. - Has not been tested by me because the standard firmware for TC2 doesn't support PSCI. (I've compiled the files though.)
With all those caveats...
The following changes since commit e13c574895626b6e8bd53f340dbd47f67871b26b:
arm64: respect mem= for EFI (2015-04-23 14:44:35 +0800)
are available in the git repository at:
https://git.linaro.org/people/tixy/kernel.git out-of-line-psci-calls-for-lsk
for you to fetch changes up to a7b7a0b45324aac0b21487ee7a9e5f682555be88:
ARM: psci: move psci firmware calls out of line (2015-04-28 10:47:57 +0100)
---------------------------------------------------------------- Mark Rutland (1): ARM: psci: move psci firmware calls out of line
Will Deacon (1): arm64: psci: move psci firmware calls out of line
arch/arm/kernel/Makefile | 2 +- arch/arm/kernel/psci-call.S | 31 +++++++++++++++++++++++++++++++ arch/arm/kernel/psci.c | 39 +++------------------------------------ arch/arm64/kernel/Makefile | 2 +- arch/arm64/kernel/psci-call.S | 28 ++++++++++++++++++++++++++++ arch/arm64/kernel/psci.c | 37 +++---------------------------------- 6 files changed, 67 insertions(+), 72 deletions(-) create mode 100644 arch/arm/kernel/psci-call.S create mode 100644 arch/arm64/kernel/psci-call.S
"Jon Medhurst (Tixy)" tixy@linaro.org writes:
Here is a pull request for the patches to move move psci firmware calls out of line. This is needed to fix arm64 compilation errors seen with the latest versions of GCC. Note however that the patch for 32-bit arm that you requested I include:
- Isn't in mainline Linux.
Isn't it commit c097877319ab (ARM: 8307/1: psci: move psci firmware calls out of line) ?
- Seems to have outstanding questions from it's review, see https://www.marc.info/?l=linux-arm-kernel&m=142667534218278&w=3
- From what I can see, nobody has actually hit compilation problems on 32-bit arm.
Good point.
- Has not been tested by me because the standard firmware for TC2 doesn't support PSCI. (I've compiled the files though.)
With all those caveats...
Also, v3.10 was just voted into maintenance mode, so I'm not going to worry anymore about fixes for things people aren't asking for (like this feature for 32-bit.)
So, how about I just pull your lsk-3.10-armlt-fixes branch, which has this arm64 fix on top of the other fixes we've already pulled?
Sorry for the run around on this,
Kevin
On Tue, 2015-04-28 at 08:17 -0700, Kevin Hilman wrote:
"Jon Medhurst (Tixy)" tixy@linaro.org writes:
[...]
- Isn't in mainline Linux.
Isn't it commit c097877319ab (ARM: 8307/1: psci: move psci firmware calls out of line) ?
It is, don't know why I didn't spot that.
[...]
Also, v3.10 was just voted into maintenance mode, so I'm not going to worry anymore about fixes for things people aren't asking for (like this feature for 32-bit.)
So, how about I just pull your lsk-3.10-armlt-fixes branch, which has this arm64 fix on top of the other fixes we've already pulled?
Well, the other fixes are already in LSK, applied by Alex from the emails I posted a while back. So the only patch you actually want is the first patch on that out-of-line-psci-calls-for-lsk branch I pushed, i.e. you can just do
git pull https://git.linaro.org/people/tixy/kernel.git 0fa86773b0cd16f1d23b090424814864643159eb
Which should be a fastforward on the current LSK. Unless anything else has been pushed today.
"Jon Medhurst (Tixy)" tixy@linaro.org writes:
On Tue, 2015-04-28 at 08:17 -0700, Kevin Hilman wrote:
"Jon Medhurst (Tixy)" tixy@linaro.org writes:
[...]
- Isn't in mainline Linux.
Isn't it commit c097877319ab (ARM: 8307/1: psci: move psci firmware calls out of line) ?
It is, don't know why I didn't spot that.
[...]
Also, v3.10 was just voted into maintenance mode, so I'm not going to worry anymore about fixes for things people aren't asking for (like this feature for 32-bit.)
So, how about I just pull your lsk-3.10-armlt-fixes branch, which has this arm64 fix on top of the other fixes we've already pulled?
Well, the other fixes are already in LSK, applied by Alex from the emails I posted a while back. So the only patch you actually want is the first patch on that out-of-line-psci-calls-for-lsk branch I pushed
I know, but even if I re-pull your lsk-3.10-armlt-fixes branch, git is smart enough to only grab the one commit that's not already in our tree.
, i.e. you can just do
git pull https://git.linaro.org/people/tixy/kernel.git 0fa86773b0cd16f1d23b090424814864643159eb
That commit ID doesn't exist. But anyways, don't worry about it.
Which should be a fastforward on the current LSK. Unless anything else has been pushed today.
There have been a few things merged since your other fixes were applied, but just re-pulling your fixes branch will still work just fine, so I've just done that.
Kevin
On Tue, 2015-04-28 at 15:41 -0700, Kevin Hilman wrote:
, i.e. you can just do
git pull
https://git.linaro.org/people/tixy/kernel.git 0fa86773b0cd16f1d23b090424814864643159eb
That commit ID doesn't exist.
It appears in the web interface at least: http://git.linaro.org/people/tixy/kernel.git/commit/0fa86773b0cd16f1d23b0904...
But anyways, don't worry about it.
OK :-)
There have been a few things merged since your other fixes were applied, but just re-pulling your fixes branch will still work just fine, so I've just done that.
Thanks.
linaro-kernel@lists.linaro.org
-
Jon Medhurst (Tixy) -
Kevin Hilman