When building non-preempt kernel (PREEMPT_NONE), PREEMPT_COUNT is still enabled if DEBUG_ATOMIC_SLEEP is enabled. But, it sounds not make sense to have PREEMPT_COUNT set in non-preempt kernel.
So, make PREEMPT_COUNT depend on PREEMPT here.
Signed-off-by: Yang Shi yang.shi@linaro.org --- lib/Kconfig.debug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index ecb9e75..a5b6e11 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -1075,7 +1075,7 @@ config DEBUG_LOCKDEP
config DEBUG_ATOMIC_SLEEP bool "Sleep inside atomic section checking" - select PREEMPT_COUNT + select PREEMPT_COUNT if PREEMPT depends on DEBUG_KERNEL help If you say Y here, various routines which may sleep will become very
On Fri, Feb 12, 2016 at 10:14:22AM -0800, Yang Shi wrote:
When building non-preempt kernel (PREEMPT_NONE), PREEMPT_COUNT is still enabled if DEBUG_ATOMIC_SLEEP is enabled. But, it sounds not make sense to have PREEMPT_COUNT set in non-preempt kernel.
So, make PREEMPT_COUNT depend on PREEMPT here.
Signed-off-by: Yang Shi yang.shi@linaro.org
lib/Kconfig.debug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index ecb9e75..a5b6e11 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -1075,7 +1075,7 @@ config DEBUG_LOCKDEP config DEBUG_ATOMIC_SLEEP bool "Sleep inside atomic section checking"
- select PREEMPT_COUNT
- select PREEMPT_COUNT if PREEMPT
OK, so do tell, how is it supposed to debug atomic sections without actually tracking atomic sections?
linaro-kernel@lists.linaro.org
-
Peter Zijlstra -
Yang Shi