This patch fix the clock device irq field which is not initialized.
Signed-off-by: Daniel Lezcano daniel.lezcano@linaro.org --- drivers/clocksource/nomadik-mtu.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/clocksource/nomadik-mtu.c b/drivers/clocksource/nomadik-mtu.c index 8914c3c..7cbcaa0 100644 --- a/drivers/clocksource/nomadik-mtu.c +++ b/drivers/clocksource/nomadik-mtu.c @@ -226,5 +226,6 @@ void __init nmdk_timer_init(void __iomem *base, int irq) /* Timer 1 is used for events, register irq and clockevents */ setup_irq(irq, &nmdk_timer_irq); nmdk_clkevt.cpumask = cpumask_of(0); + nmdk_clkevt.irq = irq; clockevents_config_and_register(&nmdk_clkevt, rate, 2, 0xffffffffU); }
On Fri, Feb 22, 2013 at 4:44 PM, Daniel Lezcano daniel.lezcano@linaro.org wrote:
This patch fix the clock device irq field which is not initialized.
Signed-off-by: Daniel Lezcano daniel.lezcano@linaro.org
Makes perfect sense: Acked-by: Linus Walleij linus.walleij@linaro.org
Sorry that I might have missed some background here or just be out-of-track with things, how did this driver work for years without the irq assigned? Or was this field recently introduced?
Yours, linus Walleij
On 02/22/2013 06:21 PM, Linus Walleij wrote:
On Fri, Feb 22, 2013 at 4:44 PM, Daniel Lezcano daniel.lezcano@linaro.org wrote:
This patch fix the clock device irq field which is not initialized.
Signed-off-by: Daniel Lezcano daniel.lezcano@linaro.org
Makes perfect sense: Acked-by: Linus Walleij linus.walleij@linaro.org
Sorry that I might have missed some background here or just be out-of-track with things, how did this driver work for years without the irq assigned? Or was this field recently introduced?
The irq is assigned through:
setup_irq(irq, &nmdk_timer_irq);
two lines above but the clockevent's irq field was not set.
I did not investigate a lot, but at the first glance it worked because the code path used by the default kernel configuration (CONFIG_NO_HZ) does not use this field.
But when using the dynamic irq affinity [1], I noticed it was set to 0.
[1] http://www.spinics.net/lists/arm-kernel/msg226371.html
Thanks -- Daniel
linaro-kernel@lists.linaro.org
-
Daniel Lezcano -
Linus Walleij