split_huge_pages doesn't support get method at all, so the read permission sounds confusing, change the permission to write only.
And, add "\n" to the output of set method to make it more readable.
Signed-off-by: Yang Shi yang.shi@linaro.org --- mm/huge_memory.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 86f9f8b..8adf3c2 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -3454,7 +3454,7 @@ next: } }
- pr_info("%lu of %lu THP split", split, total); + pr_info("%lu of %lu THP split\n", split, total);
return 0; } @@ -3465,7 +3465,7 @@ static int __init split_huge_pages_debugfs(void) { void *ret;
- ret = debugfs_create_file("split_huge_pages", 0644, NULL, NULL, + ret = debugfs_create_file("split_huge_pages", 0200, NULL, NULL, &split_huge_pages_fops); if (!ret) pr_warn("Failed to create split_huge_pages in debugfs");
On Fri, Apr 15, 2016 at 11:10:05AM -0700, Yang Shi wrote:
split_huge_pages doesn't support get method at all, so the read permission sounds confusing, change the permission to write only.
And, add "\n" to the output of set method to make it more readable.
Signed-off-by: Yang Shi yang.shi@linaro.org
Acked-by: Kirill A. Shutemov kirill.shutemov@linux.intel.com
linaro-kernel@lists.linaro.org