Hi Gaurav,

"Gaurav Jindal (Gaurav Jindal)" Gaurav.Jindal@spreadtrum.com writes:

Hi all

Please find the patch for Handling the error while getting slower/faster CPU domain. (Commit ID 847c2761d5991c7b2a194d4254ac61f0e4aafbc4)

I assume this is against the LSK v3.10, correct? What is that commit ID referencing? There is no such commit in the LSK tree. If it's the commit in your local tree, it's not needed here.

Description:

if caller does not check for slowest/fastest cpu domain before getting the next slower/faster CPU domain, error may occur if CPU is already in slowest/fastest domain.

If the CPU is already in fastest domain, it will return the head pointer of the list instead of previous faster domain. In such case ,it should return the current CPU domain only.

Similarly, if the CPU is already in slowest domain, it will return the head pointer of the list instead of next slower domain. In such case , it should return the current CPU domain only.

This looks to be the duplicate of what's in the changelog.

Rather than send a description plus a patch as an attachment, Could you just send the patch inline with the descriptive changelog (I recommend git-format-patch + git-send-email.)

Also, when you re-send, please make the subject more descriptive. Something like:

[PATCH LSK-v3.10] HMP: add error handling when getting slower/faster CPU domain

Also, since the HMP feature was developed primarily by ARM, please Cc these people when you repost:

Morten Rasmussen Morten.Rasmussen@arm.com Chris Redpath chris.redpath@arm.com Jon Medhurst tixy@linaro.org Vincent Guittot vincent.guittot@linaro.org

so this can be reviewed by the original authors.

These same comments apply to your second patch as well.

Thanks for contributing to the LSK,

Kevin