From: Mark Brown broonie@linaro.org
The DSI-CM driver uses the backlight class so needs to build depend on it.
Signed-off-by: Mark Brown broonie@linaro.org --- drivers/video/omap2/displays-new/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/video/omap2/displays-new/Kconfig b/drivers/video/omap2/displays-new/Kconfig index 6c90885..10b25e7 100644 --- a/drivers/video/omap2/displays-new/Kconfig +++ b/drivers/video/omap2/displays-new/Kconfig @@ -35,6 +35,7 @@ config DISPLAY_PANEL_DPI
config DISPLAY_PANEL_DSI_CM tristate "Generic DSI Command Mode Panel" + depends on BACKLIGHT_CLASS_DEVICE help Driver for generic DSI command mode panels.
On Wednesday, September 25, 2013 8:31 PM, Mark Brown wrote:
From: Mark Brown broonie@linaro.org
The DSI-CM driver uses the backlight class so needs to build depend on it.
Signed-off-by: Mark Brown broonie@linaro.org
Reviewed-by: Jingoo Han jg1.han@samsung.com
I checked that the following build errors are removed. drivers/video/omap2/displays-new/panel-dsi-cm.c:1257: undefined reference to `backlight_device_register' drivers/video/omap2/displays-new/panel-dsi-cm.c:1283: undefined reference to `backlight_device_unregister' drivers/built-in.o: In function `dsicm_remove': drivers/video/omap2/displays-new/panel-dsi-cm.c:1309: undefined reference to `backlight_device_unregister'
Thank you.
Best regards, Jingoo Han
drivers/video/omap2/displays-new/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/video/omap2/displays-new/Kconfig b/drivers/video/omap2/displays-new/Kconfig index 6c90885..10b25e7 100644 --- a/drivers/video/omap2/displays-new/Kconfig +++ b/drivers/video/omap2/displays-new/Kconfig @@ -35,6 +35,7 @@ config DISPLAY_PANEL_DPI
config DISPLAY_PANEL_DSI_CM tristate "Generic DSI Command Mode Panel"
- depends on BACKLIGHT_CLASS_DEVICE help Driver for generic DSI command mode panels.
-- 1.8.4.rc3
On 25/09/13 14:31, Mark Brown wrote:
From: Mark Brown broonie@linaro.org
The DSI-CM driver uses the backlight class so needs to build depend on it.
Signed-off-by: Mark Brown broonie@linaro.org
drivers/video/omap2/displays-new/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/video/omap2/displays-new/Kconfig b/drivers/video/omap2/displays-new/Kconfig index 6c90885..10b25e7 100644 --- a/drivers/video/omap2/displays-new/Kconfig +++ b/drivers/video/omap2/displays-new/Kconfig @@ -35,6 +35,7 @@ config DISPLAY_PANEL_DPI config DISPLAY_PANEL_DSI_CM tristate "Generic DSI Command Mode Panel"
- depends on BACKLIGHT_CLASS_DEVICE help Driver for generic DSI command mode panels.
Thanks, I'll queue for 3.12 fixes.
I wish we could "select" instead of "depends on"...
Tomi
On 26/09/13 13:12, Mark Brown wrote:
On Thu, Sep 26, 2013 at 11:36:26AM +0300, Tomi Valkeinen wrote:
I wish we could "select" instead of "depends on"...
We probably could.
I'm not so sure.
If we select BACKLIGHT_CLASS_DEVICE, we could end up compiling backlight.c without fbdev, and backlight.c uses fb's funcs.
The funny thing is, there is FB_BACKLIGHT, which seems to be designed to be selectable (and is selected). That one depends on FB, but if I'm not mistaken, that dependency does not do anything if FB_BACKLIGHT is selected.
FB_BACKLIGHT in turn selects both BACKLIGHT_LCD_SUPPORT and BACKLIGHT_CLASS_DEVICE, neither of which seem to be designed to be selectable.
I think that's a bit broken. Anyway, I guess it's better to "depend on" here, to be on the safe side.
Tomi
linaro-kernel@lists.linaro.org
-
Jingoo Han -
Mark Brown -
Tomi Valkeinen