This option is required by PCIe SATA disks under Juno board.
Signed-off-by: Alex Shi alex.shi@linaro.org To: Andrey Konovalov andrey.konovalov@linaro.org Cc: Ryan Harkin ryan.harkin@linaro.org Cc: Kevin Hilman khilman@linaro.org Cc: linaro-kernel@lists.linaro.org --- linaro/configs/vexpress64.conf | 1 + 1 file changed, 1 insertion(+)
diff --git a/linaro/configs/vexpress64.conf b/linaro/configs/vexpress64.conf index 7c35366..febd66a 100644 --- a/linaro/configs/vexpress64.conf +++ b/linaro/configs/vexpress64.conf @@ -46,3 +46,4 @@ CONFIG_USB_EHCI_HCD=y CONFIG_USB_EHCI_HCD_PLATFORM=y CONFIG_NOP_USB_XCEIV=y CONFIG_USB_OHCI_HCD=y +CONFIG_SATA_SIL24=y
Hi Andrey,
This patch aimed at https://git.linaro.org/kernel/configs.git config-boards-4.1 for Juno r1 PCIe support, without this, the PCIe SATA disk missed.
Thanks!
On 11/16/2015 12:08 PM, Alex Shi wrote:
This option is required by PCIe SATA disks under Juno board.
Signed-off-by: Alex Shi alex.shi@linaro.org To: Andrey Konovalov andrey.konovalov@linaro.org Cc: Ryan Harkin ryan.harkin@linaro.org Cc: Kevin Hilman khilman@linaro.org Cc: linaro-kernel@lists.linaro.org
linaro/configs/vexpress64.conf | 1 + 1 file changed, 1 insertion(+)
diff --git a/linaro/configs/vexpress64.conf b/linaro/configs/vexpress64.conf index 7c35366..febd66a 100644 --- a/linaro/configs/vexpress64.conf +++ b/linaro/configs/vexpress64.conf @@ -46,3 +46,4 @@ CONFIG_USB_EHCI_HCD=y CONFIG_USB_EHCI_HCD_PLATFORM=y CONFIG_NOP_USB_XCEIV=y CONFIG_USB_OHCI_HCD=y +CONFIG_SATA_SIL24=y
Alex Shi alex.shi@linaro.org writes:
This option is required by PCIe SATA disks under Juno board.
Signed-off-by: Alex Shi alex.shi@linaro.org To: Andrey Konovalov andrey.konovalov@linaro.org Cc: Ryan Harkin ryan.harkin@linaro.org Cc: Kevin Hilman khilman@linaro.org Cc: linaro-kernel@lists.linaro.org
Acked-by: Kevin Hilman khilman@linaro.org
On 16 November 2015 at 17:47, Kevin Hilman khilman@linaro.org wrote:
Alex Shi alex.shi@linaro.org writes:
This option is required by PCIe SATA disks under Juno board.
Signed-off-by: Alex Shi alex.shi@linaro.org To: Andrey Konovalov andrey.konovalov@linaro.org Cc: Ryan Harkin ryan.harkin@linaro.org Cc: Kevin Hilman khilman@linaro.org Cc: linaro-kernel@lists.linaro.org
Acked-by: Kevin Hilman khilman@linaro.org
Maybe it would be better to cherry-pick this commit across to get more complete PCIe support?
https://git.linaro.org/landing-teams/working/arm/kernel.git/commit/50d0303de...
Tixy, perhaps we need to "upstream" some of our config changes to configs.git?
On Mon, 2015-11-16 at 18:31 +0000, Ryan Harkin wrote:
On 16 November 2015 at 17:47, Kevin Hilman khilman@linaro.org wrote:
Alex Shi alex.shi@linaro.org writes:
This option is required by PCIe SATA disks under Juno board.
Signed-off-by: Alex Shi alex.shi@linaro.org To: Andrey Konovalov andrey.konovalov@linaro.org Cc: Ryan Harkin ryan.harkin@linaro.org Cc: Kevin Hilman khilman@linaro.org Cc: linaro-kernel@lists.linaro.org
Acked-by: Kevin Hilman khilman@linaro.org
Maybe it would be better to cherry-pick this commit across to get more complete PCIe support?
https://git.linaro.org/landing-teams/working/arm/kernel.git/commit/50d0303de...
Are those configs correct for 4.1? (Probably are)
Tixy, perhaps we need to "upstream" some of our config changes to configs.git?
Only makes sense for features which are actually 'upstream'.
For the tip of the configs repo, that means for code in Linus Torvald's tree at the relevant version (which reminds me a lot of stuff is now in 4.4-rc1 :-).
I think $subject patch at the moment is for LSK 4.1, and is using the 4.1 configs branch. That should be up-to-date with mainline 4.1 so LSK is only missing configs for things they backport. So, they might get clues from looking at our configs in linux-linaro of the relevant vintage the code was ported from, but I don't think there's scope for wholesale 'upstreaming' of configs.
On 11/16/2015 09:31 PM, Ryan Harkin wrote:
On 16 November 2015 at 17:47, Kevin Hilman khilman@linaro.org wrote:
Alex Shi alex.shi@linaro.org writes:
This option is required by PCIe SATA disks under Juno board.
Signed-off-by: Alex Shi alex.shi@linaro.org To: Andrey Konovalov andrey.konovalov@linaro.org Cc: Ryan Harkin ryan.harkin@linaro.org Cc: Kevin Hilman khilman@linaro.org Cc: linaro-kernel@lists.linaro.org
Acked-by: Kevin Hilman khilman@linaro.org
Maybe it would be better to cherry-pick this commit across to get more complete PCIe support?
https://git.linaro.org/landing-teams/working/arm/kernel.git/commit/50d0303de...
Alex, Kevin, Any objections if cherry-pick this commit?
Looks like it would be OK. PCI_HOST_GENERIC would not be enabled in vanilla v4.1 though, but it could be addressed separately for the pre-4.3 kernel trees w/o commit aa4a5c0d2 "PCI: generic: Add arm64 support" backported. lsk-v4.1 does have PCI_HOST_GENERIC enabled for ARM64.
Tixy, perhaps we need to "upstream" some of our config changes to configs.git?
That would be great!
Thanks, Andrey
Andrey Konovalov andrey.konovalov@linaro.org writes:
On 11/16/2015 09:31 PM, Ryan Harkin wrote:
On 16 November 2015 at 17:47, Kevin Hilman khilman@linaro.org wrote:
Alex Shi alex.shi@linaro.org writes:
This option is required by PCIe SATA disks under Juno board.
Signed-off-by: Alex Shi alex.shi@linaro.org To: Andrey Konovalov andrey.konovalov@linaro.org Cc: Ryan Harkin ryan.harkin@linaro.org Cc: Kevin Hilman khilman@linaro.org Cc: linaro-kernel@lists.linaro.org
Acked-by: Kevin Hilman khilman@linaro.org
Maybe it would be better to cherry-pick this commit across to get more complete PCIe support?
https://git.linaro.org/landing-teams/working/arm/kernel.git/commit/50d0303de...
Alex, Kevin, Any objections if cherry-pick this commit?
No objections.
In fact, I'm fine if there are a couple things in the configs that are not (yet) upstream since they will have no effect, and we'll get them "for free" if/when we backport the feature. If we don't backport, then there is no impact.
Looks like it would be OK. PCI_HOST_GENERIC would not be enabled in vanilla v4.1 though, but it could be addressed separately for the pre-4.3 kernel trees w/o commit aa4a5c0d2 "PCI: generic: Add arm64 support" backported. lsk-v4.1 does have PCI_HOST_GENERIC enabled for ARM64.
Tixy, perhaps we need to "upstream" some of our config changes to configs.git?
That would be great!
Agreed.
Kevin
https://git.linaro.org/landing-teams/working/arm/kernel.git/commit/50d0303de...
Hi, Ryan/Tixy,
I pick up id 4e6c808 on next-armlt-juno branch for this commit. The ID is not 50d0303dee.. as in above url. and in fact I can not found that ID in whole tree, odd or I missed sth?
Regard Alex
Hi Alex,
On 17 Nov 2015 05:54, "Alex Shi" alex.shi@linaro.org wrote:
https://git.linaro.org/landing-teams/working/arm/kernel.git/commit/50d0303de...
Hi, Ryan/Tixy,
I pick up id 4e6c808 on next-armlt-juno branch for this commit. The ID is not 50d0303dee.. as in above url. and in fact I can not found that ID in whole tree, odd or I missed sth?
I guess you missed something, because it's there in gitweb. But it's ok, because the commit you found is just a newer rebase of the same thing.
Regard Alex
On 11/17/2015 02:40 PM, Ryan Harkin wrote:
Hi Alex,
On 17 Nov 2015 05:54, "Alex Shi" <alex.shi@linaro.org mailto:alex.shi@linaro.org> wrote:
https://git.linaro.org/landing-teams/working/arm/kernel.git/commit/50d0303de...
Hi, Ryan/Tixy,
I pick up id 4e6c808 on next-armlt-juno branch for this commit. The ID is not 50d0303dee.. as in above url. and in fact I can not found that ID in whole tree, odd or I missed sth?
I guess you missed something, because it's there in gitweb. But it's ok, because the commit you found is just a newer rebase of the same thing.
Thanks! I followed the 'summary' link from that page and use the first 'URL' as git repository: https://git.linaro.org/landing-teams/working/arm/kernel.git I also can not find linux-linaro branch in above tree. That's obviously incorrect. So what's I missed? or where to find out the correct git tree from the original link?
Thanks Alex
On Tue, 2015-11-17 at 17:02 +0800, Alex Shi wrote:
On 11/17/2015 02:40 PM, Ryan Harkin wrote:
Hi Alex,
On 17 Nov 2015 05:54, "Alex Shi" <alex.shi@linaro.org mailto:alex.shi@linaro.org> wrote:
https://git.linaro.org/landing-teams/working/arm/kernel.git/commit/50d0303de...
Hi, Ryan/Tixy,
I pick up id 4e6c808 on next-armlt-juno branch for this commit. The ID is not 50d0303dee.. as in above url. and in fact I can not found that ID in whole tree, odd or I missed sth?
I guess you missed something, because it's there in gitweb. But it's ok, because the commit you found is just a newer rebase of the same thing.
Thanks! I followed the 'summary' link from that page and use the first 'URL' as git repository: https://git.linaro.org/landing-teams/working/arm/kernel.git I also can not find linux-linaro branch in above tree.
There isn't one there. 'linux-linaro' normally refers to the kernel maintained by Andrey [1], which is the latest upstream kernel with Linaro outputs added, including what the ARM LT produces. The latest PCI config commit in that is [2]
[1] http://git.linaro.org/?p=kernel/linux-linaro-tracking.git%3Ba=shortlog%3Bh=r... [2] http://git.linaro.org/kernel/linux-linaro-tracking.git/commit/96cd1969085d2f...
The ARM LT 'working' tree is subject to regular rebasing, so commits SHAs won't hang around long. ('working' here means work-in-progress and is an unfortunate naming choice for LT repos from the dawn of Linaro history).
On 11/17/2015 12:41 AM, Kevin Hilman wrote:
Andrey Konovalov andrey.konovalov@linaro.org writes:
On 11/16/2015 09:31 PM, Ryan Harkin wrote:
On 16 November 2015 at 17:47, Kevin Hilman khilman@linaro.org wrote:
Alex Shi alex.shi@linaro.org writes:
This option is required by PCIe SATA disks under Juno board.
Signed-off-by: Alex Shi alex.shi@linaro.org To: Andrey Konovalov andrey.konovalov@linaro.org Cc: Ryan Harkin ryan.harkin@linaro.org Cc: Kevin Hilman khilman@linaro.org Cc: linaro-kernel@lists.linaro.org
Acked-by: Kevin Hilman khilman@linaro.org
Maybe it would be better to cherry-pick this commit across to get more complete PCIe support?
https://git.linaro.org/landing-teams/working/arm/kernel.git/commit/50d0303de...
Alex, Kevin, Any objections if cherry-pick this commit?
No objections.
Commit c02c643 "configs: vexpress64: Add PCI related configs use by for Juno r1" has been added to config-boards-4.1 branch.
Thanks, Andrey
In fact, I'm fine if there are a couple things in the configs that are not (yet) upstream since they will have no effect, and we'll get them "for free" if/when we backport the feature. If we don't backport, then there is no impact.
Looks like it would be OK. PCI_HOST_GENERIC would not be enabled in vanilla v4.1 though, but it could be addressed separately for the pre-4.3 kernel trees w/o commit aa4a5c0d2 "PCI: generic: Add arm64 support" backported. lsk-v4.1 does have PCI_HOST_GENERIC enabled for ARM64.
Tixy, perhaps we need to "upstream" some of our config changes to configs.git?
That would be great!
Agreed.
Kevin
linaro-kernel@lists.linaro.org
-
Alex Shi -
Andrey Konovalov -
Jon Medhurst (Tixy) -
Kevin Hilman -
Ryan Harkin