On 2 April 2014 06:55, Josh Boyer jwboyer@fedoraproject.org wrote:
Hi All,
When running make listnewconfig/oldconfig on the config below with Linus' latest tree, I keep seeing this error message spit out:
drivers/cpufreq/Kconfig:57:warning: choice value used outside its choice group drivers/cpufreq/Kconfig:65:warning: choice value used outside its choice group drivers/cpufreq/Kconfig:74:warning: choice value used outside its choice group drivers/cpufreq/Kconfig:83:warning: choice value used outside its choice group drivers/cpufreq/Kconfig:95:warning: choice value used outside its choice group
At the moment I'm only seeing this on arm64 but I have no idea why. Does anyone else?
Hmm, there are two entries for this present in: arch/arm64/Kconfig
+source "drivers/cpufreq/Kconfig"
You can see that here in Linus's merge: 4dedde
Probably both Rafael and Catalin were carrying this change..
-- viresh
Commit 74397174989e5f70 attempted to clean up the power management options for arm64, but when things were merged it didn't fully take effect. Fix it again.
Signed-off-by: Josh Boyer jwboyer@fedoraproject.org --- arch/arm64/Kconfig | 6 ------ 1 file changed, 6 deletions(-)
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 07aa3556952c..8033b9b8a2df 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -321,12 +321,6 @@ menu "CPU Power Management"
source "drivers/cpuidle/Kconfig"
-source "drivers/cpufreq/Kconfig" - -endmenu - -menu "Power management options" - source "kernel/power/Kconfig"
source "drivers/cpufreq/Kconfig"
On Wed, Apr 2, 2014 at 8:10 PM, Josh Boyer jwboyer@fedoraproject.org wrote:
Commit 74397174989e5f70 attempted to clean up the power management options for arm64, but when things were merged it didn't fully take effect. Fix it again.
Signed-off-by: Josh Boyer jwboyer@fedoraproject.org
arch/arm64/Kconfig | 6 ------ 1 file changed, 6 deletions(-)
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 07aa3556952c..8033b9b8a2df 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -321,12 +321,6 @@ menu "CPU Power Management"
source "drivers/cpuidle/Kconfig"
-source "drivers/cpufreq/Kconfig"
-endmenu
-menu "Power management options"
source "kernel/power/Kconfig"
source "drivers/cpufreq/Kconfig"
Reviewed-by: Viresh Kumar viresh.kumar@linaro.org
linaro-kernel@lists.linaro.org
-
Josh Boyer -
Viresh Kumar