- Linux-stable-mirror - lists.linaro.org

FAILED: patch "[PATCH] ata: libata-scsi: Fix offsets for the fixed format sense data" failed to apply to 6.1-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.1-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.1.y git checkout FETCH_HEAD git cherry-pick -x 38dab832c3f4154968f95b267a3bb789e87554b0 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072944-swoosh-muster-ccde@gregkh' --subject-prefix 'PATCH 6.1.y' HEAD^.. Possible dependencies: 38dab832c3f4 ("ata: libata-scsi: Fix offsets for the fixed format sense data") ff8072d589dc ("ata: libata: remove references to non-existing error_handler()") 3ac873c76d79 ("ata: libata-core: fix when to fetch sense data for successful commands") 18bd7718b5c4 ("scsi: ata: libata: Handle completion of CDL commands using policy 0xD") eafe804bda7b ("scsi: ata: libata: Set read/write commands CDL index") df60f9c64576 ("scsi: ata: libata: Add ATA feature control sub-page translation") 673b2fe6ff1d ("scsi: ata: libata-scsi: Add support for CDL pages mode sense") 62e4a60e0cdb ("scsi: ata: libata: Detect support for command duration limits") bc9af4909406 ("ata: libata: Fix FUA handling in ata_build_rw_tf()") 4d2e4980a528 ("ata: libata: cleanup fua support detection") 87aab3c4cd59 ("ata: libata: move NCQ related ATA_DFLAGs") 876293121f24 ("ata: scsi: rename flag ATA_QCFLAG_FAILED to ATA_QCFLAG_EH") b83ad9eec316 ("ata: libata-eh: Cleanup ata_scsi_cmd_error_handler()") 3d8a3ae3d966 ("ata: libata: fix commands incorrectly not getting retried during NCQ error") 4cb7c6f1ef96 ("ata: make use of ata_port_is_frozen() helper") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 38dab832c3f4154968f95b267a3bb789e87554b0 Mon Sep 17 00:00:00 2001 From: Igor Pylypiv <ipylypiv(a)google.com> Date: Tue, 2 Jul 2024 02:47:29 +0000 Subject: [PATCH] ata: libata-scsi: Fix offsets for the fixed format sense data MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Correct the ATA PASS-THROUGH fixed format sense data offsets to conform to SPC-6 and SAT-5 specifications. Additionally, set the VALID bit to indicate that the INFORMATION field contains valid information. INFORMATION =========== SAT-5 Table 212 — "Fixed format sense data INFORMATION field for the ATA PASS-THROUGH commands" defines the following format: +------+------------+ | Byte | Field | +------+------------+ | 0 | ERROR | | 1 | STATUS | | 2 | DEVICE | | 3 | COUNT(7:0) | +------+------------+ SPC-6 Table 48 - "Fixed format sense data" specifies that the INFORMATION field starts at byte 3 in sense buffer resulting in the following offsets for the ATA PASS-THROUGH commands: +------------+-------------------------+ | Field | Offset in sense buffer | +------------+-------------------------+ | ERROR | 3 | | STATUS | 4 | | DEVICE | 5 | | COUNT(7:0) | 6 | +------------+-------------------------+ COMMAND-SPECIFIC INFORMATION ============================ SAT-5 Table 213 - "Fixed format sense data COMMAND-SPECIFIC INFORMATION field for ATA PASS-THROUGH" defines the following format: +------+-------------------+ | Byte | Field | +------+-------------------+ | 0 | FLAGS | LOG INDEX | | 1 | LBA (7:0) | | 2 | LBA (15:8) | | 3 | LBA (23:16) | +------+-------------------+ SPC-6 Table 48 - "Fixed format sense data" specifies that the COMMAND-SPECIFIC-INFORMATION field starts at byte 8 in sense buffer resulting in the following offsets for the ATA PASS-THROUGH commands: Offsets of these fields in the fixed sense format are as follows: +-------------------+-------------------------+ | Field | Offset in sense buffer | +-------------------+-------------------------+ | FLAGS | LOG INDEX | 8 | | LBA (7:0) | 9 | | LBA (15:8) | 10 | | LBA (23:16) | 11 | +-------------------+-------------------------+ Reported-by: Akshat Jain <akshatzen(a)google.com> Fixes: 11093cb1ef56 ("libata-scsi: generate correct ATA pass-through sense") Cc: stable(a)vger.kernel.org Reviewed-by: Hannes Reinecke <hare(a)suse.de> Reviewed-by: Niklas Cassel <cassel(a)kernel.org> Signed-off-by: Igor Pylypiv <ipylypiv(a)google.com> Link: https://lore.kernel.org/r/20240702024735.1152293-2-ipylypiv@google.com Signed-off-by: Niklas Cassel <cassel(a)kernel.org> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index cdf29b178ddc..a0c68b0a00c4 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -855,7 +855,6 @@ static void ata_gen_passthru_sense(struct ata_queued_cmd *qc) struct scsi_cmnd *cmd = qc->scsicmd; struct ata_taskfile *tf = &qc->result_tf; unsigned char *sb = cmd->sense_buffer; - unsigned char *desc = sb + 8; u8 sense_key, asc, ascq; memset(sb, 0, SCSI_SENSE_BUFFERSIZE); @@ -877,7 +876,8 @@ static void ata_gen_passthru_sense(struct ata_queued_cmd *qc) scsi_build_sense(cmd, 1, RECOVERED_ERROR, 0, 0x1D); } - if ((cmd->sense_buffer[0] & 0x7f) >= 0x72) { + if ((sb[0] & 0x7f) >= 0x72) { + unsigned char *desc; u8 len; /* descriptor format */ @@ -916,21 +916,21 @@ static void ata_gen_passthru_sense(struct ata_queued_cmd *qc) } } else { /* Fixed sense format */ - desc[0] = tf->error; - desc[1] = tf->status; - desc[2] = tf->device; - desc[3] = tf->nsect; - desc[7] = 0; + sb[0] |= 0x80; + sb[3] = tf->error; + sb[4] = tf->status; + sb[5] = tf->device; + sb[6] = tf->nsect; if (tf->flags & ATA_TFLAG_LBA48) { - desc[8] |= 0x80; + sb[8] |= 0x80; if (tf->hob_nsect) - desc[8] |= 0x40; + sb[8] |= 0x40; if (tf->hob_lbal || tf->hob_lbam || tf->hob_lbah) - desc[8] |= 0x20; + sb[8] |= 0x20; } - desc[9] = tf->lbal; - desc[10] = tf->lbam; - desc[11] = tf->lbah; + sb[9] = tf->lbal; + sb[10] = tf->lbam; + sb[11] = tf->lbah; } }

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] sched/fair: set_load_weight() must also call reweight_task()" failed to apply to 4.19-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.19-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-4.19.y git checkout FETCH_HEAD git cherry-pick -x d329605287020c3d1c3b0dadc63d8208e7251382 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072951-crimson-ashamed-1d63@gregkh' --subject-prefix 'PATCH 4.19.y' HEAD^.. Possible dependencies: d32960528702 ("sched/fair: set_load_weight() must also call reweight_task() for SCHED_IDLE tasks") 0dacee1bfa70 ("sched/pelt: Remove unused runnable load average") fe71bbb21ee1 ("sched/fair: calculate delta runnable load only when it's needed") 8de6242cca17 ("sched/debug: Add new tracepoint to track PELT at se level") ba19f51fcb54 ("sched/debug: Add new tracepoints to track PELT at rq level") 039ae8bcf7a5 ("sched/fair: Fix O(nr_cgroups) in the load balancing path") 5d299eabea5a ("sched/fair: Add tmp_alone_branch assertion") 23127296889f ("sched/fair: Update scale invariance of PELT") c40f7d74c741 ("sched/fair: Fix infinite loop in update_blocked_averages() by reverting a9e7f6544b9c") dfcb245e2848 ("sched: Fix various typos in comments") 1da1843f9f03 ("sched/core: Create task_has_idle_policy() helper") 4a465e3ebbc8 ("sched/fair: Remove setting task's se->runnable_weight during PELT update") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From d329605287020c3d1c3b0dadc63d8208e7251382 Mon Sep 17 00:00:00 2001 From: Tejun Heo <tj(a)kernel.org> Date: Tue, 25 Jun 2024 15:29:58 -1000 Subject: [PATCH] sched/fair: set_load_weight() must also call reweight_task() for SCHED_IDLE tasks When a task's weight is being changed, set_load_weight() is called with @update_load set. As weight changes aren't trivial for the fair class, set_load_weight() calls fair.c::reweight_task() for fair class tasks. However, set_load_weight() first tests task_has_idle_policy() on entry and skips calling reweight_task() for SCHED_IDLE tasks. This is buggy as SCHED_IDLE tasks are just fair tasks with a very low weight and they would incorrectly skip load, vlag and position updates. Fix it by updating reweight_task() to take struct load_weight as idle weight can't be expressed with prio and making set_load_weight() call reweight_task() for SCHED_IDLE tasks too when @update_load is set. Fixes: 9059393e4ec1 ("sched/fair: Use reweight_entity() for set_user_nice()") Suggested-by: Peter Zijlstra (Intel) <peterz(a)infradead.org> Signed-off-by: Tejun Heo <tj(a)kernel.org> Signed-off-by: Peter Zijlstra (Intel) <peterz(a)infradead.org> Cc: stable(a)vger.kernel.org # v4.15+ Link: http://lkml.kernel.org/r/20240624102331.GI31592@noisy.programming.kicks-ass… diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 0935f9d4bb7b..747683487be7 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -1328,27 +1328,24 @@ int tg_nop(struct task_group *tg, void *data) void set_load_weight(struct task_struct *p, bool update_load) { int prio = p->static_prio - MAX_RT_PRIO; - struct load_weight *load = &p->se.load; + struct load_weight lw; - /* - * SCHED_IDLE tasks get minimal weight: - */ if (task_has_idle_policy(p)) { - load->weight = scale_load(WEIGHT_IDLEPRIO); - load->inv_weight = WMULT_IDLEPRIO; - return; + lw.weight = scale_load(WEIGHT_IDLEPRIO); + lw.inv_weight = WMULT_IDLEPRIO; + } else { + lw.weight = scale_load(sched_prio_to_weight[prio]); + lw.inv_weight = sched_prio_to_wmult[prio]; } /* * SCHED_OTHER tasks have to update their load when changing their * weight */ - if (update_load && p->sched_class == &fair_sched_class) { - reweight_task(p, prio); - } else { - load->weight = scale_load(sched_prio_to_weight[prio]); - load->inv_weight = sched_prio_to_wmult[prio]; - } + if (update_load && p->sched_class == &fair_sched_class) + reweight_task(p, &lw); + else + p->se.load = lw; } #ifdef CONFIG_UCLAMP_TASK diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 41b58387023d..f205e2482690 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -3835,15 +3835,14 @@ static void reweight_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, } } -void reweight_task(struct task_struct *p, int prio) +void reweight_task(struct task_struct *p, const struct load_weight *lw) { struct sched_entity *se = &p->se; struct cfs_rq *cfs_rq = cfs_rq_of(se); struct load_weight *load = &se->load; - unsigned long weight = scale_load(sched_prio_to_weight[prio]); - reweight_entity(cfs_rq, se, weight); - load->inv_weight = sched_prio_to_wmult[prio]; + reweight_entity(cfs_rq, se, lw->weight); + load->inv_weight = lw->inv_weight; } static inline int throttled_hierarchy(struct cfs_rq *cfs_rq); diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 62fd8bc6fd08..9ab53435debd 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -2509,7 +2509,7 @@ extern void init_sched_dl_class(void); extern void init_sched_rt_class(void); extern void init_sched_fair_class(void); -extern void reweight_task(struct task_struct *p, int prio); +extern void reweight_task(struct task_struct *p, const struct load_weight *lw); extern void resched_curr(struct rq *rq); extern void resched_cpu(int cpu);

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] sched/fair: set_load_weight() must also call reweight_task()" failed to apply to 5.4-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.4.y git checkout FETCH_HEAD git cherry-pick -x d329605287020c3d1c3b0dadc63d8208e7251382 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072950-swab-uncharted-cf85@gregkh' --subject-prefix 'PATCH 5.4.y' HEAD^.. Possible dependencies: d32960528702 ("sched/fair: set_load_weight() must also call reweight_task() for SCHED_IDLE tasks") 0dacee1bfa70 ("sched/pelt: Remove unused runnable load average") fe71bbb21ee1 ("sched/fair: calculate delta runnable load only when it's needed") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From d329605287020c3d1c3b0dadc63d8208e7251382 Mon Sep 17 00:00:00 2001 From: Tejun Heo <tj(a)kernel.org> Date: Tue, 25 Jun 2024 15:29:58 -1000 Subject: [PATCH] sched/fair: set_load_weight() must also call reweight_task() for SCHED_IDLE tasks When a task's weight is being changed, set_load_weight() is called with @update_load set. As weight changes aren't trivial for the fair class, set_load_weight() calls fair.c::reweight_task() for fair class tasks. However, set_load_weight() first tests task_has_idle_policy() on entry and skips calling reweight_task() for SCHED_IDLE tasks. This is buggy as SCHED_IDLE tasks are just fair tasks with a very low weight and they would incorrectly skip load, vlag and position updates. Fix it by updating reweight_task() to take struct load_weight as idle weight can't be expressed with prio and making set_load_weight() call reweight_task() for SCHED_IDLE tasks too when @update_load is set. Fixes: 9059393e4ec1 ("sched/fair: Use reweight_entity() for set_user_nice()") Suggested-by: Peter Zijlstra (Intel) <peterz(a)infradead.org> Signed-off-by: Tejun Heo <tj(a)kernel.org> Signed-off-by: Peter Zijlstra (Intel) <peterz(a)infradead.org> Cc: stable(a)vger.kernel.org # v4.15+ Link: http://lkml.kernel.org/r/20240624102331.GI31592@noisy.programming.kicks-ass… diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 0935f9d4bb7b..747683487be7 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -1328,27 +1328,24 @@ int tg_nop(struct task_group *tg, void *data) void set_load_weight(struct task_struct *p, bool update_load) { int prio = p->static_prio - MAX_RT_PRIO; - struct load_weight *load = &p->se.load; + struct load_weight lw; - /* - * SCHED_IDLE tasks get minimal weight: - */ if (task_has_idle_policy(p)) { - load->weight = scale_load(WEIGHT_IDLEPRIO); - load->inv_weight = WMULT_IDLEPRIO; - return; + lw.weight = scale_load(WEIGHT_IDLEPRIO); + lw.inv_weight = WMULT_IDLEPRIO; + } else { + lw.weight = scale_load(sched_prio_to_weight[prio]); + lw.inv_weight = sched_prio_to_wmult[prio]; } /* * SCHED_OTHER tasks have to update their load when changing their * weight */ - if (update_load && p->sched_class == &fair_sched_class) { - reweight_task(p, prio); - } else { - load->weight = scale_load(sched_prio_to_weight[prio]); - load->inv_weight = sched_prio_to_wmult[prio]; - } + if (update_load && p->sched_class == &fair_sched_class) + reweight_task(p, &lw); + else + p->se.load = lw; } #ifdef CONFIG_UCLAMP_TASK diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 41b58387023d..f205e2482690 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -3835,15 +3835,14 @@ static void reweight_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, } } -void reweight_task(struct task_struct *p, int prio) +void reweight_task(struct task_struct *p, const struct load_weight *lw) { struct sched_entity *se = &p->se; struct cfs_rq *cfs_rq = cfs_rq_of(se); struct load_weight *load = &se->load; - unsigned long weight = scale_load(sched_prio_to_weight[prio]); - reweight_entity(cfs_rq, se, weight); - load->inv_weight = sched_prio_to_wmult[prio]; + reweight_entity(cfs_rq, se, lw->weight); + load->inv_weight = lw->inv_weight; } static inline int throttled_hierarchy(struct cfs_rq *cfs_rq); diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 62fd8bc6fd08..9ab53435debd 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -2509,7 +2509,7 @@ extern void init_sched_dl_class(void); extern void init_sched_rt_class(void); extern void init_sched_fair_class(void); -extern void reweight_task(struct task_struct *p, int prio); +extern void reweight_task(struct task_struct *p, const struct load_weight *lw); extern void resched_curr(struct rq *rq); extern void resched_cpu(int cpu);

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] ipv4: fix source address selection with route leak" failed to apply to 4.19-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.19-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-4.19.y git checkout FETCH_HEAD git cherry-pick -x 6807352353561187a718e87204458999dbcbba1b # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072923-veteran-backless-4326@gregkh' --subject-prefix 'PATCH 4.19.y' HEAD^.. Possible dependencies: 680735235356 ("ipv4: fix source address selection with route leak") eba618abacad ("ipv4: Add fib_nh_common to fib_result") 0af7e7c128eb ("ipv4: Update fib_table_lookup tracepoint to take common nexthop") b75ed8b1aa9c ("ipv4: Rename fib_nh entries") faa041a40b9f ("ipv4: Create cleanup helper for fib_nh") e4516ef65490 ("ipv4: Create init helper for fib_nh") 331c7a402358 ("ipv4: Move IN_DEV_IGNORE_ROUTES_WITH_LINKDOWN to helper") 8373c6c84e67 ("ipv4: Define fib_get_nhs when CONFIG_IP_ROUTE_MULTIPATH is disabled") 544fe7c2e654 ("net/mlx5e: Activate HW multipath and handle port affinity based on FIB events") 724b509ca023 ("net/mlx5: Add multipath mode") 10a193ed78ad ("net/mlx5: Expose lag operations in header file") bb19ad0d8d49 ("net/mlx5: Use unsigned int bit instead of bool as a struct member") 97417f6182f8 ("net/mlx5e: Fix GRE key by controlling port tunnel entropy calculation") d9ee0491c2ff ("net/mlx5e: Use dedicated uplink vport netdev representor") 025380b20dc2 ("net/mlx5e: Use single argument for the esw representor build params helper") 958246664043 ("net/mlx5: Handle LAG FW commands failure gracefully") 7c34ec19e10c ("net/mlx5: Make RoCE and SR-IOV LAG modes explicit") 292612d68c4e ("net/mlx5: Rename mlx5_lag_is_bonded() to __mlx5_lag_is_active()") eff849b2c669 ("net/mlx5: Allow/disallow LAG according to pre-req only") 3b5ff59fd851 ("net/mlx5: Adjustments for the activate LAG logic to run under sriov") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 6807352353561187a718e87204458999dbcbba1b Mon Sep 17 00:00:00 2001 From: Nicolas Dichtel <nicolas.dichtel(a)6wind.com> Date: Wed, 10 Jul 2024 10:14:27 +0200 Subject: [PATCH] ipv4: fix source address selection with route leak By default, an address assigned to the output interface is selected when the source address is not specified. This is problematic when a route, configured in a vrf, uses an interface from another vrf (aka route leak). The original vrf does not own the selected source address. Let's add a check against the output interface and call the appropriate function to select the source address. CC: stable(a)vger.kernel.org Fixes: 8cbb512c923d ("net: Add source address lookup op for VRF") Signed-off-by: Nicolas Dichtel <nicolas.dichtel(a)6wind.com> Reviewed-by: David Ahern <dsahern(a)kernel.org> Link: https://patch.msgid.link/20240710081521.3809742-2-nicolas.dichtel@6wind.com Signed-off-by: Jakub Kicinski <kuba(a)kernel.org> diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c index f669da98d11d..8956026bc0a2 100644 --- a/net/ipv4/fib_semantics.c +++ b/net/ipv4/fib_semantics.c @@ -2270,6 +2270,15 @@ void fib_select_path(struct net *net, struct fib_result *res, fib_select_default(fl4, res); check_saddr: - if (!fl4->saddr) - fl4->saddr = fib_result_prefsrc(net, res); + if (!fl4->saddr) { + struct net_device *l3mdev; + + l3mdev = dev_get_by_index_rcu(net, fl4->flowi4_l3mdev); + + if (!l3mdev || + l3mdev_master_dev_rcu(FIB_RES_DEV(*res)) == l3mdev) + fl4->saddr = fib_result_prefsrc(net, res); + else + fl4->saddr = inet_select_addr(l3mdev, 0, RT_SCOPE_LINK); + } }

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] ipv6: fix source address selection with route leak" failed to apply to 4.19-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.19-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-4.19.y git checkout FETCH_HEAD git cherry-pick -x 252442f2ae317d109ef0b4b39ce0608c09563042 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072910-phoney-unruly-d3cc@gregkh' --subject-prefix 'PATCH 4.19.y' HEAD^.. Possible dependencies: 252442f2ae31 ("ipv6: fix source address selection with route leak") fa17a6d8a5bd ("ipv6: lockless IPV6_ADDR_PREFERENCES implementation") 859f8b265fc2 ("ipv6: lockless IPV6_FLOWINFO_SEND implementation") 6b724bc4300b ("ipv6: lockless IPV6_MTU_DISCOVER implementation") 83cd5eb654b3 ("ipv6: lockless IPV6_ROUTER_ALERT_ISOLATE implementation") 3cccda8db2cf ("ipv6: move np->repflow to atomic flags") 3fa29971c695 ("ipv6: lockless IPV6_RECVERR implemetation") 1086ca7cce29 ("ipv6: lockless IPV6_DONTFRAG implementation") 5121516b0c47 ("ipv6: lockless IPV6_AUTOFLOWLABEL implementation") 6559c0ff3bc2 ("ipv6: lockless IPV6_MULTICAST_ALL implementation") dcae74622c05 ("ipv6: lockless IPV6_RECVERR_RFC4884 implementation") 273784d3c574 ("ipv6: lockless IPV6_MINHOPCOUNT implementation") 15f926c4457a ("ipv6: lockless IPV6_MTU implementation") 2da23eb07c91 ("ipv6: lockless IPV6_MULTICAST_HOPS implementation") d986f52124e0 ("ipv6: lockless IPV6_MULTICAST_LOOP implementation") b0adfba7ee77 ("ipv6: lockless IPV6_UNICAST_HOPS implementation") 8cdd9f1aaedf ("ipv6: fix ip6_sock_set_addr_preferences() typo") e3390b30a5df ("net: annotate data-races around sk->sk_tsflags") 0f158b32a9b1 ("net: selectively purge error queue in IP_RECVERR / IPV6_RECVERR") 08e39c0dfa29 ("inet: move inet->defer_connect to inet->inet_flags") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 252442f2ae317d109ef0b4b39ce0608c09563042 Mon Sep 17 00:00:00 2001 From: Nicolas Dichtel <nicolas.dichtel(a)6wind.com> Date: Wed, 10 Jul 2024 10:14:28 +0200 Subject: [PATCH] ipv6: fix source address selection with route leak By default, an address assigned to the output interface is selected when the source address is not specified. This is problematic when a route, configured in a vrf, uses an interface from another vrf (aka route leak). The original vrf does not own the selected source address. Let's add a check against the output interface and call the appropriate function to select the source address. CC: stable(a)vger.kernel.org Fixes: 0d240e7811c4 ("net: vrf: Implement get_saddr for IPv6") Signed-off-by: Nicolas Dichtel <nicolas.dichtel(a)6wind.com> Link: https://patch.msgid.link/20240710081521.3809742-3-nicolas.dichtel@6wind.com Signed-off-by: Jakub Kicinski <kuba(a)kernel.org> diff --git a/include/net/ip6_route.h b/include/net/ip6_route.h index a18ed24fed94..6dbdf60b342f 100644 --- a/include/net/ip6_route.h +++ b/include/net/ip6_route.h @@ -127,18 +127,26 @@ void rt6_age_exceptions(struct fib6_info *f6i, struct fib6_gc_args *gc_args, static inline int ip6_route_get_saddr(struct net *net, struct fib6_info *f6i, const struct in6_addr *daddr, - unsigned int prefs, + unsigned int prefs, int l3mdev_index, struct in6_addr *saddr) { + struct net_device *l3mdev; + struct net_device *dev; + bool same_vrf; int err = 0; - if (f6i && f6i->fib6_prefsrc.plen) { - *saddr = f6i->fib6_prefsrc.addr; - } else { - struct net_device *dev = f6i ? fib6_info_nh_dev(f6i) : NULL; + rcu_read_lock(); - err = ipv6_dev_get_saddr(net, dev, daddr, prefs, saddr); - } + l3mdev = dev_get_by_index_rcu(net, l3mdev_index); + if (!f6i || !f6i->fib6_prefsrc.plen || l3mdev) + dev = f6i ? fib6_info_nh_dev(f6i) : NULL; + same_vrf = !l3mdev || l3mdev_master_dev_rcu(dev) == l3mdev; + if (f6i && f6i->fib6_prefsrc.plen && same_vrf) + *saddr = f6i->fib6_prefsrc.addr; + else + err = ipv6_dev_get_saddr(net, same_vrf ? dev : l3mdev, daddr, prefs, saddr); + + rcu_read_unlock(); return err; } diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c index 27d8725445e3..784424ac4147 100644 --- a/net/ipv6/ip6_output.c +++ b/net/ipv6/ip6_output.c @@ -1124,6 +1124,7 @@ static int ip6_dst_lookup_tail(struct net *net, const struct sock *sk, from = rt ? rcu_dereference(rt->from) : NULL; err = ip6_route_get_saddr(net, from, &fl6->daddr, sk ? READ_ONCE(inet6_sk(sk)->srcprefs) : 0, + fl6->flowi6_l3mdev, &fl6->saddr); rcu_read_unlock(); diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 8d72ca0b086d..c9a9506b714d 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -5689,7 +5689,7 @@ static int rt6_fill_node(struct net *net, struct sk_buff *skb, goto nla_put_failure; } else if (dest) { struct in6_addr saddr_buf; - if (ip6_route_get_saddr(net, rt, dest, 0, &saddr_buf) == 0 && + if (ip6_route_get_saddr(net, rt, dest, 0, 0, &saddr_buf) == 0 && nla_put_in6_addr(skb, RTA_PREFSRC, &saddr_buf)) goto nla_put_failure; }

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] ipv6: fix source address selection with route leak" failed to apply to 5.4-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.4.y git checkout FETCH_HEAD git cherry-pick -x 252442f2ae317d109ef0b4b39ce0608c09563042 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072910-fax-periscope-a350@gregkh' --subject-prefix 'PATCH 5.4.y' HEAD^.. Possible dependencies: 252442f2ae31 ("ipv6: fix source address selection with route leak") fa17a6d8a5bd ("ipv6: lockless IPV6_ADDR_PREFERENCES implementation") 859f8b265fc2 ("ipv6: lockless IPV6_FLOWINFO_SEND implementation") 6b724bc4300b ("ipv6: lockless IPV6_MTU_DISCOVER implementation") 83cd5eb654b3 ("ipv6: lockless IPV6_ROUTER_ALERT_ISOLATE implementation") 3cccda8db2cf ("ipv6: move np->repflow to atomic flags") 3fa29971c695 ("ipv6: lockless IPV6_RECVERR implemetation") 1086ca7cce29 ("ipv6: lockless IPV6_DONTFRAG implementation") 5121516b0c47 ("ipv6: lockless IPV6_AUTOFLOWLABEL implementation") 6559c0ff3bc2 ("ipv6: lockless IPV6_MULTICAST_ALL implementation") dcae74622c05 ("ipv6: lockless IPV6_RECVERR_RFC4884 implementation") 273784d3c574 ("ipv6: lockless IPV6_MINHOPCOUNT implementation") 15f926c4457a ("ipv6: lockless IPV6_MTU implementation") 2da23eb07c91 ("ipv6: lockless IPV6_MULTICAST_HOPS implementation") d986f52124e0 ("ipv6: lockless IPV6_MULTICAST_LOOP implementation") b0adfba7ee77 ("ipv6: lockless IPV6_UNICAST_HOPS implementation") 8cdd9f1aaedf ("ipv6: fix ip6_sock_set_addr_preferences() typo") e3390b30a5df ("net: annotate data-races around sk->sk_tsflags") 0f158b32a9b1 ("net: selectively purge error queue in IP_RECVERR / IPV6_RECVERR") 08e39c0dfa29 ("inet: move inet->defer_connect to inet->inet_flags") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 252442f2ae317d109ef0b4b39ce0608c09563042 Mon Sep 17 00:00:00 2001 From: Nicolas Dichtel <nicolas.dichtel(a)6wind.com> Date: Wed, 10 Jul 2024 10:14:28 +0200 Subject: [PATCH] ipv6: fix source address selection with route leak By default, an address assigned to the output interface is selected when the source address is not specified. This is problematic when a route, configured in a vrf, uses an interface from another vrf (aka route leak). The original vrf does not own the selected source address. Let's add a check against the output interface and call the appropriate function to select the source address. CC: stable(a)vger.kernel.org Fixes: 0d240e7811c4 ("net: vrf: Implement get_saddr for IPv6") Signed-off-by: Nicolas Dichtel <nicolas.dichtel(a)6wind.com> Link: https://patch.msgid.link/20240710081521.3809742-3-nicolas.dichtel@6wind.com Signed-off-by: Jakub Kicinski <kuba(a)kernel.org> diff --git a/include/net/ip6_route.h b/include/net/ip6_route.h index a18ed24fed94..6dbdf60b342f 100644 --- a/include/net/ip6_route.h +++ b/include/net/ip6_route.h @@ -127,18 +127,26 @@ void rt6_age_exceptions(struct fib6_info *f6i, struct fib6_gc_args *gc_args, static inline int ip6_route_get_saddr(struct net *net, struct fib6_info *f6i, const struct in6_addr *daddr, - unsigned int prefs, + unsigned int prefs, int l3mdev_index, struct in6_addr *saddr) { + struct net_device *l3mdev; + struct net_device *dev; + bool same_vrf; int err = 0; - if (f6i && f6i->fib6_prefsrc.plen) { - *saddr = f6i->fib6_prefsrc.addr; - } else { - struct net_device *dev = f6i ? fib6_info_nh_dev(f6i) : NULL; + rcu_read_lock(); - err = ipv6_dev_get_saddr(net, dev, daddr, prefs, saddr); - } + l3mdev = dev_get_by_index_rcu(net, l3mdev_index); + if (!f6i || !f6i->fib6_prefsrc.plen || l3mdev) + dev = f6i ? fib6_info_nh_dev(f6i) : NULL; + same_vrf = !l3mdev || l3mdev_master_dev_rcu(dev) == l3mdev; + if (f6i && f6i->fib6_prefsrc.plen && same_vrf) + *saddr = f6i->fib6_prefsrc.addr; + else + err = ipv6_dev_get_saddr(net, same_vrf ? dev : l3mdev, daddr, prefs, saddr); + + rcu_read_unlock(); return err; } diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c index 27d8725445e3..784424ac4147 100644 --- a/net/ipv6/ip6_output.c +++ b/net/ipv6/ip6_output.c @@ -1124,6 +1124,7 @@ static int ip6_dst_lookup_tail(struct net *net, const struct sock *sk, from = rt ? rcu_dereference(rt->from) : NULL; err = ip6_route_get_saddr(net, from, &fl6->daddr, sk ? READ_ONCE(inet6_sk(sk)->srcprefs) : 0, + fl6->flowi6_l3mdev, &fl6->saddr); rcu_read_unlock(); diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 8d72ca0b086d..c9a9506b714d 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -5689,7 +5689,7 @@ static int rt6_fill_node(struct net *net, struct sk_buff *skb, goto nla_put_failure; } else if (dest) { struct in6_addr saddr_buf; - if (ip6_route_get_saddr(net, rt, dest, 0, &saddr_buf) == 0 && + if (ip6_route_get_saddr(net, rt, dest, 0, 0, &saddr_buf) == 0 && nla_put_in6_addr(skb, RTA_PREFSRC, &saddr_buf)) goto nla_put_failure; }

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] ipv6: fix source address selection with route leak" failed to apply to 5.10-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x 252442f2ae317d109ef0b4b39ce0608c09563042 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072909-varnish-hence-c531@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^.. Possible dependencies: 252442f2ae31 ("ipv6: fix source address selection with route leak") fa17a6d8a5bd ("ipv6: lockless IPV6_ADDR_PREFERENCES implementation") 859f8b265fc2 ("ipv6: lockless IPV6_FLOWINFO_SEND implementation") 6b724bc4300b ("ipv6: lockless IPV6_MTU_DISCOVER implementation") 83cd5eb654b3 ("ipv6: lockless IPV6_ROUTER_ALERT_ISOLATE implementation") 3cccda8db2cf ("ipv6: move np->repflow to atomic flags") 3fa29971c695 ("ipv6: lockless IPV6_RECVERR implemetation") 1086ca7cce29 ("ipv6: lockless IPV6_DONTFRAG implementation") 5121516b0c47 ("ipv6: lockless IPV6_AUTOFLOWLABEL implementation") 6559c0ff3bc2 ("ipv6: lockless IPV6_MULTICAST_ALL implementation") dcae74622c05 ("ipv6: lockless IPV6_RECVERR_RFC4884 implementation") 273784d3c574 ("ipv6: lockless IPV6_MINHOPCOUNT implementation") 15f926c4457a ("ipv6: lockless IPV6_MTU implementation") 2da23eb07c91 ("ipv6: lockless IPV6_MULTICAST_HOPS implementation") d986f52124e0 ("ipv6: lockless IPV6_MULTICAST_LOOP implementation") b0adfba7ee77 ("ipv6: lockless IPV6_UNICAST_HOPS implementation") 8cdd9f1aaedf ("ipv6: fix ip6_sock_set_addr_preferences() typo") e3390b30a5df ("net: annotate data-races around sk->sk_tsflags") 0f158b32a9b1 ("net: selectively purge error queue in IP_RECVERR / IPV6_RECVERR") 08e39c0dfa29 ("inet: move inet->defer_connect to inet->inet_flags") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 252442f2ae317d109ef0b4b39ce0608c09563042 Mon Sep 17 00:00:00 2001 From: Nicolas Dichtel <nicolas.dichtel(a)6wind.com> Date: Wed, 10 Jul 2024 10:14:28 +0200 Subject: [PATCH] ipv6: fix source address selection with route leak By default, an address assigned to the output interface is selected when the source address is not specified. This is problematic when a route, configured in a vrf, uses an interface from another vrf (aka route leak). The original vrf does not own the selected source address. Let's add a check against the output interface and call the appropriate function to select the source address. CC: stable(a)vger.kernel.org Fixes: 0d240e7811c4 ("net: vrf: Implement get_saddr for IPv6") Signed-off-by: Nicolas Dichtel <nicolas.dichtel(a)6wind.com> Link: https://patch.msgid.link/20240710081521.3809742-3-nicolas.dichtel@6wind.com Signed-off-by: Jakub Kicinski <kuba(a)kernel.org> diff --git a/include/net/ip6_route.h b/include/net/ip6_route.h index a18ed24fed94..6dbdf60b342f 100644 --- a/include/net/ip6_route.h +++ b/include/net/ip6_route.h @@ -127,18 +127,26 @@ void rt6_age_exceptions(struct fib6_info *f6i, struct fib6_gc_args *gc_args, static inline int ip6_route_get_saddr(struct net *net, struct fib6_info *f6i, const struct in6_addr *daddr, - unsigned int prefs, + unsigned int prefs, int l3mdev_index, struct in6_addr *saddr) { + struct net_device *l3mdev; + struct net_device *dev; + bool same_vrf; int err = 0; - if (f6i && f6i->fib6_prefsrc.plen) { - *saddr = f6i->fib6_prefsrc.addr; - } else { - struct net_device *dev = f6i ? fib6_info_nh_dev(f6i) : NULL; + rcu_read_lock(); - err = ipv6_dev_get_saddr(net, dev, daddr, prefs, saddr); - } + l3mdev = dev_get_by_index_rcu(net, l3mdev_index); + if (!f6i || !f6i->fib6_prefsrc.plen || l3mdev) + dev = f6i ? fib6_info_nh_dev(f6i) : NULL; + same_vrf = !l3mdev || l3mdev_master_dev_rcu(dev) == l3mdev; + if (f6i && f6i->fib6_prefsrc.plen && same_vrf) + *saddr = f6i->fib6_prefsrc.addr; + else + err = ipv6_dev_get_saddr(net, same_vrf ? dev : l3mdev, daddr, prefs, saddr); + + rcu_read_unlock(); return err; } diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c index 27d8725445e3..784424ac4147 100644 --- a/net/ipv6/ip6_output.c +++ b/net/ipv6/ip6_output.c @@ -1124,6 +1124,7 @@ static int ip6_dst_lookup_tail(struct net *net, const struct sock *sk, from = rt ? rcu_dereference(rt->from) : NULL; err = ip6_route_get_saddr(net, from, &fl6->daddr, sk ? READ_ONCE(inet6_sk(sk)->srcprefs) : 0, + fl6->flowi6_l3mdev, &fl6->saddr); rcu_read_unlock(); diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 8d72ca0b086d..c9a9506b714d 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -5689,7 +5689,7 @@ static int rt6_fill_node(struct net *net, struct sk_buff *skb, goto nla_put_failure; } else if (dest) { struct in6_addr saddr_buf; - if (ip6_route_get_saddr(net, rt, dest, 0, &saddr_buf) == 0 && + if (ip6_route_get_saddr(net, rt, dest, 0, 0, &saddr_buf) == 0 && nla_put_in6_addr(skb, RTA_PREFSRC, &saddr_buf)) goto nla_put_failure; }

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] ipv6: fix source address selection with route leak" failed to apply to 5.15-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.15-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.15.y git checkout FETCH_HEAD git cherry-pick -x 252442f2ae317d109ef0b4b39ce0608c09563042 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072908-clicker-cornball-8a64@gregkh' --subject-prefix 'PATCH 5.15.y' HEAD^.. Possible dependencies: 252442f2ae31 ("ipv6: fix source address selection with route leak") fa17a6d8a5bd ("ipv6: lockless IPV6_ADDR_PREFERENCES implementation") 859f8b265fc2 ("ipv6: lockless IPV6_FLOWINFO_SEND implementation") 6b724bc4300b ("ipv6: lockless IPV6_MTU_DISCOVER implementation") 83cd5eb654b3 ("ipv6: lockless IPV6_ROUTER_ALERT_ISOLATE implementation") 3cccda8db2cf ("ipv6: move np->repflow to atomic flags") 3fa29971c695 ("ipv6: lockless IPV6_RECVERR implemetation") 1086ca7cce29 ("ipv6: lockless IPV6_DONTFRAG implementation") 5121516b0c47 ("ipv6: lockless IPV6_AUTOFLOWLABEL implementation") 6559c0ff3bc2 ("ipv6: lockless IPV6_MULTICAST_ALL implementation") dcae74622c05 ("ipv6: lockless IPV6_RECVERR_RFC4884 implementation") 273784d3c574 ("ipv6: lockless IPV6_MINHOPCOUNT implementation") 15f926c4457a ("ipv6: lockless IPV6_MTU implementation") 2da23eb07c91 ("ipv6: lockless IPV6_MULTICAST_HOPS implementation") d986f52124e0 ("ipv6: lockless IPV6_MULTICAST_LOOP implementation") b0adfba7ee77 ("ipv6: lockless IPV6_UNICAST_HOPS implementation") 8cdd9f1aaedf ("ipv6: fix ip6_sock_set_addr_preferences() typo") e3390b30a5df ("net: annotate data-races around sk->sk_tsflags") 0f158b32a9b1 ("net: selectively purge error queue in IP_RECVERR / IPV6_RECVERR") 08e39c0dfa29 ("inet: move inet->defer_connect to inet->inet_flags") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 252442f2ae317d109ef0b4b39ce0608c09563042 Mon Sep 17 00:00:00 2001 From: Nicolas Dichtel <nicolas.dichtel(a)6wind.com> Date: Wed, 10 Jul 2024 10:14:28 +0200 Subject: [PATCH] ipv6: fix source address selection with route leak By default, an address assigned to the output interface is selected when the source address is not specified. This is problematic when a route, configured in a vrf, uses an interface from another vrf (aka route leak). The original vrf does not own the selected source address. Let's add a check against the output interface and call the appropriate function to select the source address. CC: stable(a)vger.kernel.org Fixes: 0d240e7811c4 ("net: vrf: Implement get_saddr for IPv6") Signed-off-by: Nicolas Dichtel <nicolas.dichtel(a)6wind.com> Link: https://patch.msgid.link/20240710081521.3809742-3-nicolas.dichtel@6wind.com Signed-off-by: Jakub Kicinski <kuba(a)kernel.org> diff --git a/include/net/ip6_route.h b/include/net/ip6_route.h index a18ed24fed94..6dbdf60b342f 100644 --- a/include/net/ip6_route.h +++ b/include/net/ip6_route.h @@ -127,18 +127,26 @@ void rt6_age_exceptions(struct fib6_info *f6i, struct fib6_gc_args *gc_args, static inline int ip6_route_get_saddr(struct net *net, struct fib6_info *f6i, const struct in6_addr *daddr, - unsigned int prefs, + unsigned int prefs, int l3mdev_index, struct in6_addr *saddr) { + struct net_device *l3mdev; + struct net_device *dev; + bool same_vrf; int err = 0; - if (f6i && f6i->fib6_prefsrc.plen) { - *saddr = f6i->fib6_prefsrc.addr; - } else { - struct net_device *dev = f6i ? fib6_info_nh_dev(f6i) : NULL; + rcu_read_lock(); - err = ipv6_dev_get_saddr(net, dev, daddr, prefs, saddr); - } + l3mdev = dev_get_by_index_rcu(net, l3mdev_index); + if (!f6i || !f6i->fib6_prefsrc.plen || l3mdev) + dev = f6i ? fib6_info_nh_dev(f6i) : NULL; + same_vrf = !l3mdev || l3mdev_master_dev_rcu(dev) == l3mdev; + if (f6i && f6i->fib6_prefsrc.plen && same_vrf) + *saddr = f6i->fib6_prefsrc.addr; + else + err = ipv6_dev_get_saddr(net, same_vrf ? dev : l3mdev, daddr, prefs, saddr); + + rcu_read_unlock(); return err; } diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c index 27d8725445e3..784424ac4147 100644 --- a/net/ipv6/ip6_output.c +++ b/net/ipv6/ip6_output.c @@ -1124,6 +1124,7 @@ static int ip6_dst_lookup_tail(struct net *net, const struct sock *sk, from = rt ? rcu_dereference(rt->from) : NULL; err = ip6_route_get_saddr(net, from, &fl6->daddr, sk ? READ_ONCE(inet6_sk(sk)->srcprefs) : 0, + fl6->flowi6_l3mdev, &fl6->saddr); rcu_read_unlock(); diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 8d72ca0b086d..c9a9506b714d 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -5689,7 +5689,7 @@ static int rt6_fill_node(struct net *net, struct sk_buff *skb, goto nla_put_failure; } else if (dest) { struct in6_addr saddr_buf; - if (ip6_route_get_saddr(net, rt, dest, 0, &saddr_buf) == 0 && + if (ip6_route_get_saddr(net, rt, dest, 0, 0, &saddr_buf) == 0 && nla_put_in6_addr(skb, RTA_PREFSRC, &saddr_buf)) goto nla_put_failure; }

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] ipv6: fix source address selection with route leak" failed to apply to 6.1-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.1-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.1.y git checkout FETCH_HEAD git cherry-pick -x 252442f2ae317d109ef0b4b39ce0608c09563042 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072907-unlaced-unlovely-6e01@gregkh' --subject-prefix 'PATCH 6.1.y' HEAD^.. Possible dependencies: 252442f2ae31 ("ipv6: fix source address selection with route leak") fa17a6d8a5bd ("ipv6: lockless IPV6_ADDR_PREFERENCES implementation") 859f8b265fc2 ("ipv6: lockless IPV6_FLOWINFO_SEND implementation") 6b724bc4300b ("ipv6: lockless IPV6_MTU_DISCOVER implementation") 83cd5eb654b3 ("ipv6: lockless IPV6_ROUTER_ALERT_ISOLATE implementation") 3cccda8db2cf ("ipv6: move np->repflow to atomic flags") 3fa29971c695 ("ipv6: lockless IPV6_RECVERR implemetation") 1086ca7cce29 ("ipv6: lockless IPV6_DONTFRAG implementation") 5121516b0c47 ("ipv6: lockless IPV6_AUTOFLOWLABEL implementation") 6559c0ff3bc2 ("ipv6: lockless IPV6_MULTICAST_ALL implementation") dcae74622c05 ("ipv6: lockless IPV6_RECVERR_RFC4884 implementation") 273784d3c574 ("ipv6: lockless IPV6_MINHOPCOUNT implementation") 15f926c4457a ("ipv6: lockless IPV6_MTU implementation") 2da23eb07c91 ("ipv6: lockless IPV6_MULTICAST_HOPS implementation") d986f52124e0 ("ipv6: lockless IPV6_MULTICAST_LOOP implementation") b0adfba7ee77 ("ipv6: lockless IPV6_UNICAST_HOPS implementation") 8cdd9f1aaedf ("ipv6: fix ip6_sock_set_addr_preferences() typo") e3390b30a5df ("net: annotate data-races around sk->sk_tsflags") 0f158b32a9b1 ("net: selectively purge error queue in IP_RECVERR / IPV6_RECVERR") 08e39c0dfa29 ("inet: move inet->defer_connect to inet->inet_flags") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 252442f2ae317d109ef0b4b39ce0608c09563042 Mon Sep 17 00:00:00 2001 From: Nicolas Dichtel <nicolas.dichtel(a)6wind.com> Date: Wed, 10 Jul 2024 10:14:28 +0200 Subject: [PATCH] ipv6: fix source address selection with route leak By default, an address assigned to the output interface is selected when the source address is not specified. This is problematic when a route, configured in a vrf, uses an interface from another vrf (aka route leak). The original vrf does not own the selected source address. Let's add a check against the output interface and call the appropriate function to select the source address. CC: stable(a)vger.kernel.org Fixes: 0d240e7811c4 ("net: vrf: Implement get_saddr for IPv6") Signed-off-by: Nicolas Dichtel <nicolas.dichtel(a)6wind.com> Link: https://patch.msgid.link/20240710081521.3809742-3-nicolas.dichtel@6wind.com Signed-off-by: Jakub Kicinski <kuba(a)kernel.org> diff --git a/include/net/ip6_route.h b/include/net/ip6_route.h index a18ed24fed94..6dbdf60b342f 100644 --- a/include/net/ip6_route.h +++ b/include/net/ip6_route.h @@ -127,18 +127,26 @@ void rt6_age_exceptions(struct fib6_info *f6i, struct fib6_gc_args *gc_args, static inline int ip6_route_get_saddr(struct net *net, struct fib6_info *f6i, const struct in6_addr *daddr, - unsigned int prefs, + unsigned int prefs, int l3mdev_index, struct in6_addr *saddr) { + struct net_device *l3mdev; + struct net_device *dev; + bool same_vrf; int err = 0; - if (f6i && f6i->fib6_prefsrc.plen) { - *saddr = f6i->fib6_prefsrc.addr; - } else { - struct net_device *dev = f6i ? fib6_info_nh_dev(f6i) : NULL; + rcu_read_lock(); - err = ipv6_dev_get_saddr(net, dev, daddr, prefs, saddr); - } + l3mdev = dev_get_by_index_rcu(net, l3mdev_index); + if (!f6i || !f6i->fib6_prefsrc.plen || l3mdev) + dev = f6i ? fib6_info_nh_dev(f6i) : NULL; + same_vrf = !l3mdev || l3mdev_master_dev_rcu(dev) == l3mdev; + if (f6i && f6i->fib6_prefsrc.plen && same_vrf) + *saddr = f6i->fib6_prefsrc.addr; + else + err = ipv6_dev_get_saddr(net, same_vrf ? dev : l3mdev, daddr, prefs, saddr); + + rcu_read_unlock(); return err; } diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c index 27d8725445e3..784424ac4147 100644 --- a/net/ipv6/ip6_output.c +++ b/net/ipv6/ip6_output.c @@ -1124,6 +1124,7 @@ static int ip6_dst_lookup_tail(struct net *net, const struct sock *sk, from = rt ? rcu_dereference(rt->from) : NULL; err = ip6_route_get_saddr(net, from, &fl6->daddr, sk ? READ_ONCE(inet6_sk(sk)->srcprefs) : 0, + fl6->flowi6_l3mdev, &fl6->saddr); rcu_read_unlock(); diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 8d72ca0b086d..c9a9506b714d 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -5689,7 +5689,7 @@ static int rt6_fill_node(struct net *net, struct sk_buff *skb, goto nla_put_failure; } else if (dest) { struct in6_addr saddr_buf; - if (ip6_route_get_saddr(net, rt, dest, 0, &saddr_buf) == 0 && + if (ip6_route_get_saddr(net, rt, dest, 0, 0, &saddr_buf) == 0 && nla_put_in6_addr(skb, RTA_PREFSRC, &saddr_buf)) goto nla_put_failure; }

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] kernel: rerun task_work while freezing in get_signal()" failed to apply to 5.10-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x 943ad0b62e3c21f324c4884caa6cb4a871bca05c # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072941-nucleus-cannabis-e513@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^.. Possible dependencies: 943ad0b62e3c ("kernel: rerun task_work while freezing in get_signal()") f5d39b020809 ("freezer,sched: Rewrite core freezer logic") 9963e444f71e ("sched: Widen TAKS_state literals") f9fc8cad9728 ("sched: Add TASK_ANY for wait_task_inactive()") 9204a97f7ae8 ("sched: Change wait_task_inactive()s match_state") 1fbcaa923ce2 ("freezer,umh: Clean up freezer/initrd interaction") 5950e5d574c6 ("freezer: Have {,un}lock_system_sleep() save/restore flags") 0b9d46fc5ef7 ("sched: Rename task_running() to task_on_cpu()") 8386c414e27c ("PM: hibernate: defer device probing when resuming from hibernation") 57b6de08b5f6 ("ptrace: Admit ptrace_stop can generate spuriuos SIGTRAPs") 7b0fe1367ef2 ("ptrace: Document that wait_task_inactive can't fail") 1930a6e739c4 ("Merge tag 'ptrace-cleanups-for-v5.18' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 943ad0b62e3c21f324c4884caa6cb4a871bca05c Mon Sep 17 00:00:00 2001 From: Pavel Begunkov <asml.silence(a)gmail.com> Date: Wed, 10 Jul 2024 18:58:18 +0100 Subject: [PATCH] kernel: rerun task_work while freezing in get_signal() io_uring can asynchronously add a task_work while the task is getting freezed. TIF_NOTIFY_SIGNAL will prevent the task from sleeping in do_freezer_trap(), and since the get_signal()'s relock loop doesn't retry task_work, the task will spin there not being able to sleep until the freezing is cancelled / the task is killed / etc. Run task_works in the freezer path. Keep the patch small and simple so it can be easily back ported, but we might need to do some cleaning after and look if there are other places with similar problems. Cc: stable(a)vger.kernel.org Link: https://github.com/systemd/systemd/issues/33626 Fixes: 12db8b690010c ("entry: Add support for TIF_NOTIFY_SIGNAL") Reported-by: Julian Orth <ju.orth(a)gmail.com> Acked-by: Oleg Nesterov <oleg(a)redhat.com> Acked-by: Tejun Heo <tj(a)kernel.org> Signed-off-by: Pavel Begunkov <asml.silence(a)gmail.com> Link: https://lore.kernel.org/r/89ed3a52933370deaaf61a0a620a6ac91f1e754d.17206341… Signed-off-by: Jens Axboe <axboe(a)kernel.dk> diff --git a/kernel/signal.c b/kernel/signal.c index 1f9dd41c04be..60c737e423a1 100644 --- a/kernel/signal.c +++ b/kernel/signal.c @@ -2600,6 +2600,14 @@ static void do_freezer_trap(void) spin_unlock_irq(&current->sighand->siglock); cgroup_enter_frozen(); schedule(); + + /* + * We could've been woken by task_work, run it to clear + * TIF_NOTIFY_SIGNAL. The caller will retry if necessary. + */ + clear_notify_signal(); + if (unlikely(task_work_pending(current))) + task_work_run(); } static int ptrace_signal(int signr, kernel_siginfo_t *info, enum pid_type type)

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] thermal/drivers/broadcom: Fix race between removal and clock" failed to apply to 6.6-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.6-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.6.y git checkout FETCH_HEAD git cherry-pick -x e90c369cc2ffcf7145a46448de101f715a1f5584 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072901-rare-engaging-abb3@gregkh' --subject-prefix 'PATCH 6.6.y' HEAD^.. Possible dependencies: e90c369cc2ff ("thermal/drivers/broadcom: Fix race between removal and clock disable") f29ecd3748a2 ("thermal: bcm2835: Convert to platform remove callback returning void") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From e90c369cc2ffcf7145a46448de101f715a1f5584 Mon Sep 17 00:00:00 2001 From: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> Date: Tue, 9 Jul 2024 14:59:31 +0200 Subject: [PATCH] thermal/drivers/broadcom: Fix race between removal and clock disable During the probe, driver enables clocks necessary to access registers (in get_temp()) and then registers thermal zone with managed-resources (devm) interface. Removal of device is not done in reversed order, because: 1. Clock will be disabled in driver remove() callback - thermal zone is still registered and accessible to users, 2. devm interface will unregister thermal zone. This leaves short window between (1) and (2) for accessing the get_temp() callback with disabled clock. Fix this by enabling clock also via devm-interface, so entire cleanup path will be in proper, reversed order. Fixes: 8454c8c09c77 ("thermal/drivers/bcm2835: Remove buggy call to thermal_of_zone_unregister") Cc: stable(a)vger.kernel.org Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> Link: https://lore.kernel.org/r/20240709-thermal-probe-v1-1-241644e2b6e0@linaro.o… Signed-off-by: Daniel Lezcano <daniel.lezcano(a)linaro.org> diff --git a/drivers/thermal/broadcom/bcm2835_thermal.c b/drivers/thermal/broadcom/bcm2835_thermal.c index 5c1cebe07580..3b1030fc4fbf 100644 --- a/drivers/thermal/broadcom/bcm2835_thermal.c +++ b/drivers/thermal/broadcom/bcm2835_thermal.c @@ -185,7 +185,7 @@ static int bcm2835_thermal_probe(struct platform_device *pdev) return err; } - data->clk = devm_clk_get(&pdev->dev, NULL); + data->clk = devm_clk_get_enabled(&pdev->dev, NULL); if (IS_ERR(data->clk)) { err = PTR_ERR(data->clk); if (err != -EPROBE_DEFER) @@ -193,10 +193,6 @@ static int bcm2835_thermal_probe(struct platform_device *pdev) return err; } - err = clk_prepare_enable(data->clk); - if (err) - return err; - rate = clk_get_rate(data->clk); if ((rate < 1920000) || (rate > 5000000)) dev_warn(&pdev->dev, @@ -211,7 +207,7 @@ static int bcm2835_thermal_probe(struct platform_device *pdev) dev_err(&pdev->dev, "Failed to register the thermal device: %d\n", err); - goto err_clk; + return err; } /* @@ -236,7 +232,7 @@ static int bcm2835_thermal_probe(struct platform_device *pdev) dev_err(&pdev->dev, "Not able to read trip_temp: %d\n", err); - goto err_tz; + return err; } /* set bandgap reference voltage and enable voltage regulator */ @@ -269,17 +265,11 @@ static int bcm2835_thermal_probe(struct platform_device *pdev) */ err = thermal_add_hwmon_sysfs(tz); if (err) - goto err_tz; + return err; bcm2835_thermal_debugfs(pdev); return 0; -err_tz: - devm_thermal_of_zone_unregister(&pdev->dev, tz); -err_clk: - clk_disable_unprepare(data->clk); - - return err; } static void bcm2835_thermal_remove(struct platform_device *pdev) @@ -287,7 +277,6 @@ static void bcm2835_thermal_remove(struct platform_device *pdev) struct bcm2835_thermal_data *data = platform_get_drvdata(pdev); debugfs_remove_recursive(data->debugfsdir); - clk_disable_unprepare(data->clk); } static struct platform_driver bcm2835_thermal_driver = {

1 year, 4 months

1
0
0 0

EFI backports from v6.11-rc to v6.6 and newer

by Ard Biesheuvel

Please consider the following patches (in this order) for backporting to v6.6 and newer. fb318ca0a522295edd6d796fb987e99ec41f0ee5 ae835a96d72cd025421910edb0e8faf706998727 The second patch addresses a regression on older Dell hardware. The first one is a prerequisite for the second one, and a minor bugfix itself. Thanks, Ard.

1 year, 4 months

2
1
0 0

FAILED: patch "[PATCH] mm/mglru: fix ineffective protection calculation" failed to apply to 6.10-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.10.y git checkout FETCH_HEAD git cherry-pick -x 30d77b7eef019fa4422980806e8b7cdc8674493e # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072911-marshland-grab-ced7@gregkh' --subject-prefix 'PATCH 6.10.y' HEAD^.. Possible dependencies: 30d77b7eef01 ("mm/mglru: fix ineffective protection calculation") 3f74e6bd3b84 ("mm/mglru: fix overshooting shrinker memory") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 30d77b7eef019fa4422980806e8b7cdc8674493e Mon Sep 17 00:00:00 2001 From: Yu Zhao <yuzhao(a)google.com> Date: Fri, 12 Jul 2024 17:29:56 -0600 Subject: [PATCH] mm/mglru: fix ineffective protection calculation mem_cgroup_calculate_protection() is not stateless and should only be used as part of a top-down tree traversal. shrink_one() traverses the per-node memcg LRU instead of the root_mem_cgroup tree, and therefore it should not call mem_cgroup_calculate_protection(). The existing misuse in shrink_one() can cause ineffective protection of sub-trees that are grandchildren of root_mem_cgroup. Fix it by reusing lru_gen_age_node(), which already traverses the root_mem_cgroup tree, to calculate the protection. Previously lru_gen_age_node() opportunistically skips the first pass, i.e., when scan_control->priority is DEF_PRIORITY. On the second pass, lruvec_is_sizable() uses appropriate scan_control->priority, set by set_initial_priority() from lru_gen_shrink_node(), to decide whether a memcg is too small to reclaim from. Now lru_gen_age_node() unconditionally traverses the root_mem_cgroup tree. So it should call set_initial_priority() upfront, to make sure lruvec_is_sizable() uses appropriate scan_control->priority on the first pass. Otherwise, lruvec_is_reclaimable() can return false negatives and result in premature OOM kills when min_ttl_ms is used. Link: https://lkml.kernel.org/r/20240712232956.1427127-1-yuzhao@google.com Fixes: e4dde56cd208 ("mm: multi-gen LRU: per-node lru_gen_folio lists") Signed-off-by: Yu Zhao <yuzhao(a)google.com> Reported-by: T.J. Mercier <tjmercier(a)google.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> diff --git a/mm/vmscan.c b/mm/vmscan.c index 6216d79edb7f..525d3ffa8451 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -3915,6 +3915,32 @@ static bool try_to_inc_max_seq(struct lruvec *lruvec, unsigned long seq, * working set protection ******************************************************************************/ +static void set_initial_priority(struct pglist_data *pgdat, struct scan_control *sc) +{ + int priority; + unsigned long reclaimable; + + if (sc->priority != DEF_PRIORITY || sc->nr_to_reclaim < MIN_LRU_BATCH) + return; + /* + * Determine the initial priority based on + * (total >> priority) * reclaimed_to_scanned_ratio = nr_to_reclaim, + * where reclaimed_to_scanned_ratio = inactive / total. + */ + reclaimable = node_page_state(pgdat, NR_INACTIVE_FILE); + if (can_reclaim_anon_pages(NULL, pgdat->node_id, sc)) + reclaimable += node_page_state(pgdat, NR_INACTIVE_ANON); + + /* round down reclaimable and round up sc->nr_to_reclaim */ + priority = fls_long(reclaimable) - 1 - fls_long(sc->nr_to_reclaim - 1); + + /* + * The estimation is based on LRU pages only, so cap it to prevent + * overshoots of shrinker objects by large margins. + */ + sc->priority = clamp(priority, DEF_PRIORITY / 2, DEF_PRIORITY); +} + static bool lruvec_is_sizable(struct lruvec *lruvec, struct scan_control *sc) { int gen, type, zone; @@ -3948,19 +3974,17 @@ static bool lruvec_is_reclaimable(struct lruvec *lruvec, struct scan_control *sc struct mem_cgroup *memcg = lruvec_memcg(lruvec); DEFINE_MIN_SEQ(lruvec); - /* see the comment on lru_gen_folio */ - gen = lru_gen_from_seq(min_seq[LRU_GEN_FILE]); - birth = READ_ONCE(lruvec->lrugen.timestamps[gen]); - - if (time_is_after_jiffies(birth + min_ttl)) + if (mem_cgroup_below_min(NULL, memcg)) return false; if (!lruvec_is_sizable(lruvec, sc)) return false; - mem_cgroup_calculate_protection(NULL, memcg); + /* see the comment on lru_gen_folio */ + gen = lru_gen_from_seq(min_seq[LRU_GEN_FILE]); + birth = READ_ONCE(lruvec->lrugen.timestamps[gen]); - return !mem_cgroup_below_min(NULL, memcg); + return time_is_before_jiffies(birth + min_ttl); } /* to protect the working set of the last N jiffies */ @@ -3970,23 +3994,20 @@ static void lru_gen_age_node(struct pglist_data *pgdat, struct scan_control *sc) { struct mem_cgroup *memcg; unsigned long min_ttl = READ_ONCE(lru_gen_min_ttl); + bool reclaimable = !min_ttl; VM_WARN_ON_ONCE(!current_is_kswapd()); - /* check the order to exclude compaction-induced reclaim */ - if (!min_ttl || sc->order || sc->priority == DEF_PRIORITY) - return; + set_initial_priority(pgdat, sc); memcg = mem_cgroup_iter(NULL, NULL, NULL); do { struct lruvec *lruvec = mem_cgroup_lruvec(memcg, pgdat); - if (lruvec_is_reclaimable(lruvec, sc, min_ttl)) { - mem_cgroup_iter_break(NULL, memcg); - return; - } + mem_cgroup_calculate_protection(NULL, memcg); - cond_resched(); + if (!reclaimable) + reclaimable = lruvec_is_reclaimable(lruvec, sc, min_ttl); } while ((memcg = mem_cgroup_iter(NULL, memcg, NULL))); /* @@ -3994,7 +4015,7 @@ static void lru_gen_age_node(struct pglist_data *pgdat, struct scan_control *sc) * younger than min_ttl. However, another possibility is all memcgs are * either too small or below min. */ - if (mutex_trylock(&oom_lock)) { + if (!reclaimable && mutex_trylock(&oom_lock)) { struct oom_control oc = { .gfp_mask = sc->gfp_mask, }; @@ -4786,8 +4807,7 @@ static int shrink_one(struct lruvec *lruvec, struct scan_control *sc) struct mem_cgroup *memcg = lruvec_memcg(lruvec); struct pglist_data *pgdat = lruvec_pgdat(lruvec); - mem_cgroup_calculate_protection(NULL, memcg); - + /* lru_gen_age_node() called mem_cgroup_calculate_protection() */ if (mem_cgroup_below_min(NULL, memcg)) return MEMCG_LRU_YOUNG; @@ -4911,32 +4931,6 @@ static void lru_gen_shrink_lruvec(struct lruvec *lruvec, struct scan_control *sc blk_finish_plug(&plug); } -static void set_initial_priority(struct pglist_data *pgdat, struct scan_control *sc) -{ - int priority; - unsigned long reclaimable; - - if (sc->priority != DEF_PRIORITY || sc->nr_to_reclaim < MIN_LRU_BATCH) - return; - /* - * Determine the initial priority based on - * (total >> priority) * reclaimed_to_scanned_ratio = nr_to_reclaim, - * where reclaimed_to_scanned_ratio = inactive / total. - */ - reclaimable = node_page_state(pgdat, NR_INACTIVE_FILE); - if (can_reclaim_anon_pages(NULL, pgdat->node_id, sc)) - reclaimable += node_page_state(pgdat, NR_INACTIVE_ANON); - - /* round down reclaimable and round up sc->nr_to_reclaim */ - priority = fls_long(reclaimable) - 1 - fls_long(sc->nr_to_reclaim - 1); - - /* - * The estimation is based on LRU pages only, so cap it to prevent - * overshoots of shrinker objects by large margins. - */ - sc->priority = clamp(priority, DEF_PRIORITY / 2, DEF_PRIORITY); -} - static void lru_gen_shrink_node(struct pglist_data *pgdat, struct scan_control *sc) { struct blk_plug plug;

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] mm/migrate: putback split folios when numa hint migration" failed to apply to 6.10-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.10.y git checkout FETCH_HEAD git cherry-pick -x 6e49019db5f7a09a9c0e8ac4d108e656c3f8e583 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072937-aloe-fog-7fc4@gregkh' --subject-prefix 'PATCH 6.10.y' HEAD^.. Possible dependencies: 6e49019db5f7 ("mm/migrate: putback split folios when numa hint migration fails") ee86814b0562 ("mm/migrate: move NUMA hinting fault folio isolation + checks under PTL") 4b88c23ab8c9 ("mm/migrate: make migrate_misplaced_folio() return 0 on success") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 6e49019db5f7a09a9c0e8ac4d108e656c3f8e583 Mon Sep 17 00:00:00 2001 From: Peter Xu <peterx(a)redhat.com> Date: Mon, 8 Jul 2024 17:55:37 -0400 Subject: [PATCH] mm/migrate: putback split folios when numa hint migration fails This issue is not from any report yet, but by code observation only. This is yet another fix besides Hugh's patch [1] but on relevant code path, where eager split of folio can happen if the folio is already on deferred list during a folio migration. Here the issue is NUMA path (migrate_misplaced_folio()) may start to encounter such folio split now even with MR_NUMA_MISPLACED hint applied. Then when migrate_pages() didn't migrate all the folios, it's possible the split small folios be put onto the list instead of the original folio. Then putting back only the head page won't be enough. Fix it by putting back all the folios on the list. [1] https://lore.kernel.org/all/46c948b4-4dd8-6e03-4c7b-ce4e81cfa536@google.com/ [akpm(a)linux-foundation.org: remove now unused local `nr_pages'] Link: https://lkml.kernel.org/r/20240708215537.2630610-1-peterx@redhat.com Fixes: 7262f208ca68 ("mm/migrate: split source folio if it is on deferred split list") Signed-off-by: Peter Xu <peterx(a)redhat.com> Reviewed-by: Zi Yan <ziy(a)nvidia.com> Reviewed-by: Baolin Wang <baolin.wang(a)linux.alibaba.com> Cc: Yang Shi <shy828301(a)gmail.com> Cc: Hugh Dickins <hughd(a)google.com> Cc: Huang Ying <ying.huang(a)intel.com> Cc: David Hildenbrand <david(a)redhat.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> diff --git a/mm/migrate.c b/mm/migrate.c index 6eb9df239230..bdbb5bb04c91 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -2621,20 +2621,13 @@ int migrate_misplaced_folio(struct folio *folio, struct vm_area_struct *vma, int nr_remaining; unsigned int nr_succeeded; LIST_HEAD(migratepages); - int nr_pages = folio_nr_pages(folio); list_add(&folio->lru, &migratepages); nr_remaining = migrate_pages(&migratepages, alloc_misplaced_dst_folio, NULL, node, MIGRATE_ASYNC, MR_NUMA_MISPLACED, &nr_succeeded); - if (nr_remaining) { - if (!list_empty(&migratepages)) { - list_del(&folio->lru); - node_stat_mod_folio(folio, NR_ISOLATED_ANON + - folio_is_file_lru(folio), -nr_pages); - folio_putback_lru(folio); - } - } + if (nr_remaining && !list_empty(&migratepages)) + putback_movable_pages(&migratepages); if (nr_succeeded) { count_vm_numa_events(NUMA_PAGE_MIGRATE, nr_succeeded); if (!node_is_toptier(folio_nid(folio)) && node_is_toptier(node))

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] mm: avoid overflows in dirty throttling logic" failed to apply to 6.10-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.10.y git checkout FETCH_HEAD git cherry-pick -x 68ed2a394a0190433ba982b353579075a29099bd # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072925-darling-chaplain-8e34@gregkh' --subject-prefix 'PATCH 6.10.y' HEAD^.. Possible dependencies: 68ed2a394a01 ("mm: avoid overflows in dirty throttling logic") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 68ed2a394a0190433ba982b353579075a29099bd Mon Sep 17 00:00:00 2001 From: Jan Kara <jack(a)suse.cz> Date: Fri, 21 Jun 2024 16:42:38 +0200 Subject: [PATCH] mm: avoid overflows in dirty throttling logic The dirty throttling logic is interspersed with assumptions that dirty limits in PAGE_SIZE units fit into 32-bit (so that various multiplications fit into 64-bits). If limits end up being larger, we will hit overflows, possible divisions by 0 etc. Fix these problems by never allowing so large dirty limits as they have dubious practical value anyway. For dirty_bytes / dirty_background_bytes interfaces we can just refuse to set so large limits. For dirty_ratio / dirty_background_ratio it isn't so simple as the dirty limit is computed from the amount of available memory which can change due to memory hotplug etc. So when converting dirty limits from ratios to numbers of pages, we just don't allow the result to exceed UINT_MAX. This is root-only triggerable problem which occurs when the operator sets dirty limits to >16 TB. Link: https://lkml.kernel.org/r/20240621144246.11148-2-jack@suse.cz Signed-off-by: Jan Kara <jack(a)suse.cz> Reported-by: Zach O'Keefe <zokeefe(a)google.com> Reviewed-By: Zach O'Keefe <zokeefe(a)google.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> diff --git a/mm/page-writeback.c b/mm/page-writeback.c index c4aa6e84c20a..acff24e9fae4 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -417,13 +417,20 @@ static void domain_dirty_limits(struct dirty_throttle_control *dtc) else bg_thresh = (bg_ratio * available_memory) / PAGE_SIZE; - if (bg_thresh >= thresh) - bg_thresh = thresh / 2; tsk = current; if (rt_task(tsk)) { bg_thresh += bg_thresh / 4 + global_wb_domain.dirty_limit / 32; thresh += thresh / 4 + global_wb_domain.dirty_limit / 32; } + /* + * Dirty throttling logic assumes the limits in page units fit into + * 32-bits. This gives 16TB dirty limits max which is hopefully enough. + */ + if (thresh > UINT_MAX) + thresh = UINT_MAX; + /* This makes sure bg_thresh is within 32-bits as well */ + if (bg_thresh >= thresh) + bg_thresh = thresh / 2; dtc->thresh = thresh; dtc->bg_thresh = bg_thresh; @@ -473,7 +480,11 @@ static unsigned long node_dirty_limit(struct pglist_data *pgdat) if (rt_task(tsk)) dirty += dirty / 4; - return dirty; + /* + * Dirty throttling logic assumes the limits in page units fit into + * 32-bits. This gives 16TB dirty limits max which is hopefully enough. + */ + return min_t(unsigned long, dirty, UINT_MAX); } /** @@ -510,10 +521,17 @@ static int dirty_background_bytes_handler(struct ctl_table *table, int write, void *buffer, size_t *lenp, loff_t *ppos) { int ret; + unsigned long old_bytes = dirty_background_bytes; ret = proc_doulongvec_minmax(table, write, buffer, lenp, ppos); - if (ret == 0 && write) + if (ret == 0 && write) { + if (DIV_ROUND_UP(dirty_background_bytes, PAGE_SIZE) > + UINT_MAX) { + dirty_background_bytes = old_bytes; + return -ERANGE; + } dirty_background_ratio = 0; + } return ret; } @@ -539,6 +557,10 @@ static int dirty_bytes_handler(struct ctl_table *table, int write, ret = proc_doulongvec_minmax(table, write, buffer, lenp, ppos); if (ret == 0 && write && vm_dirty_bytes != old_bytes) { + if (DIV_ROUND_UP(vm_dirty_bytes, PAGE_SIZE) > UINT_MAX) { + vm_dirty_bytes = old_bytes; + return -ERANGE; + } writeback_set_ratelimit(); vm_dirty_ratio = 0; }

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] mm/hugetlb: fix kernel NULL pointer dereference when" failed to apply to 6.10-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.10.y git checkout FETCH_HEAD git cherry-pick -x 1390a3334a48ecac5175865fd433d55eec255db8 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072954-overhung-citrus-9daa@gregkh' --subject-prefix 'PATCH 6.10.y' HEAD^.. Possible dependencies: 1390a3334a48 ("mm/hugetlb: fix kernel NULL pointer dereference when migrating hugetlb folio") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 1390a3334a48ecac5175865fd433d55eec255db8 Mon Sep 17 00:00:00 2001 From: Miaohe Lin <linmiaohe(a)huawei.com> Date: Tue, 9 Jul 2024 20:04:33 +0800 Subject: [PATCH] mm/hugetlb: fix kernel NULL pointer dereference when migrating hugetlb folio A kernel crash was observed when migrating hugetlb folio: BUG: kernel NULL pointer dereference, address: 0000000000000008 PGD 0 P4D 0 Oops: Oops: 0002 [#1] PREEMPT SMP NOPTI CPU: 0 PID: 3435 Comm: bash Not tainted 6.10.0-rc6-00450-g8578ca01f21f #66 RIP: 0010:__folio_undo_large_rmappable+0x70/0xb0 RSP: 0018:ffffb165c98a7b38 EFLAGS: 00000097 RAX: fffffbbc44528090 RBX: 0000000000000000 RCX: 0000000000000000 RDX: ffffa30e000a2800 RSI: 0000000000000246 RDI: ffffa3153ffffcc0 RBP: fffffbbc44528000 R08: 0000000000002371 R09: ffffffffbe4e5868 R10: 0000000000000001 R11: 0000000000000001 R12: ffffa3153ffffcc0 R13: fffffbbc44468000 R14: 0000000000000001 R15: 0000000000000001 FS: 00007f5b3a716740(0000) GS:ffffa3151fc00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000000000008 CR3: 000000010959a000 CR4: 00000000000006f0 Call Trace: <TASK> __folio_migrate_mapping+0x59e/0x950 __migrate_folio.constprop.0+0x5f/0x120 move_to_new_folio+0xfd/0x250 migrate_pages+0x383/0xd70 soft_offline_page+0x2ab/0x7f0 soft_offline_page_store+0x52/0x90 kernfs_fop_write_iter+0x12c/0x1d0 vfs_write+0x380/0x540 ksys_write+0x64/0xe0 do_syscall_64+0xb9/0x1d0 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f5b3a514887 RSP: 002b:00007ffe138fce68 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 RAX: ffffffffffffffda RBX: 000000000000000c RCX: 00007f5b3a514887 RDX: 000000000000000c RSI: 0000556ab809ee10 RDI: 0000000000000001 RBP: 0000556ab809ee10 R08: 00007f5b3a5d1460 R09: 000000007fffffff R10: 0000000000000000 R11: 0000000000000246 R12: 000000000000000c R13: 00007f5b3a61b780 R14: 00007f5b3a617600 R15: 00007f5b3a616a00 It's because hugetlb folio is passed to __folio_undo_large_rmappable() unexpectedly. large_rmappable flag is imperceptibly set to hugetlb folio since commit f6a8dd98a2ce ("hugetlb: convert alloc_buddy_hugetlb_folio to use a folio"). Then commit be9581ea8c05 ("mm: fix crashes from deferred split racing folio migration") makes folio_migrate_mapping() call folio_undo_large_rmappable() triggering the bug. Fix this issue by clearing large_rmappable flag for hugetlb folios. They don't need that flag set anyway. Link: https://lkml.kernel.org/r/20240709120433.4136700-1-linmiaohe@huawei.com Fixes: f6a8dd98a2ce ("hugetlb: convert alloc_buddy_hugetlb_folio to use a folio") Fixes: be9581ea8c05 ("mm: fix crashes from deferred split racing folio migration") Signed-off-by: Miaohe Lin <linmiaohe(a)huawei.com> Cc: Hugh Dickins <hughd(a)google.com> Cc: Matthew Wilcox (Oracle) <willy(a)infradead.org> Cc: Muchun Song <muchun.song(a)linux.dev> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 80a93b69652f..11f25e00a293 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -2166,6 +2166,9 @@ static struct folio *alloc_buddy_hugetlb_folio(struct hstate *h, nid = numa_mem_id(); retry: folio = __folio_alloc(gfp_mask, order, nid, nmask); + /* Ensure hugetlb folio won't have large_rmappable flag set. */ + if (folio) + folio_clear_large_rmappable(folio); if (folio && !folio_ref_freeze(folio, 1)) { folio_put(folio);

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] mm: fix khugepaged activation policy" failed to apply to 6.10-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.10.y git checkout FETCH_HEAD git cherry-pick -x 00f58104202c472e487f0866fbd38832523fd4f9 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072942-compare-unworried-8aec@gregkh' --subject-prefix 'PATCH 6.10.y' HEAD^.. Possible dependencies: 00f58104202c ("mm: fix khugepaged activation policy") 7f83bf14603e ("mm/huge_memory: mark racy access onhuge_anon_orders_always") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 00f58104202c472e487f0866fbd38832523fd4f9 Mon Sep 17 00:00:00 2001 From: Ryan Roberts <ryan.roberts(a)arm.com> Date: Thu, 4 Jul 2024 10:10:50 +0100 Subject: [PATCH] mm: fix khugepaged activation policy Since the introduction of mTHP, the docuementation has stated that khugepaged would be enabled when any mTHP size is enabled, and disabled when all mTHP sizes are disabled. There are 2 problems with this; 1. this is not what was implemented by the code and 2. this is not the desirable behavior. Desirable behavior is for khugepaged to be enabled when any PMD-sized THP is enabled, anon or file. (Note that file THP is still controlled by the top-level control so we must always consider that, as well as the PMD-size mTHP control for anon). khugepaged only supports collapsing to PMD-sized THP so there is no value in enabling it when PMD-sized THP is disabled. So let's change the code and documentation to reflect this policy. Further, per-size enabled control modification events were not previously forwarded to khugepaged to give it an opportunity to start or stop. Consequently the following was resulting in khugepaged eroneously not being activated: echo never > /sys/kernel/mm/transparent_hugepage/enabled echo always > /sys/kernel/mm/transparent_hugepage/hugepages-2048kB/enabled [ryan.roberts(a)arm.com: v3] Link: https://lkml.kernel.org/r/20240705102849.2479686-1-ryan.roberts@arm.com Link: https://lkml.kernel.org/r/20240705102849.2479686-1-ryan.roberts@arm.com Link: https://lkml.kernel.org/r/20240704091051.2411934-1-ryan.roberts@arm.com Signed-off-by: Ryan Roberts <ryan.roberts(a)arm.com> Fixes: 3485b88390b0 ("mm: thp: introduce multi-size THP sysfs interface") Closes: https://lore.kernel.org/linux-mm/7a0bbe69-1e3d-4263-b206-da007791a5c4@redha… Acked-by: David Hildenbrand <david(a)redhat.com> Cc: Baolin Wang <baolin.wang(a)linux.alibaba.com> Cc: Barry Song <baohua(a)kernel.org> Cc: Jonathan Corbet <corbet(a)lwn.net> Cc: Lance Yang <ioworker0(a)gmail.com> Cc: Yang Shi <shy828301(a)gmail.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> diff --git a/Documentation/admin-guide/mm/transhuge.rst b/Documentation/admin-guide/mm/transhuge.rst index a1bc9b24e29a..fe237825b95c 100644 --- a/Documentation/admin-guide/mm/transhuge.rst +++ b/Documentation/admin-guide/mm/transhuge.rst @@ -202,12 +202,11 @@ PMD-mappable transparent hugepage:: cat /sys/kernel/mm/transparent_hugepage/hpage_pmd_size -khugepaged will be automatically started when one or more hugepage -sizes are enabled (either by directly setting "always" or "madvise", -or by setting "inherit" while the top-level enabled is set to "always" -or "madvise"), and it'll be automatically shutdown when the last -hugepage size is disabled (either by directly setting "never", or by -setting "inherit" while the top-level enabled is set to "never"). +khugepaged will be automatically started when PMD-sized THP is enabled +(either of the per-size anon control or the top-level control are set +to "always" or "madvise"), and it'll be automatically shutdown when +PMD-sized THP is disabled (when both the per-size anon control and the +top-level control are "never") Khugepaged controls ------------------- diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h index cee3c5da8f0e..acb6ac24a07e 100644 --- a/include/linux/huge_mm.h +++ b/include/linux/huge_mm.h @@ -128,18 +128,6 @@ static inline bool hugepage_global_always(void) (1<<TRANSPARENT_HUGEPAGE_FLAG); } -static inline bool hugepage_flags_enabled(void) -{ - /* - * We cover both the anon and the file-backed case here; we must return - * true if globally enabled, even when all anon sizes are set to never. - * So we don't need to look at huge_anon_orders_inherit. - */ - return hugepage_global_enabled() || - READ_ONCE(huge_anon_orders_always) || - READ_ONCE(huge_anon_orders_madvise); -} - static inline int highest_order(unsigned long orders) { return fls_long(orders) - 1; diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 17fb072a0ca1..f8b5cbd4dd71 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -502,6 +502,13 @@ static ssize_t thpsize_enabled_store(struct kobject *kobj, } else ret = -EINVAL; + if (ret > 0) { + int err; + + err = start_stop_khugepaged(); + if (err) + ret = err; + } return ret; } diff --git a/mm/khugepaged.c b/mm/khugepaged.c index 409f67a817f1..a5ec03ef8722 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -413,6 +413,26 @@ static inline int hpage_collapse_test_exit_or_disable(struct mm_struct *mm) test_bit(MMF_DISABLE_THP, &mm->flags); } +static bool hugepage_pmd_enabled(void) +{ + /* + * We cover both the anon and the file-backed case here; file-backed + * hugepages, when configured in, are determined by the global control. + * Anon pmd-sized hugepages are determined by the pmd-size control. + */ + if (IS_ENABLED(CONFIG_READ_ONLY_THP_FOR_FS) && + hugepage_global_enabled()) + return true; + if (test_bit(PMD_ORDER, &huge_anon_orders_always)) + return true; + if (test_bit(PMD_ORDER, &huge_anon_orders_madvise)) + return true; + if (test_bit(PMD_ORDER, &huge_anon_orders_inherit) && + hugepage_global_enabled()) + return true; + return false; +} + void __khugepaged_enter(struct mm_struct *mm) { struct khugepaged_mm_slot *mm_slot; @@ -449,7 +469,7 @@ void khugepaged_enter_vma(struct vm_area_struct *vma, unsigned long vm_flags) { if (!test_bit(MMF_VM_HUGEPAGE, &vma->vm_mm->flags) && - hugepage_flags_enabled()) { + hugepage_pmd_enabled()) { if (thp_vma_allowable_order(vma, vm_flags, TVA_ENFORCE_SYSFS, PMD_ORDER)) __khugepaged_enter(vma->vm_mm); @@ -2462,8 +2482,7 @@ static unsigned int khugepaged_scan_mm_slot(unsigned int pages, int *result, static int khugepaged_has_work(void) { - return !list_empty(&khugepaged_scan.mm_head) && - hugepage_flags_enabled(); + return !list_empty(&khugepaged_scan.mm_head) && hugepage_pmd_enabled(); } static int khugepaged_wait_event(void) @@ -2536,7 +2555,7 @@ static void khugepaged_wait_work(void) return; } - if (hugepage_flags_enabled()) + if (hugepage_pmd_enabled()) wait_event_freezable(khugepaged_wait, khugepaged_wait_event()); } @@ -2567,7 +2586,7 @@ static void set_recommended_min_free_kbytes(void) int nr_zones = 0; unsigned long recommended_min; - if (!hugepage_flags_enabled()) { + if (!hugepage_pmd_enabled()) { calculate_min_free_kbytes(); goto update_wmarks; } @@ -2617,7 +2636,7 @@ int start_stop_khugepaged(void) int err = 0; mutex_lock(&khugepaged_mutex); - if (hugepage_flags_enabled()) { + if (hugepage_pmd_enabled()) { if (!khugepaged_thread) khugepaged_thread = kthread_run(khugepaged, NULL, "khugepaged"); @@ -2643,7 +2662,7 @@ int start_stop_khugepaged(void) void khugepaged_min_free_kbytes_update(void) { mutex_lock(&khugepaged_mutex); - if (hugepage_flags_enabled() && khugepaged_thread) + if (hugepage_pmd_enabled() && khugepaged_thread) set_recommended_min_free_kbytes(); mutex_unlock(&khugepaged_mutex); }

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] mm/huge_memory: avoid PMD-size page cache if needed" failed to apply to 6.1-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.1-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.1.y git checkout FETCH_HEAD git cherry-pick -x d659b715e94ac039803d7601505d3473393fc0be # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072952-envision-salvation-6c3a@gregkh' --subject-prefix 'PATCH 6.1.y' HEAD^.. Possible dependencies: d659b715e94a ("mm/huge_memory: avoid PMD-size page cache if needed") e0ffb29bc54d ("mm: simplify thp_vma_allowable_order") 19eaf44954df ("mm: thp: support allocation of anonymous multi-size THP") 3485b88390b0 ("mm: thp: introduce multi-size THP sysfs interface") 7a81751fcdeb ("mm/thp: fix "mm: thp: kill __transhuge_page_enabled()"") 5003a2bdf688 ("mm: call update_mmu_cache_range() in more page fault handling paths") daa60ae64c65 ("mm,thp: fix smaps THPeligible output alignment") 3db82b9374ca ("mm/memory: allow pte_offset_map[_lock]() to fail") 3b65f437d9e8 ("mm: fix failure to unmap pte on highmem systems") 2bad466cc9d9 ("mm/uffd: UFFD_FEATURE_WP_UNPOPULATED") 3c556d2425b0 ("mm/thp: rename TRANSPARENT_HUGEPAGE_NEVER_DAX to _UNSUPPORTED") 28d41a486331 ("mm: convert wp_page_copy() to use folios") cb3184deef10 ("mm: convert do_anonymous_page() to use a folio") 6bc56a4d8553 ("mm: add vma_alloc_zeroed_movable_folio()") 2cf1338454a8 ("mm: fix khugepaged with shmem_enabled=advise") d1751118c886 ("mm/uffd: detect pgtable allocation failures") a79390f5d6a7 ("mm/mprotect: use long for page accountings and retval") 1ef488edd6c4 ("mm/mprotect: drop pgprot_t parameter from change_protection()") 931298e103c2 ("mm/userfaultfd: rely on vma->vm_page_prot in uffd_wp_range()") fed15f1345dc ("mm/hugetlb: pre-allocate pgtable pages for uffd wr-protects") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From d659b715e94ac039803d7601505d3473393fc0be Mon Sep 17 00:00:00 2001 From: Gavin Shan <gshan(a)redhat.com> Date: Mon, 15 Jul 2024 10:04:23 +1000 Subject: [PATCH] mm/huge_memory: avoid PMD-size page cache if needed xarray can't support arbitrary page cache size. the largest and supported page cache size is defined as MAX_PAGECACHE_ORDER by commit 099d90642a71 ("mm/filemap: make MAX_PAGECACHE_ORDER acceptable to xarray"). However, it's possible to have 512MB page cache in the huge memory's collapsing path on ARM64 system whose base page size is 64KB. 512MB page cache is breaking the limitation and a warning is raised when the xarray entry is split as shown in the following example. [root@dhcp-10-26-1-207 ~]# cat /proc/1/smaps | grep KernelPageSize KernelPageSize: 64 kB [root@dhcp-10-26-1-207 ~]# cat /tmp/test.c : int main(int argc, char **argv) { const char *filename = TEST_XFS_FILENAME; int fd = 0; void *buf = (void *)-1, *p; int pgsize = getpagesize(); int ret = 0; if (pgsize != 0x10000) { fprintf(stdout, "System with 64KB base page size is required!\n"); return -EPERM; } system("echo 0 > /sys/devices/virtual/bdi/253:0/read_ahead_kb"); system("echo 1 > /proc/sys/vm/drop_caches"); /* Open the xfs file */ fd = open(filename, O_RDONLY); assert(fd > 0); /* Create VMA */ buf = mmap(NULL, TEST_MEM_SIZE, PROT_READ, MAP_SHARED, fd, 0); assert(buf != (void *)-1); fprintf(stdout, "mapped buffer at 0x%p\n", buf); /* Populate VMA */ ret = madvise(buf, TEST_MEM_SIZE, MADV_NOHUGEPAGE); assert(ret == 0); ret = madvise(buf, TEST_MEM_SIZE, MADV_POPULATE_READ); assert(ret == 0); /* Collapse VMA */ ret = madvise(buf, TEST_MEM_SIZE, MADV_HUGEPAGE); assert(ret == 0); ret = madvise(buf, TEST_MEM_SIZE, MADV_COLLAPSE); if (ret) { fprintf(stdout, "Error %d to madvise(MADV_COLLAPSE)\n", errno); goto out; } /* Split xarray entry. Write permission is needed */ munmap(buf, TEST_MEM_SIZE); buf = (void *)-1; close(fd); fd = open(filename, O_RDWR); assert(fd > 0); fallocate(fd, FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE, TEST_MEM_SIZE - pgsize, pgsize); out: if (buf != (void *)-1) munmap(buf, TEST_MEM_SIZE); if (fd > 0) close(fd); return ret; } [root@dhcp-10-26-1-207 ~]# gcc /tmp/test.c -o /tmp/test [root@dhcp-10-26-1-207 ~]# /tmp/test ------------[ cut here ]------------ WARNING: CPU: 25 PID: 7560 at lib/xarray.c:1025 xas_split_alloc+0xf8/0x128 Modules linked in: nft_fib_inet nft_fib_ipv4 nft_fib_ipv6 nft_fib \ nft_reject_inet nf_reject_ipv4 nf_reject_ipv6 nft_reject nft_ct \ nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 \ ip_set rfkill nf_tables nfnetlink vfat fat virtio_balloon drm fuse \ xfs libcrc32c crct10dif_ce ghash_ce sha2_ce sha256_arm64 virtio_net \ sha1_ce net_failover virtio_blk virtio_console failover dimlib virtio_mmio CPU: 25 PID: 7560 Comm: test Kdump: loaded Not tainted 6.10.0-rc7-gavin+ #9 Hardware name: QEMU KVM Virtual Machine, BIOS edk2-20240524-1.el9 05/24/2024 pstate: 83400005 (Nzcv daif +PAN -UAO +TCO +DIT -SSBS BTYPE=--) pc : xas_split_alloc+0xf8/0x128 lr : split_huge_page_to_list_to_order+0x1c4/0x780 sp : ffff8000ac32f660 x29: ffff8000ac32f660 x28: ffff0000e0969eb0 x27: ffff8000ac32f6c0 x26: 0000000000000c40 x25: ffff0000e0969eb0 x24: 000000000000000d x23: ffff8000ac32f6c0 x22: ffffffdfc0700000 x21: 0000000000000000 x20: 0000000000000000 x19: ffffffdfc0700000 x18: 0000000000000000 x17: 0000000000000000 x16: ffffd5f3708ffc70 x15: 0000000000000000 x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000000 x11: ffffffffffffffc0 x10: 0000000000000040 x9 : ffffd5f3708e692c x8 : 0000000000000003 x7 : 0000000000000000 x6 : ffff0000e0969eb8 x5 : ffffd5f37289e378 x4 : 0000000000000000 x3 : 0000000000000c40 x2 : 000000000000000d x1 : 000000000000000c x0 : 0000000000000000 Call trace: xas_split_alloc+0xf8/0x128 split_huge_page_to_list_to_order+0x1c4/0x780 truncate_inode_partial_folio+0xdc/0x160 truncate_inode_pages_range+0x1b4/0x4a8 truncate_pagecache_range+0x84/0xa0 xfs_flush_unmap_range+0x70/0x90 [xfs] xfs_file_fallocate+0xfc/0x4d8 [xfs] vfs_fallocate+0x124/0x2f0 ksys_fallocate+0x4c/0xa0 __arm64_sys_fallocate+0x24/0x38 invoke_syscall.constprop.0+0x7c/0xd8 do_el0_svc+0xb4/0xd0 el0_svc+0x44/0x1d8 el0t_64_sync_handler+0x134/0x150 el0t_64_sync+0x17c/0x180 Fix it by correcting the supported page cache orders, different sets for DAX and other files. With it corrected, 512MB page cache becomes disallowed on all non-DAX files on ARM64 system where the base page size is 64KB. After this patch is applied, the test program fails with error -EINVAL returned from __thp_vma_allowable_orders() and the madvise() system call to collapse the page caches. Link: https://lkml.kernel.org/r/20240715000423.316491-1-gshan@redhat.com Fixes: 6b24ca4a1a8d ("mm: Use multi-index entries in the page cache") Signed-off-by: Gavin Shan <gshan(a)redhat.com> Acked-by: David Hildenbrand <david(a)redhat.com> Reviewed-by: Ryan Roberts <ryan.roberts(a)arm.com> Acked-by: Zi Yan <ziy(a)nvidia.com> Cc: Baolin Wang <baolin.wang(a)linux.alibaba.com> Cc: Barry Song <baohua(a)kernel.org> Cc: Don Dutile <ddutile(a)redhat.com> Cc: Matthew Wilcox (Oracle) <willy(a)infradead.org> Cc: Peter Xu <peterx(a)redhat.com> Cc: Ryan Roberts <ryan.roberts(a)arm.com> Cc: William Kucharski <william.kucharski(a)oracle.com> Cc: <stable(a)vger.kernel.org> [5.17+] Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h index cff002be83eb..e25d9ebfdf89 100644 --- a/include/linux/huge_mm.h +++ b/include/linux/huge_mm.h @@ -74,14 +74,20 @@ extern struct kobj_attribute thpsize_shmem_enabled_attr; #define THP_ORDERS_ALL_ANON ((BIT(PMD_ORDER + 1) - 1) & ~(BIT(0) | BIT(1))) /* - * Mask of all large folio orders supported for file THP. + * Mask of all large folio orders supported for file THP. Folios in a DAX + * file is never split and the MAX_PAGECACHE_ORDER limit does not apply to + * it. */ -#define THP_ORDERS_ALL_FILE (BIT(PMD_ORDER) | BIT(PUD_ORDER)) +#define THP_ORDERS_ALL_FILE_DAX \ + (BIT(PMD_ORDER) | BIT(PUD_ORDER)) +#define THP_ORDERS_ALL_FILE_DEFAULT \ + ((BIT(MAX_PAGECACHE_ORDER + 1) - 1) & ~BIT(0)) /* * Mask of all large folio orders supported for THP. */ -#define THP_ORDERS_ALL (THP_ORDERS_ALL_ANON | THP_ORDERS_ALL_FILE) +#define THP_ORDERS_ALL \ + (THP_ORDERS_ALL_ANON | THP_ORDERS_ALL_FILE_DAX | THP_ORDERS_ALL_FILE_DEFAULT) #define TVA_SMAPS (1 << 0) /* Will be used for procfs */ #define TVA_IN_PF (1 << 1) /* Page fault handler */ diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 04b72912035d..f4be468e06a4 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -89,9 +89,17 @@ unsigned long __thp_vma_allowable_orders(struct vm_area_struct *vma, bool smaps = tva_flags & TVA_SMAPS; bool in_pf = tva_flags & TVA_IN_PF; bool enforce_sysfs = tva_flags & TVA_ENFORCE_SYSFS; + unsigned long supported_orders; + /* Check the intersection of requested and supported orders. */ - orders &= vma_is_anonymous(vma) ? - THP_ORDERS_ALL_ANON : THP_ORDERS_ALL_FILE; + if (vma_is_anonymous(vma)) + supported_orders = THP_ORDERS_ALL_ANON; + else if (vma_is_dax(vma)) + supported_orders = THP_ORDERS_ALL_FILE_DAX; + else + supported_orders = THP_ORDERS_ALL_FILE_DEFAULT; + + orders &= supported_orders; if (!orders) return 0;

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] mm/huge_memory: avoid PMD-size page cache if needed" failed to apply to 6.6-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.6-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.6.y git checkout FETCH_HEAD git cherry-pick -x d659b715e94ac039803d7601505d3473393fc0be # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072950-factsheet-cabbie-418a@gregkh' --subject-prefix 'PATCH 6.6.y' HEAD^.. Possible dependencies: d659b715e94a ("mm/huge_memory: avoid PMD-size page cache if needed") e0ffb29bc54d ("mm: simplify thp_vma_allowable_order") 19eaf44954df ("mm: thp: support allocation of anonymous multi-size THP") 3485b88390b0 ("mm: thp: introduce multi-size THP sysfs interface") 7a81751fcdeb ("mm/thp: fix "mm: thp: kill __transhuge_page_enabled()"") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From d659b715e94ac039803d7601505d3473393fc0be Mon Sep 17 00:00:00 2001 From: Gavin Shan <gshan(a)redhat.com> Date: Mon, 15 Jul 2024 10:04:23 +1000 Subject: [PATCH] mm/huge_memory: avoid PMD-size page cache if needed xarray can't support arbitrary page cache size. the largest and supported page cache size is defined as MAX_PAGECACHE_ORDER by commit 099d90642a71 ("mm/filemap: make MAX_PAGECACHE_ORDER acceptable to xarray"). However, it's possible to have 512MB page cache in the huge memory's collapsing path on ARM64 system whose base page size is 64KB. 512MB page cache is breaking the limitation and a warning is raised when the xarray entry is split as shown in the following example. [root@dhcp-10-26-1-207 ~]# cat /proc/1/smaps | grep KernelPageSize KernelPageSize: 64 kB [root@dhcp-10-26-1-207 ~]# cat /tmp/test.c : int main(int argc, char **argv) { const char *filename = TEST_XFS_FILENAME; int fd = 0; void *buf = (void *)-1, *p; int pgsize = getpagesize(); int ret = 0; if (pgsize != 0x10000) { fprintf(stdout, "System with 64KB base page size is required!\n"); return -EPERM; } system("echo 0 > /sys/devices/virtual/bdi/253:0/read_ahead_kb"); system("echo 1 > /proc/sys/vm/drop_caches"); /* Open the xfs file */ fd = open(filename, O_RDONLY); assert(fd > 0); /* Create VMA */ buf = mmap(NULL, TEST_MEM_SIZE, PROT_READ, MAP_SHARED, fd, 0); assert(buf != (void *)-1); fprintf(stdout, "mapped buffer at 0x%p\n", buf); /* Populate VMA */ ret = madvise(buf, TEST_MEM_SIZE, MADV_NOHUGEPAGE); assert(ret == 0); ret = madvise(buf, TEST_MEM_SIZE, MADV_POPULATE_READ); assert(ret == 0); /* Collapse VMA */ ret = madvise(buf, TEST_MEM_SIZE, MADV_HUGEPAGE); assert(ret == 0); ret = madvise(buf, TEST_MEM_SIZE, MADV_COLLAPSE); if (ret) { fprintf(stdout, "Error %d to madvise(MADV_COLLAPSE)\n", errno); goto out; } /* Split xarray entry. Write permission is needed */ munmap(buf, TEST_MEM_SIZE); buf = (void *)-1; close(fd); fd = open(filename, O_RDWR); assert(fd > 0); fallocate(fd, FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE, TEST_MEM_SIZE - pgsize, pgsize); out: if (buf != (void *)-1) munmap(buf, TEST_MEM_SIZE); if (fd > 0) close(fd); return ret; } [root@dhcp-10-26-1-207 ~]# gcc /tmp/test.c -o /tmp/test [root@dhcp-10-26-1-207 ~]# /tmp/test ------------[ cut here ]------------ WARNING: CPU: 25 PID: 7560 at lib/xarray.c:1025 xas_split_alloc+0xf8/0x128 Modules linked in: nft_fib_inet nft_fib_ipv4 nft_fib_ipv6 nft_fib \ nft_reject_inet nf_reject_ipv4 nf_reject_ipv6 nft_reject nft_ct \ nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 \ ip_set rfkill nf_tables nfnetlink vfat fat virtio_balloon drm fuse \ xfs libcrc32c crct10dif_ce ghash_ce sha2_ce sha256_arm64 virtio_net \ sha1_ce net_failover virtio_blk virtio_console failover dimlib virtio_mmio CPU: 25 PID: 7560 Comm: test Kdump: loaded Not tainted 6.10.0-rc7-gavin+ #9 Hardware name: QEMU KVM Virtual Machine, BIOS edk2-20240524-1.el9 05/24/2024 pstate: 83400005 (Nzcv daif +PAN -UAO +TCO +DIT -SSBS BTYPE=--) pc : xas_split_alloc+0xf8/0x128 lr : split_huge_page_to_list_to_order+0x1c4/0x780 sp : ffff8000ac32f660 x29: ffff8000ac32f660 x28: ffff0000e0969eb0 x27: ffff8000ac32f6c0 x26: 0000000000000c40 x25: ffff0000e0969eb0 x24: 000000000000000d x23: ffff8000ac32f6c0 x22: ffffffdfc0700000 x21: 0000000000000000 x20: 0000000000000000 x19: ffffffdfc0700000 x18: 0000000000000000 x17: 0000000000000000 x16: ffffd5f3708ffc70 x15: 0000000000000000 x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000000 x11: ffffffffffffffc0 x10: 0000000000000040 x9 : ffffd5f3708e692c x8 : 0000000000000003 x7 : 0000000000000000 x6 : ffff0000e0969eb8 x5 : ffffd5f37289e378 x4 : 0000000000000000 x3 : 0000000000000c40 x2 : 000000000000000d x1 : 000000000000000c x0 : 0000000000000000 Call trace: xas_split_alloc+0xf8/0x128 split_huge_page_to_list_to_order+0x1c4/0x780 truncate_inode_partial_folio+0xdc/0x160 truncate_inode_pages_range+0x1b4/0x4a8 truncate_pagecache_range+0x84/0xa0 xfs_flush_unmap_range+0x70/0x90 [xfs] xfs_file_fallocate+0xfc/0x4d8 [xfs] vfs_fallocate+0x124/0x2f0 ksys_fallocate+0x4c/0xa0 __arm64_sys_fallocate+0x24/0x38 invoke_syscall.constprop.0+0x7c/0xd8 do_el0_svc+0xb4/0xd0 el0_svc+0x44/0x1d8 el0t_64_sync_handler+0x134/0x150 el0t_64_sync+0x17c/0x180 Fix it by correcting the supported page cache orders, different sets for DAX and other files. With it corrected, 512MB page cache becomes disallowed on all non-DAX files on ARM64 system where the base page size is 64KB. After this patch is applied, the test program fails with error -EINVAL returned from __thp_vma_allowable_orders() and the madvise() system call to collapse the page caches. Link: https://lkml.kernel.org/r/20240715000423.316491-1-gshan@redhat.com Fixes: 6b24ca4a1a8d ("mm: Use multi-index entries in the page cache") Signed-off-by: Gavin Shan <gshan(a)redhat.com> Acked-by: David Hildenbrand <david(a)redhat.com> Reviewed-by: Ryan Roberts <ryan.roberts(a)arm.com> Acked-by: Zi Yan <ziy(a)nvidia.com> Cc: Baolin Wang <baolin.wang(a)linux.alibaba.com> Cc: Barry Song <baohua(a)kernel.org> Cc: Don Dutile <ddutile(a)redhat.com> Cc: Matthew Wilcox (Oracle) <willy(a)infradead.org> Cc: Peter Xu <peterx(a)redhat.com> Cc: Ryan Roberts <ryan.roberts(a)arm.com> Cc: William Kucharski <william.kucharski(a)oracle.com> Cc: <stable(a)vger.kernel.org> [5.17+] Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h index cff002be83eb..e25d9ebfdf89 100644 --- a/include/linux/huge_mm.h +++ b/include/linux/huge_mm.h @@ -74,14 +74,20 @@ extern struct kobj_attribute thpsize_shmem_enabled_attr; #define THP_ORDERS_ALL_ANON ((BIT(PMD_ORDER + 1) - 1) & ~(BIT(0) | BIT(1))) /* - * Mask of all large folio orders supported for file THP. + * Mask of all large folio orders supported for file THP. Folios in a DAX + * file is never split and the MAX_PAGECACHE_ORDER limit does not apply to + * it. */ -#define THP_ORDERS_ALL_FILE (BIT(PMD_ORDER) | BIT(PUD_ORDER)) +#define THP_ORDERS_ALL_FILE_DAX \ + (BIT(PMD_ORDER) | BIT(PUD_ORDER)) +#define THP_ORDERS_ALL_FILE_DEFAULT \ + ((BIT(MAX_PAGECACHE_ORDER + 1) - 1) & ~BIT(0)) /* * Mask of all large folio orders supported for THP. */ -#define THP_ORDERS_ALL (THP_ORDERS_ALL_ANON | THP_ORDERS_ALL_FILE) +#define THP_ORDERS_ALL \ + (THP_ORDERS_ALL_ANON | THP_ORDERS_ALL_FILE_DAX | THP_ORDERS_ALL_FILE_DEFAULT) #define TVA_SMAPS (1 << 0) /* Will be used for procfs */ #define TVA_IN_PF (1 << 1) /* Page fault handler */ diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 04b72912035d..f4be468e06a4 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -89,9 +89,17 @@ unsigned long __thp_vma_allowable_orders(struct vm_area_struct *vma, bool smaps = tva_flags & TVA_SMAPS; bool in_pf = tva_flags & TVA_IN_PF; bool enforce_sysfs = tva_flags & TVA_ENFORCE_SYSFS; + unsigned long supported_orders; + /* Check the intersection of requested and supported orders. */ - orders &= vma_is_anonymous(vma) ? - THP_ORDERS_ALL_ANON : THP_ORDERS_ALL_FILE; + if (vma_is_anonymous(vma)) + supported_orders = THP_ORDERS_ALL_ANON; + else if (vma_is_dax(vma)) + supported_orders = THP_ORDERS_ALL_FILE_DAX; + else + supported_orders = THP_ORDERS_ALL_FILE_DEFAULT; + + orders &= supported_orders; if (!orders) return 0;

1 year, 4 months

1
0
0 0

Linux 6.9.12

by Greg Kroah-Hartman

I'm announcing the release of the 6.9.12 kernel. All users of the 6.9 kernel series must upgrade. The updated 6.9.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-6.9.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Makefile | 2 - arch/arm64/boot/dts/qcom/ipq6018.dtsi | 1 arch/arm64/boot/dts/qcom/ipq8074.dtsi | 2 + arch/arm64/boot/dts/qcom/msm8996.dtsi | 1 arch/arm64/boot/dts/qcom/msm8998.dtsi | 1 arch/arm64/boot/dts/qcom/qrb2210-rb1.dts | 13 +++++++- arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 13 +++++++- arch/arm64/boot/dts/qcom/sc7180.dtsi | 1 arch/arm64/boot/dts/qcom/sc7280.dtsi | 1 arch/arm64/boot/dts/qcom/sdm630.dtsi | 1 arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 + arch/arm64/boot/dts/qcom/sm6115.dtsi | 1 arch/arm64/boot/dts/qcom/sm6350.dtsi | 1 arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 17 ++++++++--- arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 17 ++++++++--- arch/s390/mm/fault.c | 3 + drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 - drivers/net/tap.c | 5 +++ drivers/net/tun.c | 3 + drivers/usb/gadget/function/f_midi2.c | 19 +++++++----- fs/jfs/xattr.c | 23 ++++++++++++--- fs/locks.c | 9 ++--- fs/ntfs3/fslog.c | 44 ++++++++++++++++++++++++---- fs/ocfs2/dir.c | 46 ++++++++++++++++++------------ sound/core/pcm_dmaengine.c | 6 +++ sound/core/seq/seq_ump_client.c | 16 ++++++++++ sound/pci/hda/patch_realtek.c | 3 + 27 files changed, 198 insertions(+), 55 deletions(-) Abel Vesa (4): arm64: dts: qcom: x1e80100-qcp: Fix USB PHYs regulators arm64: dts: qcom: x1e80100-crd: Fix the PHY regulator for PCIe 6a arm64: dts: qcom: x1e80100-qcp: Fix the PHY regulator for PCIe 6a arm64: dts: qcom: x1e80100-crd: Fix USB PHYs regulators Dan Carpenter (1): drm/amdgpu: Fix signedness bug in sdma_v4_0_process_trap_irq() Dmitry Baryshkov (2): arm64: dts: qcom: qrb2210-rb1: switch I2C2 to i2c-gpio arm64: dts: qcom: qrb4210-rb2: switch I2C2 to i2c-gpio Dongli Zhang (1): tun: add missing verification for short frame Edson Juliano Drosdeck (1): ALSA: hda/realtek: Enable headset mic on Positivo SU C1400 Gerald Schaefer (1): s390/mm: Fix VM_FAULT_HWPOISON handling in do_exception() Greg Kroah-Hartman (1): Linux 6.9.12 Jann Horn (1): filelock: Fix fcntl/close race recovery compat path Konstantin Komarov (1): fs/ntfs3: Add a check for attr_names and oatbl Krishna Kurapati (10): arm64: dts: qcom: sc7180: Disable SuperSpeed instances in park mode arm64: dts: qcom: sc7280: Disable SuperSpeed instances in park mode arm64: dts: qcom: msm8996: Disable SS instance in Parkmode for USB arm64: dts: qcom: sm6350: Disable SS instance in Parkmode for USB arm64: dts: qcom: msm8998: Disable SS instance in Parkmode for USB arm64: dts: qcom: ipq6018: Disable SS instance in Parkmode for USB arm64: dts: qcom: sdm630: Disable SS instance in Parkmode for USB arm64: dts: qcom: ipq8074: Disable SS instance in Parkmode for USB arm64: dts: qcom: sdm845: Disable SS instance in Parkmode for USB arm64: dts: qcom: sm6115: Disable SS instance in Parkmode for USB Seunghun Han (1): ALSA: hda/realtek: Fix the speaker output on Samsung Galaxy Book Pro 360 Shenghao Ding (1): ALSA: hda/tas2781: Add new quirk for Lenovo Hera2 Laptop Shengjiu Wang (1): ALSA: pcm_dmaengine: Don't synchronize DMA channel when DMA is paused Si-Wei Liu (1): tap: add missing verification for short frame Takashi Iwai (2): usb: gadget: midi2: Fix incorrect default MIDI2 protocol setup ALSA: seq: ump: Skip useless ports for static blocks lei lu (3): ocfs2: add bounds checking to ocfs2_check_dir_entry() jfs: don't walk off the end of ealist fs/ntfs3: Validate ff offset

1 year, 4 months

1
2
0 0

[PATCH v1 2/2] mm/hugetlb: fix hugetlb vs. core-mm PT locking

by David Hildenbrand

We recently made GUP's common page table walking code to also walk hugetlb VMAs without most hugetlb special-casing, preparing for the future of having less hugetlb-specific page table walking code in the codebase. Turns out that we missed one page table locking detail: page table locking for hugetlb folios that are not mapped using a single PMD/PUD. Assume we have hugetlb folio that spans multiple PTEs (e.g., 64 KiB hugetlb folios on arm64 with 4 KiB base page size). GUP, as it walks the page tables, will perform a pte_offset_map_lock() to grab the PTE table lock. However, hugetlb that concurrently modifies these page tables would actually grab the mm->page_table_lock: with USE_SPLIT_PTE_PTLOCKS, the locks would differ. Something similar can happen right now with hugetlb folios that span multiple PMDs when USE_SPLIT_PMD_PTLOCKS. Let's make huge_pte_lockptr() effectively uses the same PT locks as any core-mm page table walker would. There is one ugly case: powerpc 8xx, whereby we have an 8 MiB hugetlb folio being mapped using two PTE page tables. While hugetlb wants to take the PMD table lock, core-mm would grab the PTE table lock of one of both PTE page tables. In such corner cases, we have to make sure that both locks match, which is (fortunately!) currently guaranteed for 8xx as it does not support SMP. Fixes: 9cb28da54643 ("mm/gup: handle hugetlb in the generic follow_page_mask code") Cc: <stable(a)vger.kernel.org> Signed-off-by: David Hildenbrand <david(a)redhat.com> --- include/linux/hugetlb.h | 25 ++++++++++++++++++++++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h index c9bf68c239a01..da800e56fe590 100644 --- a/include/linux/hugetlb.h +++ b/include/linux/hugetlb.h @@ -944,10 +944,29 @@ static inline bool htlb_allow_alloc_fallback(int reason) static inline spinlock_t *huge_pte_lockptr(struct hstate *h, struct mm_struct *mm, pte_t *pte) { - if (huge_page_size(h) == PMD_SIZE) + VM_WARN_ON(huge_page_size(h) == PAGE_SIZE); + VM_WARN_ON(huge_page_size(h) >= P4D_SIZE); + + /* + * hugetlb must use the exact same PT locks as core-mm page table + * walkers would. When modifying a PTE table, hugetlb must take the + * PTE PT lock, when modifying a PMD table, hugetlb must take the PMD + * PT lock etc. + * + * The expectation is that any hugetlb folio smaller than a PMD is + * always mapped into a single PTE table and that any hugetlb folio + * smaller than a PUD (but at least as big as a PMD) is always mapped + * into a single PMD table. + * + * If that does not hold for an architecture, then that architecture + * must disable split PT locks such that all *_lockptr() functions + * will give us the same result: the per-MM PT lock. + */ + if (huge_page_size(h) < PMD_SIZE) + return pte_lockptr(mm, pte); + else if (huge_page_size(h) < PUD_SIZE) return pmd_lockptr(mm, (pmd_t *) pte); - VM_BUG_ON(huge_page_size(h) == PAGE_SIZE); - return &mm->page_table_lock; + return pud_lockptr(mm, (pud_t *) pte); } #ifndef hugepages_supported -- 2.45.2

1 year, 4 months

5
11
0 0

[PATCH v3] arm64: dts: qcom: sa8775p: Mark APPS and PCIe SMMUs as DMA coherent

by Qingqing Zhou

The SMMUs on sa8775p are cache-coherent. GPU SMMU is marked as such, mark the APPS and PCIe ones as well. Fixes: 603f96d4c9d0 ("arm64: dts: qcom: add initial support for qcom sa8775p-ride") Fixes: 2dba7a613a6e ("arm64: dts: qcom: sa8775p: add the pcie smmu node") Cc: stable(a)vger.kernel.org Reviewed-by: Konrad Dybcio <konrad.dybcio(a)linaro.org> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam(a)linaro.org> Signed-off-by: Qingqing Zhou <quic_qqzhou(a)quicinc.com> --- v2 -> v3: - Remove the line break between tags. - Add the Cc stable tag. Link to v2: https://lore.kernel.org/all/20240723075948.9545-1-quic_qqzhou@quicinc.com/ v1 -> v2: - Add the Fixes tags. - Update the commit message. Link to v1: https://lore.kernel.org/lkml/20240715071649.25738-1-quic_qqzhou@quicinc.com/ --- arch/arm64/boot/dts/qcom/sa8775p.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi index 23f1b2e5e624..95691ab58a23 100644 --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi @@ -3070,6 +3070,7 @@ reg = <0x0 0x15000000 0x0 0x100000>; #iommu-cells = <2>; #global-interrupts = <2>; + dma-coherent; interrupts = <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>, @@ -3208,6 +3209,7 @@ reg = <0x0 0x15200000 0x0 0x80000>; #iommu-cells = <2>; #global-interrupts = <2>; + dma-coherent; interrupts = <GIC_SPI 920 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 921 IRQ_TYPE_LEVEL_HIGH>, -- 2.17.1

1 year, 4 months

2
1
0 0

[PATCH v2] soc: qcom: cmd-db: Map shared memory as WC, not WB

by Maulik Shah

From: Volodymyr Babchuk <Volodymyr_Babchuk(a)epam.com> Linux does not write into cmd-db region. This region of memory is write protected by XPU. XPU may sometime falsely detect clean cache eviction as "write" into the write protected region leading to secure interrupt which causes an endless loop somewhere in Trust Zone. The only reason it is working right now is because Qualcomm Hypervisor maps the same region as Non-Cacheable memory in Stage 2 translation tables. The issue manifests if we want to use another hypervisor (like Xen or KVM), which does not know anything about those specific mappings. Changing the mapping of cmd-db memory from MEMREMAP_WB to MEMREMAP_WT/WC removes dependency on correct mappings in Stage 2 tables. This patch fixes the issue by updating the mapping to MEMREMAP_WC. I tested this on SA8155P with Xen. Fixes: 312416d9171a ("drivers: qcom: add command DB driver") Cc: stable(a)vger.kernel.org # 5.4+ Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk(a)epam.com> Tested-by: Nikita Travkin <nikita(a)trvn.ru> # sc7180 WoA in EL2 Signed-off-by: Maulik Shah <quic_mkshah(a)quicinc.com> --- Changes in v2: - Use MEMREMAP_WC instead of MEMREMAP_WT - Update commit message from comments in v1 - Add Fixes tag and Cc to stable - Link to v1: https://lore.kernel.org/lkml/20240327200917.2576034-1-volodymyr_babchuk@epa… --- drivers/soc/qcom/cmd-db.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/qcom/cmd-db.c b/drivers/soc/qcom/cmd-db.c index d84572662017..ae66c2623d25 100644 --- a/drivers/soc/qcom/cmd-db.c +++ b/drivers/soc/qcom/cmd-db.c @@ -349,7 +349,7 @@ static int cmd_db_dev_probe(struct platform_device *pdev) return -EINVAL; } - cmd_db_header = memremap(rmem->base, rmem->size, MEMREMAP_WB); + cmd_db_header = memremap(rmem->base, rmem->size, MEMREMAP_WC); if (!cmd_db_header) { ret = -ENOMEM; cmd_db_header = NULL; --- base-commit: 797012914d2d031430268fe512af0ccd7d8e46ef change-id: 20240718-cmd_db_uncached-e896da5c5296 Best regards, -- Maulik Shah <quic_mkshah(a)quicinc.com>

1 year, 4 months

4
7
0 0

[PATCH] clk: qcom: gcc-sm8450: Do not turn off PCIe GDSCs during gdsc_disable()

by Manivannan Sadhasivam

With PWRSTS_OFF_ON, PCIe GDSCs are turned off during gdsc_disable(). This can happen during scenarios such as system suspend and breaks the resume of PCIe controllers from suspend. So use PWRSTS_RET_ON to indicate the GDSC driver to not turn off the GDSCs during gdsc_disable() and allow the hardware to transition the GDSCs to retention when the parent domain enters low power state during system suspend. Cc: stable(a)vger.kernel.org # 5.17 Fixes: db0c944ee92b ("clk: qcom: Add clock driver for SM8450") Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam(a)linaro.org> --- drivers/clk/qcom/gcc-sm8450.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/qcom/gcc-sm8450.c b/drivers/clk/qcom/gcc-sm8450.c index 639a9a955914..c445c271678a 100644 --- a/drivers/clk/qcom/gcc-sm8450.c +++ b/drivers/clk/qcom/gcc-sm8450.c @@ -2974,7 +2974,7 @@ static struct gdsc pcie_0_gdsc = { .pd = { .name = "pcie_0_gdsc", }, - .pwrsts = PWRSTS_OFF_ON, + .pwrsts = PWRSTS_RET_ON, }; static struct gdsc pcie_1_gdsc = { @@ -2982,7 +2982,7 @@ static struct gdsc pcie_1_gdsc = { .pd = { .name = "pcie_1_gdsc", }, - .pwrsts = PWRSTS_OFF_ON, + .pwrsts = PWRSTS_RET_ON, }; static struct gdsc ufs_phy_gdsc = { -- 2.25.1

1 year, 4 months

2
1
0 0

[PATCH] clk: qcom: gcc-sm8250: Do not turn off PCIe GDSCs during gdsc_disable()

by Manivannan Sadhasivam

With PWRSTS_OFF_ON, PCIe GDSCs are turned off during gdsc_disable(). This can happen during scenarios such as system suspend and breaks the resume of PCIe controllers from suspend. So use PWRSTS_RET_ON to indicate the GDSC driver to not turn off the GDSCs during gdsc_disable() and allow the hardware to transition the GDSCs to retention when the parent domain enters low power state during system suspend. Cc: stable(a)vger.kernel.org # 5.7 Fixes: 3e5770921a88 ("clk: qcom: gcc: Add global clock controller driver for SM8250") Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam(a)linaro.org> --- drivers/clk/qcom/gcc-sm8250.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/gcc-sm8250.c b/drivers/clk/qcom/gcc-sm8250.c index 991cd8b8d597..1c59d70e0f96 100644 --- a/drivers/clk/qcom/gcc-sm8250.c +++ b/drivers/clk/qcom/gcc-sm8250.c @@ -3226,7 +3226,7 @@ static struct gdsc pcie_0_gdsc = { .pd = { .name = "pcie_0_gdsc", }, - .pwrsts = PWRSTS_OFF_ON, + .pwrsts = PWRSTS_RET_ON, }; static struct gdsc pcie_1_gdsc = { @@ -3234,7 +3234,7 @@ static struct gdsc pcie_1_gdsc = { .pd = { .name = "pcie_1_gdsc", }, - .pwrsts = PWRSTS_OFF_ON, + .pwrsts = PWRSTS_RET_ON, }; static struct gdsc pcie_2_gdsc = { @@ -3242,7 +3242,7 @@ static struct gdsc pcie_2_gdsc = { .pd = { .name = "pcie_2_gdsc", }, - .pwrsts = PWRSTS_OFF_ON, + .pwrsts = PWRSTS_RET_ON, }; static struct gdsc ufs_card_gdsc = { -- 2.25.1

1 year, 4 months

2
1
0 0

[PATCH 6.9 2/2] Bluetooth: btusb: Add Realtek RTL8852BE support ID 0x13d3:0x3591

by Erpeng Xu

From: WangYuli <wangyuli(a)uniontech.com> commit 0cbc22dfe14453c77e53dbd28a3e27e01b699f31 upstream Add the support ID(0x13d3, 0x3591) to usb_device_id table for Realtek RTL8852BE. The device table is as follows: T: Bus=01 Lev=02 Prnt=03 Port=00 Cnt=01 Dev#= 5 Spd=12 MxCh= 0 D: Ver= 1.00 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 P: Vendor=13d3 ProdID=3591 Rev= 0.00 S: Manufacturer=Realtek S: Product=Bluetooth Radio S: SerialNumber=00e04c000001 C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=500mA I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms Cc: stable(a)vger.kernel.org Signed-off-by: Wentao Guan <guanwentao(a)uniontech.com> Signed-off-by: WangYuli <wangyuli(a)uniontech.com> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz(a)intel.com> Signed-off-by: Erpeng Xu <xuerpeng(a)uniontech.com> --- drivers/bluetooth/btusb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index d507ea9d240c..f8d4869fa221 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -554,6 +554,8 @@ static const struct usb_device_id quirks_table[] = { BTUSB_WIDEBAND_SPEECH }, { USB_DEVICE(0x13d3, 0x3572), .driver_info = BTUSB_REALTEK | BTUSB_WIDEBAND_SPEECH }, + { USB_DEVICE(0x13d3, 0x3591), .driver_info = BTUSB_REALTEK | + BTUSB_WIDEBAND_SPEECH }, { USB_DEVICE(0x0489, 0xe125), .driver_info = BTUSB_REALTEK | BTUSB_WIDEBAND_SPEECH }, -- 2.45.2

1 year, 4 months

1
0
0 0

[PATCH 6.9 1/2] Bluetooth: btusb: Add RTL8852BE device 0489:e125 to device tables

by Erpeng Xu

From: Hilda Wu <hildawu(a)realtek.com> commit 02e1aa098d52b294f80e4929abef4c44f378ddf4 upstream Add the support ID 0489:e125 to usb_device_id table for Realtek RTL8852B chip. The device info from /sys/kernel/debug/usb/devices as below. T: Bus=01 Lev=01 Prnt=01 Port=07 Cnt=03 Dev#= 5 Spd=12 MxCh= 0 D: Ver= 1.00 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 P: Vendor=0489 ProdID=e125 Rev= 0.00 S: Manufacturer=Realtek S: Product=Bluetooth Radio S: SerialNumber=00e04c000001 C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=500mA I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms Signed-off-by: Hilda Wu <hildawu(a)realtek.com> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz(a)intel.com> Signed-off-by: Erpeng Xu <xuerpeng(a)uniontech.com> --- drivers/bluetooth/btusb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index fb716849b60f..d507ea9d240c 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -554,6 +554,8 @@ static const struct usb_device_id quirks_table[] = { BTUSB_WIDEBAND_SPEECH }, { USB_DEVICE(0x13d3, 0x3572), .driver_info = BTUSB_REALTEK | BTUSB_WIDEBAND_SPEECH }, + { USB_DEVICE(0x0489, 0xe125), .driver_info = BTUSB_REALTEK | + BTUSB_WIDEBAND_SPEECH }, /* Realtek 8852BT/8852BE-VT Bluetooth devices */ { USB_DEVICE(0x0bda, 0x8520), .driver_info = BTUSB_REALTEK | -- 2.45.2

1 year, 4 months

1
0
0 0

[PATCH 6.10 2/2] Bluetooth: btusb: Add Realtek RTL8852BE support ID 0x13d3:0x3591

by Erpeng Xu

From: WangYuli <wangyuli(a)uniontech.com> commit 473a89b4ed7fd52a419340f7c540d5c8fc96fc75 upstream Add the support ID(0x13d3, 0x3591) to usb_device_id table for Realtek RTL8852BE. The device table is as follows: T: Bus=01 Lev=02 Prnt=03 Port=00 Cnt=01 Dev#= 5 Spd=12 MxCh= 0 D: Ver= 1.00 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 P: Vendor=13d3 ProdID=3591 Rev= 0.00 S: Manufacturer=Realtek S: Product=Bluetooth Radio S: SerialNumber=00e04c000001 C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=500mA I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms Cc: stable(a)vger.kernel.org Signed-off-by: Wentao Guan <guanwentao(a)uniontech.com> Signed-off-by: WangYuli <wangyuli(a)uniontech.com> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz(a)intel.com> Signed-off-by: Erpeng Xu <xuerpeng(a)uniontech.com> --- drivers/bluetooth/btusb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index aec6da3e37ef..789c492df6fa 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -555,6 +555,8 @@ static const struct usb_device_id quirks_table[] = { BTUSB_WIDEBAND_SPEECH }, { USB_DEVICE(0x13d3, 0x3572), .driver_info = BTUSB_REALTEK | BTUSB_WIDEBAND_SPEECH }, + { USB_DEVICE(0x13d3, 0x3591), .driver_info = BTUSB_REALTEK | + BTUSB_WIDEBAND_SPEECH }, { USB_DEVICE(0x0489, 0xe125), .driver_info = BTUSB_REALTEK | BTUSB_WIDEBAND_SPEECH }, -- 2.45.2

1 year, 4 months

1
0
0 0

[PATCH 6.10 1/2] Bluetooth: btusb: Add RTL8852BE device 0489:e125 to device tables

by Erpeng Xu

From: Hilda Wu <hildawu(a)realtek.com> commit 295ef07a9dae6182ad4b689aa8c6a7dbba21474c upstream Add the support ID 0489:e125 to usb_device_id table for Realtek RTL8852B chip. The device info from /sys/kernel/debug/usb/devices as below. T: Bus=01 Lev=01 Prnt=01 Port=07 Cnt=03 Dev#= 5 Spd=12 MxCh= 0 D: Ver= 1.00 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 P: Vendor=0489 ProdID=e125 Rev= 0.00 S: Manufacturer=Realtek S: Product=Bluetooth Radio S: SerialNumber=00e04c000001 C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=500mA I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms Signed-off-by: Hilda Wu <hildawu(a)realtek.com> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz(a)intel.com> Signed-off-by: Erpeng Xu <xuerpeng(a)uniontech.com> --- drivers/bluetooth/btusb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index e384ef6ff050..aec6da3e37ef 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -555,6 +555,8 @@ static const struct usb_device_id quirks_table[] = { BTUSB_WIDEBAND_SPEECH }, { USB_DEVICE(0x13d3, 0x3572), .driver_info = BTUSB_REALTEK | BTUSB_WIDEBAND_SPEECH }, + { USB_DEVICE(0x0489, 0xe125), .driver_info = BTUSB_REALTEK | + BTUSB_WIDEBAND_SPEECH }, /* Realtek 8852BT/8852BE-VT Bluetooth devices */ { USB_DEVICE(0x0bda, 0x8520), .driver_info = BTUSB_REALTEK | -- 2.45.2

1 year, 4 months

1
0
0 0

[PATCH] [DEBUG] md/raid1: check recovery_offset in raid1_check_read_range

by Mateusz Jończyk

This should fix the filesystem corruption during RAID resync. Checking this condition in raid1_check_read_range is not ideal, but this is only a debug patch. Link: https://lore.kernel.org/lkml/20240724141906.10b4fc4e@peluse-desk5/T/#m671d6… Signed-off-by: Mateusz Jończyk <mat.jonczyk(a)o2.pl> Cc: Yu Kuai <yukuai3(a)huawei.com> Cc: Song Liu <song(a)kernel.org> Cc: stable(a)vger.kernel.org --- drivers/md/raid1-10.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/md/raid1-10.c b/drivers/md/raid1-10.c index 2ea1710a3b70..4ab896e8cb12 100644 --- a/drivers/md/raid1-10.c +++ b/drivers/md/raid1-10.c @@ -252,6 +252,10 @@ static inline int raid1_check_read_range(struct md_rdev *rdev, sector_t first_bad; int bad_sectors; + if (!test_bit(In_sync, &rdev->flags) && + rdev->recovery_offset < this_sector + *len) + return 0; + /* no bad block overlap */ if (!is_badblock(rdev, this_sector, *len, &first_bad, &bad_sectors)) return *len; -- 2.25.1

1 year, 4 months

2
1
0 0

[PATCH v2 0/2] ALSA: firewire-lib: restore process context workqueue to prevent deadlock

by Edmund Raile

This patchset serves to prevent a deadlock between process context and softIRQ context: A. In the process context * (lock A) Acquiring spin_lock by snd_pcm_stream_lock_irq() in snd_pcm_status64() * (lock B) Then attempt to enter tasklet B. In the softIRQ context * (lock B) Enter tasklet * (lock A) Attempt to acquire spin_lock by snd_pcm_stream_lock_irqsave() in snd_pcm_period_elapsed() ? tasklet_unlock_spin_wait </NMI> <TASK> ohci_flush_iso_completions firewire_ohci amdtp_domain_stream_pcm_pointer snd_firewire_lib snd_pcm_update_hw_ptr0 snd_pcm snd_pcm_status64 snd_pcm ? native_queued_spin_lock_slowpath </NMI> <IRQ> _raw_spin_lock_irqsave snd_pcm_period_elapsed snd_pcm process_rx_packets snd_firewire_lib irq_target_callback snd_firewire_lib handle_it_packet firewire_ohci context_tasklet firewire_ohci The issue has been reported as a regression of kernel 5.14: Link: https://lore.kernel.org/regressions/kwryofzdmjvzkuw6j3clftsxmoolynljztxqwg7… ("[REGRESSION] ALSA: firewire-lib: snd_pcm_period_elapsed deadlock with Fireface 800") Commit 7ba5ca32fe6e ("ALSA: firewire-lib: operate for period elapse event in process context") removed the process context workqueue from amdtp_domain_stream_pcm_pointer() and update_pcm_pointers() to remove its overhead. Commit b5b519965c4c ("ALSA: firewire-lib: obsolete workqueue for period update") belongs to the same patch series and removed the now-unused workqueue entirely. Though being observed on RME Fireface 800, this issue would affect all Firewire audio interfaces using ohci amdtp + pcm streaming. ALSA streaming, especially under intensive CPU load will reveal this issue the soonest due to issuing more hardIRQs, with time to occurrence ranging from 2 secons to 30 minutes after starting playback. to reproduce the issue: direct ALSA playback to the device: mpv --audio-device=alsa/sysdefault:CARD=Fireface800 Spor-Ignition.flac Time to occurrence: 2s to 30m Likelihood increased by: - high CPU load stress --cpu $(nproc) - switching between applications via workspaces tested with i915 in Xfce PulsaAudio / PipeWire conceal the issue as they run PCM substream without period wakeup mode, issuing less hardIRQs. Backport note: Also applies to and fixes on (tested): 6.10.2, 6.9.12, 6.6.43, 6.1.102, 5.15.164 Edmund Raile (2): ALSA: firewire-lib: restore workqueue for process context ALSA: firewire-lib: prevent deadlock between process and softIRQ context sound/firewire/amdtp-stream.c | 36 ++++++++++++++++++++++------------- sound/firewire/amdtp-stream.h | 1 + 2 files changed, 24 insertions(+), 13 deletions(-) -- 2.45.2

1 year, 4 months

2
3
0 0

+ mm-vmalloc-combine-all-tlb-flush-operations-of-kasan-shadow-virtual-address-into-one-operation.patch added to mm-unstable branch

by Andrew Morton

The patch titled Subject: mm/vmalloc: combine all TLB flush operations of KASAN shadow virtual address into one operation has been added to the -mm mm-unstable branch. Its filename is mm-vmalloc-combine-all-tlb-flush-operations-of-kasan-shadow-virtual-address-into-one-operation.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patche… This patch will later appear in the mm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Adrian Huang <ahuang12(a)lenovo.com> Subject: mm/vmalloc: combine all TLB flush operations of KASAN shadow virtual address into one operation Date: Sat, 27 Jul 2024 00:52:46 +0800 When compiling kernel source 'make -j $(nproc)' with the up-and-running KASAN-enabled kernel on a 256-core machine, the following soft lockup is shown: watchdog: BUG: soft lockup - CPU#28 stuck for 22s! [kworker/28:1:1760] CPU: 28 PID: 1760 Comm: kworker/28:1 Kdump: loaded Not tainted 6.10.0-rc5 #95 Workqueue: events drain_vmap_area_work RIP: 0010:smp_call_function_many_cond+0x1d8/0xbb0 Code: 38 c8 7c 08 84 c9 0f 85 49 08 00 00 8b 45 08 a8 01 74 2e 48 89 f1 49 89 f7 48 c1 e9 03 41 83 e7 07 4c 01 e9 41 83 c7 03 f3 90 <0f> b6 01 41 38 c7 7c 08 84 c0 0f 85 d4 06 00 00 8b 45 08 a8 01 75 RSP: 0018:ffffc9000cb3fb60 EFLAGS: 00000202 RAX: 0000000000000011 RBX: ffff8883bc4469c0 RCX: ffffed10776e9949 RDX: 0000000000000002 RSI: ffff8883bb74ca48 RDI: ffffffff8434dc50 RBP: ffff8883bb74ca40 R08: ffff888103585dc0 R09: ffff8884533a1800 R10: 0000000000000004 R11: ffffffffffffffff R12: ffffed1077888d39 R13: dffffc0000000000 R14: ffffed1077888d38 R15: 0000000000000003 FS: 0000000000000000(0000) GS:ffff8883bc400000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00005577b5c8d158 CR3: 0000000004850000 CR4: 0000000000350ef0 Call Trace: <IRQ> ? watchdog_timer_fn+0x2cd/0x390 ? __pfx_watchdog_timer_fn+0x10/0x10 ? __hrtimer_run_queues+0x300/0x6d0 ? sched_clock_cpu+0x69/0x4e0 ? __pfx___hrtimer_run_queues+0x10/0x10 ? srso_return_thunk+0x5/0x5f ? ktime_get_update_offsets_now+0x7f/0x2a0 ? srso_return_thunk+0x5/0x5f ? srso_return_thunk+0x5/0x5f ? hrtimer_interrupt+0x2ca/0x760 ? __sysvec_apic_timer_interrupt+0x8c/0x2b0 ? sysvec_apic_timer_interrupt+0x6a/0x90 </IRQ> <TASK> ? asm_sysvec_apic_timer_interrupt+0x16/0x20 ? smp_call_function_many_cond+0x1d8/0xbb0 ? __pfx_do_kernel_range_flush+0x10/0x10 on_each_cpu_cond_mask+0x20/0x40 flush_tlb_kernel_range+0x19b/0x250 ? srso_return_thunk+0x5/0x5f ? kasan_release_vmalloc+0xa7/0xc0 purge_vmap_node+0x357/0x820 ? __pfx_purge_vmap_node+0x10/0x10 __purge_vmap_area_lazy+0x5b8/0xa10 drain_vmap_area_work+0x21/0x30 process_one_work+0x661/0x10b0 worker_thread+0x844/0x10e0 ? srso_return_thunk+0x5/0x5f ? __kthread_parkme+0x82/0x140 ? __pfx_worker_thread+0x10/0x10 kthread+0x2a5/0x370 ? __pfx_kthread+0x10/0x10 ret_from_fork+0x30/0x70 ? __pfx_kthread+0x10/0x10 ret_from_fork_asm+0x1a/0x30 </TASK> Debugging Analysis: 1. The following ftrace log shows that the lockup CPU spends too much time iterating vmap_nodes and flushing TLB when purging vm_area structures. (Some info is trimmed). kworker: funcgraph_entry: | drain_vmap_area_work() { kworker: funcgraph_entry: | mutex_lock() { kworker: funcgraph_entry: 1.092 us | __cond_resched(); kworker: funcgraph_exit: 3.306 us | } ... ... kworker: funcgraph_entry: | flush_tlb_kernel_range() { ... ... kworker: funcgraph_exit: # 7533.649 us | } ... ... kworker: funcgraph_entry: 2.344 us | mutex_unlock(); kworker: funcgraph_exit: $ 23871554 us | } The drain_vmap_area_work() spends over 23 seconds. There are 2805 flush_tlb_kernel_range() calls in the ftrace log. * One is called in __purge_vmap_area_lazy(). * Others are called by purge_vmap_node->kasan_release_vmalloc. purge_vmap_node() iteratively releases kasan vmalloc allocations and flushes TLB for each vmap_area. - [Rough calculation] Each flush_tlb_kernel_range() runs about 7.5ms. -- 2804 * 7.5ms = 21.03 seconds. -- That's why a soft lock is triggered. 2. Extending the soft lockup time can work around the issue (For example, # echo 60 > /proc/sys/kernel/watchdog_thresh). This confirms the above-mentioned speculation: drain_vmap_area_work() spends too much time. If we combine all TLB flush operations of the KASAN shadow virtual address into one operation in the call path 'purge_vmap_node()->kasan_release_vmalloc()', the running time of drain_vmap_area_work() can be saved greatly. The idea is from the flush_tlb_kernel_range() call in __purge_vmap_area_lazy(). And, the soft lockup won't not be triggered. Here is the test result based on 6.10: [6.10 wo/ the patch] 1. ftrace latency profiling (record a trace if the latency > 20s). echo 20000000 > /sys/kernel/debug/tracing/tracing_thresh echo drain_vmap_area_work > /sys/kernel/debug/tracing/set_graph_function echo function_graph > /sys/kernel/debug/tracing/current_tracer echo 1 > /sys/kernel/debug/tracing/tracing_on 2. Run `make -j $(nproc)` to compile the kernel source 3. Once the soft lockup is reproduced, check the ftrace log: cat /sys/kernel/debug/tracing/trace # tracer: function_graph # # CPU DURATION FUNCTION CALLS # | | | | | | | 76) $ 50412985 us | } /* __purge_vmap_area_lazy */ 76) $ 50412997 us | } /* drain_vmap_area_work */ 76) $ 29165911 us | } /* __purge_vmap_area_lazy */ 76) $ 29165926 us | } /* drain_vmap_area_work */ 91) $ 53629423 us | } /* __purge_vmap_area_lazy */ 91) $ 53629434 us | } /* drain_vmap_area_work */ 91) $ 28121014 us | } /* __purge_vmap_area_lazy */ 91) $ 28121026 us | } /* drain_vmap_area_work */ [6.10 w/ the patch] 1. Repeat step 1-2 in "[6.10 wo/ the patch]" 2. The soft lockup is not triggered and ftrace log is empty. cat /sys/kernel/debug/tracing/trace # tracer: function_graph # # CPU DURATION FUNCTION CALLS # | | | | | | | 3. Setting 'tracing_thresh' to 10/5 seconds does not get any ftrace log. 4. Setting 'tracing_thresh' to 1 second gets ftrace log. cat /sys/kernel/debug/tracing/trace # tracer: function_graph # # CPU DURATION FUNCTION CALLS # | | | | | | | 23) $ 1074942 us | } /* __purge_vmap_area_lazy */ 23) $ 1074950 us | } /* drain_vmap_area_work */ The worst execution time of drain_vmap_area_work() is about 1 second. Link: https://lore.kernel.org/lkml/ZqFlawuVnOMY2k3E@pc638.lan/ Link: https://lkml.kernel.org/r/20240726165246.31326-1-ahuang12@lenovo.com Fixes: 282631cb2447 ("mm: vmalloc: remove global purge_vmap_area_root rb-tree") Signed-off-by: Adrian Huang <ahuang12(a)lenovo.com> Co-developed-by: Uladzislau Rezki (Sony) <urezki(a)gmail.com> Signed-off-by: Uladzislau Rezki (Sony) <urezki(a)gmail.com> Tested-by: Jiwei Sun <sunjw10(a)lenovo.com> Cc: Alexander Potapenko <glider(a)google.com> Cc: Andrey Konovalov <andreyknvl(a)gmail.com> Cc: Andrey Ryabinin <ryabinin.a.a(a)gmail.com> Cc: Baoquan He <bhe(a)redhat.com> Cc: Christoph Hellwig <hch(a)infradead.org> Cc: Dmitry Vyukov <dvyukov(a)google.com> Cc: Vincenzo Frascino <vincenzo.frascino(a)arm.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- include/linux/kasan.h | 12 +++++++++--- mm/kasan/shadow.c | 14 ++++++++++---- mm/vmalloc.c | 34 ++++++++++++++++++++++++++-------- 3 files changed, 45 insertions(+), 15 deletions(-) --- a/include/linux/kasan.h~mm-vmalloc-combine-all-tlb-flush-operations-of-kasan-shadow-virtual-address-into-one-operation +++ a/include/linux/kasan.h @@ -29,6 +29,9 @@ typedef unsigned int __bitwise kasan_vma #define KASAN_VMALLOC_VM_ALLOC ((__force kasan_vmalloc_flags_t)0x02u) #define KASAN_VMALLOC_PROT_NORMAL ((__force kasan_vmalloc_flags_t)0x04u) +#define KASAN_VMALLOC_PAGE_RANGE 0x1 /* Apply exsiting page range */ +#define KASAN_VMALLOC_TLB_FLUSH 0x2 /* TLB flush */ + #if defined(CONFIG_KASAN_GENERIC) || defined(CONFIG_KASAN_SW_TAGS) #include <linux/pgtable.h> @@ -531,7 +534,8 @@ void kasan_populate_early_vm_area_shadow int kasan_populate_vmalloc(unsigned long addr, unsigned long size); void kasan_release_vmalloc(unsigned long start, unsigned long end, unsigned long free_region_start, - unsigned long free_region_end); + unsigned long free_region_end, + unsigned long flags); #else /* CONFIG_KASAN_GENERIC || CONFIG_KASAN_SW_TAGS */ @@ -546,7 +550,8 @@ static inline int kasan_populate_vmalloc static inline void kasan_release_vmalloc(unsigned long start, unsigned long end, unsigned long free_region_start, - unsigned long free_region_end) { } + unsigned long free_region_end, + unsigned long flags) { } #endif /* CONFIG_KASAN_GENERIC || CONFIG_KASAN_SW_TAGS */ @@ -581,7 +586,8 @@ static inline int kasan_populate_vmalloc static inline void kasan_release_vmalloc(unsigned long start, unsigned long end, unsigned long free_region_start, - unsigned long free_region_end) { } + unsigned long free_region_end, + unsigned long flags) { } static inline void *kasan_unpoison_vmalloc(const void *start, unsigned long size, --- a/mm/kasan/shadow.c~mm-vmalloc-combine-all-tlb-flush-operations-of-kasan-shadow-virtual-address-into-one-operation +++ a/mm/kasan/shadow.c @@ -489,7 +489,8 @@ static int kasan_depopulate_vmalloc_pte( */ void kasan_release_vmalloc(unsigned long start, unsigned long end, unsigned long free_region_start, - unsigned long free_region_end) + unsigned long free_region_end, + unsigned long flags) { void *shadow_start, *shadow_end; unsigned long region_start, region_end; @@ -522,12 +523,17 @@ void kasan_release_vmalloc(unsigned long __memset(shadow_start, KASAN_SHADOW_INIT, shadow_end - shadow_start); return; } - apply_to_existing_page_range(&init_mm, + + + if (flags & KASAN_VMALLOC_PAGE_RANGE) + apply_to_existing_page_range(&init_mm, (unsigned long)shadow_start, size, kasan_depopulate_vmalloc_pte, NULL); - flush_tlb_kernel_range((unsigned long)shadow_start, - (unsigned long)shadow_end); + + if (flags & KASAN_VMALLOC_TLB_FLUSH) + flush_tlb_kernel_range((unsigned long)shadow_start, + (unsigned long)shadow_end); } } --- a/mm/vmalloc.c~mm-vmalloc-combine-all-tlb-flush-operations-of-kasan-shadow-virtual-address-into-one-operation +++ a/mm/vmalloc.c @@ -2187,6 +2187,25 @@ decay_va_pool_node(struct vmap_node *vn, reclaim_list_global(&decay_list); } +static void +kasan_release_vmalloc_node(struct vmap_node *vn) +{ + struct vmap_area *va; + unsigned long start, end; + + start = list_first_entry(&vn->purge_list, struct vmap_area, list)->va_start; + end = list_last_entry(&vn->purge_list, struct vmap_area, list)->va_end; + + list_for_each_entry(va, &vn->purge_list, list) { + if (is_vmalloc_or_module_addr((void *) va->va_start)) + kasan_release_vmalloc(va->va_start, va->va_end, + va->va_start, va->va_end, + KASAN_VMALLOC_PAGE_RANGE); + } + + kasan_release_vmalloc(start, end, start, end, KASAN_VMALLOC_TLB_FLUSH); +} + static void purge_vmap_node(struct work_struct *work) { struct vmap_node *vn = container_of(work, @@ -2194,20 +2213,17 @@ static void purge_vmap_node(struct work_ struct vmap_area *va, *n_va; LIST_HEAD(local_list); + if (IS_ENABLED(CONFIG_KASAN_VMALLOC)) + kasan_release_vmalloc_node(vn); + vn->nr_purged = 0; list_for_each_entry_safe(va, n_va, &vn->purge_list, list) { unsigned long nr = (va->va_end - va->va_start) >> PAGE_SHIFT; - unsigned long orig_start = va->va_start; - unsigned long orig_end = va->va_end; unsigned int vn_id = decode_vn_id(va->flags); list_del_init(&va->list); - if (is_vmalloc_or_module_addr((void *)orig_start)) - kasan_release_vmalloc(orig_start, orig_end, - va->va_start, va->va_end); - atomic_long_sub(nr, &vmap_lazy_nr); vn->nr_purged++; @@ -4789,7 +4805,8 @@ recovery: &free_vmap_area_list); if (va) kasan_release_vmalloc(orig_start, orig_end, - va->va_start, va->va_end); + va->va_start, va->va_end, + KASAN_VMALLOC_PAGE_RANGE | KASAN_VMALLOC_TLB_FLUSH); vas[area] = NULL; } @@ -4839,7 +4856,8 @@ err_free_shadow: &free_vmap_area_list); if (va) kasan_release_vmalloc(orig_start, orig_end, - va->va_start, va->va_end); + va->va_start, va->va_end, + KASAN_VMALLOC_PAGE_RANGE | KASAN_VMALLOC_TLB_FLUSH); vas[area] = NULL; kfree(vms[area]); } _ Patches currently in -mm which might be from ahuang12(a)lenovo.com are mm-vmalloc-combine-all-tlb-flush-operations-of-kasan-shadow-virtual-address-into-one-operation.patch

1 year, 4 months

1
0
0 0

[PATCH] kbuild: Fix '-S -c' in x86 stack protector scripts

by Nathan Chancellor

After a recent change in clang to stop consuming all instances of '-S' and '-c' [1], the stack protector scripts break due to the kernel's use of -Werror=unused-command-line-argument to catch cases where flags are not being properly consumed by the compiler driver: $ echo | clang -o - -x c - -S -c -Werror=unused-command-line-argument clang: error: argument unused during compilation: '-c' [-Werror,-Wunused-command-line-argument] This results in CONFIG_STACKPROTECTOR getting disabled because CONFIG_CC_HAS_SANE_STACKPROTECTOR is no longer set. '-c' and '-S' both instruct the compiler to stop at different stages of the pipeline ('-S' after compiling, '-c' after assembling), so having them present together in the same command makes little sense. In this case, the test wants to stop before assembling because it is looking at the textual assembly output of the compiler for either '%fs' or '%gs', so remove '-c' from the list of arguments to resolve the error. All versions of GCC continue to work after this change, along with versions of clang that do or do not contain the change mentioned above. Cc: stable(a)vger.kernel.org Fixes: 4f7fd4d7a791 ("[PATCH] Add the -fstack-protector option to the CFLAGS") Fixes: 60a5317ff0f4 ("x86: implement x86_32 stack protector") Link: https://github.com/llvm/llvm-project/commit/6461e537815f7fa68cef06842505353… [1] Signed-off-by: Nathan Chancellor <nathan(a)kernel.org> --- I think this could go via either -tip or Kbuild? Perhaps this is an issue in the clang commit mentioned in the message above since it deviates from GCC (Fangrui is on CC here) but I think the combination of these options is a little dubious to begin with, hence this change. --- scripts/gcc-x86_32-has-stack-protector.sh | 2 +- scripts/gcc-x86_64-has-stack-protector.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/gcc-x86_32-has-stack-protector.sh b/scripts/gcc-x86_32-has-stack-protector.sh index 825c75c5b715..9459ca4f0f11 100755 --- a/scripts/gcc-x86_32-has-stack-protector.sh +++ b/scripts/gcc-x86_32-has-stack-protector.sh @@ -5,4 +5,4 @@ # -mstack-protector-guard-reg, added by # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81708 -echo "int foo(void) { char X[200]; return 3; }" | $* -S -x c -c -m32 -O0 -fstack-protector -mstack-protector-guard-reg=fs -mstack-protector-guard-symbol=__stack_chk_guard - -o - 2> /dev/null | grep -q "%fs" +echo "int foo(void) { char X[200]; return 3; }" | $* -S -x c -m32 -O0 -fstack-protector -mstack-protector-guard-reg=fs -mstack-protector-guard-symbol=__stack_chk_guard - -o - 2> /dev/null | grep -q "%fs" diff --git a/scripts/gcc-x86_64-has-stack-protector.sh b/scripts/gcc-x86_64-has-stack-protector.sh index 75e4e22b986a..f680bb01aeeb 100755 --- a/scripts/gcc-x86_64-has-stack-protector.sh +++ b/scripts/gcc-x86_64-has-stack-protector.sh @@ -1,4 +1,4 @@ #!/bin/sh # SPDX-License-Identifier: GPL-2.0 -echo "int foo(void) { char X[200]; return 3; }" | $* -S -x c -c -m64 -O0 -mcmodel=kernel -fno-PIE -fstack-protector - -o - 2> /dev/null | grep -q "%gs" +echo "int foo(void) { char X[200]; return 3; }" | $* -S -x c -m64 -O0 -mcmodel=kernel -fno-PIE -fstack-protector - -o - 2> /dev/null | grep -q "%gs" --- base-commit: 1722389b0d863056d78287a120a1d6cadb8d4f7b change-id: 20240726-fix-x86-stack-protector-tests-b542b1b9416b Best regards, -- Nathan Chancellor <nathan(a)kernel.org>

1 year, 4 months

3
7
0 0

[PATCH AUTOSEL 4.19 1/4] PCI: Add ACS quirk for Broadcom BCM5760X NIC

by Sasha Levin

From: Ajit Khaparde <ajit.khaparde(a)broadcom.com> [ Upstream commit 524e057b2d66b61f9b63b6db30467ab7b0bb4796 ] The Broadcom BCM5760X NIC may be a multi-function device. While it does not advertise an ACS capability, peer-to-peer transactions are not possible between the individual functions. So it is ok to treat them as fully isolated. Add an ACS quirk for this device so the functions can be in independent IOMMU groups and attached individually to userspace applications using VFIO. [kwilczynski: commit log] Link: https://lore.kernel.org/linux-pci/20240510204228.73435-1-ajit.khaparde@broa… Signed-off-by: Ajit Khaparde <ajit.khaparde(a)broadcom.com> Signed-off-by: Krzysztof Wilczyński <kwilczynski(a)kernel.org> Signed-off-by: Bjorn Helgaas <bhelgaas(a)google.com> Reviewed-by: Andy Gospodarek <gospo(a)broadcom.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/pci/quirks.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index bb51820890965..a3a4c4724b6c9 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -4822,6 +4822,10 @@ static const struct pci_dev_acs_enabled { { PCI_VENDOR_ID_BROADCOM, 0x1750, pci_quirk_mf_endpoint_acs }, { PCI_VENDOR_ID_BROADCOM, 0x1751, pci_quirk_mf_endpoint_acs }, { PCI_VENDOR_ID_BROADCOM, 0x1752, pci_quirk_mf_endpoint_acs }, + { PCI_VENDOR_ID_BROADCOM, 0x1760, pci_quirk_mf_endpoint_acs }, + { PCI_VENDOR_ID_BROADCOM, 0x1761, pci_quirk_mf_endpoint_acs }, + { PCI_VENDOR_ID_BROADCOM, 0x1762, pci_quirk_mf_endpoint_acs }, + { PCI_VENDOR_ID_BROADCOM, 0x1763, pci_quirk_mf_endpoint_acs }, { PCI_VENDOR_ID_BROADCOM, 0xD714, pci_quirk_brcm_acs }, { 0 } }; -- 2.43.0

1 year, 4 months

1
3
0 0

[PATCH AUTOSEL 5.4 1/7] PCI: Add ACS quirk for Broadcom BCM5760X NIC

by Sasha Levin

From: Ajit Khaparde <ajit.khaparde(a)broadcom.com> [ Upstream commit 524e057b2d66b61f9b63b6db30467ab7b0bb4796 ] The Broadcom BCM5760X NIC may be a multi-function device. While it does not advertise an ACS capability, peer-to-peer transactions are not possible between the individual functions. So it is ok to treat them as fully isolated. Add an ACS quirk for this device so the functions can be in independent IOMMU groups and attached individually to userspace applications using VFIO. [kwilczynski: commit log] Link: https://lore.kernel.org/linux-pci/20240510204228.73435-1-ajit.khaparde@broa… Signed-off-by: Ajit Khaparde <ajit.khaparde(a)broadcom.com> Signed-off-by: Krzysztof Wilczyński <kwilczynski(a)kernel.org> Signed-off-by: Bjorn Helgaas <bhelgaas(a)google.com> Reviewed-by: Andy Gospodarek <gospo(a)broadcom.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/pci/quirks.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 3bc7058404156..aef73bc36ee98 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -4986,6 +4986,10 @@ static const struct pci_dev_acs_enabled { { PCI_VENDOR_ID_BROADCOM, 0x1750, pci_quirk_mf_endpoint_acs }, { PCI_VENDOR_ID_BROADCOM, 0x1751, pci_quirk_mf_endpoint_acs }, { PCI_VENDOR_ID_BROADCOM, 0x1752, pci_quirk_mf_endpoint_acs }, + { PCI_VENDOR_ID_BROADCOM, 0x1760, pci_quirk_mf_endpoint_acs }, + { PCI_VENDOR_ID_BROADCOM, 0x1761, pci_quirk_mf_endpoint_acs }, + { PCI_VENDOR_ID_BROADCOM, 0x1762, pci_quirk_mf_endpoint_acs }, + { PCI_VENDOR_ID_BROADCOM, 0x1763, pci_quirk_mf_endpoint_acs }, { PCI_VENDOR_ID_BROADCOM, 0xD714, pci_quirk_brcm_acs }, /* Amazon Annapurna Labs */ { PCI_VENDOR_ID_AMAZON_ANNAPURNA_LABS, 0x0031, pci_quirk_al_acs }, -- 2.43.0

1 year, 4 months

1
6
0 0

[PATCH AUTOSEL 6.1 01/15] PCI: Add ACS quirk for Broadcom BCM5760X NIC

by Sasha Levin

From: Ajit Khaparde <ajit.khaparde(a)broadcom.com> [ Upstream commit 524e057b2d66b61f9b63b6db30467ab7b0bb4796 ] The Broadcom BCM5760X NIC may be a multi-function device. While it does not advertise an ACS capability, peer-to-peer transactions are not possible between the individual functions. So it is ok to treat them as fully isolated. Add an ACS quirk for this device so the functions can be in independent IOMMU groups and attached individually to userspace applications using VFIO. [kwilczynski: commit log] Link: https://lore.kernel.org/linux-pci/20240510204228.73435-1-ajit.khaparde@broa… Signed-off-by: Ajit Khaparde <ajit.khaparde(a)broadcom.com> Signed-off-by: Krzysztof Wilczyński <kwilczynski(a)kernel.org> Signed-off-by: Bjorn Helgaas <bhelgaas(a)google.com> Reviewed-by: Andy Gospodarek <gospo(a)broadcom.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/pci/quirks.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 56dce858a6934..e02a1e513f989 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -4997,6 +4997,10 @@ static const struct pci_dev_acs_enabled { { PCI_VENDOR_ID_BROADCOM, 0x1750, pci_quirk_mf_endpoint_acs }, { PCI_VENDOR_ID_BROADCOM, 0x1751, pci_quirk_mf_endpoint_acs }, { PCI_VENDOR_ID_BROADCOM, 0x1752, pci_quirk_mf_endpoint_acs }, + { PCI_VENDOR_ID_BROADCOM, 0x1760, pci_quirk_mf_endpoint_acs }, + { PCI_VENDOR_ID_BROADCOM, 0x1761, pci_quirk_mf_endpoint_acs }, + { PCI_VENDOR_ID_BROADCOM, 0x1762, pci_quirk_mf_endpoint_acs }, + { PCI_VENDOR_ID_BROADCOM, 0x1763, pci_quirk_mf_endpoint_acs }, { PCI_VENDOR_ID_BROADCOM, 0xD714, pci_quirk_brcm_acs }, /* Amazon Annapurna Labs */ { PCI_VENDOR_ID_AMAZON_ANNAPURNA_LABS, 0x0031, pci_quirk_al_acs }, -- 2.43.0

1 year, 4 months

1
14
0 0

[PATCH AUTOSEL 6.6 01/17] PCI: Add ACS quirk for Broadcom BCM5760X NIC

by Sasha Levin

From: Ajit Khaparde <ajit.khaparde(a)broadcom.com> [ Upstream commit 524e057b2d66b61f9b63b6db30467ab7b0bb4796 ] The Broadcom BCM5760X NIC may be a multi-function device. While it does not advertise an ACS capability, peer-to-peer transactions are not possible between the individual functions. So it is ok to treat them as fully isolated. Add an ACS quirk for this device so the functions can be in independent IOMMU groups and attached individually to userspace applications using VFIO. [kwilczynski: commit log] Link: https://lore.kernel.org/linux-pci/20240510204228.73435-1-ajit.khaparde@broa… Signed-off-by: Ajit Khaparde <ajit.khaparde(a)broadcom.com> Signed-off-by: Krzysztof Wilczyński <kwilczynski(a)kernel.org> Signed-off-by: Bjorn Helgaas <bhelgaas(a)google.com> Reviewed-by: Andy Gospodarek <gospo(a)broadcom.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/pci/quirks.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index ec4277d7835b2..1bf1a83dabb93 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -5092,6 +5092,10 @@ static const struct pci_dev_acs_enabled { { PCI_VENDOR_ID_BROADCOM, 0x1750, pci_quirk_mf_endpoint_acs }, { PCI_VENDOR_ID_BROADCOM, 0x1751, pci_quirk_mf_endpoint_acs }, { PCI_VENDOR_ID_BROADCOM, 0x1752, pci_quirk_mf_endpoint_acs }, + { PCI_VENDOR_ID_BROADCOM, 0x1760, pci_quirk_mf_endpoint_acs }, + { PCI_VENDOR_ID_BROADCOM, 0x1761, pci_quirk_mf_endpoint_acs }, + { PCI_VENDOR_ID_BROADCOM, 0x1762, pci_quirk_mf_endpoint_acs }, + { PCI_VENDOR_ID_BROADCOM, 0x1763, pci_quirk_mf_endpoint_acs }, { PCI_VENDOR_ID_BROADCOM, 0xD714, pci_quirk_brcm_acs }, /* Amazon Annapurna Labs */ { PCI_VENDOR_ID_AMAZON_ANNAPURNA_LABS, 0x0031, pci_quirk_al_acs }, -- 2.43.0

1 year, 4 months

1
16
0 0

[PATCH AUTOSEL 6.10 01/23] PCI: Add ACS quirk for Broadcom BCM5760X NIC

by Sasha Levin

From: Ajit Khaparde <ajit.khaparde(a)broadcom.com> [ Upstream commit 524e057b2d66b61f9b63b6db30467ab7b0bb4796 ] The Broadcom BCM5760X NIC may be a multi-function device. While it does not advertise an ACS capability, peer-to-peer transactions are not possible between the individual functions. So it is ok to treat them as fully isolated. Add an ACS quirk for this device so the functions can be in independent IOMMU groups and attached individually to userspace applications using VFIO. [kwilczynski: commit log] Link: https://lore.kernel.org/linux-pci/20240510204228.73435-1-ajit.khaparde@broa… Signed-off-by: Ajit Khaparde <ajit.khaparde(a)broadcom.com> Signed-off-by: Krzysztof Wilczyński <kwilczynski(a)kernel.org> Signed-off-by: Bjorn Helgaas <bhelgaas(a)google.com> Reviewed-by: Andy Gospodarek <gospo(a)broadcom.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/pci/quirks.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 568410e64ce64..a2ce4e08edf5a 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -5099,6 +5099,10 @@ static const struct pci_dev_acs_enabled { { PCI_VENDOR_ID_BROADCOM, 0x1750, pci_quirk_mf_endpoint_acs }, { PCI_VENDOR_ID_BROADCOM, 0x1751, pci_quirk_mf_endpoint_acs }, { PCI_VENDOR_ID_BROADCOM, 0x1752, pci_quirk_mf_endpoint_acs }, + { PCI_VENDOR_ID_BROADCOM, 0x1760, pci_quirk_mf_endpoint_acs }, + { PCI_VENDOR_ID_BROADCOM, 0x1761, pci_quirk_mf_endpoint_acs }, + { PCI_VENDOR_ID_BROADCOM, 0x1762, pci_quirk_mf_endpoint_acs }, + { PCI_VENDOR_ID_BROADCOM, 0x1763, pci_quirk_mf_endpoint_acs }, { PCI_VENDOR_ID_BROADCOM, 0xD714, pci_quirk_brcm_acs }, /* Amazon Annapurna Labs */ { PCI_VENDOR_ID_AMAZON_ANNAPURNA_LABS, 0x0031, pci_quirk_al_acs }, -- 2.43.0

1 year, 4 months

1
22
0 0

[PATCH AUTOSEL 4.19 1/5] media: uvcvideo: Ignore empty TS packets

by Sasha Levin

From: Ricardo Ribalda <ribalda(a)chromium.org> [ Upstream commit 5cd7c25f6f0576073b3d03bc4cfb1e8ca63a1195 ] Some SunplusIT cameras took a borderline interpretation of the UVC 1.5 standard, and fill the PTS and SCR fields with invalid data if the package does not contain data. "STC must be captured when the first video data of a video frame is put on the USB bus." Some SunplusIT devices send, e.g., buffer: 0xa7755c00 len 000012 header:0x8c stc 00000000 sof 0000 pts 00000000 buffer: 0xa7755c00 len 000012 header:0x8c stc 00000000 sof 0000 pts 00000000 buffer: 0xa7755c00 len 000668 header:0x8c stc 73779dba sof 070c pts 7376d37a While the UVC specification meant that the first two packets shouldn't have had the SCR bit set in the header. This borderline/buggy interpretation has been implemented in a variety of devices, from directly SunplusIT and from other OEMs that rebrand SunplusIT products. So quirking based on VID:PID will be problematic. All the affected modules have the following extension unit: VideoControl Interface Descriptor: guidExtensionCode {82066163-7050-ab49-b8cc-b3855e8d221d} But the vendor plans to use that GUID in the future and fix the bug, this means that we should use heuristic to figure out the broken packets. This patch takes care of this. lsusb of one of the affected cameras: Bus 001 Device 003: ID 1bcf:2a01 Sunplus Innovation Technology Inc. Device Descriptor: bLength 18 bDescriptorType 1 bcdUSB 2.01 bDeviceClass 239 Miscellaneous Device bDeviceSubClass 2 ? bDeviceProtocol 1 Interface Association bMaxPacketSize0 64 idVendor 0x1bcf Sunplus Innovation Technology Inc. idProduct 0x2a01 bcdDevice 0.02 iManufacturer 1 SunplusIT Inc iProduct 2 HanChen Wise Camera iSerial 3 01.00.00 bNumConfigurations 1 Tested-by: HungNien Chen <hn.chen(a)sunplusit.com> Reviewed-by: Sergey Senozhatsky <senozhatsky(a)chromium.org> Reviewed-by: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com> Signed-off-by: Ricardo Ribalda <ribalda(a)chromium.org> Reviewed-by: Tomasz Figa <tfiga(a)chromium.org> Link: https://lore.kernel.org/r/20240323-resend-hwtimestamp-v10-2-b08e590d97c7@ch… Signed-off-by: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/media/usb/uvc/uvc_video.c | 31 ++++++++++++++++++++++++++++++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c index c57bc62251bb8..e2c1b98fb4a25 100644 --- a/drivers/media/usb/uvc/uvc_video.c +++ b/drivers/media/usb/uvc/uvc_video.c @@ -473,6 +473,7 @@ uvc_video_clock_decode(struct uvc_streaming *stream, struct uvc_buffer *buf, ktime_t time; u16 host_sof; u16 dev_sof; + u32 dev_stc; switch (data[1] & (UVC_STREAM_PTS | UVC_STREAM_SCR)) { case UVC_STREAM_PTS | UVC_STREAM_SCR: @@ -517,6 +518,34 @@ uvc_video_clock_decode(struct uvc_streaming *stream, struct uvc_buffer *buf, if (dev_sof == stream->clock.last_sof) return; + dev_stc = get_unaligned_le32(&data[header_size - 6]); + + /* + * STC (Source Time Clock) is the clock used by the camera. The UVC 1.5 + * standard states that it "must be captured when the first video data + * of a video frame is put on the USB bus". This is generally understood + * as requiring devices to clear the payload header's SCR bit before + * the first packet containing video data. + * + * Most vendors follow that interpretation, but some (namely SunplusIT + * on some devices) always set the `UVC_STREAM_SCR` bit, fill the SCR + * field with 0's,and expect that the driver only processes the SCR if + * there is data in the packet. + * + * Ignore all the hardware timestamp information if we haven't received + * any data for this frame yet, the packet contains no data, and both + * STC and SOF are zero. This heuristics should be safe on compliant + * devices. This should be safe with compliant devices, as in the very + * unlikely case where a UVC 1.1 device would send timing information + * only before the first packet containing data, and both STC and SOF + * happen to be zero for a particular frame, we would only miss one + * clock sample from many and the clock recovery algorithm wouldn't + * suffer from this condition. + */ + if (buf && buf->bytesused == 0 && len == header_size && + dev_stc == 0 && dev_sof == 0) + return; + stream->clock.last_sof = dev_sof; host_sof = usb_get_current_frame_number(stream->dev->udev); @@ -554,7 +583,7 @@ uvc_video_clock_decode(struct uvc_streaming *stream, struct uvc_buffer *buf, spin_lock_irqsave(&stream->clock.lock, flags); sample = &stream->clock.samples[stream->clock.head]; - sample->dev_stc = get_unaligned_le32(&data[header_size - 6]); + sample->dev_stc = dev_stc; sample->dev_sof = dev_sof; sample->host_sof = host_sof; sample->host_time = time; -- 2.43.0

1 year, 4 months

1
4
0 0

[PATCH AUTOSEL 5.4 1/6] drm/amdgpu: Fix the null pointer dereference to ras_manager

by Sasha Levin

From: Ma Jun <Jun.Ma2(a)amd.com> [ Upstream commit 4c11d30c95576937c6c35e6f29884761f2dddb43 ] Check ras_manager before using it Signed-off-by: Ma Jun <Jun.Ma2(a)amd.com> Reviewed-by: Lijo Lazar <lijo.lazar(a)amd.com> Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c index b6fc191c353a7..96aad6cc83b1e 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c @@ -1053,12 +1053,15 @@ static void amdgpu_ras_interrupt_process_handler(struct work_struct *work) int amdgpu_ras_interrupt_dispatch(struct amdgpu_device *adev, struct ras_dispatch_if *info) { - struct ras_manager *obj = amdgpu_ras_find_obj(adev, &info->head); - struct ras_ih_data *data = &obj->ih_data; + struct ras_manager *obj; + struct ras_ih_data *data; + obj = amdgpu_ras_find_obj(adev, &info->head); if (!obj) return -EINVAL; + data = &obj->ih_data; + if (data->inuse == 0) return 0; -- 2.43.0

1 year, 4 months

1
5
0 0

[PATCH AUTOSEL 5.10 1/7] drm/amdgpu: Fix the null pointer dereference to ras_manager

by Sasha Levin

From: Ma Jun <Jun.Ma2(a)amd.com> [ Upstream commit 4c11d30c95576937c6c35e6f29884761f2dddb43 ] Check ras_manager before using it Signed-off-by: Ma Jun <Jun.Ma2(a)amd.com> Reviewed-by: Lijo Lazar <lijo.lazar(a)amd.com> Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c index e971d2b9e3c00..56f10679a26d1 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c @@ -1351,12 +1351,15 @@ static void amdgpu_ras_interrupt_process_handler(struct work_struct *work) int amdgpu_ras_interrupt_dispatch(struct amdgpu_device *adev, struct ras_dispatch_if *info) { - struct ras_manager *obj = amdgpu_ras_find_obj(adev, &info->head); - struct ras_ih_data *data = &obj->ih_data; + struct ras_manager *obj; + struct ras_ih_data *data; + obj = amdgpu_ras_find_obj(adev, &info->head); if (!obj) return -EINVAL; + data = &obj->ih_data; + if (data->inuse == 0) return 0; -- 2.43.0

1 year, 4 months

1
6
0 0

[PATCH AUTOSEL 5.15 01/10] drm/amdgpu/pm: Fix the null pointer dereference for smu7

by Sasha Levin

From: Ma Jun <Jun.Ma2(a)amd.com> [ Upstream commit c02c1960c93eede587576625a1221205a68a904f ] optimize the code to avoid pass a null pointer (hwmgr->backend) to function smu7_update_edc_leakage_table. Signed-off-by: Ma Jun <Jun.Ma2(a)amd.com> Reviewed-by: Yang Wang <kevinyang.wang(a)amd.com> Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- .../drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c | 50 +++++++++---------- 1 file changed, 24 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c index 9bfc465d08fb0..2451cec031dda 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c @@ -2907,6 +2907,7 @@ static int smu7_update_edc_leakage_table(struct pp_hwmgr *hwmgr) static int smu7_hwmgr_backend_init(struct pp_hwmgr *hwmgr) { + struct amdgpu_device *adev = hwmgr->adev; struct smu7_hwmgr *data; int result = 0; @@ -2943,40 +2944,37 @@ static int smu7_hwmgr_backend_init(struct pp_hwmgr *hwmgr) /* Initalize Dynamic State Adjustment Rule Settings */ result = phm_initializa_dynamic_state_adjustment_rule_settings(hwmgr); - if (0 == result) { - struct amdgpu_device *adev = hwmgr->adev; + if (result) + goto fail; - data->is_tlu_enabled = false; + data->is_tlu_enabled = false; - hwmgr->platform_descriptor.hardwareActivityPerformanceLevels = + hwmgr->platform_descriptor.hardwareActivityPerformanceLevels = SMU7_MAX_HARDWARE_POWERLEVELS; - hwmgr->platform_descriptor.hardwarePerformanceLevels = 2; - hwmgr->platform_descriptor.minimumClocksReductionPercentage = 50; + hwmgr->platform_descriptor.hardwarePerformanceLevels = 2; + hwmgr->platform_descriptor.minimumClocksReductionPercentage = 50; - data->pcie_gen_cap = adev->pm.pcie_gen_mask; - if (data->pcie_gen_cap & CAIL_PCIE_LINK_SPEED_SUPPORT_GEN3) - data->pcie_spc_cap = 20; - else - data->pcie_spc_cap = 16; - data->pcie_lane_cap = adev->pm.pcie_mlw_mask; - - hwmgr->platform_descriptor.vbiosInterruptId = 0x20000400; /* IRQ_SOURCE1_SW_INT */ -/* The true clock step depends on the frequency, typically 4.5 or 9 MHz. Here we use 5. */ - hwmgr->platform_descriptor.clockStep.engineClock = 500; - hwmgr->platform_descriptor.clockStep.memoryClock = 500; - smu7_thermal_parameter_init(hwmgr); - } else { - /* Ignore return value in here, we are cleaning up a mess. */ - smu7_hwmgr_backend_fini(hwmgr); - } + data->pcie_gen_cap = adev->pm.pcie_gen_mask; + if (data->pcie_gen_cap & CAIL_PCIE_LINK_SPEED_SUPPORT_GEN3) + data->pcie_spc_cap = 20; + else + data->pcie_spc_cap = 16; + data->pcie_lane_cap = adev->pm.pcie_mlw_mask; + + hwmgr->platform_descriptor.vbiosInterruptId = 0x20000400; /* IRQ_SOURCE1_SW_INT */ + /* The true clock step depends on the frequency, typically 4.5 or 9 MHz. Here we use 5. */ + hwmgr->platform_descriptor.clockStep.engineClock = 500; + hwmgr->platform_descriptor.clockStep.memoryClock = 500; + smu7_thermal_parameter_init(hwmgr); result = smu7_update_edc_leakage_table(hwmgr); - if (result) { - smu7_hwmgr_backend_fini(hwmgr); - return result; - } + if (result) + goto fail; return 0; +fail: + smu7_hwmgr_backend_fini(hwmgr); + return result; } static int smu7_force_dpm_highest(struct pp_hwmgr *hwmgr) -- 2.43.0

1 year, 4 months

1
9
0 0

[PATCH AUTOSEL 6.1 01/17] drm/amdgpu/pm: Fix the param type of set_power_profile_mode

by Sasha Levin

From: Ma Jun <Jun.Ma2(a)amd.com> [ Upstream commit f683f24093dd94a831085fe0ea8e9dc4c6c1a2d1 ] Function .set_power_profile_mode need an array as input parameter. So define variable workload as an array to fix the below coverity warning. "Passing &workload to function hwmgr->hwmgr_func->set_power_profile_mode which uses it as an array. This might corrupt or misinterpret adjacent memory locations" Signed-off-by: Ma Jun <Jun.Ma2(a)amd.com> Acked-by: Alex Deucher <alexander.deucher(a)amd.com> Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 8 ++++---- drivers/gpu/drm/amd/pm/powerplay/hwmgr/pp_psm.c | 8 ++++---- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 16 ++++++++-------- 3 files changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c index 179e1c593a53f..f3668911a88fd 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c +++ b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c @@ -928,7 +928,7 @@ static int pp_dpm_switch_power_profile(void *handle, enum PP_SMC_POWER_PROFILE type, bool en) { struct pp_hwmgr *hwmgr = handle; - long workload; + long workload[1]; uint32_t index; if (!hwmgr || !hwmgr->pm_en) @@ -946,12 +946,12 @@ static int pp_dpm_switch_power_profile(void *handle, hwmgr->workload_mask &= ~(1 << hwmgr->workload_prority[type]); index = fls(hwmgr->workload_mask); index = index > 0 && index <= Workload_Policy_Max ? index - 1 : 0; - workload = hwmgr->workload_setting[index]; + workload[0] = hwmgr->workload_setting[index]; } else { hwmgr->workload_mask |= (1 << hwmgr->workload_prority[type]); index = fls(hwmgr->workload_mask); index = index <= Workload_Policy_Max ? index - 1 : 0; - workload = hwmgr->workload_setting[index]; + workload[0] = hwmgr->workload_setting[index]; } if (type == PP_SMC_POWER_PROFILE_COMPUTE && @@ -961,7 +961,7 @@ static int pp_dpm_switch_power_profile(void *handle, } if (hwmgr->dpm_level != AMD_DPM_FORCED_LEVEL_MANUAL) - hwmgr->hwmgr_func->set_power_profile_mode(hwmgr, &workload, 0); + hwmgr->hwmgr_func->set_power_profile_mode(hwmgr, workload, 0); return 0; } diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/pp_psm.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/pp_psm.c index 1d829402cd2e2..f4bd8e9357e22 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/pp_psm.c +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/pp_psm.c @@ -269,7 +269,7 @@ int psm_adjust_power_state_dynamic(struct pp_hwmgr *hwmgr, bool skip_display_set struct pp_power_state *new_ps) { uint32_t index; - long workload; + long workload[1]; if (hwmgr->not_vf) { if (!skip_display_settings) @@ -294,10 +294,10 @@ int psm_adjust_power_state_dynamic(struct pp_hwmgr *hwmgr, bool skip_display_set if (hwmgr->dpm_level != AMD_DPM_FORCED_LEVEL_MANUAL) { index = fls(hwmgr->workload_mask); index = index > 0 && index <= Workload_Policy_Max ? index - 1 : 0; - workload = hwmgr->workload_setting[index]; + workload[0] = hwmgr->workload_setting[index]; - if (hwmgr->power_profile_mode != workload && hwmgr->hwmgr_func->set_power_profile_mode) - hwmgr->hwmgr_func->set_power_profile_mode(hwmgr, &workload, 0); + if (hwmgr->power_profile_mode != workload[0] && hwmgr->hwmgr_func->set_power_profile_mode) + hwmgr->hwmgr_func->set_power_profile_mode(hwmgr, workload, 0); } return 0; diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c index 1d0693dad8185..91f0646eb3ee0 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c +++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c @@ -1834,7 +1834,7 @@ static int smu_adjust_power_state_dynamic(struct smu_context *smu, { int ret = 0; int index = 0; - long workload; + long workload[1]; struct smu_dpm_context *smu_dpm_ctx = &(smu->smu_dpm); if (!skip_display_settings) { @@ -1874,10 +1874,10 @@ static int smu_adjust_power_state_dynamic(struct smu_context *smu, smu_dpm_ctx->dpm_level != AMD_DPM_FORCED_LEVEL_PERF_DETERMINISM) { index = fls(smu->workload_mask); index = index > 0 && index <= WORKLOAD_POLICY_MAX ? index - 1 : 0; - workload = smu->workload_setting[index]; + workload[0] = smu->workload_setting[index]; - if (smu->power_profile_mode != workload) - smu_bump_power_profile_mode(smu, &workload, 0); + if (smu->power_profile_mode != workload[0]) + smu_bump_power_profile_mode(smu, workload, 0); } return ret; @@ -1927,7 +1927,7 @@ static int smu_switch_power_profile(void *handle, { struct smu_context *smu = handle; struct smu_dpm_context *smu_dpm_ctx = &(smu->smu_dpm); - long workload; + long workload[1]; uint32_t index; if (!smu->pm_enabled || !smu->adev->pm.dpm_enabled) @@ -1940,17 +1940,17 @@ static int smu_switch_power_profile(void *handle, smu->workload_mask &= ~(1 << smu->workload_prority[type]); index = fls(smu->workload_mask); index = index > 0 && index <= WORKLOAD_POLICY_MAX ? index - 1 : 0; - workload = smu->workload_setting[index]; + workload[0] = smu->workload_setting[index]; } else { smu->workload_mask |= (1 << smu->workload_prority[type]); index = fls(smu->workload_mask); index = index <= WORKLOAD_POLICY_MAX ? index - 1 : 0; - workload = smu->workload_setting[index]; + workload[0] = smu->workload_setting[index]; } if (smu_dpm_ctx->dpm_level != AMD_DPM_FORCED_LEVEL_MANUAL && smu_dpm_ctx->dpm_level != AMD_DPM_FORCED_LEVEL_PERF_DETERMINISM) - smu_bump_power_profile_mode(smu, &workload, 0); + smu_bump_power_profile_mode(smu, workload, 0); return 0; } -- 2.43.0

1 year, 4 months

1
16
0 0

[PATCH AUTOSEL 6.6 01/20] drm/amd/display: Add delay to improve LTTPR UHBR interop

by Sasha Levin

From: Michael Strauss <michael.strauss(a)amd.com> [ Upstream commit 10839ee6a977ed1f7d0f4deb29f2d7e5d1f2a9dd ] [WHY] Avoid race condition which puts LTTPR into bad state during UHBR LT. [HOW] Delay 30ms between starting UHBR TPS1 PHY output and sending TPS1 via DPCD. Reviewed-by: Wenjing Liu <wenjing.liu(a)amd.com> Acked-by: Aurabindo Pillai <aurabindo.pillai(a)amd.com> Signed-off-by: Michael Strauss <michael.strauss(a)amd.com> Tested-by: Daniel Wheeler <daniel.wheeler(a)amd.com> Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- .../dc/link/hwss/link_hwss_hpo_fixed_vs_pe_retimer_dp.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/link/hwss/link_hwss_hpo_fixed_vs_pe_retimer_dp.c b/drivers/gpu/drm/amd/display/dc/link/hwss/link_hwss_hpo_fixed_vs_pe_retimer_dp.c index b621b97711b61..a7f5b0f6272ce 100644 --- a/drivers/gpu/drm/amd/display/dc/link/hwss/link_hwss_hpo_fixed_vs_pe_retimer_dp.c +++ b/drivers/gpu/drm/amd/display/dc/link/hwss/link_hwss_hpo_fixed_vs_pe_retimer_dp.c @@ -162,7 +162,12 @@ static void set_hpo_fixed_vs_pe_retimer_dp_link_test_pattern(struct dc_link *lin link_res->hpo_dp_link_enc->funcs->set_link_test_pattern( link_res->hpo_dp_link_enc, tp_params); } + link->dc->link_srv->dp_trace_source_sequence(link, DPCD_SOURCE_SEQ_AFTER_SET_SOURCE_PATTERN); + + // Give retimer extra time to lock before updating DP_TRAINING_PATTERN_SET to TPS1 + if (tp_params->dp_phy_pattern == DP_TEST_PATTERN_128b_132b_TPS1_TRAINING_MODE) + msleep(30); } static void set_hpo_fixed_vs_pe_retimer_dp_lane_settings(struct dc_link *link, -- 2.43.0

1 year, 4 months

1
19
0 0

[PATCH AUTOSEL 6.10 01/34] drm/xe/preempt_fence: enlarge the fence critical section

by Sasha Levin

From: Matthew Auld <matthew.auld(a)intel.com> [ Upstream commit 3cd1585e57908b6efcd967465ef7685f40b2a294 ] It is really easy to introduce subtle deadlocks in preempt_fence_work_func() since we operate on single global ordered-wq for signalling our preempt fences behind the scenes, so even though we signal a particular fence, everything in the callback should be in the fence critical section, since blocking in the callback will prevent other published fences from signalling. If we enlarge the fence critical section to cover the entire callback, then lockdep should be able to understand this better, and complain if we grab a sensitive lock like vm->lock, which is also held when waiting on preempt fences. Signed-off-by: Matthew Auld <matthew.auld(a)intel.com> Cc: Matthew Brost <matthew.brost(a)intel.com> Reviewed-by: Matthew Brost <matthew.brost(a)intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240418144630.299531-2-matth… Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/gpu/drm/xe/xe_preempt_fence.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_preempt_fence.c b/drivers/gpu/drm/xe/xe_preempt_fence.c index 7d50c6e89d8e7..5b243b7feb59d 100644 --- a/drivers/gpu/drm/xe/xe_preempt_fence.c +++ b/drivers/gpu/drm/xe/xe_preempt_fence.c @@ -23,11 +23,19 @@ static void preempt_fence_work_func(struct work_struct *w) q->ops->suspend_wait(q); dma_fence_signal(&pfence->base); - dma_fence_end_signalling(cookie); - + /* + * Opt for keep everything in the fence critical section. This looks really strange since we + * have just signalled the fence, however the preempt fences are all signalled via single + * global ordered-wq, therefore anything that happens in this callback can easily block + * progress on the entire wq, which itself may prevent other published preempt fences from + * ever signalling. Therefore try to keep everything here in the callback in the fence + * critical section. For example if something below grabs a scary lock like vm->lock, + * lockdep should complain since we also hold that lock whilst waiting on preempt fences to + * complete. + */ xe_vm_queue_rebind_worker(q->vm); - xe_exec_queue_put(q); + dma_fence_end_signalling(cookie); } static const char * -- 2.43.0

1 year, 4 months

1
33
0 0

c1839501fe3e tested

by Edmund Raile

c1839501fe3e ("ALSA: firewire-lib: fix wrong value as length of header for CIP_NO_HEADER case") indeed fixes the issue. Thank you very much! I just hope non-CIP_NO_HEADER cases work, but then again, looking at the original struct ``` struct { struct fw_iso_packet params; __be32 header[CIP_HEADER_QUADLETS]; } template = { {0}, {0} }; ``` the fw_iso_packet wasn't at the end of the array, thus ``` struct fw_iso_packet { u16 payload_length; /* Length of indirect payload */ u32 interrupt:1; /* Generate interrupt on this packet */ u32 skip:1; /* tx: Set to not send packet at all */ /* rx: Sync bit, wait for matching sy */ u32 tag:2; /* tx: Tag in packet header */ u32 sy:4; /* tx: Sy in packet header */ u32 header_length:8; /* Size of immediate header */ u32 header[]; /* tx: Top of 1394 isoch. data_block */ }; ``` its header array wouldn't ever end up being initialized here with > 0 elements. Maybe that wasn't ever required. Tested-by: Edmund Raile <edmund.raile(a)protonmail.com> Link: https://lore.kernel.org/r/20240725155640.128442-1-o-takashi@sakamocchi.jp

1 year, 4 months

1
0
0 0

[PATCH v2 0/2] ALSA: firewire-lib: restore process context workqueue to prevent deadlock

by Edmund Raile

This patchset serves to prevent a deadlock between process context and softIRQ context: A. In the process context * (lock A) Acquiring spin_lock by snd_pcm_stream_lock_irq() in snd_pcm_status64() * (lock B) Then attempt to enter tasklet B. In the softIRQ context * (lock B) Enter tasklet * (lock A) Attempt to acquire spin_lock by snd_pcm_stream_lock_irqsave() in snd_pcm_period_elapsed() ? tasklet_unlock_spin_wait </NMI> <TASK> ohci_flush_iso_completions firewire_ohci amdtp_domain_stream_pcm_pointer snd_firewire_lib snd_pcm_update_hw_ptr0 snd_pcm snd_pcm_status64 snd_pcm ? native_queued_spin_lock_slowpath </NMI> <IRQ> _raw_spin_lock_irqsave snd_pcm_period_elapsed snd_pcm process_rx_packets snd_firewire_lib irq_target_callback snd_firewire_lib handle_it_packet firewire_ohci context_tasklet firewire_ohci The issue has been reported as a regression of kernel 5.14: Link: https://lore.kernel.org/regressions/kwryofzdmjvzkuw6j3clftsxmoolynljztxqwg7… ("[REGRESSION] ALSA: firewire-lib: snd_pcm_period_elapsed deadlock with Fireface 800") Commit 7ba5ca32fe6e ("ALSA: firewire-lib: operate for period elapse event in process context") removed the process context workqueue from amdtp_domain_stream_pcm_pointer() and update_pcm_pointers() to remove its overhead. Commit b5b519965c4c ("ALSA: firewire-lib: obsolete workqueue for period update") belongs to the same patch series and removed the now-unused workqueue entirely. Though being observed on RME Fireface 800, this issue would affect all Firewire audio interfaces using ohci amdtp + pcm streaming. ALSA streaming, especially under intensive CPU load will reveal this issue the soonest due to issuing more hardIRQs, with time to occurrence ranging from 2 secons to 30 minutes after starting playback. to reproduce the issue: direct ALSA playback to the device: mpv --audio-device=alsa/sysdefault:CARD=Fireface800 Spor-Ignition.flac Time to occurrence: 2s to 30m Likelihood increased by: - high CPU load stress --cpu $(nproc) - switching between applications via workspaces tested with i915 in Xfce PulsaAudio / PipeWire conceal the issue as they run PCM substream without period wakeup mode, issuing less hardIRQs. Backport note: Also applies to and fixes on (tested): 6.10.2, 6.9.12, 6.6.43, 6.1.102, 5.15.164 Edmund Raile (2): ALSA: firewire-lib: restore workqueue for process context ALSA: firewire-lib: prevent deadlock between process and softIRQ context sound/firewire/amdtp-stream.c | 36 ++++++++++++++++++++++------------- sound/firewire/amdtp-stream.h | 1 + 2 files changed, 24 insertions(+), 13 deletions(-) -- 2.45.2

1 year, 4 months

1
2
0 0

[PATCH v2 2/2] ALSA: firewire-lib: prevent deadlock between process and softIRQ context

by Edmund Raile

Commit 7ba5ca32fe6e ("ALSA: firewire-lib: operate for period elapse event in process context") removed the process context workqueue from amdtp_domain_stream_pcm_pointer() and update_pcm_pointers() to remove its overhead. With RME Fireface 800, this lead to a regression since Kernels 5.14.0, causing a deadlock with eventual system freeze under ALSA operation: A. In the process context * (lock A) Acquiring spin_lock by snd_pcm_stream_lock_irq() in snd_pcm_status64() * (lock B) Then attempt to enter tasklet B. In the softIRQ context * (lock B) Enter tasklet * (lock A) Attempt to acquire spin_lock by snd_pcm_stream_lock_irqsave() in snd_pcm_period_elapsed() ? tasklet_unlock_spin_wait </NMI> <TASK> ohci_flush_iso_completions firewire_ohci amdtp_domain_stream_pcm_pointer snd_firewire_lib snd_pcm_update_hw_ptr0 snd_pcm snd_pcm_status64 snd_pcm ? native_queued_spin_lock_slowpath </NMI> <IRQ> _raw_spin_lock_irqsave snd_pcm_period_elapsed snd_pcm process_rx_packets snd_firewire_lib irq_target_callback snd_firewire_lib handle_it_packet firewire_ohci context_tasklet firewire_ohci Restore the process context work queue to prevent deadlock between ALSA substream process context spin_lock of snd_pcm_stream_lock_irq() in snd_pcm_status64() and OHCI 1394 IT softIRQ context spin_lock of snd_pcm_stream_lock_irqsave() in snd_pcm_period_elapsed(). Cc: stable(a)vger.kernel.org Fixes: 7ba5ca32fe6e ("ALSA: firewire-lib: operate for period elapse event in process context") Link: https://lore.kernel.org/r/kwryofzdmjvzkuw6j3clftsxmoolynljztxqwg76hzeo4simn… Reported-by: edmund.raile <edmund.raile(a)proton.me> Signed-off-by: Edmund Raile <edmund.raile(a)protonmail.com> --- sound/firewire/amdtp-stream.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/sound/firewire/amdtp-stream.c b/sound/firewire/amdtp-stream.c index 31201d506a21..c037d7de1fdc 100644 --- a/sound/firewire/amdtp-stream.c +++ b/sound/firewire/amdtp-stream.c @@ -615,16 +615,9 @@ static void update_pcm_pointers(struct amdtp_stream *s, // The program in user process should periodically check the status of intermediate // buffer associated to PCM substream to process PCM frames in the buffer, instead // of receiving notification of period elapsed by poll wait. - if (!pcm->runtime->no_period_wakeup) { - if (in_softirq()) { - // In software IRQ context for 1394 OHCI. - snd_pcm_period_elapsed(pcm); - } else { - // In process context of ALSA PCM application under acquired lock of - // PCM substream. - snd_pcm_period_elapsed_under_stream_lock(pcm); - } - } + if (!pcm->runtime->no_period_wakeup) + // wq used with amdtp_domain_stream_pcm_pointer() to prevent deadlock + queue_work(system_highpri_wq, &s->period_work); } } @@ -1866,9 +1859,11 @@ unsigned long amdtp_domain_stream_pcm_pointer(struct amdtp_domain *d, // Process isochronous packets queued till recent isochronous cycle to handle PCM frames. if (irq_target && amdtp_stream_running(irq_target)) { - // In software IRQ context, the call causes dead-lock to disable the tasklet - // synchronously. - if (!in_softirq()) + // use wq to prevent deadlock between process context spin_lock + // of snd_pcm_stream_lock_irq() in snd_pcm_status64() and + // softIRQ context spin_lock of snd_pcm_stream_lock_irqsave() + // in snd_pcm_period_elapsed() + if ((!in_softirq()) && (current_work() != &s->period_work)) fw_iso_context_flush_completions(irq_target->context); } -- 2.45.2

1 year, 4 months

1
0
0 0

[PATCH v2 1/2] ALSA: firewire-lib: restore workqueue for process context

by Edmund Raile

prepare resolution of deadlock between process context and softIRQ context: restore workqueue previously used for process context: revert commit b5b519965c4c ("ALSA: firewire-lib: obsolete workqueue for period update") Cc: stable(a)vger.kernel.org Link: https://lore.kernel.org/r/kwryofzdmjvzkuw6j3clftsxmoolynljztxqwg76hzeo4simn… Reported-by: edmund.raile <edmund.raile(a)proton.me> Signed-off-by: Edmund Raile <edmund.raile(a)protonmail.com> --- sound/firewire/amdtp-stream.c | 15 +++++++++++++++ sound/firewire/amdtp-stream.h | 1 + 2 files changed, 16 insertions(+) diff --git a/sound/firewire/amdtp-stream.c b/sound/firewire/amdtp-stream.c index d35d0a420ee0..31201d506a21 100644 --- a/sound/firewire/amdtp-stream.c +++ b/sound/firewire/amdtp-stream.c @@ -77,6 +77,8 @@ // overrun. Actual device can skip more, then this module stops the packet streaming. #define IR_JUMBO_PAYLOAD_MAX_SKIP_CYCLES 5 +static void pcm_period_work(struct work_struct *work); + /** * amdtp_stream_init - initialize an AMDTP stream structure * @s: the AMDTP stream to initialize @@ -105,6 +107,7 @@ int amdtp_stream_init(struct amdtp_stream *s, struct fw_unit *unit, s->flags = flags; s->context = ERR_PTR(-1); mutex_init(&s->mutex); + INIT_WORK(&s->period_work, pcm_period_work); s->packet_index = 0; init_waitqueue_head(&s->ready_wait); @@ -347,6 +350,7 @@ EXPORT_SYMBOL(amdtp_stream_get_max_payload); */ void amdtp_stream_pcm_prepare(struct amdtp_stream *s) { + cancel_work_sync(&s->period_work); s->pcm_buffer_pointer = 0; s->pcm_period_pointer = 0; } @@ -624,6 +628,16 @@ static void update_pcm_pointers(struct amdtp_stream *s, } } +static void pcm_period_work(struct work_struct *work) +{ + struct amdtp_stream *s = container_of(work, struct amdtp_stream, + period_work); + struct snd_pcm_substream *pcm = READ_ONCE(s->pcm); + + if (pcm) + snd_pcm_period_elapsed(pcm); +} + static int queue_packet(struct amdtp_stream *s, struct fw_iso_packet *params, bool sched_irq) { @@ -1910,6 +1924,7 @@ static void amdtp_stream_stop(struct amdtp_stream *s) return; } + cancel_work_sync(&s->period_work); fw_iso_context_stop(s->context); fw_iso_context_destroy(s->context); s->context = ERR_PTR(-1); diff --git a/sound/firewire/amdtp-stream.h b/sound/firewire/amdtp-stream.h index a1ed2e80f91a..775db3fc4959 100644 --- a/sound/firewire/amdtp-stream.h +++ b/sound/firewire/amdtp-stream.h @@ -191,5 +191,6 @@ struct amdtp_stream { /* For a PCM substream processing. */ struct snd_pcm_substream *pcm; + struct work_struct period_work; snd_pcm_uframes_t pcm_buffer_pointer; unsigned int pcm_period_pointer; -- 2.45.2

1 year, 4 months

1
0
0 0

[PATCH v2 2/2] ALSA: firewire-lib: prevent deadlock between process and softIRQ context

by Edmund Raile

Commit 7ba5ca32fe6e ("ALSA: firewire-lib: operate for period elapse event in process context") removed the process context workqueue from amdtp_domain_stream_pcm_pointer() and update_pcm_pointers() to remove its overhead. With RME Fireface 800, this lead to a regression since Kernels 5.14.0, causing a deadlock with eventual system freeze under ALSA operation: A. In the process context * (lock A) Acquiring spin_lock by snd_pcm_stream_lock_irq() in snd_pcm_status64() * (lock B) Then attempt to enter tasklet B. In the softIRQ context * (lock B) Enter tasklet * (lock A) Attempt to acquire spin_lock by snd_pcm_stream_lock_irqsave() in snd_pcm_period_elapsed() ? tasklet_unlock_spin_wait </NMI> <TASK> ohci_flush_iso_completions firewire_ohci amdtp_domain_stream_pcm_pointer snd_firewire_lib snd_pcm_update_hw_ptr0 snd_pcm snd_pcm_status64 snd_pcm ? native_queued_spin_lock_slowpath </NMI> <IRQ> _raw_spin_lock_irqsave snd_pcm_period_elapsed snd_pcm process_rx_packets snd_firewire_lib irq_target_callback snd_firewire_lib handle_it_packet firewire_ohci context_tasklet firewire_ohci Restore the process context work queue to prevent deadlock between ALSA substream process context spin_lock of snd_pcm_stream_lock_irq() in snd_pcm_status64() and OHCI 1394 IT softIRQ context spin_lock of snd_pcm_stream_lock_irqsave() in snd_pcm_period_elapsed(). Cc: stable(a)vger.kernel.org Fixes: 7ba5ca32fe6e ("ALSA: firewire-lib: operate for period elapse event in process context") Link: https://lore.kernel.org/r/kwryofzdmjvzkuw6j3clftsxmoolynljztxqwg76hzeo4simn… Reported-by: edmund.raile <edmund.raile(a)proton.me> Signed-off-by: Edmund Raile <edmund.raile(a)protonmail.com> --- sound/firewire/amdtp-stream.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/sound/firewire/amdtp-stream.c b/sound/firewire/amdtp-stream.c index 31201d506a21..c037d7de1fdc 100644 --- a/sound/firewire/amdtp-stream.c +++ b/sound/firewire/amdtp-stream.c @@ -615,16 +615,9 @@ static void update_pcm_pointers(struct amdtp_stream *s, // The program in user process should periodically check the status of intermediate // buffer associated to PCM substream to process PCM frames in the buffer, instead // of receiving notification of period elapsed by poll wait. - if (!pcm->runtime->no_period_wakeup) { - if (in_softirq()) { - // In software IRQ context for 1394 OHCI. - snd_pcm_period_elapsed(pcm); - } else { - // In process context of ALSA PCM application under acquired lock of - // PCM substream. - snd_pcm_period_elapsed_under_stream_lock(pcm); - } - } + if (!pcm->runtime->no_period_wakeup) + // wq used with amdtp_domain_stream_pcm_pointer() to prevent deadlock + queue_work(system_highpri_wq, &s->period_work); } } @@ -1866,9 +1859,11 @@ unsigned long amdtp_domain_stream_pcm_pointer(struct amdtp_domain *d, // Process isochronous packets queued till recent isochronous cycle to handle PCM frames. if (irq_target && amdtp_stream_running(irq_target)) { - // In software IRQ context, the call causes dead-lock to disable the tasklet - // synchronously. - if (!in_softirq()) + // use wq to prevent deadlock between process context spin_lock + // of snd_pcm_stream_lock_irq() in snd_pcm_status64() and + // softIRQ context spin_lock of snd_pcm_stream_lock_irqsave() + // in snd_pcm_period_elapsed() + if ((!in_softirq()) && (current_work() != &s->period_work)) fw_iso_context_flush_completions(irq_target->context); } -- 2.45.2

1 year, 4 months

1
0
0 0

[PATCH v2 1/2] ALSA: firewire-lib: restore workqueue for process context

by Edmund Raile

prepare resolution of deadlock between process context and softIRQ context: restore workqueue previously used for process context: revert commit b5b519965c4c ("ALSA: firewire-lib: obsolete workqueue for period update") Cc: stable(a)vger.kernel.org Link: https://lore.kernel.org/r/kwryofzdmjvzkuw6j3clftsxmoolynljztxqwg76hzeo4simn… Reported-by: edmund.raile <edmund.raile(a)proton.me> Signed-off-by: Edmund Raile <edmund.raile(a)protonmail.com> --- sound/firewire/amdtp-stream.c | 15 +++++++++++++++ sound/firewire/amdtp-stream.h | 1 + 2 files changed, 16 insertions(+) diff --git a/sound/firewire/amdtp-stream.c b/sound/firewire/amdtp-stream.c index d35d0a420ee0..31201d506a21 100644 --- a/sound/firewire/amdtp-stream.c +++ b/sound/firewire/amdtp-stream.c @@ -77,6 +77,8 @@ // overrun. Actual device can skip more, then this module stops the packet streaming. #define IR_JUMBO_PAYLOAD_MAX_SKIP_CYCLES 5 +static void pcm_period_work(struct work_struct *work); + /** * amdtp_stream_init - initialize an AMDTP stream structure * @s: the AMDTP stream to initialize @@ -105,6 +107,7 @@ int amdtp_stream_init(struct amdtp_stream *s, struct fw_unit *unit, s->flags = flags; s->context = ERR_PTR(-1); mutex_init(&s->mutex); + INIT_WORK(&s->period_work, pcm_period_work); s->packet_index = 0; init_waitqueue_head(&s->ready_wait); @@ -347,6 +350,7 @@ EXPORT_SYMBOL(amdtp_stream_get_max_payload); */ void amdtp_stream_pcm_prepare(struct amdtp_stream *s) { + cancel_work_sync(&s->period_work); s->pcm_buffer_pointer = 0; s->pcm_period_pointer = 0; } @@ -624,6 +628,16 @@ static void update_pcm_pointers(struct amdtp_stream *s, } } +static void pcm_period_work(struct work_struct *work) +{ + struct amdtp_stream *s = container_of(work, struct amdtp_stream, + period_work); + struct snd_pcm_substream *pcm = READ_ONCE(s->pcm); + + if (pcm) + snd_pcm_period_elapsed(pcm); +} + static int queue_packet(struct amdtp_stream *s, struct fw_iso_packet *params, bool sched_irq) { @@ -1910,6 +1924,7 @@ static void amdtp_stream_stop(struct amdtp_stream *s) return; } + cancel_work_sync(&s->period_work); fw_iso_context_stop(s->context); fw_iso_context_destroy(s->context); s->context = ERR_PTR(-1); diff --git a/sound/firewire/amdtp-stream.h b/sound/firewire/amdtp-stream.h index a1ed2e80f91a..775db3fc4959 100644 --- a/sound/firewire/amdtp-stream.h +++ b/sound/firewire/amdtp-stream.h @@ -191,5 +191,6 @@ struct amdtp_stream { /* For a PCM substream processing. */ struct snd_pcm_substream *pcm; + struct work_struct period_work; snd_pcm_uframes_t pcm_buffer_pointer; unsigned int pcm_period_pointer; -- 2.45.2

1 year, 4 months

1
0
0 0

[PATCH AUTOSEL 4.19 1/4] PCI: Add Edimax Vendor ID to pci_ids.h

by Sasha Levin

From: FUJITA Tomonori <fujita.tomonori(a)gmail.com> [ Upstream commit eee5528890d54b22b46f833002355a5ee94c3bb4 ] Add the Edimax Vendor ID (0x1432) for an ethernet driver for Tehuti Networks TN40xx chips. This ID can be used for Realtek 8180 and Ralink rt28xx wireless drivers. Signed-off-by: FUJITA Tomonori <fujita.tomonori(a)gmail.com> Acked-by: Bjorn Helgaas <bhelgaas(a)google.com> Link: https://patch.msgid.link/20240623235507.108147-2-fujita.tomonori@gmail.com Signed-off-by: Jakub Kicinski <kuba(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- include/linux/pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index 3ac7b92b35b9d..91193284710f1 100644 --- a/include/linux/pci_ids.h +++ b/include/linux/pci_ids.h @@ -2136,6 +2136,8 @@ #define PCI_VENDOR_ID_CHELSIO 0x1425 +#define PCI_VENDOR_ID_EDIMAX 0x1432 + #define PCI_VENDOR_ID_ADLINK 0x144a #define PCI_VENDOR_ID_SAMSUNG 0x144d -- 2.43.0

1 year, 4 months

1
3
0 0

[PATCH AUTOSEL 5.4 1/6] r8169: remove detection of chip version 11 (early RTL8168b)

by Sasha Levin

From: Heiner Kallweit <hkallweit1(a)gmail.com> [ Upstream commit 982300c115d229565d7af8e8b38aa1ee7bb1f5bd ] This early RTL8168b version was the first PCIe chip version, and it's quite quirky. Last sign of life is from more than 15 yrs ago. Let's remove detection of this chip version, we'll see whether anybody complains. If not, support for this chip version can be removed a few kernel versions later. Signed-off-by: Heiner Kallweit <hkallweit1(a)gmail.com> Link: https://lore.kernel.org/r/875cdcf4-843c-420a-ad5d-417447b68572@gmail.com Signed-off-by: Jakub Kicinski <kuba(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/net/ethernet/realtek/r8169_main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index 319f8d7a502da..32ea1d902a173 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -2185,7 +2185,9 @@ static void rtl8169_get_mac_version(struct rtl8169_private *tp) /* 8168B family. */ { 0x7cf, 0x380, RTL_GIGA_MAC_VER_12 }, { 0x7c8, 0x380, RTL_GIGA_MAC_VER_17 }, - { 0x7c8, 0x300, RTL_GIGA_MAC_VER_11 }, + /* This one is very old and rare, let's see if anybody complains. + * { 0x7c8, 0x300, RTL_GIGA_MAC_VER_11 }, + */ /* 8101 family. */ { 0x7c8, 0x448, RTL_GIGA_MAC_VER_39 }, -- 2.43.0

1 year, 4 months

1
5
0 0

[PATCH AUTOSEL 5.10 1/6] r8169: remove detection of chip version 11 (early RTL8168b)

by Sasha Levin

From: Heiner Kallweit <hkallweit1(a)gmail.com> [ Upstream commit 982300c115d229565d7af8e8b38aa1ee7bb1f5bd ] This early RTL8168b version was the first PCIe chip version, and it's quite quirky. Last sign of life is from more than 15 yrs ago. Let's remove detection of this chip version, we'll see whether anybody complains. If not, support for this chip version can be removed a few kernel versions later. Signed-off-by: Heiner Kallweit <hkallweit1(a)gmail.com> Link: https://lore.kernel.org/r/875cdcf4-843c-420a-ad5d-417447b68572@gmail.com Signed-off-by: Jakub Kicinski <kuba(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/net/ethernet/realtek/r8169_main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index d24eb5ee152a5..7d3443ad8e797 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -2018,7 +2018,9 @@ static enum mac_version rtl8169_get_mac_version(u16 xid, bool gmii) /* 8168B family. */ { 0x7cf, 0x380, RTL_GIGA_MAC_VER_12 }, { 0x7c8, 0x380, RTL_GIGA_MAC_VER_17 }, - { 0x7c8, 0x300, RTL_GIGA_MAC_VER_11 }, + /* This one is very old and rare, let's see if anybody complains. + * { 0x7c8, 0x300, RTL_GIGA_MAC_VER_11 }, + */ /* 8101 family. */ { 0x7c8, 0x448, RTL_GIGA_MAC_VER_39 }, -- 2.43.0

1 year, 4 months

1
5
0 0

[PATCH AUTOSEL 5.15 1/6] r8169: remove detection of chip version 11 (early RTL8168b)

by Sasha Levin

From: Heiner Kallweit <hkallweit1(a)gmail.com> [ Upstream commit 982300c115d229565d7af8e8b38aa1ee7bb1f5bd ] This early RTL8168b version was the first PCIe chip version, and it's quite quirky. Last sign of life is from more than 15 yrs ago. Let's remove detection of this chip version, we'll see whether anybody complains. If not, support for this chip version can be removed a few kernel versions later. Signed-off-by: Heiner Kallweit <hkallweit1(a)gmail.com> Link: https://lore.kernel.org/r/875cdcf4-843c-420a-ad5d-417447b68572@gmail.com Signed-off-by: Jakub Kicinski <kuba(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/net/ethernet/realtek/r8169_main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index 76d820c4e6eef..c0ad5cd963d08 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -2063,7 +2063,9 @@ static enum mac_version rtl8169_get_mac_version(u16 xid, bool gmii) /* 8168B family. */ { 0x7cf, 0x380, RTL_GIGA_MAC_VER_12 }, { 0x7c8, 0x380, RTL_GIGA_MAC_VER_17 }, - { 0x7c8, 0x300, RTL_GIGA_MAC_VER_11 }, + /* This one is very old and rare, let's see if anybody complains. + * { 0x7c8, 0x300, RTL_GIGA_MAC_VER_11 }, + */ /* 8101 family. */ { 0x7c8, 0x448, RTL_GIGA_MAC_VER_39 }, -- 2.43.0

1 year, 4 months

1
5
0 0

[PATCH AUTOSEL 6.1 01/11] wifi: nl80211: disallow setting special AP channel widths

by Sasha Levin

From: Johannes Berg <johannes.berg(a)intel.com> [ Upstream commit 23daf1b4c91db9b26f8425cc7039cf96d22ccbfe ] Setting the AP channel width is meant for use with the normal 20/40/... MHz channel width progression, and switching around in S1G or narrow channels isn't supported. Disallow that. Reported-by: syzbot+bc0f5b92cc7091f45fb6(a)syzkaller.appspotmail.com Link: https://msgid.link/20240515141600.d4a9590bfe32.I19a32d60097e81b527eafe6b092… Signed-off-by: Johannes Berg <johannes.berg(a)intel.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- net/wireless/nl80211.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index a00df7b89ca86..603fcd921bd22 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -3346,6 +3346,33 @@ static int __nl80211_set_channel(struct cfg80211_registered_device *rdev, if (chandef.chan != cur_chan) return -EBUSY; + /* only allow this for regular channel widths */ + switch (wdev->links[link_id].ap.chandef.width) { + case NL80211_CHAN_WIDTH_20_NOHT: + case NL80211_CHAN_WIDTH_20: + case NL80211_CHAN_WIDTH_40: + case NL80211_CHAN_WIDTH_80: + case NL80211_CHAN_WIDTH_80P80: + case NL80211_CHAN_WIDTH_160: + case NL80211_CHAN_WIDTH_320: + break; + default: + return -EINVAL; + } + + switch (chandef.width) { + case NL80211_CHAN_WIDTH_20_NOHT: + case NL80211_CHAN_WIDTH_20: + case NL80211_CHAN_WIDTH_40: + case NL80211_CHAN_WIDTH_80: + case NL80211_CHAN_WIDTH_80P80: + case NL80211_CHAN_WIDTH_160: + case NL80211_CHAN_WIDTH_320: + break; + default: + return -EINVAL; + } + result = rdev_set_ap_chanwidth(rdev, dev, link_id, &chandef); if (result) -- 2.43.0

1 year, 4 months

1
10
0 0

[PATCH AUTOSEL 6.6 01/15] wifi: nl80211: disallow setting special AP channel widths

by Sasha Levin

From: Johannes Berg <johannes.berg(a)intel.com> [ Upstream commit 23daf1b4c91db9b26f8425cc7039cf96d22ccbfe ] Setting the AP channel width is meant for use with the normal 20/40/... MHz channel width progression, and switching around in S1G or narrow channels isn't supported. Disallow that. Reported-by: syzbot+bc0f5b92cc7091f45fb6(a)syzkaller.appspotmail.com Link: https://msgid.link/20240515141600.d4a9590bfe32.I19a32d60097e81b527eafe6b092… Signed-off-by: Johannes Berg <johannes.berg(a)intel.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- net/wireless/nl80211.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 8f8f077e6cd40..053258b4e28d2 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -3398,6 +3398,33 @@ static int __nl80211_set_channel(struct cfg80211_registered_device *rdev, if (chandef.chan != cur_chan) return -EBUSY; + /* only allow this for regular channel widths */ + switch (wdev->links[link_id].ap.chandef.width) { + case NL80211_CHAN_WIDTH_20_NOHT: + case NL80211_CHAN_WIDTH_20: + case NL80211_CHAN_WIDTH_40: + case NL80211_CHAN_WIDTH_80: + case NL80211_CHAN_WIDTH_80P80: + case NL80211_CHAN_WIDTH_160: + case NL80211_CHAN_WIDTH_320: + break; + default: + return -EINVAL; + } + + switch (chandef.width) { + case NL80211_CHAN_WIDTH_20_NOHT: + case NL80211_CHAN_WIDTH_20: + case NL80211_CHAN_WIDTH_40: + case NL80211_CHAN_WIDTH_80: + case NL80211_CHAN_WIDTH_80P80: + case NL80211_CHAN_WIDTH_160: + case NL80211_CHAN_WIDTH_320: + break; + default: + return -EINVAL; + } + result = rdev_set_ap_chanwidth(rdev, dev, link_id, &chandef); if (result) -- 2.43.0

1 year, 4 months

1
14
0 0

[PATCH AUTOSEL 5.4 1/2] ACPI: battery: create alarm sysfs attribute atomically

by Sasha Levin

From: Thomas Weißschuh <linux(a)weissschuh.net> [ Upstream commit a231eed10ed5a290129fda36ad7bcc263c53ff7d ] Let the power supply core register the attribute. This ensures that the attribute is created before the device is announced to userspace, avoid a race condition. Signed-off-by: Thomas Weißschuh <linux(a)weissschuh.net> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki(a)intel.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/acpi/battery.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c index a49a09e3de1b3..af78f76a28729 100644 --- a/drivers/acpi/battery.c +++ b/drivers/acpi/battery.c @@ -681,12 +681,18 @@ static ssize_t acpi_battery_alarm_store(struct device *dev, return count; } -static const struct device_attribute alarm_attr = { +static struct device_attribute alarm_attr = { .attr = {.name = "alarm", .mode = 0644}, .show = acpi_battery_alarm_show, .store = acpi_battery_alarm_store, }; +static struct attribute *acpi_battery_attrs[] = { + &alarm_attr.attr, + NULL +}; +ATTRIBUTE_GROUPS(acpi_battery); + /* * The Battery Hooking API * @@ -823,7 +829,10 @@ static void __exit battery_hook_exit(void) static int sysfs_add_battery(struct acpi_battery *battery) { - struct power_supply_config psy_cfg = { .drv_data = battery, }; + struct power_supply_config psy_cfg = { + .drv_data = battery, + .attr_grp = acpi_battery_groups, + }; bool full_cap_broken = false; if (!ACPI_BATTERY_CAPACITY_VALID(battery->full_charge_capacity) && @@ -868,7 +877,7 @@ static int sysfs_add_battery(struct acpi_battery *battery) return result; } battery_hook_add_battery(battery); - return device_create_file(&battery->bat->dev, &alarm_attr); + return 0; } static void sysfs_remove_battery(struct acpi_battery *battery) @@ -879,7 +888,6 @@ static void sysfs_remove_battery(struct acpi_battery *battery) return; } battery_hook_remove_battery(battery); - device_remove_file(&battery->bat->dev, &alarm_attr); power_supply_unregister(battery->bat); battery->bat = NULL; mutex_unlock(&battery->sysfs_lock); -- 2.43.0

1 year, 4 months

1
1
0 0

[PATCH AUTOSEL 5.10 1/2] ACPI: battery: create alarm sysfs attribute atomically

by Sasha Levin

From: Thomas Weißschuh <linux(a)weissschuh.net> [ Upstream commit a231eed10ed5a290129fda36ad7bcc263c53ff7d ] Let the power supply core register the attribute. This ensures that the attribute is created before the device is announced to userspace, avoid a race condition. Signed-off-by: Thomas Weißschuh <linux(a)weissschuh.net> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki(a)intel.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/acpi/battery.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c index 8b43efe97da5d..2e1462b8929c0 100644 --- a/drivers/acpi/battery.c +++ b/drivers/acpi/battery.c @@ -670,12 +670,18 @@ static ssize_t acpi_battery_alarm_store(struct device *dev, return count; } -static const struct device_attribute alarm_attr = { +static struct device_attribute alarm_attr = { .attr = {.name = "alarm", .mode = 0644}, .show = acpi_battery_alarm_show, .store = acpi_battery_alarm_store, }; +static struct attribute *acpi_battery_attrs[] = { + &alarm_attr.attr, + NULL +}; +ATTRIBUTE_GROUPS(acpi_battery); + /* * The Battery Hooking API * @@ -812,7 +818,10 @@ static void __exit battery_hook_exit(void) static int sysfs_add_battery(struct acpi_battery *battery) { - struct power_supply_config psy_cfg = { .drv_data = battery, }; + struct power_supply_config psy_cfg = { + .drv_data = battery, + .attr_grp = acpi_battery_groups, + }; bool full_cap_broken = false; if (!ACPI_BATTERY_CAPACITY_VALID(battery->full_charge_capacity) && @@ -857,7 +866,7 @@ static int sysfs_add_battery(struct acpi_battery *battery) return result; } battery_hook_add_battery(battery); - return device_create_file(&battery->bat->dev, &alarm_attr); + return 0; } static void sysfs_remove_battery(struct acpi_battery *battery) @@ -868,7 +877,6 @@ static void sysfs_remove_battery(struct acpi_battery *battery) return; } battery_hook_remove_battery(battery); - device_remove_file(&battery->bat->dev, &alarm_attr); power_supply_unregister(battery->bat); battery->bat = NULL; mutex_unlock(&battery->sysfs_lock); -- 2.43.0

1 year, 4 months

1
1
0 0

[PATCH AUTOSEL 5.15 1/2] ACPI: battery: create alarm sysfs attribute atomically

by Sasha Levin

From: Thomas Weißschuh <linux(a)weissschuh.net> [ Upstream commit a231eed10ed5a290129fda36ad7bcc263c53ff7d ] Let the power supply core register the attribute. This ensures that the attribute is created before the device is announced to userspace, avoid a race condition. Signed-off-by: Thomas Weißschuh <linux(a)weissschuh.net> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki(a)intel.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/acpi/battery.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c index c7569151fd02a..aed4132985a96 100644 --- a/drivers/acpi/battery.c +++ b/drivers/acpi/battery.c @@ -676,12 +676,18 @@ static ssize_t acpi_battery_alarm_store(struct device *dev, return count; } -static const struct device_attribute alarm_attr = { +static struct device_attribute alarm_attr = { .attr = {.name = "alarm", .mode = 0644}, .show = acpi_battery_alarm_show, .store = acpi_battery_alarm_store, }; +static struct attribute *acpi_battery_attrs[] = { + &alarm_attr.attr, + NULL +}; +ATTRIBUTE_GROUPS(acpi_battery); + /* * The Battery Hooking API * @@ -818,7 +824,10 @@ static void __exit battery_hook_exit(void) static int sysfs_add_battery(struct acpi_battery *battery) { - struct power_supply_config psy_cfg = { .drv_data = battery, }; + struct power_supply_config psy_cfg = { + .drv_data = battery, + .attr_grp = acpi_battery_groups, + }; bool full_cap_broken = false; if (!ACPI_BATTERY_CAPACITY_VALID(battery->full_charge_capacity) && @@ -863,7 +872,7 @@ static int sysfs_add_battery(struct acpi_battery *battery) return result; } battery_hook_add_battery(battery); - return device_create_file(&battery->bat->dev, &alarm_attr); + return 0; } static void sysfs_remove_battery(struct acpi_battery *battery) @@ -874,7 +883,6 @@ static void sysfs_remove_battery(struct acpi_battery *battery) return; } battery_hook_remove_battery(battery); - device_remove_file(&battery->bat->dev, &alarm_attr); power_supply_unregister(battery->bat); battery->bat = NULL; mutex_unlock(&battery->sysfs_lock); -- 2.43.0

1 year, 4 months

1
1
0 0

[PATCH AUTOSEL 6.1 1/2] ACPI: battery: create alarm sysfs attribute atomically

by Sasha Levin

From: Thomas Weißschuh <linux(a)weissschuh.net> [ Upstream commit a231eed10ed5a290129fda36ad7bcc263c53ff7d ] Let the power supply core register the attribute. This ensures that the attribute is created before the device is announced to userspace, avoid a race condition. Signed-off-by: Thomas Weißschuh <linux(a)weissschuh.net> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki(a)intel.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/acpi/battery.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c index 084f156bdfbc4..088740fdea355 100644 --- a/drivers/acpi/battery.c +++ b/drivers/acpi/battery.c @@ -667,12 +667,18 @@ static ssize_t acpi_battery_alarm_store(struct device *dev, return count; } -static const struct device_attribute alarm_attr = { +static struct device_attribute alarm_attr = { .attr = {.name = "alarm", .mode = 0644}, .show = acpi_battery_alarm_show, .store = acpi_battery_alarm_store, }; +static struct attribute *acpi_battery_attrs[] = { + &alarm_attr.attr, + NULL +}; +ATTRIBUTE_GROUPS(acpi_battery); + /* * The Battery Hooking API * @@ -809,7 +815,10 @@ static void __exit battery_hook_exit(void) static int sysfs_add_battery(struct acpi_battery *battery) { - struct power_supply_config psy_cfg = { .drv_data = battery, }; + struct power_supply_config psy_cfg = { + .drv_data = battery, + .attr_grp = acpi_battery_groups, + }; bool full_cap_broken = false; if (!ACPI_BATTERY_CAPACITY_VALID(battery->full_charge_capacity) && @@ -854,7 +863,7 @@ static int sysfs_add_battery(struct acpi_battery *battery) return result; } battery_hook_add_battery(battery); - return device_create_file(&battery->bat->dev, &alarm_attr); + return 0; } static void sysfs_remove_battery(struct acpi_battery *battery) @@ -865,7 +874,6 @@ static void sysfs_remove_battery(struct acpi_battery *battery) return; } battery_hook_remove_battery(battery); - device_remove_file(&battery->bat->dev, &alarm_attr); power_supply_unregister(battery->bat); battery->bat = NULL; mutex_unlock(&battery->sysfs_lock); -- 2.43.0

1 year, 4 months

1
1
0 0

[PATCH AUTOSEL 6.6 1/3] ACPI: battery: create alarm sysfs attribute atomically

by Sasha Levin

From: Thomas Weißschuh <linux(a)weissschuh.net> [ Upstream commit a231eed10ed5a290129fda36ad7bcc263c53ff7d ] Let the power supply core register the attribute. This ensures that the attribute is created before the device is announced to userspace, avoid a race condition. Signed-off-by: Thomas Weißschuh <linux(a)weissschuh.net> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki(a)intel.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/acpi/battery.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c index 969bf81e8d546..7f7ad94f22b91 100644 --- a/drivers/acpi/battery.c +++ b/drivers/acpi/battery.c @@ -678,12 +678,18 @@ static ssize_t acpi_battery_alarm_store(struct device *dev, return count; } -static const struct device_attribute alarm_attr = { +static struct device_attribute alarm_attr = { .attr = {.name = "alarm", .mode = 0644}, .show = acpi_battery_alarm_show, .store = acpi_battery_alarm_store, }; +static struct attribute *acpi_battery_attrs[] = { + &alarm_attr.attr, + NULL +}; +ATTRIBUTE_GROUPS(acpi_battery); + /* * The Battery Hooking API * @@ -823,7 +829,10 @@ static void __exit battery_hook_exit(void) static int sysfs_add_battery(struct acpi_battery *battery) { - struct power_supply_config psy_cfg = { .drv_data = battery, }; + struct power_supply_config psy_cfg = { + .drv_data = battery, + .attr_grp = acpi_battery_groups, + }; bool full_cap_broken = false; if (!ACPI_BATTERY_CAPACITY_VALID(battery->full_charge_capacity) && @@ -868,7 +877,7 @@ static int sysfs_add_battery(struct acpi_battery *battery) return result; } battery_hook_add_battery(battery); - return device_create_file(&battery->bat->dev, &alarm_attr); + return 0; } static void sysfs_remove_battery(struct acpi_battery *battery) @@ -879,7 +888,6 @@ static void sysfs_remove_battery(struct acpi_battery *battery) return; } battery_hook_remove_battery(battery); - device_remove_file(&battery->bat->dev, &alarm_attr); power_supply_unregister(battery->bat); battery->bat = NULL; mutex_unlock(&battery->sysfs_lock); -- 2.43.0

1 year, 4 months

1
2
0 0

[PATCH AUTOSEL 6.10 1/9] ACPI: battery: create alarm sysfs attribute atomically

by Sasha Levin

From: Thomas Weißschuh <linux(a)weissschuh.net> [ Upstream commit a231eed10ed5a290129fda36ad7bcc263c53ff7d ] Let the power supply core register the attribute. This ensures that the attribute is created before the device is announced to userspace, avoid a race condition. Signed-off-by: Thomas Weißschuh <linux(a)weissschuh.net> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki(a)intel.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/acpi/battery.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c index b379401ff1c20..44ca989f16466 100644 --- a/drivers/acpi/battery.c +++ b/drivers/acpi/battery.c @@ -678,12 +678,18 @@ static ssize_t acpi_battery_alarm_store(struct device *dev, return count; } -static const struct device_attribute alarm_attr = { +static struct device_attribute alarm_attr = { .attr = {.name = "alarm", .mode = 0644}, .show = acpi_battery_alarm_show, .store = acpi_battery_alarm_store, }; +static struct attribute *acpi_battery_attrs[] = { + &alarm_attr.attr, + NULL +}; +ATTRIBUTE_GROUPS(acpi_battery); + /* * The Battery Hooking API * @@ -823,7 +829,10 @@ static void __exit battery_hook_exit(void) static int sysfs_add_battery(struct acpi_battery *battery) { - struct power_supply_config psy_cfg = { .drv_data = battery, }; + struct power_supply_config psy_cfg = { + .drv_data = battery, + .attr_grp = acpi_battery_groups, + }; bool full_cap_broken = false; if (!ACPI_BATTERY_CAPACITY_VALID(battery->full_charge_capacity) && @@ -868,7 +877,7 @@ static int sysfs_add_battery(struct acpi_battery *battery) return result; } battery_hook_add_battery(battery); - return device_create_file(&battery->bat->dev, &alarm_attr); + return 0; } static void sysfs_remove_battery(struct acpi_battery *battery) @@ -879,7 +888,6 @@ static void sysfs_remove_battery(struct acpi_battery *battery) return; } battery_hook_remove_battery(battery); - device_remove_file(&battery->bat->dev, &alarm_attr); power_supply_unregister(battery->bat); battery->bat = NULL; mutex_unlock(&battery->sysfs_lock); -- 2.43.0

1 year, 4 months

1
8
0 0

[PATCH AUTOSEL 4.19 1/3] fs: remove accidental overflow during wraparound check

by Sasha Levin

From: Justin Stitt <justinstitt(a)google.com> [ Upstream commit 23cc6ef6fd453b13502caae23130844e7d6ed0fe ] Running syzkaller with the newly enabled signed integer overflow sanitizer produces this report: [ 195.401651] ------------[ cut here ]------------ [ 195.404808] UBSAN: signed-integer-overflow in ../fs/open.c:321:15 [ 195.408739] 9223372036854775807 + 562984447377399 cannot be represented in type 'loff_t' (aka 'long long') [ 195.414683] CPU: 1 PID: 703 Comm: syz-executor.0 Not tainted 6.8.0-rc2-00039-g14de58dbe653-dirty #11 [ 195.420138] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 [ 195.425804] Call Trace: [ 195.427360] <TASK> [ 195.428791] dump_stack_lvl+0x93/0xd0 [ 195.431150] handle_overflow+0x171/0x1b0 [ 195.433640] vfs_fallocate+0x459/0x4f0 ... [ 195.490053] ------------[ cut here ]------------ [ 195.493146] UBSAN: signed-integer-overflow in ../fs/open.c:321:61 [ 195.497030] 9223372036854775807 + 562984447377399 cannot be represented in type 'loff_t' (aka 'long long) [ 195.502940] CPU: 1 PID: 703 Comm: syz-executor.0 Not tainted 6.8.0-rc2-00039-g14de58dbe653-dirty #11 [ 195.508395] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 [ 195.514075] Call Trace: [ 195.515636] <TASK> [ 195.517000] dump_stack_lvl+0x93/0xd0 [ 195.519255] handle_overflow+0x171/0x1b0 [ 195.521677] vfs_fallocate+0x4cb/0x4f0 [ 195.524033] __x64_sys_fallocate+0xb2/0xf0 Historically, the signed integer overflow sanitizer did not work in the kernel due to its interaction with `-fwrapv` but this has since been changed [1] in the newest version of Clang. It was re-enabled in the kernel with Commit 557f8c582a9ba8ab ("ubsan: Reintroduce signed overflow sanitizer"). Let's use the check_add_overflow helper to first verify the addition stays within the bounds of its type (long long); then we can use that sum for the following check. Link: https://github.com/llvm/llvm-project/pull/82432 [1] Closes: https://github.com/KSPP/linux/issues/356 Cc: linux-hardening(a)vger.kernel.org Reviewed-by: Kees Cook <keescook(a)chromium.org> Signed-off-by: Justin Stitt <justinstitt(a)google.com> Link: https://lore.kernel.org/r/20240513-b4-sio-vfs_fallocate-v2-1-db415872fb16@g… Reviewed-by: Jan Kara <jack(a)suse.cz> Signed-off-by: Christian Brauner <brauner(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- fs/open.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/fs/open.c b/fs/open.c index 7763a1a10f592..2751cb70f2dc1 100644 --- a/fs/open.c +++ b/fs/open.c @@ -229,6 +229,7 @@ int vfs_fallocate(struct file *file, int mode, loff_t offset, loff_t len) { struct inode *inode = file_inode(file); long ret; + loff_t sum; if (offset < 0 || len <= 0) return -EINVAL; @@ -297,8 +298,11 @@ int vfs_fallocate(struct file *file, int mode, loff_t offset, loff_t len) if (!S_ISREG(inode->i_mode) && !S_ISBLK(inode->i_mode)) return -ENODEV; - /* Check for wrap through zero too */ - if (((offset + len) > inode->i_sb->s_maxbytes) || ((offset + len) < 0)) + /* Check for wraparound */ + if (check_add_overflow(offset, len, &sum)) + return -EFBIG; + + if (sum > inode->i_sb->s_maxbytes) return -EFBIG; if (!file->f_op->fallocate) -- 2.43.0

1 year, 4 months

1
2
0 0

[PATCH AUTOSEL 5.4 1/3] fs: remove accidental overflow during wraparound check

by Sasha Levin

From: Justin Stitt <justinstitt(a)google.com> [ Upstream commit 23cc6ef6fd453b13502caae23130844e7d6ed0fe ] Running syzkaller with the newly enabled signed integer overflow sanitizer produces this report: [ 195.401651] ------------[ cut here ]------------ [ 195.404808] UBSAN: signed-integer-overflow in ../fs/open.c:321:15 [ 195.408739] 9223372036854775807 + 562984447377399 cannot be represented in type 'loff_t' (aka 'long long') [ 195.414683] CPU: 1 PID: 703 Comm: syz-executor.0 Not tainted 6.8.0-rc2-00039-g14de58dbe653-dirty #11 [ 195.420138] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 [ 195.425804] Call Trace: [ 195.427360] <TASK> [ 195.428791] dump_stack_lvl+0x93/0xd0 [ 195.431150] handle_overflow+0x171/0x1b0 [ 195.433640] vfs_fallocate+0x459/0x4f0 ... [ 195.490053] ------------[ cut here ]------------ [ 195.493146] UBSAN: signed-integer-overflow in ../fs/open.c:321:61 [ 195.497030] 9223372036854775807 + 562984447377399 cannot be represented in type 'loff_t' (aka 'long long) [ 195.502940] CPU: 1 PID: 703 Comm: syz-executor.0 Not tainted 6.8.0-rc2-00039-g14de58dbe653-dirty #11 [ 195.508395] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 [ 195.514075] Call Trace: [ 195.515636] <TASK> [ 195.517000] dump_stack_lvl+0x93/0xd0 [ 195.519255] handle_overflow+0x171/0x1b0 [ 195.521677] vfs_fallocate+0x4cb/0x4f0 [ 195.524033] __x64_sys_fallocate+0xb2/0xf0 Historically, the signed integer overflow sanitizer did not work in the kernel due to its interaction with `-fwrapv` but this has since been changed [1] in the newest version of Clang. It was re-enabled in the kernel with Commit 557f8c582a9ba8ab ("ubsan: Reintroduce signed overflow sanitizer"). Let's use the check_add_overflow helper to first verify the addition stays within the bounds of its type (long long); then we can use that sum for the following check. Link: https://github.com/llvm/llvm-project/pull/82432 [1] Closes: https://github.com/KSPP/linux/issues/356 Cc: linux-hardening(a)vger.kernel.org Reviewed-by: Kees Cook <keescook(a)chromium.org> Signed-off-by: Justin Stitt <justinstitt(a)google.com> Link: https://lore.kernel.org/r/20240513-b4-sio-vfs_fallocate-v2-1-db415872fb16@g… Reviewed-by: Jan Kara <jack(a)suse.cz> Signed-off-by: Christian Brauner <brauner(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- fs/open.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/fs/open.c b/fs/open.c index f1c2ec6790bb3..d88b7f3b4d9f1 100644 --- a/fs/open.c +++ b/fs/open.c @@ -230,6 +230,7 @@ int vfs_fallocate(struct file *file, int mode, loff_t offset, loff_t len) { struct inode *inode = file_inode(file); long ret; + loff_t sum; if (offset < 0 || len <= 0) return -EINVAL; @@ -298,8 +299,11 @@ int vfs_fallocate(struct file *file, int mode, loff_t offset, loff_t len) if (!S_ISREG(inode->i_mode) && !S_ISBLK(inode->i_mode)) return -ENODEV; - /* Check for wrap through zero too */ - if (((offset + len) > inode->i_sb->s_maxbytes) || ((offset + len) < 0)) + /* Check for wraparound */ + if (check_add_overflow(offset, len, &sum)) + return -EFBIG; + + if (sum > inode->i_sb->s_maxbytes) return -EFBIG; if (!file->f_op->fallocate) -- 2.43.0

1 year, 4 months

1
2
0 0

[PATCH AUTOSEL 5.10 1/6] fs: remove accidental overflow during wraparound check

by Sasha Levin

From: Justin Stitt <justinstitt(a)google.com> [ Upstream commit 23cc6ef6fd453b13502caae23130844e7d6ed0fe ] Running syzkaller with the newly enabled signed integer overflow sanitizer produces this report: [ 195.401651] ------------[ cut here ]------------ [ 195.404808] UBSAN: signed-integer-overflow in ../fs/open.c:321:15 [ 195.408739] 9223372036854775807 + 562984447377399 cannot be represented in type 'loff_t' (aka 'long long') [ 195.414683] CPU: 1 PID: 703 Comm: syz-executor.0 Not tainted 6.8.0-rc2-00039-g14de58dbe653-dirty #11 [ 195.420138] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 [ 195.425804] Call Trace: [ 195.427360] <TASK> [ 195.428791] dump_stack_lvl+0x93/0xd0 [ 195.431150] handle_overflow+0x171/0x1b0 [ 195.433640] vfs_fallocate+0x459/0x4f0 ... [ 195.490053] ------------[ cut here ]------------ [ 195.493146] UBSAN: signed-integer-overflow in ../fs/open.c:321:61 [ 195.497030] 9223372036854775807 + 562984447377399 cannot be represented in type 'loff_t' (aka 'long long) [ 195.502940] CPU: 1 PID: 703 Comm: syz-executor.0 Not tainted 6.8.0-rc2-00039-g14de58dbe653-dirty #11 [ 195.508395] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 [ 195.514075] Call Trace: [ 195.515636] <TASK> [ 195.517000] dump_stack_lvl+0x93/0xd0 [ 195.519255] handle_overflow+0x171/0x1b0 [ 195.521677] vfs_fallocate+0x4cb/0x4f0 [ 195.524033] __x64_sys_fallocate+0xb2/0xf0 Historically, the signed integer overflow sanitizer did not work in the kernel due to its interaction with `-fwrapv` but this has since been changed [1] in the newest version of Clang. It was re-enabled in the kernel with Commit 557f8c582a9ba8ab ("ubsan: Reintroduce signed overflow sanitizer"). Let's use the check_add_overflow helper to first verify the addition stays within the bounds of its type (long long); then we can use that sum for the following check. Link: https://github.com/llvm/llvm-project/pull/82432 [1] Closes: https://github.com/KSPP/linux/issues/356 Cc: linux-hardening(a)vger.kernel.org Reviewed-by: Kees Cook <keescook(a)chromium.org> Signed-off-by: Justin Stitt <justinstitt(a)google.com> Link: https://lore.kernel.org/r/20240513-b4-sio-vfs_fallocate-v2-1-db415872fb16@g… Reviewed-by: Jan Kara <jack(a)suse.cz> Signed-off-by: Christian Brauner <brauner(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- fs/open.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/fs/open.c b/fs/open.c index 694110929519c..be3eb6126d6da 100644 --- a/fs/open.c +++ b/fs/open.c @@ -230,6 +230,7 @@ int vfs_fallocate(struct file *file, int mode, loff_t offset, loff_t len) { struct inode *inode = file_inode(file); long ret; + loff_t sum; if (offset < 0 || len <= 0) return -EINVAL; @@ -298,8 +299,11 @@ int vfs_fallocate(struct file *file, int mode, loff_t offset, loff_t len) if (!S_ISREG(inode->i_mode) && !S_ISBLK(inode->i_mode)) return -ENODEV; - /* Check for wrap through zero too */ - if (((offset + len) > inode->i_sb->s_maxbytes) || ((offset + len) < 0)) + /* Check for wraparound */ + if (check_add_overflow(offset, len, &sum)) + return -EFBIG; + + if (sum > inode->i_sb->s_maxbytes) return -EFBIG; if (!file->f_op->fallocate) -- 2.43.0

1 year, 4 months

1
5
0 0

[PATCH AUTOSEL 5.15 1/6] fs: remove accidental overflow during wraparound check

by Sasha Levin

From: Justin Stitt <justinstitt(a)google.com> [ Upstream commit 23cc6ef6fd453b13502caae23130844e7d6ed0fe ] Running syzkaller with the newly enabled signed integer overflow sanitizer produces this report: [ 195.401651] ------------[ cut here ]------------ [ 195.404808] UBSAN: signed-integer-overflow in ../fs/open.c:321:15 [ 195.408739] 9223372036854775807 + 562984447377399 cannot be represented in type 'loff_t' (aka 'long long') [ 195.414683] CPU: 1 PID: 703 Comm: syz-executor.0 Not tainted 6.8.0-rc2-00039-g14de58dbe653-dirty #11 [ 195.420138] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 [ 195.425804] Call Trace: [ 195.427360] <TASK> [ 195.428791] dump_stack_lvl+0x93/0xd0 [ 195.431150] handle_overflow+0x171/0x1b0 [ 195.433640] vfs_fallocate+0x459/0x4f0 ... [ 195.490053] ------------[ cut here ]------------ [ 195.493146] UBSAN: signed-integer-overflow in ../fs/open.c:321:61 [ 195.497030] 9223372036854775807 + 562984447377399 cannot be represented in type 'loff_t' (aka 'long long) [ 195.502940] CPU: 1 PID: 703 Comm: syz-executor.0 Not tainted 6.8.0-rc2-00039-g14de58dbe653-dirty #11 [ 195.508395] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 [ 195.514075] Call Trace: [ 195.515636] <TASK> [ 195.517000] dump_stack_lvl+0x93/0xd0 [ 195.519255] handle_overflow+0x171/0x1b0 [ 195.521677] vfs_fallocate+0x4cb/0x4f0 [ 195.524033] __x64_sys_fallocate+0xb2/0xf0 Historically, the signed integer overflow sanitizer did not work in the kernel due to its interaction with `-fwrapv` but this has since been changed [1] in the newest version of Clang. It was re-enabled in the kernel with Commit 557f8c582a9ba8ab ("ubsan: Reintroduce signed overflow sanitizer"). Let's use the check_add_overflow helper to first verify the addition stays within the bounds of its type (long long); then we can use that sum for the following check. Link: https://github.com/llvm/llvm-project/pull/82432 [1] Closes: https://github.com/KSPP/linux/issues/356 Cc: linux-hardening(a)vger.kernel.org Reviewed-by: Kees Cook <keescook(a)chromium.org> Signed-off-by: Justin Stitt <justinstitt(a)google.com> Link: https://lore.kernel.org/r/20240513-b4-sio-vfs_fallocate-v2-1-db415872fb16@g… Reviewed-by: Jan Kara <jack(a)suse.cz> Signed-off-by: Christian Brauner <brauner(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- fs/open.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/fs/open.c b/fs/open.c index 97932af49071a..73d864636ae57 100644 --- a/fs/open.c +++ b/fs/open.c @@ -229,6 +229,7 @@ int vfs_fallocate(struct file *file, int mode, loff_t offset, loff_t len) { struct inode *inode = file_inode(file); long ret; + loff_t sum; if (offset < 0 || len <= 0) return -EINVAL; @@ -297,8 +298,11 @@ int vfs_fallocate(struct file *file, int mode, loff_t offset, loff_t len) if (!S_ISREG(inode->i_mode) && !S_ISBLK(inode->i_mode)) return -ENODEV; - /* Check for wrap through zero too */ - if (((offset + len) > inode->i_sb->s_maxbytes) || ((offset + len) < 0)) + /* Check for wraparound */ + if (check_add_overflow(offset, len, &sum)) + return -EFBIG; + + if (sum > inode->i_sb->s_maxbytes) return -EFBIG; if (!file->f_op->fallocate) -- 2.43.0

1 year, 4 months

1
5
0 0

[PATCH AUTOSEL 6.1 1/8] fs: remove accidental overflow during wraparound check

by Sasha Levin

From: Justin Stitt <justinstitt(a)google.com> [ Upstream commit 23cc6ef6fd453b13502caae23130844e7d6ed0fe ] Running syzkaller with the newly enabled signed integer overflow sanitizer produces this report: [ 195.401651] ------------[ cut here ]------------ [ 195.404808] UBSAN: signed-integer-overflow in ../fs/open.c:321:15 [ 195.408739] 9223372036854775807 + 562984447377399 cannot be represented in type 'loff_t' (aka 'long long') [ 195.414683] CPU: 1 PID: 703 Comm: syz-executor.0 Not tainted 6.8.0-rc2-00039-g14de58dbe653-dirty #11 [ 195.420138] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 [ 195.425804] Call Trace: [ 195.427360] <TASK> [ 195.428791] dump_stack_lvl+0x93/0xd0 [ 195.431150] handle_overflow+0x171/0x1b0 [ 195.433640] vfs_fallocate+0x459/0x4f0 ... [ 195.490053] ------------[ cut here ]------------ [ 195.493146] UBSAN: signed-integer-overflow in ../fs/open.c:321:61 [ 195.497030] 9223372036854775807 + 562984447377399 cannot be represented in type 'loff_t' (aka 'long long) [ 195.502940] CPU: 1 PID: 703 Comm: syz-executor.0 Not tainted 6.8.0-rc2-00039-g14de58dbe653-dirty #11 [ 195.508395] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 [ 195.514075] Call Trace: [ 195.515636] <TASK> [ 195.517000] dump_stack_lvl+0x93/0xd0 [ 195.519255] handle_overflow+0x171/0x1b0 [ 195.521677] vfs_fallocate+0x4cb/0x4f0 [ 195.524033] __x64_sys_fallocate+0xb2/0xf0 Historically, the signed integer overflow sanitizer did not work in the kernel due to its interaction with `-fwrapv` but this has since been changed [1] in the newest version of Clang. It was re-enabled in the kernel with Commit 557f8c582a9ba8ab ("ubsan: Reintroduce signed overflow sanitizer"). Let's use the check_add_overflow helper to first verify the addition stays within the bounds of its type (long long); then we can use that sum for the following check. Link: https://github.com/llvm/llvm-project/pull/82432 [1] Closes: https://github.com/KSPP/linux/issues/356 Cc: linux-hardening(a)vger.kernel.org Reviewed-by: Kees Cook <keescook(a)chromium.org> Signed-off-by: Justin Stitt <justinstitt(a)google.com> Link: https://lore.kernel.org/r/20240513-b4-sio-vfs_fallocate-v2-1-db415872fb16@g… Reviewed-by: Jan Kara <jack(a)suse.cz> Signed-off-by: Christian Brauner <brauner(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- fs/open.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/fs/open.c b/fs/open.c index 0d63c94e1c5e6..dd68725cd7247 100644 --- a/fs/open.c +++ b/fs/open.c @@ -244,6 +244,7 @@ int vfs_fallocate(struct file *file, int mode, loff_t offset, loff_t len) { struct inode *inode = file_inode(file); long ret; + loff_t sum; if (offset < 0 || len <= 0) return -EINVAL; @@ -312,8 +313,11 @@ int vfs_fallocate(struct file *file, int mode, loff_t offset, loff_t len) if (!S_ISREG(inode->i_mode) && !S_ISBLK(inode->i_mode)) return -ENODEV; - /* Check for wrap through zero too */ - if (((offset + len) > inode->i_sb->s_maxbytes) || ((offset + len) < 0)) + /* Check for wraparound */ + if (check_add_overflow(offset, len, &sum)) + return -EFBIG; + + if (sum > inode->i_sb->s_maxbytes) return -EFBIG; if (!file->f_op->fallocate) -- 2.43.0

1 year, 4 months

1
7
0 0

[PATCH AUTOSEL 6.6 1/9] fs: remove accidental overflow during wraparound check

by Sasha Levin

From: Justin Stitt <justinstitt(a)google.com> [ Upstream commit 23cc6ef6fd453b13502caae23130844e7d6ed0fe ] Running syzkaller with the newly enabled signed integer overflow sanitizer produces this report: [ 195.401651] ------------[ cut here ]------------ [ 195.404808] UBSAN: signed-integer-overflow in ../fs/open.c:321:15 [ 195.408739] 9223372036854775807 + 562984447377399 cannot be represented in type 'loff_t' (aka 'long long') [ 195.414683] CPU: 1 PID: 703 Comm: syz-executor.0 Not tainted 6.8.0-rc2-00039-g14de58dbe653-dirty #11 [ 195.420138] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 [ 195.425804] Call Trace: [ 195.427360] <TASK> [ 195.428791] dump_stack_lvl+0x93/0xd0 [ 195.431150] handle_overflow+0x171/0x1b0 [ 195.433640] vfs_fallocate+0x459/0x4f0 ... [ 195.490053] ------------[ cut here ]------------ [ 195.493146] UBSAN: signed-integer-overflow in ../fs/open.c:321:61 [ 195.497030] 9223372036854775807 + 562984447377399 cannot be represented in type 'loff_t' (aka 'long long) [ 195.502940] CPU: 1 PID: 703 Comm: syz-executor.0 Not tainted 6.8.0-rc2-00039-g14de58dbe653-dirty #11 [ 195.508395] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 [ 195.514075] Call Trace: [ 195.515636] <TASK> [ 195.517000] dump_stack_lvl+0x93/0xd0 [ 195.519255] handle_overflow+0x171/0x1b0 [ 195.521677] vfs_fallocate+0x4cb/0x4f0 [ 195.524033] __x64_sys_fallocate+0xb2/0xf0 Historically, the signed integer overflow sanitizer did not work in the kernel due to its interaction with `-fwrapv` but this has since been changed [1] in the newest version of Clang. It was re-enabled in the kernel with Commit 557f8c582a9ba8ab ("ubsan: Reintroduce signed overflow sanitizer"). Let's use the check_add_overflow helper to first verify the addition stays within the bounds of its type (long long); then we can use that sum for the following check. Link: https://github.com/llvm/llvm-project/pull/82432 [1] Closes: https://github.com/KSPP/linux/issues/356 Cc: linux-hardening(a)vger.kernel.org Reviewed-by: Kees Cook <keescook(a)chromium.org> Signed-off-by: Justin Stitt <justinstitt(a)google.com> Link: https://lore.kernel.org/r/20240513-b4-sio-vfs_fallocate-v2-1-db415872fb16@g… Reviewed-by: Jan Kara <jack(a)suse.cz> Signed-off-by: Christian Brauner <brauner(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- fs/open.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/fs/open.c b/fs/open.c index 59db720693f9a..61f0b733ad962 100644 --- a/fs/open.c +++ b/fs/open.c @@ -245,6 +245,7 @@ int vfs_fallocate(struct file *file, int mode, loff_t offset, loff_t len) { struct inode *inode = file_inode(file); long ret; + loff_t sum; if (offset < 0 || len <= 0) return -EINVAL; @@ -313,8 +314,11 @@ int vfs_fallocate(struct file *file, int mode, loff_t offset, loff_t len) if (!S_ISREG(inode->i_mode) && !S_ISBLK(inode->i_mode)) return -ENODEV; - /* Check for wrap through zero too */ - if (((offset + len) > inode->i_sb->s_maxbytes) || ((offset + len) < 0)) + /* Check for wraparound */ + if (check_add_overflow(offset, len, &sum)) + return -EFBIG; + + if (sum > inode->i_sb->s_maxbytes) return -EFBIG; if (!file->f_op->fallocate) -- 2.43.0

1 year, 4 months

1
8
0 0

[PATCH v2] Bluetooth: hci_core: fix suspicious RCU usage in hci_conn_drop()

by Yunseong Kim

Protection from the queuing operation is achieved with an RCU read lock to avoid calling 'queue_delayed_work()' after 'cancel_delayed_work()', but this does not apply to 'hci_conn_drop()'. commit deee93d13d38 ("Bluetooth: use hdev->workqueue when queuing hdev->{cmd,ncmd}_timer works") The situation described raises concerns about suspicious RCU usage in a corrupted context. CPU 1 CPU 2 hci_dev_do_reset() synchronize_rcu() hci_conn_drop() drain_workqueue() <-- no RCU read protection during queuing. --> queue_delayed_work() It displays a warning message like the following Bluetooth: hci0: unexpected cc 0x0c38 length: 249 > 2 ============================= WARNING: suspicious RCU usage 6.10.0-rc6-01340-gf14c0bb78769 #5 Not tainted ----------------------------- net/mac80211/util.c:4000 RCU-list traversed in non-reader section!! other info that might help us debug this: rcu_scheduler_active = 2, debug_locks = 1 2 locks held by syz-executor/798: #0: ffff800089a3de50 (rtnl_mutex){+.+.}-{4:4}, at: rtnl_lock+0x28/0x40 net/core/rtnetlink.c:79 stack backtrace: CPU: 0 PID: 798 Comm: syz-executor Not tainted 6.10.0-rc6-01340-gf14c0bb78769 #5 Hardware name: linux,dummy-virt (DT) Call trace: dump_backtrace.part.0+0x1b8/0x1d0 arch/arm64/kernel/stacktrace.c:317 dump_backtrace arch/arm64/kernel/stacktrace.c:323 [inline] show_stack+0x34/0x50 arch/arm64/kernel/stacktrace.c:324 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xf0/0x170 lib/dump_stack.c:114 dump_stack+0x20/0x30 lib/dump_stack.c:123 lockdep_rcu_suspicious+0x204/0x2f8 kernel/locking/lockdep.c:6712 ieee80211_check_combinations+0x71c/0x828 [mac80211] ieee80211_check_concurrent_iface+0x494/0x700 [mac80211] ieee80211_open+0x140/0x238 [mac80211] __dev_open+0x270/0x498 net/core/dev.c:1474 __dev_change_flags+0x47c/0x610 net/core/dev.c:8837 dev_change_flags+0x98/0x170 net/core/dev.c:8909 devinet_ioctl+0xdf0/0x18d0 net/ipv4/devinet.c:1177 inet_ioctl+0x34c/0x388 net/ipv4/af_inet.c:1003 sock_do_ioctl+0xe4/0x240 net/socket.c:1222 sock_ioctl+0x4cc/0x740 net/socket.c:1341 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:907 [inline] __se_sys_ioctl fs/ioctl.c:893 [inline] __arm64_sys_ioctl+0x184/0x218 fs/ioctl.c:893 __invoke_syscall arch/arm64/kernel/syscall.c:34 [inline] invoke_syscall+0x90/0x2e8 arch/arm64/kernel/syscall.c:48 el0_svc_common.constprop.0+0x200/0x2a8 arch/arm64/kernel/syscall.c:131 el0_svc+0x48/0xc0 arch/arm64/kernel/entry-common.c:712 el0t_64_sync_handler+0x120/0x130 arch/arm64/kernel/entry-common.c:730 el0t_64_sync+0x190/0x198 arch/arm64/kernel/entry.S:598 This patch attempts to fix that issue with the same convention. Cc: stable(a)vger.kernel.org # v6.1+ Fixes: deee93d13d38 ("Bluetooth: use hdev->workqueue when queuing hdev->{cmd,ncmd}_timer works") Signed-off-by: Yeoreum Yun <yeoreum.yun(a)arm.com> Tested-by: Yunseong Kim <yskelg(a)gmail.com> Signed-off-by: Yunseong Kim <yskelg(a)gmail.com> --- include/net/bluetooth/hci_core.h | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h index 31020891fc68..111509dc1a23 100644 --- a/include/net/bluetooth/hci_core.h +++ b/include/net/bluetooth/hci_core.h @@ -1572,8 +1572,13 @@ static inline void hci_conn_drop(struct hci_conn *conn) } cancel_delayed_work(&conn->disc_work); - queue_delayed_work(conn->hdev->workqueue, - &conn->disc_work, timeo); + + rcu_read_lock(); + if (!hci_dev_test_flag(conn->hdev, HCI_CMD_DRAIN_WORKQUEUE)) { + queue_delayed_work(conn->hdev->workqueue, + &conn->disc_work, timeo); + } + rcu_read_unlock(); } } -- 2.45.2

1 year, 4 months

2
2
0 0

[REGRESSION] Brightness at max level after waking up from sleep on AMD Laptop

by serg.partizan＠gmail.com

Hello, After updating from 6.8.9 to 6.9.1 I noticed a bug on my HP Envy x360 with AMD Ryzen 5 4500U. #regzbot introduced: v6.8.9..v6.9.1 After waking up from sleep brightness is set to max level, ignoring previous value. With the help of Arch Linux team, we was able to track bad commit to this: https://gitlab.freedesktop.org/agd5f/linux/-/commit/63d0b87213a0ba241b3fcfb… I have tested this on latest mainline kernel: Results after waking up: > cat /sys/class/backlight/amdgpu_bl1/{brightness,actual_brightness} 12 252 Then, on exact this commit (63d0b87213a0ba241b3fcfba3fe7b0aed0cd1cc5), result is the same. Then, on commit just before this one (aeaf3e6cf842): > cat /sys/class/backlight/amdgpu_bl1/{brightness,actual_brightness} 12 12 I hope I included all relevant information, more info can be found here: https://gitlab.archlinux.org/archlinux/packaging/packages/linux/-/issues/52

1 year, 4 months

1
0
0 0

Linux 6.10.2

by Greg Kroah-Hartman

I'm announcing the release of the 6.10.2 kernel. All users of the 6.10 kernel series must upgrade. The updated 6.10.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-6.10.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Makefile | 2 - arch/arm64/boot/dts/qcom/ipq6018.dtsi | 1 arch/arm64/boot/dts/qcom/ipq8074.dtsi | 2 + arch/arm64/boot/dts/qcom/msm8996.dtsi | 1 arch/arm64/boot/dts/qcom/msm8998.dtsi | 1 arch/arm64/boot/dts/qcom/qrb2210-rb1.dts | 13 +++++++- arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 13 +++++++- arch/arm64/boot/dts/qcom/sc7180.dtsi | 1 arch/arm64/boot/dts/qcom/sc7280.dtsi | 1 arch/arm64/boot/dts/qcom/sdm630.dtsi | 1 arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 + arch/arm64/boot/dts/qcom/sm6115.dtsi | 1 arch/arm64/boot/dts/qcom/sm6350.dtsi | 1 arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 17 ++++++++--- arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 17 ++++++++--- arch/s390/mm/fault.c | 3 + drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 - drivers/net/tap.c | 5 +++ drivers/net/tun.c | 3 + drivers/usb/gadget/function/f_midi2.c | 19 +++++++----- fs/jfs/xattr.c | 23 ++++++++++++--- fs/locks.c | 9 ++--- fs/ntfs3/fslog.c | 44 ++++++++++++++++++++++++---- fs/ocfs2/dir.c | 46 ++++++++++++++++++------------ sound/core/pcm_dmaengine.c | 6 +++ sound/core/seq/seq_ump_client.c | 16 ++++++++++ sound/pci/hda/patch_realtek.c | 3 + 27 files changed, 198 insertions(+), 55 deletions(-) Abel Vesa (4): arm64: dts: qcom: x1e80100-qcp: Fix USB PHYs regulators arm64: dts: qcom: x1e80100-crd: Fix the PHY regulator for PCIe 6a arm64: dts: qcom: x1e80100-qcp: Fix the PHY regulator for PCIe 6a arm64: dts: qcom: x1e80100-crd: Fix USB PHYs regulators Dan Carpenter (1): drm/amdgpu: Fix signedness bug in sdma_v4_0_process_trap_irq() Dmitry Baryshkov (2): arm64: dts: qcom: qrb2210-rb1: switch I2C2 to i2c-gpio arm64: dts: qcom: qrb4210-rb2: switch I2C2 to i2c-gpio Dongli Zhang (1): tun: add missing verification for short frame Edson Juliano Drosdeck (1): ALSA: hda/realtek: Enable headset mic on Positivo SU C1400 Gerald Schaefer (1): s390/mm: Fix VM_FAULT_HWPOISON handling in do_exception() Greg Kroah-Hartman (1): Linux 6.10.2 Jann Horn (1): filelock: Fix fcntl/close race recovery compat path Konstantin Komarov (1): fs/ntfs3: Add a check for attr_names and oatbl Krishna Kurapati (10): arm64: dts: qcom: sc7180: Disable SuperSpeed instances in park mode arm64: dts: qcom: sc7280: Disable SuperSpeed instances in park mode arm64: dts: qcom: msm8996: Disable SS instance in Parkmode for USB arm64: dts: qcom: sm6350: Disable SS instance in Parkmode for USB arm64: dts: qcom: msm8998: Disable SS instance in Parkmode for USB arm64: dts: qcom: ipq6018: Disable SS instance in Parkmode for USB arm64: dts: qcom: sdm630: Disable SS instance in Parkmode for USB arm64: dts: qcom: ipq8074: Disable SS instance in Parkmode for USB arm64: dts: qcom: sdm845: Disable SS instance in Parkmode for USB arm64: dts: qcom: sm6115: Disable SS instance in Parkmode for USB Seunghun Han (1): ALSA: hda/realtek: Fix the speaker output on Samsung Galaxy Book Pro 360 Shenghao Ding (1): ALSA: hda/tas2781: Add new quirk for Lenovo Hera2 Laptop Shengjiu Wang (1): ALSA: pcm_dmaengine: Don't synchronize DMA channel when DMA is paused Si-Wei Liu (1): tap: add missing verification for short frame Takashi Iwai (2): usb: gadget: midi2: Fix incorrect default MIDI2 protocol setup ALSA: seq: ump: Skip useless ports for static blocks lei lu (3): ocfs2: add bounds checking to ocfs2_check_dir_entry() jfs: don't walk off the end of ealist fs/ntfs3: Validate ff offset

1 year, 4 months

1
1
0 0

Linux 6.6.43

by Greg Kroah-Hartman

I'm announcing the release of the 6.6.43 kernel. All users of the 6.6 kernel series must upgrade. The updated 6.6.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-6.6.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Makefile | 2 - arch/arm64/boot/dts/qcom/ipq6018.dtsi | 1 arch/arm64/boot/dts/qcom/msm8996.dtsi | 1 arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 13 ++++++++ arch/arm64/boot/dts/qcom/sdm630.dtsi | 1 arch/arm64/boot/dts/qcom/sm6350.dtsi | 1 drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 - drivers/net/tap.c | 5 +++ drivers/net/tun.c | 3 ++ drivers/usb/gadget/function/f_midi2.c | 19 +++++++----- fs/jfs/xattr.c | 23 ++++++++++++--- fs/locks.c | 9 ++---- fs/ntfs3/fslog.c | 44 ++++++++++++++++++++++++----- fs/ocfs2/dir.c | 46 +++++++++++++++++++------------ sound/core/pcm_dmaengine.c | 6 +++- sound/core/seq/seq_ump_client.c | 16 ++++++++++ sound/pci/hda/patch_realtek.c | 2 + 17 files changed, 149 insertions(+), 45 deletions(-) Dan Carpenter (1): drm/amdgpu: Fix signedness bug in sdma_v4_0_process_trap_irq() Dmitry Baryshkov (1): arm64: dts: qcom: qrb4210-rb2: switch I2C2 to i2c-gpio Dongli Zhang (1): tun: add missing verification for short frame Edson Juliano Drosdeck (1): ALSA: hda/realtek: Enable headset mic on Positivo SU C1400 Greg Kroah-Hartman (1): Linux 6.6.43 Jann Horn (1): filelock: Fix fcntl/close race recovery compat path Konstantin Komarov (1): fs/ntfs3: Add a check for attr_names and oatbl Krishna Kurapati (4): arm64: dts: qcom: msm8996: Disable SS instance in Parkmode for USB arm64: dts: qcom: sm6350: Disable SS instance in Parkmode for USB arm64: dts: qcom: ipq6018: Disable SS instance in Parkmode for USB arm64: dts: qcom: sdm630: Disable SS instance in Parkmode for USB Seunghun Han (1): ALSA: hda/realtek: Fix the speaker output on Samsung Galaxy Book Pro 360 Shengjiu Wang (1): ALSA: pcm_dmaengine: Don't synchronize DMA channel when DMA is paused Si-Wei Liu (1): tap: add missing verification for short frame Takashi Iwai (2): usb: gadget: midi2: Fix incorrect default MIDI2 protocol setup ALSA: seq: ump: Skip useless ports for static blocks lei lu (3): ocfs2: add bounds checking to ocfs2_check_dir_entry() jfs: don't walk off the end of ealist fs/ntfs3: Validate ff offset

1 year, 4 months

1
1
0 0

Linux 6.1.102

by Greg Kroah-Hartman

I'm announcing the release of the 6.1.102 kernel. All users of the 6.1 kernel series must upgrade. The updated 6.1.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-6.1.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Makefile | 2 - arch/arm64/boot/dts/qcom/ipq6018.dtsi | 1 arch/arm64/boot/dts/qcom/msm8996.dtsi | 1 arch/arm64/boot/dts/qcom/sdm630.dtsi | 1 drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 - drivers/net/tap.c | 5 +++ drivers/net/tun.c | 3 ++ fs/btrfs/transaction.c | 5 ++- fs/f2fs/super.c | 15 +++++++++- fs/jfs/xattr.c | 23 +++++++++++++--- fs/locks.c | 9 ++---- fs/ntfs3/fslog.c | 6 +++- fs/ocfs2/dir.c | 46 ++++++++++++++++++++------------- sound/core/pcm_dmaengine.c | 6 +++- sound/pci/hda/patch_realtek.c | 2 + 15 files changed, 94 insertions(+), 33 deletions(-) Chao Yu (1): f2fs: avoid dead loop in f2fs_issue_checkpoint() Dan Carpenter (1): drm/amdgpu: Fix signedness bug in sdma_v4_0_process_trap_irq() Dongli Zhang (1): tun: add missing verification for short frame Edson Juliano Drosdeck (1): ALSA: hda/realtek: Enable headset mic on Positivo SU C1400 Filipe Manana (1): btrfs: do not BUG_ON on failure to get dir index for new snapshot Greg Kroah-Hartman (1): Linux 6.1.102 Jann Horn (1): filelock: Fix fcntl/close race recovery compat path Krishna Kurapati (3): arm64: dts: qcom: msm8996: Disable SS instance in Parkmode for USB arm64: dts: qcom: ipq6018: Disable SS instance in Parkmode for USB arm64: dts: qcom: sdm630: Disable SS instance in Parkmode for USB Seunghun Han (1): ALSA: hda/realtek: Fix the speaker output on Samsung Galaxy Book Pro 360 Shengjiu Wang (1): ALSA: pcm_dmaengine: Don't synchronize DMA channel when DMA is paused Si-Wei Liu (1): tap: add missing verification for short frame lei lu (3): ocfs2: add bounds checking to ocfs2_check_dir_entry() jfs: don't walk off the end of ealist fs/ntfs3: Validate ff offset

1 year, 4 months

1
1
0 0

Linux 5.15.164

by Greg Kroah-Hartman

I'm announcing the release of the 5.15.164 kernel. All users of the 5.15 kernel series must upgrade. The updated 5.15.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.15.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Documentation/admin-guide/filesystem-monitoring.rst | 20 +- Makefile | 2 arch/arm/include/asm/uaccess.h | 14 - arch/arm64/boot/dts/qcom/msm8996.dtsi | 1 arch/arm64/boot/dts/qcom/sdm630.dtsi | 1 arch/arm64/kernel/armv8_deprecated.c | 3 arch/mips/kernel/syscalls/syscall_o32.tbl | 2 arch/powerpc/kernel/eeh_pe.c | 7 arch/powerpc/kvm/book3s_64_vio.c | 18 +- arch/powerpc/platforms/pseries/setup.c | 4 arch/riscv/kernel/stacktrace.c | 3 drivers/acpi/ec.c | 9 - drivers/acpi/processor_idle.c | 40 +--- drivers/block/null_blk/main.c | 4 drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 drivers/gpu/drm/radeon/radeon_gem.c | 2 drivers/gpu/drm/vmwgfx/Kconfig | 2 drivers/input/mouse/elantech.c | 31 +++ drivers/input/serio/i8042-acpipnpio.h | 18 +- drivers/input/touchscreen/silead.c | 19 -- drivers/misc/mei/main.c | 2 drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c | 2 drivers/net/tap.c | 5 drivers/net/tun.c | 3 drivers/net/usb/qmi_wwan.c | 2 drivers/net/wireless/intel/iwlwifi/mvm/d3.c | 16 + drivers/net/wireless/intel/iwlwifi/mvm/scan.c | 5 drivers/net/wireless/ralink/rt2x00/rt2400pci.c | 8 drivers/net/wireless/ralink/rt2x00/rt2400pci.h | 2 drivers/net/wireless/ralink/rt2x00/rt2500pci.c | 8 drivers/net/wireless/ralink/rt2x00/rt2500pci.h | 2 drivers/net/wireless/ralink/rt2x00/rt2500usb.c | 8 drivers/net/wireless/ralink/rt2x00/rt2500usb.h | 2 drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 36 ++-- drivers/net/wireless/ralink/rt2x00/rt2800lib.h | 8 drivers/net/wireless/ralink/rt2x00/rt2x00usb.c | 6 drivers/net/wireless/ralink/rt2x00/rt61pci.c | 4 drivers/net/wireless/ralink/rt2x00/rt61pci.h | 2 drivers/net/wireless/ralink/rt2x00/rt73usb.c | 4 drivers/net/wireless/ralink/rt2x00/rt73usb.h | 2 drivers/nvme/host/core.c | 1 drivers/platform/x86/lg-laptop.c | 89 +++------- drivers/platform/x86/wireless-hotkey.c | 2 drivers/s390/char/sclp.c | 1 drivers/scsi/device_handler/scsi_dh_alua.c | 31 ++- drivers/scsi/hosts.c | 16 + drivers/scsi/libsas/sas_internal.h | 14 + drivers/scsi/qedf/qedf.h | 1 drivers/scsi/qedf/qedf_main.c | 47 ++++- drivers/scsi/scsi_lib.c | 6 drivers/scsi/scsi_priv.h | 2 drivers/scsi/scsi_scan.c | 1 drivers/scsi/scsi_sysfs.c | 1 drivers/spi/spi-imx.c | 2 drivers/spi/spi-mux.c | 1 fs/btrfs/qgroup.c | 4 fs/dcache.c | 31 +-- fs/file.c | 4 fs/hfsplus/xattr.c | 2 fs/jfs/xattr.c | 23 ++ fs/locks.c | 18 -- fs/ntfs3/fslog.c | 6 fs/ocfs2/dir.c | 46 +++-- include/linux/compiler.h | 6 include/linux/minmax.h | 89 +++++++--- include/linux/overflow.h | 1 include/linux/trace_events.h | 2 include/scsi/scsi_host.h | 2 include/sound/dmaengine_pcm.h | 1 kernel/bpf/ringbuf.c | 30 ++- mm/damon/core.c | 23 ++ net/bluetooth/hci_core.c | 4 net/ipv4/af_inet.c | 4 net/ipv6/ila/ila_lwt.c | 7 net/ipv6/rpl_iptunnel.c | 14 - net/mac80211/ieee80211_i.h | 2 net/mac80211/main.c | 11 + net/mac80211/mesh.c | 1 net/mac80211/scan.c | 14 + net/mac80211/util.c | 4 net/mac802154/tx.c | 8 net/wireless/scan.c | 8 samples/Kconfig | 9 + samples/Makefile | 1 samples/fanotify/.gitignore | 1 samples/fanotify/Makefile | 5 samples/fanotify/fs-monitor.c | 142 ++++++++++++++++ scripts/gcc-plugins/gcc-common.h | 4 scripts/kconfig/expr.c | 29 --- scripts/kconfig/expr.h | 1 scripts/kconfig/gconf.c | 3 scripts/kconfig/menu.c | 2 sound/core/pcm_dmaengine.c | 26 ++ sound/pci/hda/patch_realtek.c | 7 sound/soc/intel/boards/bytcr_rt5640.c | 11 + sound/soc/soc-generic-dmaengine-pcm.c | 8 sound/soc/ti/davinci-mcasp.c | 9 - sound/soc/ti/omap-hdmi.c | 6 tools/power/cpupower/utils/helpers/amd.c | 26 ++ tools/testing/selftests/openat2/openat2_test.c | 1 tools/testing/selftests/vDSO/parse_vdso.c | 16 + tools/testing/selftests/vDSO/vdso_standalone_test_x86.c | 18 +- 102 files changed, 868 insertions(+), 366 deletions(-) Aivaz Latypov (1): ALSA: hda/relatek: Enable Mute LED on HP Laptop 15-gw0xxx Alexander Usyskin (1): mei: demote client disconnect warning on suspend to debug Alexey Makhalov (1): drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency Andreas Hindborg (1): null_blk: fix validation of block size Andy Shevchenko (1): minmax: fix header inclusions Anjali K (1): powerpc/pseries: Whitelist dtl slub object for copying to userspace Armin Wolf (6): ACPI: EC: Abort address space access upon error ACPI: EC: Avoid returning AE_OK on errors in address space handler platform/x86: wireless-hotkey: Add support for LG Airplane Button platform/x86: lg-laptop: Remove LGEX0815 hotkey handling platform/x86: lg-laptop: Change ACPI device id platform/x86: lg-laptop: Use ACPI device handle when evaluating WMAB/WMBB Arnd Bergmann (1): mips: fix compat_sys_lseek syscall Ayala Beker (1): wifi: iwlwifi: mvm: properly set 6 GHz channel direct probe option Bart Van Assche (2): scsi: core: Fix a use-after-free tracing: Define the is_signed_type() macro once Chen Ni (1): can: kvaser_usb: fix return value for hif_usb_send_regout Christian Brauner (1): fs: better handle deep ancestor chains in is_subdir() Chunguang Xu (1): nvme: avoid double free special payload Dan Carpenter (1): drm/amdgpu: Fix signedness bug in sdma_v4_0_process_trap_irq() Daniel Borkmann (1): bpf: Fix overrunning reservations in ringbuf Daniele Palmas (1): net: usb: qmi_wwan: add Telit FN912 compositions David Laight (3): minmax: allow min()/max()/clamp() if the arguments have the same signedness. minmax: allow comparisons of 'int' against 'unsigned char/short' minmax: relax check to allow comparison between unsigned arguments and signed constants David Lechner (1): spi: mux: set ctlr->bits_per_word_mask Dhananjay Ugwekar (1): tools/power/cpupower: Fix Pstate frequency reporting on AMD Family 1Ah CPUs Dmitry Antipov (2): wifi: mac80211: fix UBSAN noise in ieee80211_prep_hw_scan() wifi: cfg80211: wext: add extra SIOCSIWSCAN data check Dongli Zhang (1): tun: add missing verification for short frame Edson Juliano Drosdeck (1): ALSA: hda/realtek: Enable headset mic on Positivo SU C1400 Edward Adam Davis (1): hfsplus: fix uninit-value in copy_name Eric Dumazet (2): net: ipv6: rpl_iptunnel: block BH in rpl_output() and rpl_input() ila: block BH in ila_output() Filipe Manana (1): btrfs: qgroup: fix quota root leak after quota disable failure Gabriel Krisman Bertazi (3): samples: Add fs error monitoring example samples: Make fs-monitor depend on libc and headers docs: Fix formatting of literal sections in fanotify docs Ganesh Goudar (1): powerpc/eeh: avoid possible crash when edev->pdev changes Greg Kroah-Hartman (1): Linux 5.15.164 Hans de Goede (1): Input: silead - Always support 10 fingers Heiko Carstens (1): s390/sclp: Fix sclp_init() cleanup on failure Jai Luthra (2): ALSA: dmaengine: Synchronize dma channel after drop() ASoC: ti: davinci-mcasp: Set min period size using FIFO config Jann Horn (2): filelock: Remove locks reliably when fcntl/close race is detected filelock: Fix fcntl/close race recovery compat path Jason A. Donenfeld (3): minmax: sanity check constant bounds when clamping minmax: clamp more efficiently by avoiding extra comparison wifi: rt2x00: use explicitly signed or unsigned types Johannes Berg (2): wifi: mac80211: handle tasklet frames before stopping wifi: mac80211: disable softirqs for queued frame handling John Hubbard (1): selftests/vDSO: fix clang build errors and warnings Jonathan Denose (1): Input: elantech - fix touchpad state on resume for Lenovo N24 Kailang Yang (1): ALSA: hda/realtek: Add more codec ID to no shutup pins list Kees Cook (1): gcc-plugins: Rename last_stmt() for GCC 14+ Krishna Kurapati (2): arm64: dts: qcom: msm8996: Disable SS instance in Parkmode for USB arm64: dts: qcom: sdm630: Disable SS instance in Parkmode for USB Kuan-Wei Chiu (1): ACPI: processor_idle: Fix invalid comparison with insertion sort for latency Linus Torvalds (1): Add gitignore file for samples/fanotify/ subdirectory Martin Wilck (1): scsi: core: alua: I/O errors for ALUA state transitions Masahiro Yamada (3): ARM: 9324/1: fix get_user() broken with veneer kconfig: gconf: give a proper initial state to the Save button kconfig: remove wrong expr_trans_bool() Michael Ellerman (2): selftests/openat2: Fix build warnings on ppc64 KVM: PPC: Book3S HV: Prevent UAF in kvm_spapr_tce_attach_iommu_group() Nicolas Escande (1): wifi: mac80211: mesh: init nonpeer_pm to active by default in mesh sdata Paolo Abeni (1): net: relax socket state check at accept time. Pierre-Eric Pelloux-Prayer (1): drm/radeon: check bo_va->bo is non-NULL before using it Primoz Fiser (1): ASoC: ti: omap-hdmi: Fix too long driver name Puranjay Mohan (1): riscv: stacktrace: fix usage of ftrace_graph_ret_addr() Saurav Kashyap (3): scsi: qedf: Don't process stag work during unload and recovery scsi: qedf: Wait for stag work during unload scsi: qedf: Set qed_slowpath_params to zero before use SeongJae Park (1): mm/damon/core: merge regions aggressively when max_nr_regions is unmet Seunghun Han (1): ALSA: hda/realtek: Fix the speaker output on Samsung Galaxy Book Pro 360 Shengjiu Wang (2): ALSA: dmaengine_pcm: terminate dmaengine before synchronize ALSA: pcm_dmaengine: Don't synchronize DMA channel when DMA is paused Si-Wei Liu (1): tap: add missing verification for short frame Tetsuo Handa (1): Bluetooth: hci_core: cancel all works upon hci_unregister_dev() Thomas GENTY (1): bytcr_rt5640 : inverse jack detect for Archos 101 cesium Tobias Jakobi (1): Input: i8042 - add Ayaneo Kun to i8042 quirk table Uwe Kleine-König (1): spi: imx: Don't expect DMA for i.MX{25,35,50,51,53} cspi devices Wei Li (1): arm64: armv8_deprecated: Fix warning in isndep cpuhp starting process Xingui Yang (1): scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed Yedidya Benshimol (2): wifi: iwlwifi: mvm: d3: fix WoWLAN command version lookup wifi: iwlwifi: mvm: Handle BIGTK cipher in kek_kck cmd Yunshui Jiang (1): net: mac802154: Fix racy device stats updates by DEV_STATS_INC() and DEV_STATS_ADD() Yuntao Wang (1): fs/file: fix the check in find_next_fd() lei lu (3): ocfs2: add bounds checking to ocfs2_check_dir_entry() jfs: don't walk off the end of ealist fs/ntfs3: Validate ff offset

1 year, 4 months

1
1
0 0

Linux 5.10.223

by Greg Kroah-Hartman

I'm announcing the release of the 5.10.223 kernel. All users of the 5.10 kernel series must upgrade. The updated 5.10.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.10.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Makefile | 2 arch/arm/include/asm/uaccess.h | 14 ---- arch/arm64/boot/dts/qcom/msm8996.dtsi | 1 arch/arm64/kernel/armv8_deprecated.c | 3 + arch/mips/kernel/syscalls/syscall_o32.tbl | 2 arch/powerpc/kernel/eeh_pe.c | 7 +- arch/powerpc/kvm/book3s_64_vio.c | 18 ++++-- arch/powerpc/platforms/pseries/setup.c | 4 - drivers/acpi/ec.c | 9 ++- drivers/acpi/processor_idle.c | 40 +++++-------- drivers/block/null_blk/main.c | 4 - drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 drivers/input/mouse/elantech.c | 31 ++++++++++ drivers/input/serio/i8042-acpipnpio.h | 18 +++++- drivers/input/touchscreen/silead.c | 19 +----- drivers/misc/mei/main.c | 2 drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c | 2 drivers/net/tap.c | 5 + drivers/net/tun.c | 3 + drivers/net/usb/qmi_wwan.c | 2 drivers/s390/char/sclp.c | 1 drivers/scsi/hosts.c | 16 ++++- drivers/scsi/libsas/sas_internal.h | 14 ++++ drivers/scsi/qedf/qedf_main.c | 1 drivers/scsi/scsi_lib.c | 6 +- drivers/scsi/scsi_priv.h | 2 drivers/scsi/scsi_scan.c | 1 drivers/scsi/scsi_sysfs.c | 1 drivers/spi/spi-imx.c | 2 drivers/spi/spi-mux.c | 1 fs/btrfs/qgroup.c | 4 - fs/dcache.c | 31 ++++------ fs/ext4/super.c | 9 ++- fs/file.c | 4 - fs/hfsplus/xattr.c | 2 fs/jfs/xattr.c | 23 ++++++-- fs/locks.c | 18 ++---- fs/ocfs2/dir.c | 46 ++++++++++------ include/linux/skmsg.h | 2 include/scsi/scsi_host.h | 2 include/sound/dmaengine_pcm.h | 1 kernel/bpf/ringbuf.c | 30 ++++++++-- net/bluetooth/hci_core.c | 4 + net/ipv4/af_inet.c | 4 + net/ipv6/ila/ila_lwt.c | 7 ++ net/ipv6/rpl_iptunnel.c | 14 ++-- net/mac80211/mesh.c | 1 net/mac80211/scan.c | 14 +++- net/mac802154/tx.c | 8 +- net/wireless/scan.c | 8 ++ scripts/gcc-plugins/gcc-common.h | 4 + scripts/kconfig/expr.c | 29 ---------- scripts/kconfig/expr.h | 1 scripts/kconfig/gconf.c | 3 - scripts/kconfig/menu.c | 2 sound/core/pcm_dmaengine.c | 26 +++++++++ sound/pci/hda/patch_realtek.c | 7 ++ sound/soc/intel/boards/bytcr_rt5640.c | 11 +++ sound/soc/soc-generic-dmaengine-pcm.c | 8 ++ sound/soc/ti/davinci-mcasp.c | 9 ++- sound/soc/ti/omap-hdmi.c | 6 -- tools/testing/selftests/openat2/openat2_test.c | 1 tools/testing/selftests/vDSO/parse_vdso.c | 16 +++-- tools/testing/selftests/vDSO/vdso_standalone_test_x86.c | 18 +++++- 64 files changed, 403 insertions(+), 203 deletions(-) Aivaz Latypov (1): ALSA: hda/relatek: Enable Mute LED on HP Laptop 15-gw0xxx Alexander Usyskin (1): mei: demote client disconnect warning on suspend to debug Andreas Hindborg (1): null_blk: fix validation of block size Anjali K (1): powerpc/pseries: Whitelist dtl slub object for copying to userspace Armin Wolf (2): ACPI: EC: Abort address space access upon error ACPI: EC: Avoid returning AE_OK on errors in address space handler Arnd Bergmann (1): mips: fix compat_sys_lseek syscall Bart Van Assche (1): scsi: core: Fix a use-after-free Chen Ni (1): can: kvaser_usb: fix return value for hif_usb_send_regout Christian Brauner (1): fs: better handle deep ancestor chains in is_subdir() Dan Carpenter (1): drm/amdgpu: Fix signedness bug in sdma_v4_0_process_trap_irq() Daniel Borkmann (1): bpf: Fix overrunning reservations in ringbuf Daniele Palmas (1): net: usb: qmi_wwan: add Telit FN912 compositions David Lechner (1): spi: mux: set ctlr->bits_per_word_mask Dmitry Antipov (2): wifi: mac80211: fix UBSAN noise in ieee80211_prep_hw_scan() wifi: cfg80211: wext: add extra SIOCSIWSCAN data check Dongli Zhang (1): tun: add missing verification for short frame Edson Juliano Drosdeck (1): ALSA: hda/realtek: Enable headset mic on Positivo SU C1400 Edward Adam Davis (1): hfsplus: fix uninit-value in copy_name Eric Dumazet (2): net: ipv6: rpl_iptunnel: block BH in rpl_output() and rpl_input() ila: block BH in ila_output() Filipe Manana (1): btrfs: qgroup: fix quota root leak after quota disable failure Gabriel Krisman Bertazi (2): ext4: fix error code saved on super block during file system abort ext4: Send notifications on error Ganesh Goudar (1): powerpc/eeh: avoid possible crash when edev->pdev changes Greg Kroah-Hartman (1): Linux 5.10.223 Hans de Goede (1): Input: silead - Always support 10 fingers Heiko Carstens (1): s390/sclp: Fix sclp_init() cleanup on failure Jai Luthra (2): ALSA: dmaengine: Synchronize dma channel after drop() ASoC: ti: davinci-mcasp: Set min period size using FIFO config Jann Horn (2): filelock: Remove locks reliably when fcntl/close race is detected filelock: Fix fcntl/close race recovery compat path Jason Xing (1): bpf, skmsg: Fix NULL pointer dereference in sk_psock_skb_ingress_enqueue John Hubbard (1): selftests/vDSO: fix clang build errors and warnings Jonathan Denose (1): Input: elantech - fix touchpad state on resume for Lenovo N24 Kailang Yang (1): ALSA: hda/realtek: Add more codec ID to no shutup pins list Kees Cook (1): gcc-plugins: Rename last_stmt() for GCC 14+ Krishna Kurapati (1): arm64: dts: qcom: msm8996: Disable SS instance in Parkmode for USB Kuan-Wei Chiu (1): ACPI: processor_idle: Fix invalid comparison with insertion sort for latency Masahiro Yamada (3): kconfig: gconf: give a proper initial state to the Save button kconfig: remove wrong expr_trans_bool() ARM: 9324/1: fix get_user() broken with veneer Michael Ellerman (2): selftests/openat2: Fix build warnings on ppc64 KVM: PPC: Book3S HV: Prevent UAF in kvm_spapr_tce_attach_iommu_group() Nicolas Escande (1): wifi: mac80211: mesh: init nonpeer_pm to active by default in mesh sdata Paolo Abeni (1): net: relax socket state check at accept time. Primoz Fiser (1): ASoC: ti: omap-hdmi: Fix too long driver name Saurav Kashyap (1): scsi: qedf: Set qed_slowpath_params to zero before use Seunghun Han (1): ALSA: hda/realtek: Fix the speaker output on Samsung Galaxy Book Pro 360 Shengjiu Wang (2): ALSA: dmaengine_pcm: terminate dmaengine before synchronize ALSA: pcm_dmaengine: Don't synchronize DMA channel when DMA is paused Si-Wei Liu (1): tap: add missing verification for short frame Tetsuo Handa (1): Bluetooth: hci_core: cancel all works upon hci_unregister_dev() Thomas GENTY (1): bytcr_rt5640 : inverse jack detect for Archos 101 cesium Tobias Jakobi (1): Input: i8042 - add Ayaneo Kun to i8042 quirk table Uwe Kleine-König (1): spi: imx: Don't expect DMA for i.MX{25,35,50,51,53} cspi devices Wei Li (1): arm64: armv8_deprecated: Fix warning in isndep cpuhp starting process Xingui Yang (1): scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed Yunshui Jiang (1): net: mac802154: Fix racy device stats updates by DEV_STATS_INC() and DEV_STATS_ADD() Yuntao Wang (1): fs/file: fix the check in find_next_fd() lei lu (2): ocfs2: add bounds checking to ocfs2_check_dir_entry() jfs: don't walk off the end of ealist

1 year, 4 months

1
1
0 0

Linux 5.4.281

by Greg Kroah-Hartman

I'm announcing the release of the 5.4.281 kernel. All users of the 5.4 kernel series must upgrade. The updated 5.4.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.4.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Makefile | 2 arch/arm/include/asm/uaccess.h | 14 ---- arch/mips/kernel/syscalls/syscall_o32.tbl | 2 arch/powerpc/kernel/eeh_pe.c | 7 +- arch/powerpc/kvm/book3s_64_vio.c | 18 ++++-- arch/powerpc/platforms/pseries/setup.c | 4 - drivers/acpi/ec.c | 9 ++- drivers/acpi/processor_idle.c | 40 +++++-------- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 drivers/input/mouse/elantech.c | 31 ++++++++++ drivers/input/touchscreen/silead.c | 19 +----- drivers/misc/mei/main.c | 2 drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c | 2 drivers/net/tap.c | 5 + drivers/net/tun.c | 3 + drivers/net/usb/qmi_wwan.c | 2 drivers/s390/char/sclp.c | 1 drivers/scsi/libsas/sas_internal.h | 14 ++++ drivers/scsi/qedf/qedf_main.c | 1 drivers/spi/spi-imx.c | 2 fs/dcache.c | 31 ++++------ fs/file.c | 4 - fs/hfsplus/xattr.c | 2 fs/jfs/xattr.c | 23 ++++++-- fs/locks.c | 18 ++---- fs/ocfs2/dir.c | 46 ++++++++++------ net/bluetooth/hci_core.c | 4 + net/ipv4/af_inet.c | 4 + net/ipv6/ila/ila_lwt.c | 7 ++ net/mac80211/mesh.c | 1 net/mac80211/scan.c | 14 +++- net/mac802154/tx.c | 8 +- net/wireless/scan.c | 8 ++ scripts/gcc-plugins/gcc-common.h | 4 + scripts/kconfig/expr.c | 29 ---------- scripts/kconfig/expr.h | 1 scripts/kconfig/gconf.c | 3 - scripts/kconfig/menu.c | 2 sound/core/pcm_dmaengine.c | 12 ++++ sound/pci/hda/patch_realtek.c | 5 + sound/soc/intel/boards/bytcr_rt5640.c | 11 +++ sound/soc/ti/davinci-mcasp.c | 9 ++- sound/soc/ti/omap-hdmi.c | 6 -- tools/testing/selftests/vDSO/parse_vdso.c | 16 +++-- tools/testing/selftests/vDSO/vdso_standalone_test_x86.c | 18 +++++- 45 files changed, 289 insertions(+), 177 deletions(-) Alexander Usyskin (1): mei: demote client disconnect warning on suspend to debug Anjali K (1): powerpc/pseries: Whitelist dtl slub object for copying to userspace Armin Wolf (2): ACPI: EC: Abort address space access upon error ACPI: EC: Avoid returning AE_OK on errors in address space handler Arnd Bergmann (1): mips: fix compat_sys_lseek syscall Chen Ni (1): can: kvaser_usb: fix return value for hif_usb_send_regout Christian Brauner (1): fs: better handle deep ancestor chains in is_subdir() Dan Carpenter (1): drm/amdgpu: Fix signedness bug in sdma_v4_0_process_trap_irq() Daniele Palmas (1): net: usb: qmi_wwan: add Telit FN912 compositions Dmitry Antipov (2): wifi: mac80211: fix UBSAN noise in ieee80211_prep_hw_scan() wifi: cfg80211: wext: add extra SIOCSIWSCAN data check Dongli Zhang (1): tun: add missing verification for short frame Edson Juliano Drosdeck (1): ALSA: hda/realtek: Enable headset mic on Positivo SU C1400 Edward Adam Davis (1): hfsplus: fix uninit-value in copy_name Eric Dumazet (1): ila: block BH in ila_output() Ganesh Goudar (1): powerpc/eeh: avoid possible crash when edev->pdev changes Greg Kroah-Hartman (1): Linux 5.4.281 Hans de Goede (1): Input: silead - Always support 10 fingers Heiko Carstens (1): s390/sclp: Fix sclp_init() cleanup on failure Jai Luthra (1): ASoC: ti: davinci-mcasp: Set min period size using FIFO config Jann Horn (2): filelock: Remove locks reliably when fcntl/close race is detected filelock: Fix fcntl/close race recovery compat path John Hubbard (1): selftests/vDSO: fix clang build errors and warnings Jonathan Denose (1): Input: elantech - fix touchpad state on resume for Lenovo N24 Kailang Yang (1): ALSA: hda/realtek: Add more codec ID to no shutup pins list Kees Cook (1): gcc-plugins: Rename last_stmt() for GCC 14+ Kuan-Wei Chiu (1): ACPI: processor_idle: Fix invalid comparison with insertion sort for latency Masahiro Yamada (3): kconfig: gconf: give a proper initial state to the Save button kconfig: remove wrong expr_trans_bool() ARM: 9324/1: fix get_user() broken with veneer Michael Ellerman (1): KVM: PPC: Book3S HV: Prevent UAF in kvm_spapr_tce_attach_iommu_group() Nicolas Escande (1): wifi: mac80211: mesh: init nonpeer_pm to active by default in mesh sdata Paolo Abeni (1): net: relax socket state check at accept time. Primoz Fiser (1): ASoC: ti: omap-hdmi: Fix too long driver name Saurav Kashyap (1): scsi: qedf: Set qed_slowpath_params to zero before use Shengjiu Wang (1): ALSA: dmaengine_pcm: terminate dmaengine before synchronize Si-Wei Liu (1): tap: add missing verification for short frame Tetsuo Handa (1): Bluetooth: hci_core: cancel all works upon hci_unregister_dev() Thomas GENTY (1): bytcr_rt5640 : inverse jack detect for Archos 101 cesium Uwe Kleine-König (1): spi: imx: Don't expect DMA for i.MX{25,35,50,51,53} cspi devices Xingui Yang (1): scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed Yunshui Jiang (1): net: mac802154: Fix racy device stats updates by DEV_STATS_INC() and DEV_STATS_ADD() Yuntao Wang (1): fs/file: fix the check in find_next_fd() lei lu (2): ocfs2: add bounds checking to ocfs2_check_dir_entry() jfs: don't walk off the end of ealist

1 year, 4 months

1
1
0 0

Linux 4.19.319

by Greg Kroah-Hartman

I'm announcing the release of the 4.19.319 kernel. All users of the 4.19 kernel series must upgrade. The updated 4.19.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.19.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Makefile | 2 arch/arm/include/asm/uaccess.h | 14 ---- drivers/acpi/ec.c | 9 ++- drivers/acpi/processor_idle.c | 40 +++++-------- drivers/input/mouse/elantech.c | 31 ++++++++++ drivers/input/touchscreen/silead.c | 19 +----- drivers/misc/mei/main.c | 2 drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c | 2 drivers/net/usb/qmi_wwan.c | 2 drivers/s390/char/sclp.c | 1 drivers/scsi/qedf/qedf_main.c | 1 drivers/spi/spi-imx.c | 2 fs/dcache.c | 31 ++++------ fs/file.c | 4 - fs/hfsplus/xattr.c | 2 fs/jfs/xattr.c | 23 ++++++-- fs/locks.c | 18 ++---- fs/ocfs2/dir.c | 46 ++++++++++------ net/bluetooth/hci_core.c | 4 + net/ipv4/af_inet.c | 4 + net/ipv6/ila/ila_lwt.c | 7 ++ net/mac80211/mesh.c | 1 net/mac80211/scan.c | 14 +++- net/mac802154/tx.c | 8 +- net/wireless/scan.c | 8 ++ scripts/gcc-plugins/gcc-common.h | 4 + scripts/kconfig/expr.c | 29 ---------- scripts/kconfig/expr.h | 1 scripts/kconfig/gconf.c | 3 - scripts/kconfig/menu.c | 2 sound/core/pcm_dmaengine.c | 12 ++++ sound/soc/intel/boards/bytcr_rt5640.c | 11 +++ tools/testing/selftests/vDSO/parse_vdso.c | 16 +++-- tools/testing/selftests/vDSO/vdso_standalone_test_x86.c | 18 +++++- 34 files changed, 232 insertions(+), 159 deletions(-) Alexander Usyskin (1): mei: demote client disconnect warning on suspend to debug Armin Wolf (2): ACPI: EC: Abort address space access upon error ACPI: EC: Avoid returning AE_OK on errors in address space handler Chen Ni (1): can: kvaser_usb: fix return value for hif_usb_send_regout Christian Brauner (1): fs: better handle deep ancestor chains in is_subdir() Daniele Palmas (1): net: usb: qmi_wwan: add Telit FN912 compositions Dmitry Antipov (2): wifi: mac80211: fix UBSAN noise in ieee80211_prep_hw_scan() wifi: cfg80211: wext: add extra SIOCSIWSCAN data check Edward Adam Davis (1): hfsplus: fix uninit-value in copy_name Eric Dumazet (1): ila: block BH in ila_output() Greg Kroah-Hartman (1): Linux 4.19.319 Hans de Goede (1): Input: silead - Always support 10 fingers Heiko Carstens (1): s390/sclp: Fix sclp_init() cleanup on failure Jann Horn (2): filelock: Remove locks reliably when fcntl/close race is detected filelock: Fix fcntl/close race recovery compat path John Hubbard (1): selftests/vDSO: fix clang build errors and warnings Jonathan Denose (1): Input: elantech - fix touchpad state on resume for Lenovo N24 Kees Cook (1): gcc-plugins: Rename last_stmt() for GCC 14+ Kuan-Wei Chiu (1): ACPI: processor_idle: Fix invalid comparison with insertion sort for latency Masahiro Yamada (3): kconfig: gconf: give a proper initial state to the Save button kconfig: remove wrong expr_trans_bool() ARM: 9324/1: fix get_user() broken with veneer Nicolas Escande (1): wifi: mac80211: mesh: init nonpeer_pm to active by default in mesh sdata Paolo Abeni (1): net: relax socket state check at accept time. Saurav Kashyap (1): scsi: qedf: Set qed_slowpath_params to zero before use Shengjiu Wang (1): ALSA: dmaengine_pcm: terminate dmaengine before synchronize Tetsuo Handa (1): Bluetooth: hci_core: cancel all works upon hci_unregister_dev() Thomas GENTY (1): bytcr_rt5640 : inverse jack detect for Archos 101 cesium Uwe Kleine-König (1): spi: imx: Don't expect DMA for i.MX{25,35,50,51,53} cspi devices Yunshui Jiang (1): net: mac802154: Fix racy device stats updates by DEV_STATS_INC() and DEV_STATS_ADD() Yuntao Wang (1): fs/file: fix the check in find_next_fd() lei lu (2): ocfs2: add bounds checking to ocfs2_check_dir_entry() jfs: don't walk off the end of ealist

1 year, 4 months

1
1
0 0

[PATCH] arm64: v6.8: cmdline param >= 146 chars kills kernel

by Tj

This is v6.8 specific; v6.9 is reported as not affected (due to extensive code refactoring). Commit dc3f5aae0638 reworked how early cmdline CPU feature parsing is done, and converted to using memcmp() in preparation for the move to the pi minimal C standard library. As a result it caused a regression where-by a parameter >= 146 characters on the kernel command line would cause a silent panic with no console clues as to why. It is due to memcmp() in include/linux/fortify-string.h detecting an attempted out-of-bounds read. The cause itself is subtle. arch/arm64/kernel/idreg-override.c::__parse_cmdline() compares the struct aliases entries with each parameter via memcmp(). #define FTR_ALIAS_NAME_LEN 30 #define FTR_ALIAS_OPTION_LEN 116 ... static const struct { char alias[FTR_ALIAS_NAME_LEN]; char feature[FTR_ALIAS_OPTION_LEN]; } aliases[] Each element is 146 characters. When a parameter is also 146 characters the call looks like memcmp(buf, aliases[i].alias, len+1) where len is the equivalent of strlen(buf) and +1 to compare including the trailing NUL. That triggers the fortified memcmp()'s: if (p_size < size || q_size < size) fortify_panic(__func__); where q_size == 146, size == 147 The solution here is to not call memcmp() at all unless the two strings have the same length. Initially reported in Ubuntu (and confirmed to affect Debian and Mainline): https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2069534 Signed-off-by: Tj <tj.iam.tj(a)proton.me> --- arch/arm64/kernel/idreg-override.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm64/kernel/idreg-override.c b/arch/arm64/kernel/idreg-override.c index e30fd9e32ef3a..9d2c120f378ae 100644 --- a/arch/arm64/kernel/idreg-override.c +++ b/arch/arm64/kernel/idreg-override.c @@ -308,7 +308,8 @@ static __init void __parse_cmdline(const char *cmdline, bool parse_aliases) match_options(buf); for (i = 0; parse_aliases && i < ARRAY_SIZE(aliases); i++) - if (!memcmp(buf, aliases[i].alias, len + 1)) + if (len == strlen(aliases[i].alias) && + !memcmp(buf, aliases[i].alias, len + 1)) __parse_cmdline(aliases[i].feature, false); } while (1); } -- 2.39.2

1 year, 4 months

2
1
0 0

[PATCH 5.15 00/87] 5.15.164-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.15.164 release. There are 87 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat, 27 Jul 2024 14:27:16 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.164-r… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 5.15.164-rc1 Jann Horn <jannh(a)google.com> filelock: Fix fcntl/close race recovery compat path Shengjiu Wang <shengjiu.wang(a)nxp.com> ALSA: pcm_dmaengine: Don't synchronize DMA channel when DMA is paused Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: sdm630: Disable SS instance in Parkmode for USB Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: msm8996: Disable SS instance in Parkmode for USB Seunghun Han <kkamagui(a)gmail.com> ALSA: hda/realtek: Fix the speaker output on Samsung Galaxy Book Pro 360 Edson Juliano Drosdeck <edson.drosdeck(a)gmail.com> ALSA: hda/realtek: Enable headset mic on Positivo SU C1400 lei lu <llfamsec(a)gmail.com> fs/ntfs3: Validate ff offset lei lu <llfamsec(a)gmail.com> jfs: don't walk off the end of ealist lei lu <llfamsec(a)gmail.com> ocfs2: add bounds checking to ocfs2_check_dir_entry() Paolo Abeni <pabeni(a)redhat.com> net: relax socket state check at accept time. Linus Torvalds <torvalds(a)linux-foundation.org> Add gitignore file for samples/fanotify/ subdirectory Gabriel Krisman Bertazi <krisman(a)collabora.com> docs: Fix formatting of literal sections in fanotify docs Gabriel Krisman Bertazi <krisman(a)collabora.com> samples: Make fs-monitor depend on libc and headers Gabriel Krisman Bertazi <krisman(a)collabora.com> samples: Add fs error monitoring example Dan Carpenter <dan.carpenter(a)linaro.org> drm/amdgpu: Fix signedness bug in sdma_v4_0_process_trap_irq() Johannes Berg <johannes.berg(a)intel.com> wifi: mac80211: disable softirqs for queued frame handling SeongJae Park <sj(a)kernel.org> mm/damon/core: merge regions aggressively when max_nr_regions is unmet David Laight <David.Laight(a)ACULAB.COM> minmax: relax check to allow comparison between unsigned arguments and signed constants David Laight <David.Laight(a)ACULAB.COM> minmax: allow comparisons of 'int' against 'unsigned char/short' David Laight <David.Laight(a)ACULAB.COM> minmax: allow min()/max()/clamp() if the arguments have the same signedness. Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> minmax: fix header inclusions Jason A. Donenfeld <Jason(a)zx2c4.com> minmax: clamp more efficiently by avoiding extra comparison Jason A. Donenfeld <Jason(a)zx2c4.com> minmax: sanity check constant bounds when clamping Bart Van Assche <bvanassche(a)acm.org> tracing: Define the is_signed_type() macro once David Lechner <dlechner(a)baylibre.com> spi: mux: set ctlr->bits_per_word_mask Edward Adam Davis <eadavis(a)qq.com> hfsplus: fix uninit-value in copy_name John Hubbard <jhubbard(a)nvidia.com> selftests/vDSO: fix clang build errors and warnings Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> spi: imx: Don't expect DMA for i.MX{25,35,50,51,53} cspi devices Puranjay Mohan <puranjay(a)kernel.org> riscv: stacktrace: fix usage of ftrace_graph_ret_addr() Christian Brauner <brauner(a)kernel.org> fs: better handle deep ancestor chains in is_subdir() Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer(a)amd.com> drm/radeon: check bo_va->bo is non-NULL before using it Tetsuo Handa <penguin-kernel(a)I-love.SAKURA.ne.jp> Bluetooth: hci_core: cancel all works upon hci_unregister_dev() Xingui Yang <yangxingui(a)huawei.com> scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed Ganesh Goudar <ganeshgr(a)linux.ibm.com> powerpc/eeh: avoid possible crash when edev->pdev changes Anjali K <anjalik(a)linux.ibm.com> powerpc/pseries: Whitelist dtl slub object for copying to userspace Yunshui Jiang <jiangyunshui(a)kylinos.cn> net: mac802154: Fix racy device stats updates by DEV_STATS_INC() and DEV_STATS_ADD() Daniele Palmas <dnlplm(a)gmail.com> net: usb: qmi_wwan: add Telit FN912 compositions Shengjiu Wang <shengjiu.wang(a)nxp.com> ALSA: dmaengine_pcm: terminate dmaengine before synchronize Aivaz Latypov <reichaivaz(a)gmail.com> ALSA: hda/relatek: Enable Mute LED on HP Laptop 15-gw0xxx Filipe Manana <fdmanana(a)suse.com> btrfs: qgroup: fix quota root leak after quota disable failure Armin Wolf <W_Armin(a)gmx.de> platform/x86: lg-laptop: Use ACPI device handle when evaluating WMAB/WMBB Armin Wolf <W_Armin(a)gmx.de> platform/x86: lg-laptop: Change ACPI device id Armin Wolf <W_Armin(a)gmx.de> platform/x86: lg-laptop: Remove LGEX0815 hotkey handling Armin Wolf <W_Armin(a)gmx.de> platform/x86: wireless-hotkey: Add support for LG Airplane Button Heiko Carstens <hca(a)linux.ibm.com> s390/sclp: Fix sclp_init() cleanup on failure Chen Ni <nichen(a)iscas.ac.cn> can: kvaser_usb: fix return value for hif_usb_send_regout Primoz Fiser <primoz.fiser(a)norik.com> ASoC: ti: omap-hdmi: Fix too long driver name Jai Luthra <j-luthra(a)ti.com> ASoC: ti: davinci-mcasp: Set min period size using FIFO config Jai Luthra <j-luthra(a)ti.com> ALSA: dmaengine: Synchronize dma channel after drop() Thomas GENTY <tomlohave(a)gmail.com> bytcr_rt5640 : inverse jack detect for Archos 101 cesium Tobias Jakobi <tjakobi(a)math.uni-bielefeld.de> Input: i8042 - add Ayaneo Kun to i8042 quirk table Jonathan Denose <jdenose(a)google.com> Input: elantech - fix touchpad state on resume for Lenovo N24 Arnd Bergmann <arnd(a)arndb.de> mips: fix compat_sys_lseek syscall Kailang Yang <kailang(a)realtek.com> ALSA: hda/realtek: Add more codec ID to no shutup pins list Alexey Makhalov <alexey.makhalov(a)broadcom.com> drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency Michael Ellerman <mpe(a)ellerman.id.au> KVM: PPC: Book3S HV: Prevent UAF in kvm_spapr_tce_attach_iommu_group() Dmitry Antipov <dmantipov(a)yandex.ru> wifi: cfg80211: wext: add extra SIOCSIWSCAN data check Chunguang Xu <chunguang.xu(a)shopee.com> nvme: avoid double free special payload Alexander Usyskin <alexander.usyskin(a)intel.com> mei: demote client disconnect warning on suspend to debug Yuntao Wang <yuntao.wang(a)linux.dev> fs/file: fix the check in find_next_fd() Masahiro Yamada <masahiroy(a)kernel.org> kconfig: remove wrong expr_trans_bool() Masahiro Yamada <masahiroy(a)kernel.org> kconfig: gconf: give a proper initial state to the Save button Andreas Hindborg <a.hindborg(a)samsung.com> null_blk: fix validation of block size Wei Li <liwei391(a)huawei.com> arm64: armv8_deprecated: Fix warning in isndep cpuhp starting process Eric Dumazet <edumazet(a)google.com> ila: block BH in ila_output() Eric Dumazet <edumazet(a)google.com> net: ipv6: rpl_iptunnel: block BH in rpl_output() and rpl_input() Hans de Goede <hdegoede(a)redhat.com> Input: silead - Always support 10 fingers Michael Ellerman <mpe(a)ellerman.id.au> selftests/openat2: Fix build warnings on ppc64 Dmitry Antipov <dmantipov(a)yandex.ru> wifi: mac80211: fix UBSAN noise in ieee80211_prep_hw_scan() Ayala Beker <ayala.beker(a)intel.com> wifi: iwlwifi: mvm: properly set 6 GHz channel direct probe option Yedidya Benshimol <yedidya.ben.shimol(a)intel.com> wifi: iwlwifi: mvm: Handle BIGTK cipher in kek_kck cmd Yedidya Benshimol <yedidya.ben.shimol(a)intel.com> wifi: iwlwifi: mvm: d3: fix WoWLAN command version lookup Johannes Berg <johannes.berg(a)intel.com> wifi: mac80211: handle tasklet frames before stopping Nicolas Escande <nico.escande(a)gmail.com> wifi: mac80211: mesh: init nonpeer_pm to active by default in mesh sdata Dhananjay Ugwekar <Dhananjay.Ugwekar(a)amd.com> tools/power/cpupower: Fix Pstate frequency reporting on AMD Family 1Ah CPUs Armin Wolf <W_Armin(a)gmx.de> ACPI: EC: Avoid returning AE_OK on errors in address space handler Armin Wolf <W_Armin(a)gmx.de> ACPI: EC: Abort address space access upon error Saurav Kashyap <skashyap(a)marvell.com> scsi: qedf: Set qed_slowpath_params to zero before use Saurav Kashyap <skashyap(a)marvell.com> scsi: qedf: Wait for stag work during unload Saurav Kashyap <skashyap(a)marvell.com> scsi: qedf: Don't process stag work during unload and recovery Martin Wilck <martin.wilck(a)suse.com> scsi: core: alua: I/O errors for ALUA state transitions Bart Van Assche <bvanassche(a)acm.org> scsi: core: Fix a use-after-free Daniel Borkmann <daniel(a)iogearbox.net> bpf: Fix overrunning reservations in ringbuf Kuan-Wei Chiu <visitorckw(a)gmail.com> ACPI: processor_idle: Fix invalid comparison with insertion sort for latency Masahiro Yamada <masahiroy(a)kernel.org> ARM: 9324/1: fix get_user() broken with veneer Jann Horn <jannh(a)google.com> filelock: Remove locks reliably when fcntl/close race is detected Kees Cook <keescook(a)chromium.org> gcc-plugins: Rename last_stmt() for GCC 14+ ------------- Diffstat: .../admin-guide/filesystem-monitoring.rst | 20 +-- Makefile | 4 +- arch/arm/include/asm/uaccess.h | 14 +- arch/arm64/boot/dts/qcom/msm8996.dtsi | 1 + arch/arm64/boot/dts/qcom/sdm630.dtsi | 1 + arch/arm64/kernel/armv8_deprecated.c | 3 + arch/mips/kernel/syscalls/syscall_o32.tbl | 2 +- arch/powerpc/kernel/eeh_pe.c | 7 +- arch/powerpc/kvm/book3s_64_vio.c | 18 ++- arch/powerpc/platforms/pseries/setup.c | 4 +- arch/riscv/kernel/stacktrace.c | 3 +- drivers/acpi/ec.c | 9 +- drivers/acpi/processor_idle.c | 40 +++--- drivers/block/null_blk/main.c | 4 +- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 +- drivers/gpu/drm/radeon/radeon_gem.c | 2 +- drivers/gpu/drm/vmwgfx/Kconfig | 2 +- drivers/input/mouse/elantech.c | 31 +++++ drivers/input/serio/i8042-acpipnpio.h | 18 ++- drivers/input/touchscreen/silead.c | 19 +-- drivers/misc/mei/main.c | 2 +- drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c | 2 +- drivers/net/usb/qmi_wwan.c | 2 + drivers/net/wireless/intel/iwlwifi/mvm/d3.c | 16 ++- drivers/net/wireless/intel/iwlwifi/mvm/scan.c | 5 +- drivers/nvme/host/core.c | 1 + drivers/platform/x86/lg-laptop.c | 89 +++++-------- drivers/platform/x86/wireless-hotkey.c | 2 + drivers/s390/char/sclp.c | 1 + drivers/scsi/device_handler/scsi_dh_alua.c | 31 +++-- drivers/scsi/hosts.c | 16 ++- drivers/scsi/libsas/sas_internal.h | 14 ++ drivers/scsi/qedf/qedf.h | 1 + drivers/scsi/qedf/qedf_main.c | 47 ++++++- drivers/scsi/scsi_lib.c | 6 +- drivers/scsi/scsi_priv.h | 2 +- drivers/scsi/scsi_scan.c | 1 + drivers/scsi/scsi_sysfs.c | 1 + drivers/spi/spi-imx.c | 2 +- drivers/spi/spi-mux.c | 1 + fs/btrfs/qgroup.c | 4 +- fs/dcache.c | 31 ++--- fs/file.c | 4 +- fs/hfsplus/xattr.c | 2 +- fs/jfs/xattr.c | 23 +++- fs/locks.c | 18 ++- fs/ntfs3/fslog.c | 6 +- fs/ocfs2/dir.c | 46 ++++--- include/linux/compiler.h | 6 + include/linux/minmax.h | 87 +++++++++---- include/linux/overflow.h | 1 - include/linux/trace_events.h | 2 - include/scsi/scsi_host.h | 2 + include/sound/dmaengine_pcm.h | 1 + kernel/bpf/ringbuf.c | 30 ++++- mm/damon/core.c | 21 ++- net/bluetooth/hci_core.c | 4 + net/ipv4/af_inet.c | 4 +- net/ipv6/ila/ila_lwt.c | 7 +- net/ipv6/rpl_iptunnel.c | 14 +- net/mac80211/ieee80211_i.h | 2 + net/mac80211/main.c | 11 +- net/mac80211/mesh.c | 1 + net/mac80211/scan.c | 14 +- net/mac80211/util.c | 4 + net/mac802154/tx.c | 8 +- net/wireless/scan.c | 8 +- samples/Kconfig | 9 ++ samples/Makefile | 1 + samples/fanotify/.gitignore | 1 + samples/fanotify/Makefile | 5 + samples/fanotify/fs-monitor.c | 142 +++++++++++++++++++++ scripts/gcc-plugins/gcc-common.h | 4 + scripts/kconfig/expr.c | 29 ----- scripts/kconfig/expr.h | 1 - scripts/kconfig/gconf.c | 3 +- scripts/kconfig/menu.c | 2 - sound/core/pcm_dmaengine.c | 26 ++++ sound/pci/hda/patch_realtek.c | 7 + sound/soc/intel/boards/bytcr_rt5640.c | 11 ++ sound/soc/soc-generic-dmaengine-pcm.c | 8 ++ sound/soc/ti/davinci-mcasp.c | 9 +- sound/soc/ti/omap-hdmi.c | 6 +- tools/power/cpupower/utils/helpers/amd.c | 26 +++- tools/testing/selftests/openat2/openat2_test.c | 1 + tools/testing/selftests/vDSO/parse_vdso.c | 16 ++- .../selftests/vDSO/vdso_standalone_test_x86.c | 18 ++- 87 files changed, 813 insertions(+), 319 deletions(-)

1 year, 4 months

7
97
0 0

[PATCH] ALSA: firewire-lib: fix wrong value as length of header for CIP_NO_HEADER case

by Takashi Sakamoto

In a commit 1d717123bb1a ("ALSA: firewire-lib: Avoid -Wflex-array-member-not-at-end warning"), DEFINE_FLEX() macro was used to handle variable length of array for header field in struct fw_iso_packet structure. The usage of macro has a side effect that the designated initializer assigns the count of array to the given field. Therefore CIP_HEADER_QUADLETS (=2) is assigned to struct fw_iso_packet.header, while the original designated initializer assigns zero to all fields. With CIP_NO_HEADER flag, the change causes invalid length of header in isochronous packet for 1394 OHCI IT context. This bug affects all of devices supported by ALSA fireface driver; RME Fireface 400, 800, UCX, UFX, and 802. This commit fixes the bug by replacing it with the alternative version of macro which corresponds no initializer. Cc: <stable(a)vger.kernel.org> Fixes: 1d717123bb1a ("ALSA: firewire-lib: Avoid -Wflex-array-member-not-at-end warning") Reported-by: Edmund Raile <edmund.raile(a)proton.me> Closes: https://lore.kernel.org/r/rrufondjeynlkx2lniot26ablsltnynfaq2gnqvbiso7ds32i… Signed-off-by: Takashi Sakamoto <o-takashi(a)sakamocchi.jp> --- sound/firewire/amdtp-stream.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/firewire/amdtp-stream.c b/sound/firewire/amdtp-stream.c index d35d0a420ee0..1a163bbcabd7 100644 --- a/sound/firewire/amdtp-stream.c +++ b/sound/firewire/amdtp-stream.c @@ -1180,8 +1180,7 @@ static void process_rx_packets(struct fw_iso_context *context, u32 tstamp, size_ (void)fw_card_read_cycle_time(fw_parent_device(s->unit)->card, &curr_cycle_time); for (i = 0; i < packets; ++i) { - DEFINE_FLEX(struct fw_iso_packet, template, header, - header_length, CIP_HEADER_QUADLETS); + DEFINE_RAW_FLEX(struct fw_iso_packet, template, header, CIP_HEADER_QUADLETS); bool sched_irq = false; build_it_pkt_header(s, desc->cycle, template, pkt_header_length, -- 2.43.0

1 year, 4 months

3
8
0 0

[PATCH 6.10 00/29] 6.10.2-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.10.2 release. There are 29 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat, 27 Jul 2024 14:27:16 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.10.2-rc1… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.10.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 6.10.2-rc1 Jann Horn <jannh(a)google.com> filelock: Fix fcntl/close race recovery compat path Takashi Iwai <tiwai(a)suse.de> ALSA: seq: ump: Skip useless ports for static blocks Shengjiu Wang <shengjiu.wang(a)nxp.com> ALSA: pcm_dmaengine: Don't synchronize DMA channel when DMA is paused Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: sm6115: Disable SS instance in Parkmode for USB Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: sdm845: Disable SS instance in Parkmode for USB Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: ipq8074: Disable SS instance in Parkmode for USB Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: sdm630: Disable SS instance in Parkmode for USB Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: ipq6018: Disable SS instance in Parkmode for USB Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: msm8998: Disable SS instance in Parkmode for USB Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: sm6350: Disable SS instance in Parkmode for USB Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: msm8996: Disable SS instance in Parkmode for USB Abel Vesa <abel.vesa(a)linaro.org> arm64: dts: qcom: x1e80100-crd: Fix USB PHYs regulators Abel Vesa <abel.vesa(a)linaro.org> arm64: dts: qcom: x1e80100-qcp: Fix the PHY regulator for PCIe 6a Abel Vesa <abel.vesa(a)linaro.org> arm64: dts: qcom: x1e80100-crd: Fix the PHY regulator for PCIe 6a Dmitry Baryshkov <dmitry.baryshkov(a)linaro.org> arm64: dts: qcom: qrb4210-rb2: switch I2C2 to i2c-gpio Dmitry Baryshkov <dmitry.baryshkov(a)linaro.org> arm64: dts: qcom: qrb2210-rb1: switch I2C2 to i2c-gpio Abel Vesa <abel.vesa(a)linaro.org> arm64: dts: qcom: x1e80100-qcp: Fix USB PHYs regulators Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: sc7280: Disable SuperSpeed instances in park mode Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: sc7180: Disable SuperSpeed instances in park mode Seunghun Han <kkamagui(a)gmail.com> ALSA: hda/realtek: Fix the speaker output on Samsung Galaxy Book Pro 360 Edson Juliano Drosdeck <edson.drosdeck(a)gmail.com> ALSA: hda/realtek: Enable headset mic on Positivo SU C1400 Shenghao Ding <shenghao-ding(a)ti.com> ALSA: hda/tas2781: Add new quirk for Lenovo Hera2 Laptop Takashi Iwai <tiwai(a)suse.de> usb: gadget: midi2: Fix incorrect default MIDI2 protocol setup lei lu <llfamsec(a)gmail.com> fs/ntfs3: Validate ff offset Konstantin Komarov <almaz.alexandrovich(a)paragon-software.com> fs/ntfs3: Add a check for attr_names and oatbl lei lu <llfamsec(a)gmail.com> jfs: don't walk off the end of ealist lei lu <llfamsec(a)gmail.com> ocfs2: add bounds checking to ocfs2_check_dir_entry() Gerald Schaefer <gerald.schaefer(a)linux.ibm.com> s390/mm: Fix VM_FAULT_HWPOISON handling in do_exception() Dan Carpenter <dan.carpenter(a)linaro.org> drm/amdgpu: Fix signedness bug in sdma_v4_0_process_trap_irq() ------------- Diffstat: Makefile | 4 +-- arch/arm64/boot/dts/qcom/ipq6018.dtsi | 1 + arch/arm64/boot/dts/qcom/ipq8074.dtsi | 2 ++ arch/arm64/boot/dts/qcom/msm8996.dtsi | 1 + arch/arm64/boot/dts/qcom/msm8998.dtsi | 1 + arch/arm64/boot/dts/qcom/qrb2210-rb1.dts | 13 ++++++++- arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 13 ++++++++- arch/arm64/boot/dts/qcom/sc7180.dtsi | 1 + arch/arm64/boot/dts/qcom/sc7280.dtsi | 1 + arch/arm64/boot/dts/qcom/sdm630.dtsi | 1 + arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 ++ arch/arm64/boot/dts/qcom/sm6115.dtsi | 1 + arch/arm64/boot/dts/qcom/sm6350.dtsi | 1 + arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 17 +++++++++--- arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 17 +++++++++--- arch/s390/mm/fault.c | 3 +- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 +- drivers/usb/gadget/function/f_midi2.c | 19 +++++++------ fs/jfs/xattr.c | 23 +++++++++++++--- fs/locks.c | 9 +++--- fs/ntfs3/fslog.c | 44 ++++++++++++++++++++++++----- fs/ocfs2/dir.c | 46 +++++++++++++++++++------------ sound/core/pcm_dmaengine.c | 6 +++- sound/core/seq/seq_ump_client.c | 16 +++++++++++ sound/pci/hda/patch_realtek.c | 3 ++ 25 files changed, 191 insertions(+), 56 deletions(-)

1 year, 4 months

13
41
0 0

[PATCH] power: supply: qcom_battmgr: return EAGAIN when firmware service is not up

by Neil Armstrong

The driver returns -ENODEV when the firmware battmrg service hasn't started yet, while per-se -ENODEV is fine, we usually use -EAGAIN to tell the user to retry again later. And the power supply core uses -EGAIN when the device isn't initialized, let's use the same return. This notably causes an infinite spam of: thermal thermal_zoneXX: failed to read out thermal zone (-19) because the thermal core doesn't understand -ENODEV, but only considers -EAGAIN as a non-fatal error. While it didn't appear until now, commit [1] fixes thermal core and no more ignores thermal zones returning an error at first temperature update. [1] 5725f40698b9 ("thermal: core: Call monitor_thermal_zone() if zone temperature is invalid") Link: https://lore.kernel.org/all/2ed4c630-204a-4f80-a37f-f2ca838eb455@linaro.org/ Cc: stable(a)vger.kernel.org Fixes: 29e8142b5623 ("power: supply: Introduce Qualcomm PMIC GLINK power supply") Signed-off-by: Neil Armstrong <neil.armstrong(a)linaro.org> --- drivers/power/supply/qcom_battmgr.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/power/supply/qcom_battmgr.c b/drivers/power/supply/qcom_battmgr.c index 46f36dcb185c..bde874b5e0e7 100644 --- a/drivers/power/supply/qcom_battmgr.c +++ b/drivers/power/supply/qcom_battmgr.c @@ -486,7 +486,7 @@ static int qcom_battmgr_bat_get_property(struct power_supply *psy, int ret; if (!battmgr->service_up) - return -ENODEV; + return -EAGAIN; if (battmgr->variant == QCOM_BATTMGR_SC8280XP) ret = qcom_battmgr_bat_sc8280xp_update(battmgr, psp); @@ -683,7 +683,7 @@ static int qcom_battmgr_ac_get_property(struct power_supply *psy, int ret; if (!battmgr->service_up) - return -ENODEV; + return -EAGAIN; ret = qcom_battmgr_bat_sc8280xp_update(battmgr, psp); if (ret) @@ -748,7 +748,7 @@ static int qcom_battmgr_usb_get_property(struct power_supply *psy, int ret; if (!battmgr->service_up) - return -ENODEV; + return -EAGAIN; if (battmgr->variant == QCOM_BATTMGR_SC8280XP) ret = qcom_battmgr_bat_sc8280xp_update(battmgr, psp); @@ -867,7 +867,7 @@ static int qcom_battmgr_wls_get_property(struct power_supply *psy, int ret; if (!battmgr->service_up) - return -ENODEV; + return -EAGAIN; if (battmgr->variant == QCOM_BATTMGR_SC8280XP) ret = qcom_battmgr_bat_sc8280xp_update(battmgr, psp); --- base-commit: 91e3b24eb7d297d9d99030800ed96944b8652eaf change-id: 20240715-topic-sm8x50-upstream-fix-battmgr-temp-tz-warn-c5a2f956d28d Best regards, -- Neil Armstrong <neil.armstrong(a)linaro.org>

1 year, 4 months

3
2
0 0

[PATCH 1/2] power: supply: axp288_charger: Fix constant_charge_voltage writes

by Hans de Goede

info->max_cv is in millivolts, divide the microvolt value being written to constant_charge_voltage by 1000 *before* clamping it to info->max_cv. Before this fix the code always tried to set constant_charge_voltage to max_cv / 1000 = 4 millivolt, which ends up in setting it to 4.1V which is the lowest supported value. Fixes: 843735b788a4 ("power: axp288_charger: axp288 charger driver") Cc: stable(a)vger.kernel.org Signed-off-by: Hans de Goede <hdegoede(a)redhat.com> --- drivers/power/supply/axp288_charger.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/power/supply/axp288_charger.c b/drivers/power/supply/axp288_charger.c index b5903193e2f9..aea17289a178 100644 --- a/drivers/power/supply/axp288_charger.c +++ b/drivers/power/supply/axp288_charger.c @@ -337,8 +337,8 @@ static int axp288_charger_usb_set_property(struct power_supply *psy, } break; case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE: - scaled_val = min(val->intval, info->max_cv); - scaled_val = DIV_ROUND_CLOSEST(scaled_val, 1000); + scaled_val = DIV_ROUND_CLOSEST(val->intval, 1000); + scaled_val = min(scaled_val, info->max_cv); ret = axp288_charger_set_cv(info, scaled_val); if (ret < 0) { dev_warn(&info->pdev->dev, "set charge voltage failed\n"); -- 2.45.2

1 year, 4 months

2
2
0 0

[merged mm-hotfixes-stable] nilfs2-handle-inconsistent-state-in-nilfs_btnode_create_block.patch removed from -mm tree

by Andrew Morton

The quilt patch titled Subject: nilfs2: handle inconsistent state in nilfs_btnode_create_block() has been removed from the -mm tree. Its filename was nilfs2-handle-inconsistent-state-in-nilfs_btnode_create_block.patch This patch was dropped because it was merged into the mm-hotfixes-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm ------------------------------------------------------ From: Ryusuke Konishi <konishi.ryusuke(a)gmail.com> Subject: nilfs2: handle inconsistent state in nilfs_btnode_create_block() Date: Thu, 25 Jul 2024 14:20:07 +0900 Syzbot reported that a buffer state inconsistency was detected in nilfs_btnode_create_block(), triggering a kernel bug. It is not appropriate to treat this inconsistency as a bug; it can occur if the argument block address (the buffer index of the newly created block) is a virtual block number and has been reallocated due to corruption of the bitmap used to manage its allocation state. So, modify nilfs_btnode_create_block() and its callers to treat it as a possible filesystem error, rather than triggering a kernel bug. Link: https://lkml.kernel.org/r/20240725052007.4562-1-konishi.ryusuke@gmail.com Fixes: a60be987d45d ("nilfs2: B-tree node cache") Signed-off-by: Ryusuke Konishi <konishi.ryusuke(a)gmail.com> Reported-by: syzbot+89cc4f2324ed37988b60(a)syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=89cc4f2324ed37988b60 Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- fs/nilfs2/btnode.c | 25 ++++++++++++++++++++----- fs/nilfs2/btree.c | 4 ++-- 2 files changed, 22 insertions(+), 7 deletions(-) --- a/fs/nilfs2/btnode.c~nilfs2-handle-inconsistent-state-in-nilfs_btnode_create_block +++ a/fs/nilfs2/btnode.c @@ -51,12 +51,21 @@ nilfs_btnode_create_block(struct address bh = nilfs_grab_buffer(inode, btnc, blocknr, BIT(BH_NILFS_Node)); if (unlikely(!bh)) - return NULL; + return ERR_PTR(-ENOMEM); if (unlikely(buffer_mapped(bh) || buffer_uptodate(bh) || buffer_dirty(bh))) { - brelse(bh); - BUG(); + /* + * The block buffer at the specified new address was already + * in use. This can happen if it is a virtual block number + * and has been reallocated due to corruption of the bitmap + * used to manage its allocation state (if not, the buffer + * clearing of an abandoned b-tree node is missing somewhere). + */ + nilfs_error(inode->i_sb, + "state inconsistency probably due to duplicate use of b-tree node block address %llu (ino=%lu)", + (unsigned long long)blocknr, inode->i_ino); + goto failed; } memset(bh->b_data, 0, i_blocksize(inode)); bh->b_bdev = inode->i_sb->s_bdev; @@ -67,6 +76,12 @@ nilfs_btnode_create_block(struct address folio_unlock(bh->b_folio); folio_put(bh->b_folio); return bh; + +failed: + folio_unlock(bh->b_folio); + folio_put(bh->b_folio); + brelse(bh); + return ERR_PTR(-EIO); } int nilfs_btnode_submit_block(struct address_space *btnc, __u64 blocknr, @@ -217,8 +232,8 @@ retry: } nbh = nilfs_btnode_create_block(btnc, newkey); - if (!nbh) - return -ENOMEM; + if (IS_ERR(nbh)) + return PTR_ERR(nbh); BUG_ON(nbh == obh); ctxt->newbh = nbh; --- a/fs/nilfs2/btree.c~nilfs2-handle-inconsistent-state-in-nilfs_btnode_create_block +++ a/fs/nilfs2/btree.c @@ -63,8 +63,8 @@ static int nilfs_btree_get_new_block(con struct buffer_head *bh; bh = nilfs_btnode_create_block(btnc, ptr); - if (!bh) - return -ENOMEM; + if (IS_ERR(bh)) + return PTR_ERR(bh); set_buffer_nilfs_volatile(bh); *bhp = bh; _ Patches currently in -mm which might be from konishi.ryusuke(a)gmail.com are

1 year, 4 months

1
0
0 0

[merged mm-hotfixes-stable] mm-page_alloc-fix-pcp-count-race-between-drain_pages_zone-vs-__rmqueue_pcplist.patch removed from -mm tree

by Andrew Morton

The quilt patch titled Subject: mm/page_alloc: fix pcp->count race between drain_pages_zone() vs __rmqueue_pcplist() has been removed from the -mm tree. Its filename was mm-page_alloc-fix-pcp-count-race-between-drain_pages_zone-vs-__rmqueue_pcplist.patch This patch was dropped because it was merged into the mm-hotfixes-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm ------------------------------------------------------ From: Li Zhijian <lizhijian(a)fujitsu.com> Subject: mm/page_alloc: fix pcp->count race between drain_pages_zone() vs __rmqueue_pcplist() Date: Tue, 23 Jul 2024 14:44:28 +0800 It's expected that no page should be left in pcp_list after calling zone_pcp_disable() in offline_pages(). Previously, it's observed that offline_pages() gets stuck [1] due to some pages remaining in pcp_list. Cause: There is a race condition between drain_pages_zone() and __rmqueue_pcplist() involving the pcp->count variable. See below scenario: CPU0 CPU1 ---------------- --------------- spin_lock(&pcp->lock); __rmqueue_pcplist() { zone_pcp_disable() { /* list is empty */ if (list_empty(list)) { /* add pages to pcp_list */ alloced = rmqueue_bulk() mutex_lock(&pcp_batch_high_lock) ... __drain_all_pages() { drain_pages_zone() { /* read pcp->count, it's 0 here */ count = READ_ONCE(pcp->count) /* 0 means nothing to drain */ /* update pcp->count */ pcp->count += alloced << order; ... ... spin_unlock(&pcp->lock); In this case, after calling zone_pcp_disable() though, there are still some pages in pcp_list. And these pages in pcp_list are neither movable nor isolated, offline_pages() gets stuck as a result. Solution: Expand the scope of the pcp->lock to also protect pcp->count in drain_pages_zone(), to ensure no pages are left in the pcp list after zone_pcp_disable() [1] https://lore.kernel.org/linux-mm/6a07125f-e720-404c-b2f9-e55f3f166e85@fujit… Link: https://lkml.kernel.org/r/20240723064428.1179519-1-lizhijian@fujitsu.com Fixes: 4b23a68f9536 ("mm/page_alloc: protect PCP lists with a spinlock") Signed-off-by: Li Zhijian <lizhijian(a)fujitsu.com> Reported-by: Yao Xingtao <yaoxt.fnst(a)fujitsu.com> Reviewed-by: Vlastimil Babka <vbabka(a)suse.cz> Cc: David Hildenbrand <david(a)redhat.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- mm/page_alloc.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) --- a/mm/page_alloc.c~mm-page_alloc-fix-pcp-count-race-between-drain_pages_zone-vs-__rmqueue_pcplist +++ a/mm/page_alloc.c @@ -2343,16 +2343,20 @@ void drain_zone_pages(struct zone *zone, static void drain_pages_zone(unsigned int cpu, struct zone *zone) { struct per_cpu_pages *pcp = per_cpu_ptr(zone->per_cpu_pageset, cpu); - int count = READ_ONCE(pcp->count); - - while (count) { - int to_drain = min(count, pcp->batch << CONFIG_PCP_BATCH_SCALE_MAX); - count -= to_drain; + int count; + do { spin_lock(&pcp->lock); - free_pcppages_bulk(zone, to_drain, pcp, 0); + count = pcp->count; + if (count) { + int to_drain = min(count, + pcp->batch << CONFIG_PCP_BATCH_SCALE_MAX); + + free_pcppages_bulk(zone, to_drain, pcp, 0); + count -= to_drain; + } spin_unlock(&pcp->lock); - } + } while (count); } /* _ Patches currently in -mm which might be from lizhijian(a)fujitsu.com are

1 year, 4 months

1
0
0 0

[merged mm-hotfixes-stable] alloc_tag-outline-and-export-free_reserved_page.patch removed from -mm tree

by Andrew Morton

The quilt patch titled Subject: alloc_tag: outline and export free_reserved_page() has been removed from the -mm tree. Its filename was alloc_tag-outline-and-export-free_reserved_page.patch This patch was dropped because it was merged into the mm-hotfixes-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm ------------------------------------------------------ From: Suren Baghdasaryan <surenb(a)google.com> Subject: alloc_tag: outline and export free_reserved_page() Date: Wed, 17 Jul 2024 14:28:44 -0700 Outline and export free_reserved_page() because modules use it and it in turn uses page_ext_{get|put} which should not be exported. The same result could be obtained by outlining {get|put}_page_tag_ref() but that would have higher performance impact as these functions are used in more performance critical paths. Link: https://lkml.kernel.org/r/20240717212844.2749975-1-surenb@google.com Fixes: dcfe378c81f7 ("lib: introduce support for page allocation tagging") Signed-off-by: Suren Baghdasaryan <surenb(a)google.com> Reported-by: kernel test robot <lkp(a)intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202407080044.DWMC9N9I-lkp@intel.com/ Suggested-by: Christoph Hellwig <hch(a)infradead.org> Suggested-by: Vlastimil Babka <vbabka(a)suse.cz> Acked-by: Vlastimil Babka <vbabka(a)suse.cz> Cc: Kees Cook <keescook(a)chromium.org> Cc: Kent Overstreet <kent.overstreet(a)linux.dev> Cc: Pasha Tatashin <pasha.tatashin(a)soleen.com> Cc: Sourav Panda <souravpanda(a)google.com> Cc: <stable(a)vger.kernel.org> [6.10] Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- include/linux/mm.h | 16 +--------------- mm/page_alloc.c | 17 +++++++++++++++++ 2 files changed, 18 insertions(+), 15 deletions(-) --- a/include/linux/mm.h~alloc_tag-outline-and-export-free_reserved_page +++ a/include/linux/mm.h @@ -3130,21 +3130,7 @@ extern void reserve_bootmem_region(phys_ phys_addr_t end, int nid); /* Free the reserved page into the buddy system, so it gets managed. */ -static inline void free_reserved_page(struct page *page) -{ - if (mem_alloc_profiling_enabled()) { - union codetag_ref *ref = get_page_tag_ref(page); - - if (ref) { - set_codetag_empty(ref); - put_page_tag_ref(ref); - } - } - ClearPageReserved(page); - init_page_count(page); - __free_page(page); - adjust_managed_page_count(page, 1); -} +void free_reserved_page(struct page *page); #define free_highmem_page(page) free_reserved_page(page) static inline void mark_page_reserved(struct page *page) --- a/mm/page_alloc.c~alloc_tag-outline-and-export-free_reserved_page +++ a/mm/page_alloc.c @@ -5815,6 +5815,23 @@ unsigned long free_reserved_area(void *s return pages; } +void free_reserved_page(struct page *page) +{ + if (mem_alloc_profiling_enabled()) { + union codetag_ref *ref = get_page_tag_ref(page); + + if (ref) { + set_codetag_empty(ref); + put_page_tag_ref(ref); + } + } + ClearPageReserved(page); + init_page_count(page); + __free_page(page); + adjust_managed_page_count(page, 1); +} +EXPORT_SYMBOL(free_reserved_page); + static int page_alloc_cpu_dead(unsigned int cpu) { struct zone *zone; _ Patches currently in -mm which might be from surenb(a)google.com are

1 year, 4 months

1
0
0 0

[merged mm-hotfixes-stable] decompress_bunzip2-fix-rare-decompression-failure.patch removed from -mm tree

by Andrew Morton

The quilt patch titled Subject: decompress_bunzip2: fix rare decompression failure has been removed from the -mm tree. Its filename was decompress_bunzip2-fix-rare-decompression-failure.patch This patch was dropped because it was merged into the mm-hotfixes-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm ------------------------------------------------------ From: Ross Lagerwall <ross.lagerwall(a)citrix.com> Subject: decompress_bunzip2: fix rare decompression failure Date: Wed, 17 Jul 2024 17:20:16 +0100 The decompression code parses a huffman tree and counts the number of symbols for a given bit length. In rare cases, there may be >= 256 symbols with a given bit length, causing the unsigned char to overflow. This causes a decompression failure later when the code tries and fails to find the bit length for a given symbol. Since the maximum number of symbols is 258, use unsigned short instead. Link: https://lkml.kernel.org/r/20240717162016.1514077-1-ross.lagerwall@citrix.com Fixes: bc22c17e12c1 ("bzip2/lzma: library support for gzip, bzip2 and lzma decompression") Signed-off-by: Ross Lagerwall <ross.lagerwall(a)citrix.com> Cc: Alain Knaff <alain(a)knaff.lu> Cc: "H. Peter Anvin" <hpa(a)zytor.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- lib/decompress_bunzip2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/lib/decompress_bunzip2.c~decompress_bunzip2-fix-rare-decompression-failure +++ a/lib/decompress_bunzip2.c @@ -232,7 +232,8 @@ static int INIT get_next_block(struct bu RUNB) */ symCount = symTotal+2; for (j = 0; j < groupCount; j++) { - unsigned char length[MAX_SYMBOLS], temp[MAX_HUFCODE_BITS+1]; + unsigned char length[MAX_SYMBOLS]; + unsigned short temp[MAX_HUFCODE_BITS+1]; int minLen, maxLen, pp; /* Read Huffman code lengths for each symbol. They're stored in a way similar to mtf; record a starting _ Patches currently in -mm which might be from ross.lagerwall(a)citrix.com are

1 year, 4 months

1
0
0 0

[merged mm-hotfixes-stable] mm-huge_memory-avoid-pmd-size-page-cache-if-needed.patch removed from -mm tree

by Andrew Morton

The quilt patch titled Subject: mm/huge_memory: avoid PMD-size page cache if needed has been removed from the -mm tree. Its filename was mm-huge_memory-avoid-pmd-size-page-cache-if-needed.patch This patch was dropped because it was merged into the mm-hotfixes-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm ------------------------------------------------------ From: Gavin Shan <gshan(a)redhat.com> Subject: mm/huge_memory: avoid PMD-size page cache if needed Date: Mon, 15 Jul 2024 10:04:23 +1000 xarray can't support arbitrary page cache size. the largest and supported page cache size is defined as MAX_PAGECACHE_ORDER by commit 099d90642a71 ("mm/filemap: make MAX_PAGECACHE_ORDER acceptable to xarray"). However, it's possible to have 512MB page cache in the huge memory's collapsing path on ARM64 system whose base page size is 64KB. 512MB page cache is breaking the limitation and a warning is raised when the xarray entry is split as shown in the following example. [root@dhcp-10-26-1-207 ~]# cat /proc/1/smaps | grep KernelPageSize KernelPageSize: 64 kB [root@dhcp-10-26-1-207 ~]# cat /tmp/test.c : int main(int argc, char **argv) { const char *filename = TEST_XFS_FILENAME; int fd = 0; void *buf = (void *)-1, *p; int pgsize = getpagesize(); int ret = 0; if (pgsize != 0x10000) { fprintf(stdout, "System with 64KB base page size is required!\n"); return -EPERM; } system("echo 0 > /sys/devices/virtual/bdi/253:0/read_ahead_kb"); system("echo 1 > /proc/sys/vm/drop_caches"); /* Open the xfs file */ fd = open(filename, O_RDONLY); assert(fd > 0); /* Create VMA */ buf = mmap(NULL, TEST_MEM_SIZE, PROT_READ, MAP_SHARED, fd, 0); assert(buf != (void *)-1); fprintf(stdout, "mapped buffer at 0x%p\n", buf); /* Populate VMA */ ret = madvise(buf, TEST_MEM_SIZE, MADV_NOHUGEPAGE); assert(ret == 0); ret = madvise(buf, TEST_MEM_SIZE, MADV_POPULATE_READ); assert(ret == 0); /* Collapse VMA */ ret = madvise(buf, TEST_MEM_SIZE, MADV_HUGEPAGE); assert(ret == 0); ret = madvise(buf, TEST_MEM_SIZE, MADV_COLLAPSE); if (ret) { fprintf(stdout, "Error %d to madvise(MADV_COLLAPSE)\n", errno); goto out; } /* Split xarray entry. Write permission is needed */ munmap(buf, TEST_MEM_SIZE); buf = (void *)-1; close(fd); fd = open(filename, O_RDWR); assert(fd > 0); fallocate(fd, FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE, TEST_MEM_SIZE - pgsize, pgsize); out: if (buf != (void *)-1) munmap(buf, TEST_MEM_SIZE); if (fd > 0) close(fd); return ret; } [root@dhcp-10-26-1-207 ~]# gcc /tmp/test.c -o /tmp/test [root@dhcp-10-26-1-207 ~]# /tmp/test ------------[ cut here ]------------ WARNING: CPU: 25 PID: 7560 at lib/xarray.c:1025 xas_split_alloc+0xf8/0x128 Modules linked in: nft_fib_inet nft_fib_ipv4 nft_fib_ipv6 nft_fib \ nft_reject_inet nf_reject_ipv4 nf_reject_ipv6 nft_reject nft_ct \ nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 \ ip_set rfkill nf_tables nfnetlink vfat fat virtio_balloon drm fuse \ xfs libcrc32c crct10dif_ce ghash_ce sha2_ce sha256_arm64 virtio_net \ sha1_ce net_failover virtio_blk virtio_console failover dimlib virtio_mmio CPU: 25 PID: 7560 Comm: test Kdump: loaded Not tainted 6.10.0-rc7-gavin+ #9 Hardware name: QEMU KVM Virtual Machine, BIOS edk2-20240524-1.el9 05/24/2024 pstate: 83400005 (Nzcv daif +PAN -UAO +TCO +DIT -SSBS BTYPE=--) pc : xas_split_alloc+0xf8/0x128 lr : split_huge_page_to_list_to_order+0x1c4/0x780 sp : ffff8000ac32f660 x29: ffff8000ac32f660 x28: ffff0000e0969eb0 x27: ffff8000ac32f6c0 x26: 0000000000000c40 x25: ffff0000e0969eb0 x24: 000000000000000d x23: ffff8000ac32f6c0 x22: ffffffdfc0700000 x21: 0000000000000000 x20: 0000000000000000 x19: ffffffdfc0700000 x18: 0000000000000000 x17: 0000000000000000 x16: ffffd5f3708ffc70 x15: 0000000000000000 x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000000 x11: ffffffffffffffc0 x10: 0000000000000040 x9 : ffffd5f3708e692c x8 : 0000000000000003 x7 : 0000000000000000 x6 : ffff0000e0969eb8 x5 : ffffd5f37289e378 x4 : 0000000000000000 x3 : 0000000000000c40 x2 : 000000000000000d x1 : 000000000000000c x0 : 0000000000000000 Call trace: xas_split_alloc+0xf8/0x128 split_huge_page_to_list_to_order+0x1c4/0x780 truncate_inode_partial_folio+0xdc/0x160 truncate_inode_pages_range+0x1b4/0x4a8 truncate_pagecache_range+0x84/0xa0 xfs_flush_unmap_range+0x70/0x90 [xfs] xfs_file_fallocate+0xfc/0x4d8 [xfs] vfs_fallocate+0x124/0x2f0 ksys_fallocate+0x4c/0xa0 __arm64_sys_fallocate+0x24/0x38 invoke_syscall.constprop.0+0x7c/0xd8 do_el0_svc+0xb4/0xd0 el0_svc+0x44/0x1d8 el0t_64_sync_handler+0x134/0x150 el0t_64_sync+0x17c/0x180 Fix it by correcting the supported page cache orders, different sets for DAX and other files. With it corrected, 512MB page cache becomes disallowed on all non-DAX files on ARM64 system where the base page size is 64KB. After this patch is applied, the test program fails with error -EINVAL returned from __thp_vma_allowable_orders() and the madvise() system call to collapse the page caches. Link: https://lkml.kernel.org/r/20240715000423.316491-1-gshan@redhat.com Fixes: 6b24ca4a1a8d ("mm: Use multi-index entries in the page cache") Signed-off-by: Gavin Shan <gshan(a)redhat.com> Acked-by: David Hildenbrand <david(a)redhat.com> Reviewed-by: Ryan Roberts <ryan.roberts(a)arm.com> Acked-by: Zi Yan <ziy(a)nvidia.com> Cc: Baolin Wang <baolin.wang(a)linux.alibaba.com> Cc: Barry Song <baohua(a)kernel.org> Cc: Don Dutile <ddutile(a)redhat.com> Cc: Matthew Wilcox (Oracle) <willy(a)infradead.org> Cc: Peter Xu <peterx(a)redhat.com> Cc: Ryan Roberts <ryan.roberts(a)arm.com> Cc: William Kucharski <william.kucharski(a)oracle.com> Cc: <stable(a)vger.kernel.org> [5.17+] Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- include/linux/huge_mm.h | 12 +++++++++--- mm/huge_memory.c | 12 ++++++++++-- 2 files changed, 19 insertions(+), 5 deletions(-) --- a/include/linux/huge_mm.h~mm-huge_memory-avoid-pmd-size-page-cache-if-needed +++ a/include/linux/huge_mm.h @@ -74,14 +74,20 @@ extern struct kobj_attribute thpsize_shm #define THP_ORDERS_ALL_ANON ((BIT(PMD_ORDER + 1) - 1) & ~(BIT(0) | BIT(1))) /* - * Mask of all large folio orders supported for file THP. + * Mask of all large folio orders supported for file THP. Folios in a DAX + * file is never split and the MAX_PAGECACHE_ORDER limit does not apply to + * it. */ -#define THP_ORDERS_ALL_FILE (BIT(PMD_ORDER) | BIT(PUD_ORDER)) +#define THP_ORDERS_ALL_FILE_DAX \ + (BIT(PMD_ORDER) | BIT(PUD_ORDER)) +#define THP_ORDERS_ALL_FILE_DEFAULT \ + ((BIT(MAX_PAGECACHE_ORDER + 1) - 1) & ~BIT(0)) /* * Mask of all large folio orders supported for THP. */ -#define THP_ORDERS_ALL (THP_ORDERS_ALL_ANON | THP_ORDERS_ALL_FILE) +#define THP_ORDERS_ALL \ + (THP_ORDERS_ALL_ANON | THP_ORDERS_ALL_FILE_DAX | THP_ORDERS_ALL_FILE_DEFAULT) #define TVA_SMAPS (1 << 0) /* Will be used for procfs */ #define TVA_IN_PF (1 << 1) /* Page fault handler */ --- a/mm/huge_memory.c~mm-huge_memory-avoid-pmd-size-page-cache-if-needed +++ a/mm/huge_memory.c @@ -89,9 +89,17 @@ unsigned long __thp_vma_allowable_orders bool smaps = tva_flags & TVA_SMAPS; bool in_pf = tva_flags & TVA_IN_PF; bool enforce_sysfs = tva_flags & TVA_ENFORCE_SYSFS; + unsigned long supported_orders; + /* Check the intersection of requested and supported orders. */ - orders &= vma_is_anonymous(vma) ? - THP_ORDERS_ALL_ANON : THP_ORDERS_ALL_FILE; + if (vma_is_anonymous(vma)) + supported_orders = THP_ORDERS_ALL_ANON; + else if (vma_is_dax(vma)) + supported_orders = THP_ORDERS_ALL_FILE_DAX; + else + supported_orders = THP_ORDERS_ALL_FILE_DEFAULT; + + orders &= supported_orders; if (!orders) return 0; _ Patches currently in -mm which might be from gshan(a)redhat.com are

1 year, 4 months

1
0
0 0

[merged mm-hotfixes-stable] mm-huge_memory-use-config_64bit-to-relax-huge-page-alignment-on-32-bit-machines.patch removed from -mm tree

by Andrew Morton

The quilt patch titled Subject: mm: huge_memory: use !CONFIG_64BIT to relax huge page alignment on 32 bit machines has been removed from the -mm tree. Its filename was mm-huge_memory-use-config_64bit-to-relax-huge-page-alignment-on-32-bit-machines.patch This patch was dropped because it was merged into the mm-hotfixes-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm ------------------------------------------------------ From: Yang Shi <yang(a)os.amperecomputing.com> Subject: mm: huge_memory: use !CONFIG_64BIT to relax huge page alignment on 32 bit machines Date: Fri, 12 Jul 2024 08:58:55 -0700 Yves-Alexis Perez reported commit 4ef9ad19e176 ("mm: huge_memory: don't force huge page alignment on 32 bit") didn't work for x86_32 [1]. It is because x86_32 uses CONFIG_X86_32 instead of CONFIG_32BIT. !CONFIG_64BIT should cover all 32 bit machines. [1] https://lore.kernel.org/linux-mm/CAHbLzkr1LwH3pcTgM+aGQ31ip2bKqiqEQ8=FQB+t2… Link: https://lkml.kernel.org/r/20240712155855.1130330-1-yang@os.amperecomputing.… Fixes: 4ef9ad19e176 ("mm: huge_memory: don't force huge page alignment on 32 bit") Signed-off-by: Yang Shi <yang(a)os.amperecomputing.com> Reported-by: Yves-Alexis Perez <corsac(a)debian.org> Tested-by: Yves-Alexis Perez <corsac(a)debian.org> Acked-by: David Hildenbrand <david(a)redhat.com> Cc: Ben Hutchings <ben(a)decadent.org.uk> Cc: Christoph Lameter <cl(a)linux.com> Cc: Jiri Slaby <jirislaby(a)kernel.org> Cc: Matthew Wilcox (Oracle) <willy(a)infradead.org> Cc: Rik van Riel <riel(a)surriel.com> Cc: Salvatore Bonaccorso <carnil(a)debian.org> Cc: Suren Baghdasaryan <surenb(a)google.com> Cc: <stable(a)vger.kernel.org> [6.8+] Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- mm/huge_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/huge_memory.c~mm-huge_memory-use-config_64bit-to-relax-huge-page-alignment-on-32-bit-machines +++ a/mm/huge_memory.c @@ -877,7 +877,7 @@ static unsigned long __thp_get_unmapped_ loff_t off_align = round_up(off, size); unsigned long len_pad, ret, off_sub; - if (IS_ENABLED(CONFIG_32BIT) || in_compat_syscall()) + if (!IS_ENABLED(CONFIG_64BIT) || in_compat_syscall()) return 0; if (off_end <= off_align || (off_end - off_align) < size) _ Patches currently in -mm which might be from yang(a)os.amperecomputing.com are

1 year, 4 months

1
0
0 0

[merged mm-hotfixes-stable] mm-fix-old-young-bit-handling-in-the-faulting-path.patch removed from -mm tree

by Andrew Morton

The quilt patch titled Subject: mm: fix old/young bit handling in the faulting path has been removed from the -mm tree. Its filename was mm-fix-old-young-bit-handling-in-the-faulting-path.patch This patch was dropped because it was merged into the mm-hotfixes-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm ------------------------------------------------------ From: Ram Tummala <rtummala(a)nvidia.com> Subject: mm: fix old/young bit handling in the faulting path Date: Tue, 9 Jul 2024 18:45:39 -0700 Commit 3bd786f76de2 ("mm: convert do_set_pte() to set_pte_range()") replaced do_set_pte() with set_pte_range() and that introduced a regression in the following faulting path of non-anonymous vmas which caused the PTE for the faulting address to be marked as old instead of young. handle_pte_fault() do_pte_missing() do_fault() do_read_fault() || do_cow_fault() || do_shared_fault() finish_fault() set_pte_range() The polarity of prefault calculation is incorrect. This leads to prefault being incorrectly set for the faulting address. The following check will incorrectly mark the PTE old rather than young. On some architectures this will cause a double fault to mark it young when the access is retried. if (prefault && arch_wants_old_prefaulted_pte()) entry = pte_mkold(entry); On a subsequent fault on the same address, the faulting path will see a non NULL vmf->pte and instead of reaching the do_pte_missing() path, PTE will then be correctly marked young in handle_pte_fault() itself. Due to this bug, performance degradation in the fault handling path will be observed due to unnecessary double faulting. Link: https://lkml.kernel.org/r/20240710014539.746200-1-rtummala@nvidia.com Fixes: 3bd786f76de2 ("mm: convert do_set_pte() to set_pte_range()") Signed-off-by: Ram Tummala <rtummala(a)nvidia.com> Reviewed-by: Yin Fengwei <fengwei.yin(a)intel.com> Cc: Alistair Popple <apopple(a)nvidia.com> Cc: Matthew Wilcox (Oracle) <willy(a)infradead.org> Cc: Yin Fengwei <fengwei.yin(a)intel.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- mm/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/memory.c~mm-fix-old-young-bit-handling-in-the-faulting-path +++ a/mm/memory.c @@ -4780,7 +4780,7 @@ void set_pte_range(struct vm_fault *vmf, { struct vm_area_struct *vma = vmf->vma; bool write = vmf->flags & FAULT_FLAG_WRITE; - bool prefault = in_range(vmf->address, addr, nr * PAGE_SIZE); + bool prefault = !in_range(vmf->address, addr, nr * PAGE_SIZE); pte_t entry; flush_icache_pages(vma, page, nr); _ Patches currently in -mm which might be from rtummala(a)nvidia.com are

1 year, 4 months

1
0
0 0

[PATCH 6.9 00/29] 6.9.12-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.9.12 release. There are 29 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat, 27 Jul 2024 14:27:16 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.9.12-rc1… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.9.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 6.9.12-rc1 Jann Horn <jannh(a)google.com> filelock: Fix fcntl/close race recovery compat path Takashi Iwai <tiwai(a)suse.de> ALSA: seq: ump: Skip useless ports for static blocks Shengjiu Wang <shengjiu.wang(a)nxp.com> ALSA: pcm_dmaengine: Don't synchronize DMA channel when DMA is paused Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: sm6115: Disable SS instance in Parkmode for USB Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: sdm845: Disable SS instance in Parkmode for USB Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: ipq8074: Disable SS instance in Parkmode for USB Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: sdm630: Disable SS instance in Parkmode for USB Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: ipq6018: Disable SS instance in Parkmode for USB Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: msm8998: Disable SS instance in Parkmode for USB Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: sm6350: Disable SS instance in Parkmode for USB Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: msm8996: Disable SS instance in Parkmode for USB Abel Vesa <abel.vesa(a)linaro.org> arm64: dts: qcom: x1e80100-crd: Fix USB PHYs regulators Abel Vesa <abel.vesa(a)linaro.org> arm64: dts: qcom: x1e80100-qcp: Fix the PHY regulator for PCIe 6a Abel Vesa <abel.vesa(a)linaro.org> arm64: dts: qcom: x1e80100-crd: Fix the PHY regulator for PCIe 6a Dmitry Baryshkov <dmitry.baryshkov(a)linaro.org> arm64: dts: qcom: qrb4210-rb2: switch I2C2 to i2c-gpio Dmitry Baryshkov <dmitry.baryshkov(a)linaro.org> arm64: dts: qcom: qrb2210-rb1: switch I2C2 to i2c-gpio Abel Vesa <abel.vesa(a)linaro.org> arm64: dts: qcom: x1e80100-qcp: Fix USB PHYs regulators Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: sc7280: Disable SuperSpeed instances in park mode Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: sc7180: Disable SuperSpeed instances in park mode Seunghun Han <kkamagui(a)gmail.com> ALSA: hda/realtek: Fix the speaker output on Samsung Galaxy Book Pro 360 Edson Juliano Drosdeck <edson.drosdeck(a)gmail.com> ALSA: hda/realtek: Enable headset mic on Positivo SU C1400 Shenghao Ding <shenghao-ding(a)ti.com> ALSA: hda/tas2781: Add new quirk for Lenovo Hera2 Laptop Takashi Iwai <tiwai(a)suse.de> usb: gadget: midi2: Fix incorrect default MIDI2 protocol setup lei lu <llfamsec(a)gmail.com> fs/ntfs3: Validate ff offset Konstantin Komarov <almaz.alexandrovich(a)paragon-software.com> fs/ntfs3: Add a check for attr_names and oatbl lei lu <llfamsec(a)gmail.com> jfs: don't walk off the end of ealist lei lu <llfamsec(a)gmail.com> ocfs2: add bounds checking to ocfs2_check_dir_entry() Gerald Schaefer <gerald.schaefer(a)linux.ibm.com> s390/mm: Fix VM_FAULT_HWPOISON handling in do_exception() Dan Carpenter <dan.carpenter(a)linaro.org> drm/amdgpu: Fix signedness bug in sdma_v4_0_process_trap_irq() ------------- Diffstat: Makefile | 4 +-- arch/arm64/boot/dts/qcom/ipq6018.dtsi | 1 + arch/arm64/boot/dts/qcom/ipq8074.dtsi | 2 ++ arch/arm64/boot/dts/qcom/msm8996.dtsi | 1 + arch/arm64/boot/dts/qcom/msm8998.dtsi | 1 + arch/arm64/boot/dts/qcom/qrb2210-rb1.dts | 13 ++++++++- arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 13 ++++++++- arch/arm64/boot/dts/qcom/sc7180.dtsi | 1 + arch/arm64/boot/dts/qcom/sc7280.dtsi | 1 + arch/arm64/boot/dts/qcom/sdm630.dtsi | 1 + arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 ++ arch/arm64/boot/dts/qcom/sm6115.dtsi | 1 + arch/arm64/boot/dts/qcom/sm6350.dtsi | 1 + arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 17 +++++++++--- arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 17 +++++++++--- arch/s390/mm/fault.c | 3 +- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 +- drivers/usb/gadget/function/f_midi2.c | 19 +++++++------ fs/jfs/xattr.c | 23 +++++++++++++--- fs/locks.c | 9 +++--- fs/ntfs3/fslog.c | 44 ++++++++++++++++++++++++----- fs/ocfs2/dir.c | 46 +++++++++++++++++++------------ sound/core/pcm_dmaengine.c | 6 +++- sound/core/seq/seq_ump_client.c | 16 +++++++++++ sound/pci/hda/patch_realtek.c | 3 ++ 25 files changed, 191 insertions(+), 56 deletions(-)

1 year, 4 months

11
39
0 0

[tip: irq/urgent] irqchip/loongarch-cpu: Fix return value of lpic_gsi_to_irq()

by tip-bot2 for Huacai Chen

The following commit has been merged into the irq/urgent branch of tip: Commit-ID: 81a91abab1307d7725fa4620952c0767beae7753 Gitweb: https://git.kernel.org/tip/81a91abab1307d7725fa4620952c0767beae7753 Author: Huacai Chen <chenhuacai(a)loongson.cn> AuthorDate: Tue, 23 Jul 2024 14:45:08 +08:00 Committer: Thomas Gleixner <tglx(a)linutronix.de> CommitterDate: Fri, 26 Jul 2024 21:08:42 +02:00 irqchip/loongarch-cpu: Fix return value of lpic_gsi_to_irq() lpic_gsi_to_irq() should return a valid Linux interrupt number if acpi_register_gsi() succeeds, and return 0 otherwise. But lpic_gsi_to_irq() converts a negative return value of acpi_register_gsi() to a positive value silently. Convert the return value explicitly. Fixes: e8bba72b396c ("irqchip / ACPI: Introduce ACPI_IRQ_MODEL_LPIC for LoongArch") Reported-by: Miao Wang <shankerwangmiao(a)gmail.com> Signed-off-by: Huacai Chen <chenhuacai(a)loongson.cn> Signed-off-by: Thomas Gleixner <tglx(a)linutronix.de> Reviewed-by: Jiaxun Yang <jiaxun.yang(a)flygoat.com> Cc: <stable(a)vger.kernel.org> Link: https://lore.kernel.org/r/20240723064508.35560-1-chenhuacai@loongson.cn --- drivers/irqchip/irq-loongarch-cpu.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-loongarch-cpu.c b/drivers/irqchip/irq-loongarch-cpu.c index 9d8f2c4..b35903a 100644 --- a/drivers/irqchip/irq-loongarch-cpu.c +++ b/drivers/irqchip/irq-loongarch-cpu.c @@ -18,11 +18,13 @@ struct fwnode_handle *cpuintc_handle; static u32 lpic_gsi_to_irq(u32 gsi) { + int irq = 0; + /* Only pch irqdomain transferring is required for LoongArch. */ if (gsi >= GSI_MIN_PCH_IRQ && gsi <= GSI_MAX_PCH_IRQ) - return acpi_register_gsi(NULL, gsi, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_HIGH); + irq = acpi_register_gsi(NULL, gsi, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_HIGH); - return 0; + return (irq > 0) ? irq : 0; } static struct fwnode_handle *lpic_get_gsi_domain_id(u32 gsi)

1 year, 4 months

1
0
0 0

[PATCH 6.6 00/16] 6.6.43-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.6.43 release. There are 16 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat, 27 Jul 2024 14:27:16 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.6.43-rc1… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.6.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 6.6.43-rc1 Jann Horn <jannh(a)google.com> filelock: Fix fcntl/close race recovery compat path Takashi Iwai <tiwai(a)suse.de> ALSA: seq: ump: Skip useless ports for static blocks Shengjiu Wang <shengjiu.wang(a)nxp.com> ALSA: pcm_dmaengine: Don't synchronize DMA channel when DMA is paused Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: sdm630: Disable SS instance in Parkmode for USB Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: ipq6018: Disable SS instance in Parkmode for USB Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: sm6350: Disable SS instance in Parkmode for USB Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: msm8996: Disable SS instance in Parkmode for USB Dmitry Baryshkov <dmitry.baryshkov(a)linaro.org> arm64: dts: qcom: qrb4210-rb2: switch I2C2 to i2c-gpio Seunghun Han <kkamagui(a)gmail.com> ALSA: hda/realtek: Fix the speaker output on Samsung Galaxy Book Pro 360 Edson Juliano Drosdeck <edson.drosdeck(a)gmail.com> ALSA: hda/realtek: Enable headset mic on Positivo SU C1400 Takashi Iwai <tiwai(a)suse.de> usb: gadget: midi2: Fix incorrect default MIDI2 protocol setup lei lu <llfamsec(a)gmail.com> fs/ntfs3: Validate ff offset Konstantin Komarov <almaz.alexandrovich(a)paragon-software.com> fs/ntfs3: Add a check for attr_names and oatbl lei lu <llfamsec(a)gmail.com> jfs: don't walk off the end of ealist lei lu <llfamsec(a)gmail.com> ocfs2: add bounds checking to ocfs2_check_dir_entry() Dan Carpenter <dan.carpenter(a)linaro.org> drm/amdgpu: Fix signedness bug in sdma_v4_0_process_trap_irq() ------------- Diffstat: Makefile | 4 +-- arch/arm64/boot/dts/qcom/ipq6018.dtsi | 1 + arch/arm64/boot/dts/qcom/msm8996.dtsi | 1 + arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 13 ++++++++- arch/arm64/boot/dts/qcom/sdm630.dtsi | 1 + arch/arm64/boot/dts/qcom/sm6350.dtsi | 1 + drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 +- drivers/usb/gadget/function/f_midi2.c | 19 +++++++------ fs/jfs/xattr.c | 23 +++++++++++++--- fs/locks.c | 9 +++---- fs/ntfs3/fslog.c | 44 +++++++++++++++++++++++++----- fs/ocfs2/dir.c | 46 ++++++++++++++++++++------------ sound/core/pcm_dmaengine.c | 6 ++++- sound/core/seq/seq_ump_client.c | 16 +++++++++++ sound/pci/hda/patch_realtek.c | 2 ++ 15 files changed, 142 insertions(+), 46 deletions(-)

1 year, 4 months

11
26
0 0

[PATCH 6.1 00/13] 6.1.102-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.1.102 release. There are 13 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat, 27 Jul 2024 14:27:16 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.102-rc… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 6.1.102-rc1 Filipe Manana <fdmanana(a)suse.com> btrfs: do not BUG_ON on failure to get dir index for new snapshot Jann Horn <jannh(a)google.com> filelock: Fix fcntl/close race recovery compat path Shengjiu Wang <shengjiu.wang(a)nxp.com> ALSA: pcm_dmaengine: Don't synchronize DMA channel when DMA is paused Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: sdm630: Disable SS instance in Parkmode for USB Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: ipq6018: Disable SS instance in Parkmode for USB Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: msm8996: Disable SS instance in Parkmode for USB Seunghun Han <kkamagui(a)gmail.com> ALSA: hda/realtek: Fix the speaker output on Samsung Galaxy Book Pro 360 Edson Juliano Drosdeck <edson.drosdeck(a)gmail.com> ALSA: hda/realtek: Enable headset mic on Positivo SU C1400 lei lu <llfamsec(a)gmail.com> fs/ntfs3: Validate ff offset lei lu <llfamsec(a)gmail.com> jfs: don't walk off the end of ealist lei lu <llfamsec(a)gmail.com> ocfs2: add bounds checking to ocfs2_check_dir_entry() Chao Yu <chao(a)kernel.org> f2fs: avoid dead loop in f2fs_issue_checkpoint() Dan Carpenter <dan.carpenter(a)linaro.org> drm/amdgpu: Fix signedness bug in sdma_v4_0_process_trap_irq() ------------- Diffstat: Makefile | 4 +-- arch/arm64/boot/dts/qcom/ipq6018.dtsi | 1 + arch/arm64/boot/dts/qcom/msm8996.dtsi | 1 + arch/arm64/boot/dts/qcom/sdm630.dtsi | 1 + drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 +- fs/btrfs/transaction.c | 5 +++- fs/f2fs/super.c | 15 +++++++++-- fs/jfs/xattr.c | 23 ++++++++++++++--- fs/locks.c | 9 +++---- fs/ntfs3/fslog.c | 6 ++++- fs/ocfs2/dir.c | 46 +++++++++++++++++++++------------- sound/core/pcm_dmaengine.c | 6 ++++- sound/pci/hda/patch_realtek.c | 2 ++ 13 files changed, 87 insertions(+), 34 deletions(-)

1 year, 4 months

10
22
0 0

[PATCH 5.15 00/90] 5.15.164-rc2 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.15.164 release. There are 90 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sun, 28 Jul 2024 07:05:35 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.164-r… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 5.15.164-rc2 Si-Wei Liu <si-wei.liu(a)oracle.com> tap: add missing verification for short frame Dongli Zhang <dongli.zhang(a)oracle.com> tun: add missing verification for short frame Jason A. Donenfeld <Jason(a)zx2c4.com> wifi: rt2x00: use explicitly signed or unsigned types Jann Horn <jannh(a)google.com> filelock: Fix fcntl/close race recovery compat path Shengjiu Wang <shengjiu.wang(a)nxp.com> ALSA: pcm_dmaengine: Don't synchronize DMA channel when DMA is paused Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: sdm630: Disable SS instance in Parkmode for USB Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: msm8996: Disable SS instance in Parkmode for USB Seunghun Han <kkamagui(a)gmail.com> ALSA: hda/realtek: Fix the speaker output on Samsung Galaxy Book Pro 360 Edson Juliano Drosdeck <edson.drosdeck(a)gmail.com> ALSA: hda/realtek: Enable headset mic on Positivo SU C1400 lei lu <llfamsec(a)gmail.com> fs/ntfs3: Validate ff offset lei lu <llfamsec(a)gmail.com> jfs: don't walk off the end of ealist lei lu <llfamsec(a)gmail.com> ocfs2: add bounds checking to ocfs2_check_dir_entry() Paolo Abeni <pabeni(a)redhat.com> net: relax socket state check at accept time. Linus Torvalds <torvalds(a)linux-foundation.org> Add gitignore file for samples/fanotify/ subdirectory Gabriel Krisman Bertazi <krisman(a)collabora.com> docs: Fix formatting of literal sections in fanotify docs Gabriel Krisman Bertazi <krisman(a)collabora.com> samples: Make fs-monitor depend on libc and headers Gabriel Krisman Bertazi <krisman(a)collabora.com> samples: Add fs error monitoring example Dan Carpenter <dan.carpenter(a)linaro.org> drm/amdgpu: Fix signedness bug in sdma_v4_0_process_trap_irq() Johannes Berg <johannes.berg(a)intel.com> wifi: mac80211: disable softirqs for queued frame handling SeongJae Park <sj(a)kernel.org> mm/damon/core: merge regions aggressively when max_nr_regions is unmet David Laight <David.Laight(a)ACULAB.COM> minmax: relax check to allow comparison between unsigned arguments and signed constants David Laight <David.Laight(a)ACULAB.COM> minmax: allow comparisons of 'int' against 'unsigned char/short' David Laight <David.Laight(a)ACULAB.COM> minmax: allow min()/max()/clamp() if the arguments have the same signedness. Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> minmax: fix header inclusions Jason A. Donenfeld <Jason(a)zx2c4.com> minmax: clamp more efficiently by avoiding extra comparison Jason A. Donenfeld <Jason(a)zx2c4.com> minmax: sanity check constant bounds when clamping Bart Van Assche <bvanassche(a)acm.org> tracing: Define the is_signed_type() macro once David Lechner <dlechner(a)baylibre.com> spi: mux: set ctlr->bits_per_word_mask Edward Adam Davis <eadavis(a)qq.com> hfsplus: fix uninit-value in copy_name John Hubbard <jhubbard(a)nvidia.com> selftests/vDSO: fix clang build errors and warnings Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> spi: imx: Don't expect DMA for i.MX{25,35,50,51,53} cspi devices Puranjay Mohan <puranjay(a)kernel.org> riscv: stacktrace: fix usage of ftrace_graph_ret_addr() Christian Brauner <brauner(a)kernel.org> fs: better handle deep ancestor chains in is_subdir() Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer(a)amd.com> drm/radeon: check bo_va->bo is non-NULL before using it Tetsuo Handa <penguin-kernel(a)I-love.SAKURA.ne.jp> Bluetooth: hci_core: cancel all works upon hci_unregister_dev() Xingui Yang <yangxingui(a)huawei.com> scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed Ganesh Goudar <ganeshgr(a)linux.ibm.com> powerpc/eeh: avoid possible crash when edev->pdev changes Anjali K <anjalik(a)linux.ibm.com> powerpc/pseries: Whitelist dtl slub object for copying to userspace Yunshui Jiang <jiangyunshui(a)kylinos.cn> net: mac802154: Fix racy device stats updates by DEV_STATS_INC() and DEV_STATS_ADD() Daniele Palmas <dnlplm(a)gmail.com> net: usb: qmi_wwan: add Telit FN912 compositions Shengjiu Wang <shengjiu.wang(a)nxp.com> ALSA: dmaengine_pcm: terminate dmaengine before synchronize Aivaz Latypov <reichaivaz(a)gmail.com> ALSA: hda/relatek: Enable Mute LED on HP Laptop 15-gw0xxx Filipe Manana <fdmanana(a)suse.com> btrfs: qgroup: fix quota root leak after quota disable failure Armin Wolf <W_Armin(a)gmx.de> platform/x86: lg-laptop: Use ACPI device handle when evaluating WMAB/WMBB Armin Wolf <W_Armin(a)gmx.de> platform/x86: lg-laptop: Change ACPI device id Armin Wolf <W_Armin(a)gmx.de> platform/x86: lg-laptop: Remove LGEX0815 hotkey handling Armin Wolf <W_Armin(a)gmx.de> platform/x86: wireless-hotkey: Add support for LG Airplane Button Heiko Carstens <hca(a)linux.ibm.com> s390/sclp: Fix sclp_init() cleanup on failure Chen Ni <nichen(a)iscas.ac.cn> can: kvaser_usb: fix return value for hif_usb_send_regout Primoz Fiser <primoz.fiser(a)norik.com> ASoC: ti: omap-hdmi: Fix too long driver name Jai Luthra <j-luthra(a)ti.com> ASoC: ti: davinci-mcasp: Set min period size using FIFO config Jai Luthra <j-luthra(a)ti.com> ALSA: dmaengine: Synchronize dma channel after drop() Thomas GENTY <tomlohave(a)gmail.com> bytcr_rt5640 : inverse jack detect for Archos 101 cesium Tobias Jakobi <tjakobi(a)math.uni-bielefeld.de> Input: i8042 - add Ayaneo Kun to i8042 quirk table Jonathan Denose <jdenose(a)google.com> Input: elantech - fix touchpad state on resume for Lenovo N24 Arnd Bergmann <arnd(a)arndb.de> mips: fix compat_sys_lseek syscall Kailang Yang <kailang(a)realtek.com> ALSA: hda/realtek: Add more codec ID to no shutup pins list Alexey Makhalov <alexey.makhalov(a)broadcom.com> drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency Michael Ellerman <mpe(a)ellerman.id.au> KVM: PPC: Book3S HV: Prevent UAF in kvm_spapr_tce_attach_iommu_group() Dmitry Antipov <dmantipov(a)yandex.ru> wifi: cfg80211: wext: add extra SIOCSIWSCAN data check Chunguang Xu <chunguang.xu(a)shopee.com> nvme: avoid double free special payload Alexander Usyskin <alexander.usyskin(a)intel.com> mei: demote client disconnect warning on suspend to debug Yuntao Wang <yuntao.wang(a)linux.dev> fs/file: fix the check in find_next_fd() Masahiro Yamada <masahiroy(a)kernel.org> kconfig: remove wrong expr_trans_bool() Masahiro Yamada <masahiroy(a)kernel.org> kconfig: gconf: give a proper initial state to the Save button Andreas Hindborg <a.hindborg(a)samsung.com> null_blk: fix validation of block size Wei Li <liwei391(a)huawei.com> arm64: armv8_deprecated: Fix warning in isndep cpuhp starting process Eric Dumazet <edumazet(a)google.com> ila: block BH in ila_output() Eric Dumazet <edumazet(a)google.com> net: ipv6: rpl_iptunnel: block BH in rpl_output() and rpl_input() Hans de Goede <hdegoede(a)redhat.com> Input: silead - Always support 10 fingers Michael Ellerman <mpe(a)ellerman.id.au> selftests/openat2: Fix build warnings on ppc64 Dmitry Antipov <dmantipov(a)yandex.ru> wifi: mac80211: fix UBSAN noise in ieee80211_prep_hw_scan() Ayala Beker <ayala.beker(a)intel.com> wifi: iwlwifi: mvm: properly set 6 GHz channel direct probe option Yedidya Benshimol <yedidya.ben.shimol(a)intel.com> wifi: iwlwifi: mvm: Handle BIGTK cipher in kek_kck cmd Yedidya Benshimol <yedidya.ben.shimol(a)intel.com> wifi: iwlwifi: mvm: d3: fix WoWLAN command version lookup Johannes Berg <johannes.berg(a)intel.com> wifi: mac80211: handle tasklet frames before stopping Nicolas Escande <nico.escande(a)gmail.com> wifi: mac80211: mesh: init nonpeer_pm to active by default in mesh sdata Dhananjay Ugwekar <Dhananjay.Ugwekar(a)amd.com> tools/power/cpupower: Fix Pstate frequency reporting on AMD Family 1Ah CPUs Armin Wolf <W_Armin(a)gmx.de> ACPI: EC: Avoid returning AE_OK on errors in address space handler Armin Wolf <W_Armin(a)gmx.de> ACPI: EC: Abort address space access upon error Saurav Kashyap <skashyap(a)marvell.com> scsi: qedf: Set qed_slowpath_params to zero before use Saurav Kashyap <skashyap(a)marvell.com> scsi: qedf: Wait for stag work during unload Saurav Kashyap <skashyap(a)marvell.com> scsi: qedf: Don't process stag work during unload and recovery Martin Wilck <martin.wilck(a)suse.com> scsi: core: alua: I/O errors for ALUA state transitions Bart Van Assche <bvanassche(a)acm.org> scsi: core: Fix a use-after-free Daniel Borkmann <daniel(a)iogearbox.net> bpf: Fix overrunning reservations in ringbuf Kuan-Wei Chiu <visitorckw(a)gmail.com> ACPI: processor_idle: Fix invalid comparison with insertion sort for latency Masahiro Yamada <masahiroy(a)kernel.org> ARM: 9324/1: fix get_user() broken with veneer Jann Horn <jannh(a)google.com> filelock: Remove locks reliably when fcntl/close race is detected Kees Cook <keescook(a)chromium.org> gcc-plugins: Rename last_stmt() for GCC 14+ ------------- Diffstat: .../admin-guide/filesystem-monitoring.rst | 20 +-- Makefile | 4 +- arch/arm/include/asm/uaccess.h | 14 +- arch/arm64/boot/dts/qcom/msm8996.dtsi | 1 + arch/arm64/boot/dts/qcom/sdm630.dtsi | 1 + arch/arm64/kernel/armv8_deprecated.c | 3 + arch/mips/kernel/syscalls/syscall_o32.tbl | 2 +- arch/powerpc/kernel/eeh_pe.c | 7 +- arch/powerpc/kvm/book3s_64_vio.c | 18 ++- arch/powerpc/platforms/pseries/setup.c | 4 +- arch/riscv/kernel/stacktrace.c | 3 +- drivers/acpi/ec.c | 9 +- drivers/acpi/processor_idle.c | 40 +++--- drivers/block/null_blk/main.c | 4 +- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 +- drivers/gpu/drm/radeon/radeon_gem.c | 2 +- drivers/gpu/drm/vmwgfx/Kconfig | 2 +- drivers/input/mouse/elantech.c | 31 +++++ drivers/input/serio/i8042-acpipnpio.h | 18 ++- drivers/input/touchscreen/silead.c | 19 +-- drivers/misc/mei/main.c | 2 +- drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c | 2 +- drivers/net/tap.c | 5 + drivers/net/tun.c | 3 + drivers/net/usb/qmi_wwan.c | 2 + drivers/net/wireless/intel/iwlwifi/mvm/d3.c | 16 ++- drivers/net/wireless/intel/iwlwifi/mvm/scan.c | 5 +- drivers/net/wireless/ralink/rt2x00/rt2400pci.c | 8 +- drivers/net/wireless/ralink/rt2x00/rt2400pci.h | 2 +- drivers/net/wireless/ralink/rt2x00/rt2500pci.c | 8 +- drivers/net/wireless/ralink/rt2x00/rt2500pci.h | 2 +- drivers/net/wireless/ralink/rt2x00/rt2500usb.c | 8 +- drivers/net/wireless/ralink/rt2x00/rt2500usb.h | 2 +- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 36 +++--- drivers/net/wireless/ralink/rt2x00/rt2800lib.h | 8 +- drivers/net/wireless/ralink/rt2x00/rt2x00usb.c | 6 +- drivers/net/wireless/ralink/rt2x00/rt61pci.c | 4 +- drivers/net/wireless/ralink/rt2x00/rt61pci.h | 2 +- drivers/net/wireless/ralink/rt2x00/rt73usb.c | 4 +- drivers/net/wireless/ralink/rt2x00/rt73usb.h | 2 +- drivers/nvme/host/core.c | 1 + drivers/platform/x86/lg-laptop.c | 89 +++++-------- drivers/platform/x86/wireless-hotkey.c | 2 + drivers/s390/char/sclp.c | 1 + drivers/scsi/device_handler/scsi_dh_alua.c | 31 +++-- drivers/scsi/hosts.c | 16 ++- drivers/scsi/libsas/sas_internal.h | 14 ++ drivers/scsi/qedf/qedf.h | 1 + drivers/scsi/qedf/qedf_main.c | 47 ++++++- drivers/scsi/scsi_lib.c | 6 +- drivers/scsi/scsi_priv.h | 2 +- drivers/scsi/scsi_scan.c | 1 + drivers/scsi/scsi_sysfs.c | 1 + drivers/spi/spi-imx.c | 2 +- drivers/spi/spi-mux.c | 1 + fs/btrfs/qgroup.c | 4 +- fs/dcache.c | 31 ++--- fs/file.c | 4 +- fs/hfsplus/xattr.c | 2 +- fs/jfs/xattr.c | 23 +++- fs/locks.c | 18 ++- fs/ntfs3/fslog.c | 6 +- fs/ocfs2/dir.c | 46 ++++--- include/linux/compiler.h | 6 + include/linux/minmax.h | 87 +++++++++---- include/linux/overflow.h | 1 - include/linux/trace_events.h | 2 - include/scsi/scsi_host.h | 2 + include/sound/dmaengine_pcm.h | 1 + kernel/bpf/ringbuf.c | 30 ++++- mm/damon/core.c | 21 ++- net/bluetooth/hci_core.c | 4 + net/ipv4/af_inet.c | 4 +- net/ipv6/ila/ila_lwt.c | 7 +- net/ipv6/rpl_iptunnel.c | 14 +- net/mac80211/ieee80211_i.h | 2 + net/mac80211/main.c | 11 +- net/mac80211/mesh.c | 1 + net/mac80211/scan.c | 14 +- net/mac80211/util.c | 4 + net/mac802154/tx.c | 8 +- net/wireless/scan.c | 8 +- samples/Kconfig | 9 ++ samples/Makefile | 1 + samples/fanotify/.gitignore | 1 + samples/fanotify/Makefile | 5 + samples/fanotify/fs-monitor.c | 142 +++++++++++++++++++++ scripts/gcc-plugins/gcc-common.h | 4 + scripts/kconfig/expr.c | 29 ----- scripts/kconfig/expr.h | 1 - scripts/kconfig/gconf.c | 3 +- scripts/kconfig/menu.c | 2 - sound/core/pcm_dmaengine.c | 26 ++++ sound/pci/hda/patch_realtek.c | 7 + sound/soc/intel/boards/bytcr_rt5640.c | 11 ++ sound/soc/soc-generic-dmaengine-pcm.c | 8 ++ sound/soc/ti/davinci-mcasp.c | 9 +- sound/soc/ti/omap-hdmi.c | 6 +- tools/power/cpupower/utils/helpers/amd.c | 26 +++- tools/testing/selftests/openat2/openat2_test.c | 1 + tools/testing/selftests/vDSO/parse_vdso.c | 16 ++- .../selftests/vDSO/vdso_standalone_test_x86.c | 18 ++- 102 files changed, 867 insertions(+), 365 deletions(-)

1 year, 4 months

8
7
0 0

[PATCH 4.19 00/32] 4.19.319-rc2 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.319 release. There are 32 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sun, 28 Jul 2024 07:05:18 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.319-r… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.19.319-rc2 Jann Horn <jannh(a)google.com> filelock: Fix fcntl/close race recovery compat path lei lu <llfamsec(a)gmail.com> jfs: don't walk off the end of ealist lei lu <llfamsec(a)gmail.com> ocfs2: add bounds checking to ocfs2_check_dir_entry() Paolo Abeni <pabeni(a)redhat.com> net: relax socket state check at accept time. Kuan-Wei Chiu <visitorckw(a)gmail.com> ACPI: processor_idle: Fix invalid comparison with insertion sort for latency Masahiro Yamada <masahiroy(a)kernel.org> ARM: 9324/1: fix get_user() broken with veneer Jann Horn <jannh(a)google.com> filelock: Remove locks reliably when fcntl/close race is detected Edward Adam Davis <eadavis(a)qq.com> hfsplus: fix uninit-value in copy_name John Hubbard <jhubbard(a)nvidia.com> selftests/vDSO: fix clang build errors and warnings Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> spi: imx: Don't expect DMA for i.MX{25,35,50,51,53} cspi devices Christian Brauner <brauner(a)kernel.org> fs: better handle deep ancestor chains in is_subdir() Tetsuo Handa <penguin-kernel(a)I-love.SAKURA.ne.jp> Bluetooth: hci_core: cancel all works upon hci_unregister_dev() Yunshui Jiang <jiangyunshui(a)kylinos.cn> net: mac802154: Fix racy device stats updates by DEV_STATS_INC() and DEV_STATS_ADD() Daniele Palmas <dnlplm(a)gmail.com> net: usb: qmi_wwan: add Telit FN912 compositions Shengjiu Wang <shengjiu.wang(a)nxp.com> ALSA: dmaengine_pcm: terminate dmaengine before synchronize Heiko Carstens <hca(a)linux.ibm.com> s390/sclp: Fix sclp_init() cleanup on failure Chen Ni <nichen(a)iscas.ac.cn> can: kvaser_usb: fix return value for hif_usb_send_regout Thomas GENTY <tomlohave(a)gmail.com> bytcr_rt5640 : inverse jack detect for Archos 101 cesium Jonathan Denose <jdenose(a)google.com> Input: elantech - fix touchpad state on resume for Lenovo N24 Dmitry Antipov <dmantipov(a)yandex.ru> wifi: cfg80211: wext: add extra SIOCSIWSCAN data check Alexander Usyskin <alexander.usyskin(a)intel.com> mei: demote client disconnect warning on suspend to debug Yuntao Wang <yuntao.wang(a)linux.dev> fs/file: fix the check in find_next_fd() Masahiro Yamada <masahiroy(a)kernel.org> kconfig: remove wrong expr_trans_bool() Masahiro Yamada <masahiroy(a)kernel.org> kconfig: gconf: give a proper initial state to the Save button Eric Dumazet <edumazet(a)google.com> ila: block BH in ila_output() Hans de Goede <hdegoede(a)redhat.com> Input: silead - Always support 10 fingers Dmitry Antipov <dmantipov(a)yandex.ru> wifi: mac80211: fix UBSAN noise in ieee80211_prep_hw_scan() Nicolas Escande <nico.escande(a)gmail.com> wifi: mac80211: mesh: init nonpeer_pm to active by default in mesh sdata Armin Wolf <W_Armin(a)gmx.de> ACPI: EC: Avoid returning AE_OK on errors in address space handler Armin Wolf <W_Armin(a)gmx.de> ACPI: EC: Abort address space access upon error Saurav Kashyap <skashyap(a)marvell.com> scsi: qedf: Set qed_slowpath_params to zero before use Kees Cook <keescook(a)chromium.org> gcc-plugins: Rename last_stmt() for GCC 14+ ------------- Diffstat: Makefile | 4 +- arch/arm/include/asm/uaccess.h | 14 +------ drivers/acpi/ec.c | 9 ++++- drivers/acpi/processor_idle.c | 40 ++++++++----------- drivers/input/mouse/elantech.c | 31 +++++++++++++++ drivers/input/touchscreen/silead.c | 19 +++------ drivers/misc/mei/main.c | 2 +- drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c | 2 +- drivers/net/usb/qmi_wwan.c | 2 + drivers/s390/char/sclp.c | 1 + drivers/scsi/qedf/qedf_main.c | 1 + drivers/spi/spi-imx.c | 2 +- fs/dcache.c | 31 +++++++-------- fs/file.c | 4 +- fs/hfsplus/xattr.c | 2 +- fs/jfs/xattr.c | 23 +++++++++-- fs/locks.c | 18 ++++----- fs/ocfs2/dir.c | 46 ++++++++++++++-------- net/bluetooth/hci_core.c | 4 ++ net/ipv4/af_inet.c | 4 +- net/ipv6/ila/ila_lwt.c | 7 +++- net/mac80211/mesh.c | 1 + net/mac80211/scan.c | 14 +++++-- net/mac802154/tx.c | 8 ++-- net/wireless/scan.c | 8 +++- scripts/gcc-plugins/gcc-common.h | 4 ++ scripts/kconfig/expr.c | 29 -------------- scripts/kconfig/expr.h | 1 - scripts/kconfig/gconf.c | 3 +- scripts/kconfig/menu.c | 2 - sound/core/pcm_dmaengine.c | 12 ++++++ sound/soc/intel/boards/bytcr_rt5640.c | 11 ++++++ tools/testing/selftests/vDSO/parse_vdso.c | 16 +++++--- .../selftests/vDSO/vdso_standalone_test_x86.c | 18 ++++++++- 34 files changed, 233 insertions(+), 160 deletions(-)

1 year, 4 months

4
3
0 0

[PATCH 5.10 00/59] 5.10.223-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.10.223 release. There are 59 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat, 27 Jul 2024 14:27:16 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.223-r… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 5.10.223-rc1 Jann Horn <jannh(a)google.com> filelock: Fix fcntl/close race recovery compat path Shengjiu Wang <shengjiu.wang(a)nxp.com> ALSA: pcm_dmaengine: Don't synchronize DMA channel when DMA is paused Krishna Kurapati <quic_kriskura(a)quicinc.com> arm64: dts: qcom: msm8996: Disable SS instance in Parkmode for USB Seunghun Han <kkamagui(a)gmail.com> ALSA: hda/realtek: Fix the speaker output on Samsung Galaxy Book Pro 360 Edson Juliano Drosdeck <edson.drosdeck(a)gmail.com> ALSA: hda/realtek: Enable headset mic on Positivo SU C1400 lei lu <llfamsec(a)gmail.com> jfs: don't walk off the end of ealist lei lu <llfamsec(a)gmail.com> ocfs2: add bounds checking to ocfs2_check_dir_entry() Paolo Abeni <pabeni(a)redhat.com> net: relax socket state check at accept time. Dan Carpenter <dan.carpenter(a)linaro.org> drm/amdgpu: Fix signedness bug in sdma_v4_0_process_trap_irq() Gabriel Krisman Bertazi <krisman(a)collabora.com> ext4: Send notifications on error Gabriel Krisman Bertazi <krisman(a)collabora.com> ext4: fix error code saved on super block during file system abort Bart Van Assche <bvanassche(a)acm.org> scsi: core: Fix a use-after-free Jason Xing <kernelxing(a)tencent.com> bpf, skmsg: Fix NULL pointer dereference in sk_psock_skb_ingress_enqueue Daniel Borkmann <daniel(a)iogearbox.net> bpf: Fix overrunning reservations in ringbuf Kuan-Wei Chiu <visitorckw(a)gmail.com> ACPI: processor_idle: Fix invalid comparison with insertion sort for latency Masahiro Yamada <masahiroy(a)kernel.org> ARM: 9324/1: fix get_user() broken with veneer David Lechner <dlechner(a)baylibre.com> spi: mux: set ctlr->bits_per_word_mask Edward Adam Davis <eadavis(a)qq.com> hfsplus: fix uninit-value in copy_name John Hubbard <jhubbard(a)nvidia.com> selftests/vDSO: fix clang build errors and warnings Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> spi: imx: Don't expect DMA for i.MX{25,35,50,51,53} cspi devices Christian Brauner <brauner(a)kernel.org> fs: better handle deep ancestor chains in is_subdir() Tetsuo Handa <penguin-kernel(a)I-love.SAKURA.ne.jp> Bluetooth: hci_core: cancel all works upon hci_unregister_dev() Xingui Yang <yangxingui(a)huawei.com> scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed Ganesh Goudar <ganeshgr(a)linux.ibm.com> powerpc/eeh: avoid possible crash when edev->pdev changes Anjali K <anjalik(a)linux.ibm.com> powerpc/pseries: Whitelist dtl slub object for copying to userspace Yunshui Jiang <jiangyunshui(a)kylinos.cn> net: mac802154: Fix racy device stats updates by DEV_STATS_INC() and DEV_STATS_ADD() Daniele Palmas <dnlplm(a)gmail.com> net: usb: qmi_wwan: add Telit FN912 compositions Shengjiu Wang <shengjiu.wang(a)nxp.com> ALSA: dmaengine_pcm: terminate dmaengine before synchronize Aivaz Latypov <reichaivaz(a)gmail.com> ALSA: hda/relatek: Enable Mute LED on HP Laptop 15-gw0xxx Filipe Manana <fdmanana(a)suse.com> btrfs: qgroup: fix quota root leak after quota disable failure Heiko Carstens <hca(a)linux.ibm.com> s390/sclp: Fix sclp_init() cleanup on failure Chen Ni <nichen(a)iscas.ac.cn> can: kvaser_usb: fix return value for hif_usb_send_regout Primoz Fiser <primoz.fiser(a)norik.com> ASoC: ti: omap-hdmi: Fix too long driver name Jai Luthra <j-luthra(a)ti.com> ASoC: ti: davinci-mcasp: Set min period size using FIFO config Jai Luthra <j-luthra(a)ti.com> ALSA: dmaengine: Synchronize dma channel after drop() Thomas GENTY <tomlohave(a)gmail.com> bytcr_rt5640 : inverse jack detect for Archos 101 cesium Tobias Jakobi <tjakobi(a)math.uni-bielefeld.de> Input: i8042 - add Ayaneo Kun to i8042 quirk table Jonathan Denose <jdenose(a)google.com> Input: elantech - fix touchpad state on resume for Lenovo N24 Arnd Bergmann <arnd(a)arndb.de> mips: fix compat_sys_lseek syscall Kailang Yang <kailang(a)realtek.com> ALSA: hda/realtek: Add more codec ID to no shutup pins list Michael Ellerman <mpe(a)ellerman.id.au> KVM: PPC: Book3S HV: Prevent UAF in kvm_spapr_tce_attach_iommu_group() Dmitry Antipov <dmantipov(a)yandex.ru> wifi: cfg80211: wext: add extra SIOCSIWSCAN data check Alexander Usyskin <alexander.usyskin(a)intel.com> mei: demote client disconnect warning on suspend to debug Yuntao Wang <yuntao.wang(a)linux.dev> fs/file: fix the check in find_next_fd() Masahiro Yamada <masahiroy(a)kernel.org> kconfig: remove wrong expr_trans_bool() Masahiro Yamada <masahiroy(a)kernel.org> kconfig: gconf: give a proper initial state to the Save button Andreas Hindborg <a.hindborg(a)samsung.com> null_blk: fix validation of block size Wei Li <liwei391(a)huawei.com> arm64: armv8_deprecated: Fix warning in isndep cpuhp starting process Eric Dumazet <edumazet(a)google.com> ila: block BH in ila_output() Eric Dumazet <edumazet(a)google.com> net: ipv6: rpl_iptunnel: block BH in rpl_output() and rpl_input() Hans de Goede <hdegoede(a)redhat.com> Input: silead - Always support 10 fingers Michael Ellerman <mpe(a)ellerman.id.au> selftests/openat2: Fix build warnings on ppc64 Dmitry Antipov <dmantipov(a)yandex.ru> wifi: mac80211: fix UBSAN noise in ieee80211_prep_hw_scan() Nicolas Escande <nico.escande(a)gmail.com> wifi: mac80211: mesh: init nonpeer_pm to active by default in mesh sdata Armin Wolf <W_Armin(a)gmx.de> ACPI: EC: Avoid returning AE_OK on errors in address space handler Armin Wolf <W_Armin(a)gmx.de> ACPI: EC: Abort address space access upon error Saurav Kashyap <skashyap(a)marvell.com> scsi: qedf: Set qed_slowpath_params to zero before use Jann Horn <jannh(a)google.com> filelock: Remove locks reliably when fcntl/close race is detected Kees Cook <keescook(a)chromium.org> gcc-plugins: Rename last_stmt() for GCC 14+ ------------- Diffstat: Makefile | 4 +- arch/arm/include/asm/uaccess.h | 14 +------ arch/arm64/boot/dts/qcom/msm8996.dtsi | 1 + arch/arm64/kernel/armv8_deprecated.c | 3 ++ arch/mips/kernel/syscalls/syscall_o32.tbl | 2 +- arch/powerpc/kernel/eeh_pe.c | 7 +++- arch/powerpc/kvm/book3s_64_vio.c | 18 ++++++--- arch/powerpc/platforms/pseries/setup.c | 4 +- drivers/acpi/ec.c | 9 ++++- drivers/acpi/processor_idle.c | 40 ++++++++----------- drivers/block/null_blk/main.c | 4 +- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 +- drivers/input/mouse/elantech.c | 31 +++++++++++++++ drivers/input/serio/i8042-acpipnpio.h | 18 ++++++++- drivers/input/touchscreen/silead.c | 19 +++------ drivers/misc/mei/main.c | 2 +- drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c | 2 +- drivers/net/usb/qmi_wwan.c | 2 + drivers/s390/char/sclp.c | 1 + drivers/scsi/hosts.c | 16 ++++++-- drivers/scsi/libsas/sas_internal.h | 14 +++++++ drivers/scsi/qedf/qedf_main.c | 1 + drivers/scsi/scsi_lib.c | 6 ++- drivers/scsi/scsi_priv.h | 2 +- drivers/scsi/scsi_scan.c | 1 + drivers/scsi/scsi_sysfs.c | 1 + drivers/spi/spi-imx.c | 2 +- drivers/spi/spi-mux.c | 1 + fs/btrfs/qgroup.c | 4 +- fs/dcache.c | 31 +++++++-------- fs/ext4/super.c | 9 ++++- fs/file.c | 4 +- fs/hfsplus/xattr.c | 2 +- fs/jfs/xattr.c | 23 +++++++++-- fs/locks.c | 18 ++++----- fs/ocfs2/dir.c | 46 ++++++++++++++-------- include/linux/skmsg.h | 2 + include/scsi/scsi_host.h | 2 + include/sound/dmaengine_pcm.h | 1 + kernel/bpf/ringbuf.c | 30 +++++++++++--- net/bluetooth/hci_core.c | 4 ++ net/ipv4/af_inet.c | 4 +- net/ipv6/ila/ila_lwt.c | 7 +++- net/ipv6/rpl_iptunnel.c | 14 +++---- net/mac80211/mesh.c | 1 + net/mac80211/scan.c | 14 +++++-- net/mac802154/tx.c | 8 ++-- net/wireless/scan.c | 8 +++- scripts/gcc-plugins/gcc-common.h | 4 ++ scripts/kconfig/expr.c | 29 -------------- scripts/kconfig/expr.h | 1 - scripts/kconfig/gconf.c | 3 +- scripts/kconfig/menu.c | 2 - sound/core/pcm_dmaengine.c | 26 ++++++++++++ sound/pci/hda/patch_realtek.c | 7 ++++ sound/soc/intel/boards/bytcr_rt5640.c | 11 ++++++ sound/soc/soc-generic-dmaengine-pcm.c | 8 ++++ sound/soc/ti/davinci-mcasp.c | 9 ++++- sound/soc/ti/omap-hdmi.c | 6 +-- tools/testing/selftests/openat2/openat2_test.c | 1 + tools/testing/selftests/vDSO/parse_vdso.c | 16 +++++--- .../selftests/vDSO/vdso_standalone_test_x86.c | 18 ++++++++- 62 files changed, 396 insertions(+), 204 deletions(-)

1 year, 4 months

7
65
0 0

[PATCH 5.4 00/44] 5.4.281-rc2 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.4.281 release. There are 44 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sun, 28 Jul 2024 07:05:34 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.281-rc… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 5.4.281-rc2 Si-Wei Liu <si-wei.liu(a)oracle.com> tap: add missing verification for short frame Dongli Zhang <dongli.zhang(a)oracle.com> tun: add missing verification for short frame Jann Horn <jannh(a)google.com> filelock: Fix fcntl/close race recovery compat path Edson Juliano Drosdeck <edson.drosdeck(a)gmail.com> ALSA: hda/realtek: Enable headset mic on Positivo SU C1400 lei lu <llfamsec(a)gmail.com> jfs: don't walk off the end of ealist lei lu <llfamsec(a)gmail.com> ocfs2: add bounds checking to ocfs2_check_dir_entry() Paolo Abeni <pabeni(a)redhat.com> net: relax socket state check at accept time. Dan Carpenter <dan.carpenter(a)linaro.org> drm/amdgpu: Fix signedness bug in sdma_v4_0_process_trap_irq() Kuan-Wei Chiu <visitorckw(a)gmail.com> ACPI: processor_idle: Fix invalid comparison with insertion sort for latency Masahiro Yamada <masahiroy(a)kernel.org> ARM: 9324/1: fix get_user() broken with veneer Edward Adam Davis <eadavis(a)qq.com> hfsplus: fix uninit-value in copy_name John Hubbard <jhubbard(a)nvidia.com> selftests/vDSO: fix clang build errors and warnings Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> spi: imx: Don't expect DMA for i.MX{25,35,50,51,53} cspi devices Christian Brauner <brauner(a)kernel.org> fs: better handle deep ancestor chains in is_subdir() Tetsuo Handa <penguin-kernel(a)I-love.SAKURA.ne.jp> Bluetooth: hci_core: cancel all works upon hci_unregister_dev() Xingui Yang <yangxingui(a)huawei.com> scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed Ganesh Goudar <ganeshgr(a)linux.ibm.com> powerpc/eeh: avoid possible crash when edev->pdev changes Anjali K <anjalik(a)linux.ibm.com> powerpc/pseries: Whitelist dtl slub object for copying to userspace Yunshui Jiang <jiangyunshui(a)kylinos.cn> net: mac802154: Fix racy device stats updates by DEV_STATS_INC() and DEV_STATS_ADD() Daniele Palmas <dnlplm(a)gmail.com> net: usb: qmi_wwan: add Telit FN912 compositions Shengjiu Wang <shengjiu.wang(a)nxp.com> ALSA: dmaengine_pcm: terminate dmaengine before synchronize Heiko Carstens <hca(a)linux.ibm.com> s390/sclp: Fix sclp_init() cleanup on failure Chen Ni <nichen(a)iscas.ac.cn> can: kvaser_usb: fix return value for hif_usb_send_regout Primoz Fiser <primoz.fiser(a)norik.com> ASoC: ti: omap-hdmi: Fix too long driver name Jai Luthra <j-luthra(a)ti.com> ASoC: ti: davinci-mcasp: Set min period size using FIFO config Thomas GENTY <tomlohave(a)gmail.com> bytcr_rt5640 : inverse jack detect for Archos 101 cesium Jonathan Denose <jdenose(a)google.com> Input: elantech - fix touchpad state on resume for Lenovo N24 Arnd Bergmann <arnd(a)arndb.de> mips: fix compat_sys_lseek syscall Kailang Yang <kailang(a)realtek.com> ALSA: hda/realtek: Add more codec ID to no shutup pins list Michael Ellerman <mpe(a)ellerman.id.au> KVM: PPC: Book3S HV: Prevent UAF in kvm_spapr_tce_attach_iommu_group() Dmitry Antipov <dmantipov(a)yandex.ru> wifi: cfg80211: wext: add extra SIOCSIWSCAN data check Alexander Usyskin <alexander.usyskin(a)intel.com> mei: demote client disconnect warning on suspend to debug Yuntao Wang <yuntao.wang(a)linux.dev> fs/file: fix the check in find_next_fd() Masahiro Yamada <masahiroy(a)kernel.org> kconfig: remove wrong expr_trans_bool() Masahiro Yamada <masahiroy(a)kernel.org> kconfig: gconf: give a proper initial state to the Save button Eric Dumazet <edumazet(a)google.com> ila: block BH in ila_output() Hans de Goede <hdegoede(a)redhat.com> Input: silead - Always support 10 fingers Dmitry Antipov <dmantipov(a)yandex.ru> wifi: mac80211: fix UBSAN noise in ieee80211_prep_hw_scan() Nicolas Escande <nico.escande(a)gmail.com> wifi: mac80211: mesh: init nonpeer_pm to active by default in mesh sdata Armin Wolf <W_Armin(a)gmx.de> ACPI: EC: Avoid returning AE_OK on errors in address space handler Armin Wolf <W_Armin(a)gmx.de> ACPI: EC: Abort address space access upon error Saurav Kashyap <skashyap(a)marvell.com> scsi: qedf: Set qed_slowpath_params to zero before use Jann Horn <jannh(a)google.com> filelock: Remove locks reliably when fcntl/close race is detected Kees Cook <keescook(a)chromium.org> gcc-plugins: Rename last_stmt() for GCC 14+ ------------- Diffstat: Makefile | 4 +- arch/arm/include/asm/uaccess.h | 14 +------ arch/mips/kernel/syscalls/syscall_o32.tbl | 2 +- arch/powerpc/kernel/eeh_pe.c | 7 +++- arch/powerpc/kvm/book3s_64_vio.c | 18 ++++++--- arch/powerpc/platforms/pseries/setup.c | 4 +- drivers/acpi/ec.c | 9 ++++- drivers/acpi/processor_idle.c | 40 ++++++++----------- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 +- drivers/input/mouse/elantech.c | 31 +++++++++++++++ drivers/input/touchscreen/silead.c | 19 +++------ drivers/misc/mei/main.c | 2 +- drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c | 2 +- drivers/net/tap.c | 5 +++ drivers/net/tun.c | 3 ++ drivers/net/usb/qmi_wwan.c | 2 + drivers/s390/char/sclp.c | 1 + drivers/scsi/libsas/sas_internal.h | 14 +++++++ drivers/scsi/qedf/qedf_main.c | 1 + drivers/spi/spi-imx.c | 2 +- fs/dcache.c | 31 +++++++-------- fs/file.c | 4 +- fs/hfsplus/xattr.c | 2 +- fs/jfs/xattr.c | 23 +++++++++-- fs/locks.c | 18 ++++----- fs/ocfs2/dir.c | 46 ++++++++++++++-------- net/bluetooth/hci_core.c | 4 ++ net/ipv4/af_inet.c | 4 +- net/ipv6/ila/ila_lwt.c | 7 +++- net/mac80211/mesh.c | 1 + net/mac80211/scan.c | 14 +++++-- net/mac802154/tx.c | 8 ++-- net/wireless/scan.c | 8 +++- scripts/gcc-plugins/gcc-common.h | 4 ++ scripts/kconfig/expr.c | 29 -------------- scripts/kconfig/expr.h | 1 - scripts/kconfig/gconf.c | 3 +- scripts/kconfig/menu.c | 2 - sound/core/pcm_dmaengine.c | 12 ++++++ sound/pci/hda/patch_realtek.c | 5 +++ sound/soc/intel/boards/bytcr_rt5640.c | 11 ++++++ sound/soc/ti/davinci-mcasp.c | 9 ++++- sound/soc/ti/omap-hdmi.c | 6 +-- tools/testing/selftests/vDSO/parse_vdso.c | 16 +++++--- .../selftests/vDSO/vdso_standalone_test_x86.c | 18 ++++++++- 45 files changed, 290 insertions(+), 178 deletions(-)

1 year, 4 months

5
4
0 0

[PATCH 4.19 00/33] 4.19.319-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.319 release. There are 33 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat, 27 Jul 2024 14:27:16 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.319-r… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.19.319-rc1 Jann Horn <jannh(a)google.com> filelock: Fix fcntl/close race recovery compat path lei lu <llfamsec(a)gmail.com> jfs: don't walk off the end of ealist lei lu <llfamsec(a)gmail.com> ocfs2: add bounds checking to ocfs2_check_dir_entry() Paolo Abeni <pabeni(a)redhat.com> net: relax socket state check at accept time. Kuan-Wei Chiu <visitorckw(a)gmail.com> ACPI: processor_idle: Fix invalid comparison with insertion sort for latency Masahiro Yamada <masahiroy(a)kernel.org> ARM: 9324/1: fix get_user() broken with veneer Jann Horn <jannh(a)google.com> filelock: Remove locks reliably when fcntl/close race is detected Edward Adam Davis <eadavis(a)qq.com> hfsplus: fix uninit-value in copy_name John Hubbard <jhubbard(a)nvidia.com> selftests/vDSO: fix clang build errors and warnings Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> spi: imx: Don't expect DMA for i.MX{25,35,50,51,53} cspi devices Christian Brauner <brauner(a)kernel.org> fs: better handle deep ancestor chains in is_subdir() Tetsuo Handa <penguin-kernel(a)I-love.SAKURA.ne.jp> Bluetooth: hci_core: cancel all works upon hci_unregister_dev() Yunshui Jiang <jiangyunshui(a)kylinos.cn> net: mac802154: Fix racy device stats updates by DEV_STATS_INC() and DEV_STATS_ADD() Daniele Palmas <dnlplm(a)gmail.com> net: usb: qmi_wwan: add Telit FN912 compositions Shengjiu Wang <shengjiu.wang(a)nxp.com> ALSA: dmaengine_pcm: terminate dmaengine before synchronize Heiko Carstens <hca(a)linux.ibm.com> s390/sclp: Fix sclp_init() cleanup on failure Ian Ray <ian.ray(a)gehealthcare.com> gpio: pca953x: fix pca953x_irq_bus_sync_unlock race Chen Ni <nichen(a)iscas.ac.cn> can: kvaser_usb: fix return value for hif_usb_send_regout Thomas GENTY <tomlohave(a)gmail.com> bytcr_rt5640 : inverse jack detect for Archos 101 cesium Jonathan Denose <jdenose(a)google.com> Input: elantech - fix touchpad state on resume for Lenovo N24 Dmitry Antipov <dmantipov(a)yandex.ru> wifi: cfg80211: wext: add extra SIOCSIWSCAN data check Alexander Usyskin <alexander.usyskin(a)intel.com> mei: demote client disconnect warning on suspend to debug Yuntao Wang <yuntao.wang(a)linux.dev> fs/file: fix the check in find_next_fd() Masahiro Yamada <masahiroy(a)kernel.org> kconfig: remove wrong expr_trans_bool() Masahiro Yamada <masahiroy(a)kernel.org> kconfig: gconf: give a proper initial state to the Save button Eric Dumazet <edumazet(a)google.com> ila: block BH in ila_output() Hans de Goede <hdegoede(a)redhat.com> Input: silead - Always support 10 fingers Dmitry Antipov <dmantipov(a)yandex.ru> wifi: mac80211: fix UBSAN noise in ieee80211_prep_hw_scan() Nicolas Escande <nico.escande(a)gmail.com> wifi: mac80211: mesh: init nonpeer_pm to active by default in mesh sdata Armin Wolf <W_Armin(a)gmx.de> ACPI: EC: Avoid returning AE_OK on errors in address space handler Armin Wolf <W_Armin(a)gmx.de> ACPI: EC: Abort address space access upon error Saurav Kashyap <skashyap(a)marvell.com> scsi: qedf: Set qed_slowpath_params to zero before use Kees Cook <keescook(a)chromium.org> gcc-plugins: Rename last_stmt() for GCC 14+ ------------- Diffstat: Makefile | 4 +- arch/arm/include/asm/uaccess.h | 14 +------ drivers/acpi/ec.c | 9 ++++- drivers/acpi/processor_idle.c | 40 ++++++++----------- drivers/gpio/gpio-pca953x.c | 2 + drivers/input/mouse/elantech.c | 31 +++++++++++++++ drivers/input/touchscreen/silead.c | 19 +++------ drivers/misc/mei/main.c | 2 +- drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c | 2 +- drivers/net/usb/qmi_wwan.c | 2 + drivers/s390/char/sclp.c | 1 + drivers/scsi/qedf/qedf_main.c | 1 + drivers/spi/spi-imx.c | 2 +- fs/dcache.c | 31 +++++++-------- fs/file.c | 4 +- fs/hfsplus/xattr.c | 2 +- fs/jfs/xattr.c | 23 +++++++++-- fs/locks.c | 18 ++++----- fs/ocfs2/dir.c | 46 ++++++++++++++-------- net/bluetooth/hci_core.c | 4 ++ net/ipv4/af_inet.c | 4 +- net/ipv6/ila/ila_lwt.c | 7 +++- net/mac80211/mesh.c | 1 + net/mac80211/scan.c | 14 +++++-- net/mac802154/tx.c | 8 ++-- net/wireless/scan.c | 8 +++- scripts/gcc-plugins/gcc-common.h | 4 ++ scripts/kconfig/expr.c | 29 -------------- scripts/kconfig/expr.h | 1 - scripts/kconfig/gconf.c | 3 +- scripts/kconfig/menu.c | 2 - sound/core/pcm_dmaengine.c | 12 ++++++ sound/soc/intel/boards/bytcr_rt5640.c | 11 ++++++ tools/testing/selftests/vDSO/parse_vdso.c | 16 +++++--- .../selftests/vDSO/vdso_standalone_test_x86.c | 18 ++++++++- 35 files changed, 235 insertions(+), 160 deletions(-)

1 year, 4 months

5
37
0 0

[PATCH 5.4 00/43] 5.4.281-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.4.281 release. There are 43 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat, 27 Jul 2024 14:27:16 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.281-rc… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 5.4.281-rc1 Jann Horn <jannh(a)google.com> filelock: Fix fcntl/close race recovery compat path Edson Juliano Drosdeck <edson.drosdeck(a)gmail.com> ALSA: hda/realtek: Enable headset mic on Positivo SU C1400 lei lu <llfamsec(a)gmail.com> jfs: don't walk off the end of ealist lei lu <llfamsec(a)gmail.com> ocfs2: add bounds checking to ocfs2_check_dir_entry() Paolo Abeni <pabeni(a)redhat.com> net: relax socket state check at accept time. Dan Carpenter <dan.carpenter(a)linaro.org> drm/amdgpu: Fix signedness bug in sdma_v4_0_process_trap_irq() Kuan-Wei Chiu <visitorckw(a)gmail.com> ACPI: processor_idle: Fix invalid comparison with insertion sort for latency Masahiro Yamada <masahiroy(a)kernel.org> ARM: 9324/1: fix get_user() broken with veneer Edward Adam Davis <eadavis(a)qq.com> hfsplus: fix uninit-value in copy_name John Hubbard <jhubbard(a)nvidia.com> selftests/vDSO: fix clang build errors and warnings Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> spi: imx: Don't expect DMA for i.MX{25,35,50,51,53} cspi devices Christian Brauner <brauner(a)kernel.org> fs: better handle deep ancestor chains in is_subdir() Tetsuo Handa <penguin-kernel(a)I-love.SAKURA.ne.jp> Bluetooth: hci_core: cancel all works upon hci_unregister_dev() Xingui Yang <yangxingui(a)huawei.com> scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed Ganesh Goudar <ganeshgr(a)linux.ibm.com> powerpc/eeh: avoid possible crash when edev->pdev changes Anjali K <anjalik(a)linux.ibm.com> powerpc/pseries: Whitelist dtl slub object for copying to userspace Yunshui Jiang <jiangyunshui(a)kylinos.cn> net: mac802154: Fix racy device stats updates by DEV_STATS_INC() and DEV_STATS_ADD() Daniele Palmas <dnlplm(a)gmail.com> net: usb: qmi_wwan: add Telit FN912 compositions Shengjiu Wang <shengjiu.wang(a)nxp.com> ALSA: dmaengine_pcm: terminate dmaengine before synchronize Heiko Carstens <hca(a)linux.ibm.com> s390/sclp: Fix sclp_init() cleanup on failure Ian Ray <ian.ray(a)gehealthcare.com> gpio: pca953x: fix pca953x_irq_bus_sync_unlock race Chen Ni <nichen(a)iscas.ac.cn> can: kvaser_usb: fix return value for hif_usb_send_regout Primoz Fiser <primoz.fiser(a)norik.com> ASoC: ti: omap-hdmi: Fix too long driver name Jai Luthra <j-luthra(a)ti.com> ASoC: ti: davinci-mcasp: Set min period size using FIFO config Thomas GENTY <tomlohave(a)gmail.com> bytcr_rt5640 : inverse jack detect for Archos 101 cesium Jonathan Denose <jdenose(a)google.com> Input: elantech - fix touchpad state on resume for Lenovo N24 Arnd Bergmann <arnd(a)arndb.de> mips: fix compat_sys_lseek syscall Kailang Yang <kailang(a)realtek.com> ALSA: hda/realtek: Add more codec ID to no shutup pins list Michael Ellerman <mpe(a)ellerman.id.au> KVM: PPC: Book3S HV: Prevent UAF in kvm_spapr_tce_attach_iommu_group() Dmitry Antipov <dmantipov(a)yandex.ru> wifi: cfg80211: wext: add extra SIOCSIWSCAN data check Alexander Usyskin <alexander.usyskin(a)intel.com> mei: demote client disconnect warning on suspend to debug Yuntao Wang <yuntao.wang(a)linux.dev> fs/file: fix the check in find_next_fd() Masahiro Yamada <masahiroy(a)kernel.org> kconfig: remove wrong expr_trans_bool() Masahiro Yamada <masahiroy(a)kernel.org> kconfig: gconf: give a proper initial state to the Save button Eric Dumazet <edumazet(a)google.com> ila: block BH in ila_output() Hans de Goede <hdegoede(a)redhat.com> Input: silead - Always support 10 fingers Dmitry Antipov <dmantipov(a)yandex.ru> wifi: mac80211: fix UBSAN noise in ieee80211_prep_hw_scan() Nicolas Escande <nico.escande(a)gmail.com> wifi: mac80211: mesh: init nonpeer_pm to active by default in mesh sdata Armin Wolf <W_Armin(a)gmx.de> ACPI: EC: Avoid returning AE_OK on errors in address space handler Armin Wolf <W_Armin(a)gmx.de> ACPI: EC: Abort address space access upon error Saurav Kashyap <skashyap(a)marvell.com> scsi: qedf: Set qed_slowpath_params to zero before use Jann Horn <jannh(a)google.com> filelock: Remove locks reliably when fcntl/close race is detected Kees Cook <keescook(a)chromium.org> gcc-plugins: Rename last_stmt() for GCC 14+ ------------- Diffstat: Makefile | 4 +- arch/arm/include/asm/uaccess.h | 14 +------ arch/mips/kernel/syscalls/syscall_o32.tbl | 2 +- arch/powerpc/kernel/eeh_pe.c | 7 +++- arch/powerpc/kvm/book3s_64_vio.c | 18 ++++++--- arch/powerpc/platforms/pseries/setup.c | 4 +- drivers/acpi/ec.c | 9 ++++- drivers/acpi/processor_idle.c | 40 ++++++++----------- drivers/gpio/gpio-pca953x.c | 2 + drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 +- drivers/input/mouse/elantech.c | 31 +++++++++++++++ drivers/input/touchscreen/silead.c | 19 +++------ drivers/misc/mei/main.c | 2 +- drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c | 2 +- drivers/net/usb/qmi_wwan.c | 2 + drivers/s390/char/sclp.c | 1 + drivers/scsi/libsas/sas_internal.h | 14 +++++++ drivers/scsi/qedf/qedf_main.c | 1 + drivers/spi/spi-imx.c | 2 +- fs/dcache.c | 31 +++++++-------- fs/file.c | 4 +- fs/hfsplus/xattr.c | 2 +- fs/jfs/xattr.c | 23 +++++++++-- fs/locks.c | 18 ++++----- fs/ocfs2/dir.c | 46 ++++++++++++++-------- net/bluetooth/hci_core.c | 4 ++ net/ipv4/af_inet.c | 4 +- net/ipv6/ila/ila_lwt.c | 7 +++- net/mac80211/mesh.c | 1 + net/mac80211/scan.c | 14 +++++-- net/mac802154/tx.c | 8 ++-- net/wireless/scan.c | 8 +++- scripts/gcc-plugins/gcc-common.h | 4 ++ scripts/kconfig/expr.c | 29 -------------- scripts/kconfig/expr.h | 1 - scripts/kconfig/gconf.c | 3 +- scripts/kconfig/menu.c | 2 - sound/core/pcm_dmaengine.c | 12 ++++++ sound/pci/hda/patch_realtek.c | 5 +++ sound/soc/intel/boards/bytcr_rt5640.c | 11 ++++++ sound/soc/ti/davinci-mcasp.c | 9 ++++- sound/soc/ti/omap-hdmi.c | 6 +-- tools/testing/selftests/vDSO/parse_vdso.c | 16 +++++--- .../selftests/vDSO/vdso_standalone_test_x86.c | 18 ++++++++- 44 files changed, 284 insertions(+), 178 deletions(-)

1 year, 4 months

4
47
0 0

[PATCH v7 4/8] RISC-V: Scalar unaligned access emulated on hotplug CPUs

by Jesse Taube

The check_unaligned_access_emulated() function should have been called during CPU hotplug to ensure that if all CPUs had emulated unaligned accesses, the new CPU also does. This patch adds the call to check_unaligned_access_emulated() in the hotplug path. Fixes: 55e0bf49a0d0 ("RISC-V: Probe misaligned access speed in parallel") Signed-off-by: Jesse Taube <jesse(a)rivosinc.com> Reviewed-by: Evan Green <evan(a)rivosinc.com> Cc: stable(a)vger.kernel.org --- V5 -> V6: - New patch V6 -> V7: - No changes --- arch/riscv/kernel/unaligned_access_speed.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/riscv/kernel/unaligned_access_speed.c b/arch/riscv/kernel/unaligned_access_speed.c index a9a6bcb02acf..b67db1fc3740 100644 --- a/arch/riscv/kernel/unaligned_access_speed.c +++ b/arch/riscv/kernel/unaligned_access_speed.c @@ -191,6 +191,7 @@ static int riscv_online_cpu(unsigned int cpu) if (per_cpu(misaligned_access_speed, cpu) != RISCV_HWPROBE_MISALIGNED_UNKNOWN) goto exit; + check_unaligned_access_emulated(NULL); buf = alloc_pages(GFP_KERNEL, MISALIGNED_BUFFER_ORDER); if (!buf) { pr_warn("Allocation failure, not measuring misaligned performance\n"); -- 2.45.2

1 year, 4 months

1
0
0 0

[PATCH v7 3/8] RISC-V: Check scalar unaligned access on all CPUs

by Jesse Taube

Originally, the check_unaligned_access_emulated_all_cpus function only checked the boot hart. This fixes the function to check all harts. Fixes: 71c54b3d169d ("riscv: report misaligned accesses emulation to hwprobe") Signed-off-by: Jesse Taube <jesse(a)rivosinc.com> Reviewed-by: Charlie Jenkins <charlie(a)rivosinc.com> Reviewed-by: Evan Green <evan(a)rivosinc.com> Cc: stable(a)vger.kernel.org --- V1 -> V2: - New patch V2 -> V3: - Split patch V3 -> V4: - Re-add check for a system where a heterogeneous CPU is hotplugged into a previously homogenous system. V4 -> V5: - Change work_struct *unused to work_struct *work __always_unused V5 -> V6: - Change check_unaligned_access_emulated to extern V6 -> V7: - No changes --- arch/riscv/include/asm/cpufeature.h | 2 ++ arch/riscv/kernel/traps_misaligned.c | 14 +++++++------- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/arch/riscv/include/asm/cpufeature.h b/arch/riscv/include/asm/cpufeature.h index 347805446151..3b24342c7d2a 100644 --- a/arch/riscv/include/asm/cpufeature.h +++ b/arch/riscv/include/asm/cpufeature.h @@ -8,6 +8,7 @@ #include <linux/bitmap.h> #include <linux/jump_label.h> +#include <linux/workqueue.h> #include <asm/hwcap.h> #include <asm/alternative-macros.h> #include <asm/errno.h> @@ -35,6 +36,7 @@ void riscv_user_isa_enable(void); #if defined(CONFIG_RISCV_MISALIGNED) bool check_unaligned_access_emulated_all_cpus(void); +void check_unaligned_access_emulated(struct work_struct *work __always_unused); void unaligned_emulation_finish(void); bool unaligned_ctl_available(void); DECLARE_PER_CPU(long, misaligned_access_speed); diff --git a/arch/riscv/kernel/traps_misaligned.c b/arch/riscv/kernel/traps_misaligned.c index b62d5a2f4541..bb09357778c5 100644 --- a/arch/riscv/kernel/traps_misaligned.c +++ b/arch/riscv/kernel/traps_misaligned.c @@ -526,11 +526,11 @@ int handle_misaligned_store(struct pt_regs *regs) return 0; } -static bool check_unaligned_access_emulated(int cpu) +void check_unaligned_access_emulated(struct work_struct *work __always_unused) { + int cpu = smp_processor_id(); long *mas_ptr = per_cpu_ptr(&misaligned_access_speed, cpu); unsigned long tmp_var, tmp_val; - bool misaligned_emu_detected; *mas_ptr = RISCV_HWPROBE_MISALIGNED_UNKNOWN; @@ -538,19 +538,16 @@ static bool check_unaligned_access_emulated(int cpu) " "REG_L" %[tmp], 1(%[ptr])\n" : [tmp] "=r" (tmp_val) : [ptr] "r" (&tmp_var) : "memory"); - misaligned_emu_detected = (*mas_ptr == RISCV_HWPROBE_MISALIGNED_EMULATED); /* * If unaligned_ctl is already set, this means that we detected that all * CPUS uses emulated misaligned access at boot time. If that changed * when hotplugging the new cpu, this is something we don't handle. */ - if (unlikely(unaligned_ctl && !misaligned_emu_detected)) { + if (unlikely(unaligned_ctl && (*mas_ptr != RISCV_HWPROBE_MISALIGNED_EMULATED))) { pr_crit("CPU misaligned accesses non homogeneous (expected all emulated)\n"); while (true) cpu_relax(); } - - return misaligned_emu_detected; } bool check_unaligned_access_emulated_all_cpus(void) @@ -562,8 +559,11 @@ bool check_unaligned_access_emulated_all_cpus(void) * accesses emulated since tasks requesting such control can run on any * CPU. */ + schedule_on_each_cpu(check_unaligned_access_emulated); + for_each_online_cpu(cpu) - if (!check_unaligned_access_emulated(cpu)) + if (per_cpu(misaligned_access_speed, cpu) + != RISCV_HWPROBE_MISALIGNED_EMULATED) return false; unaligned_ctl = true; -- 2.45.2

1 year, 4 months

1
0
0 0

Re: [PATCH 6.10 00/29] 6.10.2-rc1 review

by Ronald Warsow

Hi Greg no regressions here on x86_64 (RKL, Intel 11th Gen. CPU) Thanks Tested-by: Ronald Warsow <rwarsow(a)gmx.de>

1 year, 4 months

1
0
0 0

[PATCH net v4] net: usb: sr9700: fix uninitialized variable use in sr_mdio_read

by Ma Ke

It could lead to error happen because the variable res is not updated if the call to sr_share_read_word returns an error. In this particular case error code was returned and res stayed uninitialized. Same issue also applies to sr_read_reg. This can be avoided by checking the return value of sr_share_read_word and sr_read_reg, and propagating the error if the read operation failed. Found by code review. Cc: stable(a)vger.kernel.org Fixes: c9b37458e956 ("USB2NET : SR9700 : One chip USB 1.1 USB2NET SR9700Device Driver Support") Signed-off-by: Ma Ke <make24(a)iscas.ac.cn> --- Changes in v4: - added a check for sr_read_reg() as suggestions. Changes in v3: - added Cc stable line as suggestions. Changes in v2: - modified the subject as suggestions. --- drivers/net/usb/sr9700.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/sr9700.c b/drivers/net/usb/sr9700.c index 0a662e42ed96..cb7d2f798fb4 100644 --- a/drivers/net/usb/sr9700.c +++ b/drivers/net/usb/sr9700.c @@ -179,6 +179,7 @@ static int sr_mdio_read(struct net_device *netdev, int phy_id, int loc) struct usbnet *dev = netdev_priv(netdev); __le16 res; int rc = 0; + int err; if (phy_id) { netdev_dbg(netdev, "Only internal phy supported\n"); @@ -189,11 +190,17 @@ static int sr_mdio_read(struct net_device *netdev, int phy_id, int loc) if (loc == MII_BMSR) { u8 value; - sr_read_reg(dev, SR_NSR, &value); + err = sr_read_reg(dev, SR_NSR, &value); + if (err < 0) + return err; + if (value & NSR_LINKST) rc = 1; } - sr_share_read_word(dev, 1, loc, &res); + err = sr_share_read_word(dev, 1, loc, &res); + if (err < 0) + return err; + if (rc == 1) res = le16_to_cpu(res) | BMSR_LSTATUS; else -- 2.25.1

1 year, 4 months

4
3
0 0

[PATCH] erofs: fix race in z_erofs_get_gbuf()

by Gao Xiang

In z_erofs_get_gbuf(), the current task may be migrated to another CPU between `z_erofs_gbuf_id()` and `spin_lock(&gbuf->lock)`. Therefore, z_erofs_put_gbuf() will trigger the following issue which was found by stress test: <2>[772156.434168] kernel BUG at fs/erofs/zutil.c:58! .. <4>[772156.435007] <4>[772156.439237] CPU: 0 PID: 3078 Comm: stress Kdump: loaded Tainted: G E 6.10.0-rc7+ #2 <4>[772156.439239] Hardware name: Alibaba Cloud Alibaba Cloud ECS, BIOS 1.0.0 01/01/2017 <4>[772156.439241] pstate: 83400005 (Nzcv daif +PAN -UAO +TCO +DIT -SSBS BTYPE=--) <4>[772156.439243] pc : z_erofs_put_gbuf+0x64/0x70 [erofs] <4>[772156.439252] lr : z_erofs_lz4_decompress+0x600/0x6a0 [erofs] .. <6>[772156.445958] stress (3127): drop_caches: 1 <4>[772156.446120] Call trace: <4>[772156.446121] z_erofs_put_gbuf+0x64/0x70 [erofs] <4>[772156.446761] z_erofs_lz4_decompress+0x600/0x6a0 [erofs] <4>[772156.446897] z_erofs_decompress_queue+0x740/0xa10 [erofs] <4>[772156.447036] z_erofs_runqueue+0x428/0x8c0 [erofs] <4>[772156.447160] z_erofs_readahead+0x224/0x390 [erofs] .. Fixes: f36f3010f676 ("erofs: rename per-CPU buffers to global buffer pool and make it configurable") Cc: <stable(a)vger.kernel.org> # 6.10+ Cc: Chunhai Guo <guochunhai(a)vivo.com> Signed-off-by: Gao Xiang <hsiangkao(a)linux.alibaba.com> --- fs/erofs/zutil.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/erofs/zutil.c b/fs/erofs/zutil.c index b80f612867c2..9b53883e5caf 100644 --- a/fs/erofs/zutil.c +++ b/fs/erofs/zutil.c @@ -38,11 +38,13 @@ void *z_erofs_get_gbuf(unsigned int requiredpages) { struct z_erofs_gbuf *gbuf; + migrate_disable(); gbuf = &z_erofs_gbufpool[z_erofs_gbuf_id()]; spin_lock(&gbuf->lock); /* check if the buffer is too small */ if (requiredpages > gbuf->nrpages) { spin_unlock(&gbuf->lock); + migrate_enable(); /* (for sparse checker) pretend gbuf->lock is still taken */ __acquire(gbuf->lock); return NULL; @@ -57,6 +59,7 @@ void z_erofs_put_gbuf(void *ptr) __releases(gbuf->lock) gbuf = &z_erofs_gbufpool[z_erofs_gbuf_id()]; DBG_BUGON(gbuf->ptr != ptr); spin_unlock(&gbuf->lock); + migrate_enable(); } int z_erofs_gbuf_growsize(unsigned int nrpages) -- 2.43.5

1 year, 4 months

4
3
0 0

[PATCH] drm/lima: Mark simple_ondemand governor as softdep

by Dragan Simic

Lima DRM driver uses devfreq to perform DVFS, while using simple_ondemand devfreq governor by default. This causes driver initialization to fail on boot when simple_ondemand governor isn't built into the kernel statically, as a result of the missing module dependency and, consequently, the required governor module not being included in the initial ramdisk. Thus, let's mark simple_ondemand governor as a softdep for Lima, to have its kernel module included in the initial ramdisk. This is a rather longstanding issue that has forced distributions to build devfreq governors statically into their kernels, [1][2] or may have forced some users to introduce unnecessary workarounds. Having simple_ondemand marked as a softdep for Lima may not resolve this issue for all Linux distributions. In particular, it will remain unresolved for the distributions whose utilities for the initial ramdisk generation do not handle the available softdep information [3] properly yet. However, some Linux distributions already handle softdeps properly while generating their initial ramdisks, [4] and this is a prerequisite step in the right direction for the distributions that don't handle them properly yet. [1] https://gitlab.manjaro.org/manjaro-arm/packages/core/linux-pinephone/-/blob… [2] https://gitlab.com/postmarketOS/pmaports/-/blob/7f64e287e7732c9eaa029653e73… [3] https://git.kernel.org/pub/scm/utils/kernel/kmod/kmod.git/commit/?id=49d8e0… [4] https://github.com/archlinux/mkinitcpio/commit/97ac4d37aae084a050be512f6d8f… Cc: Philip Muller <philm(a)manjaro.org> Cc: Oliver Smith <ollieparanoid(a)postmarketos.org> Cc: Daniel Smith <danct12(a)disroot.org> Cc: stable(a)vger.kernel.org Fixes: 1996970773a3 ("drm/lima: Add optional devfreq and cooling device support") Signed-off-by: Dragan Simic <dsimic(a)manjaro.org> --- drivers/gpu/drm/lima/lima_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/lima/lima_drv.c b/drivers/gpu/drm/lima/lima_drv.c index 739c865b556f..10bce18b7c31 100644 --- a/drivers/gpu/drm/lima/lima_drv.c +++ b/drivers/gpu/drm/lima/lima_drv.c @@ -501,3 +501,4 @@ module_platform_driver(lima_platform_driver); MODULE_AUTHOR("Lima Project Developers"); MODULE_DESCRIPTION("Lima DRM Driver"); MODULE_LICENSE("GPL v2"); +MODULE_SOFTDEP("pre: governor_simpleondemand");

1 year, 4 months

3
14
0 0

[PATCH] drm/scheduler: Fix drm_sched_entity_set_priority()

by Tvrtko Ursulin

From: Tvrtko Ursulin <tvrtko.ursulin(a)igalia.com> Long time ago in commit b3ac17667f11 ("drm/scheduler: rework entity creation") a change was made which prevented priority changes for entities with only one assigned scheduler. The commit reduced drm_sched_entity_set_priority() to simply update the entities priority, but the run queue selection logic in drm_sched_entity_select_rq() was never able to actually change the originally assigned run queue. In practice that only affected amdgpu, being the only driver which can do dynamic priority changes. And that appears was attempted to be rectified there in 2316a86bde49 ("drm/amdgpu: change hw sched list on ctx priority override"). A few unresolved problems however were that this only fixed drm_sched_entity_set_priority() *if* drm_sched_entity_modify_sched() was called first. That was not documented anywhere. Secondly, this only works if drm_sched_entity_modify_sched() is actually called, which in amdgpu's case today is true only for gfx and compute. Priority changes for other engines with only one scheduler assigned, such as jpeg and video decode will still not work. Note that this was also noticed in 981b04d96856 ("drm/sched: improve docs around drm_sched_entity"). Completely different set of non-obvious confusion was that whereas drm_sched_entity_init() was not keeping the passed in list of schedulers (courtesy of 8c23056bdc7a ("drm/scheduler: do not keep a copy of sched list")), drm_sched_entity_modify_sched() was disagreeing with that and would simply assign the single item list. That incosistency appears to be semi-silently fixed in ac4eb83ab255 ("drm/sched: select new rq even if there is only one v3"). What was also not documented is why it was important to not keep the list of schedulers when there is only one. I suspect it could have something to do with the fact the passed in array is on stack for many callers with just one scheduler. With more than one scheduler amdgpu is the only caller, and there the container is not on the stack. Keeping a stack backed list in the entity would obviously be undefined behaviour *if* the list was kept. Amdgpu however did only stop passing in stack backed container for the more than one scheduler case in 977f7e1068be ("drm/amdgpu: allocate entities on demand"). Until then I suspect dereferencing freed stack from drm_sched_entity_select_rq() was still present. In order to untangle all that and fix priority changes this patch is bringing back the entity owned container for storing the passed in scheduler list. Container is now owned by the entity and the pointers are owned by the drivers. List of schedulers is always kept including for the one scheduler case. The patch can therefore also removes the single scheduler special case, which means that priority changes should now work (be able to change the selected run-queue) for all drivers and engines. In other words drm_sched_entity_set_priority() should now just work for all cases. To enable maintaining its own container some API calls needed to grow a capability for returning success/failure, which is a change which percolates mostly through amdgpu source. Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin(a)igalia.com> Fixes: b3ac17667f11 ("drm/scheduler: rework entity creation") References: 8c23056bdc7a ("drm/scheduler: do not keep a copy of sched list") References: 977f7e1068be ("drm/amdgpu: allocate entities on demand") References: 2316a86bde49 ("drm/amdgpu: change hw sched list on ctx priority override") References: ac4eb83ab255 ("drm/sched: select new rq even if there is only one v3") References: 981b04d96856 ("drm/sched: improve docs around drm_sched_entity") Cc: Christian König <christian.koenig(a)amd.com> Cc: Alex Deucher <alexander.deucher(a)amd.com> Cc: Luben Tuikov <ltuikov89(a)gmail.com> Cc: Matthew Brost <matthew.brost(a)intel.com> Cc: Daniel Vetter <daniel.vetter(a)ffwll.ch> Cc: amd-gfx(a)lists.freedesktop.org Cc: dri-devel(a)lists.freedesktop.org Cc: <stable(a)vger.kernel.org> # v5.6+ --- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 31 +++++--- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c | 13 +-- drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c | 3 +- drivers/gpu/drm/scheduler/sched_entity.c | 96 ++++++++++++++++------- include/drm/gpu_scheduler.h | 16 ++-- 6 files changed, 100 insertions(+), 61 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c index 5cb33ac99f70..387247f8307e 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c @@ -802,15 +802,15 @@ struct dma_fence *amdgpu_ctx_get_fence(struct amdgpu_ctx *ctx, return fence; } -static void amdgpu_ctx_set_entity_priority(struct amdgpu_ctx *ctx, - struct amdgpu_ctx_entity *aentity, - int hw_ip, - int32_t priority) +static int amdgpu_ctx_set_entity_priority(struct amdgpu_ctx *ctx, + struct amdgpu_ctx_entity *aentity, + int hw_ip, + int32_t priority) { struct amdgpu_device *adev = ctx->mgr->adev; - unsigned int hw_prio; struct drm_gpu_scheduler **scheds = NULL; - unsigned num_scheds; + unsigned int hw_prio, num_scheds; + int ret = 0; /* set sw priority */ drm_sched_entity_set_priority(&aentity->entity, @@ -822,16 +822,18 @@ static void amdgpu_ctx_set_entity_priority(struct amdgpu_ctx *ctx, hw_prio = array_index_nospec(hw_prio, AMDGPU_RING_PRIO_MAX); scheds = adev->gpu_sched[hw_ip][hw_prio].sched; num_scheds = adev->gpu_sched[hw_ip][hw_prio].num_scheds; - drm_sched_entity_modify_sched(&aentity->entity, scheds, - num_scheds); + ret = drm_sched_entity_modify_sched(&aentity->entity, scheds, + num_scheds); } + + return ret; } -void amdgpu_ctx_priority_override(struct amdgpu_ctx *ctx, - int32_t priority) +int amdgpu_ctx_priority_override(struct amdgpu_ctx *ctx, int32_t priority) { int32_t ctx_prio; unsigned i, j; + int ret; ctx->override_priority = priority; @@ -842,10 +844,15 @@ void amdgpu_ctx_priority_override(struct amdgpu_ctx *ctx, if (!ctx->entities[i][j]) continue; - amdgpu_ctx_set_entity_priority(ctx, ctx->entities[i][j], - i, ctx_prio); + ret = amdgpu_ctx_set_entity_priority(ctx, + ctx->entities[i][j], + i, ctx_prio); + if (ret) + return ret; } } + + return 0; } int amdgpu_ctx_wait_prev_fence(struct amdgpu_ctx *ctx, diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.h index 85376baaa92f..835661515e33 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.h @@ -82,7 +82,7 @@ struct dma_fence *amdgpu_ctx_get_fence(struct amdgpu_ctx *ctx, struct drm_sched_entity *entity, uint64_t seq); bool amdgpu_ctx_priority_is_valid(int32_t ctx_prio); -void amdgpu_ctx_priority_override(struct amdgpu_ctx *ctx, int32_t ctx_prio); +int amdgpu_ctx_priority_override(struct amdgpu_ctx *ctx, int32_t ctx_prio); int amdgpu_ctx_ioctl(struct drm_device *dev, void *data, struct drm_file *filp); diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c index 863b2a34b2d6..944edb7f00a2 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c @@ -54,12 +54,15 @@ static int amdgpu_sched_process_priority_override(struct amdgpu_device *adev, mgr = &fpriv->ctx_mgr; mutex_lock(&mgr->lock); - idr_for_each_entry(&mgr->ctx_handles, ctx, id) - amdgpu_ctx_priority_override(ctx, priority); + idr_for_each_entry(&mgr->ctx_handles, ctx, id) { + r = amdgpu_ctx_priority_override(ctx, priority); + if (r) + break; + } mutex_unlock(&mgr->lock); fdput(f); - return 0; + return r; } static int amdgpu_sched_context_priority_override(struct amdgpu_device *adev, @@ -88,11 +91,11 @@ static int amdgpu_sched_context_priority_override(struct amdgpu_device *adev, return -EINVAL; } - amdgpu_ctx_priority_override(ctx, priority); + r = amdgpu_ctx_priority_override(ctx, priority); amdgpu_ctx_put(ctx); fdput(f); - return 0; + return r; } int amdgpu_sched_ioctl(struct drm_device *dev, void *data, diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c index 81fb99729f37..2453decc73c7 100644 --- a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c @@ -1362,8 +1362,7 @@ static int vcn_v4_0_5_limit_sched(struct amdgpu_cs_parser *p, scheds = p->adev->gpu_sched[AMDGPU_HW_IP_VCN_ENC] [AMDGPU_RING_PRIO_0].sched; - drm_sched_entity_modify_sched(job->base.entity, scheds, 1); - return 0; + return drm_sched_entity_modify_sched(job->base.entity, scheds, 1); } static int vcn_v4_0_5_dec_msg(struct amdgpu_cs_parser *p, struct amdgpu_job *job, diff --git a/drivers/gpu/drm/scheduler/sched_entity.c b/drivers/gpu/drm/scheduler/sched_entity.c index 58c8161289fe..cb5cc65f461d 100644 --- a/drivers/gpu/drm/scheduler/sched_entity.c +++ b/drivers/gpu/drm/scheduler/sched_entity.c @@ -45,7 +45,12 @@ * @guilty: atomic_t set to 1 when a job on this queue * is found to be guilty causing a timeout * - * Note that the &sched_list must have at least one element to schedule the entity. + * Note that the &sched_list must have at least one element to schedule the + * entity. + * + * The individual drm_gpu_scheduler pointers have borrow semantics, ie. + * they must remain valid during entities lifetime, while the containing + * array can be freed after this call returns. * * For changing @priority later on at runtime see * drm_sched_entity_set_priority(). For changing the set of schedulers @@ -69,27 +74,24 @@ int drm_sched_entity_init(struct drm_sched_entity *entity, INIT_LIST_HEAD(&entity->list); entity->rq = NULL; entity->guilty = guilty; - entity->num_sched_list = num_sched_list; entity->priority = priority; - /* - * It's perfectly valid to initialize an entity without having a valid - * scheduler attached. It's just not valid to use the scheduler before it - * is initialized itself. - */ - entity->sched_list = num_sched_list > 1 ? sched_list : NULL; RCU_INIT_POINTER(entity->last_scheduled, NULL); RB_CLEAR_NODE(&entity->rb_tree_node); - if (num_sched_list && !sched_list[0]->sched_rq) { - /* Since every entry covered by num_sched_list - * should be non-NULL and therefore we warn drivers - * not to do this and to fix their DRM calling order. - */ - pr_warn("%s: called with uninitialized scheduler\n", __func__); - } else if (num_sched_list) { - /* The "priority" of an entity cannot exceed the number of run-queues of a - * scheduler. Protect against num_rqs being 0, by converting to signed. Choose - * the lowest priority available. + if (num_sched_list) { + int ret; + + ret = drm_sched_entity_modify_sched(entity, + sched_list, + num_sched_list); + if (ret) + return ret; + + /* + * The "priority" of an entity cannot exceed the number of + * run-queues of a scheduler. Protect against num_rqs being 0, + * by converting to signed. Choose the lowest priority + * available. */ if (entity->priority >= sched_list[0]->num_rqs) { drm_err(sched_list[0], "entity with out-of-bounds priority:%u num_rqs:%u\n", @@ -122,19 +124,58 @@ EXPORT_SYMBOL(drm_sched_entity_init); * existing entity->sched_list * @num_sched_list: number of drm sched in sched_list * + * The individual drm_gpu_scheduler pointers have borrow semantics, ie. + * they must remain valid during entities lifetime, while the containing + * array can be freed after this call returns. + * * Note that this must be called under the same common lock for @entity as * drm_sched_job_arm() and drm_sched_entity_push_job(), or the driver needs to * guarantee through some other means that this is never called while new jobs * can be pushed to @entity. + * + * Returns zero on success and a negative error code on failure. */ -void drm_sched_entity_modify_sched(struct drm_sched_entity *entity, - struct drm_gpu_scheduler **sched_list, - unsigned int num_sched_list) +int drm_sched_entity_modify_sched(struct drm_sched_entity *entity, + struct drm_gpu_scheduler **sched_list, + unsigned int num_sched_list) { - WARN_ON(!num_sched_list || !sched_list); + struct drm_gpu_scheduler **new, **old; + unsigned int i; - entity->sched_list = sched_list; + if (!(entity && sched_list && (num_sched_list == 0 || sched_list[0]))) + return -EINVAL; + + /* + * It's perfectly valid to initialize an entity without having a valid + * scheduler attached. It's just not valid to use the scheduler before + * it is initialized itself. + * + * Since every entry covered by num_sched_list should be non-NULL and + * therefore we warn drivers not to do this and to fix their DRM calling + * order. + */ + for (i = 0; i < num_sched_list; i++) { + if (!sched_list[i]) { + pr_warn("%s: called with uninitialized scheduler %u!\n", + __func__, i); + return -EINVAL; + } + } + + new = kmemdup_array(sched_list, + num_sched_list, + sizeof(*sched_list), + GFP_KERNEL); + if (!new) + return -ENOMEM; + + old = entity->sched_list; + entity->sched_list = new; entity->num_sched_list = num_sched_list; + + kfree(old); + + return 0; } EXPORT_SYMBOL(drm_sched_entity_modify_sched); @@ -341,6 +382,8 @@ void drm_sched_entity_fini(struct drm_sched_entity *entity) dma_fence_put(rcu_dereference_check(entity->last_scheduled, true)); RCU_INIT_POINTER(entity->last_scheduled, NULL); + + kfree(entity->sched_list); } EXPORT_SYMBOL(drm_sched_entity_fini); @@ -531,10 +574,6 @@ void drm_sched_entity_select_rq(struct drm_sched_entity *entity) struct drm_gpu_scheduler *sched; struct drm_sched_rq *rq; - /* single possible engine and already selected */ - if (!entity->sched_list) - return; - /* queue non-empty, stay on the same engine */ if (spsc_queue_count(&entity->job_queue)) return; @@ -561,9 +600,6 @@ void drm_sched_entity_select_rq(struct drm_sched_entity *entity) entity->rq = rq; } spin_unlock(&entity->rq_lock); - - if (entity->num_sched_list == 1) - entity->sched_list = NULL; } /** diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h index 5acc64954a88..09e1d063a5c0 100644 --- a/include/drm/gpu_scheduler.h +++ b/include/drm/gpu_scheduler.h @@ -110,18 +110,12 @@ struct drm_sched_entity { /** * @sched_list: * - * A list of schedulers (struct drm_gpu_scheduler). Jobs from this entity can - * be scheduled on any scheduler on this list. + * A list of schedulers (struct drm_gpu_scheduler). Jobs from this + * entity can be scheduled on any scheduler on this list. * * This can be modified by calling drm_sched_entity_modify_sched(). * Locking is entirely up to the driver, see the above function for more * details. - * - * This will be set to NULL if &num_sched_list equals 1 and @rq has been - * set already. - * - * FIXME: This means priority changes through - * drm_sched_entity_set_priority() will be lost henceforth in this case. */ struct drm_gpu_scheduler **sched_list; @@ -568,9 +562,9 @@ int drm_sched_job_add_implicit_dependencies(struct drm_sched_job *job, bool write); -void drm_sched_entity_modify_sched(struct drm_sched_entity *entity, - struct drm_gpu_scheduler **sched_list, - unsigned int num_sched_list); +int drm_sched_entity_modify_sched(struct drm_sched_entity *entity, + struct drm_gpu_scheduler **sched_list, + unsigned int num_sched_list); void drm_sched_tdr_queue_imm(struct drm_gpu_scheduler *sched); void drm_sched_job_cleanup(struct drm_sched_job *job); -- 2.44.0

1 year, 4 months

6
11
0 0

[PATCH] drm/i915: Fix possible int overflow in skl_ddi_calculate_wrpll()

by Nikita Zhandarovich

On the off chance that clock value ends up being too high (by means of skl_ddi_calculate_wrpll() having benn called with big enough value of crtc_state->port_clock * 1000), one possible consequence may be that the result will not be able to fit into signed int. Fix this, albeit unlikely, issue by first casting one of the operands to u32, then to u64, and thus avoid causing an integer overflow. Found by Linux Verification Center (linuxtesting.org) with static analysis tool SVACE. Fixes: fe70b262e781 ("drm/i915: Move a bunch of stuff into rodata from the stack") Cc: stable(a)vger.kernel.org Signed-off-by: Nikita Zhandarovich <n.zhandarovich(a)fintech.ru> --- Fixes: tag is not entirely correct, as I can't properly identify the origin with all the code movement. I opted out for using the most recent topical commit instead. drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c index 90998b037349..46d4dac6c491 100644 --- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c +++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c @@ -1683,7 +1683,7 @@ skl_ddi_calculate_wrpll(int clock /* in Hz */, }; unsigned int dco, d, i; unsigned int p0, p1, p2; - u64 afe_clock = clock * 5; /* AFE Clock is 5x Pixel clock */ + u64 afe_clock = (u64)(u32)clock * 5; /* AFE Clock is 5x Pixel clock */ for (d = 0; d < ARRAY_SIZE(dividers); d++) { for (dco = 0; dco < ARRAY_SIZE(dco_central_freq); dco++) {

1 year, 4 months

2
3
0 0

[PATCH v5.10.y v2] mtd: spinand: macronix: Add support for serial NAND flash

by Cheng Ming Lin

From: Cheng Ming Lin <chengminglin(a)mxic.com.tw> [ Upstream commit c374839f9b4475173e536d1eaddff45cb481dbdf ] Macronix NAND Flash devices are available in different configurations and densities. MX"35" means SPI NAND MX35"LF"/"UF" , LF means 3V and UF meands 1.8V MX35LF"2G" , 2G means 2Gbits MX35LF2G"E4"/"24"/"14", E4 means internal ECC and Quad I/O(x4) 24 means 8-bit ecc requirement and Quad I/O(x4) 14 means 4-bit ecc requirement and Quad I/O(x4) MX35LF2G14AC is 3V 2Gbit serial NAND flash device (without on-die ECC) https://www.mxic.com.tw/Lists/Datasheet/Attachments/7926/MX35LF2G14AC,%203V… MX35UF4G24AD/MX35UF2G24AD/MX35UF1G24AD is 1.8V 4Gbit serial NAND flash device (without on-die ECC) https://www.mxic.com.tw/Lists/Datasheet/Attachments/7980/MX35UF4G24AD,%201.… MX35UF4GE4AD/MX35UF2GE4AD/MX35UF1GE4AD are 1.8V 4G/2Gbit serial NAND flash device with 8-bit on-die ECC https://www.mxic.com.tw/Lists/Datasheet/Attachments/7983/MX35UF4GE4AD,%201.… MX35UF2GE4AC/MX35UF1GE4AC are 1.8V 2G/1Gbit serial NAND flash device with 8-bit on-die ECC https://www.mxic.com.tw/Lists/Datasheet/Attachments/7974/MX35UF2GE4AC,%201.… MX35UF2G14AC/MX35UF1G14AC are 1.8V 2G/1Gbit serial NAND flash device (without on-die ECC) https://www.mxic.com.tw/Lists/Datasheet/Attachments/7931/MX35UF2G14AC,%201.… Validated via normal(default) and QUAD mode by read, erase, read back, on Xilinx Zynq PicoZed FPGA board which included Macronix SPI Host(drivers/spi/spi-mxic.c). Cc: stable(a)vger.kernel.org # 5.10.y Signed-off-by: Cheng Ming Lin <chengminglin(a)mxic.com.tw> Signed-off-by: Jaime Liao <jaimeliao(a)mxic.com.tw> Signed-off-by: Miquel Raynal <miquel.raynal(a)bootlin.com> Link: https://lore.kernel.org/linux-mtd/1621475108-22523-1-git-send-email-jaimeli… --- drivers/mtd/nand/spi/macronix.c | 110 ++++++++++++++++++++++++++++++++ 1 file changed, 110 insertions(+) diff --git a/drivers/mtd/nand/spi/macronix.c b/drivers/mtd/nand/spi/macronix.c index 8bd3f6bf9b10..e42524687b5c 100644 --- a/drivers/mtd/nand/spi/macronix.c +++ b/drivers/mtd/nand/spi/macronix.c @@ -139,6 +139,116 @@ static const struct spinand_info macronix_spinand_table[] = { 0, SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, mx35lf1ge4ab_ecc_get_status)), + SPINAND_INFO("MX35LF2G14AC", + SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x20), + NAND_MEMORG(1, 2048, 64, 64, 2048, 40, 2, 1, 1), + NAND_ECCREQ(4, 512), + SPINAND_INFO_OP_VARIANTS(&read_cache_variants, + &write_cache_variants, + &update_cache_variants), + SPINAND_HAS_QE_BIT, + SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, + mx35lf1ge4ab_ecc_get_status)), + SPINAND_INFO("MX35UF4G24AD", + SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xb5), + NAND_MEMORG(1, 4096, 256, 64, 2048, 40, 2, 1, 1), + NAND_ECCREQ(8, 512), + SPINAND_INFO_OP_VARIANTS(&read_cache_variants, + &write_cache_variants, + &update_cache_variants), + SPINAND_HAS_QE_BIT, + SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, + mx35lf1ge4ab_ecc_get_status)), + SPINAND_INFO("MX35UF4GE4AD", + SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xb7), + NAND_MEMORG(1, 4096, 256, 64, 2048, 40, 1, 1, 1), + NAND_ECCREQ(8, 512), + SPINAND_INFO_OP_VARIANTS(&read_cache_variants, + &write_cache_variants, + &update_cache_variants), + SPINAND_HAS_QE_BIT, + SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, + mx35lf1ge4ab_ecc_get_status)), + SPINAND_INFO("MX35UF2G14AC", + SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xa0), + NAND_MEMORG(1, 2048, 64, 64, 2048, 40, 2, 1, 1), + NAND_ECCREQ(4, 512), + SPINAND_INFO_OP_VARIANTS(&read_cache_variants, + &write_cache_variants, + &update_cache_variants), + SPINAND_HAS_QE_BIT, + SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, + mx35lf1ge4ab_ecc_get_status)), + SPINAND_INFO("MX35UF2G24AD", + SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xa4), + NAND_MEMORG(1, 2048, 128, 64, 2048, 40, 2, 1, 1), + NAND_ECCREQ(8, 512), + SPINAND_INFO_OP_VARIANTS(&read_cache_variants, + &write_cache_variants, + &update_cache_variants), + SPINAND_HAS_QE_BIT, + SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, + mx35lf1ge4ab_ecc_get_status)), + SPINAND_INFO("MX35UF2GE4AD", + SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xa6), + NAND_MEMORG(1, 2048, 128, 64, 2048, 40, 1, 1, 1), + NAND_ECCREQ(8, 512), + SPINAND_INFO_OP_VARIANTS(&read_cache_variants, + &write_cache_variants, + &update_cache_variants), + SPINAND_HAS_QE_BIT, + SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, + mx35lf1ge4ab_ecc_get_status)), + SPINAND_INFO("MX35UF2GE4AC", + SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xa2), + NAND_MEMORG(1, 2048, 64, 64, 2048, 40, 1, 1, 1), + NAND_ECCREQ(4, 512), + SPINAND_INFO_OP_VARIANTS(&read_cache_variants, + &write_cache_variants, + &update_cache_variants), + SPINAND_HAS_QE_BIT, + SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, + mx35lf1ge4ab_ecc_get_status)), + SPINAND_INFO("MX35UF1G14AC", + SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x90), + NAND_MEMORG(1, 2048, 64, 64, 1024, 20, 1, 1, 1), + NAND_ECCREQ(4, 512), + SPINAND_INFO_OP_VARIANTS(&read_cache_variants, + &write_cache_variants, + &update_cache_variants), + SPINAND_HAS_QE_BIT, + SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, + mx35lf1ge4ab_ecc_get_status)), + SPINAND_INFO("MX35UF1G24AD", + SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x94), + NAND_MEMORG(1, 2048, 128, 64, 1024, 20, 1, 1, 1), + NAND_ECCREQ(8, 512), + SPINAND_INFO_OP_VARIANTS(&read_cache_variants, + &write_cache_variants, + &update_cache_variants), + SPINAND_HAS_QE_BIT, + SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, + mx35lf1ge4ab_ecc_get_status)), + SPINAND_INFO("MX35UF1GE4AD", + SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x96), + NAND_MEMORG(1, 2048, 128, 64, 1024, 20, 1, 1, 1), + NAND_ECCREQ(8, 512), + SPINAND_INFO_OP_VARIANTS(&read_cache_variants, + &write_cache_variants, + &update_cache_variants), + SPINAND_HAS_QE_BIT, + SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, + mx35lf1ge4ab_ecc_get_status)), + SPINAND_INFO("MX35UF1GE4AC", + SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x92), + NAND_MEMORG(1, 2048, 64, 64, 1024, 20, 1, 1, 1), + NAND_ECCREQ(4, 512), + SPINAND_INFO_OP_VARIANTS(&read_cache_variants, + &write_cache_variants, + &update_cache_variants), + SPINAND_HAS_QE_BIT, + SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, + mx35lf1ge4ab_ecc_get_status)), SPINAND_INFO("MX31LF1GE4BC", SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x1e), NAND_MEMORG(1, 2048, 64, 64, 1024, 20, 1, 1, 1), -- 2.25.1

1 year, 4 months

2
4
0 0

[PATCH v2] usb: gadget: core: Check for unset descriptor

by crwulff＠gmail.com

From: Chris Wulff <crwulff(a)gmail.com> Make sure the descriptor has been set before looking at maxpacket. This fixes a null pointer panic in this case. This may happen if the gadget doesn't properly set up the endpoint for the current speed, or the gadget descriptors are malformed and the descriptor for the speed/endpoint are not found. No current gadget driver is known to have this problem, but this may cause a hard-to-find bug during development of new gadgets. Fixes: 54f83b8c8ea9 ("USB: gadget: Reject endpoints with 0 maxpacket value") Cc: stable(a)vger.kernel.org Signed-off-by: Chris Wulff <crwulff(a)gmail.com> --- v2: Added WARN_ONCE message & clarification on causes v1: https://lore.kernel.org/all/20240721192048.3530097-2-crwulff@gmail.com/ --- drivers/usb/gadget/udc/core.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c index 2dfae7a17b3f..81f9140f3681 100644 --- a/drivers/usb/gadget/udc/core.c +++ b/drivers/usb/gadget/udc/core.c @@ -118,12 +118,10 @@ int usb_ep_enable(struct usb_ep *ep) goto out; /* UDC drivers can't handle endpoints with maxpacket size 0 */ - if (usb_endpoint_maxp(ep->desc) == 0) { - /* - * We should log an error message here, but we can't call - * dev_err() because there's no way to find the gadget - * given only ep. - */ + if (!ep->desc || usb_endpoint_maxp(ep->desc) == 0) { + WARN_ONCE(1, "%s: ep%d (%s) has %s\n", __func__, ep->address, ep->name, + (!ep->desc) ? "NULL descriptor" : "maxpacket 0"); + ret = -EINVAL; goto out; } -- 2.43.0

1 year, 4 months

3
3
0 0

[PATCH v3] ceph: force sending a cap update msg back to MDS for revoke op

by xiubli＠redhat.com

From: Xiubo Li <xiubli(a)redhat.com> If a client sends out a cap update dropping caps with the prior 'seq' just before an incoming cap revoke request, then the client may drop the revoke because it believes it's already released the requested capabilities. This causes the MDS to wait indefinitely for the client to respond to the revoke. It's therefore always a good idea to ack the cap revoke request with the bumped up 'seq'. Currently if the cap->issued equals to the newcaps the check_caps() will do nothing, we should force flush the caps. Cc: stable(a)vger.kernel.org Link: https://tracker.ceph.com/issues/61782 Signed-off-by: Xiubo Li <xiubli(a)redhat.com> --- V3: - Move the force check earlier V2: - Improved the patch to force send the cap update only when no caps being used. fs/ceph/caps.c | 35 ++++++++++++++++++++++++----------- fs/ceph/super.h | 7 ++++--- 2 files changed, 28 insertions(+), 14 deletions(-) diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c index 24c31f795938..672c6611d749 100644 --- a/fs/ceph/caps.c +++ b/fs/ceph/caps.c @@ -2024,6 +2024,8 @@ bool __ceph_should_report_size(struct ceph_inode_info *ci) * CHECK_CAPS_AUTHONLY - we should only check the auth cap * CHECK_CAPS_FLUSH - we should flush any dirty caps immediately, without * further delay. + * CHECK_CAPS_FLUSH_FORCE - we should flush any caps immediately, without + * further delay. */ void ceph_check_caps(struct ceph_inode_info *ci, int flags) { @@ -2105,7 +2107,7 @@ void ceph_check_caps(struct ceph_inode_info *ci, int flags) } doutc(cl, "%p %llx.%llx file_want %s used %s dirty %s " - "flushing %s issued %s revoking %s retain %s %s%s%s\n", + "flushing %s issued %s revoking %s retain %s %s%s%s%s\n", inode, ceph_vinop(inode), ceph_cap_string(file_wanted), ceph_cap_string(used), ceph_cap_string(ci->i_dirty_caps), ceph_cap_string(ci->i_flushing_caps), @@ -2113,7 +2115,8 @@ void ceph_check_caps(struct ceph_inode_info *ci, int flags) ceph_cap_string(retain), (flags & CHECK_CAPS_AUTHONLY) ? " AUTHONLY" : "", (flags & CHECK_CAPS_FLUSH) ? " FLUSH" : "", - (flags & CHECK_CAPS_NOINVAL) ? " NOINVAL" : ""); + (flags & CHECK_CAPS_NOINVAL) ? " NOINVAL" : "", + (flags & CHECK_CAPS_FLUSH_FORCE) ? " FLUSH_FORCE" : ""); /* * If we no longer need to hold onto old our caps, and we may @@ -2188,6 +2191,11 @@ void ceph_check_caps(struct ceph_inode_info *ci, int flags) queue_writeback = true; } + if (flags & CHECK_CAPS_FLUSH_FORCE) { + doutc(cl, "force to flush caps\n"); + goto ack; + } + if (cap == ci->i_auth_cap && (cap->issued & CEPH_CAP_FILE_WR)) { /* request larger max_size from MDS? */ @@ -3518,6 +3526,8 @@ static void handle_cap_grant(struct inode *inode, bool queue_invalidate = false; bool deleted_inode = false; bool fill_inline = false; + bool revoke_wait = false; + int flags = 0; /* * If there is at least one crypto block then we'll trust @@ -3713,16 +3723,18 @@ static void handle_cap_grant(struct inode *inode, ceph_cap_string(cap->issued), ceph_cap_string(newcaps), ceph_cap_string(revoking)); if (S_ISREG(inode->i_mode) && - (revoking & used & CEPH_CAP_FILE_BUFFER)) + (revoking & used & CEPH_CAP_FILE_BUFFER)) { writeback = true; /* initiate writeback; will delay ack */ - else if (queue_invalidate && + revoke_wait = true; + } else if (queue_invalidate && revoking == CEPH_CAP_FILE_CACHE && - (newcaps & CEPH_CAP_FILE_LAZYIO) == 0) - ; /* do nothing yet, invalidation will be queued */ - else if (cap == ci->i_auth_cap) + (newcaps & CEPH_CAP_FILE_LAZYIO) == 0) { + revoke_wait = true; /* do nothing yet, invalidation will be queued */ + } else if (cap == ci->i_auth_cap) { check_caps = 1; /* check auth cap only */ - else + } else { check_caps = 2; /* check all caps */ + } /* If there is new caps, try to wake up the waiters */ if (~cap->issued & newcaps) wake = true; @@ -3749,8 +3761,9 @@ static void handle_cap_grant(struct inode *inode, BUG_ON(cap->issued & ~cap->implemented); /* don't let check_caps skip sending a response to MDS for revoke msgs */ - if (le32_to_cpu(grant->op) == CEPH_CAP_OP_REVOKE) { + if (!revoke_wait && le32_to_cpu(grant->op) == CEPH_CAP_OP_REVOKE) { cap->mds_wanted = 0; + flags |= CHECK_CAPS_FLUSH_FORCE; if (cap == ci->i_auth_cap) check_caps = 1; /* check auth cap only */ else @@ -3806,9 +3819,9 @@ static void handle_cap_grant(struct inode *inode, mutex_unlock(&session->s_mutex); if (check_caps == 1) - ceph_check_caps(ci, CHECK_CAPS_AUTHONLY | CHECK_CAPS_NOINVAL); + ceph_check_caps(ci, flags | CHECK_CAPS_AUTHONLY | CHECK_CAPS_NOINVAL); else if (check_caps == 2) - ceph_check_caps(ci, CHECK_CAPS_NOINVAL); + ceph_check_caps(ci, flags | CHECK_CAPS_NOINVAL); } /* diff --git a/fs/ceph/super.h b/fs/ceph/super.h index b0b368ed3018..831e8ec4d5da 100644 --- a/fs/ceph/super.h +++ b/fs/ceph/super.h @@ -200,9 +200,10 @@ struct ceph_cap { struct list_head caps_item; }; -#define CHECK_CAPS_AUTHONLY 1 /* only check auth cap */ -#define CHECK_CAPS_FLUSH 2 /* flush any dirty caps */ -#define CHECK_CAPS_NOINVAL 4 /* don't invalidate pagecache */ +#define CHECK_CAPS_AUTHONLY 1 /* only check auth cap */ +#define CHECK_CAPS_FLUSH 2 /* flush any dirty caps */ +#define CHECK_CAPS_NOINVAL 4 /* don't invalidate pagecache */ +#define CHECK_CAPS_FLUSH_FORCE 8 /* force flush any caps */ struct ceph_cap_flush { u64 tid; -- 2.45.1

1 year, 4 months

3
5
0 0

+ selftests-mm-add-s390-to-arch-check.patch added to mm-hotfixes-unstable branch

by Andrew Morton

The patch titled Subject: selftests: mm: add s390 to ARCH check has been added to the -mm mm-hotfixes-unstable branch. Its filename is selftests-mm-add-s390-to-arch-check.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patche… This patch will later appear in the mm-hotfixes-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Nico Pache <npache(a)redhat.com> Subject: selftests: mm: add s390 to ARCH check Date: Wed, 24 Jul 2024 15:35:17 -0600 commit 0518dbe97fe6 ("selftests/mm: fix cross compilation with LLVM") changed the env variable for the architecture from MACHINE to ARCH. This is preventing 3 required TEST_GEN_FILES from being included when cross compiling s390x and errors when trying to run the test suite. This is due to the ARCH variable already being set and the arch folder name being s390. Add "s390" to the filtered list to cover this case and have the 3 files included in the build. Link: https://lkml.kernel.org/r/20240724213517.23918-1-npache@redhat.com Fixes: 0518dbe97fe6 ("selftests/mm: fix cross compilation with LLVM") Signed-off-by: Nico Pache <npache(a)redhat.com> Cc: Mark Brown <broonie(a)kernel.org> Cc: Albert Ou <aou(a)eecs.berkeley.edu> Cc: Palmer Dabbelt <palmer(a)dabbelt.com> Cc: Paul Walmsley <paul.walmsley(a)sifive.com> Cc: Shuah Khan <shuah(a)kernel.org> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- tools/testing/selftests/mm/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/tools/testing/selftests/mm/Makefile~selftests-mm-add-s390-to-arch-check +++ a/tools/testing/selftests/mm/Makefile @@ -110,7 +110,7 @@ endif endif -ifneq (,$(filter $(ARCH),arm64 ia64 mips64 parisc64 powerpc riscv64 s390x sparc64 x86_64)) +ifneq (,$(filter $(ARCH),arm64 ia64 mips64 parisc64 powerpc riscv64 s390x sparc64 x86_64 s390)) TEST_GEN_FILES += va_high_addr_switch TEST_GEN_FILES += virtual_address_range TEST_GEN_FILES += write_to_hugetlbfs _ Patches currently in -mm which might be from npache(a)redhat.com are selftests-mm-add-s390-to-arch-check.patch

1 year, 4 months

1
0
0 0

+ crash-fix-x86_32-crash-memory-reserve-dead-loop-bug.patch added to mm-nonmm-unstable branch

by Andrew Morton

The patch titled Subject: crash: fix x86_32 crash memory reserve dead loop bug has been added to the -mm mm-nonmm-unstable branch. Its filename is crash-fix-x86_32-crash-memory-reserve-dead-loop-bug.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patche… This patch will later appear in the mm-nonmm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Jinjie Ruan <ruanjinjie(a)huawei.com> Subject: crash: fix x86_32 crash memory reserve dead loop bug Date: Thu, 18 Jul 2024 11:54:42 +0800 Patch series "crash: Fix x86_32 memory reserve dead loop bug", v3. Fix two bugs for x86_32 crash memory reserve, and prepare to apply generic crashkernel reservation to 32bit system. Then use generic interface to simplify crashkernel reservation for ARM32. This patch (of 3): On x86_32 Qemu machine with 1GB memory, the cmdline "crashkernel=1G,high" will cause system stall as below: ACPI: Reserving FACP table memory at [mem 0x3ffe18b8-0x3ffe192b] ACPI: Reserving DSDT table memory at [mem 0x3ffe0040-0x3ffe18b7] ACPI: Reserving FACS table memory at [mem 0x3ffe0000-0x3ffe003f] ACPI: Reserving APIC table memory at [mem 0x3ffe192c-0x3ffe19bb] ACPI: Reserving HPET table memory at [mem 0x3ffe19bc-0x3ffe19f3] ACPI: Reserving WAET table memory at [mem 0x3ffe19f4-0x3ffe1a1b] 143MB HIGHMEM available. 879MB LOWMEM available. mapped low ram: 0 - 36ffe000 low ram: 0 - 36ffe000 (stall here) The reason is that the CRASH_ADDR_LOW_MAX is equal to CRASH_ADDR_HIGH_MAX on x86_32, the first high crash kernel memory reservation will fail, then go into the "retry" loop and never came out as below. -> reserve_crashkernel_generic() and high is true -> alloc at [CRASH_ADDR_LOW_MAX, CRASH_ADDR_HIGH_MAX] fail -> alloc at [0, CRASH_ADDR_LOW_MAX] fail and repeatedly (because CRASH_ADDR_LOW_MAX = CRASH_ADDR_HIGH_MAX). Fix it by prevent crashkernel=,high from being parsed successfully on 32bit system with a architecture-defined macro. After this patch, the 'crashkernel=,high' for 32bit system can't succeed, and it has no chance to call reserve_crashkernel_generic(), therefore this issue on x86_32 is solved. Link: https://lkml.kernel.org/r/20240718035444.2977105-1-ruanjinjie@huawei.com Link: https://lkml.kernel.org/r/20240718035444.2977105-2-ruanjinjie@huawei.com Fixes: 9c08a2a139fe ("x86: kdump: use generic interface to simplify crashkernel reservation code") Signed-off-by: Jinjie Ruan <ruanjinjie(a)huawei.com> Signed-off-by: Baoquan He <bhe(a)redhat.com> Tested-by: Jinjie Ruan <ruanjinjie(a)huawei.com> Cc: Albert Ou <aou(a)eecs.berkeley.edu> Cc: Andrew Davis <afd(a)ti.com> Cc: Arnd Bergmann <arnd(a)arndb.de> Cc: Borislav Petkov <bp(a)alien8.de> Cc: Catalin Marinas <catalin.marinas(a)arm.com> Cc: Chen Jiahao <chenjiahao16(a)huawei.com> Cc: Dave Hansen <dave.hansen(a)linux.intel.com> Cc: Dave Young <dyoung(a)redhat.com> Cc: Eric DeVolder <eric.devolder(a)oracle.com> Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Cc: Hari Bathini <hbathini(a)linux.ibm.com> Cc: Helge Deller <deller(a)gmx.de> Cc: "H. Peter Anvin" <hpa(a)zytor.com> Cc: Ingo Molnar <mingo(a)redhat.com> Cc: Javier Martinez Canillas <javierm(a)redhat.com> Cc: Linus Walleij <linus.walleij(a)linaro.org> Cc: Palmer Dabbelt <palmer(a)dabbelt.com> Cc: Paul Walmsley <paul.walmsley(a)sifive.com> Cc: Rob Herring <robh(a)kernel.org> Cc: Russell King <linux(a)armlinux.org.uk> Cc: Thomas Gleixner <tglx(a)linutronix.de> Cc: Vivek Goyal <vgoyal(a)redhat.com> Cc: Will Deacon <will(a)kernel.org> Cc: Zhen Lei <thunder.leizhen(a)huawei.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- arch/arm64/include/asm/crash_reserve.h | 2 ++ arch/riscv/include/asm/crash_reserve.h | 2 ++ arch/x86/include/asm/crash_reserve.h | 1 + kernel/crash_reserve.c | 2 +- 4 files changed, 6 insertions(+), 1 deletion(-) --- a/arch/arm64/include/asm/crash_reserve.h~crash-fix-x86_32-crash-memory-reserve-dead-loop-bug +++ a/arch/arm64/include/asm/crash_reserve.h @@ -7,4 +7,6 @@ #define CRASH_ADDR_LOW_MAX arm64_dma_phys_limit #define CRASH_ADDR_HIGH_MAX (PHYS_MASK + 1) + +#define HAVE_ARCH_CRASHKERNEL_RESERVATION_HIGH #endif --- a/arch/riscv/include/asm/crash_reserve.h~crash-fix-x86_32-crash-memory-reserve-dead-loop-bug +++ a/arch/riscv/include/asm/crash_reserve.h @@ -7,5 +7,7 @@ #define CRASH_ADDR_LOW_MAX dma32_phys_limit #define CRASH_ADDR_HIGH_MAX memblock_end_of_DRAM() +#define HAVE_ARCH_CRASHKERNEL_RESERVATION_HIGH + extern phys_addr_t memblock_end_of_DRAM(void); #endif --- a/arch/x86/include/asm/crash_reserve.h~crash-fix-x86_32-crash-memory-reserve-dead-loop-bug +++ a/arch/x86/include/asm/crash_reserve.h @@ -26,6 +26,7 @@ extern unsigned long swiotlb_size_or_def #else # define CRASH_ADDR_LOW_MAX SZ_4G # define CRASH_ADDR_HIGH_MAX SZ_64T +#define HAVE_ARCH_CRASHKERNEL_RESERVATION_HIGH #endif # define DEFAULT_CRASH_KERNEL_LOW_SIZE crash_low_size_default() --- a/kernel/crash_reserve.c~crash-fix-x86_32-crash-memory-reserve-dead-loop-bug +++ a/kernel/crash_reserve.c @@ -305,7 +305,7 @@ int __init parse_crashkernel(char *cmdli /* crashkernel=X[@offset] */ ret = __parse_crashkernel(cmdline, system_ram, crash_size, crash_base, NULL); -#ifdef CONFIG_ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION +#ifdef HAVE_ARCH_CRASHKERNEL_RESERVATION_HIGH /* * If non-NULL 'high' passed in and no normal crashkernel * setting detected, try parsing crashkernel=,high|low. _ Patches currently in -mm which might be from ruanjinjie(a)huawei.com are crash-fix-x86_32-crash-memory-reserve-dead-loop-bug.patch crash-fix-x86_32-crash-memory-reserve-dead-loop-bug-at-high.patch arm-use-generic-interface-to-simplify-crashkernel-reservation.patch

1 year, 4 months

2
4
0 0

+ mm-let-pte_lockptr-consume-a-pte_t-pointer.patch added to mm-hotfixes-unstable branch

by Andrew Morton

The patch titled Subject: mm: let pte_lockptr() consume a pte_t pointer has been added to the -mm mm-hotfixes-unstable branch. Its filename is mm-let-pte_lockptr-consume-a-pte_t-pointer.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patche… This patch will later appear in the mm-hotfixes-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: David Hildenbrand <david(a)redhat.com> Subject: mm: let pte_lockptr() consume a pte_t pointer Date: Thu, 25 Jul 2024 20:39:54 +0200 Patch series "mm/hugetlb: fix hugetlb vs. core-mm PT locking". Working on another generic page table walker that tries to avoid special-casing hugetlb, I found a page table locking issue with hugetlb folios that are not mapped using a single PMD/PUD. For some hugetlb folio sizes, GUP will take different page table locks when walking the page tables than hugetlb when modifying the page tables. I did not actually try reproducing an issue, but looking at follow_pmd_mask() where we might be rereading a PMD value multiple times it's rather clear that concurrent modifications are rather unpleasant. In follow_page_pte() we might be better in that regard -- ptep_get() does a READ_ONCE() -- but who knows what else could happen concurrently in some weird corner cases (e.g., hugetlb folio getting unmapped and freed). This patch (of 2): pte_lockptr() is the only *_lockptr() function that doesn't consume what would be expected: it consumes a pmd_t pointer instead of a pte_t pointer. Let's change that. The two callers in pgtable-generic.c are easily adjusted. Adjust khugepaged.c:retract_page_tables() to simply do a pte_offset_map_nolock() to obtain the lock, even though we won't actually be traversing the page table. This makes the code more similar to the other variants and avoids other hacks to make the new pte_lockptr() version happy. pte_lockptr() users reside now only in pgtable-generic.c. Maybe, using pte_offset_map_nolock() is the right thing to do because the PTE table could have been removed in the meantime? At least it sounds more future proof if we ever have other means of page table reclaim. It's not quite clear if holding the PTE table lock is really required: what if someone else obtains the lock just after we unlock it? But we'll leave that as is for now, maybe there are good reasons. This is a preparation for adapting hugetlb page table locking logic to take the same locks as core-mm page table walkers would. Link: https://lkml.kernel.org/r/20240725183955.2268884-1-david@redhat.com Link: https://lkml.kernel.org/r/20240725183955.2268884-2-david@redhat.com Fixes: 9cb28da54643 ("mm/gup: handle hugetlb in the generic follow_page_mask code") Signed-off-by: David Hildenbrand <david(a)redhat.com> Cc: Muchun Song <muchun.song(a)linux.dev> Cc: Oscar Salvador <osalvador(a)suse.de> Cc: Peter Xu <peterx(a)redhat.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- include/linux/mm.h | 7 ++++--- mm/khugepaged.c | 21 +++++++++++++++------ mm/pgtable-generic.c | 4 ++-- 3 files changed, 21 insertions(+), 11 deletions(-) --- a/include/linux/mm.h~mm-let-pte_lockptr-consume-a-pte_t-pointer +++ a/include/linux/mm.h @@ -2915,9 +2915,10 @@ static inline spinlock_t *ptlock_ptr(str } #endif /* ALLOC_SPLIT_PTLOCKS */ -static inline spinlock_t *pte_lockptr(struct mm_struct *mm, pmd_t *pmd) +static inline spinlock_t *pte_lockptr(struct mm_struct *mm, pte_t *pte) { - return ptlock_ptr(page_ptdesc(pmd_page(*pmd))); + /* PTE page tables don't currently exceed a single page. */ + return ptlock_ptr(virt_to_ptdesc(pte)); } static inline bool ptlock_init(struct ptdesc *ptdesc) @@ -2940,7 +2941,7 @@ static inline bool ptlock_init(struct pt /* * We use mm->page_table_lock to guard all pagetable pages of the mm. */ -static inline spinlock_t *pte_lockptr(struct mm_struct *mm, pmd_t *pmd) +static inline spinlock_t *pte_lockptr(struct mm_struct *mm, pte_t *pte) { return &mm->page_table_lock; } --- a/mm/khugepaged.c~mm-let-pte_lockptr-consume-a-pte_t-pointer +++ a/mm/khugepaged.c @@ -1697,12 +1697,13 @@ static void retract_page_tables(struct a i_mmap_lock_read(mapping); vma_interval_tree_foreach(vma, &mapping->i_mmap, pgoff, pgoff) { struct mmu_notifier_range range; + bool retracted = false; struct mm_struct *mm; unsigned long addr; pmd_t *pmd, pgt_pmd; spinlock_t *pml; spinlock_t *ptl; - bool skipped_uffd = false; + pte_t *pte; /* * Check vma->anon_vma to exclude MAP_PRIVATE mappings that @@ -1739,9 +1740,17 @@ static void retract_page_tables(struct a mmu_notifier_invalidate_range_start(&range); pml = pmd_lock(mm, pmd); - ptl = pte_lockptr(mm, pmd); + + /* + * No need to check the PTE table content, but we'll grab the + * PTE table lock while we zap it. + */ + pte = pte_offset_map_nolock(mm, pmd, addr, &ptl); + if (!pte) + goto unlock_pmd; if (ptl != pml) spin_lock_nested(ptl, SINGLE_DEPTH_NESTING); + pte_unmap(pte); /* * Huge page lock is still held, so normally the page table @@ -1752,20 +1761,20 @@ static void retract_page_tables(struct a * repeating the anon_vma check protects from one category, * and repeating the userfaultfd_wp() check from another. */ - if (unlikely(vma->anon_vma || userfaultfd_wp(vma))) { - skipped_uffd = true; - } else { + if (likely(!vma->anon_vma && !userfaultfd_wp(vma))) { pgt_pmd = pmdp_collapse_flush(vma, addr, pmd); pmdp_get_lockless_sync(); + retracted = true; } if (ptl != pml) spin_unlock(ptl); +unlock_pmd: spin_unlock(pml); mmu_notifier_invalidate_range_end(&range); - if (!skipped_uffd) { + if (retracted) { mm_dec_nr_ptes(mm); page_table_check_pte_clear_range(mm, addr, pgt_pmd); pte_free_defer(mm, pmd_pgtable(pgt_pmd)); --- a/mm/pgtable-generic.c~mm-let-pte_lockptr-consume-a-pte_t-pointer +++ a/mm/pgtable-generic.c @@ -313,7 +313,7 @@ pte_t *pte_offset_map_nolock(struct mm_s pte = __pte_offset_map(pmd, addr, &pmdval); if (likely(pte)) - *ptlp = pte_lockptr(mm, &pmdval); + *ptlp = pte_lockptr(mm, pte); return pte; } @@ -371,7 +371,7 @@ again: pte = __pte_offset_map(pmd, addr, &pmdval); if (unlikely(!pte)) return pte; - ptl = pte_lockptr(mm, &pmdval); + ptl = pte_lockptr(mm, pte); spin_lock(ptl); if (likely(pmd_same(pmdval, pmdp_get_lockless(pmd)))) { *ptlp = ptl; _ Patches currently in -mm which might be from david(a)redhat.com are mm-let-pte_lockptr-consume-a-pte_t-pointer.patch mm-hugetlb-fix-hugetlb-vs-core-mm-pt-locking.patch

1 year, 4 months

1
0
0 0

[PATCH v6 4/8] RISC-V: Scalar unaligned access emulated on hotplug CPUs

by Jesse Taube

The check_unaligned_access_emulated() function should have been called during CPU hotplug to ensure that if all CPUs had emulated unaligned accesses, the new CPU also does. This patch adds the call to check_unaligned_access_emulated() in the hotplug path. Fixes: 55e0bf49a0d0 ("RISC-V: Probe misaligned access speed in parallel") Signed-off-by: Jesse Taube <jesse(a)rivosinc.com> Cc: stable(a)vger.kernel.org --- V5 -> V6: - New patch --- arch/riscv/kernel/unaligned_access_speed.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/riscv/kernel/unaligned_access_speed.c b/arch/riscv/kernel/unaligned_access_speed.c index a9a6bcb02acf..b67db1fc3740 100644 --- a/arch/riscv/kernel/unaligned_access_speed.c +++ b/arch/riscv/kernel/unaligned_access_speed.c @@ -191,6 +191,7 @@ static int riscv_online_cpu(unsigned int cpu) if (per_cpu(misaligned_access_speed, cpu) != RISCV_HWPROBE_MISALIGNED_UNKNOWN) goto exit; + check_unaligned_access_emulated(NULL); buf = alloc_pages(GFP_KERNEL, MISALIGNED_BUFFER_ORDER); if (!buf) { pr_warn("Allocation failure, not measuring misaligned performance\n"); -- 2.45.2

1 year, 4 months

2
1
0 0

[PATCH v6 3/8] RISC-V: Check scalar unaligned access on all CPUs

by Jesse Taube

Originally, the check_unaligned_access_emulated_all_cpus function only checked the boot hart. This fixes the function to check all harts. Fixes: 71c54b3d169d ("riscv: report misaligned accesses emulation to hwprobe") Signed-off-by: Jesse Taube <jesse(a)rivosinc.com> Reviewed-by: Charlie Jenkins <charlie(a)rivosinc.com> Cc: stable(a)vger.kernel.org --- V1 -> V2: - New patch V2 -> V3: - Split patch V3 -> V4: - Re-add check for a system where a heterogeneous CPU is hotplugged into a previously homogenous system. V4 -> V5: - Change work_struct *unused to work_struct *work __always_unused V5 -> V6: - Change check_unaligned_access_emulated to extern --- arch/riscv/include/asm/cpufeature.h | 2 ++ arch/riscv/kernel/traps_misaligned.c | 14 +++++++------- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/arch/riscv/include/asm/cpufeature.h b/arch/riscv/include/asm/cpufeature.h index 347805446151..3b24342c7d2a 100644 --- a/arch/riscv/include/asm/cpufeature.h +++ b/arch/riscv/include/asm/cpufeature.h @@ -8,6 +8,7 @@ #include <linux/bitmap.h> #include <linux/jump_label.h> +#include <linux/workqueue.h> #include <asm/hwcap.h> #include <asm/alternative-macros.h> #include <asm/errno.h> @@ -35,6 +36,7 @@ void riscv_user_isa_enable(void); #if defined(CONFIG_RISCV_MISALIGNED) bool check_unaligned_access_emulated_all_cpus(void); +void check_unaligned_access_emulated(struct work_struct *work __always_unused); void unaligned_emulation_finish(void); bool unaligned_ctl_available(void); DECLARE_PER_CPU(long, misaligned_access_speed); diff --git a/arch/riscv/kernel/traps_misaligned.c b/arch/riscv/kernel/traps_misaligned.c index b62d5a2f4541..bb09357778c5 100644 --- a/arch/riscv/kernel/traps_misaligned.c +++ b/arch/riscv/kernel/traps_misaligned.c @@ -526,11 +526,11 @@ int handle_misaligned_store(struct pt_regs *regs) return 0; } -static bool check_unaligned_access_emulated(int cpu) +void check_unaligned_access_emulated(struct work_struct *work __always_unused) { + int cpu = smp_processor_id(); long *mas_ptr = per_cpu_ptr(&misaligned_access_speed, cpu); unsigned long tmp_var, tmp_val; - bool misaligned_emu_detected; *mas_ptr = RISCV_HWPROBE_MISALIGNED_UNKNOWN; @@ -538,19 +538,16 @@ static bool check_unaligned_access_emulated(int cpu) " "REG_L" %[tmp], 1(%[ptr])\n" : [tmp] "=r" (tmp_val) : [ptr] "r" (&tmp_var) : "memory"); - misaligned_emu_detected = (*mas_ptr == RISCV_HWPROBE_MISALIGNED_EMULATED); /* * If unaligned_ctl is already set, this means that we detected that all * CPUS uses emulated misaligned access at boot time. If that changed * when hotplugging the new cpu, this is something we don't handle. */ - if (unlikely(unaligned_ctl && !misaligned_emu_detected)) { + if (unlikely(unaligned_ctl && (*mas_ptr != RISCV_HWPROBE_MISALIGNED_EMULATED))) { pr_crit("CPU misaligned accesses non homogeneous (expected all emulated)\n"); while (true) cpu_relax(); } - - return misaligned_emu_detected; } bool check_unaligned_access_emulated_all_cpus(void) @@ -562,8 +559,11 @@ bool check_unaligned_access_emulated_all_cpus(void) * accesses emulated since tasks requesting such control can run on any * CPU. */ + schedule_on_each_cpu(check_unaligned_access_emulated); + for_each_online_cpu(cpu) - if (!check_unaligned_access_emulated(cpu)) + if (per_cpu(misaligned_access_speed, cpu) + != RISCV_HWPROBE_MISALIGNED_EMULATED) return false; unaligned_ctl = true; -- 2.45.2

1 year, 4 months

2
1
0 0

[PATCH wireless] wifi: mac80211: use monitor sdata with driver only if desired

by Johannes Berg

From: Johannes Berg <johannes.berg(a)intel.com> In commit 0d9c2beed116 ("wifi: mac80211: fix monitor channel with chanctx emulation") I changed mac80211 to always have an internal monitor_sdata to have something to have the chanctx bound to. However, if the driver didn't also have the WANT_MONITOR flag this would cause mac80211 to allocate it without telling the driver (which was intentional) but also use it for later APIs to the driver without it ever having known about it which was _not_ intentional. Check through the code and only use the monitor_sdata in the relevant places (TX, MU-MIMO follow settings, TX power, and interface iteration) when the WANT_MONITOR flag is set. Cc: stable(a)vger.kernel.org Fixes: 0d9c2beed116 ("wifi: mac80211: fix monitor channel with chanctx emulation") Reported-by: ZeroBeat <ZeroBeat(a)gmx.de> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219086 Tested-by: Lorenzo Bianconi <lorenzo(a)kernel.org> Signed-off-by: Johannes Berg <johannes.berg(a)intel.com> --- net/mac80211/cfg.c | 7 +++++-- net/mac80211/tx.c | 5 +++-- net/mac80211/util.c | 2 +- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c index 85cb71de370f..b02b84ce2130 100644 --- a/net/mac80211/cfg.c +++ b/net/mac80211/cfg.c @@ -114,7 +114,7 @@ static int ieee80211_set_mon_options(struct ieee80211_sub_if_data *sdata, /* apply all changes now - no failures allowed */ - if (monitor_sdata) + if (monitor_sdata && ieee80211_hw_check(&local->hw, WANT_MONITOR_VIF)) ieee80211_set_mu_mimo_follow(monitor_sdata, params); if (params->flags) { @@ -3053,6 +3053,9 @@ static int ieee80211_set_tx_power(struct wiphy *wiphy, sdata = IEEE80211_WDEV_TO_SUB_IF(wdev); if (sdata->vif.type == NL80211_IFTYPE_MONITOR) { + if (!ieee80211_hw_check(&local->hw, WANT_MONITOR_VIF)) + return -EOPNOTSUPP; + sdata = wiphy_dereference(local->hw.wiphy, local->monitor_sdata); if (!sdata) @@ -3115,7 +3118,7 @@ static int ieee80211_set_tx_power(struct wiphy *wiphy, if (has_monitor) { sdata = wiphy_dereference(local->hw.wiphy, local->monitor_sdata); - if (sdata) { + if (sdata && ieee80211_hw_check(&local->hw, WANT_MONITOR_VIF)) { sdata->deflink.user_power_level = local->user_power_level; if (txp_type != sdata->vif.bss_conf.txpower_type) update_txp_type = true; diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c index 72a9ba8bc5fd..edba4a31844f 100644 --- a/net/mac80211/tx.c +++ b/net/mac80211/tx.c @@ -1768,7 +1768,7 @@ static bool __ieee80211_tx(struct ieee80211_local *local, break; } sdata = rcu_dereference(local->monitor_sdata); - if (sdata) { + if (sdata && ieee80211_hw_check(&local->hw, WANT_MONITOR_VIF)) { vif = &sdata->vif; info->hw_queue = vif->hw_queue[skb_get_queue_mapping(skb)]; @@ -3957,7 +3957,8 @@ struct sk_buff *ieee80211_tx_dequeue(struct ieee80211_hw *hw, break; } tx.sdata = rcu_dereference(local->monitor_sdata); - if (tx.sdata) { + if (tx.sdata && + ieee80211_hw_check(&local->hw, WANT_MONITOR_VIF)) { vif = &tx.sdata->vif; info->hw_queue = vif->hw_queue[skb_get_queue_mapping(skb)]; diff --git a/net/mac80211/util.c b/net/mac80211/util.c index ced19ce7c51a..c7ad9bc5973a 100644 --- a/net/mac80211/util.c +++ b/net/mac80211/util.c @@ -776,7 +776,7 @@ static void __iterate_interfaces(struct ieee80211_local *local, sdata = rcu_dereference_check(local->monitor_sdata, lockdep_is_held(&local->iflist_mtx) || lockdep_is_held(&local->hw.wiphy->mtx)); - if (sdata && + if (sdata && ieee80211_hw_check(&local->hw, WANT_MONITOR_VIF) && (iter_flags & IEEE80211_IFACE_ITER_RESUME_ALL || !active_only || sdata->flags & IEEE80211_SDATA_IN_DRIVER)) iterator(data, sdata->vif.addr, &sdata->vif); -- 2.45.2

1 year, 4 months

2
1
0 0

[PATCH] tools/nolibc: include arch.h from string.h

by Thomas Weißschuh

string.h tests for the macros NOLIBC_ARCH_HAS_$FUNC to use the architecture-optimized function variants. However if string.h is included before arch.h header than that check does not work, leading to duplicate function definitions. Fixes: 553845eebd60 ("tools/nolibc: x86-64: Use `rep movsb` for `memcpy()` and `memmove()`") Fixes: 12108aa8c1a1 ("tools/nolibc: x86-64: Use `rep stosb` for `memset()`") Cc: stable(a)vger.kernel.org Signed-off-by: Thomas Weißschuh <linux(a)weissschuh.net> --- If nobody complains I'll apply this after v6.11-rc1 is released. --- tools/include/nolibc/string.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/include/nolibc/string.h b/tools/include/nolibc/string.h index f9ab28421e6d..9ec9c24f38c0 100644 --- a/tools/include/nolibc/string.h +++ b/tools/include/nolibc/string.h @@ -7,6 +7,7 @@ #ifndef _NOLIBC_STRING_H #define _NOLIBC_STRING_H +#include "arch.h" #include "std.h" static void *malloc(size_t len); --- base-commit: 6ca8f2e20bd1ced8a7cd12b3ae4b1ceca85cfc2b change-id: 20240725-arch-has-func-59b6c92ce935 Best regards, -- Thomas Weißschuh <linux(a)weissschuh.net>

1 year, 4 months

2
1
0 0

[PATCH 2/3] spmi: pmic-arb: Pass the correct of_node to irq_domain_add_tree

by Stephen Boyd

From: Konrad Dybcio <konrad.dybcio(a)linaro.org> Currently, irqchips for all of the subnodes (which represent a given bus master) point to the parent wrapper node. This is no bueno, as no interrupts arrive, ever (because nothing references that node). Fix that by passing a reference to the respective master's of_node. Worth noting, this is a NOP for devices with only a single master described. Signed-off-by: Konrad Dybcio <konrad.dybcio(a)linaro.org> Link: https://lore.kernel.org/r/20240522-topic-spmi_multi_master_irqfix-v2-1-7ec9… Reviewed-by: Abel Vesa <abel.vesa(a)linaro.org> Tested-by: Dmitry Baryshkov <dmitry.baryshkov(a)linaro.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov(a)linaro.org> Fixes: 02922ccbb330 ("spmi: pmic-arb: Register controller for bus instead of arbiter") Cc: stable(a)vger.kernel.org Signed-off-by: Stephen Boyd <sboyd(a)kernel.org> --- drivers/spmi/spmi-pmic-arb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c index f240fcc5a4e1..b6880c13163c 100644 --- a/drivers/spmi/spmi-pmic-arb.c +++ b/drivers/spmi/spmi-pmic-arb.c @@ -1737,8 +1737,7 @@ static int spmi_pmic_arb_bus_init(struct platform_device *pdev, dev_dbg(&pdev->dev, "adding irq domain for bus %d\n", bus_index); - bus->domain = irq_domain_add_tree(dev->of_node, - &pmic_arb_irq_domain_ops, bus); + bus->domain = irq_domain_add_tree(node, &pmic_arb_irq_domain_ops, bus); if (!bus->domain) { dev_err(&pdev->dev, "unable to create irq_domain\n"); return -ENOMEM; -- https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/ https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git

1 year, 4 months

1
0
0 0

[PATCH 6.1.y] udf: Convert udf_mkdir() to new directory iteration code

by Sergio González Collado

From: Jan Kara <jack(a)suse.cz> [ Upstream commit 00bce6f792caccefa73daeaf9bde82d24d50037f ] Convert udf_mkdir() to new directory iteration code. Signed-off-by: Jan Kara <jack(a)suse.cz> (cherry picked from commit 00bce6f792caccefa73daeaf9bde82d24d50037f) Signed-off-by: Sergio González Collado <sergio.collado(a)gmail.com> Reported-by: syzbot+600a32676df180ebc4af(a)syzkaller.appspotmail.com --- fs/udf/namei.c | 48 +++++++++++++++++++++--------------------------- 1 file changed, 21 insertions(+), 27 deletions(-) diff --git a/fs/udf/namei.c b/fs/udf/namei.c index 7c95c549dd64..a33e6d762716 100644 --- a/fs/udf/namei.c +++ b/fs/udf/namei.c @@ -665,8 +665,7 @@ static int udf_mkdir(struct user_namespace *mnt_userns, struct inode *dir, struct dentry *dentry, umode_t mode) { struct inode *inode; - struct udf_fileident_bh fibh; - struct fileIdentDesc cfi, *fi; + struct udf_fileident_iter iter; int err; struct udf_inode_info *dinfo = UDF_I(dir); struct udf_inode_info *iinfo; @@ -678,47 +677,42 @@ static int udf_mkdir(struct user_namespace *mnt_userns, struct inode *dir, iinfo = UDF_I(inode); inode->i_op = &udf_dir_inode_operations; inode->i_fop = &udf_dir_operations; - fi = udf_add_entry(inode, NULL, &fibh, &cfi, &err); - if (!fi) { - inode_dec_link_count(inode); + err = udf_fiiter_add_entry(inode, NULL, &iter); + if (err) { + clear_nlink(inode); discard_new_inode(inode); - goto out; + return err; } set_nlink(inode, 2); - cfi.icb.extLength = cpu_to_le32(inode->i_sb->s_blocksize); - cfi.icb.extLocation = cpu_to_lelb(dinfo->i_location); - *(__le32 *)((struct allocDescImpUse *)cfi.icb.impUse)->impUse = + iter.fi.icb.extLength = cpu_to_le32(inode->i_sb->s_blocksize); + iter.fi.icb.extLocation = cpu_to_lelb(dinfo->i_location); + *(__le32 *)((struct allocDescImpUse *)iter.fi.icb.impUse)->impUse = cpu_to_le32(dinfo->i_unique & 0x00000000FFFFFFFFUL); - cfi.fileCharacteristics = + iter.fi.fileCharacteristics = FID_FILE_CHAR_DIRECTORY | FID_FILE_CHAR_PARENT; - udf_write_fi(inode, &cfi, fi, &fibh, NULL, NULL); - brelse(fibh.sbh); + udf_fiiter_write_fi(&iter, NULL); + udf_fiiter_release(&iter); mark_inode_dirty(inode); - fi = udf_add_entry(dir, dentry, &fibh, &cfi, &err); - if (!fi) { + err = udf_fiiter_add_entry(dir, dentry, &iter); + if (err) { clear_nlink(inode); - mark_inode_dirty(inode); discard_new_inode(inode); - goto out; + return err; } - cfi.icb.extLength = cpu_to_le32(inode->i_sb->s_blocksize); - cfi.icb.extLocation = cpu_to_lelb(iinfo->i_location); - *(__le32 *)((struct allocDescImpUse *)cfi.icb.impUse)->impUse = + iter.fi.icb.extLength = cpu_to_le32(inode->i_sb->s_blocksize); + iter.fi.icb.extLocation = cpu_to_lelb(iinfo->i_location); + *(__le32 *)((struct allocDescImpUse *)iter.fi.icb.impUse)->impUse = cpu_to_le32(iinfo->i_unique & 0x00000000FFFFFFFFUL); - cfi.fileCharacteristics |= FID_FILE_CHAR_DIRECTORY; - udf_write_fi(dir, &cfi, fi, &fibh, NULL, NULL); + iter.fi.fileCharacteristics |= FID_FILE_CHAR_DIRECTORY; + udf_fiiter_write_fi(&iter, NULL); + udf_fiiter_release(&iter); inc_nlink(dir); dir->i_ctime = dir->i_mtime = current_time(dir); mark_inode_dirty(dir); d_instantiate_new(dentry, inode); - if (fibh.sbh != fibh.ebh) - brelse(fibh.ebh); - brelse(fibh.sbh); - err = 0; -out: - return err; + return 0; } static int empty_dir(struct inode *dir) -- 2.39.2

1 year, 4 months

2
3
0 0

[REGRESSION] ALSA: firewire-lib: heavy digital distortion with Fireface 800

by edmund.raile

Bisection revealed that the bitcrushing distortion with RME FireFace 800 was caused by 1d717123bb1a7555 ("ALSA: firewire-lib: Avoid -Wflex-array-member-not-at-end warning"). Reverting this commit yields restoration of clear audio output. I will send in a patch reverting this commit for now, soonTM. #regzbot introduced: 1d717123bb1a7555

1 year, 4 months

4
6
0 0

FAILED: patch "[PATCH] s390/mm: Fix VM_FAULT_HWPOISON handling in do_exception()" failed to apply to 6.6-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.6-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.6.y git checkout FETCH_HEAD git cherry-pick -x df39038cd89525d465c2c8827eb64116873f141a # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072535-synergy-struggle-8ecc@gregkh' --subject-prefix 'PATCH 6.6.y' HEAD^.. Possible dependencies: df39038cd895 ("s390/mm: Fix VM_FAULT_HWPOISON handling in do_exception()") b20c8216c1e0 ("s390/mm,fault: move VM_FAULT_ERROR handling to do_exception()") 7c194d84a9ce ("s390/mm,fault: remove VM_FAULT_BADMAP and VM_FAULT_BADACCESS") b61a0922b6dc ("s390/mm,fault: remove VM_FAULT_SIGNAL") 0f86ac4ba713 ("s390/mm,fault: remove VM_FAULT_BADCONTEXT") 0f1a14e0348e ("s390/mm,fault: simplify kfence fault handling") 64ea33fb09f8 ("s390/mm,fault: call do_fault_error() only from do_exception()") 5db06565cad6 ("s390/mm,fault: get rid of do_low_address()") cca12b427d43 ("s390/mm,fault: remove VM_FAULT_PFAULT") 5be05c35e72f ("s390/mm,fault: improve readability by using teid union") 4416d2ed8166 ("s390/mm,fault: use static key for store indication") 9641613f48bb ("s390/mm,fault: use get_fault_address() everywhere") 5c845de331d9 ("s390/mm,fault: remove noinline attribute from all functions") 8dbc33dc8163 ("s390/mm,fault: have balanced braces, remove unnecessary blanks") 7c915a84e5e2 ("s390/mm,fault: reverse x-mas tree coding style") 3aad8c044297 ("s390/mm,fault: remove and improve comments, adjust whitespace") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From df39038cd89525d465c2c8827eb64116873f141a Mon Sep 17 00:00:00 2001 From: Gerald Schaefer <gerald.schaefer(a)linux.ibm.com> Date: Mon, 15 Jul 2024 20:04:16 +0200 Subject: [PATCH] s390/mm: Fix VM_FAULT_HWPOISON handling in do_exception() There is no support for HWPOISON, MEMORY_FAILURE, or ARCH_HAS_COPY_MC on s390. Therefore we do not expect to see VM_FAULT_HWPOISON in do_exception(). However, since commit af19487f00f3 ("mm: make PTE_MARKER_SWAPIN_ERROR more general"), it is possible to see VM_FAULT_HWPOISON in combination with PTE_MARKER_POISONED, even on architectures that do not support HWPOISON otherwise. In this case, we will end up on the BUG() in do_exception(). Fix this by treating VM_FAULT_HWPOISON the same as VM_FAULT_SIGBUS, similar to x86 when MEMORY_FAILURE is not configured. Also print unexpected fault flags, for easier debugging. Note that VM_FAULT_HWPOISON_LARGE is not expected, because s390 cannot support swap entries on other levels than PTE level. Cc: stable(a)vger.kernel.org # 6.6+ Fixes: af19487f00f3 ("mm: make PTE_MARKER_SWAPIN_ERROR more general") Reported-by: Yunseong Kim <yskelg(a)gmail.com> Tested-by: Yunseong Kim <yskelg(a)gmail.com> Acked-by: Alexander Gordeev <agordeev(a)linux.ibm.com> Signed-off-by: Gerald Schaefer <gerald.schaefer(a)linux.ibm.com> Message-ID: <20240715180416.3632453-1-gerald.schaefer(a)linux.ibm.com> Signed-off-by: Vasily Gorbik <gor(a)linux.ibm.com> diff --git a/arch/s390/mm/fault.c b/arch/s390/mm/fault.c index 6b19a33c49c2..8e149ef5e89b 100644 --- a/arch/s390/mm/fault.c +++ b/arch/s390/mm/fault.c @@ -433,12 +433,13 @@ static void do_exception(struct pt_regs *regs, int access) handle_fault_error_nolock(regs, 0); else do_sigsegv(regs, SEGV_MAPERR); - } else if (fault & VM_FAULT_SIGBUS) { + } else if (fault & (VM_FAULT_SIGBUS | VM_FAULT_HWPOISON)) { if (!user_mode(regs)) handle_fault_error_nolock(regs, 0); else do_sigbus(regs); } else { + pr_emerg("Unexpected fault flags: %08x\n", fault); BUG(); } }

1 year, 4 months

2
1
0 0

[PATCH net v2] gve: Fix an edge case for TSO skb validity check

by Praveen Kaligineedi

From: Bailey Forrest <bcf(a)google.com> The NIC requires each TSO segment to not span more than 10 descriptors. NIC further requires each descriptor to not exceed 16KB - 1 (GVE_TX_MAX_BUF_SIZE_DQO). The descriptors for an skb are generated by gve_tx_add_skb_no_copy_dqo() for DQO RDA queue format. gve_tx_add_skb_no_copy_dqo() loops through each skb frag and generates a descriptor for the entire frag if the frag size is not greater than GVE_TX_MAX_BUF_SIZE_DQO. If the frag size is greater than GVE_TX_MAX_BUF_SIZE_DQO, it is split into descriptor(s) of size GVE_TX_MAX_BUF_SIZE_DQO and a descriptor is generated for the remainder (frag size % GVE_TX_MAX_BUF_SIZE_DQO). gve_can_send_tso() checks if the descriptors thus generated for an skb would meet the requirement that each TSO-segment not span more than 10 descriptors. However, the current code misses an edge case when a TSO segment spans multiple descriptors within a large frag. This change fixes the edge case. gve_can_send_tso() relies on the assumption that max gso size (9728) is less than GVE_TX_MAX_BUF_SIZE_DQO and therefore within an skb fragment a TSO segment can never span more than 2 descriptors. Fixes: a57e5de476be ("gve: DQO: Add TX path") Signed-off-by: Praveen Kaligineedi <pkaligineedi(a)google.com> Signed-off-by: Bailey Forrest <bcf(a)google.com> Reviewed-by: Jeroen de Borst <jeroendb(a)google.com> Cc: stable(a)vger.kernel.org --- Changes from v1: - Added 'stable tag' - Added more explanation in the commit message - Modified comments to clarify the changes made - Changed variable names 'last_frag_size' to 'prev_frag_size' and 'last_frag_remain' to 'prev_frag_remain' - Removed parentheses around single line statement drivers/net/ethernet/google/gve/gve_tx_dqo.c | 22 +++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/google/gve/gve_tx_dqo.c b/drivers/net/ethernet/google/gve/gve_tx_dqo.c index 0b3cca3fc792..f879426cb552 100644 --- a/drivers/net/ethernet/google/gve/gve_tx_dqo.c +++ b/drivers/net/ethernet/google/gve/gve_tx_dqo.c @@ -866,22 +866,42 @@ static bool gve_can_send_tso(const struct sk_buff *skb) const int header_len = skb_tcp_all_headers(skb); const int gso_size = shinfo->gso_size; int cur_seg_num_bufs; + int prev_frag_size; int cur_seg_size; int i; cur_seg_size = skb_headlen(skb) - header_len; + prev_frag_size = skb_headlen(skb); cur_seg_num_bufs = cur_seg_size > 0; for (i = 0; i < shinfo->nr_frags; i++) { if (cur_seg_size >= gso_size) { cur_seg_size %= gso_size; cur_seg_num_bufs = cur_seg_size > 0; + + if (prev_frag_size > GVE_TX_MAX_BUF_SIZE_DQO) { + int prev_frag_remain = prev_frag_size % + GVE_TX_MAX_BUF_SIZE_DQO; + + /* If the last descriptor of the previous frag + * is less than cur_seg_size, the segment will + * span two descriptors in the previous frag. + * Since max gso size (9728) is less than + * GVE_TX_MAX_BUF_SIZE_DQO, it is impossible + * for the segment to span more than two + * descriptors. + */ + if (prev_frag_remain && + cur_seg_size > prev_frag_remain) + cur_seg_num_bufs++; + } } if (unlikely(++cur_seg_num_bufs > max_bufs_per_seg)) return false; - cur_seg_size += skb_frag_size(&shinfo->frags[i]); + prev_frag_size = skb_frag_size(&shinfo->frags[i]); + cur_seg_size += prev_frag_size; } return true; -- 2.45.2.1089.g2a221341d9-goog

1 year, 4 months

3
2
0 0

[PATCH 6.1.y] bpf: Synchronize dispatcher update with bpf_dispatcher_xdp_func

by Sergio González Collado

From: Jiri Olsa <jolsa(a)kernel.org> [ Upstream commit 4121d4481b72501aa4d22680be4ea1096d69d133 ] Hao Sun reported crash in dispatcher image [1]. Currently we don't have any sync between bpf_dispatcher_update and bpf_dispatcher_xdp_func, so following race is possible: cpu 0: cpu 1: bpf_prog_run_xdp ... bpf_dispatcher_xdp_func in image at offset 0x0 bpf_dispatcher_update update image at offset 0x800 bpf_dispatcher_update update image at offset 0x0 in image at offset 0x0 -> crash Fixing this by synchronizing dispatcher image update (which is done in bpf_dispatcher_update function) with bpf_dispatcher_xdp_func that reads and execute the dispatcher image. Calling synchronize_rcu after updating and installing new image ensures that readers leave old image before it's changed in the next dispatcher update. The update itself is locked with dispatcher's mutex. The bpf_prog_run_xdp is called under local_bh_disable and synchronize_rcu will wait for it to leave [2]. [1] https://lore.kernel.org/bpf/Y5SFho7ZYXr9ifRn@krava/T/#m00c29ece654bc9f332a1… [2] https://lore.kernel.org/bpf/0B62D35A-E695-4B7A-A0D4-774767544C1A@gmail.com/… Reported-by: Hao Sun <sunhao.th(a)gmail.com> Signed-off-by: Jiri Olsa <jolsa(a)kernel.org> Acked-by: Yonghong Song <yhs(a)fb.com> Acked-by: Paul E. McKenney <paulmck(a)kernel.org> Link: https://lore.kernel.org/r/20221214123542.1389719-1-jolsa@kernel.org Signed-off-by: Martin KaFai Lau <martin.lau(a)kernel.org> (cherry picked from commit 4121d4481b72501aa4d22680be4ea1096d69d133) Signed-off-by: Sergio González Collado <sergio.collado(a)gmail.com> Reported-by: syzbot+08ba1e474d350b613604(a)syzkaller.appspotmail.com --- kernel/bpf/dispatcher.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/kernel/bpf/dispatcher.c b/kernel/bpf/dispatcher.c index c19719f48ce0..fa3e9225aedc 100644 --- a/kernel/bpf/dispatcher.c +++ b/kernel/bpf/dispatcher.c @@ -125,6 +125,11 @@ static void bpf_dispatcher_update(struct bpf_dispatcher *d, int prev_num_progs) __BPF_DISPATCHER_UPDATE(d, new ?: (void *)&bpf_dispatcher_nop_func); + /* Make sure all the callers executing the previous/old half of the + * image leave it, so following update call can modify it safely. + */ + synchronize_rcu(); + if (new) d->image_off = noff; } -- 2.39.2

1 year, 4 months

1
0
0 0

[PATCH 6.1.y] btrfs: do not BUG_ON on failure to get dir index for new snapshot

by Sergio González Collado

From: Filipe Manana <fdmanana(a)suse.com> [ Upstream commit df9f278239046719c91aeb59ec0afb1a99ee8b2b ] During the transaction commit path, at create_pending_snapshot(), there is no need to BUG_ON() in case we fail to get a dir index for the snapshot in the parent directory. This should fail very rarely because the parent inode should be loaded in memory already, with the respective delayed inode created and the parent inode's index_cnt field already initialized. However if it fails, it may be -ENOMEM like the comment at create_pending_snapshot() says or any error returned by btrfs_search_slot() through btrfs_set_inode_index_count(), which can be pretty much anything such as -EIO or -EUCLEAN for example. So the comment is not correct when it says it can only be -ENOMEM. However doing a BUG_ON() here is overkill, since we can instead abort the transaction and return the error. Note that any error returned by create_pending_snapshot() will eventually result in a transaction abort at cleanup_transaction(), called from btrfs_commit_transaction(), but we can explicitly abort the transaction at this point instead so that we get a stack trace to tell us that the call to btrfs_set_inode_index() failed. So just abort the transaction and return in case btrfs_set_inode_index() returned an error at create_pending_snapshot(). Reviewed-by: Johannes Thumshirn <johannes.thumshirn(a)wdc.com> Signed-off-by: Filipe Manana <fdmanana(a)suse.com> Reviewed-by: David Sterba <dsterba(a)suse.com> Signed-off-by: David Sterba <dsterba(a)suse.com> (cherry picked from commit df9f278239046719c91aeb59ec0afb1a99ee8b2b) Signed-off-by: Sergio González Collado <sergio.collado(a)gmail.com> Reported-by: syzbot+c56033c8c15c08286062(a)syzkaller.appspotmail.com --- fs/btrfs/transaction.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c index a7853a3a5719..604241e6e2c1 100644 --- a/fs/btrfs/transaction.c +++ b/fs/btrfs/transaction.c @@ -1701,7 +1701,10 @@ static noinline int create_pending_snapshot(struct btrfs_trans_handle *trans, * insert the directory item */ ret = btrfs_set_inode_index(BTRFS_I(parent_inode), &index); - BUG_ON(ret); /* -ENOMEM */ + if (ret) { + btrfs_abort_transaction(trans, ret); + goto fail; + } /* check if there is a file/dir which has the same name. */ dir_item = btrfs_lookup_dir_item(NULL, parent_root, path, -- 2.39.2

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] arm64: dts: qcom: sm6115: Disable SS instance in Parkmode for" failed to apply to 6.6-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.6-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.6.y git checkout FETCH_HEAD git cherry-pick -x 074992a1163295d717faa21d1818c4c19ef6e676 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072522-properly-jackpot-9fed@gregkh' --subject-prefix 'PATCH 6.6.y' HEAD^.. Possible dependencies: 074992a11632 ("arm64: dts: qcom: sm6115: Disable SS instance in Parkmode for USB") a06a2f12f9e2 ("arm64: dts: qcom: qrb4210-rb2: enable USB-C port handling") 7e3a1f6470f7 ("arm64: dts: qcom: sm6115: drop pipe clock selection") b3eaa47395b9 ("arm64: dts: qcom: sm6115: Hook up interconnects") f6874706e311 ("arm64: dts: qcom: sm6115: switch UFS QMP PHY to new style of bindings") ff753723bf39 ("arm64: dts: qcom: qrb4210-rb2: Enable MPSS and Wi-Fi") cab60b166575 ("arm64: dts: qcom: qrb4210-rb2: Enable bluetooth") ba5f5610841f ("arm64: dts: qcom: sm6115: Add UART3") 27c2ca90e2f3 ("arm64: dts: qcom: qrb4210-rb2: don't force usb peripheral mode") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 074992a1163295d717faa21d1818c4c19ef6e676 Mon Sep 17 00:00:00 2001 From: Krishna Kurapati <quic_kriskura(a)quicinc.com> Date: Thu, 4 Jul 2024 20:58:45 +0530 Subject: [PATCH] arm64: dts: qcom: sm6115: Disable SS instance in Parkmode for USB For Gen-1 targets like SM6115, it is seen that stressing out the controller in host mode results in HC died error: xhci-hcd.12.auto: xHCI host not responding to stop endpoint command xhci-hcd.12.auto: xHCI host controller not responding, assume dead xhci-hcd.12.auto: HC died; cleaning up And at this instant only restarting the host mode fixes it. Disable SuperSpeed instance in park mode for SM6115 to mitigate this issue. Cc: stable(a)vger.kernel.org Fixes: 97e563bf5ba1 ("arm64: dts: qcom: sm6115: Add basic soc dtsi") Signed-off-by: Krishna Kurapati <quic_kriskura(a)quicinc.com> Reviewed-by: Konrad Dybcio <konrad.dybcio(a)linaro.org> Link: https://lore.kernel.org/r/20240704152848.3380602-6-quic_kriskura@quicinc.com Signed-off-by: Bjorn Andersson <andersson(a)kernel.org> diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi index ac5f071a8db3..aec6ca5941c2 100644 --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi @@ -1659,6 +1659,7 @@ usb_dwc3: usb@4e00000 { snps,has-lpm-erratum; snps,hird-threshold = /bits/ 8 <0x10>; snps,usb3_lpm_capable; + snps,parkmode-disable-ss-quirk; usb-role-switch;

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] arm64: dts: qcom: sdm845: Disable SS instance in Parkmode for" failed to apply to 4.19-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.19-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-4.19.y git checkout FETCH_HEAD git cherry-pick -x cf4d6d54eadb60d2ee4d31c9d92299f5e8dcb55c # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072513-cardinal-snowcap-d711@gregkh' --subject-prefix 'PATCH 4.19.y' HEAD^.. Possible dependencies: cf4d6d54eadb ("arm64: dts: qcom: sdm845: Disable SS instance in Parkmode for USB") ca5ca568d738 ("arm64: dts: qcom: sdm845: switch USB QMP PHY to new style of bindings") a9ecdec45a3a ("arm64: dts: qcom: sdm845: switch USB+DP QMP PHY to new style of bindings") 8fe25ba3ffec ("arm64: dts: qcom: sdm845: rename labels for DSI nodes") 8721e18ca696 ("arm64: dts: qcom: enable dual ("bonded") DSI mode for DB845c") 39e0f8076f6f ("arm64: dts: qcom: sdm845-tama: Enable remoteprocs") 5dcc6587fde2 ("arm64: dts: qcom: sdm845-tama: Add display nodes") e12482e68830 ("arm64: dts: qcom: sdm845-xiaomi-beryllium: drop invalid panel properties") 9f3c858ecde0 ("arm64: dts: qcom: sdm845-oneplus: drop invalid panel properties") 4ce03bb80fae ("arm64: dts: qcom: sdm845-tama: Add volume up and camera GPIO keys") a1a685c312f5 ("arm64: dts: qcom: sdm845: Add compat qcom,sdm845-dsi-ctrl") ea25d61b448a ("arm64: dts: qcom: Use plural _gpios node label for PMIC gpios") 67e75cfea375 ("arm64: dts: qcom: Add Lenovo Tab P11 (J606F/XiaoXin Pad) dts") cb3920b50b4d ("arm64: dts: qcom: align LED node names with dtschema") f86ae6f23a9e ("arm64: dts: qcom: sagit: add initial device tree for sagit") 0d97fdf380b4 ("arm64: dts: qcom: Add configuration for PMI8950 peripheral") e07f41b0e1db ("arm64: dts: qcom: Add configuration for PM8950 peripheral") 108162894a5d ("arm64: dts: qcom: sdm845-*: Fix up comments") 4ba146dd8897 ("arm64: dts: qcom: sm6125-seine: Configure additional trinket thermistors") 7401035f2ef8 ("arm64: dts: qcom: sm6125-seine: Include PM6125 and configure PON") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From cf4d6d54eadb60d2ee4d31c9d92299f5e8dcb55c Mon Sep 17 00:00:00 2001 From: Krishna Kurapati <quic_kriskura(a)quicinc.com> Date: Thu, 4 Jul 2024 20:58:48 +0530 Subject: [PATCH] arm64: dts: qcom: sdm845: Disable SS instance in Parkmode for USB For Gen-1 targets like SDM845, it is seen that stressing out the controller in host mode results in HC died error: xhci-hcd.12.auto: xHCI host not responding to stop endpoint command xhci-hcd.12.auto: xHCI host controller not responding, assume dead xhci-hcd.12.auto: HC died; cleaning up And at this instant only restarting the host mode fixes it. Disable SuperSpeed instance in park mode for SDM845 to mitigate this issue. Cc: stable(a)vger.kernel.org Fixes: ca4db2b538a1 ("arm64: dts: qcom: sdm845: Add USB-related nodes") Signed-off-by: Krishna Kurapati <quic_kriskura(a)quicinc.com> Reviewed-by: Konrad Dybcio <konrad.dybcio(a)linaro.org> Link: https://lore.kernel.org/r/20240704152848.3380602-9-quic_kriskura@quicinc.com Signed-off-by: Bjorn Andersson <andersson(a)kernel.org> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index 23b101bb3842..54077549b9da 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -4138,6 +4138,7 @@ usb_1_dwc3: usb@a600000 { iommus = <&apps_smmu 0x740 0>; snps,dis_u2_susphy_quirk; snps,dis_enblslpm_quirk; + snps,parkmode-disable-ss-quirk; phys = <&usb_1_hsphy>, <&usb_1_qmpphy QMP_USB43DP_USB3_PHY>; phy-names = "usb2-phy", "usb3-phy"; @@ -4213,6 +4214,7 @@ usb_2_dwc3: usb@a800000 { iommus = <&apps_smmu 0x760 0>; snps,dis_u2_susphy_quirk; snps,dis_enblslpm_quirk; + snps,parkmode-disable-ss-quirk; phys = <&usb_2_hsphy>, <&usb_2_qmpphy>; phy-names = "usb2-phy", "usb3-phy"; };

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] arm64: dts: qcom: sdm845: Disable SS instance in Parkmode for" failed to apply to 5.4-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.4.y git checkout FETCH_HEAD git cherry-pick -x cf4d6d54eadb60d2ee4d31c9d92299f5e8dcb55c # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072512-saline-founder-7ebe@gregkh' --subject-prefix 'PATCH 5.4.y' HEAD^.. Possible dependencies: cf4d6d54eadb ("arm64: dts: qcom: sdm845: Disable SS instance in Parkmode for USB") ca5ca568d738 ("arm64: dts: qcom: sdm845: switch USB QMP PHY to new style of bindings") a9ecdec45a3a ("arm64: dts: qcom: sdm845: switch USB+DP QMP PHY to new style of bindings") 8fe25ba3ffec ("arm64: dts: qcom: sdm845: rename labels for DSI nodes") 8721e18ca696 ("arm64: dts: qcom: enable dual ("bonded") DSI mode for DB845c") 39e0f8076f6f ("arm64: dts: qcom: sdm845-tama: Enable remoteprocs") 5dcc6587fde2 ("arm64: dts: qcom: sdm845-tama: Add display nodes") e12482e68830 ("arm64: dts: qcom: sdm845-xiaomi-beryllium: drop invalid panel properties") 9f3c858ecde0 ("arm64: dts: qcom: sdm845-oneplus: drop invalid panel properties") 4ce03bb80fae ("arm64: dts: qcom: sdm845-tama: Add volume up and camera GPIO keys") a1a685c312f5 ("arm64: dts: qcom: sdm845: Add compat qcom,sdm845-dsi-ctrl") ea25d61b448a ("arm64: dts: qcom: Use plural _gpios node label for PMIC gpios") 67e75cfea375 ("arm64: dts: qcom: Add Lenovo Tab P11 (J606F/XiaoXin Pad) dts") cb3920b50b4d ("arm64: dts: qcom: align LED node names with dtschema") f86ae6f23a9e ("arm64: dts: qcom: sagit: add initial device tree for sagit") 0d97fdf380b4 ("arm64: dts: qcom: Add configuration for PMI8950 peripheral") e07f41b0e1db ("arm64: dts: qcom: Add configuration for PM8950 peripheral") 108162894a5d ("arm64: dts: qcom: sdm845-*: Fix up comments") 4ba146dd8897 ("arm64: dts: qcom: sm6125-seine: Configure additional trinket thermistors") 7401035f2ef8 ("arm64: dts: qcom: sm6125-seine: Include PM6125 and configure PON") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From cf4d6d54eadb60d2ee4d31c9d92299f5e8dcb55c Mon Sep 17 00:00:00 2001 From: Krishna Kurapati <quic_kriskura(a)quicinc.com> Date: Thu, 4 Jul 2024 20:58:48 +0530 Subject: [PATCH] arm64: dts: qcom: sdm845: Disable SS instance in Parkmode for USB For Gen-1 targets like SDM845, it is seen that stressing out the controller in host mode results in HC died error: xhci-hcd.12.auto: xHCI host not responding to stop endpoint command xhci-hcd.12.auto: xHCI host controller not responding, assume dead xhci-hcd.12.auto: HC died; cleaning up And at this instant only restarting the host mode fixes it. Disable SuperSpeed instance in park mode for SDM845 to mitigate this issue. Cc: stable(a)vger.kernel.org Fixes: ca4db2b538a1 ("arm64: dts: qcom: sdm845: Add USB-related nodes") Signed-off-by: Krishna Kurapati <quic_kriskura(a)quicinc.com> Reviewed-by: Konrad Dybcio <konrad.dybcio(a)linaro.org> Link: https://lore.kernel.org/r/20240704152848.3380602-9-quic_kriskura@quicinc.com Signed-off-by: Bjorn Andersson <andersson(a)kernel.org> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index 23b101bb3842..54077549b9da 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -4138,6 +4138,7 @@ usb_1_dwc3: usb@a600000 { iommus = <&apps_smmu 0x740 0>; snps,dis_u2_susphy_quirk; snps,dis_enblslpm_quirk; + snps,parkmode-disable-ss-quirk; phys = <&usb_1_hsphy>, <&usb_1_qmpphy QMP_USB43DP_USB3_PHY>; phy-names = "usb2-phy", "usb3-phy"; @@ -4213,6 +4214,7 @@ usb_2_dwc3: usb@a800000 { iommus = <&apps_smmu 0x760 0>; snps,dis_u2_susphy_quirk; snps,dis_enblslpm_quirk; + snps,parkmode-disable-ss-quirk; phys = <&usb_2_hsphy>, <&usb_2_qmpphy>; phy-names = "usb2-phy", "usb3-phy"; };

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] arm64: dts: qcom: sdm845: Disable SS instance in Parkmode for" failed to apply to 5.10-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x cf4d6d54eadb60d2ee4d31c9d92299f5e8dcb55c # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072511-taco-reveler-c562@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^.. Possible dependencies: cf4d6d54eadb ("arm64: dts: qcom: sdm845: Disable SS instance in Parkmode for USB") ca5ca568d738 ("arm64: dts: qcom: sdm845: switch USB QMP PHY to new style of bindings") a9ecdec45a3a ("arm64: dts: qcom: sdm845: switch USB+DP QMP PHY to new style of bindings") 8fe25ba3ffec ("arm64: dts: qcom: sdm845: rename labels for DSI nodes") 8721e18ca696 ("arm64: dts: qcom: enable dual ("bonded") DSI mode for DB845c") 39e0f8076f6f ("arm64: dts: qcom: sdm845-tama: Enable remoteprocs") 5dcc6587fde2 ("arm64: dts: qcom: sdm845-tama: Add display nodes") e12482e68830 ("arm64: dts: qcom: sdm845-xiaomi-beryllium: drop invalid panel properties") 9f3c858ecde0 ("arm64: dts: qcom: sdm845-oneplus: drop invalid panel properties") 4ce03bb80fae ("arm64: dts: qcom: sdm845-tama: Add volume up and camera GPIO keys") a1a685c312f5 ("arm64: dts: qcom: sdm845: Add compat qcom,sdm845-dsi-ctrl") ea25d61b448a ("arm64: dts: qcom: Use plural _gpios node label for PMIC gpios") 67e75cfea375 ("arm64: dts: qcom: Add Lenovo Tab P11 (J606F/XiaoXin Pad) dts") cb3920b50b4d ("arm64: dts: qcom: align LED node names with dtschema") f86ae6f23a9e ("arm64: dts: qcom: sagit: add initial device tree for sagit") 0d97fdf380b4 ("arm64: dts: qcom: Add configuration for PMI8950 peripheral") e07f41b0e1db ("arm64: dts: qcom: Add configuration for PM8950 peripheral") 108162894a5d ("arm64: dts: qcom: sdm845-*: Fix up comments") 4ba146dd8897 ("arm64: dts: qcom: sm6125-seine: Configure additional trinket thermistors") 7401035f2ef8 ("arm64: dts: qcom: sm6125-seine: Include PM6125 and configure PON") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From cf4d6d54eadb60d2ee4d31c9d92299f5e8dcb55c Mon Sep 17 00:00:00 2001 From: Krishna Kurapati <quic_kriskura(a)quicinc.com> Date: Thu, 4 Jul 2024 20:58:48 +0530 Subject: [PATCH] arm64: dts: qcom: sdm845: Disable SS instance in Parkmode for USB For Gen-1 targets like SDM845, it is seen that stressing out the controller in host mode results in HC died error: xhci-hcd.12.auto: xHCI host not responding to stop endpoint command xhci-hcd.12.auto: xHCI host controller not responding, assume dead xhci-hcd.12.auto: HC died; cleaning up And at this instant only restarting the host mode fixes it. Disable SuperSpeed instance in park mode for SDM845 to mitigate this issue. Cc: stable(a)vger.kernel.org Fixes: ca4db2b538a1 ("arm64: dts: qcom: sdm845: Add USB-related nodes") Signed-off-by: Krishna Kurapati <quic_kriskura(a)quicinc.com> Reviewed-by: Konrad Dybcio <konrad.dybcio(a)linaro.org> Link: https://lore.kernel.org/r/20240704152848.3380602-9-quic_kriskura@quicinc.com Signed-off-by: Bjorn Andersson <andersson(a)kernel.org> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index 23b101bb3842..54077549b9da 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -4138,6 +4138,7 @@ usb_1_dwc3: usb@a600000 { iommus = <&apps_smmu 0x740 0>; snps,dis_u2_susphy_quirk; snps,dis_enblslpm_quirk; + snps,parkmode-disable-ss-quirk; phys = <&usb_1_hsphy>, <&usb_1_qmpphy QMP_USB43DP_USB3_PHY>; phy-names = "usb2-phy", "usb3-phy"; @@ -4213,6 +4214,7 @@ usb_2_dwc3: usb@a800000 { iommus = <&apps_smmu 0x760 0>; snps,dis_u2_susphy_quirk; snps,dis_enblslpm_quirk; + snps,parkmode-disable-ss-quirk; phys = <&usb_2_hsphy>, <&usb_2_qmpphy>; phy-names = "usb2-phy", "usb3-phy"; };

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] arm64: dts: qcom: sdm845: Disable SS instance in Parkmode for" failed to apply to 5.15-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.15-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.15.y git checkout FETCH_HEAD git cherry-pick -x cf4d6d54eadb60d2ee4d31c9d92299f5e8dcb55c # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072511-kinetic-stumbling-e918@gregkh' --subject-prefix 'PATCH 5.15.y' HEAD^.. Possible dependencies: cf4d6d54eadb ("arm64: dts: qcom: sdm845: Disable SS instance in Parkmode for USB") ca5ca568d738 ("arm64: dts: qcom: sdm845: switch USB QMP PHY to new style of bindings") a9ecdec45a3a ("arm64: dts: qcom: sdm845: switch USB+DP QMP PHY to new style of bindings") 8fe25ba3ffec ("arm64: dts: qcom: sdm845: rename labels for DSI nodes") 8721e18ca696 ("arm64: dts: qcom: enable dual ("bonded") DSI mode for DB845c") 39e0f8076f6f ("arm64: dts: qcom: sdm845-tama: Enable remoteprocs") 5dcc6587fde2 ("arm64: dts: qcom: sdm845-tama: Add display nodes") e12482e68830 ("arm64: dts: qcom: sdm845-xiaomi-beryllium: drop invalid panel properties") 9f3c858ecde0 ("arm64: dts: qcom: sdm845-oneplus: drop invalid panel properties") 4ce03bb80fae ("arm64: dts: qcom: sdm845-tama: Add volume up and camera GPIO keys") a1a685c312f5 ("arm64: dts: qcom: sdm845: Add compat qcom,sdm845-dsi-ctrl") ea25d61b448a ("arm64: dts: qcom: Use plural _gpios node label for PMIC gpios") 67e75cfea375 ("arm64: dts: qcom: Add Lenovo Tab P11 (J606F/XiaoXin Pad) dts") cb3920b50b4d ("arm64: dts: qcom: align LED node names with dtschema") f86ae6f23a9e ("arm64: dts: qcom: sagit: add initial device tree for sagit") 0d97fdf380b4 ("arm64: dts: qcom: Add configuration for PMI8950 peripheral") e07f41b0e1db ("arm64: dts: qcom: Add configuration for PM8950 peripheral") 108162894a5d ("arm64: dts: qcom: sdm845-*: Fix up comments") 4ba146dd8897 ("arm64: dts: qcom: sm6125-seine: Configure additional trinket thermistors") 7401035f2ef8 ("arm64: dts: qcom: sm6125-seine: Include PM6125 and configure PON") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From cf4d6d54eadb60d2ee4d31c9d92299f5e8dcb55c Mon Sep 17 00:00:00 2001 From: Krishna Kurapati <quic_kriskura(a)quicinc.com> Date: Thu, 4 Jul 2024 20:58:48 +0530 Subject: [PATCH] arm64: dts: qcom: sdm845: Disable SS instance in Parkmode for USB For Gen-1 targets like SDM845, it is seen that stressing out the controller in host mode results in HC died error: xhci-hcd.12.auto: xHCI host not responding to stop endpoint command xhci-hcd.12.auto: xHCI host controller not responding, assume dead xhci-hcd.12.auto: HC died; cleaning up And at this instant only restarting the host mode fixes it. Disable SuperSpeed instance in park mode for SDM845 to mitigate this issue. Cc: stable(a)vger.kernel.org Fixes: ca4db2b538a1 ("arm64: dts: qcom: sdm845: Add USB-related nodes") Signed-off-by: Krishna Kurapati <quic_kriskura(a)quicinc.com> Reviewed-by: Konrad Dybcio <konrad.dybcio(a)linaro.org> Link: https://lore.kernel.org/r/20240704152848.3380602-9-quic_kriskura@quicinc.com Signed-off-by: Bjorn Andersson <andersson(a)kernel.org> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index 23b101bb3842..54077549b9da 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -4138,6 +4138,7 @@ usb_1_dwc3: usb@a600000 { iommus = <&apps_smmu 0x740 0>; snps,dis_u2_susphy_quirk; snps,dis_enblslpm_quirk; + snps,parkmode-disable-ss-quirk; phys = <&usb_1_hsphy>, <&usb_1_qmpphy QMP_USB43DP_USB3_PHY>; phy-names = "usb2-phy", "usb3-phy"; @@ -4213,6 +4214,7 @@ usb_2_dwc3: usb@a800000 { iommus = <&apps_smmu 0x760 0>; snps,dis_u2_susphy_quirk; snps,dis_enblslpm_quirk; + snps,parkmode-disable-ss-quirk; phys = <&usb_2_hsphy>, <&usb_2_qmpphy>; phy-names = "usb2-phy", "usb3-phy"; };

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] arm64: dts: qcom: sdm845: Disable SS instance in Parkmode for" failed to apply to 6.1-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.1-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.1.y git checkout FETCH_HEAD git cherry-pick -x cf4d6d54eadb60d2ee4d31c9d92299f5e8dcb55c # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072510-await-likely-827c@gregkh' --subject-prefix 'PATCH 6.1.y' HEAD^.. Possible dependencies: cf4d6d54eadb ("arm64: dts: qcom: sdm845: Disable SS instance in Parkmode for USB") ca5ca568d738 ("arm64: dts: qcom: sdm845: switch USB QMP PHY to new style of bindings") a9ecdec45a3a ("arm64: dts: qcom: sdm845: switch USB+DP QMP PHY to new style of bindings") 8fe25ba3ffec ("arm64: dts: qcom: sdm845: rename labels for DSI nodes") 8721e18ca696 ("arm64: dts: qcom: enable dual ("bonded") DSI mode for DB845c") 39e0f8076f6f ("arm64: dts: qcom: sdm845-tama: Enable remoteprocs") 5dcc6587fde2 ("arm64: dts: qcom: sdm845-tama: Add display nodes") e12482e68830 ("arm64: dts: qcom: sdm845-xiaomi-beryllium: drop invalid panel properties") 9f3c858ecde0 ("arm64: dts: qcom: sdm845-oneplus: drop invalid panel properties") 4ce03bb80fae ("arm64: dts: qcom: sdm845-tama: Add volume up and camera GPIO keys") a1a685c312f5 ("arm64: dts: qcom: sdm845: Add compat qcom,sdm845-dsi-ctrl") ea25d61b448a ("arm64: dts: qcom: Use plural _gpios node label for PMIC gpios") 67e75cfea375 ("arm64: dts: qcom: Add Lenovo Tab P11 (J606F/XiaoXin Pad) dts") cb3920b50b4d ("arm64: dts: qcom: align LED node names with dtschema") f86ae6f23a9e ("arm64: dts: qcom: sagit: add initial device tree for sagit") 0d97fdf380b4 ("arm64: dts: qcom: Add configuration for PMI8950 peripheral") e07f41b0e1db ("arm64: dts: qcom: Add configuration for PM8950 peripheral") 108162894a5d ("arm64: dts: qcom: sdm845-*: Fix up comments") 4ba146dd8897 ("arm64: dts: qcom: sm6125-seine: Configure additional trinket thermistors") 7401035f2ef8 ("arm64: dts: qcom: sm6125-seine: Include PM6125 and configure PON") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From cf4d6d54eadb60d2ee4d31c9d92299f5e8dcb55c Mon Sep 17 00:00:00 2001 From: Krishna Kurapati <quic_kriskura(a)quicinc.com> Date: Thu, 4 Jul 2024 20:58:48 +0530 Subject: [PATCH] arm64: dts: qcom: sdm845: Disable SS instance in Parkmode for USB For Gen-1 targets like SDM845, it is seen that stressing out the controller in host mode results in HC died error: xhci-hcd.12.auto: xHCI host not responding to stop endpoint command xhci-hcd.12.auto: xHCI host controller not responding, assume dead xhci-hcd.12.auto: HC died; cleaning up And at this instant only restarting the host mode fixes it. Disable SuperSpeed instance in park mode for SDM845 to mitigate this issue. Cc: stable(a)vger.kernel.org Fixes: ca4db2b538a1 ("arm64: dts: qcom: sdm845: Add USB-related nodes") Signed-off-by: Krishna Kurapati <quic_kriskura(a)quicinc.com> Reviewed-by: Konrad Dybcio <konrad.dybcio(a)linaro.org> Link: https://lore.kernel.org/r/20240704152848.3380602-9-quic_kriskura@quicinc.com Signed-off-by: Bjorn Andersson <andersson(a)kernel.org> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index 23b101bb3842..54077549b9da 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -4138,6 +4138,7 @@ usb_1_dwc3: usb@a600000 { iommus = <&apps_smmu 0x740 0>; snps,dis_u2_susphy_quirk; snps,dis_enblslpm_quirk; + snps,parkmode-disable-ss-quirk; phys = <&usb_1_hsphy>, <&usb_1_qmpphy QMP_USB43DP_USB3_PHY>; phy-names = "usb2-phy", "usb3-phy"; @@ -4213,6 +4214,7 @@ usb_2_dwc3: usb@a800000 { iommus = <&apps_smmu 0x760 0>; snps,dis_u2_susphy_quirk; snps,dis_enblslpm_quirk; + snps,parkmode-disable-ss-quirk; phys = <&usb_2_hsphy>, <&usb_2_qmpphy>; phy-names = "usb2-phy", "usb3-phy"; };

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] arm64: dts: qcom: sdm845: Disable SS instance in Parkmode for" failed to apply to 6.6-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.6-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.6.y git checkout FETCH_HEAD git cherry-pick -x cf4d6d54eadb60d2ee4d31c9d92299f5e8dcb55c # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072509-chive-tabby-a6f1@gregkh' --subject-prefix 'PATCH 6.6.y' HEAD^.. Possible dependencies: cf4d6d54eadb ("arm64: dts: qcom: sdm845: Disable SS instance in Parkmode for USB") ca5ca568d738 ("arm64: dts: qcom: sdm845: switch USB QMP PHY to new style of bindings") a9ecdec45a3a ("arm64: dts: qcom: sdm845: switch USB+DP QMP PHY to new style of bindings") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From cf4d6d54eadb60d2ee4d31c9d92299f5e8dcb55c Mon Sep 17 00:00:00 2001 From: Krishna Kurapati <quic_kriskura(a)quicinc.com> Date: Thu, 4 Jul 2024 20:58:48 +0530 Subject: [PATCH] arm64: dts: qcom: sdm845: Disable SS instance in Parkmode for USB For Gen-1 targets like SDM845, it is seen that stressing out the controller in host mode results in HC died error: xhci-hcd.12.auto: xHCI host not responding to stop endpoint command xhci-hcd.12.auto: xHCI host controller not responding, assume dead xhci-hcd.12.auto: HC died; cleaning up And at this instant only restarting the host mode fixes it. Disable SuperSpeed instance in park mode for SDM845 to mitigate this issue. Cc: stable(a)vger.kernel.org Fixes: ca4db2b538a1 ("arm64: dts: qcom: sdm845: Add USB-related nodes") Signed-off-by: Krishna Kurapati <quic_kriskura(a)quicinc.com> Reviewed-by: Konrad Dybcio <konrad.dybcio(a)linaro.org> Link: https://lore.kernel.org/r/20240704152848.3380602-9-quic_kriskura@quicinc.com Signed-off-by: Bjorn Andersson <andersson(a)kernel.org> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index 23b101bb3842..54077549b9da 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -4138,6 +4138,7 @@ usb_1_dwc3: usb@a600000 { iommus = <&apps_smmu 0x740 0>; snps,dis_u2_susphy_quirk; snps,dis_enblslpm_quirk; + snps,parkmode-disable-ss-quirk; phys = <&usb_1_hsphy>, <&usb_1_qmpphy QMP_USB43DP_USB3_PHY>; phy-names = "usb2-phy", "usb3-phy"; @@ -4213,6 +4214,7 @@ usb_2_dwc3: usb@a800000 { iommus = <&apps_smmu 0x760 0>; snps,dis_u2_susphy_quirk; snps,dis_enblslpm_quirk; + snps,parkmode-disable-ss-quirk; phys = <&usb_2_hsphy>, <&usb_2_qmpphy>; phy-names = "usb2-phy", "usb3-phy"; };

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] arm64: dts: qcom: ipq8074: Disable SS instance in Parkmode" failed to apply to 5.10-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x dc6ba95c6c4400a84cca5b419b34ae852a08cfb5 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072552-victory-unpaid-afda@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^.. Possible dependencies: dc6ba95c6c44 ("arm64: dts: qcom: ipq8074: Disable SS instance in Parkmode for USB") d412786ab86b ("arm64: dts: qcom: ipq8074: remove USB tx-fifo-resize property") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From dc6ba95c6c4400a84cca5b419b34ae852a08cfb5 Mon Sep 17 00:00:00 2001 From: Krishna Kurapati <quic_kriskura(a)quicinc.com> Date: Thu, 4 Jul 2024 20:58:42 +0530 Subject: [PATCH] arm64: dts: qcom: ipq8074: Disable SS instance in Parkmode for USB For Gen-1 targets like IPQ8074, it is seen that stressing out the controller in host mode results in HC died error: xhci-hcd.12.auto: xHCI host not responding to stop endpoint command xhci-hcd.12.auto: xHCI host controller not responding, assume dead xhci-hcd.12.auto: HC died; cleaning up And at this instant only restarting the host mode fixes it. Disable SuperSpeed instance in park mode for IPQ8074 to mitigate this issue. Cc: stable(a)vger.kernel.org Fixes: 5e09bc51d07b ("arm64: dts: ipq8074: enable USB support") Signed-off-by: Krishna Kurapati <quic_kriskura(a)quicinc.com> Reviewed-by: Konrad Dybcio <konrad.dybcio(a)linaro.org> Link: https://lore.kernel.org/r/20240704152848.3380602-3-quic_kriskura@quicinc.com Signed-off-by: Bjorn Andersson <andersson(a)kernel.org> diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi index 92682d3c9478..284a4553070f 100644 --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi @@ -666,6 +666,7 @@ dwc_0: usb@8a00000 { interrupts = <GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>; phys = <&qusb_phy_0>, <&ssphy_0>; phy-names = "usb2-phy", "usb3-phy"; + snps,parkmode-disable-ss-quirk; snps,is-utmi-l1-suspend; snps,hird-threshold = /bits/ 8 <0x0>; snps,dis_u2_susphy_quirk; @@ -715,6 +716,7 @@ dwc_1: usb@8c00000 { interrupts = <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>; phys = <&qusb_phy_1>, <&ssphy_1>; phy-names = "usb2-phy", "usb3-phy"; + snps,parkmode-disable-ss-quirk; snps,is-utmi-l1-suspend; snps,hird-threshold = /bits/ 8 <0x0>; snps,dis_u2_susphy_quirk;

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] arm64: dts: qcom: ipq8074: Disable SS instance in Parkmode" failed to apply to 5.15-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.15-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.15.y git checkout FETCH_HEAD git cherry-pick -x dc6ba95c6c4400a84cca5b419b34ae852a08cfb5 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072552-twisty-harvest-26cd@gregkh' --subject-prefix 'PATCH 5.15.y' HEAD^.. Possible dependencies: dc6ba95c6c44 ("arm64: dts: qcom: ipq8074: Disable SS instance in Parkmode for USB") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From dc6ba95c6c4400a84cca5b419b34ae852a08cfb5 Mon Sep 17 00:00:00 2001 From: Krishna Kurapati <quic_kriskura(a)quicinc.com> Date: Thu, 4 Jul 2024 20:58:42 +0530 Subject: [PATCH] arm64: dts: qcom: ipq8074: Disable SS instance in Parkmode for USB For Gen-1 targets like IPQ8074, it is seen that stressing out the controller in host mode results in HC died error: xhci-hcd.12.auto: xHCI host not responding to stop endpoint command xhci-hcd.12.auto: xHCI host controller not responding, assume dead xhci-hcd.12.auto: HC died; cleaning up And at this instant only restarting the host mode fixes it. Disable SuperSpeed instance in park mode for IPQ8074 to mitigate this issue. Cc: stable(a)vger.kernel.org Fixes: 5e09bc51d07b ("arm64: dts: ipq8074: enable USB support") Signed-off-by: Krishna Kurapati <quic_kriskura(a)quicinc.com> Reviewed-by: Konrad Dybcio <konrad.dybcio(a)linaro.org> Link: https://lore.kernel.org/r/20240704152848.3380602-3-quic_kriskura@quicinc.com Signed-off-by: Bjorn Andersson <andersson(a)kernel.org> diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi index 92682d3c9478..284a4553070f 100644 --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi @@ -666,6 +666,7 @@ dwc_0: usb@8a00000 { interrupts = <GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>; phys = <&qusb_phy_0>, <&ssphy_0>; phy-names = "usb2-phy", "usb3-phy"; + snps,parkmode-disable-ss-quirk; snps,is-utmi-l1-suspend; snps,hird-threshold = /bits/ 8 <0x0>; snps,dis_u2_susphy_quirk; @@ -715,6 +716,7 @@ dwc_1: usb@8c00000 { interrupts = <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>; phys = <&qusb_phy_1>, <&ssphy_1>; phy-names = "usb2-phy", "usb3-phy"; + snps,parkmode-disable-ss-quirk; snps,is-utmi-l1-suspend; snps,hird-threshold = /bits/ 8 <0x0>; snps,dis_u2_susphy_quirk;

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] arm64: dts: qcom: ipq8074: Disable SS instance in Parkmode" failed to apply to 6.1-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.1-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.1.y git checkout FETCH_HEAD git cherry-pick -x dc6ba95c6c4400a84cca5b419b34ae852a08cfb5 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072551-chain-finalist-0cb0@gregkh' --subject-prefix 'PATCH 6.1.y' HEAD^.. Possible dependencies: dc6ba95c6c44 ("arm64: dts: qcom: ipq8074: Disable SS instance in Parkmode for USB") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From dc6ba95c6c4400a84cca5b419b34ae852a08cfb5 Mon Sep 17 00:00:00 2001 From: Krishna Kurapati <quic_kriskura(a)quicinc.com> Date: Thu, 4 Jul 2024 20:58:42 +0530 Subject: [PATCH] arm64: dts: qcom: ipq8074: Disable SS instance in Parkmode for USB For Gen-1 targets like IPQ8074, it is seen that stressing out the controller in host mode results in HC died error: xhci-hcd.12.auto: xHCI host not responding to stop endpoint command xhci-hcd.12.auto: xHCI host controller not responding, assume dead xhci-hcd.12.auto: HC died; cleaning up And at this instant only restarting the host mode fixes it. Disable SuperSpeed instance in park mode for IPQ8074 to mitigate this issue. Cc: stable(a)vger.kernel.org Fixes: 5e09bc51d07b ("arm64: dts: ipq8074: enable USB support") Signed-off-by: Krishna Kurapati <quic_kriskura(a)quicinc.com> Reviewed-by: Konrad Dybcio <konrad.dybcio(a)linaro.org> Link: https://lore.kernel.org/r/20240704152848.3380602-3-quic_kriskura@quicinc.com Signed-off-by: Bjorn Andersson <andersson(a)kernel.org> diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi index 92682d3c9478..284a4553070f 100644 --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi @@ -666,6 +666,7 @@ dwc_0: usb@8a00000 { interrupts = <GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>; phys = <&qusb_phy_0>, <&ssphy_0>; phy-names = "usb2-phy", "usb3-phy"; + snps,parkmode-disable-ss-quirk; snps,is-utmi-l1-suspend; snps,hird-threshold = /bits/ 8 <0x0>; snps,dis_u2_susphy_quirk; @@ -715,6 +716,7 @@ dwc_1: usb@8c00000 { interrupts = <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>; phys = <&qusb_phy_1>, <&ssphy_1>; phy-names = "usb2-phy", "usb3-phy"; + snps,parkmode-disable-ss-quirk; snps,is-utmi-l1-suspend; snps,hird-threshold = /bits/ 8 <0x0>; snps,dis_u2_susphy_quirk;

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] arm64: dts: qcom: ipq8074: Disable SS instance in Parkmode" failed to apply to 6.6-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.6-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.6.y git checkout FETCH_HEAD git cherry-pick -x dc6ba95c6c4400a84cca5b419b34ae852a08cfb5 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072550-editor-edging-bfb4@gregkh' --subject-prefix 'PATCH 6.6.y' HEAD^.. Possible dependencies: dc6ba95c6c44 ("arm64: dts: qcom: ipq8074: Disable SS instance in Parkmode for USB") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From dc6ba95c6c4400a84cca5b419b34ae852a08cfb5 Mon Sep 17 00:00:00 2001 From: Krishna Kurapati <quic_kriskura(a)quicinc.com> Date: Thu, 4 Jul 2024 20:58:42 +0530 Subject: [PATCH] arm64: dts: qcom: ipq8074: Disable SS instance in Parkmode for USB For Gen-1 targets like IPQ8074, it is seen that stressing out the controller in host mode results in HC died error: xhci-hcd.12.auto: xHCI host not responding to stop endpoint command xhci-hcd.12.auto: xHCI host controller not responding, assume dead xhci-hcd.12.auto: HC died; cleaning up And at this instant only restarting the host mode fixes it. Disable SuperSpeed instance in park mode for IPQ8074 to mitigate this issue. Cc: stable(a)vger.kernel.org Fixes: 5e09bc51d07b ("arm64: dts: ipq8074: enable USB support") Signed-off-by: Krishna Kurapati <quic_kriskura(a)quicinc.com> Reviewed-by: Konrad Dybcio <konrad.dybcio(a)linaro.org> Link: https://lore.kernel.org/r/20240704152848.3380602-3-quic_kriskura@quicinc.com Signed-off-by: Bjorn Andersson <andersson(a)kernel.org> diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi index 92682d3c9478..284a4553070f 100644 --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi @@ -666,6 +666,7 @@ dwc_0: usb@8a00000 { interrupts = <GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>; phys = <&qusb_phy_0>, <&ssphy_0>; phy-names = "usb2-phy", "usb3-phy"; + snps,parkmode-disable-ss-quirk; snps,is-utmi-l1-suspend; snps,hird-threshold = /bits/ 8 <0x0>; snps,dis_u2_susphy_quirk; @@ -715,6 +716,7 @@ dwc_1: usb@8c00000 { interrupts = <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>; phys = <&qusb_phy_1>, <&ssphy_1>; phy-names = "usb2-phy", "usb3-phy"; + snps,parkmode-disable-ss-quirk; snps,is-utmi-l1-suspend; snps,hird-threshold = /bits/ 8 <0x0>; snps,dis_u2_susphy_quirk;

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] arm64: dts: qcom: msm8998: Disable SS instance in Parkmode" failed to apply to 5.4-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.4.y git checkout FETCH_HEAD git cherry-pick -x 0046325ae52079b46da13a7f84dd7b2a6f7c38f8 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072511-underfeed-acclaim-5e48@gregkh' --subject-prefix 'PATCH 5.4.y' HEAD^.. Possible dependencies: 0046325ae520 ("arm64: dts: qcom: msm8998: Disable SS instance in Parkmode for USB") b7efebfeb2e8 ("arm64: dts: qcom: msm8998: switch USB QMP PHY to new style of bindings") ed9cbbcb8c6a ("arm64: dts: qcom: msm8998: drop USB PHY clock index") 1351512f29b4 ("arm64: dts: qcom: Correct QMP PHY child node name") 82d61e19fccb ("arm64: dts: qcom: msm8996: Move '#clock-cells' to QMP PHY child node") 095bbdd9a5c3 ("arm64: dts: qcom: ipq6018: Add pcie support") 63fa43224696 ("arm64: dts: qcom: sm8250: fix usb2 qmp phy node") dc2f86369b15 ("arm64: dts: qcom: sm8250: Fix pcie2_lane unit address") 59c7cf814783 ("arm64: dts: qcom: sm8350: Add UFS nodes") e780fb318fe5 ("arm64: dts: qcom: sm8350: add USB and PHY device nodes") e53bdfc00977 ("arm64: dts: qcom: sm8250: Add PCIe support") b7e8f433a673 ("arm64: dts: qcom: Add basic devicetree support for SM8350 SoC") 46a6f297d7dd ("arm64: dts: qcom: sm8250: Add USB and PHY device nodes") 0c9dde0d2015 ("arm64: dts: qcom: sm8150: Add secondary USB and PHY nodes") e7e41a207a3e ("arm64: dts: qcom: sm8250: add interconnect nodes") 71a2fc6e7b30 ("arm64: dts: qcom: sm8150: add interconnect nodes") dff0f49cda84 ("arm64: dts: qcom: sm8250: Drop tcsr_mutex syscon") 5e09bc51d07b ("arm64: dts: ipq8074: enable USB support") 23a8903785b9 ("arm64: dts: qcom: sm8250: Add remoteprocs") 16951b490b20 ("arm64: dts: qcom: sm8250: Add TLMM pinctrl node") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 0046325ae52079b46da13a7f84dd7b2a6f7c38f8 Mon Sep 17 00:00:00 2001 From: Krishna Kurapati <quic_kriskura(a)quicinc.com> Date: Thu, 4 Jul 2024 20:58:43 +0530 Subject: [PATCH] arm64: dts: qcom: msm8998: Disable SS instance in Parkmode for USB For Gen-1 targets like MSM8998, it is seen that stressing out the controller in host mode results in HC died error: xhci-hcd.12.auto: xHCI host not responding to stop endpoint command xhci-hcd.12.auto: xHCI host controller not responding, assume dead xhci-hcd.12.auto: HC died; cleaning up And at this instant only restarting the host mode fixes it. Disable SuperSpeed instance in park mode for MSM8998 to mitigate this issue. Cc: stable(a)vger.kernel.org Fixes: 026dad8f5873 ("arm64: dts: qcom: msm8998: Add USB-related nodes") Signed-off-by: Krishna Kurapati <quic_kriskura(a)quicinc.com> Reviewed-by: Konrad Dybcio <konrad.dybcio(a)linaro.org> Link: https://lore.kernel.org/r/20240704152848.3380602-4-quic_kriskura@quicinc.com Signed-off-by: Bjorn Andersson <andersson(a)kernel.org> diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi index 99f811a57ac5..7f44807b1b97 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi @@ -2144,6 +2144,7 @@ usb3_dwc3: usb@a800000 { interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>; snps,dis_u2_susphy_quirk; snps,dis_enblslpm_quirk; + snps,parkmode-disable-ss-quirk; phys = <&qusb2phy>, <&usb3phy>; phy-names = "usb2-phy", "usb3-phy"; snps,has-lpm-erratum;

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] arm64: dts: qcom: msm8998: Disable SS instance in Parkmode" failed to apply to 5.10-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x 0046325ae52079b46da13a7f84dd7b2a6f7c38f8 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072510-blade-spousal-6659@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^.. Possible dependencies: 0046325ae520 ("arm64: dts: qcom: msm8998: Disable SS instance in Parkmode for USB") b7efebfeb2e8 ("arm64: dts: qcom: msm8998: switch USB QMP PHY to new style of bindings") ed9cbbcb8c6a ("arm64: dts: qcom: msm8998: drop USB PHY clock index") 1351512f29b4 ("arm64: dts: qcom: Correct QMP PHY child node name") 82d61e19fccb ("arm64: dts: qcom: msm8996: Move '#clock-cells' to QMP PHY child node") 095bbdd9a5c3 ("arm64: dts: qcom: ipq6018: Add pcie support") 63fa43224696 ("arm64: dts: qcom: sm8250: fix usb2 qmp phy node") dc2f86369b15 ("arm64: dts: qcom: sm8250: Fix pcie2_lane unit address") 59c7cf814783 ("arm64: dts: qcom: sm8350: Add UFS nodes") e780fb318fe5 ("arm64: dts: qcom: sm8350: add USB and PHY device nodes") e53bdfc00977 ("arm64: dts: qcom: sm8250: Add PCIe support") b7e8f433a673 ("arm64: dts: qcom: Add basic devicetree support for SM8350 SoC") 46a6f297d7dd ("arm64: dts: qcom: sm8250: Add USB and PHY device nodes") 0c9dde0d2015 ("arm64: dts: qcom: sm8150: Add secondary USB and PHY nodes") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 0046325ae52079b46da13a7f84dd7b2a6f7c38f8 Mon Sep 17 00:00:00 2001 From: Krishna Kurapati <quic_kriskura(a)quicinc.com> Date: Thu, 4 Jul 2024 20:58:43 +0530 Subject: [PATCH] arm64: dts: qcom: msm8998: Disable SS instance in Parkmode for USB For Gen-1 targets like MSM8998, it is seen that stressing out the controller in host mode results in HC died error: xhci-hcd.12.auto: xHCI host not responding to stop endpoint command xhci-hcd.12.auto: xHCI host controller not responding, assume dead xhci-hcd.12.auto: HC died; cleaning up And at this instant only restarting the host mode fixes it. Disable SuperSpeed instance in park mode for MSM8998 to mitigate this issue. Cc: stable(a)vger.kernel.org Fixes: 026dad8f5873 ("arm64: dts: qcom: msm8998: Add USB-related nodes") Signed-off-by: Krishna Kurapati <quic_kriskura(a)quicinc.com> Reviewed-by: Konrad Dybcio <konrad.dybcio(a)linaro.org> Link: https://lore.kernel.org/r/20240704152848.3380602-4-quic_kriskura@quicinc.com Signed-off-by: Bjorn Andersson <andersson(a)kernel.org> diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi index 99f811a57ac5..7f44807b1b97 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi @@ -2144,6 +2144,7 @@ usb3_dwc3: usb@a800000 { interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>; snps,dis_u2_susphy_quirk; snps,dis_enblslpm_quirk; + snps,parkmode-disable-ss-quirk; phys = <&qusb2phy>, <&usb3phy>; phy-names = "usb2-phy", "usb3-phy"; snps,has-lpm-erratum;

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] arm64: dts: qcom: msm8998: Disable SS instance in Parkmode" failed to apply to 5.15-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.15-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.15.y git checkout FETCH_HEAD git cherry-pick -x 0046325ae52079b46da13a7f84dd7b2a6f7c38f8 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072509-coach-bronzing-2797@gregkh' --subject-prefix 'PATCH 5.15.y' HEAD^.. Possible dependencies: 0046325ae520 ("arm64: dts: qcom: msm8998: Disable SS instance in Parkmode for USB") b7efebfeb2e8 ("arm64: dts: qcom: msm8998: switch USB QMP PHY to new style of bindings") ed9cbbcb8c6a ("arm64: dts: qcom: msm8998: drop USB PHY clock index") 1351512f29b4 ("arm64: dts: qcom: Correct QMP PHY child node name") 82d61e19fccb ("arm64: dts: qcom: msm8996: Move '#clock-cells' to QMP PHY child node") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 0046325ae52079b46da13a7f84dd7b2a6f7c38f8 Mon Sep 17 00:00:00 2001 From: Krishna Kurapati <quic_kriskura(a)quicinc.com> Date: Thu, 4 Jul 2024 20:58:43 +0530 Subject: [PATCH] arm64: dts: qcom: msm8998: Disable SS instance in Parkmode for USB For Gen-1 targets like MSM8998, it is seen that stressing out the controller in host mode results in HC died error: xhci-hcd.12.auto: xHCI host not responding to stop endpoint command xhci-hcd.12.auto: xHCI host controller not responding, assume dead xhci-hcd.12.auto: HC died; cleaning up And at this instant only restarting the host mode fixes it. Disable SuperSpeed instance in park mode for MSM8998 to mitigate this issue. Cc: stable(a)vger.kernel.org Fixes: 026dad8f5873 ("arm64: dts: qcom: msm8998: Add USB-related nodes") Signed-off-by: Krishna Kurapati <quic_kriskura(a)quicinc.com> Reviewed-by: Konrad Dybcio <konrad.dybcio(a)linaro.org> Link: https://lore.kernel.org/r/20240704152848.3380602-4-quic_kriskura@quicinc.com Signed-off-by: Bjorn Andersson <andersson(a)kernel.org> diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi index 99f811a57ac5..7f44807b1b97 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi @@ -2144,6 +2144,7 @@ usb3_dwc3: usb@a800000 { interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>; snps,dis_u2_susphy_quirk; snps,dis_enblslpm_quirk; + snps,parkmode-disable-ss-quirk; phys = <&qusb2phy>, <&usb3phy>; phy-names = "usb2-phy", "usb3-phy"; snps,has-lpm-erratum;

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] arm64: dts: qcom: msm8998: Disable SS instance in Parkmode" failed to apply to 6.1-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.1-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.1.y git checkout FETCH_HEAD git cherry-pick -x 0046325ae52079b46da13a7f84dd7b2a6f7c38f8 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072508-musty-divisive-4413@gregkh' --subject-prefix 'PATCH 6.1.y' HEAD^.. Possible dependencies: 0046325ae520 ("arm64: dts: qcom: msm8998: Disable SS instance in Parkmode for USB") b7efebfeb2e8 ("arm64: dts: qcom: msm8998: switch USB QMP PHY to new style of bindings") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 0046325ae52079b46da13a7f84dd7b2a6f7c38f8 Mon Sep 17 00:00:00 2001 From: Krishna Kurapati <quic_kriskura(a)quicinc.com> Date: Thu, 4 Jul 2024 20:58:43 +0530 Subject: [PATCH] arm64: dts: qcom: msm8998: Disable SS instance in Parkmode for USB For Gen-1 targets like MSM8998, it is seen that stressing out the controller in host mode results in HC died error: xhci-hcd.12.auto: xHCI host not responding to stop endpoint command xhci-hcd.12.auto: xHCI host controller not responding, assume dead xhci-hcd.12.auto: HC died; cleaning up And at this instant only restarting the host mode fixes it. Disable SuperSpeed instance in park mode for MSM8998 to mitigate this issue. Cc: stable(a)vger.kernel.org Fixes: 026dad8f5873 ("arm64: dts: qcom: msm8998: Add USB-related nodes") Signed-off-by: Krishna Kurapati <quic_kriskura(a)quicinc.com> Reviewed-by: Konrad Dybcio <konrad.dybcio(a)linaro.org> Link: https://lore.kernel.org/r/20240704152848.3380602-4-quic_kriskura@quicinc.com Signed-off-by: Bjorn Andersson <andersson(a)kernel.org> diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi index 99f811a57ac5..7f44807b1b97 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi @@ -2144,6 +2144,7 @@ usb3_dwc3: usb@a800000 { interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>; snps,dis_u2_susphy_quirk; snps,dis_enblslpm_quirk; + snps,parkmode-disable-ss-quirk; phys = <&qusb2phy>, <&usb3phy>; phy-names = "usb2-phy", "usb3-phy"; snps,has-lpm-erratum;

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] arm64: dts: qcom: msm8998: Disable SS instance in Parkmode" failed to apply to 6.6-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.6-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.6.y git checkout FETCH_HEAD git cherry-pick -x 0046325ae52079b46da13a7f84dd7b2a6f7c38f8 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072508-equipment-maturely-32e1@gregkh' --subject-prefix 'PATCH 6.6.y' HEAD^.. Possible dependencies: 0046325ae520 ("arm64: dts: qcom: msm8998: Disable SS instance in Parkmode for USB") b7efebfeb2e8 ("arm64: dts: qcom: msm8998: switch USB QMP PHY to new style of bindings") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 0046325ae52079b46da13a7f84dd7b2a6f7c38f8 Mon Sep 17 00:00:00 2001 From: Krishna Kurapati <quic_kriskura(a)quicinc.com> Date: Thu, 4 Jul 2024 20:58:43 +0530 Subject: [PATCH] arm64: dts: qcom: msm8998: Disable SS instance in Parkmode for USB For Gen-1 targets like MSM8998, it is seen that stressing out the controller in host mode results in HC died error: xhci-hcd.12.auto: xHCI host not responding to stop endpoint command xhci-hcd.12.auto: xHCI host controller not responding, assume dead xhci-hcd.12.auto: HC died; cleaning up And at this instant only restarting the host mode fixes it. Disable SuperSpeed instance in park mode for MSM8998 to mitigate this issue. Cc: stable(a)vger.kernel.org Fixes: 026dad8f5873 ("arm64: dts: qcom: msm8998: Add USB-related nodes") Signed-off-by: Krishna Kurapati <quic_kriskura(a)quicinc.com> Reviewed-by: Konrad Dybcio <konrad.dybcio(a)linaro.org> Link: https://lore.kernel.org/r/20240704152848.3380602-4-quic_kriskura@quicinc.com Signed-off-by: Bjorn Andersson <andersson(a)kernel.org> diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi index 99f811a57ac5..7f44807b1b97 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi @@ -2144,6 +2144,7 @@ usb3_dwc3: usb@a800000 { interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>; snps,dis_u2_susphy_quirk; snps,dis_enblslpm_quirk; + snps,parkmode-disable-ss-quirk; phys = <&qusb2phy>, <&usb3phy>; phy-names = "usb2-phy", "usb3-phy"; snps,has-lpm-erratum;

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] arm64: dts: qcom: sm6350: Disable SS instance in Parkmode for" failed to apply to 6.1-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.1-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.1.y git checkout FETCH_HEAD git cherry-pick -x c5d57eb7d06df16c07037cea5dacfd74d49d1833 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072552-smock-demeanor-6259@gregkh' --subject-prefix 'PATCH 6.1.y' HEAD^.. Possible dependencies: c5d57eb7d06d ("arm64: dts: qcom: sm6350: Disable SS instance in Parkmode for USB") 5ed2b6388b31 ("arm64: dts: qcom: sm6350: Use specific qmpphy compatible") 347b9491c595 ("arm64: dts: qcom: sm6350: fix USB-DP PHY registers") 95fade4016cb ("arm64: dts: qcom: sm6350: drop bogus DP PHY clock") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From c5d57eb7d06df16c07037cea5dacfd74d49d1833 Mon Sep 17 00:00:00 2001 From: Krishna Kurapati <quic_kriskura(a)quicinc.com> Date: Thu, 4 Jul 2024 20:58:46 +0530 Subject: [PATCH] arm64: dts: qcom: sm6350: Disable SS instance in Parkmode for USB For Gen-1 targets like SM6350, it is seen that stressing out the controller in host mode results in HC died error: xhci-hcd.12.auto: xHCI host not responding to stop endpoint command xhci-hcd.12.auto: xHCI host controller not responding, assume dead xhci-hcd.12.auto: HC died; cleaning up And at this instant only restarting the host mode fixes it. Disable SuperSpeed instance in park mode for SM6350 to mitigate this issue. Cc: stable(a)vger.kernel.org Fixes: 23737b9557fe ("arm64: dts: qcom: sm6350: Add USB1 nodes") Signed-off-by: Krishna Kurapati <quic_kriskura(a)quicinc.com> Reviewed-by: Konrad Dybcio <konrad.dybcio(a)linaro.org> Link: https://lore.kernel.org/r/20240704152848.3380602-7-quic_kriskura@quicinc.com Signed-off-by: Bjorn Andersson <andersson(a)kernel.org> diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi index 46e122c4421c..84009b74aee7 100644 --- a/arch/arm64/boot/dts/qcom/sm6350.dtsi +++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi @@ -1921,6 +1921,7 @@ usb_1_dwc3: usb@a600000 { snps,dis_enblslpm_quirk; snps,has-lpm-erratum; snps,hird-threshold = /bits/ 8 <0x10>; + snps,parkmode-disable-ss-quirk; phys = <&usb_1_hsphy>, <&usb_1_qmpphy QMP_USB43DP_USB3_PHY>; phy-names = "usb2-phy", "usb3-phy"; usb-role-switch;

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] arm64: dts: qcom: msm8996: Disable SS instance in Parkmode" failed to apply to 4.19-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.19-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-4.19.y git checkout FETCH_HEAD git cherry-pick -x 44ea1ae3cf95db97e10d6ce17527948121f1dd4b # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072534-unguarded-atonable-f64d@gregkh' --subject-prefix 'PATCH 4.19.y' HEAD^.. Possible dependencies: 44ea1ae3cf95 ("arm64: dts: qcom: msm8996: Disable SS instance in Parkmode for USB") d0af0537e28f ("arm64: dts: qcom: msm8996: Add missing DWC3 quirks") 50aa72ccb30b ("arm64: dts: qcom: msm8996: Sort all nodes in msm8996.dtsi") 86f6d6225e5e ("arm64: dts: qcom: msm8996: Pad addresses") 808844314309 ("arm64: dts: qcom: msm8996: Move regulator consumers to db820c") 75b77d6492eb ("arm64: dts: qcom: msm8996: Use node references in db820c") f978d45b4aab ("arm64: dts: qcom: db820c: Move non-soc entries out of /soc") d026c96b25b7 ("arm64: dts: qcom: msm8996: Disable USB2 PHY suspend by core") 4e300e439af3 ("arm64: dts: qcom: msm8996: Add Venus video codec DT node") d98de8efa19f ("arm64: dts: qcom: msm8996: Add Coresight support") 887e54218183 ("arm64: dts: qcom: msm8996: Rename smmu nodes") 72825e7f4a63 ("arm64: dts: qcom: msm8996: Enable SMMUs") 64a68a736068 ("arm64: dts: qcom: msm8996: Correct apr-domain property") 693e824452e5 ("arm64: dts: qcom: msm8996: Stop using legacy clock names") 3a2b37b09f74 ("arm64: dts: msm8996: Add UFS PHY reset controller") f3eb39a55a1f ("arm64: dts: db820c: Add sound card support") 1ad69b695582 ("arm64: dts: apq8096-db820c: Add HDMI display support") 69cc3114ab0f ("arm64: dts: Add Adreno GPU definitions") 3a4547c1fc2f ("arm64: qcom: msm8996.dtsi: Add Display nodes") 953f65737006 ("arm64: dts: msm8996: Add display smmu node") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 44ea1ae3cf95db97e10d6ce17527948121f1dd4b Mon Sep 17 00:00:00 2001 From: Krishna Kurapati <quic_kriskura(a)quicinc.com> Date: Thu, 4 Jul 2024 20:58:47 +0530 Subject: [PATCH] arm64: dts: qcom: msm8996: Disable SS instance in Parkmode for USB For Gen-1 targets like MSM8996, it is seen that stressing out the controller in host mode results in HC died error: xhci-hcd.12.auto: xHCI host not responding to stop endpoint command xhci-hcd.12.auto: xHCI host controller not responding, assume dead xhci-hcd.12.auto: HC died; cleaning up And at this instant only restarting the host mode fixes it. Disable SuperSpeed instance in park mode for MSM8996 to mitigate this issue. Cc: stable(a)vger.kernel.org Fixes: 1e39255ed29d ("arm64: dts: msm8996: Add device node for qcom,dwc3") Signed-off-by: Krishna Kurapati <quic_kriskura(a)quicinc.com> Reviewed-by: Konrad Dybcio <konrad.dybcio(a)linaro.org> Link: https://lore.kernel.org/r/20240704152848.3380602-8-quic_kriskura@quicinc.com Signed-off-by: Bjorn Andersson <andersson(a)kernel.org> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index 2b20cedfe26c..0fd2b1b944a5 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -3101,6 +3101,7 @@ usb3_dwc3: usb@6a00000 { snps,dis_u2_susphy_quirk; snps,dis_enblslpm_quirk; snps,is-utmi-l1-suspend; + snps,parkmode-disable-ss-quirk; tx-fifo-resize; }; };

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] arm64: dts: qcom: msm8996: Disable SS instance in Parkmode" failed to apply to 5.4-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.4.y git checkout FETCH_HEAD git cherry-pick -x 44ea1ae3cf95db97e10d6ce17527948121f1dd4b # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072533-splurge-kung-54fa@gregkh' --subject-prefix 'PATCH 5.4.y' HEAD^.. Possible dependencies: 44ea1ae3cf95 ("arm64: dts: qcom: msm8996: Disable SS instance in Parkmode for USB") d0af0537e28f ("arm64: dts: qcom: msm8996: Add missing DWC3 quirks") 50aa72ccb30b ("arm64: dts: qcom: msm8996: Sort all nodes in msm8996.dtsi") 86f6d6225e5e ("arm64: dts: qcom: msm8996: Pad addresses") 808844314309 ("arm64: dts: qcom: msm8996: Move regulator consumers to db820c") 75b77d6492eb ("arm64: dts: qcom: msm8996: Use node references in db820c") f978d45b4aab ("arm64: dts: qcom: db820c: Move non-soc entries out of /soc") d026c96b25b7 ("arm64: dts: qcom: msm8996: Disable USB2 PHY suspend by core") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 44ea1ae3cf95db97e10d6ce17527948121f1dd4b Mon Sep 17 00:00:00 2001 From: Krishna Kurapati <quic_kriskura(a)quicinc.com> Date: Thu, 4 Jul 2024 20:58:47 +0530 Subject: [PATCH] arm64: dts: qcom: msm8996: Disable SS instance in Parkmode for USB For Gen-1 targets like MSM8996, it is seen that stressing out the controller in host mode results in HC died error: xhci-hcd.12.auto: xHCI host not responding to stop endpoint command xhci-hcd.12.auto: xHCI host controller not responding, assume dead xhci-hcd.12.auto: HC died; cleaning up And at this instant only restarting the host mode fixes it. Disable SuperSpeed instance in park mode for MSM8996 to mitigate this issue. Cc: stable(a)vger.kernel.org Fixes: 1e39255ed29d ("arm64: dts: msm8996: Add device node for qcom,dwc3") Signed-off-by: Krishna Kurapati <quic_kriskura(a)quicinc.com> Reviewed-by: Konrad Dybcio <konrad.dybcio(a)linaro.org> Link: https://lore.kernel.org/r/20240704152848.3380602-8-quic_kriskura@quicinc.com Signed-off-by: Bjorn Andersson <andersson(a)kernel.org> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index 2b20cedfe26c..0fd2b1b944a5 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -3101,6 +3101,7 @@ usb3_dwc3: usb@6a00000 { snps,dis_u2_susphy_quirk; snps,dis_enblslpm_quirk; snps,is-utmi-l1-suspend; + snps,parkmode-disable-ss-quirk; tx-fifo-resize; }; };

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] arm64: dts: qcom: sc7280: Disable SuperSpeed instances in" failed to apply to 5.15-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.15-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.15.y git checkout FETCH_HEAD git cherry-pick -x 3d930f1750ce30a6c36dbc71f8ff7e20322b94d7 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072515-shifting-impulse-0512@gregkh' --subject-prefix 'PATCH 5.15.y' HEAD^.. Possible dependencies: 3d930f1750ce ("arm64: dts: qcom: sc7280: Disable SuperSpeed instances in park mode") 36888ed83f99 ("arm64: dts: qcom: sc7280: switch USB+DP QMP PHY to new style of bindings") 70c4a1ca13b3 ("arm64: dts: qcom: sc7280: link usb3_phy_wrapper_gcc_usb30_pipe_clk") 531c738fb360 ("arm64: dts: qcom: sc7280: drop PCIe PHY clock index") fc6b1225d20d ("arm64: dts: qcom: sc7280: Add Display Port node") 25940788d170 ("arm64: dts: qcom: sc7280: add edp display dt nodes") 43137272f0bc ("arm64: dts: qcom: sc7280: Add DSI display nodes") fcb68dfda5cb ("arm64: dts: qcom: sc7280: add display dt nodes") bd7d507935ca ("arm64: dts: qcom: sc7280: Add pcie clock support") 92e0ee9f83b3 ("arm64: dts: qcom: sc7280: Add PCIe and PHY related nodes") 6b3207dfebdf ("arm64: dts: qcom: sc7280: Use QMP property to control load state") 7720ea001b52 ("arm64: dts: qcom: sc7280: Add QSPI node") 425f30cc843c ("arm64: dts: qcom: sc7280: fix display port phy reg property") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 3d930f1750ce30a6c36dbc71f8ff7e20322b94d7 Mon Sep 17 00:00:00 2001 From: Krishna Kurapati <quic_kriskura(a)quicinc.com> Date: Tue, 4 Jun 2024 11:36:59 +0530 Subject: [PATCH] arm64: dts: qcom: sc7280: Disable SuperSpeed instances in park mode On SC7280, in host mode, it is observed that stressing out controller results in HC died error: xhci-hcd.12.auto: xHCI host not responding to stop endpoint command xhci-hcd.12.auto: xHCI host controller not responding, assume dead xhci-hcd.12.auto: HC died; cleaning up And at this instant only restarting the host mode fixes it. Disable SuperSpeed instances in park mode for SC7280 to mitigate this issue. Reported-by: Doug Anderson <dianders(a)google.com> Cc: stable(a)vger.kernel.org Fixes: bb9efa59c665 ("arm64: dts: qcom: sc7280: Add USB related nodes") Signed-off-by: Krishna Kurapati <quic_kriskura(a)quicinc.com> Reviewed-by: Konrad Dybcio <konrad.dybcio(a)linaro.org> Link: https://lore.kernel.org/r/20240604060659.1449278-3-quic_kriskura@quicinc.com Signed-off-by: Bjorn Andersson <andersson(a)kernel.org> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index c3aaa09b8187..ba43fba2c551 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -4232,6 +4232,7 @@ usb_1_dwc3: usb@a600000 { iommus = <&apps_smmu 0xe0 0x0>; snps,dis_u2_susphy_quirk; snps,dis_enblslpm_quirk; + snps,parkmode-disable-ss-quirk; phys = <&usb_1_hsphy>, <&usb_1_qmpphy QMP_USB43DP_USB3_PHY>; phy-names = "usb2-phy", "usb3-phy"; maximum-speed = "super-speed";

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] arm64: dts: qcom: sc7280: Disable SuperSpeed instances in" failed to apply to 6.1-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.1-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.1.y git checkout FETCH_HEAD git cherry-pick -x 3d930f1750ce30a6c36dbc71f8ff7e20322b94d7 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072514-hunter-transpose-6f5e@gregkh' --subject-prefix 'PATCH 6.1.y' HEAD^.. Possible dependencies: 3d930f1750ce ("arm64: dts: qcom: sc7280: Disable SuperSpeed instances in park mode") 36888ed83f99 ("arm64: dts: qcom: sc7280: switch USB+DP QMP PHY to new style of bindings") 70c4a1ca13b3 ("arm64: dts: qcom: sc7280: link usb3_phy_wrapper_gcc_usb30_pipe_clk") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 3d930f1750ce30a6c36dbc71f8ff7e20322b94d7 Mon Sep 17 00:00:00 2001 From: Krishna Kurapati <quic_kriskura(a)quicinc.com> Date: Tue, 4 Jun 2024 11:36:59 +0530 Subject: [PATCH] arm64: dts: qcom: sc7280: Disable SuperSpeed instances in park mode On SC7280, in host mode, it is observed that stressing out controller results in HC died error: xhci-hcd.12.auto: xHCI host not responding to stop endpoint command xhci-hcd.12.auto: xHCI host controller not responding, assume dead xhci-hcd.12.auto: HC died; cleaning up And at this instant only restarting the host mode fixes it. Disable SuperSpeed instances in park mode for SC7280 to mitigate this issue. Reported-by: Doug Anderson <dianders(a)google.com> Cc: stable(a)vger.kernel.org Fixes: bb9efa59c665 ("arm64: dts: qcom: sc7280: Add USB related nodes") Signed-off-by: Krishna Kurapati <quic_kriskura(a)quicinc.com> Reviewed-by: Konrad Dybcio <konrad.dybcio(a)linaro.org> Link: https://lore.kernel.org/r/20240604060659.1449278-3-quic_kriskura@quicinc.com Signed-off-by: Bjorn Andersson <andersson(a)kernel.org> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index c3aaa09b8187..ba43fba2c551 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -4232,6 +4232,7 @@ usb_1_dwc3: usb@a600000 { iommus = <&apps_smmu 0xe0 0x0>; snps,dis_u2_susphy_quirk; snps,dis_enblslpm_quirk; + snps,parkmode-disable-ss-quirk; phys = <&usb_1_hsphy>, <&usb_1_qmpphy QMP_USB43DP_USB3_PHY>; phy-names = "usb2-phy", "usb3-phy"; maximum-speed = "super-speed";

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] arm64: dts: qcom: sc7280: Disable SuperSpeed instances in" failed to apply to 6.6-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.6-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.6.y git checkout FETCH_HEAD git cherry-pick -x 3d930f1750ce30a6c36dbc71f8ff7e20322b94d7 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072513-magnify-deputize-f818@gregkh' --subject-prefix 'PATCH 6.6.y' HEAD^.. Possible dependencies: 3d930f1750ce ("arm64: dts: qcom: sc7280: Disable SuperSpeed instances in park mode") 36888ed83f99 ("arm64: dts: qcom: sc7280: switch USB+DP QMP PHY to new style of bindings") 70c4a1ca13b3 ("arm64: dts: qcom: sc7280: link usb3_phy_wrapper_gcc_usb30_pipe_clk") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 3d930f1750ce30a6c36dbc71f8ff7e20322b94d7 Mon Sep 17 00:00:00 2001 From: Krishna Kurapati <quic_kriskura(a)quicinc.com> Date: Tue, 4 Jun 2024 11:36:59 +0530 Subject: [PATCH] arm64: dts: qcom: sc7280: Disable SuperSpeed instances in park mode On SC7280, in host mode, it is observed that stressing out controller results in HC died error: xhci-hcd.12.auto: xHCI host not responding to stop endpoint command xhci-hcd.12.auto: xHCI host controller not responding, assume dead xhci-hcd.12.auto: HC died; cleaning up And at this instant only restarting the host mode fixes it. Disable SuperSpeed instances in park mode for SC7280 to mitigate this issue. Reported-by: Doug Anderson <dianders(a)google.com> Cc: stable(a)vger.kernel.org Fixes: bb9efa59c665 ("arm64: dts: qcom: sc7280: Add USB related nodes") Signed-off-by: Krishna Kurapati <quic_kriskura(a)quicinc.com> Reviewed-by: Konrad Dybcio <konrad.dybcio(a)linaro.org> Link: https://lore.kernel.org/r/20240604060659.1449278-3-quic_kriskura@quicinc.com Signed-off-by: Bjorn Andersson <andersson(a)kernel.org> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index c3aaa09b8187..ba43fba2c551 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -4232,6 +4232,7 @@ usb_1_dwc3: usb@a600000 { iommus = <&apps_smmu 0xe0 0x0>; snps,dis_u2_susphy_quirk; snps,dis_enblslpm_quirk; + snps,parkmode-disable-ss-quirk; phys = <&usb_1_hsphy>, <&usb_1_qmpphy QMP_USB43DP_USB3_PHY>; phy-names = "usb2-phy", "usb3-phy"; maximum-speed = "super-speed";

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] arm64: dts: qcom: sc7180: Disable SuperSpeed instances in" failed to apply to 5.10-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x 5b8baed4b88132c12010ce6ca1b56f00d122e376 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072546-saddled-unselect-6d9b@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^.. Possible dependencies: 5b8baed4b881 ("arm64: dts: qcom: sc7180: Disable SuperSpeed instances in park mode") ebb840b00b7f ("arm64: dts: qcom: sc7180: switch USB+DP QMP PHY to new style of bindings") 2b616f86d51b ("arm64: dts: qcom: sc7180: rename labels for DSI nodes") 4a9f8f8f2ada ("arm64: dts: qcom: Add Acer Aspire 1") 39238382c499 ("arm64: dts: qcom: sc7180: Drop redundant disable in mdp") 43926a3cb191 ("arm64: dts: qcom: sc7180: Don't enable lpass clocks by default") c28d9029f3b6 ("arm64: dts: qcom: sc7180-trogdor-wormdingler: use just "port" in panel") 88904a12fbcb ("arm64: dts: qcom: sc7180-trogdor-quackingstick: use just "port" in panel") 746bda7d9dd9 ("arm64: dts: qcom: sc7180-idp: use just "port" in panel") 603f96d4c9d0 ("arm64: dts: qcom: add initial support for qcom sa8775p-ride") a45d0641d110 ("arm64: dts: qcom: sc7180: Add compat qcom,sc7180-dsi-ctrl") f5b4811e8758 ("arm64: dts: qcom: sc7180: Add trogdor eDP/touchscreen regulator off-on-time") 6be310347c9c ("arm64: dts: qcom: add SA8540P ride(Qdrive-3)") 2372bd2d5be6 ("arm64: dts: qcom: sc7180: change DSI PHY node name to generic one") 95dc5fd99972 ("arm64: dts: qcom: sc7180: Drop redundant phy-names from DSI controller") a10b760b7402 ("arm64: dts: qcom: sc7180-trogdor: Split out keyboard node and describe detachables") 6afcee78b4a4 ("arm64: dts: qcom: sc7180: Add kingoftown dts files") fb69f6adaf88 ("arm64: dts: qcom: sc7180: Add pazquel dts files") 9520fef90049 ("arm64: dts: qcom: sc7180: Add mrbland dts files") c77a3d4a2bfa ("arm64: dts: qcom: sc7180: Add quackingstick dts files") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 5b8baed4b88132c12010ce6ca1b56f00d122e376 Mon Sep 17 00:00:00 2001 From: Krishna Kurapati <quic_kriskura(a)quicinc.com> Date: Tue, 4 Jun 2024 11:36:58 +0530 Subject: [PATCH] arm64: dts: qcom: sc7180: Disable SuperSpeed instances in park mode On SC7180, in host mode, it is observed that stressing out controller results in HC died error: xhci-hcd.12.auto: xHCI host not responding to stop endpoint command xhci-hcd.12.auto: xHCI host controller not responding, assume dead xhci-hcd.12.auto: HC died; cleaning up And at this instant only restarting the host mode fixes it. Disable SuperSpeed instances in park mode for SC7180 to mitigate this issue. Reported-by: Doug Anderson <dianders(a)google.com> Cc: stable(a)vger.kernel.org Fixes: 0b766e7fe5a2 ("arm64: dts: qcom: sc7180: Add USB related nodes") Signed-off-by: Krishna Kurapati <quic_kriskura(a)quicinc.com> Reviewed-by: Konrad Dybcio <konrad.dybcio(a)linaro.org> Link: https://lore.kernel.org/r/20240604060659.1449278-2-quic_kriskura@quicinc.com Signed-off-by: Bjorn Andersson <andersson(a)kernel.org> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index 52d074a4fbf3..9ab0c98cac05 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -3066,6 +3066,7 @@ usb_1_dwc3: usb@a600000 { iommus = <&apps_smmu 0x540 0>; snps,dis_u2_susphy_quirk; snps,dis_enblslpm_quirk; + snps,parkmode-disable-ss-quirk; phys = <&usb_1_hsphy>, <&usb_1_qmpphy QMP_USB43DP_USB3_PHY>; phy-names = "usb2-phy", "usb3-phy"; maximum-speed = "super-speed";

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] arm64: dts: qcom: sc7180: Disable SuperSpeed instances in" failed to apply to 5.15-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.15-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.15.y git checkout FETCH_HEAD git cherry-pick -x 5b8baed4b88132c12010ce6ca1b56f00d122e376 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072545-supermom-stinky-b4f9@gregkh' --subject-prefix 'PATCH 5.15.y' HEAD^.. Possible dependencies: 5b8baed4b881 ("arm64: dts: qcom: sc7180: Disable SuperSpeed instances in park mode") ebb840b00b7f ("arm64: dts: qcom: sc7180: switch USB+DP QMP PHY to new style of bindings") 2b616f86d51b ("arm64: dts: qcom: sc7180: rename labels for DSI nodes") 4a9f8f8f2ada ("arm64: dts: qcom: Add Acer Aspire 1") 39238382c499 ("arm64: dts: qcom: sc7180: Drop redundant disable in mdp") 43926a3cb191 ("arm64: dts: qcom: sc7180: Don't enable lpass clocks by default") c28d9029f3b6 ("arm64: dts: qcom: sc7180-trogdor-wormdingler: use just "port" in panel") 88904a12fbcb ("arm64: dts: qcom: sc7180-trogdor-quackingstick: use just "port" in panel") 746bda7d9dd9 ("arm64: dts: qcom: sc7180-idp: use just "port" in panel") 603f96d4c9d0 ("arm64: dts: qcom: add initial support for qcom sa8775p-ride") a45d0641d110 ("arm64: dts: qcom: sc7180: Add compat qcom,sc7180-dsi-ctrl") f5b4811e8758 ("arm64: dts: qcom: sc7180: Add trogdor eDP/touchscreen regulator off-on-time") 6be310347c9c ("arm64: dts: qcom: add SA8540P ride(Qdrive-3)") 2372bd2d5be6 ("arm64: dts: qcom: sc7180: change DSI PHY node name to generic one") 95dc5fd99972 ("arm64: dts: qcom: sc7180: Drop redundant phy-names from DSI controller") a10b760b7402 ("arm64: dts: qcom: sc7180-trogdor: Split out keyboard node and describe detachables") 6afcee78b4a4 ("arm64: dts: qcom: sc7180: Add kingoftown dts files") fb69f6adaf88 ("arm64: dts: qcom: sc7180: Add pazquel dts files") 9520fef90049 ("arm64: dts: qcom: sc7180: Add mrbland dts files") c77a3d4a2bfa ("arm64: dts: qcom: sc7180: Add quackingstick dts files") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 5b8baed4b88132c12010ce6ca1b56f00d122e376 Mon Sep 17 00:00:00 2001 From: Krishna Kurapati <quic_kriskura(a)quicinc.com> Date: Tue, 4 Jun 2024 11:36:58 +0530 Subject: [PATCH] arm64: dts: qcom: sc7180: Disable SuperSpeed instances in park mode On SC7180, in host mode, it is observed that stressing out controller results in HC died error: xhci-hcd.12.auto: xHCI host not responding to stop endpoint command xhci-hcd.12.auto: xHCI host controller not responding, assume dead xhci-hcd.12.auto: HC died; cleaning up And at this instant only restarting the host mode fixes it. Disable SuperSpeed instances in park mode for SC7180 to mitigate this issue. Reported-by: Doug Anderson <dianders(a)google.com> Cc: stable(a)vger.kernel.org Fixes: 0b766e7fe5a2 ("arm64: dts: qcom: sc7180: Add USB related nodes") Signed-off-by: Krishna Kurapati <quic_kriskura(a)quicinc.com> Reviewed-by: Konrad Dybcio <konrad.dybcio(a)linaro.org> Link: https://lore.kernel.org/r/20240604060659.1449278-2-quic_kriskura@quicinc.com Signed-off-by: Bjorn Andersson <andersson(a)kernel.org> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index 52d074a4fbf3..9ab0c98cac05 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -3066,6 +3066,7 @@ usb_1_dwc3: usb@a600000 { iommus = <&apps_smmu 0x540 0>; snps,dis_u2_susphy_quirk; snps,dis_enblslpm_quirk; + snps,parkmode-disable-ss-quirk; phys = <&usb_1_hsphy>, <&usb_1_qmpphy QMP_USB43DP_USB3_PHY>; phy-names = "usb2-phy", "usb3-phy"; maximum-speed = "super-speed";

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] ocfs2: strict bound check before memcmp in" failed to apply to 4.19-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.19-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-4.19.y git checkout FETCH_HEAD git cherry-pick -x af77c4fc1871847b528d58b7fdafb4aa1f6a9262 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072558-waving-discharge-31eb@gregkh' --subject-prefix 'PATCH 4.19.y' HEAD^.. Possible dependencies: af77c4fc1871 ("ocfs2: strict bound check before memcmp in ocfs2_xattr_find_entry()") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From af77c4fc1871847b528d58b7fdafb4aa1f6a9262 Mon Sep 17 00:00:00 2001 From: Ferry Meng <mengferry(a)linux.alibaba.com> Date: Mon, 20 May 2024 10:40:24 +0800 Subject: [PATCH] ocfs2: strict bound check before memcmp in ocfs2_xattr_find_entry() xattr in ocfs2 maybe 'non-indexed', which saved with additional space requested. It's better to check if the memory is out of bound before memcmp, although this possibility mainly comes from crafted poisonous images. Link: https://lkml.kernel.org/r/20240520024024.1976129-2-joseph.qi@linux.alibaba.… Signed-off-by: Ferry Meng <mengferry(a)linux.alibaba.com> Signed-off-by: Joseph Qi <joseph.qi(a)linux.alibaba.com> Reported-by: lei lu <llfamsec(a)gmail.com> Reviewed-by: Joseph Qi <joseph.qi(a)linux.alibaba.com> Cc: Changwei Ge <gechangwei(a)live.cn> Cc: Gang He <ghe(a)suse.com> Cc: Joel Becker <jlbec(a)evilplan.org> Cc: Jun Piao <piaojun(a)huawei.com> Cc: Junxiao Bi <junxiao.bi(a)oracle.com> Cc: Mark Fasheh <mark(a)fasheh.com> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c index 8aea94c90739..35c0cc2a51af 100644 --- a/fs/ocfs2/xattr.c +++ b/fs/ocfs2/xattr.c @@ -1068,7 +1068,7 @@ static int ocfs2_xattr_find_entry(struct inode *inode, int name_index, { struct ocfs2_xattr_entry *entry; size_t name_len; - int i, cmp = 1; + int i, name_offset, cmp = 1; if (name == NULL) return -EINVAL; @@ -1083,10 +1083,15 @@ static int ocfs2_xattr_find_entry(struct inode *inode, int name_index, cmp = name_index - ocfs2_xattr_get_type(entry); if (!cmp) cmp = name_len - entry->xe_name_len; - if (!cmp) - cmp = memcmp(name, (xs->base + - le16_to_cpu(entry->xe_name_offset)), - name_len); + if (!cmp) { + name_offset = le16_to_cpu(entry->xe_name_offset); + if ((xs->base + name_offset + name_len) > xs->end) { + ocfs2_error(inode->i_sb, + "corrupted xattr entries"); + return -EFSCORRUPTED; + } + cmp = memcmp(name, (xs->base + name_offset), name_len); + } if (cmp == 0) break; entry += 1;

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] ocfs2: strict bound check before memcmp in" failed to apply to 5.4-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.4.y git checkout FETCH_HEAD git cherry-pick -x af77c4fc1871847b528d58b7fdafb4aa1f6a9262 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072557-handlebar-underpass-54f1@gregkh' --subject-prefix 'PATCH 5.4.y' HEAD^.. Possible dependencies: af77c4fc1871 ("ocfs2: strict bound check before memcmp in ocfs2_xattr_find_entry()") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From af77c4fc1871847b528d58b7fdafb4aa1f6a9262 Mon Sep 17 00:00:00 2001 From: Ferry Meng <mengferry(a)linux.alibaba.com> Date: Mon, 20 May 2024 10:40:24 +0800 Subject: [PATCH] ocfs2: strict bound check before memcmp in ocfs2_xattr_find_entry() xattr in ocfs2 maybe 'non-indexed', which saved with additional space requested. It's better to check if the memory is out of bound before memcmp, although this possibility mainly comes from crafted poisonous images. Link: https://lkml.kernel.org/r/20240520024024.1976129-2-joseph.qi@linux.alibaba.… Signed-off-by: Ferry Meng <mengferry(a)linux.alibaba.com> Signed-off-by: Joseph Qi <joseph.qi(a)linux.alibaba.com> Reported-by: lei lu <llfamsec(a)gmail.com> Reviewed-by: Joseph Qi <joseph.qi(a)linux.alibaba.com> Cc: Changwei Ge <gechangwei(a)live.cn> Cc: Gang He <ghe(a)suse.com> Cc: Joel Becker <jlbec(a)evilplan.org> Cc: Jun Piao <piaojun(a)huawei.com> Cc: Junxiao Bi <junxiao.bi(a)oracle.com> Cc: Mark Fasheh <mark(a)fasheh.com> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c index 8aea94c90739..35c0cc2a51af 100644 --- a/fs/ocfs2/xattr.c +++ b/fs/ocfs2/xattr.c @@ -1068,7 +1068,7 @@ static int ocfs2_xattr_find_entry(struct inode *inode, int name_index, { struct ocfs2_xattr_entry *entry; size_t name_len; - int i, cmp = 1; + int i, name_offset, cmp = 1; if (name == NULL) return -EINVAL; @@ -1083,10 +1083,15 @@ static int ocfs2_xattr_find_entry(struct inode *inode, int name_index, cmp = name_index - ocfs2_xattr_get_type(entry); if (!cmp) cmp = name_len - entry->xe_name_len; - if (!cmp) - cmp = memcmp(name, (xs->base + - le16_to_cpu(entry->xe_name_offset)), - name_len); + if (!cmp) { + name_offset = le16_to_cpu(entry->xe_name_offset); + if ((xs->base + name_offset + name_len) > xs->end) { + ocfs2_error(inode->i_sb, + "corrupted xattr entries"); + return -EFSCORRUPTED; + } + cmp = memcmp(name, (xs->base + name_offset), name_len); + } if (cmp == 0) break; entry += 1;

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] ocfs2: strict bound check before memcmp in" failed to apply to 5.10-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x af77c4fc1871847b528d58b7fdafb4aa1f6a9262 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072556-gumminess-desecrate-6e7c@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^.. Possible dependencies: af77c4fc1871 ("ocfs2: strict bound check before memcmp in ocfs2_xattr_find_entry()") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From af77c4fc1871847b528d58b7fdafb4aa1f6a9262 Mon Sep 17 00:00:00 2001 From: Ferry Meng <mengferry(a)linux.alibaba.com> Date: Mon, 20 May 2024 10:40:24 +0800 Subject: [PATCH] ocfs2: strict bound check before memcmp in ocfs2_xattr_find_entry() xattr in ocfs2 maybe 'non-indexed', which saved with additional space requested. It's better to check if the memory is out of bound before memcmp, although this possibility mainly comes from crafted poisonous images. Link: https://lkml.kernel.org/r/20240520024024.1976129-2-joseph.qi@linux.alibaba.… Signed-off-by: Ferry Meng <mengferry(a)linux.alibaba.com> Signed-off-by: Joseph Qi <joseph.qi(a)linux.alibaba.com> Reported-by: lei lu <llfamsec(a)gmail.com> Reviewed-by: Joseph Qi <joseph.qi(a)linux.alibaba.com> Cc: Changwei Ge <gechangwei(a)live.cn> Cc: Gang He <ghe(a)suse.com> Cc: Joel Becker <jlbec(a)evilplan.org> Cc: Jun Piao <piaojun(a)huawei.com> Cc: Junxiao Bi <junxiao.bi(a)oracle.com> Cc: Mark Fasheh <mark(a)fasheh.com> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c index 8aea94c90739..35c0cc2a51af 100644 --- a/fs/ocfs2/xattr.c +++ b/fs/ocfs2/xattr.c @@ -1068,7 +1068,7 @@ static int ocfs2_xattr_find_entry(struct inode *inode, int name_index, { struct ocfs2_xattr_entry *entry; size_t name_len; - int i, cmp = 1; + int i, name_offset, cmp = 1; if (name == NULL) return -EINVAL; @@ -1083,10 +1083,15 @@ static int ocfs2_xattr_find_entry(struct inode *inode, int name_index, cmp = name_index - ocfs2_xattr_get_type(entry); if (!cmp) cmp = name_len - entry->xe_name_len; - if (!cmp) - cmp = memcmp(name, (xs->base + - le16_to_cpu(entry->xe_name_offset)), - name_len); + if (!cmp) { + name_offset = le16_to_cpu(entry->xe_name_offset); + if ((xs->base + name_offset + name_len) > xs->end) { + ocfs2_error(inode->i_sb, + "corrupted xattr entries"); + return -EFSCORRUPTED; + } + cmp = memcmp(name, (xs->base + name_offset), name_len); + } if (cmp == 0) break; entry += 1;

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] ocfs2: strict bound check before memcmp in" failed to apply to 5.15-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.15-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.15.y git checkout FETCH_HEAD git cherry-pick -x af77c4fc1871847b528d58b7fdafb4aa1f6a9262 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072555-hubcap-monetary-01bc@gregkh' --subject-prefix 'PATCH 5.15.y' HEAD^.. Possible dependencies: af77c4fc1871 ("ocfs2: strict bound check before memcmp in ocfs2_xattr_find_entry()") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From af77c4fc1871847b528d58b7fdafb4aa1f6a9262 Mon Sep 17 00:00:00 2001 From: Ferry Meng <mengferry(a)linux.alibaba.com> Date: Mon, 20 May 2024 10:40:24 +0800 Subject: [PATCH] ocfs2: strict bound check before memcmp in ocfs2_xattr_find_entry() xattr in ocfs2 maybe 'non-indexed', which saved with additional space requested. It's better to check if the memory is out of bound before memcmp, although this possibility mainly comes from crafted poisonous images. Link: https://lkml.kernel.org/r/20240520024024.1976129-2-joseph.qi@linux.alibaba.… Signed-off-by: Ferry Meng <mengferry(a)linux.alibaba.com> Signed-off-by: Joseph Qi <joseph.qi(a)linux.alibaba.com> Reported-by: lei lu <llfamsec(a)gmail.com> Reviewed-by: Joseph Qi <joseph.qi(a)linux.alibaba.com> Cc: Changwei Ge <gechangwei(a)live.cn> Cc: Gang He <ghe(a)suse.com> Cc: Joel Becker <jlbec(a)evilplan.org> Cc: Jun Piao <piaojun(a)huawei.com> Cc: Junxiao Bi <junxiao.bi(a)oracle.com> Cc: Mark Fasheh <mark(a)fasheh.com> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c index 8aea94c90739..35c0cc2a51af 100644 --- a/fs/ocfs2/xattr.c +++ b/fs/ocfs2/xattr.c @@ -1068,7 +1068,7 @@ static int ocfs2_xattr_find_entry(struct inode *inode, int name_index, { struct ocfs2_xattr_entry *entry; size_t name_len; - int i, cmp = 1; + int i, name_offset, cmp = 1; if (name == NULL) return -EINVAL; @@ -1083,10 +1083,15 @@ static int ocfs2_xattr_find_entry(struct inode *inode, int name_index, cmp = name_index - ocfs2_xattr_get_type(entry); if (!cmp) cmp = name_len - entry->xe_name_len; - if (!cmp) - cmp = memcmp(name, (xs->base + - le16_to_cpu(entry->xe_name_offset)), - name_len); + if (!cmp) { + name_offset = le16_to_cpu(entry->xe_name_offset); + if ((xs->base + name_offset + name_len) > xs->end) { + ocfs2_error(inode->i_sb, + "corrupted xattr entries"); + return -EFSCORRUPTED; + } + cmp = memcmp(name, (xs->base + name_offset), name_len); + } if (cmp == 0) break; entry += 1;

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] ocfs2: strict bound check before memcmp in" failed to apply to 6.1-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.1-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.1.y git checkout FETCH_HEAD git cherry-pick -x af77c4fc1871847b528d58b7fdafb4aa1f6a9262 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072554-renovate-snippet-1b35@gregkh' --subject-prefix 'PATCH 6.1.y' HEAD^.. Possible dependencies: af77c4fc1871 ("ocfs2: strict bound check before memcmp in ocfs2_xattr_find_entry()") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From af77c4fc1871847b528d58b7fdafb4aa1f6a9262 Mon Sep 17 00:00:00 2001 From: Ferry Meng <mengferry(a)linux.alibaba.com> Date: Mon, 20 May 2024 10:40:24 +0800 Subject: [PATCH] ocfs2: strict bound check before memcmp in ocfs2_xattr_find_entry() xattr in ocfs2 maybe 'non-indexed', which saved with additional space requested. It's better to check if the memory is out of bound before memcmp, although this possibility mainly comes from crafted poisonous images. Link: https://lkml.kernel.org/r/20240520024024.1976129-2-joseph.qi@linux.alibaba.… Signed-off-by: Ferry Meng <mengferry(a)linux.alibaba.com> Signed-off-by: Joseph Qi <joseph.qi(a)linux.alibaba.com> Reported-by: lei lu <llfamsec(a)gmail.com> Reviewed-by: Joseph Qi <joseph.qi(a)linux.alibaba.com> Cc: Changwei Ge <gechangwei(a)live.cn> Cc: Gang He <ghe(a)suse.com> Cc: Joel Becker <jlbec(a)evilplan.org> Cc: Jun Piao <piaojun(a)huawei.com> Cc: Junxiao Bi <junxiao.bi(a)oracle.com> Cc: Mark Fasheh <mark(a)fasheh.com> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c index 8aea94c90739..35c0cc2a51af 100644 --- a/fs/ocfs2/xattr.c +++ b/fs/ocfs2/xattr.c @@ -1068,7 +1068,7 @@ static int ocfs2_xattr_find_entry(struct inode *inode, int name_index, { struct ocfs2_xattr_entry *entry; size_t name_len; - int i, cmp = 1; + int i, name_offset, cmp = 1; if (name == NULL) return -EINVAL; @@ -1083,10 +1083,15 @@ static int ocfs2_xattr_find_entry(struct inode *inode, int name_index, cmp = name_index - ocfs2_xattr_get_type(entry); if (!cmp) cmp = name_len - entry->xe_name_len; - if (!cmp) - cmp = memcmp(name, (xs->base + - le16_to_cpu(entry->xe_name_offset)), - name_len); + if (!cmp) { + name_offset = le16_to_cpu(entry->xe_name_offset); + if ((xs->base + name_offset + name_len) > xs->end) { + ocfs2_error(inode->i_sb, + "corrupted xattr entries"); + return -EFSCORRUPTED; + } + cmp = memcmp(name, (xs->base + name_offset), name_len); + } if (cmp == 0) break; entry += 1;

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] ocfs2: strict bound check before memcmp in" failed to apply to 6.6-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.6-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.6.y git checkout FETCH_HEAD git cherry-pick -x af77c4fc1871847b528d58b7fdafb4aa1f6a9262 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072553-viewing-trapped-d0a4@gregkh' --subject-prefix 'PATCH 6.6.y' HEAD^.. Possible dependencies: af77c4fc1871 ("ocfs2: strict bound check before memcmp in ocfs2_xattr_find_entry()") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From af77c4fc1871847b528d58b7fdafb4aa1f6a9262 Mon Sep 17 00:00:00 2001 From: Ferry Meng <mengferry(a)linux.alibaba.com> Date: Mon, 20 May 2024 10:40:24 +0800 Subject: [PATCH] ocfs2: strict bound check before memcmp in ocfs2_xattr_find_entry() xattr in ocfs2 maybe 'non-indexed', which saved with additional space requested. It's better to check if the memory is out of bound before memcmp, although this possibility mainly comes from crafted poisonous images. Link: https://lkml.kernel.org/r/20240520024024.1976129-2-joseph.qi@linux.alibaba.… Signed-off-by: Ferry Meng <mengferry(a)linux.alibaba.com> Signed-off-by: Joseph Qi <joseph.qi(a)linux.alibaba.com> Reported-by: lei lu <llfamsec(a)gmail.com> Reviewed-by: Joseph Qi <joseph.qi(a)linux.alibaba.com> Cc: Changwei Ge <gechangwei(a)live.cn> Cc: Gang He <ghe(a)suse.com> Cc: Joel Becker <jlbec(a)evilplan.org> Cc: Jun Piao <piaojun(a)huawei.com> Cc: Junxiao Bi <junxiao.bi(a)oracle.com> Cc: Mark Fasheh <mark(a)fasheh.com> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c index 8aea94c90739..35c0cc2a51af 100644 --- a/fs/ocfs2/xattr.c +++ b/fs/ocfs2/xattr.c @@ -1068,7 +1068,7 @@ static int ocfs2_xattr_find_entry(struct inode *inode, int name_index, { struct ocfs2_xattr_entry *entry; size_t name_len; - int i, cmp = 1; + int i, name_offset, cmp = 1; if (name == NULL) return -EINVAL; @@ -1083,10 +1083,15 @@ static int ocfs2_xattr_find_entry(struct inode *inode, int name_index, cmp = name_index - ocfs2_xattr_get_type(entry); if (!cmp) cmp = name_len - entry->xe_name_len; - if (!cmp) - cmp = memcmp(name, (xs->base + - le16_to_cpu(entry->xe_name_offset)), - name_len); + if (!cmp) { + name_offset = le16_to_cpu(entry->xe_name_offset); + if ((xs->base + name_offset + name_len) > xs->end) { + ocfs2_error(inode->i_sb, + "corrupted xattr entries"); + return -EFSCORRUPTED; + } + cmp = memcmp(name, (xs->base + name_offset), name_len); + } if (cmp == 0) break; entry += 1;

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] ocfs2: strict bound check before memcmp in" failed to apply to 6.9-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.9-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.9.y git checkout FETCH_HEAD git cherry-pick -x af77c4fc1871847b528d58b7fdafb4aa1f6a9262 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072553-arena-chute-8609@gregkh' --subject-prefix 'PATCH 6.9.y' HEAD^.. Possible dependencies: af77c4fc1871 ("ocfs2: strict bound check before memcmp in ocfs2_xattr_find_entry()") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From af77c4fc1871847b528d58b7fdafb4aa1f6a9262 Mon Sep 17 00:00:00 2001 From: Ferry Meng <mengferry(a)linux.alibaba.com> Date: Mon, 20 May 2024 10:40:24 +0800 Subject: [PATCH] ocfs2: strict bound check before memcmp in ocfs2_xattr_find_entry() xattr in ocfs2 maybe 'non-indexed', which saved with additional space requested. It's better to check if the memory is out of bound before memcmp, although this possibility mainly comes from crafted poisonous images. Link: https://lkml.kernel.org/r/20240520024024.1976129-2-joseph.qi@linux.alibaba.… Signed-off-by: Ferry Meng <mengferry(a)linux.alibaba.com> Signed-off-by: Joseph Qi <joseph.qi(a)linux.alibaba.com> Reported-by: lei lu <llfamsec(a)gmail.com> Reviewed-by: Joseph Qi <joseph.qi(a)linux.alibaba.com> Cc: Changwei Ge <gechangwei(a)live.cn> Cc: Gang He <ghe(a)suse.com> Cc: Joel Becker <jlbec(a)evilplan.org> Cc: Jun Piao <piaojun(a)huawei.com> Cc: Junxiao Bi <junxiao.bi(a)oracle.com> Cc: Mark Fasheh <mark(a)fasheh.com> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c index 8aea94c90739..35c0cc2a51af 100644 --- a/fs/ocfs2/xattr.c +++ b/fs/ocfs2/xattr.c @@ -1068,7 +1068,7 @@ static int ocfs2_xattr_find_entry(struct inode *inode, int name_index, { struct ocfs2_xattr_entry *entry; size_t name_len; - int i, cmp = 1; + int i, name_offset, cmp = 1; if (name == NULL) return -EINVAL; @@ -1083,10 +1083,15 @@ static int ocfs2_xattr_find_entry(struct inode *inode, int name_index, cmp = name_index - ocfs2_xattr_get_type(entry); if (!cmp) cmp = name_len - entry->xe_name_len; - if (!cmp) - cmp = memcmp(name, (xs->base + - le16_to_cpu(entry->xe_name_offset)), - name_len); + if (!cmp) { + name_offset = le16_to_cpu(entry->xe_name_offset); + if ((xs->base + name_offset + name_len) > xs->end) { + ocfs2_error(inode->i_sb, + "corrupted xattr entries"); + return -EFSCORRUPTED; + } + cmp = memcmp(name, (xs->base + name_offset), name_len); + } if (cmp == 0) break; entry += 1;

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] ocfs2: strict bound check before memcmp in" failed to apply to 6.10-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.10.y git checkout FETCH_HEAD git cherry-pick -x af77c4fc1871847b528d58b7fdafb4aa1f6a9262 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072552-willed-overturn-c270@gregkh' --subject-prefix 'PATCH 6.10.y' HEAD^.. Possible dependencies: af77c4fc1871 ("ocfs2: strict bound check before memcmp in ocfs2_xattr_find_entry()") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From af77c4fc1871847b528d58b7fdafb4aa1f6a9262 Mon Sep 17 00:00:00 2001 From: Ferry Meng <mengferry(a)linux.alibaba.com> Date: Mon, 20 May 2024 10:40:24 +0800 Subject: [PATCH] ocfs2: strict bound check before memcmp in ocfs2_xattr_find_entry() xattr in ocfs2 maybe 'non-indexed', which saved with additional space requested. It's better to check if the memory is out of bound before memcmp, although this possibility mainly comes from crafted poisonous images. Link: https://lkml.kernel.org/r/20240520024024.1976129-2-joseph.qi@linux.alibaba.… Signed-off-by: Ferry Meng <mengferry(a)linux.alibaba.com> Signed-off-by: Joseph Qi <joseph.qi(a)linux.alibaba.com> Reported-by: lei lu <llfamsec(a)gmail.com> Reviewed-by: Joseph Qi <joseph.qi(a)linux.alibaba.com> Cc: Changwei Ge <gechangwei(a)live.cn> Cc: Gang He <ghe(a)suse.com> Cc: Joel Becker <jlbec(a)evilplan.org> Cc: Jun Piao <piaojun(a)huawei.com> Cc: Junxiao Bi <junxiao.bi(a)oracle.com> Cc: Mark Fasheh <mark(a)fasheh.com> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c index 8aea94c90739..35c0cc2a51af 100644 --- a/fs/ocfs2/xattr.c +++ b/fs/ocfs2/xattr.c @@ -1068,7 +1068,7 @@ static int ocfs2_xattr_find_entry(struct inode *inode, int name_index, { struct ocfs2_xattr_entry *entry; size_t name_len; - int i, cmp = 1; + int i, name_offset, cmp = 1; if (name == NULL) return -EINVAL; @@ -1083,10 +1083,15 @@ static int ocfs2_xattr_find_entry(struct inode *inode, int name_index, cmp = name_index - ocfs2_xattr_get_type(entry); if (!cmp) cmp = name_len - entry->xe_name_len; - if (!cmp) - cmp = memcmp(name, (xs->base + - le16_to_cpu(entry->xe_name_offset)), - name_len); + if (!cmp) { + name_offset = le16_to_cpu(entry->xe_name_offset); + if ((xs->base + name_offset + name_len) > xs->end) { + ocfs2_error(inode->i_sb, + "corrupted xattr entries"); + return -EFSCORRUPTED; + } + cmp = memcmp(name, (xs->base + name_offset), name_len); + } if (cmp == 0) break; entry += 1;

1 year, 4 months

1
0
0 0

[PATCH] arm64: mm: Fix lockless walks with static and dynamic page-table folding

by Will Deacon

Lina reports random oopsen originating from the fast GUP code when 16K pages are used with 4-level page-tables, the fourth level being folded at runtime due to lack of LPA2. In this configuration, the generic implementation of p4d_offset_lockless() will return a 'p4d_t *' corresponding to the 'pgd_t' allocated on the stack of the caller, gup_fast_pgd_range(). This is normally fine, but when the fourth level of page-table is folded at runtime, pud_offset_lockless() will offset from the address of the 'p4d_t' to calculate the address of the PUD in the same page-table page. This results in a stray stack read when the 'p4d_t' has been allocated on the stack and can send the walker into the weeds. Fix the problem by providing our own definition of p4d_offset_lockless() when CONFIG_PGTABLE_LEVELS <= 4 which returns the real page-table pointer rather than the address of the local stack variable. Cc: Catalin Marinas <catalin.marinas(a)arm.com> Cc: Ard Biesheuvel <ardb(a)kernel.org> Cc: <stable(a)vger.kernel.org> Link: https://lore.kernel.org/r/50360968-13fb-4e6f-8f52-1725b3177215@asahilina.net Fixes: 0dd4f60a2c76 ("arm64: mm: Add support for folding PUDs at runtime") Reported-by: Asahi Lina <lina(a)asahilina.net> Signed-off-by: Will Deacon <will(a)kernel.org> --- arch/arm64/include/asm/pgtable.h | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h index f8efbc128446..7a4f5604be3f 100644 --- a/arch/arm64/include/asm/pgtable.h +++ b/arch/arm64/include/asm/pgtable.h @@ -1065,6 +1065,28 @@ static inline bool pgtable_l5_enabled(void) { return false; } #define p4d_offset_kimg(dir,addr) ((p4d_t *)dir) +static inline +p4d_t *p4d_offset_lockless_folded(pgd_t *pgdp, pgd_t pgd, unsigned long addr) +{ + /* + * With runtime folding of the pud, pud_offset_lockless() passes + * the 'pgd_t *' we return here to p4d_to_folded_pud(), which + * will offset the pointer assuming that it points into + * a page-table page. However, the fast GUP path passes us a + * pgd_t allocated on the stack and so we must use the original + * pointer in 'pgdp' to construct the p4d pointer instead of + * using the generic p4d_offset_lockless() implementation. + * + * Note: reusing the original pointer means that we may + * dereference the same (live) page-table entry multiple times. + * This is safe because it is still only loaded once in the + * context of each level and the CPU guarantees same-address + * read-after-read ordering. + */ + return p4d_offset(pgdp, addr); +} +#define p4d_offset_lockless p4d_offset_lockless_folded + #endif /* CONFIG_PGTABLE_LEVELS > 4 */ #define pgd_ERROR(e) \ -- 2.45.2.1089.g2a221341d9-goog

1 year, 4 months

2
2
0 0

FAILED: patch "[PATCH] Bluetooth: btusb: Add Realtek RTL8852BE support ID" failed to apply to 4.19-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.19-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-4.19.y git checkout FETCH_HEAD git cherry-pick -x 473a89b4ed7fd52a419340f7c540d5c8fc96fc75 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072511-deskbound-riding-5c98@gregkh' --subject-prefix 'PATCH 4.19.y' HEAD^.. Possible dependencies: 473a89b4ed7f ("Bluetooth: btusb: Add Realtek RTL8852BE support ID 0x13d3:0x3591") 295ef07a9dae ("Bluetooth: btusb: Add RTL8852BE device 0489:e125 to device tables") 3600860a7193 ("Bluetooth: Add device 13d3:3572 IMC Networks Bluetooth Radio") 069f534247bb ("bluetooth: Add device 13d3:3571 to device tables") 730a1d1a93a3 ("bluetooth: Add device 0bda:887b to device tables") 393b4916b7b5 ("Bluetooth: btusb: Add Realtek RTL8852BE support ID 0x0cb8:0xc559") 33bfd94a05ab ("Bluetooth: btusb: add Realtek 8822CE to usb_device_id table") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 473a89b4ed7fd52a419340f7c540d5c8fc96fc75 Mon Sep 17 00:00:00 2001 From: WangYuli <wangyuli(a)uniontech.com> Date: Sat, 22 Jun 2024 12:09:59 +0800 Subject: [PATCH] Bluetooth: btusb: Add Realtek RTL8852BE support ID 0x13d3:0x3591 Add the support ID(0x13d3, 0x3591) to usb_device_id table for Realtek RTL8852BE. The device table is as follows: T: Bus=01 Lev=02 Prnt=03 Port=00 Cnt=01 Dev#= 5 Spd=12 MxCh= 0 D: Ver= 1.00 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 P: Vendor=13d3 ProdID=3591 Rev= 0.00 S: Manufacturer=Realtek S: Product=Bluetooth Radio S: SerialNumber=00e04c000001 C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=500mA I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms Cc: stable(a)vger.kernel.org Signed-off-by: Wentao Guan <guanwentao(a)uniontech.com> Signed-off-by: WangYuli <wangyuli(a)uniontech.com> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz(a)intel.com> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 2d7d47f9d007..2d5c971a59ad 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -555,6 +555,8 @@ static const struct usb_device_id quirks_table[] = { BTUSB_WIDEBAND_SPEECH }, { USB_DEVICE(0x13d3, 0x3572), .driver_info = BTUSB_REALTEK | BTUSB_WIDEBAND_SPEECH }, + { USB_DEVICE(0x13d3, 0x3591), .driver_info = BTUSB_REALTEK | + BTUSB_WIDEBAND_SPEECH }, { USB_DEVICE(0x0489, 0xe125), .driver_info = BTUSB_REALTEK | BTUSB_WIDEBAND_SPEECH },

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] Bluetooth: btusb: Add Realtek RTL8852BE support ID" failed to apply to 5.4-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.4.y git checkout FETCH_HEAD git cherry-pick -x 473a89b4ed7fd52a419340f7c540d5c8fc96fc75 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072510-grove-resent-a6fc@gregkh' --subject-prefix 'PATCH 5.4.y' HEAD^.. Possible dependencies: 473a89b4ed7f ("Bluetooth: btusb: Add Realtek RTL8852BE support ID 0x13d3:0x3591") 295ef07a9dae ("Bluetooth: btusb: Add RTL8852BE device 0489:e125 to device tables") 3600860a7193 ("Bluetooth: Add device 13d3:3572 IMC Networks Bluetooth Radio") 069f534247bb ("bluetooth: Add device 13d3:3571 to device tables") 730a1d1a93a3 ("bluetooth: Add device 0bda:887b to device tables") 393b4916b7b5 ("Bluetooth: btusb: Add Realtek RTL8852BE support ID 0x0cb8:0xc559") 33bfd94a05ab ("Bluetooth: btusb: add Realtek 8822CE to usb_device_id table") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 473a89b4ed7fd52a419340f7c540d5c8fc96fc75 Mon Sep 17 00:00:00 2001 From: WangYuli <wangyuli(a)uniontech.com> Date: Sat, 22 Jun 2024 12:09:59 +0800 Subject: [PATCH] Bluetooth: btusb: Add Realtek RTL8852BE support ID 0x13d3:0x3591 Add the support ID(0x13d3, 0x3591) to usb_device_id table for Realtek RTL8852BE. The device table is as follows: T: Bus=01 Lev=02 Prnt=03 Port=00 Cnt=01 Dev#= 5 Spd=12 MxCh= 0 D: Ver= 1.00 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 P: Vendor=13d3 ProdID=3591 Rev= 0.00 S: Manufacturer=Realtek S: Product=Bluetooth Radio S: SerialNumber=00e04c000001 C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=500mA I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms Cc: stable(a)vger.kernel.org Signed-off-by: Wentao Guan <guanwentao(a)uniontech.com> Signed-off-by: WangYuli <wangyuli(a)uniontech.com> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz(a)intel.com> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 2d7d47f9d007..2d5c971a59ad 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -555,6 +555,8 @@ static const struct usb_device_id quirks_table[] = { BTUSB_WIDEBAND_SPEECH }, { USB_DEVICE(0x13d3, 0x3572), .driver_info = BTUSB_REALTEK | BTUSB_WIDEBAND_SPEECH }, + { USB_DEVICE(0x13d3, 0x3591), .driver_info = BTUSB_REALTEK | + BTUSB_WIDEBAND_SPEECH }, { USB_DEVICE(0x0489, 0xe125), .driver_info = BTUSB_REALTEK | BTUSB_WIDEBAND_SPEECH },

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] Bluetooth: btusb: Add Realtek RTL8852BE support ID" failed to apply to 5.10-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x 473a89b4ed7fd52a419340f7c540d5c8fc96fc75 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072509-slacking-prowling-76a4@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^.. Possible dependencies: 473a89b4ed7f ("Bluetooth: btusb: Add Realtek RTL8852BE support ID 0x13d3:0x3591") 295ef07a9dae ("Bluetooth: btusb: Add RTL8852BE device 0489:e125 to device tables") 3600860a7193 ("Bluetooth: Add device 13d3:3572 IMC Networks Bluetooth Radio") 069f534247bb ("bluetooth: Add device 13d3:3571 to device tables") 730a1d1a93a3 ("bluetooth: Add device 0bda:887b to device tables") 393b4916b7b5 ("Bluetooth: btusb: Add Realtek RTL8852BE support ID 0x0cb8:0xc559") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 473a89b4ed7fd52a419340f7c540d5c8fc96fc75 Mon Sep 17 00:00:00 2001 From: WangYuli <wangyuli(a)uniontech.com> Date: Sat, 22 Jun 2024 12:09:59 +0800 Subject: [PATCH] Bluetooth: btusb: Add Realtek RTL8852BE support ID 0x13d3:0x3591 Add the support ID(0x13d3, 0x3591) to usb_device_id table for Realtek RTL8852BE. The device table is as follows: T: Bus=01 Lev=02 Prnt=03 Port=00 Cnt=01 Dev#= 5 Spd=12 MxCh= 0 D: Ver= 1.00 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 P: Vendor=13d3 ProdID=3591 Rev= 0.00 S: Manufacturer=Realtek S: Product=Bluetooth Radio S: SerialNumber=00e04c000001 C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=500mA I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms Cc: stable(a)vger.kernel.org Signed-off-by: Wentao Guan <guanwentao(a)uniontech.com> Signed-off-by: WangYuli <wangyuli(a)uniontech.com> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz(a)intel.com> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 2d7d47f9d007..2d5c971a59ad 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -555,6 +555,8 @@ static const struct usb_device_id quirks_table[] = { BTUSB_WIDEBAND_SPEECH }, { USB_DEVICE(0x13d3, 0x3572), .driver_info = BTUSB_REALTEK | BTUSB_WIDEBAND_SPEECH }, + { USB_DEVICE(0x13d3, 0x3591), .driver_info = BTUSB_REALTEK | + BTUSB_WIDEBAND_SPEECH }, { USB_DEVICE(0x0489, 0xe125), .driver_info = BTUSB_REALTEK | BTUSB_WIDEBAND_SPEECH },

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] Bluetooth: btusb: Add Realtek RTL8852BE support ID" failed to apply to 5.15-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.15-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.15.y git checkout FETCH_HEAD git cherry-pick -x 473a89b4ed7fd52a419340f7c540d5c8fc96fc75 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072507-corridor-graceful-9eac@gregkh' --subject-prefix 'PATCH 5.15.y' HEAD^.. Possible dependencies: 473a89b4ed7f ("Bluetooth: btusb: Add Realtek RTL8852BE support ID 0x13d3:0x3591") 295ef07a9dae ("Bluetooth: btusb: Add RTL8852BE device 0489:e125 to device tables") 3600860a7193 ("Bluetooth: Add device 13d3:3572 IMC Networks Bluetooth Radio") 069f534247bb ("bluetooth: Add device 13d3:3571 to device tables") 730a1d1a93a3 ("bluetooth: Add device 0bda:887b to device tables") 393b4916b7b5 ("Bluetooth: btusb: Add Realtek RTL8852BE support ID 0x0cb8:0xc559") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 473a89b4ed7fd52a419340f7c540d5c8fc96fc75 Mon Sep 17 00:00:00 2001 From: WangYuli <wangyuli(a)uniontech.com> Date: Sat, 22 Jun 2024 12:09:59 +0800 Subject: [PATCH] Bluetooth: btusb: Add Realtek RTL8852BE support ID 0x13d3:0x3591 Add the support ID(0x13d3, 0x3591) to usb_device_id table for Realtek RTL8852BE. The device table is as follows: T: Bus=01 Lev=02 Prnt=03 Port=00 Cnt=01 Dev#= 5 Spd=12 MxCh= 0 D: Ver= 1.00 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 P: Vendor=13d3 ProdID=3591 Rev= 0.00 S: Manufacturer=Realtek S: Product=Bluetooth Radio S: SerialNumber=00e04c000001 C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=500mA I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms Cc: stable(a)vger.kernel.org Signed-off-by: Wentao Guan <guanwentao(a)uniontech.com> Signed-off-by: WangYuli <wangyuli(a)uniontech.com> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz(a)intel.com> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 2d7d47f9d007..2d5c971a59ad 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -555,6 +555,8 @@ static const struct usb_device_id quirks_table[] = { BTUSB_WIDEBAND_SPEECH }, { USB_DEVICE(0x13d3, 0x3572), .driver_info = BTUSB_REALTEK | BTUSB_WIDEBAND_SPEECH }, + { USB_DEVICE(0x13d3, 0x3591), .driver_info = BTUSB_REALTEK | + BTUSB_WIDEBAND_SPEECH }, { USB_DEVICE(0x0489, 0xe125), .driver_info = BTUSB_REALTEK | BTUSB_WIDEBAND_SPEECH },

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] Bluetooth: btusb: Add Realtek RTL8852BE support ID" failed to apply to 6.1-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.1-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.1.y git checkout FETCH_HEAD git cherry-pick -x 473a89b4ed7fd52a419340f7c540d5c8fc96fc75 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072506-sloped-overhand-cc26@gregkh' --subject-prefix 'PATCH 6.1.y' HEAD^.. Possible dependencies: 473a89b4ed7f ("Bluetooth: btusb: Add Realtek RTL8852BE support ID 0x13d3:0x3591") 295ef07a9dae ("Bluetooth: btusb: Add RTL8852BE device 0489:e125 to device tables") 3600860a7193 ("Bluetooth: Add device 13d3:3572 IMC Networks Bluetooth Radio") 069f534247bb ("bluetooth: Add device 13d3:3571 to device tables") 730a1d1a93a3 ("bluetooth: Add device 0bda:887b to device tables") 393b4916b7b5 ("Bluetooth: btusb: Add Realtek RTL8852BE support ID 0x0cb8:0xc559") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 473a89b4ed7fd52a419340f7c540d5c8fc96fc75 Mon Sep 17 00:00:00 2001 From: WangYuli <wangyuli(a)uniontech.com> Date: Sat, 22 Jun 2024 12:09:59 +0800 Subject: [PATCH] Bluetooth: btusb: Add Realtek RTL8852BE support ID 0x13d3:0x3591 Add the support ID(0x13d3, 0x3591) to usb_device_id table for Realtek RTL8852BE. The device table is as follows: T: Bus=01 Lev=02 Prnt=03 Port=00 Cnt=01 Dev#= 5 Spd=12 MxCh= 0 D: Ver= 1.00 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 P: Vendor=13d3 ProdID=3591 Rev= 0.00 S: Manufacturer=Realtek S: Product=Bluetooth Radio S: SerialNumber=00e04c000001 C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=500mA I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms Cc: stable(a)vger.kernel.org Signed-off-by: Wentao Guan <guanwentao(a)uniontech.com> Signed-off-by: WangYuli <wangyuli(a)uniontech.com> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz(a)intel.com> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 2d7d47f9d007..2d5c971a59ad 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -555,6 +555,8 @@ static const struct usb_device_id quirks_table[] = { BTUSB_WIDEBAND_SPEECH }, { USB_DEVICE(0x13d3, 0x3572), .driver_info = BTUSB_REALTEK | BTUSB_WIDEBAND_SPEECH }, + { USB_DEVICE(0x13d3, 0x3591), .driver_info = BTUSB_REALTEK | + BTUSB_WIDEBAND_SPEECH }, { USB_DEVICE(0x0489, 0xe125), .driver_info = BTUSB_REALTEK | BTUSB_WIDEBAND_SPEECH },

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] Bluetooth: btusb: Add Realtek RTL8852BE support ID" failed to apply to 6.6-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.6-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.6.y git checkout FETCH_HEAD git cherry-pick -x 473a89b4ed7fd52a419340f7c540d5c8fc96fc75 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072505-extradite-thus-9a5c@gregkh' --subject-prefix 'PATCH 6.6.y' HEAD^.. Possible dependencies: 473a89b4ed7f ("Bluetooth: btusb: Add Realtek RTL8852BE support ID 0x13d3:0x3591") 295ef07a9dae ("Bluetooth: btusb: Add RTL8852BE device 0489:e125 to device tables") 3600860a7193 ("Bluetooth: Add device 13d3:3572 IMC Networks Bluetooth Radio") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 473a89b4ed7fd52a419340f7c540d5c8fc96fc75 Mon Sep 17 00:00:00 2001 From: WangYuli <wangyuli(a)uniontech.com> Date: Sat, 22 Jun 2024 12:09:59 +0800 Subject: [PATCH] Bluetooth: btusb: Add Realtek RTL8852BE support ID 0x13d3:0x3591 Add the support ID(0x13d3, 0x3591) to usb_device_id table for Realtek RTL8852BE. The device table is as follows: T: Bus=01 Lev=02 Prnt=03 Port=00 Cnt=01 Dev#= 5 Spd=12 MxCh= 0 D: Ver= 1.00 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 P: Vendor=13d3 ProdID=3591 Rev= 0.00 S: Manufacturer=Realtek S: Product=Bluetooth Radio S: SerialNumber=00e04c000001 C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=500mA I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms Cc: stable(a)vger.kernel.org Signed-off-by: Wentao Guan <guanwentao(a)uniontech.com> Signed-off-by: WangYuli <wangyuli(a)uniontech.com> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz(a)intel.com> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 2d7d47f9d007..2d5c971a59ad 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -555,6 +555,8 @@ static const struct usb_device_id quirks_table[] = { BTUSB_WIDEBAND_SPEECH }, { USB_DEVICE(0x13d3, 0x3572), .driver_info = BTUSB_REALTEK | BTUSB_WIDEBAND_SPEECH }, + { USB_DEVICE(0x13d3, 0x3591), .driver_info = BTUSB_REALTEK | + BTUSB_WIDEBAND_SPEECH }, { USB_DEVICE(0x0489, 0xe125), .driver_info = BTUSB_REALTEK | BTUSB_WIDEBAND_SPEECH },

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] Bluetooth: btusb: Add Realtek RTL8852BE support ID" failed to apply to 6.9-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.9-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.9.y git checkout FETCH_HEAD git cherry-pick -x 473a89b4ed7fd52a419340f7c540d5c8fc96fc75 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072504-bunkmate-disliking-eccc@gregkh' --subject-prefix 'PATCH 6.9.y' HEAD^.. Possible dependencies: 473a89b4ed7f ("Bluetooth: btusb: Add Realtek RTL8852BE support ID 0x13d3:0x3591") 295ef07a9dae ("Bluetooth: btusb: Add RTL8852BE device 0489:e125 to device tables") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 473a89b4ed7fd52a419340f7c540d5c8fc96fc75 Mon Sep 17 00:00:00 2001 From: WangYuli <wangyuli(a)uniontech.com> Date: Sat, 22 Jun 2024 12:09:59 +0800 Subject: [PATCH] Bluetooth: btusb: Add Realtek RTL8852BE support ID 0x13d3:0x3591 Add the support ID(0x13d3, 0x3591) to usb_device_id table for Realtek RTL8852BE. The device table is as follows: T: Bus=01 Lev=02 Prnt=03 Port=00 Cnt=01 Dev#= 5 Spd=12 MxCh= 0 D: Ver= 1.00 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 P: Vendor=13d3 ProdID=3591 Rev= 0.00 S: Manufacturer=Realtek S: Product=Bluetooth Radio S: SerialNumber=00e04c000001 C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=500mA I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms Cc: stable(a)vger.kernel.org Signed-off-by: Wentao Guan <guanwentao(a)uniontech.com> Signed-off-by: WangYuli <wangyuli(a)uniontech.com> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz(a)intel.com> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 2d7d47f9d007..2d5c971a59ad 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -555,6 +555,8 @@ static const struct usb_device_id quirks_table[] = { BTUSB_WIDEBAND_SPEECH }, { USB_DEVICE(0x13d3, 0x3572), .driver_info = BTUSB_REALTEK | BTUSB_WIDEBAND_SPEECH }, + { USB_DEVICE(0x13d3, 0x3591), .driver_info = BTUSB_REALTEK | + BTUSB_WIDEBAND_SPEECH }, { USB_DEVICE(0x0489, 0xe125), .driver_info = BTUSB_REALTEK | BTUSB_WIDEBAND_SPEECH },

1 year, 4 months

1
0
0 0

FAILED: patch "[PATCH] Bluetooth: btusb: Add Realtek RTL8852BE support ID" failed to apply to 6.10-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.10.y git checkout FETCH_HEAD git cherry-pick -x 473a89b4ed7fd52a419340f7c540d5c8fc96fc75 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024072503-karma-crewman-5be4@gregkh' --subject-prefix 'PATCH 6.10.y' HEAD^.. Possible dependencies: 473a89b4ed7f ("Bluetooth: btusb: Add Realtek RTL8852BE support ID 0x13d3:0x3591") 295ef07a9dae ("Bluetooth: btusb: Add RTL8852BE device 0489:e125 to device tables") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 473a89b4ed7fd52a419340f7c540d5c8fc96fc75 Mon Sep 17 00:00:00 2001 From: WangYuli <wangyuli(a)uniontech.com> Date: Sat, 22 Jun 2024 12:09:59 +0800 Subject: [PATCH] Bluetooth: btusb: Add Realtek RTL8852BE support ID 0x13d3:0x3591 Add the support ID(0x13d3, 0x3591) to usb_device_id table for Realtek RTL8852BE. The device table is as follows: T: Bus=01 Lev=02 Prnt=03 Port=00 Cnt=01 Dev#= 5 Spd=12 MxCh= 0 D: Ver= 1.00 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 P: Vendor=13d3 ProdID=3591 Rev= 0.00 S: Manufacturer=Realtek S: Product=Bluetooth Radio S: SerialNumber=00e04c000001 C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=500mA I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms Cc: stable(a)vger.kernel.org Signed-off-by: Wentao Guan <guanwentao(a)uniontech.com> Signed-off-by: WangYuli <wangyuli(a)uniontech.com> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz(a)intel.com> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 2d7d47f9d007..2d5c971a59ad 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -555,6 +555,8 @@ static const struct usb_device_id quirks_table[] = { BTUSB_WIDEBAND_SPEECH }, { USB_DEVICE(0x13d3, 0x3572), .driver_info = BTUSB_REALTEK | BTUSB_WIDEBAND_SPEECH }, + { USB_DEVICE(0x13d3, 0x3591), .driver_info = BTUSB_REALTEK | + BTUSB_WIDEBAND_SPEECH }, { USB_DEVICE(0x0489, 0xe125), .driver_info = BTUSB_REALTEK | BTUSB_WIDEBAND_SPEECH },

1 year, 4 months

1
0
0 0

[PATCH 6.1.y] f2fs: avoid dead loop in f2fs_issue_checkpoint()

by Sergio González Collado

From: Chao Yu <chao(a)kernel.org> [ Upstream commit 5079e1c0c879311668b77075de3e701869804adf ] generic/082 reports a bug as below: __schedule+0x332/0xf60 schedule+0x6f/0xf0 schedule_timeout+0x23b/0x2a0 wait_for_completion+0x8f/0x140 f2fs_issue_checkpoint+0xfe/0x1b0 f2fs_sync_fs+0x9d/0xb0 sync_filesystem+0x87/0xb0 dquot_load_quota_sb+0x41b/0x460 dquot_load_quota_inode+0xa5/0x130 dquot_quota_on+0x4b/0x60 f2fs_quota_on+0xe3/0x1b0 do_quotactl+0x483/0x700 __x64_sys_quotactl+0x15c/0x310 do_syscall_64+0x3f/0x90 entry_SYSCALL_64_after_hwframe+0x72/0xdc The root casue is race case as below: Thread A Kworker IRQ - write() : write data to quota.user file - writepages - f2fs_submit_page_write - __is_cp_guaranteed return false - inc_page_count(F2FS_WB_DATA) - submit_bio - quotactl(Q_QUOTAON) - f2fs_quota_on - dquot_quota_on - dquot_load_quota_inode - vfs_setup_quota_inode : inode->i_flags |= S_NOQUOTA - f2fs_write_end_io - __is_cp_guaranteed return true - dec_page_count(F2FS_WB_CP_DATA) - dquot_load_quota_sb - f2fs_sync_fs - f2fs_issue_checkpoint - do_checkpoint - f2fs_wait_on_all_pages(F2FS_WB_CP_DATA) : loop due to F2FS_WB_CP_DATA count is negative Calling filemap_fdatawrite() and filemap_fdatawait() to keep all data clean before quota file setup. Signed-off-by: Chao Yu <chao(a)kernel.org> Signed-off-by: Jaegeuk Kim <jaegeuk(a)kernel.org> (cherry picked from commit 5079e1c0c879311668b77075de3e701869804adf) Signed-off-by: Sergio González Collado <sergio.collado(a)gmail.com> Reported-by: syzbot+d0ab8746c920a592aeab(a)syzkaller.appspotmail.com --- fs/f2fs/super.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index 6bd8c231069a..2d586a6bfe5f 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -2824,15 +2824,26 @@ static int f2fs_quota_on(struct super_block *sb, int type, int format_id, return -EBUSY; } + if (path->dentry->d_sb != sb) + return -EXDEV; + err = f2fs_quota_sync(sb, type); if (err) return err; - err = dquot_quota_on(sb, type, format_id, path); + inode = d_inode(path->dentry); + + err = filemap_fdatawrite(inode->i_mapping); if (err) return err; - inode = d_inode(path->dentry); + err = filemap_fdatawait(inode->i_mapping); + if (err) + return err; + + err = dquot_quota_on(sb, type, format_id, path); + if (err) + return err; inode_lock(inode); F2FS_I(inode)->i_flags |= F2FS_NOATIME_FL | F2FS_IMMUTABLE_FL; -- 2.39.2

1 year, 4 months

2
1
0 0

[PATCH v2 4.19 5.4 5.10 5.15] net: relax socket state check at accept time.

by Nikolay Kuratov

[ Upstream commit 26afda78cda3da974fd4c287962c169e9462c495 ] Christoph reported the following splat: WARNING: CPU: 1 PID: 772 at net/ipv4/af_inet.c:761 __inet_accept+0x1f4/0x4a0 Modules linked in: CPU: 1 PID: 772 Comm: syz-executor510 Not tainted 6.9.0-rc7-g7da7119fe22b #56 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.11.0-2.el7 04/01/2014 RIP: 0010:__inet_accept+0x1f4/0x4a0 net/ipv4/af_inet.c:759 Code: 04 38 84 c0 0f 85 87 00 00 00 41 c7 04 24 03 00 00 00 48 83 c4 10 5b 41 5c 41 5d 41 5e 41 5f 5d c3 cc cc cc cc e8 ec b7 da fd <0f> 0b e9 7f fe ff ff e8 e0 b7 da fd 0f 0b e9 fe fe ff ff 89 d9 80 RSP: 0018:ffffc90000c2fc58 EFLAGS: 00010293 RAX: ffffffff836bdd14 RBX: 0000000000000000 RCX: ffff888104668000 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000 RBP: dffffc0000000000 R08: ffffffff836bdb89 R09: fffff52000185f64 R10: dffffc0000000000 R11: fffff52000185f64 R12: dffffc0000000000 R13: 1ffff92000185f98 R14: ffff88810754d880 R15: ffff8881007b7800 FS: 000000001c772880(0000) GS:ffff88811b280000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007fb9fcf2e178 CR3: 00000001045d2002 CR4: 0000000000770ef0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 PKRU: 55555554 Call Trace: <TASK> inet_accept+0x138/0x1d0 net/ipv4/af_inet.c:786 do_accept+0x435/0x620 net/socket.c:1929 __sys_accept4_file net/socket.c:1969 [inline] __sys_accept4+0x9b/0x110 net/socket.c:1999 __do_sys_accept net/socket.c:2016 [inline] __se_sys_accept net/socket.c:2013 [inline] __x64_sys_accept+0x7d/0x90 net/socket.c:2013 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0x58/0x100 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x76/0x7e RIP: 0033:0x4315f9 Code: fd ff 48 81 c4 80 00 00 00 e9 f1 fe ff ff 0f 1f 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 ab b4 fd ff c3 66 2e 0f 1f 84 00 00 00 00 RSP: 002b:00007ffdb26d9c78 EFLAGS: 00000246 ORIG_RAX: 000000000000002b RAX: ffffffffffffffda RBX: 0000000000400300 RCX: 00000000004315f9 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000004 RBP: 00000000006e1018 R08: 0000000000400300 R09: 0000000000400300 R10: 0000000000400300 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000040cdf0 R14: 000000000040ce80 R15: 0000000000000055 </TASK> The reproducer invokes shutdown() before entering the listener status. After commit 94062790aedb ("tcp: defer shutdown(SEND_SHUTDOWN) for TCP_SYN_RECV sockets"), the above causes the child to reach the accept syscall in FIN_WAIT1 status. Eric noted we can relax the existing assertion in __inet_accept() Reported-by: Christoph Paasch <cpaasch(a)apple.com> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/490 Suggested-by: Eric Dumazet <edumazet(a)google.com> Fixes: 94062790aedb ("tcp: defer shutdown(SEND_SHUTDOWN) for TCP_SYN_RECV sockets") Link: https://lore.kernel.org/r/23ab880a44d8cfd967e84de8b93dbf48848e3d8c.17162996… Link: https://lore.kernel.org/linux-cve-announce/2024062136-CVE-2024-36484-375b@g… Signed-off-by: Paolo Abeni <pabeni(a)redhat.com> Signed-off-by: Nikolay Kuratov <kniv(a)yandex-team.ru> --- Changes in v2: - restore Signed-off-by tag with original author Paolo Abeni <pabeni(a)redhat.com> --- net/ipv4/af_inet.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c index 475a19db3713..ce42626663de 100644 --- a/net/ipv4/af_inet.c +++ b/net/ipv4/af_inet.c @@ -758,7 +758,9 @@ int inet_accept(struct socket *sock, struct socket *newsock, int flags, sock_rps_record_flow(sk2); WARN_ON(!((1 << sk2->sk_state) & (TCPF_ESTABLISHED | TCPF_SYN_RECV | - TCPF_CLOSE_WAIT | TCPF_CLOSE))); + TCPF_FIN_WAIT1 | TCPF_FIN_WAIT2 | + TCPF_CLOSING | TCPF_CLOSE_WAIT | + TCPF_CLOSE))); sock_graft(sk2, newsock); -- 2.34.1

1 year, 4 months

2
1
0 0

[PATCH v5.15.y 0/4] Apply fanotify-related documentation changes

by cel＠kernel.org

From: Chuck Lever <chuck.lever(a)oracle.com> These extra commits were requested by Amir Goldstein <amir73il(a)gmail.com>. Note that c0baf9ac0b05 ("docs: Document the FAN_FS_ERROR event") is already applied to v5.15.y. Gabriel Krisman Bertazi (3): samples: Add fs error monitoring example samples: Make fs-monitor depend on libc and headers docs: Fix formatting of literal sections in fanotify docs Linus Torvalds (1): Add gitignore file for samples/fanotify/ subdirectory .../admin-guide/filesystem-monitoring.rst | 20 ++- samples/Kconfig | 9 ++ samples/Makefile | 1 + samples/fanotify/.gitignore | 1 + samples/fanotify/Makefile | 5 + samples/fanotify/fs-monitor.c | 142 ++++++++++++++++++ 6 files changed, 170 insertions(+), 8 deletions(-) create mode 100644 samples/fanotify/.gitignore create mode 100644 samples/fanotify/Makefile create mode 100644 samples/fanotify/fs-monitor.c -- 2.45.2

1 year, 4 months

2
5
0 0

[PATCH] drm/panfrost: Mark simple_ondemand governor as softdep

by Dragan Simic

Panfrost DRM driver uses devfreq to perform DVFS, while using simple_ondemand devfreq governor by default. This causes driver initialization to fail on boot when simple_ondemand governor isn't built into the kernel statically, as a result of the missing module dependency and, consequently, the required governor module not being included in the initial ramdisk. Thus, let's mark simple_ondemand governor as a softdep for Panfrost, to have its kernel module included in the initial ramdisk. This is a rather longstanding issue that has forced distributions to build devfreq governors statically into their kernels, [1][2] or has forced users to introduce some unnecessary workarounds. [3] For future reference, not having support for the simple_ondemand governor in the initial ramdisk produces errors in the kernel log similar to these below, which were taken from a Pine64 RockPro64: panfrost ff9a0000.gpu: [drm:panfrost_devfreq_init [panfrost]] *ERROR* Couldn't initialize GPU devfreq panfrost ff9a0000.gpu: Fatal error during GPU init panfrost: probe of ff9a0000.gpu failed with error -22 Having simple_ondemand marked as a softdep for Panfrost may not resolve this issue for all Linux distributions. In particular, it will remain unresolved for the distributions whose utilities for the initial ramdisk generation do not handle the available softdep information [4] properly yet. However, some Linux distributions already handle softdeps properly while generating their initial ramdisks, [5] and this is a prerequisite step in the right direction for the distributions that don't handle them properly yet. [1] https://gitlab.manjaro.org/manjaro-arm/packages/core/linux/-/blob/linux61/c… [2] https://salsa.debian.org/kernel-team/linux/-/merge_requests/1066 [3] https://forum.pine64.org/showthread.php?tid=15458 [4] https://git.kernel.org/pub/scm/utils/kernel/kmod/kmod.git/commit/?id=49d8e0… [5] https://github.com/archlinux/mkinitcpio/commit/97ac4d37aae084a050be512f6d8f… Cc: Diederik de Haas <didi.debian(a)cknow.org> Cc: Furkan Kardame <f.kardame(a)manjaro.org> Cc: stable(a)vger.kernel.org Fixes: f3ba91228e8e ("drm/panfrost: Add initial panfrost driver") Signed-off-by: Dragan Simic <dsimic(a)manjaro.org> --- drivers/gpu/drm/panfrost/panfrost_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c index ef9f6c0716d5..149737d7a07e 100644 --- a/drivers/gpu/drm/panfrost/panfrost_drv.c +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c @@ -828,3 +828,4 @@ module_platform_driver(panfrost_driver); MODULE_AUTHOR("Panfrost Project Developers"); MODULE_DESCRIPTION("Panfrost DRM Driver"); MODULE_LICENSE("GPL v2"); +MODULE_SOFTDEP("pre: governor_simpleondemand");

1 year, 4 months

4
10
0 0

[PATCH 4.19 5.4 5.10 5.15] net: relax socket state check at accept time.

by Nikolay Kuratov

[ Upstream commit 26afda78cda3da974fd4c287962c169e9462c495 ] Christoph reported the following splat: WARNING: CPU: 1 PID: 772 at net/ipv4/af_inet.c:761 __inet_accept+0x1f4/0x4a0 Modules linked in: CPU: 1 PID: 772 Comm: syz-executor510 Not tainted 6.9.0-rc7-g7da7119fe22b #56 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.11.0-2.el7 04/01/2014 RIP: 0010:__inet_accept+0x1f4/0x4a0 net/ipv4/af_inet.c:759 Code: 04 38 84 c0 0f 85 87 00 00 00 41 c7 04 24 03 00 00 00 48 83 c4 10 5b 41 5c 41 5d 41 5e 41 5f 5d c3 cc cc cc cc e8 ec b7 da fd <0f> 0b e9 7f fe ff ff e8 e0 b7 da fd 0f 0b e9 fe fe ff ff 89 d9 80 RSP: 0018:ffffc90000c2fc58 EFLAGS: 00010293 RAX: ffffffff836bdd14 RBX: 0000000000000000 RCX: ffff888104668000 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000 RBP: dffffc0000000000 R08: ffffffff836bdb89 R09: fffff52000185f64 R10: dffffc0000000000 R11: fffff52000185f64 R12: dffffc0000000000 R13: 1ffff92000185f98 R14: ffff88810754d880 R15: ffff8881007b7800 FS: 000000001c772880(0000) GS:ffff88811b280000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007fb9fcf2e178 CR3: 00000001045d2002 CR4: 0000000000770ef0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 PKRU: 55555554 Call Trace: <TASK> inet_accept+0x138/0x1d0 net/ipv4/af_inet.c:786 do_accept+0x435/0x620 net/socket.c:1929 __sys_accept4_file net/socket.c:1969 [inline] __sys_accept4+0x9b/0x110 net/socket.c:1999 __do_sys_accept net/socket.c:2016 [inline] __se_sys_accept net/socket.c:2013 [inline] __x64_sys_accept+0x7d/0x90 net/socket.c:2013 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0x58/0x100 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x76/0x7e RIP: 0033:0x4315f9 Code: fd ff 48 81 c4 80 00 00 00 e9 f1 fe ff ff 0f 1f 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 ab b4 fd ff c3 66 2e 0f 1f 84 00 00 00 00 RSP: 002b:00007ffdb26d9c78 EFLAGS: 00000246 ORIG_RAX: 000000000000002b RAX: ffffffffffffffda RBX: 0000000000400300 RCX: 00000000004315f9 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000004 RBP: 00000000006e1018 R08: 0000000000400300 R09: 0000000000400300 R10: 0000000000400300 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000040cdf0 R14: 000000000040ce80 R15: 0000000000000055 </TASK> The reproducer invokes shutdown() before entering the listener status. After commit 94062790aedb ("tcp: defer shutdown(SEND_SHUTDOWN) for TCP_SYN_RECV sockets"), the above causes the child to reach the accept syscall in FIN_WAIT1 status. Eric noted we can relax the existing assertion in __inet_accept() Reported-by: Christoph Paasch <cpaasch(a)apple.com> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/490 Suggested-by: Eric Dumazet <edumazet(a)google.com> Fixes: 94062790aedb ("tcp: defer shutdown(SEND_SHUTDOWN) for TCP_SYN_RECV sockets") Link: https://lore.kernel.org/r/23ab880a44d8cfd967e84de8b93dbf48848e3d8c.17162996… Link: https://lore.kernel.org/linux-cve-announce/2024062136-CVE-2024-36484-375b@g… Signed-off-by: Nikolay Kuratov <kniv(a)yandex-team.ru> --- net/ipv4/af_inet.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c index 475a19db3713..ce42626663de 100644 --- a/net/ipv4/af_inet.c +++ b/net/ipv4/af_inet.c @@ -758,7 +758,9 @@ int inet_accept(struct socket *sock, struct socket *newsock, int flags, sock_rps_record_flow(sk2); WARN_ON(!((1 << sk2->sk_state) & (TCPF_ESTABLISHED | TCPF_SYN_RECV | - TCPF_CLOSE_WAIT | TCPF_CLOSE))); + TCPF_FIN_WAIT1 | TCPF_FIN_WAIT2 | + TCPF_CLOSING | TCPF_CLOSE_WAIT | + TCPF_CLOSE))); sock_graft(sk2, newsock); -- 2.34.1

1 year, 4 months

2
1
0 0

Linux 6.9.11

by Greg Kroah-Hartman

I'm announcing the release of the 6.9.11 kernel. All users of the 6.9 kernel series must upgrade. The updated 6.9.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-6.9.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Documentation/cdrom/cdrom-standard.rst | 4 Makefile | 2 arch/arm64/kernel/armv8_deprecated.c | 3 arch/loongarch/boot/dts/loongson-2k0500-ref.dts | 4 arch/loongarch/boot/dts/loongson-2k1000-ref.dts | 4 arch/loongarch/boot/dts/loongson-2k2000-ref.dts | 2 arch/mips/kernel/syscalls/syscall_o32.tbl | 2 arch/powerpc/kernel/eeh_pe.c | 7 arch/powerpc/kvm/book3s_64_vio.c | 18 arch/powerpc/platforms/pseries/setup.c | 4 arch/riscv/kernel/stacktrace.c | 3 drivers/acpi/ac.c | 4 drivers/acpi/ec.c | 9 drivers/acpi/sbs.c | 4 drivers/block/loop.c | 23 drivers/block/null_blk/main.c | 4 drivers/bluetooth/btnxpuart.c | 2 drivers/clk/qcom/apss-ipq-pll.c | 2 drivers/firmware/efi/libstub/zboot.lds | 1 drivers/gpio/gpio-pca953x.c | 2 drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 15 drivers/gpu/drm/amd/amdgpu/psp_v14_0.c | 5 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 52 + drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c | 3 drivers/gpu/drm/amd/display/dc/dml/dcn35/dcn35_fpu.c | 2 drivers/gpu/drm/amd/display/dc/dml/dcn351/dcn351_fpu.c | 2 drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c | 1 drivers/gpu/drm/amd/display/dc/dml2/dml2_utils.c | 2 drivers/gpu/drm/amd/include/pptable.h | 91 +-- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 13 drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 5 drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v14_0_0_ppsmc.h | 4 drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h | 4 drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c | 73 ++ drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 drivers/gpu/drm/exynos/exynos_dp.c | 1 drivers/gpu/drm/mediatek/mtk_drm_drv.c | 8 drivers/gpu/drm/radeon/radeon_gem.c | 2 drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c | 8 drivers/gpu/drm/vmwgfx/Kconfig | 2 drivers/hid/hid-debug.c | 2 drivers/hid/hid-ids.h | 2 drivers/hid/hid-input.c | 13 drivers/input/joystick/xpad.c | 1 drivers/input/mouse/elantech.c | 31 + drivers/input/serio/i8042-acpipnpio.h | 18 drivers/input/touchscreen/ads7846.c | 12 drivers/input/touchscreen/silead.c | 19 drivers/misc/mei/main.c | 2 drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c | 2 drivers/net/ethernet/ibm/ibmvnic.c | 12 drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 1 drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 10 drivers/net/ethernet/marvell/octeontx2/nic/otx2_reg.h | 55 +- drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c | 2 drivers/net/ethernet/marvell/octeontx2/nic/qos.c | 3 drivers/net/usb/qmi_wwan.c | 2 drivers/net/wireless/intel/iwlwifi/mvm/d3.c | 16 drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 47 + drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c | 13 drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 6 drivers/net/wireless/intel/iwlwifi/mvm/scan.c | 8 drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 12 drivers/net/wireless/intel/iwlwifi/mvm/sta.h | 5 drivers/nvme/host/core.c | 1 drivers/nvme/host/fabrics.c | 6 drivers/nvme/host/nvme.h | 2 drivers/nvme/target/core.c | 1 drivers/nvme/target/fabrics-cmd-auth.c | 3 drivers/nvme/target/fabrics-cmd.c | 6 drivers/of/irq.c | 143 ++--- drivers/of/of_private.h | 3 drivers/parport/parport_amiga.c | 8 drivers/perf/riscv_pmu_sbi.c | 2 drivers/platform/mellanox/nvsw-sn2201.c | 5 drivers/platform/x86/amd/hsmp.c | 50 + drivers/platform/x86/lg-laptop.c | 89 +-- drivers/platform/x86/wireless-hotkey.c | 2 drivers/pnp/base.h | 1 drivers/s390/char/sclp.c | 1 drivers/scsi/device_handler/scsi_dh_alua.c | 31 - drivers/scsi/libsas/sas_internal.h | 14 drivers/scsi/qedf/qedf.h | 1 drivers/scsi/qedf/qedf_main.c | 47 + drivers/scsi/sr.h | 2 drivers/scsi/sr_ioctl.c | 5 drivers/spi/spi-davinci.c | 6 drivers/spi/spi-imx.c | 2 drivers/spi/spi-mux.c | 1 drivers/spi/spi.c | 6 drivers/tee/optee/ffa_abi.c | 12 drivers/vfio/device_cdev.c | 7 drivers/vfio/group.c | 7 drivers/vfio/pci/vfio_pci_core.c | 271 ++-------- drivers/vfio/vfio_main.c | 44 + fs/btrfs/btrfs_inode.h | 10 fs/btrfs/file.c | 16 fs/btrfs/ordered-data.c | 31 + fs/btrfs/qgroup.c | 4 fs/btrfs/ref-verify.c | 9 fs/btrfs/scrub.c | 24 fs/cachefiles/cache.c | 45 + fs/cachefiles/ondemand.c | 74 +- fs/cachefiles/volume.c | 1 fs/dcache.c | 31 - fs/erofs/zmap.c | 2 fs/file.c | 4 fs/hfsplus/xattr.c | 2 fs/iomap/buffered-io.c | 3 fs/netfs/buffered_write.c | 4 fs/netfs/fscache_volume.c | 14 fs/netfs/internal.h | 2 fs/nfs/dir.c | 27 fs/nfs/nfs4proc.c | 1 fs/nfs/pagelist.c | 5 fs/nfs/symlink.c | 2 fs/smb/client/cifsfs.c | 2 fs/smb/client/file.c | 4 fs/smb/common/smb2pdu.h | 34 + fs/smb/server/smb2pdu.c | 9 include/linux/cdrom.h | 2 include/linux/fscache-cache.h | 6 include/linux/page_ref.h | 49 - include/linux/pnp.h | 2 include/linux/spi/spi.h | 5 include/linux/vfio.h | 1 include/linux/vfio_pci_core.h | 2 include/net/bluetooth/hci_sync.h | 2 include/sound/dmaengine_pcm.h | 1 include/trace/events/fscache.h | 4 include/uapi/linux/input-event-codes.h | 2 io_uring/register.c | 4 kernel/workqueue.c | 51 + lib/Kconfig | 8 lib/closure.c | 10 mm/filemap.c | 10 mm/gup.c | 2 net/bluetooth/hci_core.c | 76 -- net/bluetooth/hci_sync.c | 13 net/bluetooth/l2cap_core.c | 3 net/bluetooth/l2cap_sock.c | 14 net/ipv6/ila/ila_lwt.c | 7 net/ipv6/rpl_iptunnel.c | 14 net/mac80211/cfg.c | 5 net/mac80211/ieee80211_i.h | 2 net/mac80211/main.c | 11 net/mac80211/mesh.c | 1 net/mac80211/scan.c | 31 - net/mac80211/util.c | 4 net/mac802154/tx.c | 8 net/wireless/rdev-ops.h | 6 net/wireless/scan.c | 59 +- scripts/kconfig/expr.c | 29 - scripts/kconfig/expr.h | 1 scripts/kconfig/gconf.c | 3 scripts/kconfig/menu.c | 2 sound/core/pcm_dmaengine.c | 22 sound/core/pcm_native.c | 2 sound/pci/hda/Kconfig | 2 sound/pci/hda/cs35l41_hda_property.c | 8 sound/pci/hda/cs35l56_hda.c | 5 sound/pci/hda/patch_realtek.c | 9 sound/soc/amd/yc/acp6x-mach.c | 7 sound/soc/codecs/cs35l56-shared.c | 4 sound/soc/codecs/es8326.c | 8 sound/soc/codecs/rt722-sdca-sdw.c | 4 sound/soc/intel/avs/topology.c | 19 sound/soc/intel/boards/bytcr_rt5640.c | 11 sound/soc/soc-generic-dmaengine-pcm.c | 8 sound/soc/soc-topology.c | 29 - sound/soc/sof/intel/hda-pcm.c | 6 sound/soc/sof/sof-audio.c | 2 sound/soc/ti/davinci-mcasp.c | 9 sound/soc/ti/omap-hdmi.c | 6 tools/power/cpupower/utils/helpers/amd.c | 26 tools/testing/selftests/bpf/config | 3 tools/testing/selftests/bpf/prog_tests/tc_links.c | 61 ++ tools/testing/selftests/cachestat/test_cachestat.c | 1 tools/testing/selftests/filesystems/overlayfs/dev_in_maps.c | 1 tools/testing/selftests/futex/functional/Makefile | 2 tools/testing/selftests/net/openvswitch/ovs-dpctl.py | 2 tools/testing/selftests/openat2/openat2_test.c | 1 tools/testing/selftests/timens/exec.c | 6 tools/testing/selftests/timens/timer.c | 2 tools/testing/selftests/timens/timerfd.c | 2 tools/testing/selftests/timens/vfork_exec.c | 4 tools/testing/selftests/vDSO/parse_vdso.c | 16 tools/testing/selftests/vDSO/vdso_standalone_test_x86.c | 18 188 files changed, 1713 insertions(+), 879 deletions(-) Adrian Moreno (1): selftests: openvswitch: Set value to nla flags. Aivaz Latypov (1): ALSA: hda/relatek: Enable Mute LED on HP Laptop 15-gw0xxx Alex Williamson (3): vfio: Create vfio_fs_type with inode per device vfio/pci: Use unmap_mapping_range() vfio/pci: Insert full vma on mmap'd MMIO fault Alexander Stein (1): Input: ads7846 - use spi_device_id table Alexander Usyskin (1): mei: demote client disconnect warning on suspend to debug Alexey Makhalov (1): drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency Alvin Lee (1): drm/amd/display: Account for cursor prefetch BW in DML1 mode support Amadeusz Sławiński (3): ASoC: topology: Fix references to freed memory ASoC: Intel: avs: Fix route override ASoC: topology: Do not assign fields that are already set Andreas Hindborg (1): null_blk: fix validation of block size Andy Shevchenko (1): PNP: Hide pnp_bus_type from the non-PNP code Anjali K (1): powerpc/pseries: Whitelist dtl slub object for copying to userspace Armin Wolf (6): ACPI: EC: Abort address space access upon error ACPI: EC: Avoid returning AE_OK on errors in address space handler platform/x86: wireless-hotkey: Add support for LG Airplane Button platform/x86: lg-laptop: Remove LGEX0815 hotkey handling platform/x86: lg-laptop: Change ACPI device id platform/x86: lg-laptop: Use ACPI device handle when evaluating WMAB/WMBB Arnd Bergmann (1): mips: fix compat_sys_lseek syscall Aryan Srivastava (1): net: mvpp2: fill-in dev_port attribute Aseda Aboagye (2): input: Add event code for accessibility key input: Add support for "Do Not Disturb" Ayala Beker (1): wifi: iwlwifi: mvm: properly set 6 GHz channel direct probe option Baokun Li (5): cachefiles: add consistency check for copen/cread cachefiles: make on-demand read killable netfs, fscache: export fscache_put_volume() and add fscache_try_get_volume() cachefiles: fix slab-use-after-free in fscache_withdraw_volume() cachefiles: fix slab-use-after-free in cachefiles_withdraw_cookie() Bastien Curutchet (1): spi: davinci: Unset POWERDOWN bit when releasing resources Benjamin Berg (1): wifi: iwlwifi: mvm: remove stale STA link data during restart Boyang Yu (1): nvme: fix NVME_NS_DEAC may incorrectly identifying the disk as EXT_LBA. Chen Ni (2): can: kvaser_usb: fix return value for hif_usb_send_regout platform/mellanox: nvsw-sn2201: Add check for platform_device_add_resources Christian Brauner (1): fs: better handle deep ancestor chains in is_subdir() Chunguang Xu (2): nvme-fabrics: use reserved tag for reg read/write command nvme: avoid double free special payload Cyril Hrubis (1): loop: Disable fallocate() zero and discard if not supported Daniel Borkmann (1): selftests/bpf: Extend tcx tests to cover late tcx_entry release Daniel Gabay (1): wifi: iwlwifi: properly set WIPHY_FLAG_SUPPORTS_EXT_KEK_KCK Daniel Miess (1): drm/amd/display: Change dram_clock_latency to 34us for dcn351 Daniel Wagner (1): nvmet: always initialize cqe.result Daniele Palmas (1): net: usb: qmi_wwan: add Telit FN912 compositions David Lechner (1): spi: mux: set ctlr->bits_per_word_mask Dhananjay Ugwekar (1): tools/power/cpupower: Fix Pstate frequency reporting on AMD Family 1Ah CPUs Dmitry Antipov (2): wifi: mac80211: fix UBSAN noise in ieee80211_prep_hw_scan() wifi: cfg80211: wext: add extra SIOCSIWSCAN data check Dmitry Mastykin (1): NFSv4: Fix memory leak in nfs4_set_security_label Dmitry Savin (1): ALSA: hda: cs35l41: Fix swapped l/r audio channels for Lenovo ThinBook 13x Gen4 Douglas Anderson (2): drm: renesas: shmobile: Call drm_atomic_helper_shutdown() at shutdown time drm/mediatek: Call drm_atomic_helper_shutdown() at shutdown time Edward Adam Davis (2): bluetooth/l2cap: sync sock recv cb and release hfsplus: fix uninit-value in copy_name Emmanuel Grumbach (1): wifi: iwlwifi: mvm: don't wake up rx_sync_waitq upon RFKILL Eric Dumazet (2): net: ipv6: rpl_iptunnel: block BH in rpl_output() and rpl_input() ila: block BH in ila_output() Fangzhi Zuo (1): drm/amd/display: Update efficiency bandwidth for dcn351 Filipe Manana (3): btrfs: ensure fast fsync waits for ordered extents after a write failure btrfs: qgroup: fix quota root leak after quota disable failure btrfs: fix uninitialized return value in the ref-verify tool Gabor Juhos (1): clk: qcom: apss-ipq-pll: remove 'config_ctl_hi_val' from Stromer pll configs Ganesh Goudar (1): powerpc/eeh: avoid possible crash when edev->pdev changes Gao Xiang (1): erofs: ensure m_llen is reset to 0 if metadata is invalid Greg Kroah-Hartman (1): Linux 6.9.11 Hagar Hemdan (1): io_uring: fix possible deadlock in io_register_iowq_max_workers() Hans de Goede (1): Input: silead - Always support 10 fingers Harish Kasiviswanathan (1): drm/amdgpu: Indicate CU havest info to CP Heiko Carstens (1): s390/sclp: Fix sclp_init() cleanup on failure Huacai Chen (1): LoongArch: Fix GMAC's phy-mode definitions in dts Ian Ray (1): gpio: pca953x: fix pca953x_irq_bus_sync_unlock race Ilan Peer (1): wifi: iwlwifi: mvm: Fix scan abort handling with HW rfkill Jack Yu (2): ASoC: rt722-sdca-sdw: add silence detection register as volatile ASoC: rt722-sdca-sdw: add debounce time for type detection Jai Luthra (2): ALSA: dmaengine: Synchronize dma channel after drop() ASoC: ti: davinci-mcasp: Set min period size using FIFO config Jan Kara (1): nfs: Avoid flushing many pages with NFS_FILE_SYNC Johannes Berg (6): wifi: mac80211: apply mcast rate only if interface is up wifi: mac80211: handle tasklet frames before stopping wifi: cfg80211: fix 6 GHz scan request building wifi: iwlwifi: mvm: handle BA session teardown in RF-kill wifi: cfg80211: wext: set ssids=NULL for passive scans wifi: mac80211: disable softirqs for queued frame handling John Hubbard (3): selftests/futex: pass _GNU_SOURCE without a value to the compiler selftest/timerns: fix clang build failures for abs() calls selftests/vDSO: fix clang build errors and warnings Jonathan Denose (1): Input: elantech - fix touchpad state on resume for Lenovo N24 Justin Stitt (1): scsi: sr: Fix unintentional arithmetic wraparound Kailang Yang (1): ALSA: hda/realtek: Add more codec ID to no shutup pins list Kent Overstreet (1): closures: Change BUG_ON() to WARN_ON() Kenton Groombridge (1): wifi: mac80211: Avoid address calculations via out of bounds array indexing Krzysztof Kozlowski (1): drm/exynos: dp: drop driver owner initialization Li Ma (1): drm/amd/swsmu: add MALL init support workaround for smu_v14_0_1 Likun Gao (1): drm/amdgpu: init TA fw for psp v14 Linus Torvalds (1): cpumask: limit FORCE_NR_CPUS to just the UP case Louis Dalibard (1): HID: Ignore battery for ELAN touchscreens 2F2C and 4116 Luiz Augusto von Dentz (1): Bluetooth: L2CAP: Fix deadlock Luke D. Jones (1): Input: xpad - add support for ASUS ROG RAIKIRI PRO Marc Zyngier (1): of/irq: Disable "interrupt-map" parsing for PASEMI Nemo Mark-PK Tsai (1): tee: optee: ffa: Fix missing-field-initializers warning Martin Wilck (1): scsi: core: alua: I/O errors for ALUA state transitions Masahiro Yamada (2): kconfig: gconf: give a proper initial state to the Save button kconfig: remove wrong expr_trans_bool() Michael Ellerman (4): selftests: cachestat: Fix build warnings on ppc64 selftests/openat2: Fix build warnings on ppc64 selftests/overlayfs: Fix build error on ppc64 KVM: PPC: Book3S HV: Prevent UAF in kvm_spapr_tce_attach_iommu_group() Namjae Jeon (1): ksmbd: return FILE_DEVICE_DISK instead of super magic Nathan Chancellor (1): efi/libstub: zboot.lds: Discard .discard sections Neeraj Sanjay Kale (1): Bluetooth: btnxpuart: Enable Power Save feature on startup Nick Child (1): ibmvnic: Add tx check to prevent skb leak Nicolas Escande (1): wifi: mac80211: mesh: init nonpeer_pm to active by default in mesh sdata Patrice Chotard (1): spi: Fix OCTAL mode support Paul Hsieh (1): drm/amd/display: change dram_clock_latency to 34us for dcn35 Peter Ujfalusi (2): ASoC: SOF: sof-audio: Skip unprepare for in-use widgets on error rollback ASoC: SOF: Intel: hda-pcm: Limit the maximum number of periods by MAX_BDL_ENTRIES Pierre-Eric Pelloux-Prayer (1): drm/radeon: check bo_va->bo is non-NULL before using it Primoz Fiser (1): ASoC: ti: omap-hdmi: Fix too long driver name Puranjay Mohan (1): riscv: stacktrace: fix usage of ftrace_graph_ret_addr() Qu Wenruo (1): btrfs: scrub: handle RST lookup error correctly Ratheesh Kannoth (1): octeontx2-pf: Fix coverity and klockwork issues in octeon PF driver Richard Fitzgerald (1): ASoC: cs35l56: Disconnect ASP1 TX sources when ASP1 DAI is hooked up Ritesh Harjani (IBM) (1): iomap: Fix iomap_adjust_read_range for plen calculation Rob Herring (Arm) (1): of/irq: Factor out parsing of interrupt-map parent phandle+args from of_irq_parse_raw() Roman Li (1): drm/amd/display: Fix array-index-out-of-bounds in dml2/FCLKChangeSupport Sagi Grimberg (1): nfs: propagate readlink errors in nfs_symlink_filler Samuel Holland (1): drivers/perf: riscv: Reset the counter to hpmevent mapping while starting cpus Saurav Kashyap (3): scsi: qedf: Don't process stag work during unload and recovery scsi: qedf: Wait for stag work during unload scsi: qedf: Set qed_slowpath_params to zero before use Scott Mayhew (1): nfs: don't invalidate dentries on transient errors Shengjiu Wang (1): ALSA: dmaengine_pcm: terminate dmaengine before synchronize Simon Trimmer (2): ALSA: hda: cs35l56: Fix lifecycle of codec pointer ALSA: hda: cs35l56: Select SERIAL_MULTI_INSTANTIATE Stefan Binding (4): ALSA: hda: cs35l41: Support Lenovo Thinkbook 16P Gen 5 ALSA: hda: cs35l41: Support Lenovo Thinkbook 13x Gen 4 ALSA: hda/realtek: Support Lenovo Thinkbook 16P Gen 5 ALSA: hda/realtek: Support Lenovo Thinkbook 13x Gen 4 Steve French (1): cifs: fix noisy message on copy_file_range Suma Hegde (1): platform/x86/amd/hsmp: Check HSMP support on AMD family of processors Takashi Iwai (2): ALSA: PCM: Allow resume only for suspended streams ALSA: hda: Use imply for suggesting CONFIG_SERIAL_MULTI_INSTANTIATE Tasos Sahanidis (1): drm/amdgpu/pptable: Fix UBSAN array-index-out-of-bounds Tejun Heo (1): workqueue: Refactor worker ID formatting and make wq_worker_comm() use full ID string Tetsuo Handa (1): Bluetooth: hci_core: cancel all works upon hci_unregister_dev() Thomas GENTY (1): bytcr_rt5640 : inverse jack detect for Archos 101 cesium Thomas Weißschuh (1): ACPI: AC: Properly notify powermanagement core about changes Tobias Jakobi (2): drm: panel-orientation-quirks: Add quirk for Aya Neo KUN Input: i8042 - add Ayaneo Kun to i8042 quirk table Tom Chung (2): drm/amd/display: Add refresh rate range check drm/amd/display: Fix refresh rate range for some panel Uwe Kleine-König (2): parport: amiga: Mark driver struct with __refdata to prevent section mismatch spi: imx: Don't expect DMA for i.MX{25,35,50,51,53} cspi devices Vyacheslav Frantsishko (1): ASoC: amd: yc: Fix non-functional mic on ASUS M5602RA Wei Li (1): arm64: armv8_deprecated: Fix warning in isndep cpuhp starting process Xingui Yang (1): scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed Yang Shi (1): mm: page_ref: remove folio_try_get_rcu() Yedidya Benshimol (2): wifi: iwlwifi: mvm: d3: fix WoWLAN command version lookup wifi: iwlwifi: mvm: Handle BIGTK cipher in kek_kck cmd Yunshui Jiang (1): net: mac802154: Fix racy device stats updates by DEV_STATS_INC() and DEV_STATS_ADD() Yuntao Wang (1): fs/file: fix the check in find_next_fd() Zhang Yi (1): ASoC: codecs: ES8326: Solve headphone detection issue Zizhi Wo (1): cachefiles: Set object to close if ondemand_id < 0 in copen

1 year, 4 months

1
1
0 0

Linux 6.6.42

by Greg Kroah-Hartman

I'm announcing the release of the 6.6.42 kernel. All users of the 6.6 kernel series must upgrade. The updated 6.6.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-6.6.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Documentation/cdrom/cdrom-standard.rst | 4 Makefile | 2 arch/arm/include/asm/uaccess.h | 14 arch/arm64/kernel/armv8_deprecated.c | 3 arch/mips/kernel/syscalls/syscall_o32.tbl | 2 arch/powerpc/kernel/eeh_pe.c | 7 arch/powerpc/kvm/book3s_64_vio.c | 18 - arch/powerpc/platforms/pseries/setup.c | 4 arch/riscv/kernel/stacktrace.c | 3 drivers/acpi/ec.c | 9 drivers/block/null_blk/main.c | 4 drivers/bluetooth/btnxpuart.c | 2 drivers/firmware/efi/libstub/zboot.lds | 1 drivers/gpio/gpio-pca953x.c | 2 drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 15 - drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 52 +++ drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c | 3 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 drivers/gpu/drm/exynos/exynos_dp.c | 1 drivers/gpu/drm/mediatek/mtk_drm_drv.c | 8 drivers/gpu/drm/radeon/radeon_gem.c | 2 drivers/gpu/drm/vmwgfx/Kconfig | 2 drivers/hid/hid-debug.c | 2 drivers/hid/hid-ids.h | 2 drivers/hid/hid-input.c | 13 drivers/input/joystick/xpad.c | 1 drivers/input/mouse/elantech.c | 31 ++ drivers/input/serio/i8042-acpipnpio.h | 18 + drivers/input/touchscreen/ads7846.c | 12 drivers/input/touchscreen/silead.c | 19 - drivers/misc/mei/main.c | 2 drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c | 2 drivers/net/ethernet/ibm/ibmvnic.c | 12 drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 10 drivers/net/ethernet/marvell/octeontx2/nic/otx2_reg.h | 55 +-- drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c | 2 drivers/net/ethernet/marvell/octeontx2/nic/qos.c | 3 drivers/net/usb/qmi_wwan.c | 2 drivers/net/wireless/intel/iwlwifi/mvm/d3.c | 16 - drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 47 ++- drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c | 13 drivers/net/wireless/intel/iwlwifi/mvm/scan.c | 8 drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 12 drivers/net/wireless/intel/iwlwifi/mvm/sta.h | 5 drivers/nvme/host/core.c | 1 drivers/nvme/host/nvme.h | 2 drivers/nvme/target/core.c | 1 drivers/nvme/target/fabrics-cmd-auth.c | 3 drivers/nvme/target/fabrics-cmd.c | 6 drivers/of/irq.c | 143 +++++----- drivers/of/of_private.h | 3 drivers/perf/riscv_pmu_sbi.c | 2 drivers/platform/mellanox/nvsw-sn2201.c | 5 drivers/platform/x86/lg-laptop.c | 89 ++---- drivers/platform/x86/wireless-hotkey.c | 2 drivers/s390/char/sclp.c | 1 drivers/scsi/device_handler/scsi_dh_alua.c | 31 +- drivers/scsi/libsas/sas_internal.h | 14 drivers/scsi/qedf/qedf.h | 1 drivers/scsi/qedf/qedf_main.c | 47 +++ drivers/scsi/sr.h | 2 drivers/scsi/sr_ioctl.c | 5 drivers/spi/spi-imx.c | 2 drivers/spi/spi-mux.c | 1 drivers/spi/spi.c | 6 drivers/tee/optee/ffa_abi.c | 12 fs/afs/write.c | 2 fs/btrfs/qgroup.c | 4 fs/cachefiles/cache.c | 45 +++ fs/cachefiles/ondemand.c | 74 +++-- fs/cachefiles/volume.c | 1 fs/dcache.c | 31 -- fs/erofs/zmap.c | 2 fs/file.c | 4 fs/fscache/internal.h | 2 fs/fscache/volume.c | 14 fs/hfsplus/xattr.c | 2 fs/iomap/buffered-io.c | 3 fs/locks.c | 9 fs/nfs/dir.c | 27 - fs/nfs/nfs4proc.c | 1 fs/nfs/pagelist.c | 5 fs/nfs/symlink.c | 2 fs/smb/client/cifsfs.c | 2 fs/smb/client/file.c | 4 fs/smb/common/smb2pdu.h | 34 ++ fs/smb/server/smb2pdu.c | 9 include/linux/cdrom.h | 2 include/linux/fscache-cache.h | 6 include/linux/page_ref.h | 49 --- include/linux/spi/spi.h | 5 include/net/bluetooth/hci_sync.h | 2 include/sound/dmaengine_pcm.h | 1 include/trace/events/fscache.h | 4 include/uapi/linux/input-event-codes.h | 2 lib/Kconfig | 8 mm/filemap.c | 10 mm/gup.c | 2 net/bluetooth/hci_core.c | 76 +---- net/bluetooth/hci_sync.c | 13 net/bluetooth/l2cap_core.c | 3 net/bluetooth/l2cap_sock.c | 14 net/ipv6/ila/ila_lwt.c | 7 net/ipv6/rpl_iptunnel.c | 14 net/mac80211/cfg.c | 5 net/mac80211/ieee80211_i.h | 2 net/mac80211/main.c | 11 net/mac80211/mesh.c | 1 net/mac80211/scan.c | 14 net/mac80211/util.c | 4 net/mac802154/tx.c | 8 net/wireless/rdev-ops.h | 6 net/wireless/scan.c | 59 ++-- scripts/kconfig/expr.c | 29 -- scripts/kconfig/expr.h | 1 scripts/kconfig/gconf.c | 3 scripts/kconfig/menu.c | 2 sound/core/pcm_dmaengine.c | 22 + sound/core/pcm_native.c | 2 sound/pci/hda/Kconfig | 2 sound/pci/hda/cs35l56_hda.c | 5 sound/pci/hda/patch_realtek.c | 7 sound/soc/amd/yc/acp6x-mach.c | 7 sound/soc/codecs/rt722-sdca-sdw.c | 4 sound/soc/intel/boards/bytcr_rt5640.c | 11 sound/soc/soc-generic-dmaengine-pcm.c | 8 sound/soc/soc-topology.c | 29 +- sound/soc/sof/intel/hda-pcm.c | 6 sound/soc/sof/sof-audio.c | 2 sound/soc/ti/davinci-mcasp.c | 9 sound/soc/ti/omap-hdmi.c | 6 tools/power/cpupower/utils/helpers/amd.c | 26 + tools/testing/selftests/bpf/config | 3 tools/testing/selftests/bpf/prog_tests/tc_links.c | 61 ++++ tools/testing/selftests/cachestat/test_cachestat.c | 1 tools/testing/selftests/futex/functional/Makefile | 2 tools/testing/selftests/net/openvswitch/ovs-dpctl.py | 2 tools/testing/selftests/openat2/openat2_test.c | 1 tools/testing/selftests/timens/exec.c | 6 tools/testing/selftests/timens/timer.c | 2 tools/testing/selftests/timens/timerfd.c | 2 tools/testing/selftests/timens/vfork_exec.c | 4 tools/testing/selftests/vDSO/parse_vdso.c | 16 - tools/testing/selftests/vDSO/vdso_standalone_test_x86.c | 18 + 144 files changed, 1167 insertions(+), 567 deletions(-) Adrian Moreno (1): selftests: openvswitch: Set value to nla flags. Aivaz Latypov (1): ALSA: hda/relatek: Enable Mute LED on HP Laptop 15-gw0xxx Alexander Stein (1): Input: ads7846 - use spi_device_id table Alexander Usyskin (1): mei: demote client disconnect warning on suspend to debug Alexey Makhalov (1): drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency Alvin Lee (1): drm/amd/display: Account for cursor prefetch BW in DML1 mode support Amadeusz Sławiński (2): ASoC: topology: Fix references to freed memory ASoC: topology: Do not assign fields that are already set Andreas Hindborg (1): null_blk: fix validation of block size Anjali K (1): powerpc/pseries: Whitelist dtl slub object for copying to userspace Armin Wolf (6): ACPI: EC: Abort address space access upon error ACPI: EC: Avoid returning AE_OK on errors in address space handler platform/x86: wireless-hotkey: Add support for LG Airplane Button platform/x86: lg-laptop: Remove LGEX0815 hotkey handling platform/x86: lg-laptop: Change ACPI device id platform/x86: lg-laptop: Use ACPI device handle when evaluating WMAB/WMBB Arnd Bergmann (1): mips: fix compat_sys_lseek syscall Aseda Aboagye (2): input: Add event code for accessibility key input: Add support for "Do Not Disturb" Ayala Beker (1): wifi: iwlwifi: mvm: properly set 6 GHz channel direct probe option Baokun Li (5): cachefiles: add consistency check for copen/cread cachefiles: make on-demand read killable netfs, fscache: export fscache_put_volume() and add fscache_try_get_volume() cachefiles: fix slab-use-after-free in fscache_withdraw_volume() cachefiles: fix slab-use-after-free in cachefiles_withdraw_cookie() Benjamin Berg (1): wifi: iwlwifi: mvm: remove stale STA link data during restart Boyang Yu (1): nvme: fix NVME_NS_DEAC may incorrectly identifying the disk as EXT_LBA. Chen Ni (2): can: kvaser_usb: fix return value for hif_usb_send_regout platform/mellanox: nvsw-sn2201: Add check for platform_device_add_resources Christian Brauner (1): fs: better handle deep ancestor chains in is_subdir() Chunguang Xu (1): nvme: avoid double free special payload Daniel Borkmann (1): selftests/bpf: Extend tcx tests to cover late tcx_entry release Daniel Gabay (1): wifi: iwlwifi: properly set WIPHY_FLAG_SUPPORTS_EXT_KEK_KCK Daniel Wagner (1): nvmet: always initialize cqe.result Daniele Palmas (1): net: usb: qmi_wwan: add Telit FN912 compositions David Lechner (1): spi: mux: set ctlr->bits_per_word_mask Dhananjay Ugwekar (1): tools/power/cpupower: Fix Pstate frequency reporting on AMD Family 1Ah CPUs Dmitry Antipov (2): wifi: mac80211: fix UBSAN noise in ieee80211_prep_hw_scan() wifi: cfg80211: wext: add extra SIOCSIWSCAN data check Dmitry Mastykin (1): NFSv4: Fix memory leak in nfs4_set_security_label Douglas Anderson (1): drm/mediatek: Call drm_atomic_helper_shutdown() at shutdown time Edward Adam Davis (2): bluetooth/l2cap: sync sock recv cb and release hfsplus: fix uninit-value in copy_name Emmanuel Grumbach (1): wifi: iwlwifi: mvm: don't wake up rx_sync_waitq upon RFKILL Eric Dumazet (2): net: ipv6: rpl_iptunnel: block BH in rpl_output() and rpl_input() ila: block BH in ila_output() Filipe Manana (1): btrfs: qgroup: fix quota root leak after quota disable failure Ganesh Goudar (1): powerpc/eeh: avoid possible crash when edev->pdev changes Gao Xiang (1): erofs: ensure m_llen is reset to 0 if metadata is invalid Greg Kroah-Hartman (1): Linux 6.6.42 Hans de Goede (1): Input: silead - Always support 10 fingers Harish Kasiviswanathan (1): drm/amdgpu: Indicate CU havest info to CP Heiko Carstens (1): s390/sclp: Fix sclp_init() cleanup on failure Ian Ray (1): gpio: pca953x: fix pca953x_irq_bus_sync_unlock race Ilan Peer (1): wifi: iwlwifi: mvm: Fix scan abort handling with HW rfkill Jack Yu (2): ASoC: rt722-sdca-sdw: add silence detection register as volatile ASoC: rt722-sdca-sdw: add debounce time for type detection Jai Luthra (2): ALSA: dmaengine: Synchronize dma channel after drop() ASoC: ti: davinci-mcasp: Set min period size using FIFO config Jan Kara (1): nfs: Avoid flushing many pages with NFS_FILE_SYNC Jann Horn (1): filelock: Remove locks reliably when fcntl/close race is detected Johannes Berg (6): wifi: mac80211: apply mcast rate only if interface is up wifi: mac80211: handle tasklet frames before stopping wifi: cfg80211: fix 6 GHz scan request building wifi: iwlwifi: mvm: handle BA session teardown in RF-kill wifi: cfg80211: wext: set ssids=NULL for passive scans wifi: mac80211: disable softirqs for queued frame handling John Hubbard (3): selftests/futex: pass _GNU_SOURCE without a value to the compiler selftest/timerns: fix clang build failures for abs() calls selftests/vDSO: fix clang build errors and warnings Jonathan Denose (1): Input: elantech - fix touchpad state on resume for Lenovo N24 Justin Stitt (1): scsi: sr: Fix unintentional arithmetic wraparound Kailang Yang (1): ALSA: hda/realtek: Add more codec ID to no shutup pins list Krzysztof Kozlowski (1): drm/exynos: dp: drop driver owner initialization Linus Torvalds (1): cpumask: limit FORCE_NR_CPUS to just the UP case Louis Dalibard (1): HID: Ignore battery for ELAN touchscreens 2F2C and 4116 Luiz Augusto von Dentz (1): Bluetooth: L2CAP: Fix deadlock Luke D. Jones (1): Input: xpad - add support for ASUS ROG RAIKIRI PRO Marc Zyngier (1): of/irq: Disable "interrupt-map" parsing for PASEMI Nemo Mark-PK Tsai (1): tee: optee: ffa: Fix missing-field-initializers warning Martin Wilck (1): scsi: core: alua: I/O errors for ALUA state transitions Masahiro Yamada (3): kconfig: gconf: give a proper initial state to the Save button kconfig: remove wrong expr_trans_bool() ARM: 9324/1: fix get_user() broken with veneer Michael Ellerman (3): selftests: cachestat: Fix build warnings on ppc64 selftests/openat2: Fix build warnings on ppc64 KVM: PPC: Book3S HV: Prevent UAF in kvm_spapr_tce_attach_iommu_group() Namjae Jeon (1): ksmbd: return FILE_DEVICE_DISK instead of super magic Nathan Chancellor (1): efi/libstub: zboot.lds: Discard .discard sections Neeraj Sanjay Kale (1): Bluetooth: btnxpuart: Enable Power Save feature on startup Nick Child (1): ibmvnic: Add tx check to prevent skb leak Nicolas Escande (1): wifi: mac80211: mesh: init nonpeer_pm to active by default in mesh sdata Patrice Chotard (1): spi: Fix OCTAL mode support Peter Ujfalusi (2): ASoC: SOF: sof-audio: Skip unprepare for in-use widgets on error rollback ASoC: SOF: Intel: hda-pcm: Limit the maximum number of periods by MAX_BDL_ENTRIES Pierre-Eric Pelloux-Prayer (1): drm/radeon: check bo_va->bo is non-NULL before using it Primoz Fiser (1): ASoC: ti: omap-hdmi: Fix too long driver name Puranjay Mohan (1): riscv: stacktrace: fix usage of ftrace_graph_ret_addr() Ratheesh Kannoth (1): octeontx2-pf: Fix coverity and klockwork issues in octeon PF driver Ritesh Harjani (IBM) (1): iomap: Fix iomap_adjust_read_range for plen calculation Rob Herring (Arm) (1): of/irq: Factor out parsing of interrupt-map parent phandle+args from of_irq_parse_raw() Sagi Grimberg (1): nfs: propagate readlink errors in nfs_symlink_filler Samuel Holland (1): drivers/perf: riscv: Reset the counter to hpmevent mapping while starting cpus Saurav Kashyap (3): scsi: qedf: Don't process stag work during unload and recovery scsi: qedf: Wait for stag work during unload scsi: qedf: Set qed_slowpath_params to zero before use Scott Mayhew (1): nfs: don't invalidate dentries on transient errors Shengjiu Wang (1): ALSA: dmaengine_pcm: terminate dmaengine before synchronize Simon Trimmer (2): ALSA: hda: cs35l56: Fix lifecycle of codec pointer ALSA: hda: cs35l56: Select SERIAL_MULTI_INSTANTIATE Stefan Binding (1): ALSA: hda/realtek: Support Lenovo Thinkbook 16P Gen 5 Steve French (1): cifs: fix noisy message on copy_file_range Takashi Iwai (2): ALSA: PCM: Allow resume only for suspended streams ALSA: hda: Use imply for suggesting CONFIG_SERIAL_MULTI_INSTANTIATE Tetsuo Handa (1): Bluetooth: hci_core: cancel all works upon hci_unregister_dev() Thomas GENTY (1): bytcr_rt5640 : inverse jack detect for Archos 101 cesium Tobias Jakobi (2): drm: panel-orientation-quirks: Add quirk for Aya Neo KUN Input: i8042 - add Ayaneo Kun to i8042 quirk table Tom Chung (2): drm/amd/display: Add refresh rate range check drm/amd/display: Fix refresh rate range for some panel Uwe Kleine-König (1): spi: imx: Don't expect DMA for i.MX{25,35,50,51,53} cspi devices Vyacheslav Frantsishko (1): ASoC: amd: yc: Fix non-functional mic on ASUS M5602RA Wei Li (1): arm64: armv8_deprecated: Fix warning in isndep cpuhp starting process Xingui Yang (1): scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed Yang Shi (1): mm: page_ref: remove folio_try_get_rcu() Yedidya Benshimol (2): wifi: iwlwifi: mvm: d3: fix WoWLAN command version lookup wifi: iwlwifi: mvm: Handle BIGTK cipher in kek_kck cmd Yunshui Jiang (1): net: mac802154: Fix racy device stats updates by DEV_STATS_INC() and DEV_STATS_ADD() Yuntao Wang (1): fs/file: fix the check in find_next_fd() Zizhi Wo (1): cachefiles: Set object to close if ondemand_id < 0 in copen

1 year, 4 months

1
1
0 0

Linux 6.1.101

by Greg Kroah-Hartman

I'm announcing the release of the 6.1.101 kernel. All users of the 6.1 kernel series must upgrade. The updated 6.1.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-6.1.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Makefile | 2 arch/arm/include/asm/uaccess.h | 14 arch/mips/kernel/syscalls/syscall_o32.tbl | 2 arch/powerpc/kernel/eeh_pe.c | 7 arch/powerpc/kvm/book3s_64_vio.c | 18 - arch/powerpc/platforms/pseries/setup.c | 4 arch/riscv/kernel/stacktrace.c | 3 drivers/acpi/ec.c | 9 drivers/block/null_blk/main.c | 4 drivers/firmware/efi/libstub/zboot.lds | 1 drivers/gpio/gpio-pca953x.c | 2 drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c | 3 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 drivers/gpu/drm/radeon/radeon_gem.c | 2 drivers/gpu/drm/vmwgfx/Kconfig | 2 drivers/hid/hid-ids.h | 2 drivers/hid/hid-input.c | 4 drivers/input/mouse/elantech.c | 31 ++ drivers/input/serio/i8042-acpipnpio.h | 18 + drivers/input/touchscreen/silead.c | 19 - drivers/misc/mei/main.c | 2 drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c | 2 drivers/net/ethernet/ibm/ibmvnic.c | 12 drivers/net/usb/qmi_wwan.c | 2 drivers/net/wireless/intel/iwlwifi/mvm/d3.c | 16 - drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 2 drivers/net/wireless/intel/iwlwifi/mvm/scan.c | 8 drivers/nvme/host/core.c | 1 drivers/nvme/target/core.c | 1 drivers/nvme/target/fabrics-cmd-auth.c | 3 drivers/nvme/target/fabrics-cmd.c | 6 drivers/of/irq.c | 143 +++++----- drivers/of/of_private.h | 3 drivers/perf/riscv_pmu_sbi.c | 2 drivers/platform/mellanox/nvsw-sn2201.c | 5 drivers/platform/x86/lg-laptop.c | 89 ++---- drivers/platform/x86/wireless-hotkey.c | 2 drivers/s390/char/sclp.c | 1 drivers/scsi/device_handler/scsi_dh_alua.c | 31 +- drivers/scsi/libsas/sas_internal.h | 14 drivers/scsi/qedf/qedf.h | 1 drivers/scsi/qedf/qedf_main.c | 47 +++ drivers/spi/spi-imx.c | 2 drivers/spi/spi-mux.c | 1 drivers/tee/optee/ffa_abi.c | 12 fs/btrfs/qgroup.c | 4 fs/cachefiles/cache.c | 45 +++ fs/cachefiles/ondemand.c | 74 +++-- fs/cachefiles/volume.c | 1 fs/dcache.c | 31 -- fs/erofs/zmap.c | 2 fs/file.c | 4 fs/fscache/internal.h | 2 fs/fscache/volume.c | 14 fs/hfsplus/xattr.c | 2 fs/iomap/buffered-io.c | 3 fs/locks.c | 9 fs/nfs/dir.c | 27 - fs/nfs/nfs4proc.c | 1 fs/nfs/symlink.c | 2 fs/smb/client/cifsfs.c | 2 fs/smb/common/smb2pdu.h | 34 ++ fs/smb/server/smb2pdu.c | 9 include/linux/fscache-cache.h | 6 include/linux/minmax.h | 89 ++++-- include/net/bluetooth/hci_sync.h | 2 include/sound/dmaengine_pcm.h | 1 include/trace/events/fscache.h | 4 mm/damon/core.c | 21 + net/bluetooth/hci_core.c | 76 +---- net/bluetooth/hci_sync.c | 13 net/bluetooth/l2cap_core.c | 3 net/bluetooth/l2cap_sock.c | 14 net/ipv6/ila/ila_lwt.c | 7 net/ipv6/rpl_iptunnel.c | 14 net/mac80211/cfg.c | 5 net/mac80211/ieee80211_i.h | 2 net/mac80211/main.c | 11 net/mac80211/mesh.c | 1 net/mac80211/scan.c | 14 net/mac80211/util.c | 4 net/mac802154/tx.c | 8 net/wireless/rdev-ops.h | 6 net/wireless/scan.c | 59 ++-- scripts/gcc-plugins/gcc-common.h | 4 scripts/kconfig/expr.c | 29 -- scripts/kconfig/expr.h | 1 scripts/kconfig/gconf.c | 3 scripts/kconfig/menu.c | 2 sound/core/pcm_dmaengine.c | 22 + sound/core/pcm_native.c | 2 sound/pci/hda/patch_realtek.c | 5 sound/soc/amd/yc/acp6x-mach.c | 7 sound/soc/intel/boards/bytcr_rt5640.c | 11 sound/soc/soc-generic-dmaengine-pcm.c | 8 sound/soc/soc-topology.c | 29 +- sound/soc/sof/sof-audio.c | 2 sound/soc/ti/davinci-mcasp.c | 9 sound/soc/ti/omap-hdmi.c | 6 tools/power/cpupower/utils/helpers/amd.c | 26 + tools/testing/selftests/futex/functional/Makefile | 2 tools/testing/selftests/openat2/openat2_test.c | 1 tools/testing/selftests/vDSO/parse_vdso.c | 16 - tools/testing/selftests/vDSO/vdso_standalone_test_x86.c | 18 + 104 files changed, 934 insertions(+), 456 deletions(-) Aivaz Latypov (1): ALSA: hda/relatek: Enable Mute LED on HP Laptop 15-gw0xxx Alexander Usyskin (1): mei: demote client disconnect warning on suspend to debug Alexey Makhalov (1): drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency Alvin Lee (1): drm/amd/display: Account for cursor prefetch BW in DML1 mode support Amadeusz Sławiński (2): ASoC: topology: Fix references to freed memory ASoC: topology: Do not assign fields that are already set Andreas Hindborg (1): null_blk: fix validation of block size Andy Shevchenko (1): minmax: fix header inclusions Anjali K (1): powerpc/pseries: Whitelist dtl slub object for copying to userspace Armin Wolf (6): ACPI: EC: Abort address space access upon error ACPI: EC: Avoid returning AE_OK on errors in address space handler platform/x86: wireless-hotkey: Add support for LG Airplane Button platform/x86: lg-laptop: Remove LGEX0815 hotkey handling platform/x86: lg-laptop: Change ACPI device id platform/x86: lg-laptop: Use ACPI device handle when evaluating WMAB/WMBB Arnd Bergmann (1): mips: fix compat_sys_lseek syscall Ayala Beker (1): wifi: iwlwifi: mvm: properly set 6 GHz channel direct probe option Baokun Li (5): cachefiles: add consistency check for copen/cread cachefiles: make on-demand read killable netfs, fscache: export fscache_put_volume() and add fscache_try_get_volume() cachefiles: fix slab-use-after-free in fscache_withdraw_volume() cachefiles: fix slab-use-after-free in cachefiles_withdraw_cookie() Chen Ni (2): can: kvaser_usb: fix return value for hif_usb_send_regout platform/mellanox: nvsw-sn2201: Add check for platform_device_add_resources Christian Brauner (1): fs: better handle deep ancestor chains in is_subdir() Chunguang Xu (1): nvme: avoid double free special payload Daniel Gabay (1): wifi: iwlwifi: properly set WIPHY_FLAG_SUPPORTS_EXT_KEK_KCK Daniel Wagner (1): nvmet: always initialize cqe.result Daniele Palmas (1): net: usb: qmi_wwan: add Telit FN912 compositions David Laight (3): minmax: allow min()/max()/clamp() if the arguments have the same signedness. minmax: allow comparisons of 'int' against 'unsigned char/short' minmax: relax check to allow comparison between unsigned arguments and signed constants David Lechner (1): spi: mux: set ctlr->bits_per_word_mask Dhananjay Ugwekar (1): tools/power/cpupower: Fix Pstate frequency reporting on AMD Family 1Ah CPUs Dmitry Antipov (2): wifi: mac80211: fix UBSAN noise in ieee80211_prep_hw_scan() wifi: cfg80211: wext: add extra SIOCSIWSCAN data check Dmitry Mastykin (1): NFSv4: Fix memory leak in nfs4_set_security_label Edward Adam Davis (2): bluetooth/l2cap: sync sock recv cb and release hfsplus: fix uninit-value in copy_name Eric Dumazet (2): net: ipv6: rpl_iptunnel: block BH in rpl_output() and rpl_input() ila: block BH in ila_output() Filipe Manana (1): btrfs: qgroup: fix quota root leak after quota disable failure Ganesh Goudar (1): powerpc/eeh: avoid possible crash when edev->pdev changes Gao Xiang (1): erofs: ensure m_llen is reset to 0 if metadata is invalid Greg Kroah-Hartman (1): Linux 6.1.101 Hans de Goede (1): Input: silead - Always support 10 fingers Heiko Carstens (1): s390/sclp: Fix sclp_init() cleanup on failure Ian Ray (1): gpio: pca953x: fix pca953x_irq_bus_sync_unlock race Ilan Peer (1): wifi: iwlwifi: mvm: Fix scan abort handling with HW rfkill Jai Luthra (2): ALSA: dmaengine: Synchronize dma channel after drop() ASoC: ti: davinci-mcasp: Set min period size using FIFO config Jann Horn (1): filelock: Remove locks reliably when fcntl/close race is detected Jason A. Donenfeld (2): minmax: sanity check constant bounds when clamping minmax: clamp more efficiently by avoiding extra comparison Johannes Berg (5): wifi: mac80211: apply mcast rate only if interface is up wifi: mac80211: handle tasklet frames before stopping wifi: cfg80211: fix 6 GHz scan request building wifi: cfg80211: wext: set ssids=NULL for passive scans wifi: mac80211: disable softirqs for queued frame handling John Hubbard (2): selftests/futex: pass _GNU_SOURCE without a value to the compiler selftests/vDSO: fix clang build errors and warnings Jonathan Denose (1): Input: elantech - fix touchpad state on resume for Lenovo N24 Kailang Yang (1): ALSA: hda/realtek: Add more codec ID to no shutup pins list Kees Cook (1): gcc-plugins: Rename last_stmt() for GCC 14+ Louis Dalibard (1): HID: Ignore battery for ELAN touchscreens 2F2C and 4116 Luiz Augusto von Dentz (1): Bluetooth: L2CAP: Fix deadlock Marc Zyngier (1): of/irq: Disable "interrupt-map" parsing for PASEMI Nemo Mark-PK Tsai (1): tee: optee: ffa: Fix missing-field-initializers warning Martin Wilck (1): scsi: core: alua: I/O errors for ALUA state transitions Masahiro Yamada (3): kconfig: gconf: give a proper initial state to the Save button kconfig: remove wrong expr_trans_bool() ARM: 9324/1: fix get_user() broken with veneer Michael Ellerman (2): selftests/openat2: Fix build warnings on ppc64 KVM: PPC: Book3S HV: Prevent UAF in kvm_spapr_tce_attach_iommu_group() Namjae Jeon (1): ksmbd: return FILE_DEVICE_DISK instead of super magic Nathan Chancellor (1): efi/libstub: zboot.lds: Discard .discard sections Nick Child (1): ibmvnic: Add tx check to prevent skb leak Nicolas Escande (1): wifi: mac80211: mesh: init nonpeer_pm to active by default in mesh sdata Peter Ujfalusi (1): ASoC: SOF: sof-audio: Skip unprepare for in-use widgets on error rollback Pierre-Eric Pelloux-Prayer (1): drm/radeon: check bo_va->bo is non-NULL before using it Primoz Fiser (1): ASoC: ti: omap-hdmi: Fix too long driver name Puranjay Mohan (1): riscv: stacktrace: fix usage of ftrace_graph_ret_addr() Ritesh Harjani (IBM) (1): iomap: Fix iomap_adjust_read_range for plen calculation Rob Herring (Arm) (1): of/irq: Factor out parsing of interrupt-map parent phandle+args from of_irq_parse_raw() Sagi Grimberg (1): nfs: propagate readlink errors in nfs_symlink_filler Samuel Holland (1): drivers/perf: riscv: Reset the counter to hpmevent mapping while starting cpus Saurav Kashyap (3): scsi: qedf: Don't process stag work during unload and recovery scsi: qedf: Wait for stag work during unload scsi: qedf: Set qed_slowpath_params to zero before use Scott Mayhew (1): nfs: don't invalidate dentries on transient errors SeongJae Park (1): mm/damon/core: merge regions aggressively when max_nr_regions is unmet Shengjiu Wang (1): ALSA: dmaengine_pcm: terminate dmaengine before synchronize Steve French (1): cifs: fix noisy message on copy_file_range Takashi Iwai (1): ALSA: PCM: Allow resume only for suspended streams Tetsuo Handa (1): Bluetooth: hci_core: cancel all works upon hci_unregister_dev() Thomas GENTY (1): bytcr_rt5640 : inverse jack detect for Archos 101 cesium Tobias Jakobi (2): drm: panel-orientation-quirks: Add quirk for Aya Neo KUN Input: i8042 - add Ayaneo Kun to i8042 quirk table Uwe Kleine-König (1): spi: imx: Don't expect DMA for i.MX{25,35,50,51,53} cspi devices Vyacheslav Frantsishko (1): ASoC: amd: yc: Fix non-functional mic on ASUS M5602RA Xingui Yang (1): scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed Yedidya Benshimol (2): wifi: iwlwifi: mvm: d3: fix WoWLAN command version lookup wifi: iwlwifi: mvm: Handle BIGTK cipher in kek_kck cmd Yunshui Jiang (1): net: mac802154: Fix racy device stats updates by DEV_STATS_INC() and DEV_STATS_ADD() Yuntao Wang (1): fs/file: fix the check in find_next_fd() Zizhi Wo (1): cachefiles: Set object to close if ondemand_id < 0 in copen

1 year, 4 months

1
1
0 0

+ nilfs2-handle-inconsistent-state-in-nilfs_btnode_create_block.patch added to mm-hotfixes-unstable branch

by Andrew Morton

The patch titled Subject: nilfs2: handle inconsistent state in nilfs_btnode_create_block() has been added to the -mm mm-hotfixes-unstable branch. Its filename is nilfs2-handle-inconsistent-state-in-nilfs_btnode_create_block.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patche… This patch will later appear in the mm-hotfixes-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Ryusuke Konishi <konishi.ryusuke(a)gmail.com> Subject: nilfs2: handle inconsistent state in nilfs_btnode_create_block() Date: Thu, 25 Jul 2024 14:20:07 +0900 Syzbot reported that a buffer state inconsistency was detected in nilfs_btnode_create_block(), triggering a kernel bug. It is not appropriate to treat this inconsistency as a bug; it can occur if the argument block address (the buffer index of the newly created block) is a virtual block number and has been reallocated due to corruption of the bitmap used to manage its allocation state. So, modify nilfs_btnode_create_block() and its callers to treat it as a possible filesystem error, rather than triggering a kernel bug. Link: https://lkml.kernel.org/r/20240725052007.4562-1-konishi.ryusuke@gmail.com Fixes: a60be987d45d ("nilfs2: B-tree node cache") Signed-off-by: Ryusuke Konishi <konishi.ryusuke(a)gmail.com> Reported-by: syzbot+89cc4f2324ed37988b60(a)syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=89cc4f2324ed37988b60 Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- fs/nilfs2/btnode.c | 25 ++++++++++++++++++++----- fs/nilfs2/btree.c | 4 ++-- 2 files changed, 22 insertions(+), 7 deletions(-) --- a/fs/nilfs2/btnode.c~nilfs2-handle-inconsistent-state-in-nilfs_btnode_create_block +++ a/fs/nilfs2/btnode.c @@ -51,12 +51,21 @@ nilfs_btnode_create_block(struct address bh = nilfs_grab_buffer(inode, btnc, blocknr, BIT(BH_NILFS_Node)); if (unlikely(!bh)) - return NULL; + return ERR_PTR(-ENOMEM); if (unlikely(buffer_mapped(bh) || buffer_uptodate(bh) || buffer_dirty(bh))) { - brelse(bh); - BUG(); + /* + * The block buffer at the specified new address was already + * in use. This can happen if it is a virtual block number + * and has been reallocated due to corruption of the bitmap + * used to manage its allocation state (if not, the buffer + * clearing of an abandoned b-tree node is missing somewhere). + */ + nilfs_error(inode->i_sb, + "state inconsistency probably due to duplicate use of b-tree node block address %llu (ino=%lu)", + (unsigned long long)blocknr, inode->i_ino); + goto failed; } memset(bh->b_data, 0, i_blocksize(inode)); bh->b_bdev = inode->i_sb->s_bdev; @@ -67,6 +76,12 @@ nilfs_btnode_create_block(struct address folio_unlock(bh->b_folio); folio_put(bh->b_folio); return bh; + +failed: + folio_unlock(bh->b_folio); + folio_put(bh->b_folio); + brelse(bh); + return ERR_PTR(-EIO); } int nilfs_btnode_submit_block(struct address_space *btnc, __u64 blocknr, @@ -217,8 +232,8 @@ retry: } nbh = nilfs_btnode_create_block(btnc, newkey); - if (!nbh) - return -ENOMEM; + if (IS_ERR(nbh)) + return PTR_ERR(nbh); BUG_ON(nbh == obh); ctxt->newbh = nbh; --- a/fs/nilfs2/btree.c~nilfs2-handle-inconsistent-state-in-nilfs_btnode_create_block +++ a/fs/nilfs2/btree.c @@ -63,8 +63,8 @@ static int nilfs_btree_get_new_block(con struct buffer_head *bh; bh = nilfs_btnode_create_block(btnc, ptr); - if (!bh) - return -ENOMEM; + if (IS_ERR(bh)) + return PTR_ERR(bh); set_buffer_nilfs_volatile(bh); *bhp = bh; _ Patches currently in -mm which might be from konishi.ryusuke(a)gmail.com are nilfs2-handle-inconsistent-state-in-nilfs_btnode_create_block.patch

1 year, 4 months

1
0
0 0

[PATCH 6.1 000/105] 6.1.101-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.1.101 release. There are 105 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Thu, 25 Jul 2024 18:03:27 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.101-rc… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 6.1.101-rc1 Baokun Li <libaokun1(a)huawei.com> cachefiles: fix slab-use-after-free in cachefiles_withdraw_cookie() Baokun Li <libaokun1(a)huawei.com> cachefiles: fix slab-use-after-free in fscache_withdraw_volume() Baokun Li <libaokun1(a)huawei.com> netfs, fscache: export fscache_put_volume() and add fscache_try_get_volume() Johannes Berg <johannes.berg(a)intel.com> wifi: mac80211: disable softirqs for queued frame handling Johannes Berg <johannes.berg(a)intel.com> wifi: cfg80211: wext: set ssids=NULL for passive scans Marc Zyngier <maz(a)kernel.org> of/irq: Disable "interrupt-map" parsing for PASEMI Nemo Luiz Augusto von Dentz <luiz.von.dentz(a)intel.com> Bluetooth: L2CAP: Fix deadlock Masahiro Yamada <masahiroy(a)kernel.org> ARM: 9324/1: fix get_user() broken with veneer Steve French <stfrench(a)microsoft.com> cifs: fix noisy message on copy_file_range David Lechner <dlechner(a)baylibre.com> spi: mux: set ctlr->bits_per_word_mask Edward Adam Davis <eadavis(a)qq.com> hfsplus: fix uninit-value in copy_name John Hubbard <jhubbard(a)nvidia.com> selftests/vDSO: fix clang build errors and warnings Namjae Jeon <linkinjeon(a)kernel.org> ksmbd: return FILE_DEVICE_DISK instead of super magic Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> spi: imx: Don't expect DMA for i.MX{25,35,50,51,53} cspi devices Puranjay Mohan <puranjay(a)kernel.org> riscv: stacktrace: fix usage of ftrace_graph_ret_addr() Samuel Holland <samuel.holland(a)sifive.com> drivers/perf: riscv: Reset the counter to hpmevent mapping while starting cpus Daniel Gabay <daniel.gabay(a)intel.com> wifi: iwlwifi: properly set WIPHY_FLAG_SUPPORTS_EXT_KEK_KCK Christian Brauner <brauner(a)kernel.org> fs: better handle deep ancestor chains in is_subdir() Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer(a)amd.com> drm/radeon: check bo_va->bo is non-NULL before using it Alvin Lee <alvin.lee2(a)amd.com> drm/amd/display: Account for cursor prefetch BW in DML1 mode support Gao Xiang <xiang(a)kernel.org> erofs: ensure m_llen is reset to 0 if metadata is invalid Edward Adam Davis <eadavis(a)qq.com> bluetooth/l2cap: sync sock recv cb and release Tetsuo Handa <penguin-kernel(a)I-love.SAKURA.ne.jp> Bluetooth: hci_core: cancel all works upon hci_unregister_dev() Mark-PK Tsai <mark-pk.tsai(a)mediatek.com> tee: optee: ffa: Fix missing-field-initializers warning Xingui Yang <yangxingui(a)huawei.com> scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed Ganesh Goudar <ganeshgr(a)linux.ibm.com> powerpc/eeh: avoid possible crash when edev->pdev changes Anjali K <anjalik(a)linux.ibm.com> powerpc/pseries: Whitelist dtl slub object for copying to userspace Yunshui Jiang <jiangyunshui(a)kylinos.cn> net: mac802154: Fix racy device stats updates by DEV_STATS_INC() and DEV_STATS_ADD() Daniele Palmas <dnlplm(a)gmail.com> net: usb: qmi_wwan: add Telit FN912 compositions Vyacheslav Frantsishko <itmymaill(a)gmail.com> ASoC: amd: yc: Fix non-functional mic on ASUS M5602RA Shengjiu Wang <shengjiu.wang(a)nxp.com> ALSA: dmaengine_pcm: terminate dmaengine before synchronize Aivaz Latypov <reichaivaz(a)gmail.com> ALSA: hda/relatek: Enable Mute LED on HP Laptop 15-gw0xxx Takashi Iwai <tiwai(a)suse.de> ALSA: PCM: Allow resume only for suspended streams Nick Child <nnac123(a)linux.ibm.com> ibmvnic: Add tx check to prevent skb leak Filipe Manana <fdmanana(a)suse.com> btrfs: qgroup: fix quota root leak after quota disable failure Armin Wolf <W_Armin(a)gmx.de> platform/x86: lg-laptop: Use ACPI device handle when evaluating WMAB/WMBB Armin Wolf <W_Armin(a)gmx.de> platform/x86: lg-laptop: Change ACPI device id Armin Wolf <W_Armin(a)gmx.de> platform/x86: lg-laptop: Remove LGEX0815 hotkey handling Armin Wolf <W_Armin(a)gmx.de> platform/x86: wireless-hotkey: Add support for LG Airplane Button Chen Ni <nichen(a)iscas.ac.cn> platform/mellanox: nvsw-sn2201: Add check for platform_device_add_resources Heiko Carstens <hca(a)linux.ibm.com> s390/sclp: Fix sclp_init() cleanup on failure Ian Ray <ian.ray(a)gehealthcare.com> gpio: pca953x: fix pca953x_irq_bus_sync_unlock race Chen Ni <nichen(a)iscas.ac.cn> can: kvaser_usb: fix return value for hif_usb_send_regout Peter Ujfalusi <peter.ujfalusi(a)linux.intel.com> ASoC: SOF: sof-audio: Skip unprepare for in-use widgets on error rollback Primoz Fiser <primoz.fiser(a)norik.com> ASoC: ti: omap-hdmi: Fix too long driver name Jai Luthra <j-luthra(a)ti.com> ASoC: ti: davinci-mcasp: Set min period size using FIFO config Jai Luthra <j-luthra(a)ti.com> ALSA: dmaengine: Synchronize dma channel after drop() Thomas GENTY <tomlohave(a)gmail.com> bytcr_rt5640 : inverse jack detect for Archos 101 cesium Amadeusz Sławiński <amadeuszx.slawinski(a)linux.intel.com> ASoC: topology: Do not assign fields that are already set Amadeusz Sławiński <amadeuszx.slawinski(a)linux.intel.com> ASoC: topology: Fix references to freed memory Tobias Jakobi <tjakobi(a)math.uni-bielefeld.de> Input: i8042 - add Ayaneo Kun to i8042 quirk table Jonathan Denose <jdenose(a)google.com> Input: elantech - fix touchpad state on resume for Lenovo N24 Arnd Bergmann <arnd(a)arndb.de> mips: fix compat_sys_lseek syscall Kailang Yang <kailang(a)realtek.com> ALSA: hda/realtek: Add more codec ID to no shutup pins list Alexey Makhalov <alexey.makhalov(a)broadcom.com> drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency Michael Ellerman <mpe(a)ellerman.id.au> KVM: PPC: Book3S HV: Prevent UAF in kvm_spapr_tce_attach_iommu_group() Dmitry Antipov <dmantipov(a)yandex.ru> wifi: cfg80211: wext: add extra SIOCSIWSCAN data check Daniel Wagner <dwagner(a)suse.de> nvmet: always initialize cqe.result Chunguang Xu <chunguang.xu(a)shopee.com> nvme: avoid double free special payload Tobias Jakobi <tjakobi(a)math.uni-bielefeld.de> drm: panel-orientation-quirks: Add quirk for Aya Neo KUN Ritesh Harjani (IBM) <ritesh.list(a)gmail.com> iomap: Fix iomap_adjust_read_range for plen calculation Alexander Usyskin <alexander.usyskin(a)intel.com> mei: demote client disconnect warning on suspend to debug Yuntao Wang <yuntao.wang(a)linux.dev> fs/file: fix the check in find_next_fd() Baokun Li <libaokun1(a)huawei.com> cachefiles: make on-demand read killable Zizhi Wo <wozizhi(a)huawei.com> cachefiles: Set object to close if ondemand_id < 0 in copen Baokun Li <libaokun1(a)huawei.com> cachefiles: add consistency check for copen/cread Scott Mayhew <smayhew(a)redhat.com> nfs: don't invalidate dentries on transient errors Sagi Grimberg <sagi(a)grimberg.me> nfs: propagate readlink errors in nfs_symlink_filler Dmitry Mastykin <mastichi(a)gmail.com> NFSv4: Fix memory leak in nfs4_set_security_label Louis Dalibard <ontake(a)ontake.dev> HID: Ignore battery for ELAN touchscreens 2F2C and 4116 Masahiro Yamada <masahiroy(a)kernel.org> kconfig: remove wrong expr_trans_bool() Masahiro Yamada <masahiroy(a)kernel.org> kconfig: gconf: give a proper initial state to the Save button Andreas Hindborg <a.hindborg(a)samsung.com> null_blk: fix validation of block size Eric Dumazet <edumazet(a)google.com> ila: block BH in ila_output() Eric Dumazet <edumazet(a)google.com> net: ipv6: rpl_iptunnel: block BH in rpl_output() and rpl_input() Hans de Goede <hdegoede(a)redhat.com> Input: silead - Always support 10 fingers Rob Herring (Arm) <robh(a)kernel.org> of/irq: Factor out parsing of interrupt-map parent phandle+args from of_irq_parse_raw() John Hubbard <jhubbard(a)nvidia.com> selftests/futex: pass _GNU_SOURCE without a value to the compiler Michael Ellerman <mpe(a)ellerman.id.au> selftests/openat2: Fix build warnings on ppc64 Dmitry Antipov <dmantipov(a)yandex.ru> wifi: mac80211: fix UBSAN noise in ieee80211_prep_hw_scan() Ilan Peer <ilan.peer(a)intel.com> wifi: iwlwifi: mvm: Fix scan abort handling with HW rfkill Ayala Beker <ayala.beker(a)intel.com> wifi: iwlwifi: mvm: properly set 6 GHz channel direct probe option Yedidya Benshimol <yedidya.ben.shimol(a)intel.com> wifi: iwlwifi: mvm: Handle BIGTK cipher in kek_kck cmd Yedidya Benshimol <yedidya.ben.shimol(a)intel.com> wifi: iwlwifi: mvm: d3: fix WoWLAN command version lookup Johannes Berg <johannes.berg(a)intel.com> wifi: cfg80211: fix 6 GHz scan request building Johannes Berg <johannes.berg(a)intel.com> wifi: mac80211: handle tasklet frames before stopping Johannes Berg <johannes.berg(a)intel.com> wifi: mac80211: apply mcast rate only if interface is up Nicolas Escande <nico.escande(a)gmail.com> wifi: mac80211: mesh: init nonpeer_pm to active by default in mesh sdata Dhananjay Ugwekar <Dhananjay.Ugwekar(a)amd.com> tools/power/cpupower: Fix Pstate frequency reporting on AMD Family 1Ah CPUs Armin Wolf <W_Armin(a)gmx.de> ACPI: EC: Avoid returning AE_OK on errors in address space handler Armin Wolf <W_Armin(a)gmx.de> ACPI: EC: Abort address space access upon error Nathan Chancellor <nathan(a)kernel.org> efi/libstub: zboot.lds: Discard .discard sections Saurav Kashyap <skashyap(a)marvell.com> scsi: qedf: Set qed_slowpath_params to zero before use Saurav Kashyap <skashyap(a)marvell.com> scsi: qedf: Wait for stag work during unload Saurav Kashyap <skashyap(a)marvell.com> scsi: qedf: Don't process stag work during unload and recovery Martin Wilck <martin.wilck(a)suse.com> scsi: core: alua: I/O errors for ALUA state transitions Jann Horn <jannh(a)google.com> filelock: Remove locks reliably when fcntl/close race is detected Kees Cook <keescook(a)chromium.org> gcc-plugins: Rename last_stmt() for GCC 14+ SeongJae Park <sj(a)kernel.org> mm/damon/core: merge regions aggressively when max_nr_regions is unmet David Laight <David.Laight(a)ACULAB.COM> minmax: relax check to allow comparison between unsigned arguments and signed constants David Laight <David.Laight(a)ACULAB.COM> minmax: allow comparisons of 'int' against 'unsigned char/short' David Laight <David.Laight(a)ACULAB.COM> minmax: allow min()/max()/clamp() if the arguments have the same signedness. Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> minmax: fix header inclusions Jason A. Donenfeld <Jason(a)zx2c4.com> minmax: clamp more efficiently by avoiding extra comparison Jason A. Donenfeld <Jason(a)zx2c4.com> minmax: sanity check constant bounds when clamping ------------- Diffstat: Makefile | 4 +- arch/arm/include/asm/uaccess.h | 14 +- arch/mips/kernel/syscalls/syscall_o32.tbl | 2 +- arch/powerpc/kernel/eeh_pe.c | 7 +- arch/powerpc/kvm/book3s_64_vio.c | 18 ++- arch/powerpc/platforms/pseries/setup.c | 4 +- arch/riscv/kernel/stacktrace.c | 3 +- drivers/acpi/ec.c | 9 +- drivers/block/null_blk/main.c | 4 +- drivers/firmware/efi/libstub/zboot.lds | 1 + drivers/gpio/gpio-pca953x.c | 2 + .../amd/display/dc/dml/dcn32/display_mode_vba_32.c | 3 + drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 + drivers/gpu/drm/radeon/radeon_gem.c | 2 +- drivers/gpu/drm/vmwgfx/Kconfig | 2 +- drivers/hid/hid-ids.h | 2 + drivers/hid/hid-input.c | 4 + drivers/input/mouse/elantech.c | 31 +++++ drivers/input/serio/i8042-acpipnpio.h | 18 ++- drivers/input/touchscreen/silead.c | 19 +-- drivers/misc/mei/main.c | 2 +- drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c | 2 +- drivers/net/ethernet/ibm/ibmvnic.c | 12 ++ drivers/net/usb/qmi_wwan.c | 2 + drivers/net/wireless/intel/iwlwifi/mvm/d3.c | 16 ++- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 2 +- drivers/net/wireless/intel/iwlwifi/mvm/scan.c | 8 +- drivers/nvme/host/core.c | 1 + drivers/nvme/target/core.c | 1 + drivers/nvme/target/fabrics-cmd-auth.c | 3 - drivers/nvme/target/fabrics-cmd.c | 6 - drivers/of/irq.c | 143 +++++++++++---------- drivers/of/of_private.h | 3 + drivers/perf/riscv_pmu_sbi.c | 2 +- drivers/platform/mellanox/nvsw-sn2201.c | 5 +- drivers/platform/x86/lg-laptop.c | 89 +++++-------- drivers/platform/x86/wireless-hotkey.c | 2 + drivers/s390/char/sclp.c | 1 + drivers/scsi/device_handler/scsi_dh_alua.c | 31 +++-- drivers/scsi/libsas/sas_internal.h | 14 ++ drivers/scsi/qedf/qedf.h | 1 + drivers/scsi/qedf/qedf_main.c | 47 ++++++- drivers/spi/spi-imx.c | 2 +- drivers/spi/spi-mux.c | 1 + drivers/tee/optee/ffa_abi.c | 12 +- fs/btrfs/qgroup.c | 4 +- fs/cachefiles/cache.c | 45 ++++++- fs/cachefiles/ondemand.c | 74 ++++++++--- fs/cachefiles/volume.c | 1 - fs/dcache.c | 31 ++--- fs/erofs/zmap.c | 2 + fs/file.c | 4 +- fs/fscache/internal.h | 2 - fs/fscache/volume.c | 14 ++ fs/hfsplus/xattr.c | 2 +- fs/iomap/buffered-io.c | 3 +- fs/locks.c | 9 +- fs/nfs/dir.c | 27 ++-- fs/nfs/nfs4proc.c | 1 + fs/nfs/symlink.c | 2 +- fs/smb/client/cifsfs.c | 2 +- fs/smb/common/smb2pdu.h | 34 +++++ fs/smb/server/smb2pdu.c | 9 +- include/linux/fscache-cache.h | 6 + include/linux/minmax.h | 87 +++++++++---- include/net/bluetooth/hci_sync.h | 2 + include/sound/dmaengine_pcm.h | 1 + include/trace/events/fscache.h | 4 + mm/damon/core.c | 21 ++- net/bluetooth/hci_core.c | 76 ++++------- net/bluetooth/hci_sync.c | 13 ++ net/bluetooth/l2cap_core.c | 3 + net/bluetooth/l2cap_sock.c | 14 +- net/ipv6/ila/ila_lwt.c | 7 +- net/ipv6/rpl_iptunnel.c | 14 +- net/mac80211/cfg.c | 5 +- net/mac80211/ieee80211_i.h | 2 + net/mac80211/main.c | 11 +- net/mac80211/mesh.c | 1 + net/mac80211/scan.c | 14 +- net/mac80211/util.c | 4 + net/mac802154/tx.c | 8 +- net/wireless/rdev-ops.h | 6 +- net/wireless/scan.c | 59 ++++++--- scripts/gcc-plugins/gcc-common.h | 4 + scripts/kconfig/expr.c | 29 ----- scripts/kconfig/expr.h | 1 - scripts/kconfig/gconf.c | 3 +- scripts/kconfig/menu.c | 2 - sound/core/pcm_dmaengine.c | 22 ++++ sound/core/pcm_native.c | 2 + sound/pci/hda/patch_realtek.c | 5 + sound/soc/amd/yc/acp6x-mach.c | 7 + sound/soc/intel/boards/bytcr_rt5640.c | 11 ++ sound/soc/soc-generic-dmaengine-pcm.c | 8 ++ sound/soc/soc-topology.c | 29 +++-- sound/soc/sof/sof-audio.c | 2 +- sound/soc/ti/davinci-mcasp.c | 9 +- sound/soc/ti/omap-hdmi.c | 6 +- tools/power/cpupower/utils/helpers/amd.c | 26 +++- tools/testing/selftests/futex/functional/Makefile | 2 +- tools/testing/selftests/openat2/openat2_test.c | 1 + tools/testing/selftests/vDSO/parse_vdso.c | 16 ++- .../selftests/vDSO/vdso_standalone_test_x86.c | 18 ++- 104 files changed, 934 insertions(+), 456 deletions(-)

1 year, 4 months

11
115
0 0

[PATCH 6.6 000/129] 6.6.42-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.6.42 release. There are 129 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Thu, 25 Jul 2024 18:03:23 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.6.42-rc1… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.6.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 6.6.42-rc1 Baokun Li <libaokun1(a)huawei.com> cachefiles: fix slab-use-after-free in cachefiles_withdraw_cookie() Baokun Li <libaokun1(a)huawei.com> cachefiles: fix slab-use-after-free in fscache_withdraw_volume() Baokun Li <libaokun1(a)huawei.com> netfs, fscache: export fscache_put_volume() and add fscache_try_get_volume() Emmanuel Grumbach <emmanuel.grumbach(a)intel.com> wifi: iwlwifi: mvm: don't wake up rx_sync_waitq upon RFKILL Johannes Berg <johannes.berg(a)intel.com> wifi: mac80211: disable softirqs for queued frame handling Johannes Berg <johannes.berg(a)intel.com> wifi: cfg80211: wext: set ssids=NULL for passive scans Marc Zyngier <maz(a)kernel.org> of/irq: Disable "interrupt-map" parsing for PASEMI Nemo Luiz Augusto von Dentz <luiz.von.dentz(a)intel.com> Bluetooth: L2CAP: Fix deadlock Yang Shi <yang(a)os.amperecomputing.com> mm: page_ref: remove folio_try_get_rcu() Masahiro Yamada <masahiroy(a)kernel.org> ARM: 9324/1: fix get_user() broken with veneer Steve French <stfrench(a)microsoft.com> cifs: fix noisy message on copy_file_range Takashi Iwai <tiwai(a)suse.de> ALSA: hda: Use imply for suggesting CONFIG_SERIAL_MULTI_INSTANTIATE David Lechner <dlechner(a)baylibre.com> spi: mux: set ctlr->bits_per_word_mask Daniel Borkmann <daniel(a)iogearbox.net> selftests/bpf: Extend tcx tests to cover late tcx_entry release Edward Adam Davis <eadavis(a)qq.com> hfsplus: fix uninit-value in copy_name John Hubbard <jhubbard(a)nvidia.com> selftests/vDSO: fix clang build errors and warnings John Hubbard <jhubbard(a)nvidia.com> selftest/timerns: fix clang build failures for abs() calls Peter Ujfalusi <peter.ujfalusi(a)linux.intel.com> ASoC: SOF: Intel: hda-pcm: Limit the maximum number of periods by MAX_BDL_ENTRIES Namjae Jeon <linkinjeon(a)kernel.org> ksmbd: return FILE_DEVICE_DISK instead of super magic Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> spi: imx: Don't expect DMA for i.MX{25,35,50,51,53} cspi devices Puranjay Mohan <puranjay(a)kernel.org> riscv: stacktrace: fix usage of ftrace_graph_ret_addr() Samuel Holland <samuel.holland(a)sifive.com> drivers/perf: riscv: Reset the counter to hpmevent mapping while starting cpus Daniel Gabay <daniel.gabay(a)intel.com> wifi: iwlwifi: properly set WIPHY_FLAG_SUPPORTS_EXT_KEK_KCK Christian Brauner <brauner(a)kernel.org> fs: better handle deep ancestor chains in is_subdir() Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer(a)amd.com> drm/radeon: check bo_va->bo is non-NULL before using it Tom Chung <chiahsuan.chung(a)amd.com> drm/amd/display: Fix refresh rate range for some panel Alvin Lee <alvin.lee2(a)amd.com> drm/amd/display: Account for cursor prefetch BW in DML1 mode support Tom Chung <chiahsuan.chung(a)amd.com> drm/amd/display: Add refresh rate range check Gao Xiang <xiang(a)kernel.org> erofs: ensure m_llen is reset to 0 if metadata is invalid Edward Adam Davis <eadavis(a)qq.com> bluetooth/l2cap: sync sock recv cb and release Neeraj Sanjay Kale <neeraj.sanjaykale(a)nxp.com> Bluetooth: btnxpuart: Enable Power Save feature on startup Tetsuo Handa <penguin-kernel(a)I-love.SAKURA.ne.jp> Bluetooth: hci_core: cancel all works upon hci_unregister_dev() Mark-PK Tsai <mark-pk.tsai(a)mediatek.com> tee: optee: ffa: Fix missing-field-initializers warning Xingui Yang <yangxingui(a)huawei.com> scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed Ganesh Goudar <ganeshgr(a)linux.ibm.com> powerpc/eeh: avoid possible crash when edev->pdev changes Anjali K <anjalik(a)linux.ibm.com> powerpc/pseries: Whitelist dtl slub object for copying to userspace Yunshui Jiang <jiangyunshui(a)kylinos.cn> net: mac802154: Fix racy device stats updates by DEV_STATS_INC() and DEV_STATS_ADD() Daniele Palmas <dnlplm(a)gmail.com> net: usb: qmi_wwan: add Telit FN912 compositions Vyacheslav Frantsishko <itmymaill(a)gmail.com> ASoC: amd: yc: Fix non-functional mic on ASUS M5602RA Shengjiu Wang <shengjiu.wang(a)nxp.com> ALSA: dmaengine_pcm: terminate dmaengine before synchronize Aivaz Latypov <reichaivaz(a)gmail.com> ALSA: hda/relatek: Enable Mute LED on HP Laptop 15-gw0xxx Takashi Iwai <tiwai(a)suse.de> ALSA: PCM: Allow resume only for suspended streams Nick Child <nnac123(a)linux.ibm.com> ibmvnic: Add tx check to prevent skb leak Filipe Manana <fdmanana(a)suse.com> btrfs: qgroup: fix quota root leak after quota disable failure Armin Wolf <W_Armin(a)gmx.de> platform/x86: lg-laptop: Use ACPI device handle when evaluating WMAB/WMBB Armin Wolf <W_Armin(a)gmx.de> platform/x86: lg-laptop: Change ACPI device id Armin Wolf <W_Armin(a)gmx.de> platform/x86: lg-laptop: Remove LGEX0815 hotkey handling Armin Wolf <W_Armin(a)gmx.de> platform/x86: wireless-hotkey: Add support for LG Airplane Button Chen Ni <nichen(a)iscas.ac.cn> platform/mellanox: nvsw-sn2201: Add check for platform_device_add_resources Heiko Carstens <hca(a)linux.ibm.com> s390/sclp: Fix sclp_init() cleanup on failure Ratheesh Kannoth <rkannoth(a)marvell.com> octeontx2-pf: Fix coverity and klockwork issues in octeon PF driver Ian Ray <ian.ray(a)gehealthcare.com> gpio: pca953x: fix pca953x_irq_bus_sync_unlock race Chen Ni <nichen(a)iscas.ac.cn> can: kvaser_usb: fix return value for hif_usb_send_regout Alexander Stein <alexander.stein(a)ew.tq-group.com> Input: ads7846 - use spi_device_id table Boyang Yu <yuboyang(a)dapustor.com> nvme: fix NVME_NS_DEAC may incorrectly identifying the disk as EXT_LBA. Jack Yu <jack.yu(a)realtek.com> ASoC: rt722-sdca-sdw: add debounce time for type detection Peter Ujfalusi <peter.ujfalusi(a)linux.intel.com> ASoC: SOF: sof-audio: Skip unprepare for in-use widgets on error rollback Primoz Fiser <primoz.fiser(a)norik.com> ASoC: ti: omap-hdmi: Fix too long driver name Jai Luthra <j-luthra(a)ti.com> ASoC: ti: davinci-mcasp: Set min period size using FIFO config Jai Luthra <j-luthra(a)ti.com> ALSA: dmaengine: Synchronize dma channel after drop() Thomas GENTY <tomlohave(a)gmail.com> bytcr_rt5640 : inverse jack detect for Archos 101 cesium Amadeusz Sławiński <amadeuszx.slawinski(a)linux.intel.com> ASoC: topology: Do not assign fields that are already set Amadeusz Sławiński <amadeuszx.slawinski(a)linux.intel.com> ASoC: topology: Fix references to freed memory Luke D. Jones <luke(a)ljones.dev> Input: xpad - add support for ASUS ROG RAIKIRI PRO Jack Yu <jack.yu(a)realtek.com> ASoC: rt722-sdca-sdw: add silence detection register as volatile Tobias Jakobi <tjakobi(a)math.uni-bielefeld.de> Input: i8042 - add Ayaneo Kun to i8042 quirk table Jonathan Denose <jdenose(a)google.com> Input: elantech - fix touchpad state on resume for Lenovo N24 Arnd Bergmann <arnd(a)arndb.de> mips: fix compat_sys_lseek syscall Simon Trimmer <simont(a)opensource.cirrus.com> ALSA: hda: cs35l56: Select SERIAL_MULTI_INSTANTIATE Harish Kasiviswanathan <Harish.Kasiviswanathan(a)amd.com> drm/amdgpu: Indicate CU havest info to CP Adrian Moreno <amorenoz(a)redhat.com> selftests: openvswitch: Set value to nla flags. Linus Torvalds <torvalds(a)linux-foundation.org> cpumask: limit FORCE_NR_CPUS to just the UP case Patrice Chotard <patrice.chotard(a)foss.st.com> spi: Fix OCTAL mode support Kailang Yang <kailang(a)realtek.com> ALSA: hda/realtek: Add more codec ID to no shutup pins list Alexey Makhalov <alexey.makhalov(a)broadcom.com> drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency Michael Ellerman <mpe(a)ellerman.id.au> KVM: PPC: Book3S HV: Prevent UAF in kvm_spapr_tce_attach_iommu_group() Stefan Binding <sbinding(a)opensource.cirrus.com> ALSA: hda/realtek: Support Lenovo Thinkbook 16P Gen 5 Dmitry Antipov <dmantipov(a)yandex.ru> wifi: cfg80211: wext: add extra SIOCSIWSCAN data check Simon Trimmer <simont(a)opensource.cirrus.com> ALSA: hda: cs35l56: Fix lifecycle of codec pointer Daniel Wagner <dwagner(a)suse.de> nvmet: always initialize cqe.result Chunguang Xu <chunguang.xu(a)shopee.com> nvme: avoid double free special payload Douglas Anderson <dianders(a)chromium.org> drm/mediatek: Call drm_atomic_helper_shutdown() at shutdown time Tobias Jakobi <tjakobi(a)math.uni-bielefeld.de> drm: panel-orientation-quirks: Add quirk for Aya Neo KUN Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> drm/exynos: dp: drop driver owner initialization Ritesh Harjani (IBM) <ritesh.list(a)gmail.com> iomap: Fix iomap_adjust_read_range for plen calculation Alexander Usyskin <alexander.usyskin(a)intel.com> mei: demote client disconnect warning on suspend to debug Yuntao Wang <yuntao.wang(a)linux.dev> fs/file: fix the check in find_next_fd() Baokun Li <libaokun1(a)huawei.com> cachefiles: make on-demand read killable Zizhi Wo <wozizhi(a)huawei.com> cachefiles: Set object to close if ondemand_id < 0 in copen Baokun Li <libaokun1(a)huawei.com> cachefiles: add consistency check for copen/cread Scott Mayhew <smayhew(a)redhat.com> nfs: don't invalidate dentries on transient errors Jan Kara <jack(a)suse.cz> nfs: Avoid flushing many pages with NFS_FILE_SYNC Sagi Grimberg <sagi(a)grimberg.me> nfs: propagate readlink errors in nfs_symlink_filler Dmitry Mastykin <mastichi(a)gmail.com> NFSv4: Fix memory leak in nfs4_set_security_label Louis Dalibard <ontake(a)ontake.dev> HID: Ignore battery for ELAN touchscreens 2F2C and 4116 Aseda Aboagye <aaboagye(a)chromium.org> input: Add support for "Do Not Disturb" Aseda Aboagye <aaboagye(a)chromium.org> input: Add event code for accessibility key Masahiro Yamada <masahiroy(a)kernel.org> kconfig: remove wrong expr_trans_bool() Masahiro Yamada <masahiroy(a)kernel.org> kconfig: gconf: give a proper initial state to the Save button Andreas Hindborg <a.hindborg(a)samsung.com> null_blk: fix validation of block size Wei Li <liwei391(a)huawei.com> arm64: armv8_deprecated: Fix warning in isndep cpuhp starting process Eric Dumazet <edumazet(a)google.com> ila: block BH in ila_output() Eric Dumazet <edumazet(a)google.com> net: ipv6: rpl_iptunnel: block BH in rpl_output() and rpl_input() Hans de Goede <hdegoede(a)redhat.com> Input: silead - Always support 10 fingers Rob Herring (Arm) <robh(a)kernel.org> of/irq: Factor out parsing of interrupt-map parent phandle+args from of_irq_parse_raw() John Hubbard <jhubbard(a)nvidia.com> selftests/futex: pass _GNU_SOURCE without a value to the compiler Michael Ellerman <mpe(a)ellerman.id.au> selftests/openat2: Fix build warnings on ppc64 Michael Ellerman <mpe(a)ellerman.id.au> selftests: cachestat: Fix build warnings on ppc64 Dmitry Antipov <dmantipov(a)yandex.ru> wifi: mac80211: fix UBSAN noise in ieee80211_prep_hw_scan() Ilan Peer <ilan.peer(a)intel.com> wifi: iwlwifi: mvm: Fix scan abort handling with HW rfkill Ayala Beker <ayala.beker(a)intel.com> wifi: iwlwifi: mvm: properly set 6 GHz channel direct probe option Johannes Berg <johannes.berg(a)intel.com> wifi: iwlwifi: mvm: handle BA session teardown in RF-kill Yedidya Benshimol <yedidya.ben.shimol(a)intel.com> wifi: iwlwifi: mvm: Handle BIGTK cipher in kek_kck cmd Benjamin Berg <benjamin.berg(a)intel.com> wifi: iwlwifi: mvm: remove stale STA link data during restart Yedidya Benshimol <yedidya.ben.shimol(a)intel.com> wifi: iwlwifi: mvm: d3: fix WoWLAN command version lookup Johannes Berg <johannes.berg(a)intel.com> wifi: cfg80211: fix 6 GHz scan request building Johannes Berg <johannes.berg(a)intel.com> wifi: mac80211: handle tasklet frames before stopping Johannes Berg <johannes.berg(a)intel.com> wifi: mac80211: apply mcast rate only if interface is up Nicolas Escande <nico.escande(a)gmail.com> wifi: mac80211: mesh: init nonpeer_pm to active by default in mesh sdata Dhananjay Ugwekar <Dhananjay.Ugwekar(a)amd.com> tools/power/cpupower: Fix Pstate frequency reporting on AMD Family 1Ah CPUs Armin Wolf <W_Armin(a)gmx.de> ACPI: EC: Avoid returning AE_OK on errors in address space handler Armin Wolf <W_Armin(a)gmx.de> ACPI: EC: Abort address space access upon error Nathan Chancellor <nathan(a)kernel.org> efi/libstub: zboot.lds: Discard .discard sections Saurav Kashyap <skashyap(a)marvell.com> scsi: qedf: Set qed_slowpath_params to zero before use Saurav Kashyap <skashyap(a)marvell.com> scsi: qedf: Wait for stag work during unload Saurav Kashyap <skashyap(a)marvell.com> scsi: qedf: Don't process stag work during unload and recovery Justin Stitt <justinstitt(a)google.com> scsi: sr: Fix unintentional arithmetic wraparound Martin Wilck <martin.wilck(a)suse.com> scsi: core: alua: I/O errors for ALUA state transitions Jann Horn <jannh(a)google.com> filelock: Remove locks reliably when fcntl/close race is detected ------------- Diffstat: Documentation/cdrom/cdrom-standard.rst | 4 +- Makefile | 4 +- arch/arm/include/asm/uaccess.h | 14 +- arch/arm64/kernel/armv8_deprecated.c | 3 + arch/mips/kernel/syscalls/syscall_o32.tbl | 2 +- arch/powerpc/kernel/eeh_pe.c | 7 +- arch/powerpc/kvm/book3s_64_vio.c | 18 ++- arch/powerpc/platforms/pseries/setup.c | 4 +- arch/riscv/kernel/stacktrace.c | 3 +- drivers/acpi/ec.c | 9 +- drivers/block/null_blk/main.c | 4 +- drivers/bluetooth/btnxpuart.c | 2 +- drivers/firmware/efi/libstub/zboot.lds | 1 + drivers/gpio/gpio-pca953x.c | 2 + drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 15 ++- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 52 +++++++- .../amd/display/dc/dml/dcn32/display_mode_vba_32.c | 3 + drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 + drivers/gpu/drm/exynos/exynos_dp.c | 1 - drivers/gpu/drm/mediatek/mtk_drm_drv.c | 8 ++ drivers/gpu/drm/radeon/radeon_gem.c | 2 +- drivers/gpu/drm/vmwgfx/Kconfig | 2 +- drivers/hid/hid-debug.c | 2 + drivers/hid/hid-ids.h | 2 + drivers/hid/hid-input.c | 13 ++ drivers/input/joystick/xpad.c | 1 + drivers/input/mouse/elantech.c | 31 +++++ drivers/input/serio/i8042-acpipnpio.h | 18 ++- drivers/input/touchscreen/ads7846.c | 12 +- drivers/input/touchscreen/silead.c | 19 +-- drivers/misc/mei/main.c | 2 +- drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c | 2 +- drivers/net/ethernet/ibm/ibmvnic.c | 12 ++ .../ethernet/marvell/octeontx2/nic/otx2_common.c | 10 +- .../net/ethernet/marvell/octeontx2/nic/otx2_reg.h | 55 ++++---- .../net/ethernet/marvell/octeontx2/nic/otx2_txrx.c | 2 +- drivers/net/ethernet/marvell/octeontx2/nic/qos.c | 3 +- drivers/net/usb/qmi_wwan.c | 2 + drivers/net/wireless/intel/iwlwifi/mvm/d3.c | 16 ++- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 47 ++++++- drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c | 13 +- drivers/net/wireless/intel/iwlwifi/mvm/scan.c | 8 +- drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 12 +- drivers/net/wireless/intel/iwlwifi/mvm/sta.h | 5 + drivers/nvme/host/core.c | 1 + drivers/nvme/host/nvme.h | 2 +- drivers/nvme/target/core.c | 1 + drivers/nvme/target/fabrics-cmd-auth.c | 3 - drivers/nvme/target/fabrics-cmd.c | 6 - drivers/of/irq.c | 143 +++++++++++---------- drivers/of/of_private.h | 3 + drivers/perf/riscv_pmu_sbi.c | 2 +- drivers/platform/mellanox/nvsw-sn2201.c | 5 +- drivers/platform/x86/lg-laptop.c | 89 +++++-------- drivers/platform/x86/wireless-hotkey.c | 2 + drivers/s390/char/sclp.c | 1 + drivers/scsi/device_handler/scsi_dh_alua.c | 31 +++-- drivers/scsi/libsas/sas_internal.h | 14 ++ drivers/scsi/qedf/qedf.h | 1 + drivers/scsi/qedf/qedf_main.c | 47 ++++++- drivers/scsi/sr.h | 2 +- drivers/scsi/sr_ioctl.c | 5 +- drivers/spi/spi-imx.c | 2 +- drivers/spi/spi-mux.c | 1 + drivers/spi/spi.c | 6 +- drivers/tee/optee/ffa_abi.c | 12 +- fs/afs/write.c | 2 +- fs/btrfs/qgroup.c | 4 +- fs/cachefiles/cache.c | 45 ++++++- fs/cachefiles/ondemand.c | 74 ++++++++--- fs/cachefiles/volume.c | 1 - fs/dcache.c | 31 ++--- fs/erofs/zmap.c | 2 + fs/file.c | 4 +- fs/fscache/internal.h | 2 - fs/fscache/volume.c | 14 ++ fs/hfsplus/xattr.c | 2 +- fs/iomap/buffered-io.c | 3 +- fs/locks.c | 9 +- fs/nfs/dir.c | 27 ++-- fs/nfs/nfs4proc.c | 1 + fs/nfs/pagelist.c | 5 + fs/nfs/symlink.c | 2 +- fs/smb/client/cifsfs.c | 2 +- fs/smb/client/file.c | 4 +- fs/smb/common/smb2pdu.h | 34 +++++ fs/smb/server/smb2pdu.c | 9 +- include/linux/cdrom.h | 2 +- include/linux/fscache-cache.h | 6 + include/linux/page_ref.h | 49 +------ include/linux/spi/spi.h | 5 +- include/net/bluetooth/hci_sync.h | 2 + include/sound/dmaengine_pcm.h | 1 + include/trace/events/fscache.h | 4 + include/uapi/linux/input-event-codes.h | 2 + lib/Kconfig | 8 +- mm/filemap.c | 10 +- mm/gup.c | 2 +- net/bluetooth/hci_core.c | 76 ++++------- net/bluetooth/hci_sync.c | 13 ++ net/bluetooth/l2cap_core.c | 3 + net/bluetooth/l2cap_sock.c | 14 +- net/ipv6/ila/ila_lwt.c | 7 +- net/ipv6/rpl_iptunnel.c | 14 +- net/mac80211/cfg.c | 5 +- net/mac80211/ieee80211_i.h | 2 + net/mac80211/main.c | 11 +- net/mac80211/mesh.c | 1 + net/mac80211/scan.c | 14 +- net/mac80211/util.c | 4 + net/mac802154/tx.c | 8 +- net/wireless/rdev-ops.h | 6 +- net/wireless/scan.c | 59 ++++++--- scripts/kconfig/expr.c | 29 ----- scripts/kconfig/expr.h | 1 - scripts/kconfig/gconf.c | 3 +- scripts/kconfig/menu.c | 2 - sound/core/pcm_dmaengine.c | 22 ++++ sound/core/pcm_native.c | 2 + sound/pci/hda/Kconfig | 2 + sound/pci/hda/cs35l56_hda.c | 5 + sound/pci/hda/patch_realtek.c | 7 + sound/soc/amd/yc/acp6x-mach.c | 7 + sound/soc/codecs/rt722-sdca-sdw.c | 4 +- sound/soc/intel/boards/bytcr_rt5640.c | 11 ++ sound/soc/soc-generic-dmaengine-pcm.c | 8 ++ sound/soc/soc-topology.c | 29 +++-- sound/soc/sof/intel/hda-pcm.c | 6 + sound/soc/sof/sof-audio.c | 2 +- sound/soc/ti/davinci-mcasp.c | 9 +- sound/soc/ti/omap-hdmi.c | 6 +- tools/power/cpupower/utils/helpers/amd.c | 26 +++- tools/testing/selftests/bpf/config | 3 + tools/testing/selftests/bpf/prog_tests/tc_links.c | 61 +++++++++ tools/testing/selftests/cachestat/test_cachestat.c | 1 + tools/testing/selftests/futex/functional/Makefile | 2 +- .../testing/selftests/net/openvswitch/ovs-dpctl.py | 2 +- tools/testing/selftests/openat2/openat2_test.c | 1 + tools/testing/selftests/timens/exec.c | 6 +- tools/testing/selftests/timens/timer.c | 2 +- tools/testing/selftests/timens/timerfd.c | 2 +- tools/testing/selftests/timens/vfork_exec.c | 4 +- tools/testing/selftests/vDSO/parse_vdso.c | 16 ++- .../selftests/vDSO/vdso_standalone_test_x86.c | 18 ++- 144 files changed, 1168 insertions(+), 568 deletions(-)

1 year, 4 months

14
143
0 0

[PATCH 6.9 000/163] 6.9.11-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.9.11 release. There are 163 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Thu, 25 Jul 2024 18:01:03 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.9.11-rc1… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.9.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 6.9.11-rc1 Baokun Li <libaokun1(a)huawei.com> cachefiles: fix slab-use-after-free in cachefiles_withdraw_cookie() Baokun Li <libaokun1(a)huawei.com> cachefiles: fix slab-use-after-free in fscache_withdraw_volume() Baokun Li <libaokun1(a)huawei.com> netfs, fscache: export fscache_put_volume() and add fscache_try_get_volume() Emmanuel Grumbach <emmanuel.grumbach(a)intel.com> wifi: iwlwifi: mvm: don't wake up rx_sync_waitq upon RFKILL Johannes Berg <johannes.berg(a)intel.com> wifi: mac80211: disable softirqs for queued frame handling Johannes Berg <johannes.berg(a)intel.com> wifi: cfg80211: wext: set ssids=NULL for passive scans Marc Zyngier <maz(a)kernel.org> of/irq: Disable "interrupt-map" parsing for PASEMI Nemo Dmitry Savin <envelsavinds(a)gmail.com> ALSA: hda: cs35l41: Fix swapped l/r audio channels for Lenovo ThinBook 13x Gen4 Luiz Augusto von Dentz <luiz.von.dentz(a)intel.com> Bluetooth: L2CAP: Fix deadlock Yang Shi <yang(a)os.amperecomputing.com> mm: page_ref: remove folio_try_get_rcu() Takashi Iwai <tiwai(a)suse.de> ALSA: hda: Use imply for suggesting CONFIG_SERIAL_MULTI_INSTANTIATE David Lechner <dlechner(a)baylibre.com> spi: mux: set ctlr->bits_per_word_mask Daniel Borkmann <daniel(a)iogearbox.net> selftests/bpf: Extend tcx tests to cover late tcx_entry release Edward Adam Davis <eadavis(a)qq.com> hfsplus: fix uninit-value in copy_name John Hubbard <jhubbard(a)nvidia.com> selftests/vDSO: fix clang build errors and warnings John Hubbard <jhubbard(a)nvidia.com> selftest/timerns: fix clang build failures for abs() calls Peter Ujfalusi <peter.ujfalusi(a)linux.intel.com> ASoC: SOF: Intel: hda-pcm: Limit the maximum number of periods by MAX_BDL_ENTRIES Namjae Jeon <linkinjeon(a)kernel.org> ksmbd: return FILE_DEVICE_DISK instead of super magic Bastien Curutchet <bastien.curutchet(a)bootlin.com> spi: davinci: Unset POWERDOWN bit when releasing resources Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> spi: imx: Don't expect DMA for i.MX{25,35,50,51,53} cspi devices Puranjay Mohan <puranjay(a)kernel.org> riscv: stacktrace: fix usage of ftrace_graph_ret_addr() Samuel Holland <samuel.holland(a)sifive.com> drivers/perf: riscv: Reset the counter to hpmevent mapping while starting cpus Daniel Gabay <daniel.gabay(a)intel.com> wifi: iwlwifi: properly set WIPHY_FLAG_SUPPORTS_EXT_KEK_KCK Christian Brauner <brauner(a)kernel.org> fs: better handle deep ancestor chains in is_subdir() Filipe Manana <fdmanana(a)suse.com> btrfs: fix uninitialized return value in the ref-verify tool Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer(a)amd.com> drm/radeon: check bo_va->bo is non-NULL before using it Roman Li <Roman.Li(a)amd.com> drm/amd/display: Fix array-index-out-of-bounds in dml2/FCLKChangeSupport Fangzhi Zuo <Jerry.Zuo(a)amd.com> drm/amd/display: Update efficiency bandwidth for dcn351 Tom Chung <chiahsuan.chung(a)amd.com> drm/amd/display: Fix refresh rate range for some panel Alvin Lee <alvin.lee2(a)amd.com> drm/amd/display: Account for cursor prefetch BW in DML1 mode support Tom Chung <chiahsuan.chung(a)amd.com> drm/amd/display: Add refresh rate range check Gao Xiang <xiang(a)kernel.org> erofs: ensure m_llen is reset to 0 if metadata is invalid Edward Adam Davis <eadavis(a)qq.com> bluetooth/l2cap: sync sock recv cb and release Neeraj Sanjay Kale <neeraj.sanjaykale(a)nxp.com> Bluetooth: btnxpuart: Enable Power Save feature on startup Tetsuo Handa <penguin-kernel(a)I-love.SAKURA.ne.jp> Bluetooth: hci_core: cancel all works upon hci_unregister_dev() Mark-PK Tsai <mark-pk.tsai(a)mediatek.com> tee: optee: ffa: Fix missing-field-initializers warning Xingui Yang <yangxingui(a)huawei.com> scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed Ganesh Goudar <ganeshgr(a)linux.ibm.com> powerpc/eeh: avoid possible crash when edev->pdev changes Anjali K <anjalik(a)linux.ibm.com> powerpc/pseries: Whitelist dtl slub object for copying to userspace Yunshui Jiang <jiangyunshui(a)kylinos.cn> net: mac802154: Fix racy device stats updates by DEV_STATS_INC() and DEV_STATS_ADD() Gabor Juhos <j4g8y7(a)gmail.com> clk: qcom: apss-ipq-pll: remove 'config_ctl_hi_val' from Stromer pll configs Daniele Palmas <dnlplm(a)gmail.com> net: usb: qmi_wwan: add Telit FN912 compositions Vyacheslav Frantsishko <itmymaill(a)gmail.com> ASoC: amd: yc: Fix non-functional mic on ASUS M5602RA Li Ma <li.ma(a)amd.com> drm/amd/swsmu: add MALL init support workaround for smu_v14_0_1 Shengjiu Wang <shengjiu.wang(a)nxp.com> ALSA: dmaengine_pcm: terminate dmaengine before synchronize Aivaz Latypov <reichaivaz(a)gmail.com> ALSA: hda/relatek: Enable Mute LED on HP Laptop 15-gw0xxx Takashi Iwai <tiwai(a)suse.de> ALSA: PCM: Allow resume only for suspended streams Nick Child <nnac123(a)linux.ibm.com> ibmvnic: Add tx check to prevent skb leak Filipe Manana <fdmanana(a)suse.com> btrfs: qgroup: fix quota root leak after quota disable failure Qu Wenruo <wqu(a)suse.com> btrfs: scrub: handle RST lookup error correctly Armin Wolf <W_Armin(a)gmx.de> platform/x86: lg-laptop: Use ACPI device handle when evaluating WMAB/WMBB Armin Wolf <W_Armin(a)gmx.de> platform/x86: lg-laptop: Change ACPI device id Armin Wolf <W_Armin(a)gmx.de> platform/x86: lg-laptop: Remove LGEX0815 hotkey handling Armin Wolf <W_Armin(a)gmx.de> platform/x86: wireless-hotkey: Add support for LG Airplane Button Chen Ni <nichen(a)iscas.ac.cn> platform/mellanox: nvsw-sn2201: Add check for platform_device_add_resources Heiko Carstens <hca(a)linux.ibm.com> s390/sclp: Fix sclp_init() cleanup on failure Ratheesh Kannoth <rkannoth(a)marvell.com> octeontx2-pf: Fix coverity and klockwork issues in octeon PF driver Ian Ray <ian.ray(a)gehealthcare.com> gpio: pca953x: fix pca953x_irq_bus_sync_unlock race Aryan Srivastava <aryan.srivastava(a)alliedtelesis.co.nz> net: mvpp2: fill-in dev_port attribute Chen Ni <nichen(a)iscas.ac.cn> can: kvaser_usb: fix return value for hif_usb_send_regout Alexander Stein <alexander.stein(a)ew.tq-group.com> Input: ads7846 - use spi_device_id table Boyang Yu <yuboyang(a)dapustor.com> nvme: fix NVME_NS_DEAC may incorrectly identifying the disk as EXT_LBA. Richard Fitzgerald <rf(a)opensource.cirrus.com> ASoC: cs35l56: Disconnect ASP1 TX sources when ASP1 DAI is hooked up Jack Yu <jack.yu(a)realtek.com> ASoC: rt722-sdca-sdw: add debounce time for type detection Peter Ujfalusi <peter.ujfalusi(a)linux.intel.com> ASoC: SOF: sof-audio: Skip unprepare for in-use widgets on error rollback Primoz Fiser <primoz.fiser(a)norik.com> ASoC: ti: omap-hdmi: Fix too long driver name Jai Luthra <j-luthra(a)ti.com> ASoC: ti: davinci-mcasp: Set min period size using FIFO config Jai Luthra <j-luthra(a)ti.com> ALSA: dmaengine: Synchronize dma channel after drop() Thomas GENTY <tomlohave(a)gmail.com> bytcr_rt5640 : inverse jack detect for Archos 101 cesium Amadeusz Sławiński <amadeuszx.slawinski(a)linux.intel.com> ASoC: topology: Do not assign fields that are already set Amadeusz Sławiński <amadeuszx.slawinski(a)linux.intel.com> ASoC: Intel: avs: Fix route override Amadeusz Sławiński <amadeuszx.slawinski(a)linux.intel.com> ASoC: topology: Fix references to freed memory Luke D. Jones <luke(a)ljones.dev> Input: xpad - add support for ASUS ROG RAIKIRI PRO Zhang Yi <zhangyi(a)everest-semi.com> ASoC: codecs: ES8326: Solve headphone detection issue Jack Yu <jack.yu(a)realtek.com> ASoC: rt722-sdca-sdw: add silence detection register as volatile Tobias Jakobi <tjakobi(a)math.uni-bielefeld.de> Input: i8042 - add Ayaneo Kun to i8042 quirk table Jonathan Denose <jdenose(a)google.com> Input: elantech - fix touchpad state on resume for Lenovo N24 Tejun Heo <tj(a)kernel.org> workqueue: Refactor worker ID formatting and make wq_worker_comm() use full ID string Kent Overstreet <kent.overstreet(a)linux.dev> closures: Change BUG_ON() to WARN_ON() Arnd Bergmann <arnd(a)arndb.de> mips: fix compat_sys_lseek syscall Simon Trimmer <simont(a)opensource.cirrus.com> ALSA: hda: cs35l56: Select SERIAL_MULTI_INSTANTIATE Likun Gao <Likun.Gao(a)amd.com> drm/amdgpu: init TA fw for psp v14 Paul Hsieh <paul.hsieh(a)amd.com> drm/amd/display: change dram_clock_latency to 34us for dcn35 Daniel Miess <daniel.miess(a)amd.com> drm/amd/display: Change dram_clock_latency to 34us for dcn351 Harish Kasiviswanathan <Harish.Kasiviswanathan(a)amd.com> drm/amdgpu: Indicate CU havest info to CP Adrian Moreno <amorenoz(a)redhat.com> selftests: openvswitch: Set value to nla flags. Linus Torvalds <torvalds(a)linux-foundation.org> cpumask: limit FORCE_NR_CPUS to just the UP case Patrice Chotard <patrice.chotard(a)foss.st.com> spi: Fix OCTAL mode support Kailang Yang <kailang(a)realtek.com> ALSA: hda/realtek: Add more codec ID to no shutup pins list Alexey Makhalov <alexey.makhalov(a)broadcom.com> drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency Michael Ellerman <mpe(a)ellerman.id.au> KVM: PPC: Book3S HV: Prevent UAF in kvm_spapr_tce_attach_iommu_group() Kenton Groombridge <concord(a)gentoo.org> wifi: mac80211: Avoid address calculations via out of bounds array indexing Stefan Binding <sbinding(a)opensource.cirrus.com> ALSA: hda/realtek: Support Lenovo Thinkbook 13x Gen 4 Stefan Binding <sbinding(a)opensource.cirrus.com> ALSA: hda/realtek: Support Lenovo Thinkbook 16P Gen 5 Stefan Binding <sbinding(a)opensource.cirrus.com> ALSA: hda: cs35l41: Support Lenovo Thinkbook 13x Gen 4 Stefan Binding <sbinding(a)opensource.cirrus.com> ALSA: hda: cs35l41: Support Lenovo Thinkbook 16P Gen 5 Dmitry Antipov <dmantipov(a)yandex.ru> wifi: cfg80211: wext: add extra SIOCSIWSCAN data check Simon Trimmer <simont(a)opensource.cirrus.com> ALSA: hda: cs35l56: Fix lifecycle of codec pointer Cyril Hrubis <chrubis(a)suse.cz> loop: Disable fallocate() zero and discard if not supported Alex Williamson <alex.williamson(a)redhat.com> vfio/pci: Insert full vma on mmap'd MMIO fault Daniel Wagner <dwagner(a)suse.de> nvmet: always initialize cqe.result Chunguang Xu <chunguang.xu(a)shopee.com> nvme: avoid double free special payload Douglas Anderson <dianders(a)chromium.org> drm/mediatek: Call drm_atomic_helper_shutdown() at shutdown time Douglas Anderson <dianders(a)chromium.org> drm: renesas: shmobile: Call drm_atomic_helper_shutdown() at shutdown time Tobias Jakobi <tjakobi(a)math.uni-bielefeld.de> drm: panel-orientation-quirks: Add quirk for Aya Neo KUN Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> drm/exynos: dp: drop driver owner initialization Ritesh Harjani (IBM) <ritesh.list(a)gmail.com> iomap: Fix iomap_adjust_read_range for plen calculation Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> parport: amiga: Mark driver struct with __refdata to prevent section mismatch Alexander Usyskin <alexander.usyskin(a)intel.com> mei: demote client disconnect warning on suspend to debug Alex Williamson <alex.williamson(a)redhat.com> vfio/pci: Use unmap_mapping_range() Alex Williamson <alex.williamson(a)redhat.com> vfio: Create vfio_fs_type with inode per device Yuntao Wang <yuntao.wang(a)linux.dev> fs/file: fix the check in find_next_fd() Baokun Li <libaokun1(a)huawei.com> cachefiles: make on-demand read killable Zizhi Wo <wozizhi(a)huawei.com> cachefiles: Set object to close if ondemand_id < 0 in copen Baokun Li <libaokun1(a)huawei.com> cachefiles: add consistency check for copen/cread Scott Mayhew <smayhew(a)redhat.com> nfs: don't invalidate dentries on transient errors Jan Kara <jack(a)suse.cz> nfs: Avoid flushing many pages with NFS_FILE_SYNC Sagi Grimberg <sagi(a)grimberg.me> nfs: propagate readlink errors in nfs_symlink_filler Dmitry Mastykin <mastichi(a)gmail.com> NFSv4: Fix memory leak in nfs4_set_security_label Louis Dalibard <ontake(a)ontake.dev> HID: Ignore battery for ELAN touchscreens 2F2C and 4116 Aseda Aboagye <aaboagye(a)chromium.org> input: Add support for "Do Not Disturb" Aseda Aboagye <aaboagye(a)chromium.org> input: Add event code for accessibility key Masahiro Yamada <masahiroy(a)kernel.org> kconfig: remove wrong expr_trans_bool() Masahiro Yamada <masahiroy(a)kernel.org> kconfig: gconf: give a proper initial state to the Save button Andreas Hindborg <a.hindborg(a)samsung.com> null_blk: fix validation of block size Tasos Sahanidis <tasos(a)tasossah.com> drm/amdgpu/pptable: Fix UBSAN array-index-out-of-bounds Wei Li <liwei391(a)huawei.com> arm64: armv8_deprecated: Fix warning in isndep cpuhp starting process Hagar Hemdan <hagarhem(a)amazon.com> io_uring: fix possible deadlock in io_register_iowq_max_workers() Eric Dumazet <edumazet(a)google.com> ila: block BH in ila_output() Eric Dumazet <edumazet(a)google.com> net: ipv6: rpl_iptunnel: block BH in rpl_output() and rpl_input() Suma Hegde <suma.hegde(a)amd.com> platform/x86/amd/hsmp: Check HSMP support on AMD family of processors Hans de Goede <hdegoede(a)redhat.com> Input: silead - Always support 10 fingers Huacai Chen <chenhuacai(a)kernel.org> LoongArch: Fix GMAC's phy-mode definitions in dts Chunguang Xu <chunguang.xu(a)shopee.com> nvme-fabrics: use reserved tag for reg read/write command Rob Herring (Arm) <robh(a)kernel.org> of/irq: Factor out parsing of interrupt-map parent phandle+args from of_irq_parse_raw() John Hubbard <jhubbard(a)nvidia.com> selftests/futex: pass _GNU_SOURCE without a value to the compiler Michael Ellerman <mpe(a)ellerman.id.au> selftests/overlayfs: Fix build error on ppc64 Michael Ellerman <mpe(a)ellerman.id.au> selftests/openat2: Fix build warnings on ppc64 Michael Ellerman <mpe(a)ellerman.id.au> selftests: cachestat: Fix build warnings on ppc64 Dmitry Antipov <dmantipov(a)yandex.ru> wifi: mac80211: fix UBSAN noise in ieee80211_prep_hw_scan() Ilan Peer <ilan.peer(a)intel.com> wifi: iwlwifi: mvm: Fix scan abort handling with HW rfkill Ayala Beker <ayala.beker(a)intel.com> wifi: iwlwifi: mvm: properly set 6 GHz channel direct probe option Johannes Berg <johannes.berg(a)intel.com> wifi: iwlwifi: mvm: handle BA session teardown in RF-kill Yedidya Benshimol <yedidya.ben.shimol(a)intel.com> wifi: iwlwifi: mvm: Handle BIGTK cipher in kek_kck cmd Benjamin Berg <benjamin.berg(a)intel.com> wifi: iwlwifi: mvm: remove stale STA link data during restart Yedidya Benshimol <yedidya.ben.shimol(a)intel.com> wifi: iwlwifi: mvm: d3: fix WoWLAN command version lookup Johannes Berg <johannes.berg(a)intel.com> wifi: cfg80211: fix 6 GHz scan request building Johannes Berg <johannes.berg(a)intel.com> wifi: mac80211: handle tasklet frames before stopping Johannes Berg <johannes.berg(a)intel.com> wifi: mac80211: apply mcast rate only if interface is up Nicolas Escande <nico.escande(a)gmail.com> wifi: mac80211: mesh: init nonpeer_pm to active by default in mesh sdata Thomas Weißschuh <linux(a)weissschuh.net> ACPI: AC: Properly notify powermanagement core about changes Andy Shevchenko <andy.shevchenko(a)gmail.com> PNP: Hide pnp_bus_type from the non-PNP code Dhananjay Ugwekar <Dhananjay.Ugwekar(a)amd.com> tools/power/cpupower: Fix Pstate frequency reporting on AMD Family 1Ah CPUs Filipe Manana <fdmanana(a)suse.com> btrfs: ensure fast fsync waits for ordered extents after a write failure Armin Wolf <W_Armin(a)gmx.de> ACPI: EC: Avoid returning AE_OK on errors in address space handler Armin Wolf <W_Armin(a)gmx.de> ACPI: EC: Abort address space access upon error Nathan Chancellor <nathan(a)kernel.org> efi/libstub: zboot.lds: Discard .discard sections Saurav Kashyap <skashyap(a)marvell.com> scsi: qedf: Set qed_slowpath_params to zero before use Saurav Kashyap <skashyap(a)marvell.com> scsi: qedf: Wait for stag work during unload Saurav Kashyap <skashyap(a)marvell.com> scsi: qedf: Don't process stag work during unload and recovery Justin Stitt <justinstitt(a)google.com> scsi: sr: Fix unintentional arithmetic wraparound Martin Wilck <martin.wilck(a)suse.com> scsi: core: alua: I/O errors for ALUA state transitions Steve French <stfrench(a)microsoft.com> cifs: fix noisy message on copy_file_range ------------- Diffstat: Documentation/cdrom/cdrom-standard.rst | 4 +- Makefile | 4 +- arch/arm64/kernel/armv8_deprecated.c | 3 + arch/loongarch/boot/dts/loongson-2k0500-ref.dts | 4 +- arch/loongarch/boot/dts/loongson-2k1000-ref.dts | 4 +- arch/loongarch/boot/dts/loongson-2k2000-ref.dts | 2 +- arch/mips/kernel/syscalls/syscall_o32.tbl | 2 +- arch/powerpc/kernel/eeh_pe.c | 7 +- arch/powerpc/kvm/book3s_64_vio.c | 18 +- arch/powerpc/platforms/pseries/setup.c | 4 +- arch/riscv/kernel/stacktrace.c | 3 +- drivers/acpi/ac.c | 4 +- drivers/acpi/ec.c | 9 +- drivers/acpi/sbs.c | 4 +- drivers/block/loop.c | 23 ++ drivers/block/null_blk/main.c | 4 +- drivers/bluetooth/btnxpuart.c | 2 +- drivers/clk/qcom/apss-ipq-pll.c | 2 - drivers/firmware/efi/libstub/zboot.lds | 1 + drivers/gpio/gpio-pca953x.c | 2 + drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 15 +- drivers/gpu/drm/amd/amdgpu/psp_v14_0.c | 5 + drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 52 +++- .../amd/display/dc/dml/dcn32/display_mode_vba_32.c | 3 + .../gpu/drm/amd/display/dc/dml/dcn35/dcn35_fpu.c | 2 +- .../gpu/drm/amd/display/dc/dml/dcn351/dcn351_fpu.c | 2 +- .../amd/display/dc/dml2/dml2_translation_helper.c | 1 + drivers/gpu/drm/amd/display/dc/dml2/dml2_utils.c | 2 +- drivers/gpu/drm/amd/include/pptable.h | 91 +++---- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 13 + drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 5 + .../amd/pm/swsmu/inc/pmfw_if/smu_v14_0_0_ppsmc.h | 4 +- drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h | 4 +- .../gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c | 73 ++++++ drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 + drivers/gpu/drm/exynos/exynos_dp.c | 1 - drivers/gpu/drm/mediatek/mtk_drm_drv.c | 8 + drivers/gpu/drm/radeon/radeon_gem.c | 2 +- drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c | 8 + drivers/gpu/drm/vmwgfx/Kconfig | 2 +- drivers/hid/hid-debug.c | 2 + drivers/hid/hid-ids.h | 2 + drivers/hid/hid-input.c | 13 + drivers/input/joystick/xpad.c | 1 + drivers/input/mouse/elantech.c | 31 +++ drivers/input/serio/i8042-acpipnpio.h | 18 +- drivers/input/touchscreen/ads7846.c | 12 +- drivers/input/touchscreen/silead.c | 19 +- drivers/misc/mei/main.c | 2 +- drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c | 2 +- drivers/net/ethernet/ibm/ibmvnic.c | 12 + drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 1 + .../ethernet/marvell/octeontx2/nic/otx2_common.c | 10 +- .../net/ethernet/marvell/octeontx2/nic/otx2_reg.h | 55 ++-- .../net/ethernet/marvell/octeontx2/nic/otx2_txrx.c | 2 +- drivers/net/ethernet/marvell/octeontx2/nic/qos.c | 3 +- drivers/net/usb/qmi_wwan.c | 2 + drivers/net/wireless/intel/iwlwifi/mvm/d3.c | 16 +- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 47 +++- drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c | 13 +- drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 6 +- drivers/net/wireless/intel/iwlwifi/mvm/scan.c | 8 +- drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 12 +- drivers/net/wireless/intel/iwlwifi/mvm/sta.h | 5 + drivers/nvme/host/core.c | 1 + drivers/nvme/host/fabrics.c | 6 +- drivers/nvme/host/nvme.h | 2 +- drivers/nvme/target/core.c | 1 + drivers/nvme/target/fabrics-cmd-auth.c | 3 - drivers/nvme/target/fabrics-cmd.c | 6 - drivers/of/irq.c | 143 ++++++----- drivers/of/of_private.h | 3 + drivers/parport/parport_amiga.c | 8 +- drivers/perf/riscv_pmu_sbi.c | 2 +- drivers/platform/mellanox/nvsw-sn2201.c | 5 +- drivers/platform/x86/amd/hsmp.c | 50 +++- drivers/platform/x86/lg-laptop.c | 89 +++---- drivers/platform/x86/wireless-hotkey.c | 2 + drivers/pnp/base.h | 1 + drivers/s390/char/sclp.c | 1 + drivers/scsi/device_handler/scsi_dh_alua.c | 31 ++- drivers/scsi/libsas/sas_internal.h | 14 ++ drivers/scsi/qedf/qedf.h | 1 + drivers/scsi/qedf/qedf_main.c | 47 +++- drivers/scsi/sr.h | 2 +- drivers/scsi/sr_ioctl.c | 5 +- drivers/spi/spi-davinci.c | 6 + drivers/spi/spi-imx.c | 2 +- drivers/spi/spi-mux.c | 1 + drivers/spi/spi.c | 6 +- drivers/tee/optee/ffa_abi.c | 12 +- drivers/vfio/device_cdev.c | 7 + drivers/vfio/group.c | 7 + drivers/vfio/pci/vfio_pci_core.c | 277 +++++---------------- drivers/vfio/vfio_main.c | 44 ++++ fs/btrfs/btrfs_inode.h | 10 + fs/btrfs/file.c | 16 ++ fs/btrfs/ordered-data.c | 31 +++ fs/btrfs/qgroup.c | 4 +- fs/btrfs/ref-verify.c | 9 +- fs/btrfs/scrub.c | 26 +- fs/cachefiles/cache.c | 45 +++- fs/cachefiles/ondemand.c | 74 ++++-- fs/cachefiles/volume.c | 1 - fs/dcache.c | 31 ++- fs/erofs/zmap.c | 2 + fs/file.c | 4 +- fs/hfsplus/xattr.c | 2 +- fs/iomap/buffered-io.c | 3 +- fs/netfs/buffered_write.c | 4 +- fs/netfs/fscache_volume.c | 14 ++ fs/netfs/internal.h | 2 - fs/nfs/dir.c | 27 +- fs/nfs/nfs4proc.c | 1 + fs/nfs/pagelist.c | 5 + fs/nfs/symlink.c | 2 +- fs/smb/client/cifsfs.c | 2 +- fs/smb/client/file.c | 4 +- fs/smb/common/smb2pdu.h | 34 +++ fs/smb/server/smb2pdu.c | 9 +- include/linux/cdrom.h | 2 +- include/linux/fscache-cache.h | 6 + include/linux/page_ref.h | 49 +--- include/linux/pnp.h | 2 - include/linux/spi/spi.h | 5 +- include/linux/vfio.h | 1 + include/linux/vfio_pci_core.h | 2 - include/net/bluetooth/hci_sync.h | 2 + include/sound/dmaengine_pcm.h | 1 + include/trace/events/fscache.h | 4 + include/uapi/linux/input-event-codes.h | 2 + io_uring/register.c | 4 + kernel/workqueue.c | 51 ++-- lib/Kconfig | 8 +- lib/closure.c | 10 +- mm/filemap.c | 10 +- mm/gup.c | 2 +- net/bluetooth/hci_core.c | 76 ++---- net/bluetooth/hci_sync.c | 13 + net/bluetooth/l2cap_core.c | 3 + net/bluetooth/l2cap_sock.c | 14 +- net/ipv6/ila/ila_lwt.c | 7 +- net/ipv6/rpl_iptunnel.c | 14 +- net/mac80211/cfg.c | 5 +- net/mac80211/ieee80211_i.h | 2 + net/mac80211/main.c | 11 +- net/mac80211/mesh.c | 1 + net/mac80211/scan.c | 31 ++- net/mac80211/util.c | 4 + net/mac802154/tx.c | 8 +- net/wireless/rdev-ops.h | 6 +- net/wireless/scan.c | 59 +++-- scripts/kconfig/expr.c | 29 --- scripts/kconfig/expr.h | 1 - scripts/kconfig/gconf.c | 3 +- scripts/kconfig/menu.c | 2 - sound/core/pcm_dmaengine.c | 22 ++ sound/core/pcm_native.c | 2 + sound/pci/hda/Kconfig | 2 + sound/pci/hda/cs35l41_hda_property.c | 8 + sound/pci/hda/cs35l56_hda.c | 5 + sound/pci/hda/patch_realtek.c | 9 + sound/soc/amd/yc/acp6x-mach.c | 7 + sound/soc/codecs/cs35l56-shared.c | 4 + sound/soc/codecs/es8326.c | 8 +- sound/soc/codecs/rt722-sdca-sdw.c | 4 +- sound/soc/intel/avs/topology.c | 19 +- sound/soc/intel/boards/bytcr_rt5640.c | 11 + sound/soc/soc-generic-dmaengine-pcm.c | 8 + sound/soc/soc-topology.c | 29 ++- sound/soc/sof/intel/hda-pcm.c | 6 + sound/soc/sof/sof-audio.c | 2 +- sound/soc/ti/davinci-mcasp.c | 9 +- sound/soc/ti/omap-hdmi.c | 6 +- tools/power/cpupower/utils/helpers/amd.c | 26 +- tools/testing/selftests/bpf/config | 3 + tools/testing/selftests/bpf/prog_tests/tc_links.c | 61 +++++ tools/testing/selftests/cachestat/test_cachestat.c | 1 + .../selftests/filesystems/overlayfs/dev_in_maps.c | 1 + tools/testing/selftests/futex/functional/Makefile | 2 +- .../testing/selftests/net/openvswitch/ovs-dpctl.py | 2 +- tools/testing/selftests/openat2/openat2_test.c | 1 + tools/testing/selftests/timens/exec.c | 6 +- tools/testing/selftests/timens/timer.c | 2 +- tools/testing/selftests/timens/timerfd.c | 2 +- tools/testing/selftests/timens/vfork_exec.c | 4 +- tools/testing/selftests/vDSO/parse_vdso.c | 16 +- .../selftests/vDSO/vdso_standalone_test_x86.c | 18 +- 188 files changed, 1718 insertions(+), 884 deletions(-)

1 year, 4 months

13
176
0 0

[PATCH v3] EDAC/ti: Fix possible null pointer dereference in _emif_get_id()

by Ma Ke

In _emif_get_id(), of_get_address() may return NULL which is later dereferenced. Fix this bug by adding NULL check. Found by code review. Cc: stable(a)vger.kernel.org Fixes: 86a18ee21e5e ("EDAC, ti: Add support for TI keystone and DRA7xx EDAC") Signed-off-by: Ma Ke <make24(a)iscas.ac.cn> --- Changes in v3: - added the patch operations omitted in PATCH v2 RESEND compared to PATCH v2. Sorry for my oversight. Changes in v2: - added Cc stable line. --- drivers/edac/ti_edac.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/edac/ti_edac.c b/drivers/edac/ti_edac.c index 29723c9592f7..6f3da8d99eab 100644 --- a/drivers/edac/ti_edac.c +++ b/drivers/edac/ti_edac.c @@ -207,6 +207,9 @@ static int _emif_get_id(struct device_node *node) int my_id = 0; addrp = of_get_address(node, 0, NULL, NULL); + if (!addrp) + return -EINVAL; + my_addr = (u32)of_translate_address(node, addrp); for_each_matching_node(np, ti_edac_of_match) { @@ -214,6 +217,9 @@ static int _emif_get_id(struct device_node *node) continue; addrp = of_get_address(np, 0, NULL, NULL); + if (!addrp) + return -EINVAL; + addr = (u32)of_translate_address(np, addrp); edac_printk(KERN_INFO, EDAC_MOD_NAME, -- 2.25.1

1 year, 4 months

1
0
0 0

[PATCH v4] drm/client: fix null pointer dereference in drm_client_modeset_probe

by Ma Ke

In drm_client_modeset_probe(), the return value of drm_mode_duplicate() is assigned to modeset->mode, which will lead to a possible NULL pointer dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. Cc: stable(a)vger.kernel.org Fixes: cf13909aee05 ("drm/fb-helper: Move out modeset config code") Signed-off-by: Ma Ke <make24(a)iscas.ac.cn> --- Changes in v4: - modified patch, set ret and break to handle error rightly. Changes in v3: - modified patch as suggestions, returned error directly when failing to get modeset->mode. Changes in v2: - added the recipient's email address, due to the prolonged absence of a response from the recipients. - added Cc stable. --- drivers/gpu/drm/drm_client_modeset.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/drm_client_modeset.c b/drivers/gpu/drm/drm_client_modeset.c index 31af5cf37a09..cee5eafbfb81 100644 --- a/drivers/gpu/drm/drm_client_modeset.c +++ b/drivers/gpu/drm/drm_client_modeset.c @@ -880,6 +880,11 @@ int drm_client_modeset_probe(struct drm_client_dev *client, unsigned int width, kfree(modeset->mode); modeset->mode = drm_mode_duplicate(dev, mode); + if (!modeset->mode) { + ret = -ENOMEM; + break; + } + drm_connector_get(connector); modeset->connectors[modeset->num_connectors++] = connector; modeset->x = offset->x; -- 2.25.1

1 year, 4 months

1
0
0 0

[PATCH v3] drm/client: fix null pointer dereference in drm_client_modeset_probe

by Ma Ke

In drm_client_modeset_probe(), the return value of drm_mode_duplicate() is assigned to modeset->mode, which will lead to a possible NULL pointer dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. Cc: stable(a)vger.kernel.org Fixes: cf13909aee05 ("drm/fb-helper: Move out modeset config code") Signed-off-by: Ma Ke <make24(a)iscas.ac.cn> --- Changes in v3: - modified patch as suggestions, returned error directly when failing to get modeset->mode. Changes in v2: - added the recipient's email address, due to the prolonged absence of a response from the recipients. - added Cc stable. --- drivers/gpu/drm/drm_client_modeset.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_client_modeset.c b/drivers/gpu/drm/drm_client_modeset.c index 31af5cf37a09..750b8dce0f90 100644 --- a/drivers/gpu/drm/drm_client_modeset.c +++ b/drivers/gpu/drm/drm_client_modeset.c @@ -880,6 +880,9 @@ int drm_client_modeset_probe(struct drm_client_dev *client, unsigned int width, kfree(modeset->mode); modeset->mode = drm_mode_duplicate(dev, mode); + if (!modeset->mode) + return 0; + drm_connector_get(connector); modeset->connectors[modeset->num_connectors++] = connector; modeset->x = offset->x; -- 2.25.1

1 year, 4 months

2
4
0 0

Re: [PATCH 6.9 000/250] 6.9.7-rc1 review

by Pavel Machek

On Wed 2024-07-24 18:48:20, DAVIETTE wrote: > Afternoon: > > Has any test on incorporation of muti platform data been seen using the PATCH file ? > > Will the install cause support default models to reset. > > Any other information is welcomed and appreciated, Thanks. > > D.Lauricella Has spam gotten smart with use of AI, or is this real? Can you fix your mailer to to generate in-reply-to headers and try again stating your question? BR, Pavel -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

1 year, 4 months

1
0
0 0

[PATCH v2 RESEND] EDAC/ti: Fix possible null pointer dereference in _emif_get_id()

by Ma Ke

In _emif_get_id(), of_get_address() may return NULL which is later dereferenced. Fix this bug by adding NULL check. Cc: stable(a)vger.kernel.org Fixes: 86a18ee21e5e ("EDAC, ti: Add support for TI keystone and DRA7xx EDAC") Signed-off-by: Ma Ke <make24(a)iscas.ac.cn> --- Changes in v2: - added Cc stable line. --- drivers/edac/ti_edac.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/edac/ti_edac.c b/drivers/edac/ti_edac.c index 29723c9592f7..db23887b2d81 100644 --- a/drivers/edac/ti_edac.c +++ b/drivers/edac/ti_edac.c @@ -207,6 +207,9 @@ static int _emif_get_id(struct device_node *node) int my_id = 0; addrp = of_get_address(node, 0, NULL, NULL); + if (!addrp) + return -EINVAL; + my_addr = (u32)of_translate_address(node, addrp); for_each_matching_node(np, ti_edac_of_match) { -- 2.25.1

1 year, 4 months

3
2
0 0

[PATCH] Bluetooth: hci_core: fix suspicious RCU usage in hci_conn_drop()

by Yunseong Kim

Protection from the queuing operation is achieved with an RCU read lock to avoid calling 'queue_delayed_work()' after 'cancel_delayed_work()', but this does not apply to 'hci_conn_drop()'. commit deee93d13d38 ("Bluetooth: use hdev->workqueue when queuing hdev->{cmd,ncmd}_timer works") The situation described raises concerns about suspicious RCU usage in a corrupted context. CPU 1 CPU 2 hci_dev_do_reset() synchronize_rcu() hci_conn_drop() drain_workqueue() <-- no RCU read protection during queuing. --> queue_delayed_work() It displays a warning message like the following Bluetooth: hci0: unexpected cc 0x0c38 length: 249 > 2 ============================= WARNING: suspicious RCU usage 6.10.0-rc6-01340-gf14c0bb78769 #5 Not tainted ----------------------------- net/mac80211/util.c:4000 RCU-list traversed in non-reader section!! other info that might help us debug this: rcu_scheduler_active = 2, debug_locks = 1 2 locks held by syz-executor/798: #0: ffff800089a3de50 (rtnl_mutex){+.+.}-{4:4}, at: rtnl_lock+0x28/0x40 net/core/rtnetlink.c:79 stack backtrace: CPU: 0 PID: 798 Comm: syz-executor Not tainted 6.10.0-rc6-01340-gf14c0bb78769 #5 Hardware name: linux,dummy-virt (DT) Call trace: dump_backtrace.part.0+0x1b8/0x1d0 arch/arm64/kernel/stacktrace.c:317 dump_backtrace arch/arm64/kernel/stacktrace.c:323 [inline] show_stack+0x34/0x50 arch/arm64/kernel/stacktrace.c:324 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xf0/0x170 lib/dump_stack.c:114 dump_stack+0x20/0x30 lib/dump_stack.c:123 lockdep_rcu_suspicious+0x204/0x2f8 kernel/locking/lockdep.c:6712 ieee80211_check_combinations+0x71c/0x828 [mac80211] ieee80211_check_concurrent_iface+0x494/0x700 [mac80211] ieee80211_open+0x140/0x238 [mac80211] __dev_open+0x270/0x498 net/core/dev.c:1474 __dev_change_flags+0x47c/0x610 net/core/dev.c:8837 dev_change_flags+0x98/0x170 net/core/dev.c:8909 devinet_ioctl+0xdf0/0x18d0 net/ipv4/devinet.c:1177 inet_ioctl+0x34c/0x388 net/ipv4/af_inet.c:1003 sock_do_ioctl+0xe4/0x240 net/socket.c:1222 sock_ioctl+0x4cc/0x740 net/socket.c:1341 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:907 [inline] __se_sys_ioctl fs/ioctl.c:893 [inline] __arm64_sys_ioctl+0x184/0x218 fs/ioctl.c:893 __invoke_syscall arch/arm64/kernel/syscall.c:34 [inline] invoke_syscall+0x90/0x2e8 arch/arm64/kernel/syscall.c:48 el0_svc_common.constprop.0+0x200/0x2a8 arch/arm64/kernel/syscall.c:131 el0_svc+0x48/0xc0 arch/arm64/kernel/entry-common.c:712 el0t_64_sync_handler+0x120/0x130 arch/arm64/kernel/entry-common.c:730 el0t_64_sync+0x190/0x198 arch/arm64/kernel/entry.S:598 This patch attempts to fix that issue with the same convention. Cc: stable(a)vger.kernel.org # v6.1+ Fixes: deee93d13d38 ("Bluetooth: use hdev->workqueue when queuing hdev-> {cmd,ncmd}_timer works") Signed-off-by: Yeoreum Yun <yeoreum.yun(a)arm.com> Tested-by: Yunseong Kim <yskelg(a)gmail.com> Signed-off-by: Yunseong Kim <yskelg(a)gmail.com> --- include/net/bluetooth/hci_core.h | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h index 31020891fc68..111509dc1a23 100644 --- a/include/net/bluetooth/hci_core.h +++ b/include/net/bluetooth/hci_core.h @@ -1572,8 +1572,13 @@ static inline void hci_conn_drop(struct hci_conn *conn) } cancel_delayed_work(&conn->disc_work); - queue_delayed_work(conn->hdev->workqueue, - &conn->disc_work, timeo); + + rcu_read_lock(); + if (!hci_dev_test_flag(conn->hdev, HCI_CMD_DRAIN_WORKQUEUE)) { + queue_delayed_work(conn->hdev->workqueue, + &conn->disc_work, timeo); + } + rcu_read_unlock(); } } -- 2.45.2

1 year, 4 months

2
1
0 0

[RESEND PATCH] rtc: ds1343: Force SPI chip select to be active high

by Ian Abbott

Commit 3b52093dc917 ("rtc: ds1343: Do not hardcode SPI mode flags") bit-flips (^=) the existing SPI_CS_HIGH setting in the SPI mode during device probe. This will set it to the wrong value if the spi-cs-high property has been set in the devicetree node. Just force it to be set active high and get rid of some commentary that attempted to explain why flipping the bit was the correct choice. Fixes: 3b52093dc917 ("rtc: ds1343: Do not hardcode SPI mode flags") Cc: <stable(a)vger.kernel.org> # 5.6+ Cc: Linus Walleij <linus.walleij(a)linaro.org> Cc: Mark Brown <broonie(a)kernel.org> Signed-off-by: Ian Abbott <abbotti(a)mev.co.uk> --- drivers/rtc/rtc-ds1343.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-ds1343.c b/drivers/rtc/rtc-ds1343.c index ed5a6ba89a3e..484b5756b55c 100644 --- a/drivers/rtc/rtc-ds1343.c +++ b/drivers/rtc/rtc-ds1343.c @@ -361,13 +361,10 @@ static int ds1343_probe(struct spi_device *spi) if (!priv) return -ENOMEM; - /* RTC DS1347 works in spi mode 3 and - * its chip select is active high. Active high should be defined as - * "inverse polarity" as GPIO-based chip selects can be logically - * active high but inverted by the GPIO library. + /* + * RTC DS1347 works in spi mode 3 and its chip select is active high. */ - spi->mode |= SPI_MODE_3; - spi->mode ^= SPI_CS_HIGH; + spi->mode |= SPI_MODE_3 | SPI_CS_HIGH; spi->bits_per_word = 8; res = spi_setup(spi); if (res) -- 2.43.0

1 year, 4 months

3
6
0 0

[PATCH v3] block: fix deadlock between sd_remove & sd_release

by Yang Yang

Our test report the following hung task: [ 2538.459400] INFO: task "kworker/0:0":7 blocked for more than 188 seconds. [ 2538.459427] Call trace: [ 2538.459430] __switch_to+0x174/0x338 [ 2538.459436] __schedule+0x628/0x9c4 [ 2538.459442] schedule+0x7c/0xe8 [ 2538.459447] schedule_preempt_disabled+0x24/0x40 [ 2538.459453] __mutex_lock+0x3ec/0xf04 [ 2538.459456] __mutex_lock_slowpath+0x14/0x24 [ 2538.459459] mutex_lock+0x30/0xd8 [ 2538.459462] del_gendisk+0xdc/0x350 [ 2538.459466] sd_remove+0x30/0x60 [ 2538.459470] device_release_driver_internal+0x1c4/0x2c4 [ 2538.459474] device_release_driver+0x18/0x28 [ 2538.459478] bus_remove_device+0x15c/0x174 [ 2538.459483] device_del+0x1d0/0x358 [ 2538.459488] __scsi_remove_device+0xa8/0x198 [ 2538.459493] scsi_forget_host+0x50/0x70 [ 2538.459497] scsi_remove_host+0x80/0x180 [ 2538.459502] usb_stor_disconnect+0x68/0xf4 [ 2538.459506] usb_unbind_interface+0xd4/0x280 [ 2538.459510] device_release_driver_internal+0x1c4/0x2c4 [ 2538.459514] device_release_driver+0x18/0x28 [ 2538.459518] bus_remove_device+0x15c/0x174 [ 2538.459523] device_del+0x1d0/0x358 [ 2538.459528] usb_disable_device+0x84/0x194 [ 2538.459532] usb_disconnect+0xec/0x300 [ 2538.459537] hub_event+0xb80/0x1870 [ 2538.459541] process_scheduled_works+0x248/0x4dc [ 2538.459545] worker_thread+0x244/0x334 [ 2538.459549] kthread+0x114/0x1bc [ 2538.461001] INFO: task "fsck.":15415 blocked for more than 188 seconds. [ 2538.461014] Call trace: [ 2538.461016] __switch_to+0x174/0x338 [ 2538.461021] __schedule+0x628/0x9c4 [ 2538.461025] schedule+0x7c/0xe8 [ 2538.461030] blk_queue_enter+0xc4/0x160 [ 2538.461034] blk_mq_alloc_request+0x120/0x1d4 [ 2538.461037] scsi_execute_cmd+0x7c/0x23c [ 2538.461040] ioctl_internal_command+0x5c/0x164 [ 2538.461046] scsi_set_medium_removal+0x5c/0xb0 [ 2538.461051] sd_release+0x50/0x94 [ 2538.461054] blkdev_put+0x190/0x28c [ 2538.461058] blkdev_release+0x28/0x40 [ 2538.461063] __fput+0xf8/0x2a8 [ 2538.461066] __fput_sync+0x28/0x5c [ 2538.461070] __arm64_sys_close+0x84/0xe8 [ 2538.461073] invoke_syscall+0x58/0x114 [ 2538.461078] el0_svc_common+0xac/0xe0 [ 2538.461082] do_el0_svc+0x1c/0x28 [ 2538.461087] el0_svc+0x38/0x68 [ 2538.461090] el0t_64_sync_handler+0x68/0xbc [ 2538.461093] el0t_64_sync+0x1a8/0x1ac T1: T2: sd_remove del_gendisk __blk_mark_disk_dead blk_freeze_queue_start ++q->mq_freeze_depth bdev_release mutex_lock(&disk->open_mutex) sd_release scsi_execute_cmd blk_queue_enter wait_event(!q->mq_freeze_depth) mutex_lock(&disk->open_mutex) SCSI does not set GD_OWNS_QUEUE, so QUEUE_FLAG_DYING is not set in this scenario. This is a classic ABBA deadlock. To fix the deadlock, make sure we don't try to acquire disk->open_mutex after freezing the queue. Cc: stable(a)vger.kernel.org Fixes: eec1be4c30df ("block: delete partitions later in del_gendisk") Signed-off-by: Yang Yang <yang.yang(a)vivo.com> Reviewed-by: Ming Lei <ming.lei(a)redhat.com> Reviewed-by: Bart Van Assche <bvanassche(a)acm.org> --- Changes from v2: - Add Fixes: and Cc: stable by suggestion Changes from v1: - Modify commit message by suggestion --- block/genhd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/genhd.c b/block/genhd.c index 8f1f3c6b4d67..c5fca3e893a0 100644 --- a/block/genhd.c +++ b/block/genhd.c @@ -663,12 +663,12 @@ void del_gendisk(struct gendisk *disk) */ if (!test_bit(GD_DEAD, &disk->state)) blk_report_disk_dead(disk, false); - __blk_mark_disk_dead(disk); /* * Drop all partitions now that the disk is marked dead. */ mutex_lock(&disk->open_mutex); + __blk_mark_disk_dead(disk); xa_for_each_start(&disk->part_tbl, idx, part, 1) drop_partition(part); mutex_unlock(&disk->open_mutex); -- 2.34.1

1 year, 4 months

3
2
0 0

[PATCH 6.10 00/11] 6.10.1-rc2 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.10.1 release. There are 11 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Thu, 25 Jul 2024 12:28:30 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.10.1-rc2… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.10.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 6.10.1-rc2 Rafael J. Wysocki <rafael.j.wysocki(a)intel.com> thermal: core: Allow thermal zones to tell the core to ignore them Pavel Begunkov <asml.silence(a)gmail.com> io_uring: fix error pbuf checking Richard Fitzgerald <rf(a)opensource.cirrus.com> ASoC: cs35l56: Limit Speaker Volume to +12dB maximum Richard Fitzgerald <rf(a)opensource.cirrus.com> ASoC: cs35l56: Use header defines for Speaker Volume control definition Hao Ge <gehao(a)kylinos.cn> tpm: Use auth only after NULL check in tpm_buf_check_hmac_response() David Howells <dhowells(a)redhat.com> cifs: Fix setting of zero_point after DIO write David Howells <dhowells(a)redhat.com> cifs: Fix server re-repick on subrequest retry Steve French <stfrench(a)microsoft.com> cifs: fix noisy message on copy_file_range David Howells <dhowells(a)redhat.com> cifs: Fix missing fscache invalidation David Howells <dhowells(a)redhat.com> cifs: Fix missing error code set Kees Cook <kees(a)kernel.org> ext4: use memtostr_pad() for s_volume_name ------------- Diffstat: Makefile | 4 +-- drivers/char/tpm/tpm2-sessions.c | 5 +-- drivers/net/wireless/intel/iwlwifi/mvm/tt.c | 7 +++- drivers/thermal/thermal_core.c | 51 ++++++++++++++--------------- drivers/thermal/thermal_core.h | 3 ++ drivers/thermal/thermal_helpers.c | 2 ++ fs/ext4/ext4.h | 2 +- fs/ext4/ioctl.c | 2 +- fs/smb/client/cifsfs.c | 2 +- fs/smb/client/file.c | 21 +++++++++--- fs/smb/client/smb2pdu.c | 3 -- include/sound/cs35l56.h | 2 +- io_uring/kbuf.c | 4 ++- sound/soc/codecs/cs35l56.c | 6 +++- 14 files changed, 69 insertions(+), 45 deletions(-)

1 year, 4 months

8
7
0 0

Linux 6.10.1

by Greg Kroah-Hartman

I'm announcing the release of the 6.10.1 kernel. All users of the 6.10 kernel series must upgrade. The updated 6.10.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-6.10.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Makefile | 2 - drivers/char/tpm/tpm2-sessions.c | 5 +- drivers/net/wireless/intel/iwlwifi/mvm/tt.c | 7 +++ drivers/thermal/thermal_core.c | 51 +++++++++++++--------------- drivers/thermal/thermal_core.h | 3 + drivers/thermal/thermal_helpers.c | 2 + fs/ext4/ext4.h | 2 - fs/ext4/ioctl.c | 2 - fs/smb/client/cifsfs.c | 2 - fs/smb/client/file.c | 21 +++++++++-- fs/smb/client/smb2pdu.c | 3 - include/sound/cs35l56.h | 2 - io_uring/kbuf.c | 4 +- sound/soc/codecs/cs35l56.c | 6 ++- 14 files changed, 68 insertions(+), 44 deletions(-) David Howells (4): cifs: Fix missing error code set cifs: Fix missing fscache invalidation cifs: Fix server re-repick on subrequest retry cifs: Fix setting of zero_point after DIO write Greg Kroah-Hartman (1): Linux 6.10.1 Hao Ge (1): tpm: Use auth only after NULL check in tpm_buf_check_hmac_response() Kees Cook (1): ext4: use memtostr_pad() for s_volume_name Pavel Begunkov (1): io_uring: fix error pbuf checking Rafael J. Wysocki (1): thermal: core: Allow thermal zones to tell the core to ignore them Richard Fitzgerald (2): ASoC: cs35l56: Use header defines for Speaker Volume control definition ASoC: cs35l56: Limit Speaker Volume to +12dB maximum Steve French (1): cifs: fix noisy message on copy_file_range

1 year, 4 months

1
1
0 0

Linux 6.10.1

by Greg Kroah-Hartman

I'm announcing the release of the 6.10.1 kernel. All users of the 6.10 kernel series must upgrade. The updated 6.10.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-6.10.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Makefile | 2 - drivers/char/tpm/tpm2-sessions.c | 5 +- drivers/net/wireless/intel/iwlwifi/mvm/tt.c | 7 +++ drivers/thermal/thermal_core.c | 51 +++++++++++++--------------- drivers/thermal/thermal_core.h | 3 + drivers/thermal/thermal_helpers.c | 2 + fs/ext4/ext4.h | 2 - fs/ext4/ioctl.c | 2 - fs/smb/client/cifsfs.c | 2 - fs/smb/client/file.c | 21 +++++++++-- fs/smb/client/smb2pdu.c | 3 - include/sound/cs35l56.h | 2 - io_uring/kbuf.c | 4 +- sound/soc/codecs/cs35l56.c | 6 ++- 14 files changed, 68 insertions(+), 44 deletions(-) David Howells (4): cifs: Fix missing error code set cifs: Fix missing fscache invalidation cifs: Fix server re-repick on subrequest retry cifs: Fix setting of zero_point after DIO write Greg Kroah-Hartman (1): Linux 6.10.1 Hao Ge (1): tpm: Use auth only after NULL check in tpm_buf_check_hmac_response() Kees Cook (1): ext4: use memtostr_pad() for s_volume_name Pavel Begunkov (1): io_uring: fix error pbuf checking Rafael J. Wysocki (1): thermal: core: Allow thermal zones to tell the core to ignore them Richard Fitzgerald (2): ASoC: cs35l56: Use header defines for Speaker Volume control definition ASoC: cs35l56: Limit Speaker Volume to +12dB maximum Steve French (1): cifs: fix noisy message on copy_file_range

1 year, 4 months

1
1
0 0

[PATCH] drm/nouveau: fix a possible null pointer dereference

by Ma Ke

In ch7006_encoder_get_modes(), the return value of drm_mode_duplicate() is used directly in drm_mode_probed_add(), which will lead to a NULL pointer dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. Cc: stable(a)vger.kernel.org Fixes: 6ee738610f41 ("drm/nouveau: Add DRM driver for NVIDIA GPUs") Signed-off-by: Ma Ke <make24(a)iscas.ac.cn> --- drivers/gpu/drm/i2c/ch7006_drv.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i2c/ch7006_drv.c b/drivers/gpu/drm/i2c/ch7006_drv.c index 131512a5f3bd..48bf6e4e8bdb 100644 --- a/drivers/gpu/drm/i2c/ch7006_drv.c +++ b/drivers/gpu/drm/i2c/ch7006_drv.c @@ -229,6 +229,7 @@ static int ch7006_encoder_get_modes(struct drm_encoder *encoder, { struct ch7006_priv *priv = to_ch7006_priv(encoder); const struct ch7006_mode *mode; + struct drm_display_mode *encoder_mode = NULL; int n = 0; for (mode = ch7006_modes; mode->mode.clock; mode++) { @@ -236,8 +237,11 @@ static int ch7006_encoder_get_modes(struct drm_encoder *encoder, ~mode->valid_norms & 1<<priv->norm) continue; - drm_mode_probed_add(connector, - drm_mode_duplicate(encoder->dev, &mode->mode)); + encoder_mode = drm_mode_duplicate(encoder->dev, &mode->mode); + if (!encoder_mode) + return 0; + + drm_mode_probed_add(connector, encoder_mode); n++; } -- 2.25.1

1 year, 4 months

1
0
0 0

[PATCH fro 6.11 0/2] ASoC SOF: ipc4-topology: Fix LinkID handling for ChainDMA

by Peter Ujfalusi

Hi, A recent patch available in 6.10 [1] uncovered two issues on how the DMA Link ID is tracked with ChainDMA and can cause under specific conditions [2] to cause a DSP panic. The issue is not academic as we have one user report of it: https://github.com/thesofproject/linux/issues/5116 The patches have been marked for stable backport to made there way to 6.10. The first patch is fixing a code move patch, for older than 6.9 we would need different patch to fix the original code, but since the issue is only valid for 6.10, I will do that at a later time. Mark, can you please schedule these as fixes for 6.11 to get them fast to 6.10? Thank you. [1] ebd3b3014eeb ("ASoC: SOF: pcm: reset all PCM sources in case of xruns") [2] https://github.com/thesofproject/linux/pull/5119#issuecomment-2244770449 Regards, Peter --- Peter Ujfalusi (2): ASoC: SOF: ipc4-topology: Only handle dai_config with HW_PARAMS for ChainDMA ASoC: SOF: ipc4-topology: Preserve the DMA Link ID for ChainDMA on unprepare sound/soc/sof/ipc4-topology.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) -- 2.45.2

1 year, 4 months

2
3
0 0

Re: CVE-2024-39471: drm/amdgpu: add error handle to avoid out-of-bounds

by Siddh Raman Pant

(Mail V2: Send to correct mailing list and CCing relevant people.) On Tue, 25 Jun 2024 16:29:04 +0200, Greg Kroah-Hartman wrote: > In the Linux kernel, the following vulnerability has been resolved: > > drm/amdgpu: add error handle to avoid out-of-bounds > > if the sdma_v4_0_irq_id_to_seq return -EINVAL, the process should > be stop to avoid out-of-bounds read, so directly return -EINVAL. > > The Linux kernel CVE team has assigned CVE-2024-39471 to this issue. This commit has a bug which was fixed by 6769a23697f1. It should be immediately backported, otherwise this "fix" doesn't do anything since gcc will optimise out the check. Thanks, Siddh

1 year, 4 months

1
0
0 0

[PATCH v2 RESEND] drm/client: fix null pointer dereference in drm_client_modeset_probe

by Ma Ke

In drm_client_modeset_probe(), the return value of drm_mode_duplicate() is assigned to modeset->mode, which will lead to a possible NULL pointer dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. Cc: stable(a)vger.kernel.org Fixes: cf13909aee05 ("drm/fb-helper: Move out modeset config code") Signed-off-by: Ma Ke <make24(a)iscas.ac.cn> --- Changes in v2: - added the recipient's email address, due to the prolonged absence of a response from the recipients. - added Cc stable. --- drivers/gpu/drm/drm_client_modeset.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_client_modeset.c b/drivers/gpu/drm/drm_client_modeset.c index 31af5cf37a09..cca37b225385 100644 --- a/drivers/gpu/drm/drm_client_modeset.c +++ b/drivers/gpu/drm/drm_client_modeset.c @@ -880,6 +880,9 @@ int drm_client_modeset_probe(struct drm_client_dev *client, unsigned int width, kfree(modeset->mode); modeset->mode = drm_mode_duplicate(dev, mode); + if (!modeset->mode) + continue; + drm_connector_get(connector); modeset->connectors[modeset->num_connectors++] = connector; modeset->x = offset->x; -- 2.25.1

1 year, 4 months

2
1
0 0

[PATCH v2] spi: ppc4xx: handle irq_of_parse_and_map() errors

by Ma Ke

Zero and negative number is not a valid IRQ for in-kernel code and the irq_of_parse_and_map() function returns zero on error. So this check for valid IRQs should only accept values > 0. Cc: stable(a)vger.kernel.org Fixes: 44dab88e7cc9 ("spi: add spi_ppc4xx driver") Signed-off-by: Ma Ke <make24(a)iscas.ac.cn> --- Changes in v2: - added Cc stable line; - added Fixes line. --- drivers/spi/spi-ppc4xx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/spi/spi-ppc4xx.c b/drivers/spi/spi-ppc4xx.c index 942c3117ab3a..01fdecbf132d 100644 --- a/drivers/spi/spi-ppc4xx.c +++ b/drivers/spi/spi-ppc4xx.c @@ -413,6 +413,9 @@ static int spi_ppc4xx_of_probe(struct platform_device *op) /* Request IRQ */ hw->irqnum = irq_of_parse_and_map(np, 0); + if (hw->irqnum <= 0) + goto free_host; + ret = request_irq(hw->irqnum, spi_ppc4xx_int, 0, "spi_ppc4xx_of", (void *)hw); if (ret) { -- 2.25.1

1 year, 4 months

3
2
0 0

[PATCH RESEND] EDAC/altera: Fix possible null pointer dereference

by Ma Ke

In altr_s10_sdram_check_ecc_deps(), of_get_address() may return NULL which is later dereferenced. Fix this bug by adding NULL check. Cc: stable(a)vger.kernel.org Fixes: e1bca853dddc ("EDAC/altera: Add SDRAM ECC check for U-Boot") Signed-off-by: Ma Ke <make24(a)iscas.ac.cn> --- drivers/edac/altera_edac.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c index fe89f5c4837f..d6bf0eebeb41 100644 --- a/drivers/edac/altera_edac.c +++ b/drivers/edac/altera_edac.c @@ -1086,6 +1086,7 @@ static int altr_s10_sdram_check_ecc_deps(struct altr_edac_device_dev *device) struct arm_smccc_res result; struct device_node *np; phys_addr_t sdram_addr; + const __be32 *sdram_addrp; u32 read_reg; int ret; @@ -1093,8 +1094,14 @@ static int altr_s10_sdram_check_ecc_deps(struct altr_edac_device_dev *device) if (!np) goto sdram_err; - sdram_addr = of_translate_address(np, of_get_address(np, 0, - NULL, NULL)); + sdram_addrp = of_get_address(np, 0, NULL, NULL); + if (!sdram_addrp) + return -EINVAL; + + sdram_addr = of_translate_address(np, sdram_addrp); + if (!sdram_addr) + return -EINVAL; + of_node_put(np); sdram_ecc_addr = (unsigned long)sdram_addr + prv->ecc_en_ofst; arm_smccc_smc(INTEL_SIP_SMC_REG_READ, sdram_ecc_addr, -- 2.25.1

1 year, 4 months

1
0
0 0

[PATCH 5.10 000/770] 5.10.220-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.10.220 release. There are 770 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Thu, 20 Jun 2024 12:32:00 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.220-r… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 5.10.220-rc1 Trond Myklebust <trond.myklebust(a)hammerspace.com> nfsd: Fix a regression in nfsd_setattr() NeilBrown <neilb(a)suse.de> nfsd: don't call locks_release_private() twice concurrently NeilBrown <neilb(a)suse.de> nfsd: don't take fi_lock in nfsd_break_deleg_cb() NeilBrown <neilb(a)suse.de> nfsd: fix RELEASE_LOCKOWNER Jeff Layton <jlayton(a)kernel.org> nfsd: drop the nfsd_put helper NeilBrown <neilb(a)suse.de> nfsd: call nfsd_last_thread() before final nfsd_put() NeilBrown <neilb(a)suse.de> NFSD: fix possible oops when nfsd/pool_stats is closed. Chuck Lever <chuck.lever(a)oracle.com> Documentation: Add missing documentation for EXPORT_OP flags NeilBrown <neilb(a)suse.de> nfsd: separate nfsd_last_thread() from nfsd_put() NeilBrown <neilb(a)suse.de> nfsd: Simplify code around svc_exit_thread() call in nfsd() Chuck Lever <chuck.lever(a)oracle.com> nfsd: don't allow nfsd threads to be signalled. Tavian Barnes <tavianator(a)tavianator.com> nfsd: Fix creation time serialization order Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add an nfsd4_encode_nfstime4() helper NeilBrown <neilb(a)suse.de> lockd: drop inappropriate svc_get() from locked_get() Dan Carpenter <dan.carpenter(a)linaro.org> nfsd: fix double fget() bug in __write_ports_addfd() Jeff Layton <jlayton(a)kernel.org> nfsd: make a copy of struct iattr before calling notify_change Dai Ngo <dai.ngo(a)oracle.com> NFSD: Fix problem of COMMIT and NFS4ERR_DELAY in infinite loop Jeff Layton <jlayton(a)kernel.org> nfsd: simplify the delayed disposal list code Chuck Lever <chuck.lever(a)oracle.com> NFSD: Convert filecache to rhltable Jeff Layton <jlayton(a)kernel.org> nfsd: allow reaping files still under writeback Jeff Layton <jlayton(a)kernel.org> nfsd: update comment over __nfsd_file_cache_purge Jeff Layton <jlayton(a)kernel.org> nfsd: don't take/put an extra reference when putting a file Jeff Layton <jlayton(a)kernel.org> nfsd: add some comments to nfsd_file_do_acquire Jeff Layton <jlayton(a)kernel.org> nfsd: don't kill nfsd_files because of lease break error Jeff Layton <jlayton(a)kernel.org> nfsd: simplify test_bit return in NFSD_FILE_KEY_FULL comparator Jeff Layton <jlayton(a)kernel.org> nfsd: NFSD_FILE_KEY_INODE only needs to find GC'ed entries Jeff Layton <jlayton(a)kernel.org> nfsd: don't open-code clear_and_wake_up_bit Jeff Layton <jlayton(a)kernel.org> nfsd: call op_release, even when op_func returns an error Chuck Lever <chuck.lever(a)oracle.com> NFSD: Avoid calling OPDESC() with ops->opnum == OP_ILLEGAL Jeff Layton <jlayton(a)kernel.org> nfsd: don't replace page in rq_pages if it's a continuation of last page Jeff Layton <jlayton(a)kernel.org> lockd: set file_lock start and end when decoding nlm4 testargs Chuck Lever <chuck.lever(a)oracle.com> NFSD: Protect against filesystem freezing Chuck Lever <chuck.lever(a)oracle.com> NFSD: copy the whole verifier in nfsd_copy_write_verifier Jeff Layton <jlayton(a)kernel.org> nfsd: don't fsync nfsd_files on last close Jeff Layton <jlayton(a)kernel.org> nfsd: fix courtesy client with deny mode handling in nfs4_upgrade_open Dai Ngo <dai.ngo(a)oracle.com> NFSD: fix problems with cleanup on errors in nfsd4_copy Jeff Layton <jlayton(a)kernel.org> nfsd: don't hand out delegation on setuid files being opened for write Dai Ngo <dai.ngo(a)oracle.com> NFSD: fix leaked reference count of nfsd4_ssc_umount_item Jeff Layton <jlayton(a)kernel.org> nfsd: clean up potential nfsd_file refcount leaks in COPY codepath Jeff Layton <jlayton(a)kernel.org> nfsd: allow nfsd_file_get to sanely handle a NULL pointer Dai Ngo <dai.ngo(a)oracle.com> NFSD: enhance inter-server copy cleanup Jeff Layton <jlayton(a)kernel.org> nfsd: don't destroy global nfs4_file table in per-net shutdown Jeff Layton <jlayton(a)kernel.org> nfsd: don't free files unconditionally in __nfsd_file_cache_purge Dai Ngo <dai.ngo(a)oracle.com> NFSD: replace delayed_work with work_struct for nfsd_client_shrinker Dai Ngo <dai.ngo(a)oracle.com> NFSD: register/unregister of nfsd-client shrinker at nfsd startup/shutdown time Xingyuan Mo <hdthky0(a)gmail.com> NFSD: fix use-after-free in nfsd4_ssc_setup_dul() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Use set_bit(RQ_DROPME) Chuck Lever <chuck.lever(a)oracle.com> Revert "SUNRPC: Use RMW bitops in single-threaded hot paths" Jeff Layton <jlayton(a)kernel.org> nfsd: fix handling of cached open files in nfsd4_open codepath Jeff Layton <jlayton(a)kernel.org> nfsd: rework refcounting in filecache Kees Cook <keescook(a)chromium.org> NFSD: Avoid clashing function prototypes Chuck Lever <chuck.lever(a)oracle.com> NFSD: Use only RQ_DROPME to signal the need to drop a reply Dai Ngo <dai.ngo(a)oracle.com> NFSD: add delegation reaper to react to low memory condition Dai Ngo <dai.ngo(a)oracle.com> NFSD: add support for sending CB_RECALL_ANY Dai Ngo <dai.ngo(a)oracle.com> NFSD: refactoring courtesy_client_reaper to a generic low memory shrinker Brian Foster <bfoster(a)redhat.com> NFSD: pass range end to vfs_fsync_range() instead of count Jeff Layton <jlayton(a)kernel.org> lockd: fix file selection in nlmsvc_cancel_blocked Jeff Layton <jlayton(a)kernel.org> lockd: ensure we use the correct file descriptor when unlocking Jeff Layton <jlayton(a)kernel.org> lockd: set missing fl_flags field when retrieving args Xiu Jianfeng <xiujianfeng(a)huawei.com> NFSD: Use struct_size() helper in alloc_session() Jeff Layton <jlayton(a)kernel.org> nfsd: return error if nfs4_setacl fails Trond Myklebust <trond.myklebust(a)hammerspace.com> lockd: set other missing fields when unlocking files Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add an nfsd_file_fsync tracepoint Jeff Layton <jlayton(a)kernel.org> nfsd: fix up the filecache laundrette scheduling Jeff Layton <jlayton(a)kernel.org> nfsd: reorganize filecache.c Jeff Layton <jlayton(a)kernel.org> nfsd: remove the pages_flushed statistic from filecache Chuck Lever <chuck.lever(a)oracle.com> NFSD: Fix licensing header in filecache.c Chuck Lever <chuck.lever(a)oracle.com> NFSD: Use rhashtable for managing nfs4_file objects Chuck Lever <chuck.lever(a)oracle.com> NFSD: Refactor find_file() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Clean up find_or_add_file() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add a nfsd4_file_hash_remove() helper Chuck Lever <chuck.lever(a)oracle.com> NFSD: Clean up nfsd4_init_file() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update file_hashtbl() helpers Chuck Lever <chuck.lever(a)oracle.com> NFSD: Use const pointers as parameters to fh_ helpers Chuck Lever <chuck.lever(a)oracle.com> NFSD: Trace delegation revocations Chuck Lever <chuck.lever(a)oracle.com> NFSD: Trace stateids returned via DELEGRETURN Chuck Lever <chuck.lever(a)oracle.com> NFSD: Clean up nfs4_preprocess_stateid_op() call sites Chuck Lever <chuck.lever(a)oracle.com> NFSD: Flesh out a documenting comment for filecache.c Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add an NFSD_FILE_GC flag to enable nfsd_file garbage collection Chuck Lever <chuck.lever(a)oracle.com> NFSD: Revert "NFSD: NFSv4 CLOSE should release an nfsd_file immediately" Chuck Lever <chuck.lever(a)oracle.com> NFSD: Pass the target nfsd_file to nfsd_commit() David Disseldorp <ddiss(a)suse.de> exportfs: use pr_debug for unreachable debug statements Jeff Layton <jlayton(a)kernel.org> nfsd: allow disabling NFSv2 at compile time Jeff Layton <jlayton(a)kernel.org> nfsd: move nfserrno() to vfs.c Jeff Layton <jlayton(a)kernel.org> nfsd: ignore requests to disable unsupported versions Chuck Lever <chuck.lever(a)oracle.com> NFSD: Finish converting the NFSv3 GETACL result encoder Chuck Lever <chuck.lever(a)oracle.com> NFSD: Finish converting the NFSv2 GETACL result encoder Colin Ian King <colin.i.king(a)gmail.com> NFSD: Remove redundant assignment to variable host_err Anna Schumaker <Anna.Schumaker(a)Netapp.com> NFSD: Simplify READ_PLUS Jeff Layton <jlayton(a)kernel.org> nfsd: use locks_inode_context helper Jeff Layton <jlayton(a)kernel.org> lockd: use locks_inode_context helper Jeff Layton <jlayton(a)kernel.org> filelock: add a new locks_inode_context accessor function Chuck Lever <chuck.lever(a)oracle.com> NFSD: Fix reads with a non-zero offset that don't end on a page boundary Jeff Layton <jlayton(a)kernel.org> nfsd: put the export reference in nfsd4_verify_deleg_dentry Jeff Layton <jlayton(a)kernel.org> nfsd: fix use-after-free in nfsd_file_do_acquire tracepoint Jeff Layton <jlayton(a)kernel.org> nfsd: fix net-namespace logic in __nfsd_file_cache_purge Tetsuo Handa <penguin-kernel(a)I-love.SAKURA.ne.jp> NFSD: unregister shrinker when nfsd_init_net() fails Jeff Layton <jlayton(a)kernel.org> nfsd: rework hashtable handling in nfsd_do_file_acquire Jeff Layton <jlayton(a)kernel.org> nfsd: fix nfsd_file_unhash_and_dispose Gaosheng Cui <cuigaosheng1(a)huawei.com> fanotify: Remove obsoleted fanotify_event_has_path() Gaosheng Cui <cuigaosheng1(a)huawei.com> fsnotify: remove unused declaration Al Viro <viro(a)zeniv.linux.org.uk> fs/notify: constify path Jeff Layton <jlayton(a)kernel.org> nfsd: extra checks when freeing delegation stateids Jeff Layton <jlayton(a)kernel.org> nfsd: make nfsd4_run_cb a bool return function Jeff Layton <jlayton(a)kernel.org> nfsd: fix comments about spinlock handling with delegations Jeff Layton <jlayton(a)kernel.org> nfsd: only fill out return pointer on success in nfsd4_lookup_stateid Chuck Lever <chuck.lever(a)oracle.com> NFSD: Cap rsize_bop result based on send buffer size Chuck Lever <chuck.lever(a)oracle.com> NFSD: Rename the fields in copy_stateid_t ChenXiaoSong <chenxiaosong2(a)huawei.com> nfsd: use DEFINE_SHOW_ATTRIBUTE to define nfsd_file_cache_stats_fops ChenXiaoSong <chenxiaosong2(a)huawei.com> nfsd: use DEFINE_SHOW_ATTRIBUTE to define nfsd_reply_cache_stats_fops ChenXiaoSong <chenxiaosong2(a)huawei.com> nfsd: use DEFINE_SHOW_ATTRIBUTE to define client_info_fops ChenXiaoSong <chenxiaosong2(a)huawei.com> nfsd: use DEFINE_SHOW_ATTRIBUTE to define export_features_fops and supported_enctypes_fops ChenXiaoSong <chenxiaosong2(a)huawei.com> nfsd: use DEFINE_PROC_SHOW_ATTRIBUTE to define nfsd_proc_ops Chuck Lever <chuck.lever(a)oracle.com> NFSD: Pack struct nfsd4_compoundres Chuck Lever <chuck.lever(a)oracle.com> NFSD: Remove unused nfsd4_compoundargs::cachetype field Chuck Lever <chuck.lever(a)oracle.com> NFSD: Remove "inline" directives on op_rsize_bop helpers Chuck Lever <chuck.lever(a)oracle.com> NFSD: Clean up nfs4svc_encode_compoundres() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Clean up WRITE arg decoders Chuck Lever <chuck.lever(a)oracle.com> NFSD: Use xdr_inline_decode() to decode NFSv3 symlinks Chuck Lever <chuck.lever(a)oracle.com> NFSD: Refactor common code out of dirlist helpers Chuck Lever <chuck.lever(a)oracle.com> NFSD: Reduce amount of struct nfsd4_compoundargs that needs clearing Chuck Lever <chuck.lever(a)oracle.com> SUNRPC: Parametrize how much of argsize should be zeroed Dai Ngo <dai.ngo(a)oracle.com> NFSD: add shrinker to reap courtesy clients on low memory condition Dai Ngo <dai.ngo(a)oracle.com> NFSD: keep track of the number of courtesy clients in the system Chuck Lever <chuck.lever(a)oracle.com> NFSD: Make nfsd4_remove() wait before returning NFS4ERR_DELAY Chuck Lever <chuck.lever(a)oracle.com> NFSD: Make nfsd4_rename() wait before returning NFS4ERR_DELAY Chuck Lever <chuck.lever(a)oracle.com> NFSD: Make nfsd4_setattr() wait before returning NFS4ERR_DELAY Chuck Lever <chuck.lever(a)oracle.com> NFSD: Refactor nfsd_setattr() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add a mechanism to wait for a DELEGRETURN Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add tracepoints to report NFSv4 callback completions Gaosheng Cui <cuigaosheng1(a)huawei.com> nfsd: remove nfsd4_prepare_cb_recall() declaration Jeff Layton <jlayton(a)kernel.org> nfsd: clean up mounted_on_fileid handling Chuck Lever <chuck.lever(a)oracle.com> NFSD: Fix handling of oversized NFSv4 COMPOUND requests NeilBrown <neilb(a)suse.de> NFSD: drop fname and flen args from nfsd_create_locked() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Protect against send buffer overflow in NFSv3 READ Chuck Lever <chuck.lever(a)oracle.com> NFSD: Protect against send buffer overflow in NFSv2 READ Chuck Lever <chuck.lever(a)oracle.com> NFSD: Protect against send buffer overflow in NFSv3 READDIR Chuck Lever <chuck.lever(a)oracle.com> NFSD: Protect against send buffer overflow in NFSv2 READDIR Chuck Lever <chuck.lever(a)oracle.com> NFSD: Increase NFSD_MAX_OPS_PER_COMPOUND Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> nfsd: Propagate some error code returned by memdup_user() Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> nfsd: Avoid some useless tests Jinpeng Cui <cui.jinpeng2(a)zte.com.cn> NFSD: remove redundant variable status Olga Kornievskaia <kolga(a)netapp.com> NFSD enforce filehandle check for source file in COPY Wolfram Sang <wsa+renesas(a)sang-engineering.com> lockd: move from strlcpy with unused retval to strscpy Wolfram Sang <wsa+renesas(a)sang-engineering.com> NFSD: move from strlcpy with unused retval to strscpy Al Viro <viro(a)zeniv.linux.org.uk> nfsd_splice_actor(): handle compound pages NeilBrown <neilb(a)suse.de> NFSD: fix regression with setting ACLs. Jeff Layton <jlayton(a)kernel.org> lockd: detect and reject lock arguments that overflow NeilBrown <neilb(a)suse.de> NFSD: discard fh_locked flag and fh_lock/fh_unlock NeilBrown <neilb(a)suse.de> NFSD: use (un)lock_inode instead of fh_(un)lock for file operations NeilBrown <neilb(a)suse.de> NFSD: use explicit lock/unlock for directory ops NeilBrown <neilb(a)suse.de> NFSD: reduce locking in nfsd_lookup() NeilBrown <neilb(a)suse.de> NFSD: only call fh_unlock() once in nfsd_link() NeilBrown <neilb(a)suse.de> NFSD: always drop directory lock in nfsd_unlink() NeilBrown <neilb(a)suse.de> NFSD: change nfsd_create()/nfsd_symlink() to unlock directory before returning. NeilBrown <neilb(a)suse.de> NFSD: add posix ACLs to struct nfsd_attrs NeilBrown <neilb(a)suse.de> NFSD: add security label to struct nfsd_attrs NeilBrown <neilb(a)suse.de> NFSD: set attributes when creating symlinks NeilBrown <neilb(a)suse.de> NFSD: introduce struct nfsd_attrs Jeff Layton <jlayton(a)kernel.org> NFSD: verify the opened dentry after setting a delegation Jeff Layton <jlayton(a)kernel.org> NFSD: drop fh argument from alloc_init_deleg Chuck Lever <chuck.lever(a)oracle.com> NFSD: Move copy offload callback arguments into a separate structure Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add nfsd4_send_cb_offload() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Remove kmalloc from nfsd4_do_async_copy() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Refactor nfsd4_do_copy() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Refactor nfsd4_cleanup_inter_ssc() (2/2) Chuck Lever <chuck.lever(a)oracle.com> NFSD: Refactor nfsd4_cleanup_inter_ssc() (1/2) Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace boolean fields in struct nfsd4_copy Chuck Lever <chuck.lever(a)oracle.com> NFSD: Make nfs4_put_copy() static Chuck Lever <chuck.lever(a)oracle.com> NFSD: Reorder the fields in struct nfsd4_op Chuck Lever <chuck.lever(a)oracle.com> NFSD: Shrink size of struct nfsd4_copy Chuck Lever <chuck.lever(a)oracle.com> NFSD: Shrink size of struct nfsd4_copy_notify Chuck Lever <chuck.lever(a)oracle.com> NFSD: nfserrno(-ENOMEM) is nfserr_jukebox Chuck Lever <chuck.lever(a)oracle.com> NFSD: Fix strncpy() fortify warning Chuck Lever <chuck.lever(a)oracle.com> NFSD: Clean up nfsd4_encode_readlink() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Use xdr_pad_size() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Simplify starting_len Chuck Lever <chuck.lever(a)oracle.com> NFSD: Optimize nfsd4_encode_readv() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add an nfsd4_read::rd_eof field Chuck Lever <chuck.lever(a)oracle.com> NFSD: Clean up SPLICE_OK in nfsd4_encode_read() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Optimize nfsd4_encode_fattr() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Optimize nfsd4_encode_operation() Jeff Layton <jlayton(a)kernel.org> nfsd: silence extraneous printk on nfsd.ko insertion Dai Ngo <dai.ngo(a)oracle.com> NFSD: limit the number of v4 clients to 1024 per 1GB of system memory Dai Ngo <dai.ngo(a)oracle.com> NFSD: keep track of the number of v4 clients in the system Dai Ngo <dai.ngo(a)oracle.com> NFSD: refactoring v4 specific code to a helper in nfs4state.c Chuck Lever <chuck.lever(a)oracle.com> NFSD: Ensure nf_inode is never dereferenced Chuck Lever <chuck.lever(a)oracle.com> NFSD: NFSv4 CLOSE should release an nfsd_file immediately Chuck Lever <chuck.lever(a)oracle.com> NFSD: Move nfsd_file_trace_alloc() tracepoint Chuck Lever <chuck.lever(a)oracle.com> NFSD: Separate tracepoints for acquire and create Chuck Lever <chuck.lever(a)oracle.com> NFSD: Clean up unused code after rhashtable conversion Chuck Lever <chuck.lever(a)oracle.com> NFSD: Convert the filecache to use rhashtable Chuck Lever <chuck.lever(a)oracle.com> NFSD: Set up an rhashtable for the filecache Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace the "init once" mechanism Chuck Lever <chuck.lever(a)oracle.com> NFSD: Remove nfsd_file::nf_hashval Chuck Lever <chuck.lever(a)oracle.com> NFSD: nfsd_file_hash_remove can compute hashval Chuck Lever <chuck.lever(a)oracle.com> NFSD: Refactor __nfsd_file_close_inode() Chuck Lever <chuck.lever(a)oracle.com> NFSD: nfsd_file_unhash can compute hashval from nf->nf_inode Chuck Lever <chuck.lever(a)oracle.com> NFSD: Remove lockdep assertion from unhash_and_release_locked() Chuck Lever <chuck.lever(a)oracle.com> NFSD: No longer record nf_hashval in the trace log Chuck Lever <chuck.lever(a)oracle.com> NFSD: Never call nfsd_file_gc() in foreground paths Chuck Lever <chuck.lever(a)oracle.com> NFSD: Fix the filecache LRU shrinker Chuck Lever <chuck.lever(a)oracle.com> NFSD: Leave open files out of the filecache LRU Chuck Lever <chuck.lever(a)oracle.com> NFSD: Trace filecache LRU activity Chuck Lever <chuck.lever(a)oracle.com> NFSD: WARN when freeing an item still linked via nf_lru Chuck Lever <chuck.lever(a)oracle.com> NFSD: Hook up the filecache stat file Chuck Lever <chuck.lever(a)oracle.com> NFSD: Zero counters when the filecache is re-initialized Chuck Lever <chuck.lever(a)oracle.com> NFSD: Record number of flush calls Chuck Lever <chuck.lever(a)oracle.com> NFSD: Report the number of items evicted by the LRU walk Chuck Lever <chuck.lever(a)oracle.com> NFSD: Refactor nfsd_file_lru_scan() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Refactor nfsd_file_gc() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add nfsd_file_lru_dispose_list() helper Chuck Lever <chuck.lever(a)oracle.com> NFSD: Report average age of filecache items Chuck Lever <chuck.lever(a)oracle.com> NFSD: Report count of freed filecache items Chuck Lever <chuck.lever(a)oracle.com> NFSD: Report count of calls to nfsd_file_acquire() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Report filecache LRU size Chuck Lever <chuck.lever(a)oracle.com> NFSD: Demote a WARN to a pr_warn() Colin Ian King <colin.i.king(a)gmail.com> nfsd: remove redundant assignment to variable len Zhang Jiaming <jiaming(a)nfschina.com> NFSD: Fix space and spelling mistake Benjamin Coddington <bcodding(a)redhat.com> NLM: Defend against file_lock changes after vfs_test_lock() Chuck Lever <chuck.lever(a)oracle.com> SUNRPC: Fix xdr_encode_bool() Jeff Layton <jlayton(a)kernel.org> nfsd: eliminate the NFSD_FILE_BREAK_* flags Xin Gao <gaoxin(a)cdjrlc.com> fsnotify: Fix comment typo Amir Goldstein <amir73il(a)gmail.com> fanotify: introduce FAN_MARK_IGNORE Amir Goldstein <amir73il(a)gmail.com> fanotify: cleanups for fanotify_mark() input validations Amir Goldstein <amir73il(a)gmail.com> fanotify: prepare for setting event flags in ignore mask Oliver Ford <ojford(a)gmail.com> fs: inotify: Fix typo in inotify comment Jeff Layton <jlayton(a)kernel.org> lockd: fix nlm_close_files Jeff Layton <jlayton(a)kernel.org> lockd: set fl_owner when unlocking files Chuck Lever <chuck.lever(a)oracle.com> NFSD: Decode NFSv4 birth time attribute NeilBrown <neilb(a)suse.de> NFS: restore module put when manager exits. Amir Goldstein <amir73il(a)gmail.com> fanotify: refine the validation checks on non-dir inode mask Chuck Lever <chuck.lever(a)oracle.com> SUNRPC: Optimize xdr_reserve_space() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Fix potential use-after-free in nfsd_file_put() Chuck Lever <chuck.lever(a)oracle.com> NFSD: nfsd_file_put() can sleep Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add documenting comment for nfsd4_release_lockowner() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Modernize nfsd4_release_lockowner() Julian Schroeder <jumaco(a)amazon.com> nfsd: destroy percpu stats counters after reply cache shutdown Zhang Xiaoxu <zhangxiaoxu5(a)huawei.com> nfsd: Fix null-ptr-deref in nfsd_fill_super() Zhang Xiaoxu <zhangxiaoxu5(a)huawei.com> nfsd: Unregister the cld notifier when laundry_wq create failed Chuck Lever <chuck.lever(a)oracle.com> SUNRPC: Use RMW bitops in single-threaded hot paths Chuck Lever <chuck.lever(a)oracle.com> NFSD: Clean up the show_nf_flags() macro Chuck Lever <chuck.lever(a)oracle.com> NFSD: Trace filecache opens Chuck Lever <chuck.lever(a)oracle.com> NFSD: Move documenting comment for nfsd4_process_open2() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Fix whitespace Chuck Lever <chuck.lever(a)oracle.com> NFSD: Remove dprintk call sites from tail of nfsd4_open() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Instantiate a struct file when creating a regular NFSv4 file Chuck Lever <chuck.lever(a)oracle.com> NFSD: Clean up nfsd_open_verified() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Remove do_nfsd_create() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Refactor NFSv4 OPEN(CREATE) Chuck Lever <chuck.lever(a)oracle.com> NFSD: Refactor NFSv3 CREATE Chuck Lever <chuck.lever(a)oracle.com> NFSD: Refactor nfsd_create_setattr() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Avoid calling fh_drop_write() twice in do_nfsd_create() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Clean up nfsd3_proc_create() Dai Ngo <dai.ngo(a)oracle.com> NFSD: Show state of courtesy client in client info Dai Ngo <dai.ngo(a)oracle.com> NFSD: add support for lock conflict to courteous server Dai Ngo <dai.ngo(a)oracle.com> fs/lock: add 2 callbacks to lock_manager_operations to resolve conflict Dai Ngo <dai.ngo(a)oracle.com> fs/lock: add helper locks_owner_has_blockers to check for blockers Dai Ngo <dai.ngo(a)oracle.com> NFSD: move create/destroy of laundry_wq to init_nfsd and exit_nfsd Dai Ngo <dai.ngo(a)oracle.com> NFSD: add support for share reservation conflict to courteous server Dai Ngo <dai.ngo(a)oracle.com> NFSD: add courteous server support for thread with only delegation Chuck Lever <chuck.lever(a)oracle.com> NFSD: Clean up nfsd_splice_actor() Vasily Averin <vvs(a)openvz.org> fanotify: fix incorrect fmode_t casts Amir Goldstein <amir73il(a)gmail.com> fsnotify: consistent behavior for parent not watching children Amir Goldstein <amir73il(a)gmail.com> fsnotify: introduce mark type iterator Amir Goldstein <amir73il(a)gmail.com> fanotify: enable "evictable" inode marks Amir Goldstein <amir73il(a)gmail.com> fanotify: use fsnotify group lock helpers Amir Goldstein <amir73il(a)gmail.com> fanotify: implement "evictable" inode marks Amir Goldstein <amir73il(a)gmail.com> fanotify: factor out helper fanotify_mark_update_flags() Amir Goldstein <amir73il(a)gmail.com> fanotify: create helper fanotify_mark_user_flags() Amir Goldstein <amir73il(a)gmail.com> fsnotify: allow adding an inode mark without pinning inode Amir Goldstein <amir73il(a)gmail.com> dnotify: use fsnotify group lock helpers Amir Goldstein <amir73il(a)gmail.com> nfsd: use fsnotify group lock helpers Amir Goldstein <amir73il(a)gmail.com> inotify: use fsnotify group lock helpers Amir Goldstein <amir73il(a)gmail.com> fsnotify: create helpers for group mark_mutex lock Amir Goldstein <amir73il(a)gmail.com> fsnotify: make allow_dups a property of the group Amir Goldstein <amir73il(a)gmail.com> fsnotify: pass flags argument to fsnotify_alloc_group() Amir Goldstein <amir73il(a)gmail.com> inotify: move control flags from mask to mark flags Dai Ngo <dai.ngo(a)oracle.com> fs/lock: documentation cleanup. Replace inode->i_lock with flc_lock. Amir Goldstein <amir73il(a)gmail.com> fanotify: do not allow setting dirent events in mask of non-dir Trond Myklebust <trond.myklebust(a)hammerspace.com> nfsd: Clean up nfsd_file_put() Trond Myklebust <trond.myklebust(a)hammerspace.com> nfsd: Fix a write performance regression Haowen Bai <baihaowen(a)meizu.com> SUNRPC: Return true/false (not 1/0) from bool functions Bang Li <libang.linuxer(a)gmail.com> fsnotify: remove redundant parameter judgment Amir Goldstein <amir73il(a)gmail.com> fsnotify: optimize FS_MODIFY events with no ignored masks Amir Goldstein <amir73il(a)gmail.com> fsnotify: fix merge with parent's ignored mask Jakob Koschel <jakobkoschel(a)gmail.com> nfsd: fix using the correct variable for sizeof() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Clean up _lm_ operation names Chuck Lever <chuck.lever(a)oracle.com> NFSD: Remove CONFIG_NFSD_V3 Chuck Lever <chuck.lever(a)oracle.com> NFSD: Move svc_serv_ops::svo_function into struct svc_serv Chuck Lever <chuck.lever(a)oracle.com> NFSD: Remove svc_serv_ops::svo_module Chuck Lever <chuck.lever(a)oracle.com> SUNRPC: Remove svc_shutdown_net() Chuck Lever <chuck.lever(a)oracle.com> SUNRPC: Rename svc_close_xprt() Chuck Lever <chuck.lever(a)oracle.com> SUNRPC: Rename svc_create_xprt() Chuck Lever <chuck.lever(a)oracle.com> SUNRPC: Remove svo_shutdown method Chuck Lever <chuck.lever(a)oracle.com> SUNRPC: Merge svc_do_enqueue_xprt() into svc_enqueue_xprt() Chuck Lever <chuck.lever(a)oracle.com> SUNRPC: Remove the .svo_enqueue_xprt method Chuck Lever <chuck.lever(a)oracle.com> NFSD: Streamline the rare "found" case Chuck Lever <chuck.lever(a)oracle.com> NFSD: Skip extra computation for RC_NOCACHE case Chuck Lever <chuck.lever(a)oracle.com> NFSD: De-duplicate hash bucket indexing Ondrej Valousek <ondrej.valousek.xm(a)renesas.com> nfsd: Add support for the birth time attribute Chuck Lever <chuck.lever(a)oracle.com> NFSD: Deprecate NFS_OFFSET_MAX Chuck Lever <chuck.lever(a)oracle.com> NFSD: COMMIT operations must not return NFS?ERR_INVAL Chuck Lever <chuck.lever(a)oracle.com> NFSD: Fix NFSv3 SETATTR/CREATE's handling of large file sizes Chuck Lever <chuck.lever(a)oracle.com> NFSD: Fix ia_size underflow Chuck Lever <chuck.lever(a)oracle.com> NFSD: Fix the behavior of READ near OFFSET_MAX J. Bruce Fields <bfields(a)redhat.com> lockd: fix failure to cleanup client locks J. Bruce Fields <bfields(a)redhat.com> lockd: fix server crash on reboot of client holding lock Yang Li <yang.lee(a)linux.alibaba.com> fanotify: remove variable set but not used J. Bruce Fields <bfields(a)redhat.com> nfsd: fix crash on COPY_NOTIFY with special stateid Chuck Lever <chuck.lever(a)oracle.com> NFSD: Move fill_pre_wcc() and fill_post_wcc() Chuck Lever <chuck.lever(a)oracle.com> Revert "nfsd: skip some unnecessary stats in the v4 case" Chuck Lever <chuck.lever(a)oracle.com> NFSD: Trace boot verifier resets Chuck Lever <chuck.lever(a)oracle.com> NFSD: Rename boot verifier functions Chuck Lever <chuck.lever(a)oracle.com> NFSD: Clean up the nfsd_net::nfssvc_boot field Chuck Lever <chuck.lever(a)oracle.com> NFSD: Write verifier might go backwards Trond Myklebust <trond.myklebust(a)hammerspace.com> nfsd: Add a tracepoint for errors in nfsd4_clone_file_range() Chuck Lever <chuck.lever(a)oracle.com> NFSD: De-duplicate net_generic(nf->nf_net, nfsd_net_id) Chuck Lever <chuck.lever(a)oracle.com> NFSD: De-duplicate net_generic(SVC_NET(rqstp), nfsd_net_id) Chuck Lever <chuck.lever(a)oracle.com> NFSD: Clean up nfsd_vfs_write() Jeff Layton <jeff.layton(a)primarydata.com> nfsd: Retry once in nfsd_open on an -EOPENSTALE return Jeff Layton <jeff.layton(a)primarydata.com> nfsd: Add errno mapping for EREMOTEIO Peng Tao <tao.peng(a)primarydata.com> nfsd: map EBADF Chuck Lever <chuck.lever(a)oracle.com> NFSD: Fix zero-length NFSv3 WRITEs Vasily Averin <vvs(a)virtuozzo.com> nfsd4: add refcount for nfsd4_blocked_lock J. Bruce Fields <bfields(a)redhat.com> nfs: block notification on fs with its own ->lock Chuck Lever <chuck.lever(a)oracle.com> NFSD: De-duplicate nfsd4_decode_bitmap4() J. Bruce Fields <bfields(a)redhat.com> nfsd: improve stateid access bitmask documentation Chuck Lever <chuck.lever(a)oracle.com> NFSD: Combine XDR error tracepoints NeilBrown <neilb(a)suse.de> NFSD: simplify per-net file cache management Jiapeng Chong <jiapeng.chong(a)linux.alibaba.com> NFSD: Fix inconsistent indenting Chuck Lever <chuck.lever(a)oracle.com> NFSD: Remove be32_to_cpu() from DRC hash function NeilBrown <neilb(a)suse.de> NFS: switch the callback service back to non-pooled. NeilBrown <neilb(a)suse.de> lockd: use svc_set_num_threads() for thread start and stop NeilBrown <neilb(a)suse.de> SUNRPC: always treat sv_nrpools==1 as "not pooled" NeilBrown <neilb(a)suse.de> SUNRPC: move the pool_map definitions (back) into svc.c NeilBrown <neilb(a)suse.de> lockd: rename lockd_create_svc() to lockd_get() NeilBrown <neilb(a)suse.de> lockd: introduce lockd_put() NeilBrown <neilb(a)suse.de> lockd: move svc_exit_thread() into the thread NeilBrown <neilb(a)suse.de> lockd: move lockd_start_svc() call into lockd_create_svc() NeilBrown <neilb(a)suse.de> lockd: simplify management of network status notifiers NeilBrown <neilb(a)suse.de> lockd: introduce nlmsvc_serv NeilBrown <neilb(a)suse.de> NFSD: simplify locking for network notifier. NeilBrown <neilb(a)suse.de> SUNRPC: discard svo_setup and rename svc_set_num_threads_sync() NeilBrown <neilb(a)suse.de> NFSD: Make it possible to use svc_set_num_threads_sync NeilBrown <neilb(a)suse.de> NFSD: narrow nfsd_mutex protection in nfsd thread NeilBrown <neilb(a)suse.de> SUNRPC: use sv_lock to protect updates to sv_nrthreads. NeilBrown <neilb(a)suse.de> nfsd: make nfsd_stats.th_cnt atomic_t NeilBrown <neilb(a)suse.de> SUNRPC: stop using ->sv_nrthreads as a refcount NeilBrown <neilb(a)suse.de> SUNRPC/NFSD: clean up get/put functions. NeilBrown <neilb(a)suse.de> SUNRPC: change svc_get() to return the svc. NeilBrown <neilb(a)suse.de> NFSD: handle errors better in write_ports_addfd() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Fix sparse warning Eric W. Biederman <ebiederm(a)xmission.com> exit: Rename module_put_and_exit to module_put_and_kthread_exit Eric W. Biederman <ebiederm(a)xmission.com> exit: Implement kthread_exit Amir Goldstein <amir73il(a)gmail.com> fanotify: wire up FAN_RENAME event Amir Goldstein <amir73il(a)gmail.com> fanotify: report old and/or new parent+name in FAN_RENAME event Amir Goldstein <amir73il(a)gmail.com> fanotify: record either old name new name or both for FAN_RENAME Amir Goldstein <amir73il(a)gmail.com> fanotify: record old and new parent and name in FAN_RENAME event Amir Goldstein <amir73il(a)gmail.com> fanotify: support secondary dir fh and name in fanotify_info Amir Goldstein <amir73il(a)gmail.com> fanotify: use helpers to parcel fanotify_info buffer Amir Goldstein <amir73il(a)gmail.com> fanotify: use macros to get the offset to fanotify_info buffer Amir Goldstein <amir73il(a)gmail.com> fsnotify: generate FS_RENAME event with rich information Amir Goldstein <amir73il(a)gmail.com> fanotify: introduce group flag FAN_REPORT_TARGET_FID Amir Goldstein <amir73il(a)gmail.com> fsnotify: separate mark iterator type from object type enum Amir Goldstein <amir73il(a)gmail.com> fsnotify: clarify object type argument Chuck Lever <chuck.lever(a)oracle.com> NFSD: Fix READDIR buffer overflow Chuck Lever <chuck.lever(a)oracle.com> NFSD: Fix exposure in nfsd4_decode_bitmap() J. Bruce Fields <bfields(a)redhat.com> nfsd4: remove obselete comment Changcheng Deng <deng.changcheng(a)zte.com.cn> NFSD:fix boolreturn.cocci warning J. Bruce Fields <bfields(a)redhat.com> nfsd: update create verifier comment Chuck Lever <chuck.lever(a)oracle.com> SUNRPC: Change return value type of .pc_encode Chuck Lever <chuck.lever(a)oracle.com> SUNRPC: Replace the "__be32 *p" parameter to .pc_encode Chuck Lever <chuck.lever(a)oracle.com> NFSD: Save location of NFSv4 COMPOUND status Chuck Lever <chuck.lever(a)oracle.com> SUNRPC: Change return value type of .pc_decode Chuck Lever <chuck.lever(a)oracle.com> SUNRPC: Replace the "__be32 *p" parameter to .pc_decode Chuck Lever <chuck.lever(a)oracle.com> NFSD: Have legacy NFSD WRITE decoders use xdr_stream_subsegment() Colin Ian King <colin.king(a)canonical.com> NFSD: Initialize pointer ni with NULL and not plain integer 0 NeilBrown <neilb(a)suse.de> NFSD: simplify struct nfsfh NeilBrown <neilb(a)suse.de> NFSD: drop support for ancient filehandles NeilBrown <neilb(a)suse.de> NFSD: move filehandle format declarations out of "uapi". Chuck Lever <chuck.lever(a)oracle.com> NFSD: Optimize DRC bucket pruning Chuck Lever <chuck.lever(a)oracle.com> SUNRPC: Trace calls to .rpc_call_done Gabriel Krisman Bertazi <krisman(a)collabora.com> fanotify: Allow users to request FAN_FS_ERROR events Gabriel Krisman Bertazi <krisman(a)collabora.com> fanotify: Emit generic error info for error event Gabriel Krisman Bertazi <krisman(a)collabora.com> fanotify: Report fid info for file related file system errors Gabriel Krisman Bertazi <krisman(a)collabora.com> fanotify: WARN_ON against too large file handles Gabriel Krisman Bertazi <krisman(a)collabora.com> fanotify: Add helpers to decide whether to report FID/DFID Gabriel Krisman Bertazi <krisman(a)collabora.com> fanotify: Wrap object_fh inline space in a creator macro Gabriel Krisman Bertazi <krisman(a)collabora.com> fanotify: Support merging of error events Gabriel Krisman Bertazi <krisman(a)collabora.com> fanotify: Support enqueueing of error events Gabriel Krisman Bertazi <krisman(a)collabora.com> fanotify: Pre-allocate pool of error events Gabriel Krisman Bertazi <krisman(a)collabora.com> fanotify: Reserve UAPI bits for FAN_FS_ERROR Gabriel Krisman Bertazi <krisman(a)collabora.com> fsnotify: Support FS_ERROR event type Gabriel Krisman Bertazi <krisman(a)collabora.com> fanotify: Require fid_mode for any non-fd event Gabriel Krisman Bertazi <krisman(a)collabora.com> fanotify: Encode empty file handle when no inode is provided Gabriel Krisman Bertazi <krisman(a)collabora.com> fanotify: Allow file handle encoding for unhashed events Gabriel Krisman Bertazi <krisman(a)collabora.com> fanotify: Support null inode event in fanotify_dfid_inode Gabriel Krisman Bertazi <krisman(a)collabora.com> fsnotify: Pass group argument to free_event Gabriel Krisman Bertazi <krisman(a)collabora.com> fsnotify: Protect fsnotify_handle_inode_event from no-inode events Gabriel Krisman Bertazi <krisman(a)collabora.com> fsnotify: Retrieve super block from the data field Gabriel Krisman Bertazi <krisman(a)collabora.com> fsnotify: Add wrapper around fsnotify_add_event Gabriel Krisman Bertazi <krisman(a)collabora.com> fsnotify: Add helper to detect overflow_event Gabriel Krisman Bertazi <krisman(a)collabora.com> inotify: Don't force FS_IN_IGNORED Gabriel Krisman Bertazi <krisman(a)collabora.com> fanotify: Split fsid check from other fid mode checks Gabriel Krisman Bertazi <krisman(a)collabora.com> fanotify: Fold event size calculation to its own function Gabriel Krisman Bertazi <krisman(a)collabora.com> fsnotify: Don't insert unmergeable events in hashtable Amir Goldstein <amir73il(a)gmail.com> fsnotify: clarify contract for create event hooks Amir Goldstein <amir73il(a)gmail.com> fsnotify: pass dentry instead of inode data Amir Goldstein <amir73il(a)gmail.com> fsnotify: pass data_type to fsnotify_name() Trond Myklebust <trond.myklebust(a)hammerspace.com> nfsd: Fix a warning for nfsd_file_close_inode Chuck Lever <chuck.lever(a)oracle.com> NLM: Fix svcxdr_encode_owner() Amir Goldstein <amir73il(a)gmail.com> fsnotify: fix sb_connectors leak Chuck Lever <chuck.lever(a)oracle.com> NFS: Remove unused callback void decoder Chuck Lever <chuck.lever(a)oracle.com> NFS: Add a private local dispatcher for NFSv4 callback operations Chuck Lever <chuck.lever(a)oracle.com> SUNRPC: Eliminate the RQ_AUTHERR flag Chuck Lever <chuck.lever(a)oracle.com> SUNRPC: Set rq_auth_stat in the pg_authenticate() callout Chuck Lever <chuck.lever(a)oracle.com> SUNRPC: Add svc_rqst::rq_auth_stat J. Bruce Fields <bfields(a)redhat.com> nfs: don't allow reexport reclaims J. Bruce Fields <bfields(a)redhat.com> lockd: don't attempt blocking locks on nfs reexports J. Bruce Fields <bfields(a)redhat.com> nfs: don't atempt blocking locks on nfs reexports J. Bruce Fields <bfields(a)redhat.com> Keep read and write fds with each nlm_file J. Bruce Fields <bfields(a)redhat.com> lockd: update nlm_lookup_file reexport comment J. Bruce Fields <bfields(a)redhat.com> nlm: minor refactoring J. Bruce Fields <bfields(a)redhat.com> nlm: minor nlm_lookup_file argument change Jia He <hejianet(a)gmail.com> lockd: change the proc_handler for nsm_use_hostnames Jia He <hejianet(a)gmail.com> sysctl: introduce new proc handler proc_dobool NeilBrown <neilb(a)suse.de> NFSD: remove vanity comments Chuck Lever <chuck.lever(a)oracle.com> NFSD: Batch release pages during splice read Chuck Lever <chuck.lever(a)oracle.com> SUNRPC: Add svc_rqst_replace_page() API Chuck Lever <chuck.lever(a)oracle.com> NFSD: Clean up splice actor Amir Goldstein <amir73il(a)gmail.com> fsnotify: optimize the case of no marks of any type Amir Goldstein <amir73il(a)gmail.com> fsnotify: count all objects with attached connectors Amir Goldstein <amir73il(a)gmail.com> fsnotify: count s_fsnotify_inode_refs for attached connectors Amir Goldstein <amir73il(a)gmail.com> fsnotify: replace igrab() with ihold() on attach connector Matthew Bobrowski <repnop(a)google.com> fanotify: add pidfd support to the fanotify API Matthew Bobrowski <repnop(a)google.com> fanotify: introduce a generic info record copying helper Matthew Bobrowski <repnop(a)google.com> fanotify: minor cosmetic adjustments to fid labels Matthew Bobrowski <repnop(a)google.com> kernel/pid.c: implement additional checks upon pidfd_create() parameters Matthew Bobrowski <repnop(a)google.com> kernel/pid.c: remove static qualifier from pidfd_create() J. Bruce Fields <bfields(a)redhat.com> nfsd: fix NULL dereference in nfs3svc_encode_getaclres Chuck Lever <chuck.lever(a)oracle.com> NFSD: Prevent a possible oops in the nfs_dirent() tracepoint Colin Ian King <colin.king(a)canonical.com> nfsd: remove redundant assignment to pointer 'this' Chuck Lever <chuck.lever(a)oracle.com> lockd: Update the NLMv4 SHARE results encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> lockd: Update the NLMv4 nlm_res results encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> lockd: Update the NLMv4 TEST results encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> lockd: Update the NLMv4 void results encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> lockd: Update the NLMv4 FREE_ALL arguments decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> lockd: Update the NLMv4 SHARE arguments decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> lockd: Update the NLMv4 SM_NOTIFY arguments decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> lockd: Update the NLMv4 nlm_res arguments decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> lockd: Update the NLMv4 UNLOCK arguments decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> lockd: Update the NLMv4 CANCEL arguments decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> lockd: Update the NLMv4 LOCK arguments decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> lockd: Update the NLMv4 TEST arguments decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> lockd: Update the NLMv4 void arguments decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> lockd: Update the NLMv1 SHARE results encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> lockd: Update the NLMv1 nlm_res results encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> lockd: Update the NLMv1 TEST results encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> lockd: Update the NLMv1 void results encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> lockd: Update the NLMv1 FREE_ALL arguments decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> lockd: Update the NLMv1 SHARE arguments decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> lockd: Update the NLMv1 SM_NOTIFY arguments decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> lockd: Update the NLMv1 nlm_res arguments decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> lockd: Update the NLMv1 UNLOCK arguments decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> lockd: Update the NLMv1 CANCEL arguments decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> lockd: Update the NLMv1 LOCK arguments decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> lockd: Update the NLMv1 TEST arguments decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> lockd: Update the NLMv1 void argument decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> lockd: Common NLM XDR helpers Chuck Lever <chuck.lever(a)oracle.com> lockd: Create a simplified .vs_dispatch method for NLM requests Chuck Lever <chuck.lever(a)oracle.com> lockd: Remove stale comments J. Bruce Fields <bfields(a)redhat.com> nfsd: rpc_peeraddr2str needs rcu lock Wei Yongjun <weiyongjun1(a)huawei.com> NFSD: Fix error return code in nfsd4_interssc_connect() Dai Ngo <dai.ngo(a)oracle.com> nfsd: fix kernel test robot warning in SSC code Dave Wysochanski <dwysocha(a)redhat.com> nfsd4: Expose the callback address and state of each NFS4 client J. Bruce Fields <bfields(a)redhat.com> nfsd: move fsnotify on client creation outside spinlock Dai Ngo <dai.ngo(a)oracle.com> NFSD: delay unmount source's export after inter-server copy completed. Olga Kornievskaia <kolga(a)netapp.com> NFSD add vfs_fsync after async copy is done J. Bruce Fields <bfields(a)redhat.com> nfsd: move some commit_metadata()s outside the inode lock Yu Hsiang Huang <nickhuang(a)synology.com> nfsd: Prevent truncation of an unlinked inode from blocking access to its directory Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update nfsd_cb_args tracepoint Chuck Lever <chuck.lever(a)oracle.com> NFSD: Remove the nfsd_cb_work and nfsd_cb_done tracepoints Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add an nfsd_cb_probe tracepoint Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace the nfsd_deleg_break tracepoint Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add an nfsd_cb_offload tracepoint Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add an nfsd_cb_lm_notify tracepoint Chuck Lever <chuck.lever(a)oracle.com> NFSD: Enhance the nfsd_cb_setup tracepoint Chuck Lever <chuck.lever(a)oracle.com> NFSD: Adjust cb_shutdown tracepoint Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add cb_lost tracepoint Chuck Lever <chuck.lever(a)oracle.com> NFSD: Drop TRACE_DEFINE_ENUM for NFSD4_CB_<state> macros Chuck Lever <chuck.lever(a)oracle.com> NFSD: Capture every CB state transition Chuck Lever <chuck.lever(a)oracle.com> NFSD: Constify @fh argument of knfsd_fh_hash() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add tracepoints for EXCHANGEID edge cases Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add tracepoints for SETCLIENTID edge cases Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add a couple more nfsd_clid_expired call sites Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add nfsd_clid_destroyed tracepoint Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add nfsd_clid_reclaim_complete tracepoint Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add nfsd_clid_confirmed tracepoint Chuck Lever <chuck.lever(a)oracle.com> NFSD: Remove trace_nfsd_clid_inuse_err Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add nfsd_clid_verf_mismatch tracepoint Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add nfsd_clid_cred_mismatch tracepoint Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add an RPC authflavor tracepoint display helper Amir Goldstein <amir73il(a)gmail.com> fanotify: fix permission model of unprivileged group Trond Myklebust <trond.myklebust(a)hammerspace.com> NFS: fix nfs_fetch_iversion() Dai Ngo <dai.ngo(a)oracle.com> NFSv4.2: Remove ifdef CONFIG_NFSD from NFSv4.2 client SSC code. Gustavo A. R. Silva <gustavoars(a)kernel.org> nfsd: Fix fall-through warnings for Clang J. Bruce Fields <bfields(a)redhat.com> nfsd: grant read delegations to clients holding writes J. Bruce Fields <bfields(a)redhat.com> nfsd: reshuffle some code J. Bruce Fields <bfields(a)redhat.com> nfsd: track filehandle aliasing in nfs4_files J. Bruce Fields <bfields(a)redhat.com> nfsd: hash nfs4_files by inode number Vasily Averin <vvs(a)virtuozzo.com> nfsd: removed unused argument in nfsd_startup_generic() Jiapeng Chong <jiapeng.chong(a)linux.alibaba.com> nfsd: remove unused function Christian Brauner <christian.brauner(a)ubuntu.com> fanotify_user: use upper_32_bits() to verify mask Amir Goldstein <amir73il(a)gmail.com> fanotify: support limited functionality for unprivileged users Amir Goldstein <amir73il(a)gmail.com> fanotify: configurable limits via sysfs Amir Goldstein <amir73il(a)gmail.com> fanotify: limit number of event merge attempts Amir Goldstein <amir73il(a)gmail.com> fsnotify: use hash table for faster events merge Amir Goldstein <amir73il(a)gmail.com> fanotify: mix event info and pid into merge key hash Amir Goldstein <amir73il(a)gmail.com> fanotify: reduce event objectid to 29-bit hash Chuck Lever <chuck.lever(a)oracle.com> Revert "fanotify: limit number of event merge attempts" Amir Goldstein <amir73il(a)gmail.com> fsnotify: allow fsnotify_{peek,remove}_first_event with empty queue Guobin Huang <huangguobin4(a)huawei.com> NFSD: Use DEFINE_SPINLOCK() for spinlock Gustavo A. R. Silva <gustavoars(a)kernel.org> UAPI: nfsfh.h: Replace one-element array with flexible-array member Chuck Lever <chuck.lever(a)oracle.com> SUNRPC: Export svc_xprt_received() NeilBrown <neilb(a)suse.de> nfsd: report client confirmation status in "info" file J. Bruce Fields <bfields(a)redhat.com> nfsd: don't ignore high bits of copy count J. Bruce Fields <bfields(a)redhat.com> nfsd: COPY with length 0 should copy to end of file Ricardo Ribalda <ribalda(a)chromium.org> nfsd: Fix typo "accesible" Paul Menzel <pmenzel(a)molgen.mpg.de> nfsd: Log client tracking type log message as info instead of warning J. Bruce Fields <bfields(a)redhat.com> nfsd: helper for laundromat expiry calculations Chuck Lever <chuck.lever(a)oracle.com> NFSD: Clean up NFSDDBG_FACILITY macro Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add a tracepoint to record directory entry encoding Chuck Lever <chuck.lever(a)oracle.com> NFSD: Clean up after updating NFSv3 ACL encoders Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv3 SETACL result encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv3 GETACL result encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Clean up after updating NFSv2 ACL encoders Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv2 ACL ACCESS result encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv2 ACL GETATTR result encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv2 SETACL result encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv2 GETACL result encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add an xdr_stream-based encoder for NFSv2/3 ACLs Chuck Lever <chuck.lever(a)oracle.com> NFSD: Remove unused NFSv2 directory entry encoders Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv2 READDIR entry encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv2 READDIR result encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Count bytes instead of pages in the NFSv2 READDIR encoder Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add a helper that encodes NFSv3 directory offset cookies, again Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv2 STATFS result encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv2 READ result encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv2 READLINK result encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv2 diropres encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv2 attrstat encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv2 stat encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Reduce svc_rqst::rq_pages churn during READDIR operations Chuck Lever <chuck.lever(a)oracle.com> NFSD: Remove unused NFSv3 directory entry encoders Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update NFSv3 READDIR entry encoders to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv3 READDIR3res encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Count bytes instead of pages in the NFSv3 READDIR encoder Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add a helper that encodes NFSv3 directory offset cookies Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv3 COMMIT3res encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv3 PATHCONF3res encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv3 FSINFO3res encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv3 FSSTAT3res encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv3 LINK3res encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv3 RENAMEv3res encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv3 CREATE family of encoders to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv3 WRITE3res encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv3 READ3res encode to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv3 READLINK3res encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv3 wccstat result encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv3 LOOKUP3res encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv3 ACCESS3res encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the GETATTR3res encoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Extract the svcxdr_init_encode() helper Christian Brauner <christian.brauner(a)ubuntu.com> namei: introduce struct renamedata Christian Brauner <christian.brauner(a)ubuntu.com> fs: add file and path permissions helpers Christoph Hellwig <hch(a)lst.de> kallsyms: only build {,module_}kallsyms_on_each_symbol when required Christoph Hellwig <hch(a)lst.de> kallsyms: refactor {,module_}kallsyms_on_each_symbol Christoph Hellwig <hch(a)lst.de> module: use RCU to synchronize find_module Christoph Hellwig <hch(a)lst.de> module: unexport find_module and module_mutex Shakeel Butt <shakeelb(a)google.com> inotify, memcg: account inotify instances to kmemcg J. Bruce Fields <bfields(a)redhat.com> nfsd: skip some unnecessary stats in the v4 case J. Bruce Fields <bfields(a)redhat.com> nfs: use change attribute for NFS re-exports Dai Ngo <dai.ngo(a)oracle.com> NFSv4_2: SSC helper should use its own config. J. Bruce Fields <bfields(a)redhat.com> nfsd: cstate->session->se_client -> cstate->clp J. Bruce Fields <bfields(a)redhat.com> nfsd: simplify nfsd4_check_open_reclaim J. Bruce Fields <bfields(a)redhat.com> nfsd: remove unused set_client argument J. Bruce Fields <bfields(a)redhat.com> nfsd: find_cpntf_state cleanup J. Bruce Fields <bfields(a)redhat.com> nfsd: refactor set_client J. Bruce Fields <bfields(a)redhat.com> nfsd: rename lookup_clientid->set_client J. Bruce Fields <bfields(a)redhat.com> nfsd: simplify nfsd_renew J. Bruce Fields <bfields(a)redhat.com> nfsd: simplify process_lock J. Bruce Fields <bfields(a)redhat.com> nfsd4: simplify process_lookup1 Amir Goldstein <amir73il(a)gmail.com> nfsd: report per-export stats Amir Goldstein <amir73il(a)gmail.com> nfsd: protect concurrent access to nfsd stats counters Amir Goldstein <amir73il(a)gmail.com> nfsd: remove unused stats counters Chuck Lever <chuck.lever(a)oracle.com> NFSD: Clean up after updating NFSv3 ACL decoders Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv2 SETACL argument decoder to use struct xdr_stream, again Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv3 GETACL argument decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Clean up after updating NFSv2 ACL decoders Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv2 ACL ACCESS argument decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv2 ACL GETATTR argument decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv2 SETACL argument decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add an xdr_stream-based decoder for NFSv2/3 ACLs Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv2 GETACL argument decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Remove argument length checking in nfsd_dispatch() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv2 SYMLINK argument decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv2 CREATE argument decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv2 SETATTR argument decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv2 LINK argument decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv2 RENAME argument decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update NFSv2 diropargs decoding to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv2 READDIR argument decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add helper to set up the pages where the dirlist is encoded, again Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv2 READLINK argument decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv2 WRITE argument decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv2 READ argument decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv2 GETATTR argument decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the MKNOD3args decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the SYMLINK3args decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the MKDIR3args decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the CREATE3args decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the SETATTR3args decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the LINK3args decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the RENAME3args decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update the NFSv3 DIROPargs decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update COMMIT3arg decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update READDIR3args decoders to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add helper to set up the pages where the dirlist is encoded Chuck Lever <chuck.lever(a)oracle.com> NFSD: Fix returned READDIR offset cookie Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update READLINK3arg decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update WRITE3arg decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update READ3arg decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update ACCESS3arg decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> NFSD: Update GETATTR3args decoder to use struct xdr_stream Chuck Lever <chuck.lever(a)oracle.com> SUNRPC: Move definition of XDR_UNIT Chuck Lever <chuck.lever(a)oracle.com> SUNRPC: Display RPC procedure names instead of proc numbers Chuck Lever <chuck.lever(a)oracle.com> SUNRPC: Make trace_svc_process() display the RPC procedure symbolically Chuck Lever <chuck.lever(a)oracle.com> NFSD: Restore NFSv4 decoding's SAVEMEM functionality Chuck Lever <chuck.lever(a)oracle.com> NFSD: Fix sparse warning in nfssvc.c Zheng Yongjun <zhengyongjun3(a)huawei.com> fs/lockd: convert comma to semicolon Waiman Long <longman(a)redhat.com> inotify: Increase default inotify.max_user_watches limit to 1048576 Eric W. Biederman <ebiederm(a)xmission.com> file: Replace ksys_close with close_fd Eric W. Biederman <ebiederm(a)xmission.com> file: Rename __close_fd to close_fd and remove the files parameter Eric W. Biederman <ebiederm(a)xmission.com> file: Merge __alloc_fd into alloc_fd Eric W. Biederman <ebiederm(a)xmission.com> file: In f_dupfd read RLIMIT_NOFILE once. Eric W. Biederman <ebiederm(a)xmission.com> file: Merge __fd_install into fd_install Eric W. Biederman <ebiederm(a)xmission.com> proc/fd: In fdinfo seq_show don't use get_files_struct Eric W. Biederman <ebiederm(a)xmission.com> proc/fd: In proc_readfd_common use task_lookup_next_fd_rcu Eric W. Biederman <ebiederm(a)xmission.com> file: Implement task_lookup_next_fd_rcu Eric W. Biederman <ebiederm(a)xmission.com> kcmp: In get_file_raw_ptr use task_lookup_fd_rcu Eric W. Biederman <ebiederm(a)xmission.com> proc/fd: In tid_fd_mode use task_lookup_fd_rcu Eric W. Biederman <ebiederm(a)xmission.com> file: Implement task_lookup_fd_rcu Eric W. Biederman <ebiederm(a)xmission.com> file: Rename fcheck lookup_fd_rcu Eric W. Biederman <ebiederm(a)xmission.com> file: Replace fcheck_files with files_lookup_fd_rcu Eric W. Biederman <ebiederm(a)xmission.com> file: Factor files_lookup_fd_locked out of fcheck_files Eric W. Biederman <ebiederm(a)xmission.com> file: Rename __fcheck_files to files_lookup_fd_raw Chuck Lever <chuck.lever(a)oracle.com> Revert "fget: clarify and improve __fget_files() implementation" Eric W. Biederman <ebiederm(a)xmission.com> proc/fd: In proc_fd_link use fget_task Eric W. Biederman <ebiederm(a)xmission.com> bpf: In bpf_task_fd_query use fget_task Eric W. Biederman <ebiederm(a)xmission.com> kcmp: In kcmp_epoll_target use fget_task Eric W. Biederman <ebiederm(a)xmission.com> exec: Remove reset_files_struct Eric W. Biederman <ebiederm(a)xmission.com> exec: Simplify unshare_files Eric W. Biederman <ebiederm(a)xmission.com> exec: Move unshare_files to fix posix file locking during exec Eric W. Biederman <ebiederm(a)xmission.com> exec: Don't open code get_close_on_exec Trond Myklebust <trond.myklebust(a)hammerspace.com> nfsd: Record NFSv4 pre/post-op attributes as non-atomic Trond Myklebust <trond.myklebust(a)hammerspace.com> nfsd: Set PF_LOCAL_THROTTLE on local filesystems only Trond Myklebust <trond.myklebust(a)hammerspace.com> nfsd: Fix up nfsd to ensure that timeout errors don't result in ESTALE Trond Myklebust <trond.myklebust(a)hammerspace.com> exportfs: Add a function to return the raw output from fh_to_dentry() Jeff Layton <jeff.layton(a)primarydata.com> nfsd: close cached files prior to a REMOVE or RENAME that would replace target Jeff Layton <jeff.layton(a)primarydata.com> nfsd: allow filesystems to opt out of subtree checking Jeff Layton <jeff.layton(a)primarydata.com> nfsd: add a new EXPORT_OP_NOWCC flag to struct export_operations J. Bruce Fields <bfields(a)redhat.com> Revert "nfsd4: support change_attr_type attribute" J. Bruce Fields <bfields(a)redhat.com> nfsd4: don't query change attribute in v2/v3 case J. Bruce Fields <bfields(a)redhat.com> nfsd: minor nfsd4_change_attribute cleanup J. Bruce Fields <bfields(a)redhat.com> nfsd: simplify nfsd4_change_info J. Bruce Fields <bfields(a)redhat.com> nfsd: only call inode_query_iversion in the I_VERSION case Chuck Lever <chuck.lever(a)oracle.com> NFSD: Remove macros that are no longer used Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_compound() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Make nfsd4_ops::opnum a u32 Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_listxattrs() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_setxattr() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_xattr_name() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_clone() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_seek() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_offload_status() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_copy_notify() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_copy() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_nl4_server() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_fallocate() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_reclaim_complete() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_destroy_clientid() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_test_stateid() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_sequence() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_secinfo_no_name() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_layoutreturn() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_layoutget() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_layoutcommit() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_getdeviceinfo() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_free_stateid() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_destroy_session() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_create_session() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add a helper to decode channel_attrs4 Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add a helper to decode nfs_impl_id4 Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add a helper to decode state_protect4_a Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add a separate decoder for ssv_sp_parms Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add a separate decoder to handle state_protect_ops Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_bind_conn_to_session() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_backchannel_ctl() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_cb_sec() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_release_lockowner() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_write() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_verify() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_setclientid_confirm() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_setclientid() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_setattr() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_secinfo() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_renew() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_rename() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_remove() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_readdir() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_read() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_putfh() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_open_downgrade() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_open_confirm() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_open() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add helper to decode OPEN's open_claim4 argument Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_share_deny() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_share_access() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add helper to decode OPEN's openflag4 argument Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add helper to decode OPEN's createhow4 argument Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add helper to decode NFSv4 verifiers Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_lookup() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_locku() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_lockt() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_lock() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add helper for decoding locker4 Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add helpers to decode a clientid4 and an NFSv4 state owner Chuck Lever <chuck.lever(a)oracle.com> NFSD: Relocate nfsd4_decode_opaque() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_link() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_getattr() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_delegreturn() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_create() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_fattr() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros that decode the fattr4 umask attribute Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros that decode the fattr4 security label attribute Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros that decode the fattr4 time_set attributes Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros that decode the fattr4 owner_group attribute Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros that decode the fattr4 owner attribute Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros that decode the fattr4 mode attribute Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros that decode the fattr4 acl attribute Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros that decode the fattr4 size attribute Chuck Lever <chuck.lever(a)oracle.com> NFSD: Change the way the expected length of a fattr4 is checked Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_commit() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_close() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace READ* macros in nfsd4_decode_access() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Replace the internals of the READ_BUF() macro Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add tracepoints in nfsd4_decode/encode_compound() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add tracepoints in nfsd_dispatch() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add common helpers to decode void args and encode void results Chuck Lever <chuck.lever(a)oracle.com> SUNRPC: Prepare for xdr_stream-style decoding on the server-side Chuck Lever <chuck.lever(a)oracle.com> SUNRPC: Add xdr_set_scratch_page() and xdr_reset_scratch_buffer() Huang Guobin <huangguobin4(a)huawei.com> nfsd: Fix error return code in nfsd_file_cache_init() Chuck Lever <chuck.lever(a)oracle.com> NFSD: Add SPDX header for fs/nfsd/trace.c Chuck Lever <chuck.lever(a)oracle.com> NFSD: Remove extra "0x" in tracepoint format specifier Chuck Lever <chuck.lever(a)oracle.com> NFSD: Clean up the show_nf_may macro Alex Shi <alex.shi(a)linux.alibaba.com> nfsd/nfs3: remove unused macro nfsd3_fhandleres Tom Rix <trix(a)redhat.com> NFSD: A semicolon is not needed after a switch statement. Chuck Lever <chuck.lever(a)oracle.com> NFSD: Invoke svc_encode_result_payload() in "read" NFSD encoders Chuck Lever <chuck.lever(a)oracle.com> SUNRPC: Rename svc_encode_read_payload() ------------- Diffstat: Documentation/filesystems/files.rst | 8 +- Documentation/filesystems/locking.rst | 10 +- Documentation/filesystems/nfs/exporting.rst | 78 + Makefile | 4 +- arch/powerpc/platforms/cell/spufs/coredump.c | 2 +- crypto/algboss.c | 4 +- fs/Kconfig | 6 +- fs/autofs/dev-ioctl.c | 5 +- fs/cachefiles/namei.c | 9 +- fs/cifs/connect.c | 2 +- fs/coredump.c | 5 +- fs/ecryptfs/inode.c | 10 +- fs/exec.c | 29 +- fs/exportfs/expfs.c | 40 +- fs/file.c | 177 +- fs/init.c | 6 +- fs/lockd/clnt4xdr.c | 9 +- fs/lockd/clntproc.c | 3 - fs/lockd/host.c | 4 +- fs/lockd/svc.c | 262 +- fs/lockd/svc4proc.c | 70 +- fs/lockd/svclock.c | 67 +- fs/lockd/svcproc.c | 62 +- fs/lockd/svcsubs.c | 123 +- fs/lockd/svcxdr.h | 142 + fs/lockd/xdr.c | 448 +-- fs/lockd/xdr4.c | 472 ++-- fs/locks.c | 102 +- fs/namei.c | 21 +- fs/nfs/blocklayout/blocklayout.c | 2 +- fs/nfs/blocklayout/dev.c | 2 +- fs/nfs/callback.c | 111 +- fs/nfs/callback_xdr.c | 33 +- fs/nfs/dir.c | 2 +- fs/nfs/export.c | 17 + fs/nfs/file.c | 3 + fs/nfs/filelayout/filelayout.c | 4 +- fs/nfs/filelayout/filelayoutdev.c | 2 +- fs/nfs/flexfilelayout/flexfilelayout.c | 4 +- fs/nfs/flexfilelayout/flexfilelayoutdev.c | 2 +- fs/nfs/nfs42xdr.c | 2 +- fs/nfs/nfs4state.c | 2 +- fs/nfs/nfs4xdr.c | 6 +- fs/nfs/pagelist.c | 3 - fs/nfs/super.c | 8 + fs/nfs/write.c | 3 - fs/nfs_common/Makefile | 2 +- fs/nfs_common/nfs_ssc.c | 2 - fs/nfs_common/nfsacl.c | 123 + fs/nfsd/Kconfig | 36 +- fs/nfsd/Makefile | 8 +- fs/nfsd/acl.h | 6 +- fs/nfsd/blocklayout.c | 1 + fs/nfsd/blocklayoutxdr.c | 1 + fs/nfsd/cache.h | 2 +- fs/nfsd/export.c | 74 +- fs/nfsd/export.h | 16 +- fs/nfsd/filecache.c | 1229 +++++---- fs/nfsd/filecache.h | 23 +- fs/nfsd/flexfilelayout.c | 3 +- fs/nfsd/lockd.c | 10 +- fs/nfsd/netns.h | 63 +- fs/nfsd/nfs2acl.c | 214 +- fs/nfsd/nfs3acl.c | 140 +- fs/nfsd/nfs3proc.c | 396 ++- fs/nfsd/nfs3xdr.c | 1763 ++++++------ fs/nfsd/nfs4acl.c | 45 +- fs/nfsd/nfs4callback.c | 168 +- fs/nfsd/nfs4idmap.c | 9 +- fs/nfsd/nfs4layouts.c | 4 +- fs/nfsd/nfs4proc.c | 1111 +++++--- fs/nfsd/nfs4recover.c | 20 +- fs/nfsd/nfs4state.c | 1725 ++++++++---- fs/nfsd/nfs4xdr.c | 3763 ++++++++++++++------------ fs/nfsd/nfscache.c | 115 +- fs/nfsd/nfsctl.c | 169 +- fs/nfsd/nfsd.h | 50 +- fs/nfsd/nfsfh.c | 291 +- fs/nfsd/nfsfh.h | 179 +- fs/nfsd/nfsproc.c | 262 +- fs/nfsd/nfssvc.c | 356 ++- fs/nfsd/nfsxdr.c | 834 +++--- fs/nfsd/state.h | 69 +- fs/nfsd/stats.c | 126 +- fs/nfsd/stats.h | 96 +- fs/nfsd/trace.c | 1 + fs/nfsd/trace.h | 894 +++++- fs/nfsd/vfs.c | 931 +++---- fs/nfsd/vfs.h | 60 +- fs/nfsd/xdr.h | 68 +- fs/nfsd/xdr3.h | 116 +- fs/nfsd/xdr4.h | 127 +- fs/nfsd/xdr4cb.h | 6 + fs/notify/dnotify/dnotify.c | 17 +- fs/notify/fanotify/fanotify.c | 487 +++- fs/notify/fanotify/fanotify.h | 252 +- fs/notify/fanotify/fanotify_user.c | 882 ++++-- fs/notify/fdinfo.c | 19 +- fs/notify/fsnotify.c | 183 +- fs/notify/fsnotify.h | 19 +- fs/notify/group.c | 38 +- fs/notify/inotify/inotify.h | 11 +- fs/notify/inotify/inotify_fsnotify.c | 12 +- fs/notify/inotify/inotify_user.c | 87 +- fs/notify/mark.c | 172 +- fs/notify/notification.c | 78 +- fs/open.c | 49 +- fs/overlayfs/overlayfs.h | 9 +- fs/proc/fd.c | 48 +- fs/udf/file.c | 2 +- fs/verity/enable.c | 2 +- include/linux/dnotify.h | 2 +- include/linux/errno.h | 1 + include/linux/exportfs.h | 15 + include/linux/fanotify.h | 74 +- include/linux/fdtable.h | 37 +- include/linux/fs.h | 54 +- include/linux/fsnotify.h | 77 +- include/linux/fsnotify_backend.h | 372 ++- include/linux/iversion.h | 13 + include/linux/kallsyms.h | 17 +- include/linux/kthread.h | 1 + include/linux/lockd/bind.h | 3 +- include/linux/lockd/lockd.h | 17 +- include/linux/lockd/xdr.h | 35 +- include/linux/lockd/xdr4.h | 33 +- include/linux/module.h | 24 +- include/linux/nfs.h | 8 - include/linux/nfs4.h | 21 +- include/linux/nfs_ssc.h | 14 + include/linux/nfsacl.h | 6 + include/linux/pid.h | 1 + include/linux/sched/user.h | 3 - include/linux/sunrpc/msg_prot.h | 3 - include/linux/sunrpc/svc.h | 151 +- include/linux/sunrpc/svc_rdma.h | 4 +- include/linux/sunrpc/svc_xprt.h | 16 +- include/linux/sunrpc/svcauth.h | 4 +- include/linux/sunrpc/svcsock.h | 7 +- include/linux/sunrpc/xdr.h | 153 +- include/linux/syscalls.h | 12 - include/linux/sysctl.h | 2 + include/linux/user_namespace.h | 4 + include/trace/events/sunrpc.h | 26 +- include/uapi/linux/fanotify.h | 42 + include/uapi/linux/nfs3.h | 6 + include/uapi/linux/nfsd/nfsfh.h | 105 - kernel/audit_fsnotify.c | 8 +- kernel/audit_tree.c | 2 +- kernel/audit_watch.c | 5 +- kernel/bpf/inode.c | 2 +- kernel/bpf/syscall.c | 20 +- kernel/bpf/task_iter.c | 2 +- kernel/fork.c | 12 +- kernel/kallsyms.c | 8 +- kernel/kcmp.c | 29 +- kernel/kthread.c | 23 +- kernel/livepatch/core.c | 7 +- kernel/module.c | 26 +- kernel/pid.c | 15 +- kernel/sys.c | 2 +- kernel/sysctl.c | 54 +- kernel/trace/trace_kprobe.c | 4 +- kernel/ucount.c | 4 + mm/madvise.c | 2 +- mm/memcontrol.c | 2 +- mm/mincore.c | 2 +- net/bluetooth/bnep/core.c | 2 +- net/bluetooth/cmtp/core.c | 2 +- net/bluetooth/hidp/core.c | 2 +- net/sunrpc/auth_gss/gss_rpc_xdr.c | 2 +- net/sunrpc/auth_gss/svcauth_gss.c | 47 +- net/sunrpc/sched.c | 1 + net/sunrpc/svc.c | 314 ++- net/sunrpc/svc_xprt.c | 104 +- net/sunrpc/svcauth.c | 8 +- net/sunrpc/svcauth_unix.c | 18 +- net/sunrpc/svcsock.c | 32 +- net/sunrpc/xdr.c | 112 +- net/sunrpc/xprtrdma/svc_rdma_backchannel.c | 2 +- net/sunrpc/xprtrdma/svc_rdma_sendto.c | 32 +- net/sunrpc/xprtrdma/svc_rdma_transport.c | 2 +- net/unix/af_unix.c | 2 +- tools/objtool/check.c | 3 +- 184 files changed, 13912 insertions(+), 8825 deletions(-)

1 year, 4 months

15
800
0 0

[PATCH net v3] net: usb: sr9700: fix uninitialized variable use in sr_mdio_read

by Ma Ke

It could lead to error happen because the variable res is not updated if the call to sr_share_read_word returns an error. In this particular case error code was returned and res stayed uninitialized. This can be avoided by checking the return value of sr_share_read_word and propagating the error if the read operation failed. Found by code review. Cc: stable(a)vger.kernel.org Fixes: c9b37458e956 ("USB2NET : SR9700 : One chip USB 1.1 USB2NET SR9700Device Driver Support") Signed-off-by: Ma Ke <make24(a)iscas.ac.cn> --- Changes in v3: - added Cc stable line as suggestions. Changes in v2: - modified the subject as suggestions. --- drivers/net/usb/sr9700.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/sr9700.c b/drivers/net/usb/sr9700.c index 0a662e42ed96..d5bc596f4521 100644 --- a/drivers/net/usb/sr9700.c +++ b/drivers/net/usb/sr9700.c @@ -179,6 +179,7 @@ static int sr_mdio_read(struct net_device *netdev, int phy_id, int loc) struct usbnet *dev = netdev_priv(netdev); __le16 res; int rc = 0; + int err; if (phy_id) { netdev_dbg(netdev, "Only internal phy supported\n"); @@ -193,7 +194,10 @@ static int sr_mdio_read(struct net_device *netdev, int phy_id, int loc) if (value & NSR_LINKST) rc = 1; } - sr_share_read_word(dev, 1, loc, &res); + err = sr_share_read_word(dev, 1, loc, &res); + if (err < 0) + return err; + if (rc == 1) res = le16_to_cpu(res) | BMSR_LSTATUS; else -- 2.25.1

1 year, 4 months

1
0
0 0

[PATCH] mm: fix maxnode for mbind(), set_mempolicy() and migrate_pages()

by Jerome Glisse

Because maxnode bug there is no way to bind or migrate_pages to the last node in multi-node NUMA system unless you lie about maxnodes when making the mbind, set_mempolicy or migrate_pages syscall. Manpage for those syscall describe maxnodes as the number of bits in the node bitmap ("bit mask of nodes containing up to maxnode bits"). Thus if maxnode is n then we expect to have a n bit(s) bitmap which means that the mask of valid bits is ((1 << n) - 1). The get_nodes() decrement lead to the mask being ((1 << (n - 1)) - 1). The three syscalls use a common helper get_nodes() and first things this helper do is decrement maxnode by 1 which leads to using n-1 bits in the provided mask of nodes (see get_bitmap() an helper function to get_nodes()). The lead to two bugs, either the last node in the bitmap provided will not be use in either of the three syscalls, or the syscalls will error out and return EINVAL if the only bit set in the bitmap was the last bit in the mask of nodes (which is ignored because of the bug and an empty mask of nodes is an invalid argument). I am surprised this bug was never caught ... it has been in the kernel since forever. People can use the following function to detect if the kernel has the bug: bool kernel_has_maxnodes_bug(void) { unsigned long nodemask = 1; bool has_bug; long res; res = set_mempolicy(MPOL_BIND, &nodemask, 1); has_bug = res && (errno == EINVAL); set_mempolicy(MPOL_DEFAULT, NULL, 0); return has_bug; } You can tested with any of the three program below: gcc mbind.c -o mbind -lnuma gcc set_mempolicy.c -o set_mempolicy -lnuma gcc migrate_pages.c -o migrate_pages -lnuma First argument is maxnode, second argument is the bit index to set in the mask of node (0 set the first bit, 1 the second bit, ...). ./mbind 2 1 & sleep 2 && numastat -n -p `pidof mbind` && fg ./set_mempolicy 2 1 & sleep 2 && numastat -n -p `pidof set_mempolicy` && fg ./migrate_pages 2 1 & sleep 2 && numastat -n -p `pidof migrate_pages` && fg mbind.c %< ---------------------------------------------------------- void *anon_mem(size_t size) { void *ret; ret = mmap(NULL, size, PROT_READ| PROT_WRITE, MAP_PRIVATE| MAP_ANON, -1, 0); return ret == MAP_FAILED ? NULL : ret; } unsigned long mround(unsigned long v, unsigned long m) { if (m == 0) { return v; } return v + m - (v % m); } void bitmap_set(void *_bitmap, unsigned long b) { uint8_t *bitmap = _bitmap; bitmap[b >> 3] |= (1 << (b & 7)); } int main(int argc, char *argv[]) { unsigned long *nodemask, maxnode, node, i; size_t bytes; int8_t *mem; long res; if (argv[1] == NULL || argv[2] == NULL) { printf("missing argument: %s maxnodes node\n", argv[0]); return -1; } maxnode = atoi(argv[1]); node = atoi(argv[2]); bytes = mround(mround(maxnode, 8) >> 3, sizeof(unsigned long)); nodemask = calloc(bytes, 1); mem = anon_mem(NPAGES << 12); if (!mem || !nodemask) { return -1; } // Try to bind memory to node bitmap_set(nodemask, node); res = mbind(mem, NPAGES << 12, MPOL_BIND, nodemask, maxnode, 0); if (res) { printf("mbind(mem, NPAGES << 12, MPOL_BIND, " "nodemask, %d, 0) failed with %d\n", maxnode, errno); return -1; } // Write something to breakup from the zero page for (unsigned i = 0; i < NPAGES; i++) { mem[i << 12] = i + 1; } // Allow numastats to gather statistics getchar(); return 0; } set_mempolicy %< ---------------------------------------------------- void *anon_mem(size_t size) { void *ret; ret = mmap(NULL, size, PROT_READ| PROT_WRITE, MAP_PRIVATE| MAP_ANON, -1, 0); return ret == MAP_FAILED ? NULL : ret; } unsigned long mround(unsigned long v, unsigned long m) { if (m == 0) { return v; } return v + m - (v % m); } void bitmap_set(void *_bitmap, unsigned long b) { uint8_t *bitmap = _bitmap; bitmap[b >> 3] |= (1 << (b & 7)); } int main(int argc, char *argv[]) { unsigned long *nodemask, maxnode, node, i; size_t bytes; int8_t *mem; long res; if (argv[1] == NULL || argv[2] == NULL) { printf("missing argument: %s maxnodes node\n", argv[0]); return -1; } maxnode = atoi(argv[1]); node = atoi(argv[2]); // bind memory to node 0 ... i = 1; res = set_mempolicy(MPOL_BIND, i, 2); if (res) { printf("set_mempolicy(MPOL_BIND, []=1, %d) " "failed with %d\n", maxnode, errno); return -1; } bytes = mround(mround(maxnode, 8) >> 3, sizeof(unsigned long)); nodemask = calloc(bytes, 1); mem = anon_mem(NPAGES << 12); if (!mem || !nodemask) { return -1; } // Try to bind memory to node bitmap_set(nodemask, node); res = set_mempolicy(MPOL_BIND, nodemask, maxnode); if (res) { printf("set_mempolicy(MPOL_BIND, nodemask, %d) " "failed with %d\n", maxnode, errno); return -1; } // Write something to breakup from the zero page for (unsigned i = 0; i < NPAGES; i++) { mem[i << 12] = i + 1; } // Allow numastats to gather statistics getchar(); return 0; } migrate_pages %< ---------------------------------------------------- void *anon_mem(size_t size) { void *ret; ret = mmap(NULL, size, PROT_READ| PROT_WRITE, MAP_PRIVATE| MAP_ANON, -1, 0); return ret == MAP_FAILED ? NULL : ret; } unsigned long mround(unsigned long v, unsigned long m) { if (m == 0) { return v; } return v + m - (v % m); } void bitmap_set(void *_bitmap, unsigned long b) { uint8_t *bitmap = _bitmap; bitmap[b >> 3] |= (1 << (b & 7)); } int main(int argc, char *argv[]) { unsigned long *old_nodes, *new_nodes, maxnode, node, i; size_t bytes; int8_t *mem; long res; if (argv[1] == NULL || argv[2] == NULL) { printf("missing argument: %s maxnodes node\n", argv[0]); return -1; } maxnode = atoi(argv[1]); node = atoi(argv[2]); // bind memory to node 0 ... i = 1; res = set_mempolicy(MPOL_BIND, &i, 2); if (res) { printf("set_mempolicy(MPOL_BIND, []=1, %d) " "failed with %d\n", maxnode, errno); return -1; } bytes = mround(mround(maxnode, 8) >> 3, sizeof(unsigned long)); old_nodes = calloc(bytes, 1); new_nodes = calloc(bytes, 1); mem = anon_mem(NPAGES << 12); if (!mem || !new_nodes || !old_nodes) { return -1; } // Write something to breakup from the zero page for (unsigned i = 0; i < NPAGES; i++) { mem[i << 12] = i + 1; } // Try to bind memory to node bitmap_set(old_nodes, 0); bitmap_set(new_nodes, node); res = migrate_pages(getpid(), maxnode, old_nodes, new_nodes); if (res) { printf("migrate_pages(pid, %d, old_nodes, " "new_nodes) failed with %d\n", maxnode, errno); return -1; } // Allow numastats to gather statistics getchar(); return 0; } Signed-off-by: Jérôme Glisse <jglisse(a)google.com> To: Andrew Morton <akpm(a)linux-foundation.org> To: linux-mm(a)kvack.org Cc: linux-kernel(a)vger.kernel.org Cc: stable(a)vger.kernel.org --- mm/mempolicy.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index aec756ae5637..658e5366d266 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -1434,7 +1434,6 @@ static int get_bitmap(unsigned long *mask, const unsigned long __user *nmask, static int get_nodes(nodemask_t *nodes, const unsigned long __user *nmask, unsigned long maxnode) { - --maxnode; nodes_clear(*nodes); if (maxnode == 0 || !nmask) return 0; -- 2.45.2.1089.g2a221341d9-goog

1 year, 4 months

4
8
0 0

+ crash-fix-x86_32-crash-memory-reserve-dead-loop-bug-at-high.patch added to mm-nonmm-unstable branch

by Andrew Morton

The patch titled Subject: crash: fix x86_32 crash memory reserve dead loop bug at high has been added to the -mm mm-nonmm-unstable branch. Its filename is crash-fix-x86_32-crash-memory-reserve-dead-loop-bug-at-high.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patche… This patch will later appear in the mm-nonmm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Jinjie Ruan <ruanjinjie(a)huawei.com> Subject: crash: fix x86_32 crash memory reserve dead loop bug at high Date: Thu, 18 Jul 2024 11:54:43 +0800 On x86_32 Qemu machine with 1GB memory, the cmdline "crashkernel=512M" will also cause system stall as below: ACPI: Reserving FACP table memory at [mem 0x3ffe18b8-0x3ffe192b] ACPI: Reserving DSDT table memory at [mem 0x3ffe0040-0x3ffe18b7] ACPI: Reserving FACS table memory at [mem 0x3ffe0000-0x3ffe003f] ACPI: Reserving APIC table memory at [mem 0x3ffe192c-0x3ffe19bb] ACPI: Reserving HPET table memory at [mem 0x3ffe19bc-0x3ffe19f3] ACPI: Reserving WAET table memory at [mem 0x3ffe19f4-0x3ffe1a1b] 143MB HIGHMEM available. 879MB LOWMEM available. mapped low ram: 0 - 36ffe000 low ram: 0 - 36ffe000 (stall here) The reason is that the CRASH_ADDR_LOW_MAX is equal to CRASH_ADDR_HIGH_MAX on x86_32, the first "low" crash kernel memory reservation for 512M fails, then it go into the "retry" loop and never came out as below (consider CRASH_ADDR_LOW_MAX = CRASH_ADDR_HIGH_MAX = 512M): -> reserve_crashkernel_generic() and high is false -> alloc at [0, 0x20000000] fail -> alloc at [0x20000000, 0x20000000] fail and repeatedly (because CRASH_ADDR_LOW_MAX = CRASH_ADDR_HIGH_MAX). Fix it by skipping meaningless calls of memblock_phys_alloc_range() with `start = end` After this patch, the retry dead loop is avoided and print below info: cannot allocate crashkernel (size:0x20000000) And apply generic crashkernel reservation to 32bit system will be ready. Link: https://lkml.kernel.org/r/20240718035444.2977105-3-ruanjinjie@huawei.com Fixes: 9c08a2a139fe ("x86: kdump: use generic interface to simplify crashkernel reservation code") Signed-off-by: Jinjie Ruan <ruanjinjie(a)huawei.com> Signed-off-by: Baoquan He <bhe(a)redhat.com> Tested-by: Jinjie Ruan <ruanjinjie(a)huawei.com> Cc: Albert Ou <aou(a)eecs.berkeley.edu> Cc: Andrew Davis <afd(a)ti.com> Cc: Arnd Bergmann <arnd(a)arndb.de> Cc: Borislav Petkov <bp(a)alien8.de> Cc: Catalin Marinas <catalin.marinas(a)arm.com> Cc: Chen Jiahao <chenjiahao16(a)huawei.com> Cc: Dave Hansen <dave.hansen(a)linux.intel.com> Cc: Dave Young <dyoung(a)redhat.com> Cc: Eric DeVolder <eric.devolder(a)oracle.com> Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Cc: Hari Bathini <hbathini(a)linux.ibm.com> Cc: Helge Deller <deller(a)gmx.de> Cc: "H. Peter Anvin" <hpa(a)zytor.com> Cc: Ingo Molnar <mingo(a)redhat.com> Cc: Javier Martinez Canillas <javierm(a)redhat.com> Cc: Linus Walleij <linus.walleij(a)linaro.org> Cc: Palmer Dabbelt <palmer(a)dabbelt.com> Cc: Paul Walmsley <paul.walmsley(a)sifive.com> Cc: Rob Herring <robh(a)kernel.org> Cc: Russell King <linux(a)armlinux.org.uk> Cc: Thomas Gleixner <tglx(a)linutronix.de> Cc: Vivek Goyal <vgoyal(a)redhat.com> Cc: Will Deacon <will(a)kernel.org> Cc: Zhen Lei <thunder.leizhen(a)huawei.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- kernel/crash_reserve.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/kernel/crash_reserve.c~crash-fix-x86_32-crash-memory-reserve-dead-loop-bug-at-high +++ a/kernel/crash_reserve.c @@ -413,7 +413,8 @@ retry: search_end = CRASH_ADDR_HIGH_MAX; search_base = CRASH_ADDR_LOW_MAX; crash_low_size = DEFAULT_CRASH_KERNEL_LOW_SIZE; - goto retry; + if (search_base != search_end) + goto retry; } /* _ Patches currently in -mm which might be from ruanjinjie(a)huawei.com are crash-fix-x86_32-crash-memory-reserve-dead-loop-bug.patch crash-fix-x86_32-crash-memory-reserve-dead-loop-bug-at-high.patch arm-use-generic-interface-to-simplify-crashkernel-reservation.patch

1 year, 4 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror