July 2018 - Linux-stable-mirror

request for 4.14-stable: 1990cf7c21ea ("usb: gadget: udc: renesas_usb3: should remove debugfs")

by Sudip Mukherjee

Hi Greg, This was missing in 4.14-stable. Please apply to your queue. -- Regards Sudip

5 years, 11 months

2
1
0 0

request for 4.14-stable: 940efcc8889f ("RDMA/uverbs: Protect from attempts to create flows on unsupported QP")

by Sudip Mukherjee

Hi Greg, This was missing in 4.14-stable. Please apply to your queue. -- Regards Sudip

5 years, 11 months

2
1
0 0

[PATCH 4.17 00/66] 4.17.11-stable review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.17.11 release. There are 66 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sun Jul 29 09:37:38 UTC 2018. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.17.11-rc… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.17.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.17.11-rc1 Roman Fietze <roman.fietze(a)telemotive.de> can: m_can.c: fix setup of CCCR register: clear CCCR NISO bit before checking can.ctrlmode Faiz Abbas <faiz_abbas(a)ti.com> can: m_can: Fix runtime resume call Stephane Grosjean <s.grosjean(a)peak-system.com> can: peak_canfd: fix firmware < v3.3.0: limit allocation to 32-bit DMA addr only Anssi Hannula <anssi.hannula(a)bitwise.fi> can: xilinx_can: fix RX overflow interrupt not being enabled Anssi Hannula <anssi.hannula(a)bitwise.fi> can: xilinx_can: fix incorrect clear of non-processed interrupts Anssi Hannula <anssi.hannula(a)bitwise.fi> can: xilinx_can: keep only 1-2 frames in TX FIFO to fix TX accounting Anssi Hannula <anssi.hannula(a)bitwise.fi> can: xilinx_can: fix device dropping off bus on RX overrun Anssi Hannula <anssi.hannula(a)bitwise.fi> can: xilinx_can: fix recovery from error states not being propagated Anssi Hannula <anssi.hannula(a)bitwise.fi> can: xilinx_can: fix power management handling Anssi Hannula <anssi.hannula(a)bitwise.fi> can: xilinx_can: fix RX loop if RXNEMP is asserted without RXOK Rafael J. Wysocki <rafael.j.wysocki(a)intel.com> driver core: Partially revert "driver core: correct device's shutdown order" Schmauss, Erik <erik.schmauss(a)intel.com> ACPICA: AML Parser: ignore dispatcher error status during table load Jerry Zhang <zhangjerry(a)google.com> usb: gadget: f_fs: Only return delayed status when len is 0 Benjamin Herrenschmidt <benh(a)kernel.crashing.org> usb: gadget: Fix OS descriptors support Zheng Xiaowei <zhengxiaowei(a)ruijie.com.cn> usb: xhci: Fix memory leak in xhci_endpoint_reset() Antti Seppälä <a.seppala(a)gmail.com> usb: dwc2: Fix DMA alignment to start at allocated boundary Bin Liu <b-liu(a)ti.com> usb: core: handle hub C_PORT_OVER_CURRENT condition Lubomir Rintel <lkundrak(a)v3.sk> usb: cdc_acm: Add quirk for Castles VEGA3000 Samuel Thibault <samuel.thibault(a)ens-lyon.org> staging: speakup: fix wraparound in uaccess length check Hans de Goede <hdegoede(a)redhat.com> Revert "staging:r8188eu: Use lib80211 to support TKIP" Eric Dumazet <edumazet(a)google.com> tcp: add tcp_ooo_try_coalesce() helper Eric Dumazet <edumazet(a)google.com> tcp: call tcp_drop() from tcp_data_queue_ofo() Eric Dumazet <edumazet(a)google.com> tcp: detect malicious patterns in tcp_collapse_ofo_queue() Eric Dumazet <edumazet(a)google.com> tcp: avoid collapses in tcp_prune_queue() if possible Eric Dumazet <edumazet(a)google.com> tcp: free batches of packets in tcp_prune_ofo_queue() Roopa Prabhu <roopa(a)cumulusnetworks.com> vxlan: fix default fdb entry netlink notify ordering during netdev create Roopa Prabhu <roopa(a)cumulusnetworks.com> vxlan: make netlink notify in vxlan_fdb_destroy optional Roopa Prabhu <roopa(a)cumulusnetworks.com> vxlan: add new fdb alloc and create helpers Roopa Prabhu <roopa(a)cumulusnetworks.com> rtnetlink: add rtnl_link_state check in rtnl_configure_link Ariel Levkovich <lariel(a)mellanox.com> net/mlx5: Adjust clock overflow work period Eran Ben Elisha <eranbe(a)mellanox.com> net/mlx5e: Fix quota counting in aRFS expire flow Eran Ben Elisha <eranbe(a)mellanox.com> net/mlx5e: Don't allow aRFS for encapsulated packets David Ahern <dsahern(a)gmail.com> net/ipv6: Fix linklocal to global address with VRF Hangbin Liu <liuhangbin(a)gmail.com> multicast: do not restore deleted record source filter mode to new one Heiner Kallweit <hkallweit1(a)gmail.com> net: phy: consider PHY_IGNORE_INTERRUPT in phy_start_aneg_priv Daniel Borkmann <daniel(a)iogearbox.net> sock: fix sg page frag coalescing in sk_alloc_sg John Hurley <john.hurley(a)netronome.com> nfp: flower: ensure dead neighbour entries are not offloaded Shay Agroskin <shayag(a)mellanox.com> net/mlx5e: Refine ets validation function Roi Dayan <roid(a)mellanox.com> net/mlx5e: Only allow offloading decap egress (egdev) flows Or Gerlitz <ogerlitz(a)mellanox.com> net/mlx5e: Add ingress/egress indication for offloaded TC flows Doron Roberts-Kedes <doronrk(a)fb.com> tls: check RCV_SHUTDOWN in tls_wait_data Heiner Kallweit <hkallweit1(a)gmail.com> r8169: restore previous behavior to accept BIOS WoL settings Saeed Mahameed <saeedm(a)mellanox.com> net/mlx5: E-Switch, UBSAN fix undefined behavior in mlx5_eswitch_mode Yuchung Cheng <ycheng(a)google.com> tcp: do not delay ACK in DCTCP upon CE status change Yuchung Cheng <ycheng(a)google.com> tcp: do not cancel delay-AcK on DCTCP special ACK Yuchung Cheng <ycheng(a)google.com> tcp: helpers to send special DCTCP ack Yuchung Cheng <ycheng(a)google.com> tcp: fix dctcp delayed ACK schedule Eric Dumazet <edumazet(a)google.com> net: skb_segment() should not return NULL Zhao Chen <zhaochen6(a)huawei.com> net-next/hinic: fix a problem in hinic_xmit_frame() Jack Morgenstein <jackm(a)dev.mellanox.co.il> net/mlx4_core: Save the qpn from the input modifier in RST2INIT wrapper Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> net: dsa: mv88e6xxx: fix races between lock and irq freeing Willem de Bruijn <willemb(a)google.com> ip: in cmsg IP(V6)_ORIGDSTADDR call pskb_may_pull Paolo Abeni <pabeni(a)redhat.com> ip: hash fragments consistently Jarod Wilson <jarod(a)redhat.com> bonding: set default miimon value for non-arp modes if not set Neil Armstrong <narmstrong(a)baylibre.com> clk: meson-gxbb: set fclk_div2 as CLK_IS_CRITICAL Lyude Paul <lyude(a)redhat.com> drm/nouveau: Set DRIVER_ATOMIC cap earlier to fix debugfs Lyude Paul <lyude(a)redhat.com> drm/nouveau/drm/nouveau: Fix runtime PM leak in nv50_disp_atomic_commit() Alexey Kardashevskiy <aik(a)ozlabs.ru> KVM: PPC: Check if IOMMU page is contained in the pinned physical page Boris Ostrovsky <boris.ostrovsky(a)oracle.com> xen/PVH: Set up GS segment for stack canary Joel Stanley <joel(a)jms.id.au> clk: aspeed: Support HPLL strapping on ast2400 Joel Stanley <joel(a)jms.id.au> clk: aspeed: Mark bclk (PCIe) and dclk (VGA) as critical Gregory CLEMENT <gregory.clement(a)bootlin.com> clk: mvebu: armada-37xx-periph: Fix switching CPU rate from 300Mhz to 1.2GHz Paul Burton <paul.burton(a)mips.com> MIPS: Fix off-by-one in pci_resource_to_user() Felix Fietkau <nbd(a)nbd.name> MIPS: ath79: fix register address in ath79_ddr_wb_flush() Christoph Hellwig <hch(a)lst.de> Revert "iommu/intel-iommu: Enable CONFIG_DMA_DIRECT_OPS=y and clean up intel_{alloc,free}_coherent()" Paolo Bonzini <pbonzini(a)redhat.com> KVM: VMX: support MSR_IA32_ARCH_CAPABILITIES as a feature MSR ------------- Diffstat: Makefile | 4 +- arch/mips/ath79/common.c | 2 +- arch/mips/pci/pci.c | 2 +- arch/powerpc/include/asm/mmu_context.h | 4 +- arch/powerpc/kvm/book3s_64_vio.c | 2 +- arch/powerpc/kvm/book3s_64_vio_hv.c | 6 +- arch/powerpc/mm/mmu_context_iommu.c | 37 +- arch/x86/kvm/x86.c | 4 +- arch/x86/xen/xen-pvh.S | 26 +- drivers/acpi/acpica/psloop.c | 26 ++ drivers/base/dd.c | 8 - drivers/clk/clk-aspeed.c | 46 ++- drivers/clk/meson/gxbb.c | 1 + drivers/clk/mvebu/armada-37xx-periph.c | 38 ++ drivers/gpu/drm/nouveau/dispnv04/disp.c | 3 + drivers/gpu/drm/nouveau/nouveau_drm.c | 7 + drivers/gpu/drm/nouveau/nv50_display.c | 8 +- drivers/iommu/Kconfig | 1 - drivers/iommu/intel-iommu.c | 62 +++- drivers/net/bonding/bond_options.c | 23 +- drivers/net/can/m_can/m_can.c | 11 +- drivers/net/can/peak_canfd/peak_pciefd_main.c | 19 + drivers/net/can/xilinx_can.c | 392 +++++++++++++++------ drivers/net/dsa/mv88e6xxx/chip.c | 21 +- drivers/net/ethernet/huawei/hinic/hinic_tx.c | 1 + .../net/ethernet/mellanox/mlx4/resource_tracker.c | 2 +- drivers/net/ethernet/mellanox/mlx5/core/en.h | 3 - drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c | 7 +- drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c | 17 +- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 15 +- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 32 +- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 42 ++- drivers/net/ethernet/mellanox/mlx5/core/en_tc.h | 13 +- drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 2 +- .../net/ethernet/mellanox/mlx5/core/lib/clock.c | 12 +- .../ethernet/netronome/nfp/flower/tunnel_conf.c | 2 +- drivers/net/ethernet/realtek/r8169.c | 3 +- drivers/net/phy/phy.c | 2 +- drivers/net/vxlan.c | 126 +++++-- drivers/staging/rtl8188eu/Kconfig | 1 - drivers/staging/rtl8188eu/core/rtw_recv.c | 161 ++++++--- drivers/staging/rtl8188eu/core/rtw_security.c | 92 ++--- drivers/staging/speakup/speakup_soft.c | 6 +- drivers/usb/class/cdc-acm.c | 3 + drivers/usb/core/hub.c | 8 +- drivers/usb/dwc2/hcd.c | 44 +-- drivers/usb/gadget/composite.c | 1 - drivers/usb/gadget/function/f_fs.c | 2 +- drivers/usb/host/xhci.c | 1 + drivers/vfio/vfio_iommu_spapr_tce.c | 2 +- include/net/tcp.h | 7 + net/core/rtnetlink.c | 9 +- net/core/skbuff.c | 10 +- net/core/sock.c | 6 +- net/ipv4/igmp.c | 3 +- net/ipv4/ip_output.c | 2 + net/ipv4/ip_sockglue.c | 7 +- net/ipv4/tcp_dctcp.c | 50 +-- net/ipv4/tcp_input.c | 65 +++- net/ipv4/tcp_output.c | 33 +- net/ipv6/datagram.c | 7 +- net/ipv6/icmp.c | 5 +- net/ipv6/ip6_output.c | 2 + net/ipv6/mcast.c | 3 +- net/ipv6/tcp_ipv6.c | 6 +- net/tls/tls_sw.c | 3 + 66 files changed, 1097 insertions(+), 474 deletions(-)

5 years, 11 months

5
71
0 0

photos need editing

by Edward

We are an image editing service provider having more than 10 years of industry experience. We use latest techniques for photo editing to meet international quality standards. We are committed to deliver reliable photo processing services. Production of 1000+ images within single working day 24×7×365 photo editing services On-demand image editing to meet rush job requirements Service details: Images Masking Photo Clipping Path Photo Cutout Photo Enhancement Vector Conversion Photo Stitching Services Fashion Photo Editing Jewelry Retouching Footwear Photo Editing Furniture Photo Retouching Wedding Photo Editing Real Estate Photo Editing Photo Restoration We provide trials to evaluate our service quality to new clients. Thanks, Edward

5 years, 11 months

1
0
0 0

[PATCH] can: ems_usb: Fix memory leak on ems_usb_disconnect()

by Marc Kleine-Budde

From: Anton Vasilyev <vasilyev(a)ispras.ru> ems_usb_probe() allocates memory for dev->tx_msg_buffer, but there is no its deallocation in ems_usb_disconnect(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Anton Vasilyev <vasilyev(a)ispras.ru> Cc: <stable(a)vger.kernel.org> Signed-off-by: Marc Kleine-Budde <mkl(a)pengutronix.de> --- drivers/net/can/usb/ems_usb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/can/usb/ems_usb.c b/drivers/net/can/usb/ems_usb.c index 12ff0020ecd6..b7dfd4109d24 100644 --- a/drivers/net/can/usb/ems_usb.c +++ b/drivers/net/can/usb/ems_usb.c @@ -1072,6 +1072,7 @@ static void ems_usb_disconnect(struct usb_interface *intf) usb_free_urb(dev->intr_urb); kfree(dev->intr_in_buffer); + kfree(dev->tx_msg_buffer); } } -- 2.18.0

5 years, 11 months

1
0
0 0

FAILED: patch "[PATCH] ext4: fix check to prevent initializing reserved inodes" failed to apply to 4.4-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 5012284700775a4e6e3fbe7eac4c543c4874b559 Mon Sep 17 00:00:00 2001 From: Theodore Ts'o <tytso(a)mit.edu> Date: Sat, 28 Jul 2018 08:12:04 -0400 Subject: [PATCH] ext4: fix check to prevent initializing reserved inodes Commit 8844618d8aa7: "ext4: only look at the bg_flags field if it is valid" will complain if block group zero does not have the EXT4_BG_INODE_ZEROED flag set. Unfortunately, this is not correct, since a freshly created file system has this flag cleared. It gets almost immediately after the file system is mounted read-write --- but the following somewhat unlikely sequence will end up triggering a false positive report of a corrupted file system: mkfs.ext4 /dev/vdc mount -o ro /dev/vdc /vdc mount -o remount,rw /dev/vdc Instead, when initializing the inode table for block group zero, test to make sure that itable_unused count is not too large, since that is the case that will result in some or all of the reserved inodes getting cleared. This fixes the failures reported by Eric Whiteney when running generic/230 and generic/231 in the the nojournal test case. Fixes: 8844618d8aa7 ("ext4: only look at the bg_flags field if it is valid") Reported-by: Eric Whitney <enwlinux(a)gmail.com> Signed-off-by: Theodore Ts'o <tytso(a)mit.edu> diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c index e9d8e2667ab5..f336cbc6e932 100644 --- a/fs/ext4/ialloc.c +++ b/fs/ext4/ialloc.c @@ -1388,7 +1388,10 @@ int ext4_init_inode_table(struct super_block *sb, ext4_group_t group, ext4_itable_unused_count(sb, gdp)), sbi->s_inodes_per_block); - if ((used_blks < 0) || (used_blks > sbi->s_itb_per_group)) { + if ((used_blks < 0) || (used_blks > sbi->s_itb_per_group) || + ((group == 0) && ((EXT4_INODES_PER_GROUP(sb) - + ext4_itable_unused_count(sb, gdp)) < + EXT4_FIRST_INO(sb)))) { ext4_error(sb, "Something is wrong with group %u: " "used itable blocks: %d; " "itable unused count: %u", diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 680526e9ee96..b7f7922061be 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -3141,14 +3141,8 @@ static ext4_group_t ext4_has_uninit_itable(struct super_block *sb) if (!gdp) continue; - if (gdp->bg_flags & cpu_to_le16(EXT4_BG_INODE_ZEROED)) - continue; - if (group != 0) + if (!(gdp->bg_flags & cpu_to_le16(EXT4_BG_INODE_ZEROED))) break; - ext4_error(sb, "Inode table for bg 0 marked as " - "needing zeroing"); - if (sb_rdonly(sb)) - return ngroups; } return group;

5 years, 11 months

1
0
0 0

FAILED: patch "[PATCH] ext4: fix check to prevent initializing reserved inodes" failed to apply to 4.9-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.9-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 5012284700775a4e6e3fbe7eac4c543c4874b559 Mon Sep 17 00:00:00 2001 From: Theodore Ts'o <tytso(a)mit.edu> Date: Sat, 28 Jul 2018 08:12:04 -0400 Subject: [PATCH] ext4: fix check to prevent initializing reserved inodes Commit 8844618d8aa7: "ext4: only look at the bg_flags field if it is valid" will complain if block group zero does not have the EXT4_BG_INODE_ZEROED flag set. Unfortunately, this is not correct, since a freshly created file system has this flag cleared. It gets almost immediately after the file system is mounted read-write --- but the following somewhat unlikely sequence will end up triggering a false positive report of a corrupted file system: mkfs.ext4 /dev/vdc mount -o ro /dev/vdc /vdc mount -o remount,rw /dev/vdc Instead, when initializing the inode table for block group zero, test to make sure that itable_unused count is not too large, since that is the case that will result in some or all of the reserved inodes getting cleared. This fixes the failures reported by Eric Whiteney when running generic/230 and generic/231 in the the nojournal test case. Fixes: 8844618d8aa7 ("ext4: only look at the bg_flags field if it is valid") Reported-by: Eric Whitney <enwlinux(a)gmail.com> Signed-off-by: Theodore Ts'o <tytso(a)mit.edu> diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c index e9d8e2667ab5..f336cbc6e932 100644 --- a/fs/ext4/ialloc.c +++ b/fs/ext4/ialloc.c @@ -1388,7 +1388,10 @@ int ext4_init_inode_table(struct super_block *sb, ext4_group_t group, ext4_itable_unused_count(sb, gdp)), sbi->s_inodes_per_block); - if ((used_blks < 0) || (used_blks > sbi->s_itb_per_group)) { + if ((used_blks < 0) || (used_blks > sbi->s_itb_per_group) || + ((group == 0) && ((EXT4_INODES_PER_GROUP(sb) - + ext4_itable_unused_count(sb, gdp)) < + EXT4_FIRST_INO(sb)))) { ext4_error(sb, "Something is wrong with group %u: " "used itable blocks: %d; " "itable unused count: %u", diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 680526e9ee96..b7f7922061be 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -3141,14 +3141,8 @@ static ext4_group_t ext4_has_uninit_itable(struct super_block *sb) if (!gdp) continue; - if (gdp->bg_flags & cpu_to_le16(EXT4_BG_INODE_ZEROED)) - continue; - if (group != 0) + if (!(gdp->bg_flags & cpu_to_le16(EXT4_BG_INODE_ZEROED))) break; - ext4_error(sb, "Inode table for bg 0 marked as " - "needing zeroing"); - if (sb_rdonly(sb)) - return ngroups; } return group;

5 years, 11 months

1
0
0 0

FAILED: patch "[PATCH] ext4: fix false negatives *and* false positives in" failed to apply to 4.4-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 44de022c4382541cebdd6de4465d1f4f465ff1dd Mon Sep 17 00:00:00 2001 From: Theodore Ts'o <tytso(a)mit.edu> Date: Sun, 8 Jul 2018 19:35:02 -0400 Subject: [PATCH] ext4: fix false negatives *and* false positives in ext4_check_descriptors() Ext4_check_descriptors() was getting called before s_gdb_count was initialized. So for file systems w/o the meta_bg feature, allocation bitmaps could overlap the block group descriptors and ext4 wouldn't notice. For file systems with the meta_bg feature enabled, there was a fencepost error which would cause the ext4_check_descriptors() to incorrectly believe that the block allocation bitmap overlaps with the block group descriptor blocks, and it would reject the mount. Fix both of these problems. Signed-off-by: Theodore Ts'o <tytso(a)mit.edu> Cc: stable(a)vger.kernel.org diff --git a/fs/ext4/super.c b/fs/ext4/super.c index ba2396a7bd04..eff5c983e067 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -2342,7 +2342,7 @@ static int ext4_check_descriptors(struct super_block *sb, struct ext4_sb_info *sbi = EXT4_SB(sb); ext4_fsblk_t first_block = le32_to_cpu(sbi->s_es->s_first_data_block); ext4_fsblk_t last_block; - ext4_fsblk_t last_bg_block = sb_block + ext4_bg_num_gdb(sb, 0) + 1; + ext4_fsblk_t last_bg_block = sb_block + ext4_bg_num_gdb(sb, 0); ext4_fsblk_t block_bitmap; ext4_fsblk_t inode_bitmap; ext4_fsblk_t inode_table; @@ -4085,14 +4085,13 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) goto failed_mount2; } } + sbi->s_gdb_count = db_count; if (!ext4_check_descriptors(sb, logical_sb_block, &first_not_zeroed)) { ext4_msg(sb, KERN_ERR, "group descriptors corrupted!"); ret = -EFSCORRUPTED; goto failed_mount2; } - sbi->s_gdb_count = db_count; - timer_setup(&sbi->s_err_report, print_daily_error_info, 0); /* Register extent status tree shrinker */

5 years, 11 months

1
0
0 0

FAILED: patch "[PATCH] ext4: fix false negatives *and* false positives in" failed to apply to 4.9-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.9-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 44de022c4382541cebdd6de4465d1f4f465ff1dd Mon Sep 17 00:00:00 2001 From: Theodore Ts'o <tytso(a)mit.edu> Date: Sun, 8 Jul 2018 19:35:02 -0400 Subject: [PATCH] ext4: fix false negatives *and* false positives in ext4_check_descriptors() Ext4_check_descriptors() was getting called before s_gdb_count was initialized. So for file systems w/o the meta_bg feature, allocation bitmaps could overlap the block group descriptors and ext4 wouldn't notice. For file systems with the meta_bg feature enabled, there was a fencepost error which would cause the ext4_check_descriptors() to incorrectly believe that the block allocation bitmap overlaps with the block group descriptor blocks, and it would reject the mount. Fix both of these problems. Signed-off-by: Theodore Ts'o <tytso(a)mit.edu> Cc: stable(a)vger.kernel.org diff --git a/fs/ext4/super.c b/fs/ext4/super.c index ba2396a7bd04..eff5c983e067 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -2342,7 +2342,7 @@ static int ext4_check_descriptors(struct super_block *sb, struct ext4_sb_info *sbi = EXT4_SB(sb); ext4_fsblk_t first_block = le32_to_cpu(sbi->s_es->s_first_data_block); ext4_fsblk_t last_block; - ext4_fsblk_t last_bg_block = sb_block + ext4_bg_num_gdb(sb, 0) + 1; + ext4_fsblk_t last_bg_block = sb_block + ext4_bg_num_gdb(sb, 0); ext4_fsblk_t block_bitmap; ext4_fsblk_t inode_bitmap; ext4_fsblk_t inode_table; @@ -4085,14 +4085,13 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) goto failed_mount2; } } + sbi->s_gdb_count = db_count; if (!ext4_check_descriptors(sb, logical_sb_block, &first_not_zeroed)) { ext4_msg(sb, KERN_ERR, "group descriptors corrupted!"); ret = -EFSCORRUPTED; goto failed_mount2; } - sbi->s_gdb_count = db_count; - timer_setup(&sbi->s_err_report, print_daily_error_info, 0); /* Register extent status tree shrinker */

5 years, 11 months

1
0
0 0

FAILED: patch "[PATCH] i2c: imx: Fix reinit_completion() use" failed to apply to 4.4-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 9f9e3e0d4dd3338b3f3dde080789f71901e1e4ff Mon Sep 17 00:00:00 2001 From: Esben Haabendal <eha(a)deif.com> Date: Mon, 9 Jul 2018 11:43:01 +0200 Subject: [PATCH] i2c: imx: Fix reinit_completion() use MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Make sure to call reinit_completion() before dma is started to avoid race condition where reinit_completion() is called after complete() and before wait_for_completion_timeout(). Signed-off-by: Esben Haabendal <eha(a)deif.com> Fixes: ce1a78840ff7 ("i2c: imx: add DMA support for freescale i2c driver") Reviewed-by: Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> Signed-off-by: Wolfram Sang <wsa(a)the-dreams.de> Cc: stable(a)kernel.org diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c index 0207e194f84b..39cfd98c7b23 100644 --- a/drivers/i2c/busses/i2c-imx.c +++ b/drivers/i2c/busses/i2c-imx.c @@ -368,6 +368,7 @@ static int i2c_imx_dma_xfer(struct imx_i2c_struct *i2c_imx, goto err_desc; } + reinit_completion(&dma->cmd_complete); txdesc->callback = i2c_imx_dma_callback; txdesc->callback_param = i2c_imx; if (dma_submit_error(dmaengine_submit(txdesc))) { @@ -622,7 +623,6 @@ static int i2c_imx_dma_write(struct imx_i2c_struct *i2c_imx, * The first byte must be transmitted by the CPU. */ imx_i2c_write_reg(i2c_8bit_addr_from_msg(msgs), i2c_imx, IMX_I2C_I2DR); - reinit_completion(&i2c_imx->dma->cmd_complete); time_left = wait_for_completion_timeout( &i2c_imx->dma->cmd_complete, msecs_to_jiffies(DMA_TIMEOUT)); @@ -681,7 +681,6 @@ static int i2c_imx_dma_read(struct imx_i2c_struct *i2c_imx, if (result) return result; - reinit_completion(&i2c_imx->dma->cmd_complete); time_left = wait_for_completion_timeout( &i2c_imx->dma->cmd_complete, msecs_to_jiffies(DMA_TIMEOUT));

5 years, 11 months

1
0
0 0

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror July 2018