October 2019 - Linux-stable-mirror

[PATCH 0/2] PCI: rcar: Fix missing MACCTLR register setting (take2)

by Yoshihiro Shimoda

This patch series is based on the latest pci/rcar branch of Lorenzo's pci.git. The commit 175cc093888e ("PCI: rcar: Fix missing MACCTLR register setting in rcar_pcie_hw_init()") description/code don't follow the manual accurately, so that it's difficult to understand. So, this patch series reverts the commit at first, and then applies a new fixed patch. Reference: https://marc.info/?l=linux-renesas-soc&m=157242422327368&w=2 Yoshihiro Shimoda (2): Revert "PCI: rcar: Fix missing MACCTLR register setting in rcar_pcie_hw_init()" PCI: rcar: Fix missing MACCTLR register setting in initialize sequence drivers/pci/controller/pcie-rcar.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.7.4

4 years, 5 months

4
9
0 0

[PATCH] timekeeping/vsyscall: Update vdso data unconditionally

by Huacai Chen

In do_hres(), we currently use whether the return value of __arch_get_ hw_counter() is negative to indicate fallback, but MIPS returns 0 when clock_mode is invalid. It is sure that MIPS has a bug when clock_mode is invalid and should return ULL_MAX as ARM64 does (Vincenzo has already submitted a patch). But at the time we found another bug: currently update_vsyscall() and update_vsyscall_tz() rely on __arch_use_vsyscall() to update the vdso data, which causes __cvdso_clock_getres() and some other functions get wrong results when clock_mode is invalid. So, in this patch we update vdso data unconditionally. Fixes: 44f57d788e7deecb50 ("timekeeping: Provide a generic update_vsyscall() implementation") Cc: stable(a)vger.kernel.org Cc: Arnd Bergmann <arnd(a)arndb.de> Cc: Paul Burton <paul.burton(a)mips.com> Cc: linux-mips(a)vger.kernel.org Cc: linux-arm-kernel(a)lists.infradead.org Signed-off-by: Huacai Chen <chenhc(a)lemote.com> --- kernel/time/vsyscall.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/kernel/time/vsyscall.c b/kernel/time/vsyscall.c index 4bc37ac..5ee0f77 100644 --- a/kernel/time/vsyscall.c +++ b/kernel/time/vsyscall.c @@ -110,8 +110,7 @@ void update_vsyscall(struct timekeeper *tk) nsec = nsec + tk->wall_to_monotonic.tv_nsec; vdso_ts->sec += __iter_div_u64_rem(nsec, NSEC_PER_SEC, &vdso_ts->nsec); - if (__arch_use_vsyscall(vdata)) - update_vdso_data(vdata, tk); + update_vdso_data(vdata, tk); __arch_update_vsyscall(vdata, tk); @@ -124,10 +123,8 @@ void update_vsyscall_tz(void) { struct vdso_data *vdata = __arch_get_k_vdso_data(); - if (__arch_use_vsyscall(vdata)) { - vdata[CS_HRES_COARSE].tz_minuteswest = sys_tz.tz_minuteswest; - vdata[CS_HRES_COARSE].tz_dsttime = sys_tz.tz_dsttime; - } + vdata[CS_HRES_COARSE].tz_minuteswest = sys_tz.tz_minuteswest; + vdata[CS_HRES_COARSE].tz_dsttime = sys_tz.tz_dsttime; __arch_sync_vdso_data(vdata); } -- 2.7.0

4 years, 5 months

2
1
0 0

[PATCH] btrfs: save i_size in compress_file_range

by Josef Bacik

We hit a regression while rolling out 5.2 internally where we were hitting the following panic kernel BUG at mm/page-writeback.c:2659! RIP: 0010:clear_page_dirty_for_io+0xe6/0x1f0 Call Trace: __process_pages_contig+0x25a/0x350 ? extent_clear_unlock_delalloc+0x43/0x70 submit_compressed_extents+0x359/0x4d0 normal_work_helper+0x15a/0x330 process_one_work+0x1f5/0x3f0 worker_thread+0x2d/0x3d0 ? rescuer_thread+0x340/0x340 kthread+0x111/0x130 ? kthread_create_on_node+0x60/0x60 ret_from_fork+0x1f/0x30 this is happening because the page is not locked when doing clear_page_dirty_for_io. Looking at the core dump it was because our async_extent had a ram_size of 24576 but our async_chunk range only spanned 20480, so we had a whole extra page in our ram_size for our async_extent. This happened because we try not to compress pages outside of our i_size, however a cleanup patch changed us to do actual_end = min_t(u64, i_size_read(inode), end + 1); which is problematic because i_size_read() can evaluate to different values in between checking and assigning. So either a expanding truncate or a fallocate could increase our i_size while we're doing writeout and actual_end would end up being past the range we have locked. I confirmed this was what was happening by installing a debug kernel that had actual_end = min_t(u64, i_size_read(inode), end + 1); if (actual_end > end + 1) { printk(KERN_ERR "WE GOT FUCKED\n"); actual_end = end + 1; } and installing it onto 500 boxes of the tier that had been seeing the problem regularly. Last night I got my debug message and no panic, confirming what I expected. Fixes: 62b37622718c ("btrfs: Remove isize local variable in compress_file_range") cc: stable(a)vger.kernel.org Signed-off-by: Josef Bacik <josef(a)toxicpanda.com> --- fs/btrfs/inode.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 2eb1d7249f83..9a483d1f61f8 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -474,6 +474,7 @@ static noinline int compress_file_range(struct async_chunk *async_chunk) u64 start = async_chunk->start; u64 end = async_chunk->end; u64 actual_end; + loff_t i_size = i_size_read(inode); int ret = 0; struct page **pages = NULL; unsigned long nr_pages; @@ -488,7 +489,13 @@ static noinline int compress_file_range(struct async_chunk *async_chunk) inode_should_defrag(BTRFS_I(inode), start, end, end - start + 1, SZ_16K); - actual_end = min_t(u64, i_size_read(inode), end + 1); + /* + * We need to save i_size before now because it could change in between + * us evaluating the size and assigning it. This is because we lock and + * unlock the page in truncate and fallocate, and then modify the i_size + * later on. + */ + actual_end = min_t(u64, i_size, end + 1); again: will_compress = 0; nr_pages = (end >> PAGE_SHIFT) - (start >> PAGE_SHIFT) + 1; -- 2.21.0

4 years, 5 months

3
5
0 0

[PATCH 03/22] ext4: Do not iput inode under running transaction in ext4_mkdir()

by Jan Kara

When ext4_mkdir() fails to add entry into directory, it ends up dropping freshly created inode under the running transaction and thus inode truncation happens under that transaction. That breaks assumptions that ext4_evict_inode() does not get called from a transaction context (although I'm not aware of any real issue) and is completely unnecessary. Just stop the transaction before dropping inode reference. CC: stable(a)vger.kernel.org Signed-off-by: Jan Kara <jack(a)suse.cz> --- fs/ext4/namei.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index a427d2031a8d..9c872a33aea7 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c @@ -2781,8 +2781,9 @@ static int ext4_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) clear_nlink(inode); unlock_new_inode(inode); ext4_mark_inode_dirty(handle, inode); + ext4_journal_stop(handle); iput(inode); - goto out_stop; + goto out_retry; } ext4_inc_count(handle, dir); ext4_update_dx_flag(dir); @@ -2796,6 +2797,7 @@ static int ext4_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) out_stop: if (handle) ext4_journal_stop(handle); +out_retry: if (err == -ENOSPC && ext4_should_retry_alloc(dir->i_sb, &retries)) goto retry; return err; -- 2.16.4

4 years, 5 months

2
5
0 0

[STABLE-PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic

by Alex Lyakas

From: Vratislav Bendel <vbendel(a)redhat.com> [upstream commit 19957a181608d25c8f4136652d0ea00b3738972d] Due to an inverted logic mistake in xfs_buftarg_isolate() the xfs_buffers with zero b_lru_ref will take another trip around LRU, while isolating buffers with non-zero b_lru_ref. Additionally those isolated buffers end up right back on the LRU once they are released, because b_lru_ref remains elevated. Fix that circuitous route by leaving them on the LRU as originally intended. [Additional description for the issue] Due to this issue, buffers will spend one cycle less in the LRU than intended. If we initialize b_lru_ref to X, we intend the buffer to survive X shrinker calls, and on the X+1'th call to be taken off the LRU (and maybe freed). But with this issue, the buffer will be taken off the LRU and immediately re-added back. But this will happen X-1 times, because on the X'th time the b_lru_ref will be 0, and the buffer will not be re-added to the LRU. So the buffer will survive X-1 shrinker calls and not X as intended. Furthermore, if somehow we end up with the buffer sitting on the LRU and having b_lru_ref==0, this buffer will never be taken off the LRU, due to the bug. Not sure that this can happen, because by default b_lru_ref is set to 1. This issue existed since the introduction of lru in XFS buffer cache in commit "430cbeb86fdcbbdabea7d4aa65307de8de425350 xfs: add a lru to the XFS buffer cache". However, the integration with the "list_lru" insfrastructure was done in kernel 3.12, in commit "e80dfa19976b884db1ac2bc5d7d6ca0a4027bd1c xfs: convert buftarg LRU to generic code" Therefore this patch is relevant for all kernels from 3.12 to 4.15 (upstream fix was made in 4.16). Signed-off-by: Alex Lyakas <alex(a)zadara.com> Signed-off-by: Vratislav Bendel <vbendel(a)redhat.com> Reviewed-by: Brian Foster <bfoster(a)redhat.com> Reviewed-by: Christoph Hellwig <hch(a)lst.de> Reviewed-by: Darrick J. Wong <darrick.wong(a)oracle.com> Signed-off-by: Darrick J. Wong <darrick.wong(a)oracle.com> (cherry picked from commit 19957a181608d25c8f4136652d0ea00b3738972d) --- fs/xfs/xfs_buf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c index 16f93d7..e4a6239 100644 --- a/fs/xfs/xfs_buf.c +++ b/fs/xfs/xfs_buf.c @@ -1702,7 +1702,7 @@ struct xfs_buf * * zero. If the value is already zero, we need to reclaim the * buffer, otherwise it gets another trip through the LRU. */ - if (!atomic_add_unless(&bp->b_lru_ref, -1, 0)) { + if (atomic_add_unless(&bp->b_lru_ref, -1, 0)) { spin_unlock(&bp->b_lock); return LRU_ROTATE; } -- 1.9.1

4 years, 5 months

2
1
0 0

[PATCH] CIFS: Fix SMB2 oplock break processing

by Pavel Shilovsky

Even when mounting modern protocol version the server may be configured without supporting SMB2.1 leases and the client uses SMB2 oplock to optimize IO performance through local caching. However there is a problem in oplock break handling that leads to missing a break notification on the client who has a file opened. It latter causes big latencies to other clients that are trying to open the same file. The problem reproduces when there are multiple shares from the same server mounted on the client. The processing code tries to match persistent and volatile file ids from the break notification with an open file but it skips all share besides the first one. Fix this by looking up in all shares belonging to the server that issued the oplock break. Cc: Stable <stable(a)vger.kernel.org> Signed-off-by: Pavel Shilovsky <pshilov(a)microsoft.com> --- fs/cifs/smb2misc.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/fs/cifs/smb2misc.c b/fs/cifs/smb2misc.c index 8db6201b18ba..527c9efd3de0 100644 --- a/fs/cifs/smb2misc.c +++ b/fs/cifs/smb2misc.c @@ -664,10 +664,10 @@ smb2_is_valid_oplock_break(char *buffer, struct TCP_Server_Info *server) spin_lock(&cifs_tcp_ses_lock); list_for_each(tmp, &server->smb_ses_list) { ses = list_entry(tmp, struct cifs_ses, smb_ses_list); + list_for_each(tmp1, &ses->tcon_list) { tcon = list_entry(tmp1, struct cifs_tcon, tcon_list); - cifs_stats_inc(&tcon->stats.cifs_stats.num_oplock_brks); spin_lock(&tcon->open_file_lock); list_for_each(tmp2, &tcon->openFileList) { cfile = list_entry(tmp2, struct cifsFileInfo, @@ -679,6 +679,8 @@ smb2_is_valid_oplock_break(char *buffer, struct TCP_Server_Info *server) continue; cifs_dbg(FYI, "file id match, oplock break\n"); + cifs_stats_inc( + &tcon->stats.cifs_stats.num_oplock_brks); cinode = CIFS_I(d_inode(cfile->dentry)); spin_lock(&cfile->file_info_lock); if (!CIFS_CACHE_WRITE(cinode) && @@ -702,9 +704,6 @@ smb2_is_valid_oplock_break(char *buffer, struct TCP_Server_Info *server) return true; } spin_unlock(&tcon->open_file_lock); - spin_unlock(&cifs_tcp_ses_lock); - cifs_dbg(FYI, "No matching file for oplock break\n"); - return true; } } spin_unlock(&cifs_tcp_ses_lock); -- 2.17.1

4 years, 6 months

2
1
0 0

[PATCH 3.16 00/47] 3.16.76-rc1 review

by Ben Hutchings

This is the start of the stable review cycle for the 3.16.76 release. There are 47 patches in this series, which will be posted as responses to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Tue Oct 29 18:00:00 UTC 2019. Anything received after that time might be too late. All the patches have also been committed to the linux-3.16.y-rc branch of https://git.kernel.org/pub/scm/linux/kernel/git/bwh/linux-stable-rc.git . A shortlog and diffstat can be found below. Ben. ------------- Andreas Fritiofson (1): USB: serial: ftdi_sio: add ID for isodebug v1 [f8377eff548170e8ea8022c067a1fbdf9e1c46a8] Anirudh Gupta (1): xfrm: Fix xfrm sel prefix length validation [b38ff4075a80b4da5cb2202d7965332ca0efb213] Arnd Bergmann (1): ARC: hide unused function unw_hdr_alloc [fd5de2721ea7d16e2b16c4049ac49f229551b290] Boris Brezillon (1): media: v4l2: Test type instead of cfg->type in v4l2_ctrl_new_custom() [07d89227a983df957a6a7c56f7c040cde9ac571f] Brian Norris (2): mwifiex: Don't abort on small, spec-compliant vendor IEs [63d7ef36103d26f20325a921ecc96a3288560146] mwifiex: fix 802.11n/WPA detection [df612421fe2566654047769c6852ffae1a31df16] Christian Lamparter (1): carl9170: fix misuse of device driver API [feb09b2933275a70917a869989ea2823e7356be8] Christophe Leroy (4): crypto: talitos - check AES key size [1ba34e71e9e56ac29a52e0d42b6290f3dc5bfd90] lib/scatterlist: Fix mapping iterator when sg->offset is greater than PAGE_SIZE [aeb87246537a83c2aff482f3f34a2e0991e02cbc] powerpc/32s: fix suspend/resume when IBATs 4-7 are used [6ecb78ef56e08d2119d337ae23cb951a640dc52d] tty: serial: cpm_uart - fix init when SMC is relocated [06aaa3d066db87e8478522d910285141d44b1e58] Cong Wang (1): bonding: validate ip header before check IPPROTO_IGMP [9d1bc24b52fb8c5d859f9a47084bf1179470e04c] Dan Carpenter (1): eCryptfs: fix a couple type promotion bugs [0bdf8a8245fdea6f075a5fede833a5fcf1b3466c] Daniel Jordan (1): padata: use smp_mb in padata_reorder to avoid orphaned padata jobs [cf144f81a99d1a3928f90b0936accfd3f45c9a0a] Dianzhang Chen (2): x86/ptrace: Fix possible spectre-v1 in ptrace_get_debugreg() [31a2fbb390fee4231281b939e1979e810f945415] x86/tls: Fix possible spectre-v1 in do_get_thread_area() [993773d11d45c90cb1c6481c2638c3d9f092ea5b] Eiichi Tsukata (1): EDAC: Fix global-out-of-bounds write when setting edac_mc_poll_msec [d8655e7630dafa88bc37f101640e39c736399771] Eric Biggers (1): crypto: ghash - fix unaligned memory access in ghash_setkey() [5c6bc4dfa515738149998bb0db2481a4fdead979] Eric Dumazet (1): igmp: fix memory leak in igmpv3_del_delrec() [e5b1c6c6277d5a283290a8c033c72544746f9b5b] Eric W. Biederman (1): signal/pid_namespace: Fix reboot_pid_ns to use send_sig not force_sig [f9070dc94542093fd516ae4ccea17ef46a4362c5] Heiko Carstens (1): s390: fix stfle zero padding [4f18d869ffd056c7858f3d617c71345cf19be008] Helge Deller (1): parisc: Fix kernel panic due invalid values in IAOQ0 or IAOQ1 [10835c854685393a921b68f529bf740fa7c9984d] Jan Harkes (1): coda: pass the host file in vma->vm_file on mmap [7fa0a1da3dadfd9216df7745a1331fdaa0940d1c] Jean-Philippe Brucker (1): mm/mmu_notifier: use hlist_add_head_rcu() [543bdb2d825fe2400d6e951f1786d92139a16931] Jeremy Sowden (1): af_key: fix leaks in key_pol_get_resp and dump_sp. [7c80eb1c7e2b8420477fbc998971d62a648035d9] Julian Wiedmann (3): s390/qdio: (re-)initialize tiqdio list entries [e54e4785cb5cb4896cf4285964aeef2125612fb2] s390/qdio: don't touch the dsci in tiqdio_add_input_queues() [ac6639cd3db607d386616487902b4cc1850a7be5] s390/qdio: handle PENDING state for QEBSM devices [04310324c6f482921c071444833e70fe861b73d9] Jörgen Storvist (2): USB: serial: option: add GosunCn ZTE WeLink ME3630 [70a7444c550a75584ffcfae95267058817eff6a7] USB: serial: option: add support for GosunCn ME3630 RNDIS mode [aed2a26283528fb69c38e414f649411aa48fb391] Kiruthika Varadarajan (1): usb: gadget: ether: Fix race between gether_disconnect and rx_submit [d29fcf7078bc8be2b6366cbd4418265b53c94fac] Like Xu (1): KVM: x86/vPMU: refine kvm_pmu err msg when event creation failed [6fc3977ccc5d3c22e851f2dce2d3ce2a0a843842] Lorenzo Bianconi (1): net: neigh: fix multiple neigh timer scheduling [071c37983d99da07797294ea78e9da1a6e287144] Mika Westerberg (1): PCI: Do not poll for PME if the device is in D3cold [000dd5316e1c756a1c028f22e01d06a38249dd4d] Nicolas Dichtel (1): xfrm: fix sa selector validation [b8d6d0079757cbd1b69724cfd1c08e2171c68cee] Nikolay Aleksandrov (1): net: bridge: stp: don't cache eth dest pointer before skb pull [2446a68ae6a8cee6d480e2f5b52f5007c7c41312] Ravi Bangoria (1): powerpc/watchpoint: Restore NV GPRs while returning from exception [f474c28fbcbe42faca4eb415172c07d76adcb819] Russell King (2): ARM: riscpc: fix DMA [ffd9a1ba9fdb7f2bd1d1ad9b9243d34e96756ba2] gpio: omap: fix lack of irqstatus_raw0 for OMAP4 [64ea3e9094a1f13b96c33244a3fb3a0f45690bd2] Steven J. Magnani (1): udf: Fix incorrect final NOT_ALLOCATED (hole) extent length [fa33cdbf3eceb0206a4f844fe91aeebcf6ff2b7a] Taehee Yoo (1): caif-hsi: fix possible deadlock in cfhsi_exit_module() [fdd258d49e88a9e0b49ef04a506a796f1c768a8e] Takashi Iwai (1): ALSA: seq: Break too long mutex context in the write loop [ede34f397ddb063b145b9e7d79c6026f819ded13] Trond Myklebust (1): NFSv4: Handle the special Linux file open access mode [44942b4e457beda00981f616402a1a791e8c616e] Vishnu DASA (1): VMCI: Fix integer overflow in VMCI handle arrays [1c2eb5b2853c9f513690ba6b71072d8eb65da16a] Wang Hai (1): memstick: Fix error cleanup path of memstick_init [65f1a0d39c289bb6fc85635528cd36c4b07f560e] YueHaibing (2): 9p/virtio: Add cleanup path in p9_virtio_init [d4548543fc4ece56c6f04b8586f435fb4fd84c20] Input: psmouse - fix build error of multiple definition [49e6979e7e92cf496105b5636f1df0ac17c159c0] Makefile | 4 +- arch/arc/kernel/unwind.c | 9 ++- arch/arm/mach-rpc/dma.c | 5 +- arch/parisc/kernel/ptrace.c | 28 +++++---- arch/powerpc/kernel/exceptions-64s.S | 9 ++- arch/powerpc/kernel/swsusp_32.S | 73 +++++++++++++++++++--- arch/powerpc/platforms/powermac/sleep.S | 68 +++++++++++++++++++-- arch/s390/include/asm/facility.h | 21 ++++--- arch/x86/kernel/ptrace.c | 4 +- arch/x86/kernel/tls.c | 9 ++- arch/x86/kvm/pmu.c | 4 +- crypto/ghash-generic.c | 8 ++- drivers/crypto/talitos.c | 13 ++++ drivers/edac/edac_mc_sysfs.c | 16 ++--- drivers/edac/edac_module.h | 2 +- drivers/gpio/gpio-omap.c | 2 + drivers/input/mouse/trackpoint.h | 3 +- drivers/media/v4l2-core/v4l2-ctrls.c | 9 ++- drivers/memstick/core/memstick.c | 13 ++-- drivers/misc/vmw_vmci/vmci_context.c | 80 ++++++++++++++----------- drivers/misc/vmw_vmci/vmci_handle_array.c | 38 ++++++++---- drivers/misc/vmw_vmci/vmci_handle_array.h | 29 +++++---- drivers/net/bonding/bond_main.c | 37 +++++++----- drivers/net/caif/caif_hsi.c | 2 +- drivers/net/wireless/ath/carl9170/usb.c | 39 ++++++------ drivers/net/wireless/mwifiex/fw.h | 12 +++- drivers/net/wireless/mwifiex/main.h | 1 + drivers/net/wireless/mwifiex/scan.c | 21 ++++--- drivers/net/wireless/mwifiex/sta_ioctl.c | 4 +- drivers/net/wireless/mwifiex/wmm.c | 2 +- drivers/pci/pci.c | 7 +++ drivers/s390/cio/qdio_main.c | 1 + drivers/s390/cio/qdio_setup.c | 2 + drivers/s390/cio/qdio_thinint.c | 5 +- drivers/tty/serial/cpm_uart/cpm_uart_core.c | 17 ++++-- drivers/usb/gadget/u_ether.c | 6 +- drivers/usb/serial/ftdi_sio.c | 1 + drivers/usb/serial/ftdi_sio_ids.h | 6 ++ drivers/usb/serial/option.c | 3 + fs/coda/file.c | 70 +++++++++++++++++++++- fs/ecryptfs/crypto.c | 12 ++-- fs/nfs/inode.c | 1 + fs/nfs/nfs4file.c | 2 +- fs/udf/inode.c | 93 +++++++++++++++++++---------- include/linux/vmw_vmci_defs.h | 11 +++- kernel/padata.c | 12 ++++ kernel/pid_namespace.c | 2 +- lib/scatterlist.c | 9 +-- mm/mmu_notifier.c | 2 +- net/9p/trans_virtio.c | 8 ++- net/bridge/br_stp_bpdu.c | 3 +- net/core/neighbour.c | 2 + net/ipv4/igmp.c | 8 +-- net/key/af_key.c | 8 ++- net/xfrm/xfrm_user.c | 19 ++++++ sound/core/seq/seq_clientmgr.c | 11 +++- 56 files changed, 642 insertions(+), 244 deletions(-) -- Ben Hutchings Humans are not rational beings; they are rationalising beings.

4 years, 6 months

5
56
0 0

[PATCH v2] Revert "nvme: Add quirk for Kingston NVME SSD running FW E8FK11.T"

by Jian-Hong Pan

Since commit 253eaf4faaaa ("PCI/MSI: Fix incorrect MSI-X masking on resume") is merged, we can revert the previous quirk now. This reverts commit 19ea025e1d28c629b369c3532a85b3df478cc5c6. Fixes: 19ea025e1d28 ("nvme: Add quirk for Kingston NVME SSD running FW E8FK11.T") Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=204887 Signed-off-by: Jian-Hong Pan <jian-hong(a)endlessm.com> Cc: stable(a)vger.kernel.org --- v2: Re-send for mailing failure drivers/nvme/host/core.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index fa7ba09dca77..94bfbee1e5f7 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -2404,16 +2404,6 @@ static const struct nvme_core_quirk_entry core_quirks[] = { .vid = 0x14a4, .fr = "22301111", .quirks = NVME_QUIRK_SIMPLE_SUSPEND, - }, - { - /* - * This Kingston E8FK11.T firmware version has no interrupt - * after resume with actions related to suspend to idle - * https://bugzilla.kernel.org/show_bug.cgi?id=204887 - */ - .vid = 0x2646, - .fr = "E8FK11.T", - .quirks = NVME_QUIRK_SIMPLE_SUSPEND, } }; -- 2.23.0

4 years, 6 months

3
3
0 0

[PATCH for-rc 1/4] IB/hfi1: Allow for all speeds higher than gen3

by Dennis Dalessandro

From: James Erwin <james.erwin(a)intel.com> The driver avoids the gen3 speed bump when the parent bus speed isn't identical to gen3, 8.0GT/s. This is not compatible with gen4 and newer speeds. Fix by relaxing the test to explicitly look for the lower capability speeds which inherently allows for all future speeds. Fixes: 7724105686e7 ("IB/hfi1: add driver files") Cc: <stable(a)vger.kernel.org> Reviewed-by: Dennis Dalessandro <dennis.dalessandro(a)intel.com> Reviewed-by: Kaike Wan <kaike.wan(a)intel.com> Signed-off-by: James Erwin <james.erwin(a)intel.com> Signed-off-by: Mike Marciniszyn <mike.marciniszyn(a)intel.com> Signed-off-by: Dennis Dalessandro <dennis.dalessandro(a)intel.com> --- drivers/infiniband/hw/hfi1/pcie.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/hfi1/pcie.c b/drivers/infiniband/hw/hfi1/pcie.c index 61aa550..61362bd 100644 --- a/drivers/infiniband/hw/hfi1/pcie.c +++ b/drivers/infiniband/hw/hfi1/pcie.c @@ -319,7 +319,9 @@ int pcie_speeds(struct hfi1_devdata *dd) /* * bus->max_bus_speed is set from the bridge's linkcap Max Link Speed */ - if (parent && dd->pcidev->bus->max_bus_speed != PCIE_SPEED_8_0GT) { + if (parent && + (dd->pcidev->bus->max_bus_speed == PCIE_SPEED_2_5GT || + dd->pcidev->bus->max_bus_speed == PCIE_SPEED_5_0GT)) { dd_dev_info(dd, "Parent PCIe bridge does not support Gen3\n"); dd->link_gen3_capable = 0; }

4 years, 6 months

3
5
0 0

[PATCH v4 1/2] sched/topology: Don't try to build empty sched domains

by Valentin Schneider

Turns out hotplugging CPUs that are in exclusive cpusets can lead to the cpuset code feeding empty cpumasks to the sched domain rebuild machinery. This leads to the following splat: [ 30.618174] Internal error: Oops: 96000004 [#1] PREEMPT SMP [ 30.623697] Modules linked in: [ 30.626731] CPU: 0 PID: 235 Comm: kworker/5:2 Not tainted 5.4.0-rc1-00005-g8d495477d62e #23 [ 30.635003] Hardware name: ARM Juno development board (r0) (DT) [ 30.640877] Workqueue: events cpuset_hotplug_workfn [ 30.645713] pstate: 60000005 (nZCv daif -PAN -UAO) [ 30.650464] pc : build_sched_domains (./include/linux/arch_topology.h:23 kernel/sched/topology.c:1898 kernel/sched/topology.c:1969) [ 30.655126] lr : build_sched_domains (kernel/sched/topology.c:1966) [...] [ 30.742047] Call trace: [ 30.744474] build_sched_domains (./include/linux/arch_topology.h:23 kernel/sched/topology.c:1898 kernel/sched/topology.c:1969) [ 30.748793] partition_sched_domains_locked (kernel/sched/topology.c:2250) [ 30.753971] rebuild_sched_domains_locked (./include/linux/bitmap.h:370 ./include/linux/cpumask.h:538 kernel/cgroup/cpuset.c:955 kernel/cgroup/cpuset.c:978 kernel/cgroup/cpuset.c:1019) [ 30.758977] rebuild_sched_domains (kernel/cgroup/cpuset.c:1032) [ 30.763209] cpuset_hotplug_workfn (kernel/cgroup/cpuset.c:3205 (discriminator 2)) [ 30.767613] process_one_work (./arch/arm64/include/asm/jump_label.h:21 ./include/linux/jump_label.h:200 ./include/trace/events/workqueue.h:114 kernel/workqueue.c:2274) [ 30.771586] worker_thread (./include/linux/compiler.h:199 ./include/linux/list.h:268 kernel/workqueue.c:2416) [ 30.775217] kthread (kernel/kthread.c:255) [ 30.778418] ret_from_fork (arch/arm64/kernel/entry.S:1167) [ 30.781965] Code: f860dae2 912802d6 aa1603e1 12800000 (f8616853) The faulty line in question is cap = arch_scale_cpu_capacity(cpumask_first(cpu_map)); and we're not checking the return value against nr_cpu_ids (we shouldn't have to!), which leads to the above. Prevent generate_sched_domains() from returning empty cpumasks, and add some assertion in build_sched_domains() to scream bloody murder if it happens again. The above splat was obtained on my Juno r0 with: cgcreate -g cpuset:asym cgset -r cpuset.cpus=0-3 asym cgset -r cpuset.mems=0 asym cgset -r cpuset.cpu_exclusive=1 asym cgcreate -g cpuset:smp cgset -r cpuset.cpus=4-5 smp cgset -r cpuset.mems=0 smp cgset -r cpuset.cpu_exclusive=1 smp cgset -r cpuset.sched_load_balance=0 . echo 0 > /sys/devices/system/cpu/cpu4/online echo 0 > /sys/devices/system/cpu/cpu5/online Cc: <stable(a)vger.kernel.org> Fixes: 05484e098448 ("sched/topology: Add SD_ASYM_CPUCAPACITY flag detection") Signed-off-by: Valentin Schneider <valentin.schneider(a)arm.com> --- kernel/cgroup/cpuset.c | 3 ++- kernel/sched/topology.c | 5 ++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index c52bc91f882b..c87ee6412b36 100644 --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -798,7 +798,8 @@ static int generate_sched_domains(cpumask_var_t **domains, cpumask_subset(cp->cpus_allowed, top_cpuset.effective_cpus)) continue; - if (is_sched_load_balance(cp)) + if (is_sched_load_balance(cp) && + !cpumask_empty(cp->effective_cpus)) csa[csn++] = cp; /* skip @cp's subtree if not a partition root */ diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 3623ffe85d18..2e7af755e17a 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -1945,7 +1945,7 @@ static struct sched_domain_topology_level static int build_sched_domains(const struct cpumask *cpu_map, struct sched_domain_attr *attr) { - enum s_alloc alloc_state; + enum s_alloc alloc_state = sa_none; struct sched_domain *sd; struct s_data d; struct rq *rq = NULL; @@ -1953,6 +1953,9 @@ build_sched_domains(const struct cpumask *cpu_map, struct sched_domain_attr *att struct sched_domain_topology_level *tl_asym; bool has_asym = false; + if (WARN_ON(cpumask_empty(cpu_map))) + goto error; + alloc_state = __visit_domain_allocation_hell(&d, cpu_map); if (alloc_state != sa_rootdomain) goto error; -- 2.22.0

4 years, 6 months

3
5
0 0

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror October 2019