November 2019 - Linux-stable-mirror

Re: [PATCH 2/3] rtlwifi: rtl8192de: Fix missing callback that tests for hw release of buffer

by Larry Finger

On 11/22/19 1:00 AM, Sasha Levin wrote: > Hi, > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag, > fixing commit: 38506ecefab9 ("rtlwifi: rtl_pci: Start modification for new drivers"). > > The bot has tested the following trees: v5.3.11, v4.19.84, v4.14.154, v4.9.201, v4.4.201. > > v5.3.11: Build OK! > v4.19.84: Build OK! > v4.14.154: Failed to apply! Possible dependencies: > 0c07bd745760 ("rtlwifi: rtl8192ee: Make driver support 64bits DMA.") > > v4.9.201: Failed to apply! Possible dependencies: > 004a1e167905 ("rtlwifi: rtl8821ae: Remove all instances of DBG_EMERG") > 02527a73beb3 ("rtlwifi: rtl8188ee: Remove all instances of DBG_EMERG") > 0c07bd745760 ("rtlwifi: rtl8192ee: Make driver support 64bits DMA.") > 102e295ed5a4 ("rtlwifi: Redo debugging macros RTPRINT and RT_PRINT_DATA") > 2d15acac2354 ("rtlwifi: rtl8192se: Remove all instances of DBG_EMERG") > 4e2b4378f9d7 ("rtlwifi: rtl8723be: Remove all instances of DBG_EMERG") > a44f59d60365 ("rtlwifi: rtl8192ee: Remove all instances of DBG_EMERG") > a67005bc46d9 ("rtlwifi: rtl8723ae: Remove all instances of DBG_EMERG") > b8c79f454880 ("rtlwifi: rtl8192de: Remove all instances of DBG_EMERG") > c34df318ec9f ("rtlwifi: Convert COMP_XX entries into a proper debugging mask") > c38af3f06af4 ("rtlwifi: rtl8192cu: Remove all instances of DBG_EMERG") > e40a005652ad ("rtlwifi: rtl8192ce: Remove all instances of DBG_EMERG") > > v4.4.201: Failed to apply! Possible dependencies: > 02527a73beb3 ("rtlwifi: rtl8188ee: Remove all instances of DBG_EMERG") > 0c07bd745760 ("rtlwifi: rtl8192ee: Make driver support 64bits DMA.") > 102e295ed5a4 ("rtlwifi: Redo debugging macros RTPRINT and RT_PRINT_DATA") > 4713bd1c7407 ("rtlwifi: Add missing newlines to RT_TRACE calls") > 5345ea6a4bfb ("rtlwifi: fix error handling in *_read_adapter_info()") > 9ce221915a94 ("rtlwifi: Create _rtl_dbg_trace function to reduce RT_TRACE code size") > ad5748893b27 ("rtlwifi: Add switch variable to 'switch case not processed' messages") > b8c79f454880 ("rtlwifi: rtl8192de: Remove all instances of DBG_EMERG") > c34df318ec9f ("rtlwifi: Convert COMP_XX entries into a proper debugging mask") > c38af3f06af4 ("rtlwifi: rtl8192cu: Remove all instances of DBG_EMERG") > e40a005652ad ("rtlwifi: rtl8192ce: Remove all instances of DBG_EMERG") > > > NOTE: The patch will not be queued to stable trees until it is upstream. > > How should we proceed with this patch? Sasha, The underlying directories were moved from drivers/net/wireless/rtlwifi/ to drivers/net/wireless/realtek/rtlwifi/. I can refactor the patches to account for this change. How should I annotate them, and where should I send them? Larry

5 years, 3 months

1
0
0 0

[PATCH 4.4 1/9] ARM: 8904/1: skip nomap memblocks while finding the lowmem/highmem boundary

by Lee Jones

From: Chester Lin <clin(a)suse.com> [ Upstream commit 1d31999cf04c21709f72ceb17e65b54a401330da ] adjust_lowmem_bounds() checks every memblocks in order to find the boundary between lowmem and highmem. However some memblocks could be marked as NOMAP so they are not used by kernel, which should be skipped while calculating the boundary. Signed-off-by: Chester Lin <clin(a)suse.com> Reviewed-by: Mike Rapoport <rppt(a)linux.ibm.com> Signed-off-by: Russell King <rmk+kernel(a)armlinux.org.uk> Signed-off-by: Lee Jones <lee.jones(a)linaro.org> --- arch/arm/mm/mmu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c index aead23f15213..d9ddb5721565 100644 --- a/arch/arm/mm/mmu.c +++ b/arch/arm/mm/mmu.c @@ -1121,6 +1121,9 @@ void __init sanity_check_meminfo(void) phys_addr_t block_end = reg->base + reg->size; phys_addr_t size_limit = reg->size; + if (memblock_is_nomap(reg)) + continue; + if (reg->base >= vmalloc_limit) highmem = 1; else -- 2.24.0

5 years, 3 months

1
9
0 0

[stable 4.19+][PATCH 01/20] i2c: stm32f7: fix first byte to send in slave mode

by Mathieu Poirier

From: Fabrice Gasnier <fabrice.gasnier(a)st.com> commit 915da2b794ce4fc98b1acf64d64354f22a5e4931 upstream The slave-interface documentation [1] states "the bus driver should transmit the first byte" upon I2C_SLAVE_READ_REQUESTED slave event: - 'val': backend returns first byte to be sent The driver currently ignores the 1st byte to send on this event. [1] https://www.kernel.org/doc/Documentation/i2c/slave-interface Fixes: 60d609f30de2 ("i2c: i2c-stm32f7: Add slave support") Signed-off-by: Fabrice Gasnier <fabrice.gasnier(a)st.com> Reviewed-by: Pierre-Yves MORDRET <pierre-yves.mordret(a)st.com> Signed-off-by: Wolfram Sang <wsa(a)the-dreams.de> Cc: stable <stable(a)vger.kernel.org> # 4.19+ Signed-off-by: Mathieu Poirier <mathieu.poirier(a)linaro.org> --- drivers/i2c/busses/i2c-stm32f7.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c index ac9c9486b834..48521bc8a4d2 100644 --- a/drivers/i2c/busses/i2c-stm32f7.c +++ b/drivers/i2c/busses/i2c-stm32f7.c @@ -1177,6 +1177,8 @@ static void stm32f7_i2c_slave_start(struct stm32f7_i2c_dev *i2c_dev) STM32F7_I2C_CR1_TXIE; stm32f7_i2c_set_bits(base + STM32F7_I2C_CR1, mask); + /* Write 1st data byte */ + writel_relaxed(value, base + STM32F7_I2C_TXDR); } else { /* Notify i2c slave that new write transfer is starting */ i2c_slave_event(slave, I2C_SLAVE_WRITE_REQUESTED, &value); -- 2.17.1

5 years, 3 months

2
21
0 0

Re: Linux 5.3.12 BOOT TEST: Compiled, Booted, everything OK.

by Greg KH

On Thu, Nov 21, 2019 at 03:55:34PM -0300, Daniel W. S. Almeida wrote: > ~ 2hr uptime: no crashes, no new errors on dmesg, everything looks good. Thanks for testing. > *This pops up after diffing the output of kselftest though:* > > < # ./reuseport_bpf: Unable to open tcp_fastopen sysctl for writing: > Permission denied > --- > > # ./reuseport_bpf: ebpf error. log: > > # 0: (bf) r6 = r1 > > # 1: (20) r0 = *(u32 *)skb[0] > > # 2: (97) r0 %= 10 > > # 3: (95) exit > > # processed 4 insns (limit 1000000) max_states_per_insn 0 total_states 0 > peak_states 0 mark_read 0 > > # > > # : Operation not permitted > > I did not run kselftest as root. I assume it is nothing noteworthy? Is this a new issue, or has it always been there? thanks, greg k-h

5 years, 3 months

2
1
0 0

[PATCH 1/2] iomap: Fix pipe page leakage during splicing

by Jan Kara

When splicing using iomap_dio_rw() to a pipe, we may leak pipe pages because bio_iov_iter_get_pages() records that the pipe will have full extent worth of data however if file size is not block size aligned iomap_dio_rw() returns less than what bio_iov_iter_get_pages() set up and splice code gets confused leaking a pipe page with the file tail. Handle the situation similarly to the old direct IO implementation and revert iter to actually returned read amount which makes iter consistent with value returned from iomap_dio_rw() and thus the splice code is happy. Fixes: ff6a9292e6f6 ("iomap: implement direct I/O") CC: stable(a)vger.kernel.org Reported-by: syzbot+991400e8eba7e00a26e1(a)syzkaller.appspotmail.com Signed-off-by: Jan Kara <jack(a)suse.cz> --- fs/iomap/direct-io.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c index 1fc28c2da279..30189652c560 100644 --- a/fs/iomap/direct-io.c +++ b/fs/iomap/direct-io.c @@ -497,8 +497,15 @@ iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter, } pos += ret; - if (iov_iter_rw(iter) == READ && pos >= dio->i_size) + if (iov_iter_rw(iter) == READ && pos >= dio->i_size) { + /* + * We will report we've read data only upto i_size. + * Revert iter to a state corresponding to that as + * some callers (such as splice code) rely on it. + */ + iov_iter_revert(iter, pos - dio->i_size); break; + } } while ((count = iov_iter_count(iter)) > 0); blk_finish_plug(&plug); -- 2.16.4

5 years, 3 months

4
4
0 0

✅ PASS: Test report for kernel 5.3.13-rc1-6b14caa.cki (stable)

by CKI Project

Hello, We ran automated tests on a recent commit from this kernel tree: Kernel repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Commit: 6b14caa1dc57 - Linux 5.3.13-rc1 The results of these automated tests are provided below. Overall result: PASSED Merge: OK Compile: OK Tests: OK All kernel binaries, config files, and logs are available for download here: https://artifacts.cki-project.org/pipelines/301338 Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Compile testing --------------- We compiled the kernel for 3 architectures: aarch64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg ppc64le: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg x86_64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ppc64le: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. x86_64: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. Test sources: https://github.com/CKI-project/tests-beaker 💚 Pull requests are welcome for new tests or improvements to existing tests! Waived tests ------------ If the test run included waived tests, they are marked with 🚧. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed. Testing timeout --------------- We aim to provide a report within reasonable timeframe. Tests that haven't finished running are marked with ⏱. Reports for non-upstream kernels have a Beaker recipe linked to next to each host.

5 years, 3 months

1
0
0 0

Re: [PATCH v4 3/8] media: v4l2-core: compat: ignore native command codes

by Arnd Bergmann

On Fri, Nov 22, 2019 at 8:00 AM Sasha Levin <sashal(a)kernel.org> wrote: > > Hi, > > [This is an automated email] > > This commit has been processed because it contains a -stable tag. > The stable tag indicates that it's relevant for the following trees: all > > The bot has tested the following trees: v5.3.11, v4.19.84, v4.14.154, v4.9.201, v4.4.201. > > v5.3.11: Build OK! > v4.19.84: Build OK! Ok, good. > v4.14.154: Failed to apply! Possible dependencies: > 6dd0394f5fcd ("media: v4l2-compat-ioctl32: better name userspace pointers") > fef6cc6b3618 ("media: v4l2-compat-ioctl32: fix several __user annotations") The fef6cc6b3618 is probably a candidate for backporting (it fixes smatch and sparse warnings and should have no other effect), the 6dd0394f5fcd may be a little too big (but also harmless). The downside of not backporting the patch is that user space code built with 64-bit time_t would get incorrect data rather than failing with an error code on older kernels. I do not expect to see backports of 64-bit time_t support to kernels older than 4.19, so this probably won't matter much, but in theory it's still possible that users can run into it. > v4.9.201: Failed to apply! Possible dependencies: > 6dd0394f5fcd ("media: v4l2-compat-ioctl32: better name userspace pointers") > a56bc171598c ("[media] v4l: compat: Prevent allocating excessive amounts of memory") > ba7ed691dcce ("[media] v4l2-compat-ioctl32: VIDIOC_S_EDID should return all fields on error") > fb9ffa6a7f7e ("[media] v4l: Add metadata buffer type and format") > fef6cc6b3618 ("media: v4l2-compat-ioctl32: fix several __user annotations") > > v4.4.201: Failed to apply! Possible dependencies: > 0579e6e3a326 ("doc-rst: linux_tv: remove whitespaces") > 17defc282fe6 ("Documentation: add meta-documentation for Sphinx and kernel-doc") > 22cba31bae9d ("Documentation/sphinx: add basic working Sphinx configuration and build") > 234d549662a7 ("doc-rst: video: use reference for VIDIOC_ENUMINPUT") > 5377d91f3e88 ("doc-rst: linux_tv DocBook to reST migration (docs-next)") > 6dd0394f5fcd ("media: v4l2-compat-ioctl32: better name userspace pointers") > 7347081e8a52 ("doc-rst: linux_tv: simplify references") > 789818845202 ("doc-rst: audio: Fix some cross references") > 94fff0dc5333 ("doc-rst: dmx_fcalls: improve man-like format") > 9e00ffca8cc7 ("doc-rst: querycap: fix troubles on some references") > af4a4d0db8ab ("doc-rst: linux_tv: Replace reference names to match ioctls") > c2b66cafdf02 ("[media] v4l: doc: Remove row numbers from tables") > e6702ee18e24 ("doc-rst: app-pri: Fix a bad reference") > fb9ffa6a7f7e ("[media] v4l: Add metadata buffer type and format") > > > NOTE: The patch will not be queued to stable trees until it is upstream. > > How should we proceed with this patch? I'm happy to provide a hand-backported version of the patch for the older kernels if Mauro and Hans think we should do that, otherwise I think it's we're fine with having it on 4.19+. Arnd

5 years, 3 months

1
0
0 0

[PATCH V2] clk: imx: clk-imx7ulp: Add missing sentinel of ulp_div_table

by Peng Fan

From: Peng Fan <peng.fan(a)nxp.com> There should be a sentinel of ulp_div_table, otherwise _get_table_div may access data out of the array. Fixes: b1260067ac3d ("clk: imx: add imx7ulp clk driver") Cc: stable(a)vger.kernel.org Signed-off-by: Peng Fan <peng.fan(a)nxp.com> --- V2: cc stable mail list drivers/clk/imx/clk-imx7ulp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/imx/clk-imx7ulp.c b/drivers/clk/imx/clk-imx7ulp.c index 3fdf3d494f0a..281191b55b3a 100644 --- a/drivers/clk/imx/clk-imx7ulp.c +++ b/drivers/clk/imx/clk-imx7ulp.c @@ -40,6 +40,7 @@ static const struct clk_div_table ulp_div_table[] = { { .val = 5, .div = 16, }, { .val = 6, .div = 32, }, { .val = 7, .div = 64, }, + { /* sentinel */ }, }; static const int pcc2_uart_clk_ids[] __initconst = { -- 2.16.4

5 years, 3 months

2
1
0 0

patch "staging: comedi: usbduxfast: usbduxfast_ai_cmdtest rounding error" added to staging-next

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled staging: comedi: usbduxfast: usbduxfast_ai_cmdtest rounding error to my staging git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git in the staging-next branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will also be merged in the next major kernel release during the merge window. If you have any questions about this process, please let me know. >From 5618332e5b955b4bff06d0b88146b971c8dd7b32 Mon Sep 17 00:00:00 2001 From: Bernd Porr <mail(a)berndporr.me.uk> Date: Mon, 18 Nov 2019 23:07:59 +0000 Subject: staging: comedi: usbduxfast: usbduxfast_ai_cmdtest rounding error The userspace comedilib function 'get_cmd_generic_timed' fills the cmd structure with an informed guess and then calls the function 'usbduxfast_ai_cmdtest' in this driver repeatedly while 'usbduxfast_ai_cmdtest' is modifying the cmd struct until it no longer changes. However, because of rounding errors this never converged because 'steps = (cmd->convert_arg * 30) / 1000' and then back to 'cmd->convert_arg = (steps * 1000) / 30' won't be the same because of rounding errors. 'Steps' should only be converted back to the 'convert_arg' if 'steps' has actually been modified. In addition the case of steps being 0 wasn't checked which is also now done. Signed-off-by: Bernd Porr <mail(a)berndporr.me.uk> Cc: <stable(a)vger.kernel.org> # 4.4+ Reviewed-by: Ian Abbott <abbotti(a)mev.co.uk> Link: https://lore.kernel.org/r/20191118230759.1727-1-mail@berndporr.me.uk Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/staging/comedi/drivers/usbduxfast.c | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers/staging/comedi/drivers/usbduxfast.c b/drivers/staging/comedi/drivers/usbduxfast.c index 04bc488385e6..4af012968cb6 100644 --- a/drivers/staging/comedi/drivers/usbduxfast.c +++ b/drivers/staging/comedi/drivers/usbduxfast.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0+ /* - * Copyright (C) 2004-2014 Bernd Porr, mail(a)berndporr.me.uk + * Copyright (C) 2004-2019 Bernd Porr, mail(a)berndporr.me.uk */ /* @@ -8,7 +8,7 @@ * Description: University of Stirling USB DAQ & INCITE Technology Limited * Devices: [ITL] USB-DUX-FAST (usbduxfast) * Author: Bernd Porr <mail(a)berndporr.me.uk> - * Updated: 10 Oct 2014 + * Updated: 16 Nov 2019 * Status: stable */ @@ -22,6 +22,7 @@ * * * Revision history: + * 1.0: Fixed a rounding error in usbduxfast_ai_cmdtest * 0.9: Dropping the first data packet which seems to be from the last transfer. * Buffer overflows in the FX2 are handed over to comedi. * 0.92: Dropping now 4 packets. The quad buffer has to be emptied. @@ -350,6 +351,7 @@ static int usbduxfast_ai_cmdtest(struct comedi_device *dev, struct comedi_cmd *cmd) { int err = 0; + int err2 = 0; unsigned int steps; unsigned int arg; @@ -399,11 +401,16 @@ static int usbduxfast_ai_cmdtest(struct comedi_device *dev, */ steps = (cmd->convert_arg * 30) / 1000; if (cmd->chanlist_len != 1) - err |= comedi_check_trigger_arg_min(&steps, - MIN_SAMPLING_PERIOD); - err |= comedi_check_trigger_arg_max(&steps, MAX_SAMPLING_PERIOD); - arg = (steps * 1000) / 30; - err |= comedi_check_trigger_arg_is(&cmd->convert_arg, arg); + err2 |= comedi_check_trigger_arg_min(&steps, + MIN_SAMPLING_PERIOD); + else + err2 |= comedi_check_trigger_arg_min(&steps, 1); + err2 |= comedi_check_trigger_arg_max(&steps, MAX_SAMPLING_PERIOD); + if (err2) { + err |= err2; + arg = (steps * 1000) / 30; + err |= comedi_check_trigger_arg_is(&cmd->convert_arg, arg); + } if (cmd->stop_src == TRIG_COUNT) err |= comedi_check_trigger_arg_min(&cmd->stop_arg, 1); -- 2.24.0

5 years, 3 months

1
0
0 0

patch "serial: stm32: fix clearing interrupt error flags" added to tty-next

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled serial: stm32: fix clearing interrupt error flags to my tty git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git in the tty-next branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will also be merged in the next major kernel release during the merge window. If you have any questions about this process, please let me know. >From 1250ed7114a977cdc2a67a0c09d6cdda63970eb9 Mon Sep 17 00:00:00 2001 From: Fabrice Gasnier <fabrice.gasnier(a)st.com> Date: Thu, 21 Nov 2019 09:10:49 +0100 Subject: serial: stm32: fix clearing interrupt error flags The interrupt clear flag register is a "write 1 to clear" register. So, only writing ones allows to clear flags: - Replace buggy stm32_clr_bits() by a simple write to clear error flags - Replace useless read/modify/write stm32_set_bits() routine by a simple write to clear TC (transfer complete) flag. Fixes: 4f01d833fdcd ("serial: stm32: fix rx error handling") Signed-off-by: Fabrice Gasnier <fabrice.gasnier(a)st.com> Cc: stable <stable(a)vger.kernel.org> Link: https://lore.kernel.org/r/1574323849-1909-1-git-send-email-fabrice.gasnier@… Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/tty/serial/stm32-usart.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c index df90747ee3a8..2f72514d63ed 100644 --- a/drivers/tty/serial/stm32-usart.c +++ b/drivers/tty/serial/stm32-usart.c @@ -240,8 +240,8 @@ static void stm32_receive_chars(struct uart_port *port, bool threaded) * cleared by the sequence [read SR - read DR]. */ if ((sr & USART_SR_ERR_MASK) && ofs->icr != UNDEF_REG) - stm32_clr_bits(port, ofs->icr, USART_ICR_ORECF | - USART_ICR_PECF | USART_ICR_FECF); + writel_relaxed(sr & USART_SR_ERR_MASK, + port->membase + ofs->icr); c = stm32_get_char(port, &sr, &stm32_port->last_res); port->icount.rx++; @@ -435,7 +435,7 @@ static void stm32_transmit_chars(struct uart_port *port) if (ofs->icr == UNDEF_REG) stm32_clr_bits(port, ofs->isr, USART_SR_TC); else - stm32_set_bits(port, ofs->icr, USART_ICR_TCCF); + writel_relaxed(USART_ICR_TCCF, port->membase + ofs->icr); if (stm32_port->tx_ch) stm32_transmit_chars_dma(port); -- 2.24.0

5 years, 3 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror November 2019