Hello,
We ran automated tests on a patchset that was proposed for merging into this
kernel tree. The patches were applied to:
Kernel repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
Commit: e109a984cf38 - Linux 4.19.48
The results of these automated tests are provided below.
Overall result: FAILED (see details below)
Merge: OK
Compile: FAILED
We attempted to compile the kernel for multiple architectures, but the compile
failed on one or more architectures:
aarch64: FAILED (see build-aarch64.log.xz attachment)
We hope that these logs can help you find the problem quickly. For the full
detail on our testing procedures, please scroll to the bottom of this message.
Please reply to this email if you have any questions about the tests that we
ran or if you have any suggestions on how to make future tests more effective.
,-. ,-.
( C ) ( K ) Continuous
`-',-.`-' Kernel
( I ) Integration
`-'
______________________________________________________________________________
Merge testing
-------------
We cloned this repository and checked out the following commit:
Repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
Commit: e109a984cf38 - Linux 4.19.48
We then merged the patchset with `git am`:
sparc64-fix-regression-in-non-hypervisor-tlb-flush-xcall.patch
include-linux-bitops.h-sanitize-rotate-primitives.patch
xhci-update-bounce-buffer-with-correct-sg-num.patch
xhci-use-zu-for-printing-size_t-type.patch
xhci-convert-xhci_handshake-to-use-readl_poll_timeout_atomic.patch
usb-xhci-avoid-null-pointer-deref-when-bos-field-is-null.patch
usbip-usbip_host-fix-bug-sleeping-function-called-from-invalid-context.patch
usbip-usbip_host-fix-stub_dev-lock-context-imbalance-regression.patch
usb-fix-slab-out-of-bounds-write-in-usb_get_bos_descriptor.patch
usb-sisusbvga-fix-oops-in-error-path-of-sisusb_probe.patch
usb-add-lpm-quirk-for-surface-dock-gige-adapter.patch
usb-rio500-refuse-more-than-one-device-at-a-time.patch
usb-rio500-fix-memory-leak-in-close-after-disconnect.patch
media-usb-siano-fix-general-protection-fault-in-smsusb.patch
media-usb-siano-fix-false-positive-uninitialized-variable-warning.patch
media-smsusb-better-handle-optional-alignment.patch
brcmfmac-fix-null-pointer-derefence-during-usb-disconnect.patch
scsi-zfcp-fix-missing-zfcp_port-reference-put-on-ebusy-from-port_remove.patch
scsi-zfcp-fix-to-prevent-port_remove-with-pure-auto-scan-luns-only-sdevs.patch
tracing-avoid-memory-leak-in-predicate_parse.patch
btrfs-fix-wrong-ctime-and-mtime-of-a-directory-after-log-replay.patch
btrfs-fix-race-updating-log-root-item-during-fsync.patch
btrfs-fix-fsync-not-persisting-changed-attributes-of-a-directory.patch
btrfs-incremental-send-fix-file-corruption-when-no-holes-feature-is-enabled.patch
iio-dac-ds4422-ds4424-fix-chip-verification.patch
iio-adc-ti-ads8688-fix-timestamp-is-not-updated-in-buffer.patch
s390-crypto-fix-gcm-aes-s390-selftest-failures.patch
s390-crypto-fix-possible-sleep-during-spinlock-aquired.patch
kvm-ppc-book3s-hv-xive-do-not-clear-irq-data-of-passthrough-interrupts.patch
powerpc-perf-fix-mmcra-corruption-by-bhrb_filter.patch
alsa-line6-assure-canceling-delayed-work-at-disconnection.patch
alsa-hda-realtek-set-default-power-save-node-to-0.patch
alsa-hda-realtek-improve-the-headset-mic-for-acer-aspire-laptops.patch
kvm-s390-do-not-report-unusabled-ids-via-kvm_cap_max_vcpu_id.patch
drm-nouveau-i2c-disable-i2c-bus-access-after-fini.patch
i2c-mlxcpld-fix-wrong-initialization-order-in-probe.patch
i2c-synquacer-fix-synquacer_i2c_doxfer-return-value.patch
tty-serial-msm_serial-fix-xon-xoff.patch
tty-max310x-fix-external-crystal-register-setup.patch
memcg-make-it-work-on-sparse-non-0-node-systems.patch
kernel-signal.c-trace_signal_deliver-when-signal_group_exit.patch
arm64-fix-the-arm64_personality-syscall-wrapper-redirection.patch
docs-fix-conf.py-for-sphinx-2.0.patch
doc-cope-with-the-deprecation-of-autoreporter.patch
doc-cope-with-sphinx-logging-deprecations.patch
ima-show-rules-with-ima_inmask-correctly.patch
evm-check-hash-algorithm-passed-to-init_desc.patch
vt-fbcon-deinitialize-resources-in-visual_init-after-failed-memory-allocation.patch
serial-sh-sci-disable-dma-for-uart_console.patch
staging-vc04_services-prevent-integer-overflow-in-create_pagelist.patch
staging-wlan-ng-fix-adapter-initialization-failure.patch
cifs-fix-memory-leak-of-pneg_inbuf-on-eopnotsupp-ioctl-case.patch
cifs-cifs_read_allocate_pages-don-t-iterate-through-whole-page-array-on-enomem.patch
revert-lockd-show-pid-of-lockd-for-remote-locks.patch
gcc-plugins-fix-build-failures-under-darwin-host.patch
drm-tegra-gem-fix-cpu-cache-maintenance-for-bo-s-allocated-using-get_pages.patch
drm-vmwgfx-don-t-send-drm-sysfs-hotplug-events-on-initial-master-set.patch
drm-sun4i-fix-sun8i-hdmi-phy-clock-initialization.patch
drm-sun4i-fix-sun8i-hdmi-phy-configuration-for-148.5-mhz.patch
drm-rockchip-shutdown-drm-subsystem-on-shutdown.patch
drm-lease-make-sure-implicit-planes-are-leased.patch
Compile testing
---------------
We compiled the kernel for 4 architectures:
aarch64:
build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg
ppc64le:
build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg
configuration: https://artifacts.cki-project.org/builds/ppc64le/kernel-stable_queue_4.19-p…
kernel build: https://artifacts.cki-project.org/builds/ppc64le/kernel-stable_queue_4.19-p…
s390x:
build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg
configuration: https://artifacts.cki-project.org/builds/s390x/kernel-stable_queue_4.19-s39…
kernel build: https://artifacts.cki-project.org/builds/s390x/kernel-stable_queue_4.19-s39…
x86_64:
build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg
configuration: https://artifacts.cki-project.org/builds/x86_64/kernel-stable_queue_4.19-x8…
kernel build: https://artifacts.cki-project.org/builds/x86_64/kernel-stable_queue_4.19-x8…
Hello,
We ran automated tests on a patchset that was proposed for merging into this
kernel tree. The patches were applied to:
Kernel repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
Commit: 2f7d9d47575e - Linux 5.1.7
The results of these automated tests are provided below.
Overall result: PASSED
Merge: OK
Compile: OK
Tests: OK
We hope that these logs can help you find the problem quickly. For the full
detail on our testing procedures, please scroll to the bottom of this message.
Please reply to this email if you have any questions about the tests that we
ran or if you have any suggestions on how to make future tests more effective.
,-. ,-.
( C ) ( K ) Continuous
`-',-.`-' Kernel
( I ) Integration
`-'
______________________________________________________________________________
Merge testing
-------------
We cloned this repository and checked out the following commit:
Repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
Commit: 2f7d9d47575e - Linux 5.1.7
We then merged the patchset with `git am`:
sparc64-fix-regression-in-non-hypervisor-tlb-flush-xcall.patch
include-linux-bitops.h-sanitize-rotate-primitives.patch
xhci-update-bounce-buffer-with-correct-sg-num.patch
xhci-use-zu-for-printing-size_t-type.patch
xhci-convert-xhci_handshake-to-use-readl_poll_timeout_atomic.patch
usb-xhci-avoid-null-pointer-deref-when-bos-field-is-null.patch
usbip-usbip_host-fix-bug-sleeping-function-called-from-invalid-context.patch
usbip-usbip_host-fix-stub_dev-lock-context-imbalance-regression.patch
usb-fix-slab-out-of-bounds-write-in-usb_get_bos_descriptor.patch
usb-sisusbvga-fix-oops-in-error-path-of-sisusb_probe.patch
usb-add-lpm-quirk-for-surface-dock-gige-adapter.patch
usb-rio500-refuse-more-than-one-device-at-a-time.patch
usb-rio500-fix-memory-leak-in-close-after-disconnect.patch
media-usb-siano-fix-general-protection-fault-in-smsusb.patch
media-usb-siano-fix-false-positive-uninitialized-variable-warning.patch
media-smsusb-better-handle-optional-alignment.patch
brcmfmac-fix-null-pointer-derefence-during-usb-disconnect.patch
scsi-zfcp-fix-missing-zfcp_port-reference-put-on-ebusy-from-port_remove.patch
scsi-zfcp-fix-to-prevent-port_remove-with-pure-auto-scan-luns-only-sdevs.patch
tracing-avoid-memory-leak-in-predicate_parse.patch
btrfs-fix-wrong-ctime-and-mtime-of-a-directory-after-log-replay.patch
btrfs-fix-race-updating-log-root-item-during-fsync.patch
btrfs-fix-fsync-not-persisting-changed-attributes-of-a-directory.patch
btrfs-correct-zstd-workspace-manager-lock-to-use-spin_lock_bh.patch
btrfs-qgroup-check-bg-while-resuming-relocation-to-avoid-null-pointer-dereference.patch
btrfs-incremental-send-fix-file-corruption-when-no-holes-feature-is-enabled.patch
btrfs-reloc-also-queue-orphan-reloc-tree-for-cleanup-to-avoid-bug_on.patch
iio-dac-ds4422-ds4424-fix-chip-verification.patch
iio-adc-ads124-avoid-buffer-overflow.patch
iio-adc-modify-npcm-adc-read-reference-voltage.patch
iio-adc-ti-ads8688-fix-timestamp-is-not-updated-in-buffer.patch
s390-crypto-fix-gcm-aes-s390-selftest-failures.patch
s390-crypto-fix-possible-sleep-during-spinlock-aquired.patch
kvm-ppc-book3s-hv-xive-do-not-clear-irq-data-of-passthrough-interrupts.patch
kvm-ppc-book3s-hv-fix-lockdep-warning-when-entering-guest-on-power9.patch
kvm-ppc-book3s-hv-restore-sprg3-in-kvmhv_p9_guest_entry.patch
powerpc-perf-fix-mmcra-corruption-by-bhrb_filter.patch
powerpc-kexec-fix-loading-of-kernel-initramfs-with-kexec_file_load.patch
alsa-line6-assure-canceling-delayed-work-at-disconnection.patch
alsa-hda-realtek-set-default-power-save-node-to-0.patch
alsa-hda-realtek-improve-the-headset-mic-for-acer-aspire-laptops.patch
kvm-s390-do-not-report-unusabled-ids-via-kvm_cap_max_vcpu_id.patch
drm-nouveau-i2c-disable-i2c-bus-access-after-fini.patch
i2c-mlxcpld-fix-wrong-initialization-order-in-probe.patch
i2c-synquacer-fix-synquacer_i2c_doxfer-return-value.patch
tty-serial-msm_serial-fix-xon-xoff.patch
tty-max310x-fix-external-crystal-register-setup.patch
mm-memcg-consider-subtrees-in-memory.events.patch
memcg-make-it-work-on-sparse-non-0-node-systems.patch
kasan-initialize-tag-to-0xff-in-__kasan_kmalloc.patch
kernel-signal.c-trace_signal_deliver-when-signal_group_exit.patch
signal-arm64-use-force_sig-not-force_sig_fault-for-sigkill.patch
mm-compaction-make-sure-we-isolate-a-valid-pfn.patch
arm64-fix-the-arm64_personality-syscall-wrapper-redirection.patch
docs-fix-conf.py-for-sphinx-2.0.patch
doc-cope-with-the-deprecation-of-autoreporter.patch
doc-cope-with-sphinx-logging-deprecations.patch
x86-ima-check-efi_runtime_services-before-using.patch
ima-fix-wrong-signed-policy-requirement-when-not-appraising.patch
ima-show-rules-with-ima_inmask-correctly.patch
evm-check-hash-algorithm-passed-to-init_desc.patch
clk-imx-imx8mm-fix-int-pll-clk-gate.patch
vt-fbcon-deinitialize-resources-in-visual_init-after-failed-memory-allocation.patch
serial-sh-sci-disable-dma-for-uart_console.patch
staging-vc04_services-prevent-integer-overflow-in-create_pagelist.patch
staging-wlan-ng-fix-adapter-initialization-failure.patch
cifs-fix-memory-leak-of-pneg_inbuf-on-eopnotsupp-ioctl-case.patch
cifs-cifs_read_allocate_pages-don-t-iterate-through-whole-page-array-on-enomem.patch
revert-lockd-show-pid-of-lockd-for-remote-locks.patch
gcc-plugins-fix-build-failures-under-darwin-host.patch
Compile testing
---------------
We compiled the kernel for 4 architectures:
aarch64:
build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg
configuration: https://artifacts.cki-project.org/builds/aarch64/kernel-stable_queue_5.1-aa…
kernel build: https://artifacts.cki-project.org/builds/aarch64/kernel-stable_queue_5.1-aa…
ppc64le:
build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg
configuration: https://artifacts.cki-project.org/builds/ppc64le/kernel-stable_queue_5.1-pp…
kernel build: https://artifacts.cki-project.org/builds/ppc64le/kernel-stable_queue_5.1-pp…
s390x:
build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg
configuration: https://artifacts.cki-project.org/builds/s390x/kernel-stable_queue_5.1-s390…
kernel build: https://artifacts.cki-project.org/builds/s390x/kernel-stable_queue_5.1-s390…
x86_64:
build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg
configuration: https://artifacts.cki-project.org/builds/x86_64/kernel-stable_queue_5.1-x86…
kernel build: https://artifacts.cki-project.org/builds/x86_64/kernel-stable_queue_5.1-x86…
Hardware testing
----------------
We booted each kernel and ran the following tests:
aarch64:
⚡ Internal infrastructure issues prevented one or more tests from running
on this architecture. This is not the fault of the kernel that was tested.
ppc64le:
Host 1:
✅ Boot test [0]
✅ selinux-policy: serge-testsuite [1]
Host 2:
✅ Boot test [0]
✅ LTP lite [2]
✅ Loopdev Sanity [3]
✅ AMTU (Abstract Machine Test Utility) [4]
✅ audit: audit testsuite test [5]
✅ httpd: mod_ssl smoke sanity [6]
✅ iotop: sanity [7]
✅ tuned: tune-processes-through-perf [8]
✅ Usex - version 1.9-29 [9]
s390x:
Host 1:
✅ Boot test [0]
✅ selinux-policy: serge-testsuite [1]
Host 2:
✅ Boot test [0]
✅ LTP lite [2]
✅ Loopdev Sanity [3]
✅ audit: audit testsuite test [5]
✅ httpd: mod_ssl smoke sanity [6]
✅ iotop: sanity [7]
✅ tuned: tune-processes-through-perf [8]
🚧 ✅ stress: stress-ng [10]
x86_64:
Host 1:
✅ Boot test [0]
✅ LTP lite [2]
✅ Loopdev Sanity [3]
✅ AMTU (Abstract Machine Test Utility) [4]
✅ audit: audit testsuite test [5]
✅ httpd: mod_ssl smoke sanity [6]
✅ iotop: sanity [7]
✅ tuned: tune-processes-through-perf [8]
✅ Usex - version 1.9-29 [9]
🚧 ✅ stress: stress-ng [10]
Host 2:
✅ Boot test [0]
✅ selinux-policy: serge-testsuite [1]
Test source:
💚 Pull requests are welcome for new tests or improvements to existing tests!
[0]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution…
[1]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/packages/se…
[2]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution…
[3]: https://github.com/CKI-project/tests-beaker/archive/master.zip#filesystems/…
[4]: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu
[5]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/aud…
[6]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/htt…
[7]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/iot…
[8]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/tun…
[9]: https://github.com/CKI-project/tests-beaker/archive/master.zip#standards/us…
[10]: https://github.com/CKI-project/tests-beaker/archive/master.zip#stress/stres…
Waived tests (marked with 🚧)
-----------------------------
This test run included waived tests. Such tests are executed but their results
are not taken into account. Tests are waived when their results are not
reliable enough, e.g. when they're just introduced or are being fixed.
While this backport proposal is based on the 4.4.y stable tree, it
might also apply in some form to any stable tree which backported
05c0b86b96: "ipv6: frags: rewrite ip6_expire_frag_queue()"
While this made ip6_expire_frag_queue() similar to ip_exire(),
it did not follow the additional changes to ip_expire() which
were also backported:
fa0f527358: "ip: use rb trees for IP frag queue."
a4fd284a1f: "ip: process in-order fragments efficiently"
The former of the two not only adds handling for rb trees, but
also modifies ip_expire() to take the first skb off the queue
before using it for the sending the icmp message. This also got
rid of the need to protect the skb by incrementing its reference
count (which is the reason for the crash in ip6_expire_frag_queue()).
My first approach was do those changes in ip6_expire_frag_queue(),
but only the former of the two can be done without problems. The
latter uses code which is only locally defined in ipv4/ip_fragment.c.
This was changed upstream in 5.1 when moving code around to be shared
c23f35d19d: "net: IP defrag: encapsulate rbtree defrag code into
callable functions"
And while backporting that I found the two other changes which sounded
like one might want them backported, too. Maybe even more since the
second (ip: fail fast on IP defrag errors) is already partially
included in the backport of "net: ipv4: do not handle duplicate
fragments as overlapping".
Though I do realize that "net: IP defrag: encapsulate rbtree
defrag code into callable functions" is rather large and for
that reason maybe not qualifying as a stable backport.
So I would like to ask what the net-developers think about
this.
Thanks,
Stefan
0001: v4.20: ipv4: ipv6: netfilter: Adjust the frag mem limit when
truesize changes
0002: v4.20: ip: fail fast on IP defrag errors
0003: v5.1 : net: IP defrag: encapsulate rbtree defrag code into
callable functions
0004: n/a : ipv6: frags: Use inet_frag_pull_head() in
ip6_expire_frag_queue()
Jiri Wiesner (1):
ipv4: ipv6: netfilter: Adjust the frag mem limit when truesize changes
Peter Oskolkov (2):
ip: fail fast on IP defrag errors
net: IP defrag: encapsulate rbtree defrag code into callable functions
Stefan Bader (1):
ipv6: frags: Use inet_frag_pull_head() in ip6_expire_frag_queue()
include/net/inet_frag.h | 16 +-
net/ipv4/inet_fragment.c | 293 +++++++++++++++++++++++
net/ipv4/ip_fragment.c | 294 +++---------------------
net/ipv6/netfilter/nf_conntrack_reasm.c | 8 +-
net/ipv6/reassembly.c | 20 +-
5 files changed, 359 insertions(+), 272 deletions(-)
--
2.17.1
From: Miguel Ojeda <miguel.ojeda.sandonis(a)gmail.com>
[ Upstream commit c0d9782f5b6d7157635ae2fd782a4b27d55a6013 ]
>From the GCC manual:
copy
copy(function)
The copy attribute applies the set of attributes with which function
has been declared to the declaration of the function to which
the attribute is applied. The attribute is designed for libraries
that define aliases or function resolvers that are expected
to specify the same set of attributes as their targets. The copy
attribute can be used with functions, variables, or types. However,
the kind of symbol to which the attribute is applied (either
function or variable) must match the kind of symbol to which
the argument refers. The copy attribute copies only syntactic and
semantic attributes but not attributes that affect a symbol’s
linkage or visibility such as alias, visibility, or weak.
The deprecated attribute is also not copied.
https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html
The upcoming GCC 9 release extends the -Wmissing-attributes warnings
(enabled by -Wall) to C and aliases: it warns when particular function
attributes are missing in the aliases but not in their target, e.g.:
void __cold f(void) {}
void __alias("f") g(void);
diagnoses:
warning: 'g' specifies less restrictive attribute than
its target 'f': 'cold' [-Wmissing-attributes]
Using __copy(f) we can copy the __cold attribute from f to g:
void __cold f(void) {}
void __copy(f) __alias("f") g(void);
This attribute is most useful to deal with situations where an alias
is declared but we don't know the exact attributes the target has.
For instance, in the kernel, the widely used module_init/exit macros
define the init/cleanup_module aliases, but those cannot be marked
always as __init/__exit since some modules do not have their
functions marked as such.
Cc: <stable(a)vger.kernel.org> # 4.14+
Suggested-by: Martin Sebor <msebor(a)gcc.gnu.org>
Reviewed-by: Nick Desaulniers <ndesaulniers(a)google.com>
Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis(a)gmail.com>
Signed-off-by: Stefan Agner <stefan(a)agner.ch>
---
Changes in v2:
- Fix define of compatibility __copy macro (add symbol argument)
include/linux/compiler-gcc.h | 4 ++++
include/linux/compiler_types.h | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
index 4816355b9875..6d7ead22c1b4 100644
--- a/include/linux/compiler-gcc.h
+++ b/include/linux/compiler-gcc.h
@@ -343,6 +343,10 @@
#define __designated_init __attribute__((designated_init))
#endif
+#if GCC_VERSION >= 90100
+#define __copy(symbol) __attribute__((__copy__(symbol)))
+#endif
+
#endif /* gcc version >= 40000 specific checks */
#if !defined(__noclone)
diff --git a/include/linux/compiler_types.h b/include/linux/compiler_types.h
index 4be464a07612..222fcefaa6a7 100644
--- a/include/linux/compiler_types.h
+++ b/include/linux/compiler_types.h
@@ -230,6 +230,10 @@ struct ftrace_likely_data {
# define __latent_entropy
#endif
+#ifndef __copy
+# define __copy(symbol)
+#endif
+
#ifndef __randomize_layout
# define __randomize_layout __designated_init
#endif
--
2.21.0
Hello,
We ran automated tests on a patchset that was proposed for merging into this
kernel tree. The patches were applied to:
Kernel repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
Commit: e109a984cf38 - Linux 4.19.48
The results of these automated tests are provided below.
Overall result: FAILED (see details below)
Merge: OK
Compile: FAILED
We attempted to compile the kernel for multiple architectures, but the compile
failed on one or more architectures:
aarch64: FAILED (see build-aarch64.log.xz attachment)
We hope that these logs can help you find the problem quickly. For the full
detail on our testing procedures, please scroll to the bottom of this message.
Please reply to this email if you have any questions about the tests that we
ran or if you have any suggestions on how to make future tests more effective.
,-. ,-.
( C ) ( K ) Continuous
`-',-.`-' Kernel
( I ) Integration
`-'
______________________________________________________________________________
Merge testing
-------------
We cloned this repository and checked out the following commit:
Repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
Commit: e109a984cf38 - Linux 4.19.48
We then merged the patchset with `git am`:
sparc64-fix-regression-in-non-hypervisor-tlb-flush-xcall.patch
include-linux-bitops.h-sanitize-rotate-primitives.patch
xhci-update-bounce-buffer-with-correct-sg-num.patch
xhci-use-zu-for-printing-size_t-type.patch
xhci-convert-xhci_handshake-to-use-readl_poll_timeout_atomic.patch
usb-xhci-avoid-null-pointer-deref-when-bos-field-is-null.patch
usbip-usbip_host-fix-bug-sleeping-function-called-from-invalid-context.patch
usbip-usbip_host-fix-stub_dev-lock-context-imbalance-regression.patch
usb-fix-slab-out-of-bounds-write-in-usb_get_bos_descriptor.patch
usb-sisusbvga-fix-oops-in-error-path-of-sisusb_probe.patch
usb-add-lpm-quirk-for-surface-dock-gige-adapter.patch
usb-rio500-refuse-more-than-one-device-at-a-time.patch
usb-rio500-fix-memory-leak-in-close-after-disconnect.patch
media-usb-siano-fix-general-protection-fault-in-smsusb.patch
media-usb-siano-fix-false-positive-uninitialized-variable-warning.patch
media-smsusb-better-handle-optional-alignment.patch
brcmfmac-fix-null-pointer-derefence-during-usb-disconnect.patch
scsi-zfcp-fix-missing-zfcp_port-reference-put-on-ebusy-from-port_remove.patch
scsi-zfcp-fix-to-prevent-port_remove-with-pure-auto-scan-luns-only-sdevs.patch
tracing-avoid-memory-leak-in-predicate_parse.patch
btrfs-fix-wrong-ctime-and-mtime-of-a-directory-after-log-replay.patch
btrfs-fix-race-updating-log-root-item-during-fsync.patch
btrfs-fix-fsync-not-persisting-changed-attributes-of-a-directory.patch
btrfs-incremental-send-fix-file-corruption-when-no-holes-feature-is-enabled.patch
iio-dac-ds4422-ds4424-fix-chip-verification.patch
iio-adc-ti-ads8688-fix-timestamp-is-not-updated-in-buffer.patch
s390-crypto-fix-gcm-aes-s390-selftest-failures.patch
s390-crypto-fix-possible-sleep-during-spinlock-aquired.patch
kvm-ppc-book3s-hv-xive-do-not-clear-irq-data-of-passthrough-interrupts.patch
powerpc-perf-fix-mmcra-corruption-by-bhrb_filter.patch
alsa-line6-assure-canceling-delayed-work-at-disconnection.patch
alsa-hda-realtek-set-default-power-save-node-to-0.patch
alsa-hda-realtek-improve-the-headset-mic-for-acer-aspire-laptops.patch
kvm-s390-do-not-report-unusabled-ids-via-kvm_cap_max_vcpu_id.patch
drm-nouveau-i2c-disable-i2c-bus-access-after-fini.patch
i2c-mlxcpld-fix-wrong-initialization-order-in-probe.patch
i2c-synquacer-fix-synquacer_i2c_doxfer-return-value.patch
tty-serial-msm_serial-fix-xon-xoff.patch
tty-max310x-fix-external-crystal-register-setup.patch
memcg-make-it-work-on-sparse-non-0-node-systems.patch
kernel-signal.c-trace_signal_deliver-when-signal_group_exit.patch
arm64-fix-the-arm64_personality-syscall-wrapper-redirection.patch
docs-fix-conf.py-for-sphinx-2.0.patch
doc-cope-with-the-deprecation-of-autoreporter.patch
doc-cope-with-sphinx-logging-deprecations.patch
ima-show-rules-with-ima_inmask-correctly.patch
evm-check-hash-algorithm-passed-to-init_desc.patch
vt-fbcon-deinitialize-resources-in-visual_init-after-failed-memory-allocation.patch
serial-sh-sci-disable-dma-for-uart_console.patch
staging-vc04_services-prevent-integer-overflow-in-create_pagelist.patch
staging-wlan-ng-fix-adapter-initialization-failure.patch
cifs-fix-memory-leak-of-pneg_inbuf-on-eopnotsupp-ioctl-case.patch
cifs-cifs_read_allocate_pages-don-t-iterate-through-whole-page-array-on-enomem.patch
revert-lockd-show-pid-of-lockd-for-remote-locks.patch
gcc-plugins-fix-build-failures-under-darwin-host.patch
efi-x86-add-missing-error-handling-to-old_memmap-1-1-mapping-code.patch
drm-tegra-gem-fix-cpu-cache-maintenance-for-bo-s-allocated-using-get_pages.patch
drm-vmwgfx-don-t-send-drm-sysfs-hotplug-events-on-initial-master-set.patch
drm-sun4i-fix-sun8i-hdmi-phy-clock-initialization.patch
drm-sun4i-fix-sun8i-hdmi-phy-configuration-for-148.5-mhz.patch
drm-rockchip-shutdown-drm-subsystem-on-shutdown.patch
drm-lease-make-sure-implicit-planes-are-leased.patch
Compile testing
---------------
We compiled the kernel for 4 architectures:
aarch64:
build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg
ppc64le:
build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg
configuration: https://artifacts.cki-project.org/builds/ppc64le/kernel-stable_queue_4.19-p…
kernel build: https://artifacts.cki-project.org/builds/ppc64le/kernel-stable_queue_4.19-p…
s390x:
build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg
configuration: https://artifacts.cki-project.org/builds/s390x/kernel-stable_queue_4.19-s39…
kernel build: https://artifacts.cki-project.org/builds/s390x/kernel-stable_queue_4.19-s39…
x86_64:
build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg
configuration: https://artifacts.cki-project.org/builds/x86_64/kernel-stable_queue_4.19-x8…
kernel build: https://artifacts.cki-project.org/builds/x86_64/kernel-stable_queue_4.19-x8…
Hi Sasha,
On 04/06/19 6:20 PM, Sasha Levin wrote:
> Hi,
>
> [This is an automated email]
>
> This commit has been processed because it contains a -stable tag.
> The stable tag indicates that it's relevant for the following trees: all
>
> The bot has tested the following trees: v5.1.6, v5.0.20, v4.19.47, v4.14.123, v4.9.180, v4.4.180.
>
> v5.1.6: Build OK!
> v5.0.20: Build OK!
Please apply it only to the above two releases. I guess this script
could detect that the file was not even present before this and not try
to apply to those.
> v4.19.47: Failed to apply! Possible dependencies:
> 06b23ca021c4 ("mmc: sdhci-of-arasan: Add a single data structure to incorporate pdata and soc_ctl_map")
> 41fd4caeb00b ("mmc: sdhci_am654: Add Initial Support for AM654 SDHCI driver")
> f0061fed1f8a ("mmc: sdhci-of-arasan: Add Support for AM654 MMC and PHY")
>
> v4.14.123: Failed to apply! Possible dependencies:
> 06b23ca021c4 ("mmc: sdhci-of-arasan: Add a single data structure to incorporate pdata and soc_ctl_map")
> 41fd4caeb00b ("mmc: sdhci_am654: Add Initial Support for AM654 SDHCI driver")
> 7d326930d352 ("mmc: sdhci-omap: Add OMAP SDHCI driver")
> 84362d79f436 ("mmc: sdhci-of-arasan: Add CQHCI support for arasan,sdhci-5.1")
> f0061fed1f8a ("mmc: sdhci-of-arasan: Add Support for AM654 MMC and PHY")
>
> v4.9.180: Failed to apply! Possible dependencies:
> 06b23ca021c4 ("mmc: sdhci-of-arasan: Add a single data structure to incorporate pdata and soc_ctl_map")
> 3a3748dba881 ("mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality")
> 41fd4caeb00b ("mmc: sdhci_am654: Add Initial Support for AM654 SDHCI driver")
> 7d326930d352 ("mmc: sdhci-omap: Add OMAP SDHCI driver")
> 84362d79f436 ("mmc: sdhci-of-arasan: Add CQHCI support for arasan,sdhci-5.1")
> d38dcad4e7b4 ("mmc: sdhci: Let drivers decide whether to use mmc_retune_needed() with pm")
> f0061fed1f8a ("mmc: sdhci-of-arasan: Add Support for AM654 MMC and PHY")
>
> v4.4.180: Failed to apply! Possible dependencies:
> 06b23ca021c4 ("mmc: sdhci-of-arasan: Add a single data structure to incorporate pdata and soc_ctl_map")
> 0c7fe32e847f ("mmc: sdhci-of-arasan: fix clk issue in sdhci_arasan_remove()")
> 278d09624eda ("mmc: sdhci-of-arasan: fix missing sdhci_pltfm_free for err handling")
> 3a3748dba881 ("mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality")
> 3ea4666e8d42 ("mmc: sdhci-of-arasan: Properly set corecfg_baseclkfreq on rk3399")
> 41fd4caeb00b ("mmc: sdhci_am654: Add Initial Support for AM654 SDHCI driver")
> 476bf3d62d5c ("mmc: sdhci-brcmstb: Add driver for Broadcom BRCMSTB SoCs")
> 5d9460d74ce5 ("mmc: sdhci-pic32: Add PIC32 SDHCI host controller driver")
> 7d326930d352 ("mmc: sdhci-omap: Add OMAP SDHCI driver")
> 802ac39a5566 ("mmc: sdhci-of-arasan: fix set_clock when a phy is supported")
> 84362d79f436 ("mmc: sdhci-of-arasan: Add CQHCI support for arasan,sdhci-5.1")
> 89211418cb71 ("mmc: sdhci-of-arasan: use sdhci_pltfm_init for private allocation")
> 91aa366109e8 ("mmc: sdhci-of-arasan: add phy support for sdhci-of-arasan")
> a05c84651145 ("mmc: sdhci-of-arasan: implement enhanced strobe callback")
> c390f2110adf ("mmc: sdhci-of-arasan: Add ability to export card clock")
> ca572f4636aa ("mmc: sdhci-of-arasan: Always power the PHY off/on when clock changes")
> f0061fed1f8a ("mmc: sdhci-of-arasan: Add Support for AM654 MMC and PHY")
>
>
> How should we proceed with this patch?
>
Thanks,
Faiz
If we have to drop the seqcount & rcu lock to perform a krealloc, we
have to restart the loop. In doing so, be careful not to lose track of
the already acquired exclusive fence.
Fixes: fedf54132d24 ("dma-buf: Restart reservation_object_get_fences_rcu() after writes") #v4.10
Signed-off-by: Chris Wilson <chris(a)chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter(a)ffwll.ch>
Cc: Maarten Lankhorst <maarten.lankhorst(a)linux.intel.com>
Cc: Christian König <christian.koenig(a)amd.com>
Cc: Alex Deucher <alexander.deucher(a)amd.com>
Cc: Sumit Semwal <sumit.semwal(a)linaro.org>
Cc: stable(a)vger.kernel.org
---
drivers/dma-buf/reservation.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/dma-buf/reservation.c b/drivers/dma-buf/reservation.c
index 4d32e2c67862..704503df4892 100644
--- a/drivers/dma-buf/reservation.c
+++ b/drivers/dma-buf/reservation.c
@@ -365,6 +365,12 @@ int reservation_object_get_fences_rcu(struct reservation_object *obj,
GFP_NOWAIT | __GFP_NOWARN);
if (!nshared) {
rcu_read_unlock();
+
+ if (fence_excl) {
+ dma_fence_put(fence_excl);
+ fence_excl = NULL;
+ }
+
nshared = krealloc(shared, sz, GFP_KERNEL);
if (nshared) {
shared = nshared;
--
2.20.1