August 2019 - Linux-stable-mirror

Latest kernel version no NOT reflecting on kernel.org

by Bhaskar Chowdhury

Am I the only one, who is not seeing it getting reflected on kernel.org??? Well, I have tried it 2 different browsers.....cleared caches several times(heck) .....3 different devices .....and importantly 3 different networks. Wondering! Thanks, Bhaskar

4 years, 9 months

3
5
0 0

[PATCH 4.19 00/98] 4.19.69-stable review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.69 release. There are 98 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Thu 29 Aug 2019 07:25:02 AM UTC. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.69-rc… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.19.69-rc1 David Howells <dhowells(a)redhat.com> rxrpc: Fix read-after-free in rxrpc_queue_local() David Howells <dhowells(a)redhat.com> rxrpc: Fix local endpoint refcounting Alastair D'Silva <alastair(a)d-silva.org> powerpc: Allow flush_(inval_)dcache_range to work across ranges >4GB Dan Carpenter <dan.carpenter(a)oracle.com> dm zoned: fix potential NULL dereference in dmz_do_reclaim() Darrick J. Wong <darrick.wong(a)oracle.com> xfs: always rejoin held resources during defer roll Allison Henderson <allison.henderson(a)oracle.com> xfs: Add attibute remove and helper functions Allison Henderson <allison.henderson(a)oracle.com> xfs: Add attibute set and helper functions Allison Henderson <allison.henderson(a)oracle.com> xfs: Add helper function xfs_attr_try_sf_addname Allison Henderson <allison.henderson(a)oracle.com> xfs: Move fs/xfs/xfs_attr.h to fs/xfs/libxfs/xfs_attr.h Brian Foster <bfoster(a)redhat.com> xfs: don't trip over uninitialized buffer on extent read of corrupted inode Darrick J. Wong <darrick.wong(a)oracle.com> xfs: fix missing ILOCK unlock when xfs_setattr_nonsize fails due to EDQUOT Henry Burns <henryburns(a)google.com> mm/zsmalloc.c: fix race condition in zs_destroy_pool Henry Burns <henryburns(a)google.com> mm/zsmalloc.c: migration can leave pages in ZS_EMPTY indefinitely Vlastimil Babka <vbabka(a)suse.cz> mm, page_owner: handle THP splits correctly Michael Kelley <mikelley(a)microsoft.com> genirq: Properly pair kobject_del() with kobject_add() Dmitry Fomichev <dmitry.fomichev(a)wdc.com> dm zoned: properly handle backing device failure Dmitry Fomichev <dmitry.fomichev(a)wdc.com> dm zoned: improve error handling in i/o map code Dmitry Fomichev <dmitry.fomichev(a)wdc.com> dm zoned: improve error handling in reclaim Mikulas Patocka <mpatocka(a)redhat.com> dm table: fix invalid memory accesses with too high sector number ZhangXiaoxu <zhangxiaoxu5(a)huawei.com> dm space map metadata: fix missing store of apply_bops() return value Wenwen Wang <wenwen(a)cs.uga.edu> dm raid: add missing cleanup in raid_ctr() Mikulas Patocka <mpatocka(a)redhat.com> dm integrity: fix a crash due to BUG_ON in __journal_read_write() ZhangXiaoxu <zhangxiaoxu5(a)huawei.com> dm btree: fix order of block initialization in btree_split_beneath Dmitry Fomichev <dmitry.fomichev(a)wdc.com> dm kcopyd: always complete failed jobs John Hubbard <jhubbard(a)nvidia.com> x86/boot: Fix boot regression caused by bootparam sanitizing John Hubbard <jhubbard(a)nvidia.com> x86/boot: Save fields explicitly, zero out everything else Tom Lendacky <thomas.lendacky(a)amd.com> x86/CPU/AMD: Clear RDRAND CPUID bit on AMD family 15h/16h Thomas Gleixner <tglx(a)linutronix.de> x86/apic: Handle missing global clockevent gracefully Sean Christopherson <sean.j.christopherson(a)intel.com> x86/retpoline: Don't clobber RFLAGS during CALL_NOSPEC on i386 Oleg Nesterov <oleg(a)redhat.com> userfaultfd_release: always remove uffd flags and clear vm_userfaultfd_ctx Dexuan Cui <decui(a)microsoft.com> Drivers: hv: vmbus: Fix virt_to_hvpfn() for X86_PAE Bartosz Golaszewski <bgolaszewski(a)baylibre.com> gpiolib: never report open-drain/source lines as 'input' to user-space Lyude Paul <lyude(a)redhat.com> drm/nouveau: Don't retry infinitely when receiving no data on i2c over AUX Ilya Dryomov <idryomov(a)gmail.com> libceph: fix PG split vs OSD (re)connect race Jeff Layton <jlayton(a)kernel.org> ceph: don't try fill file_lock on unsuccessful GETFILELOCK reply Erqi Chen <chenerqi(a)gmail.com> ceph: clear page dirty before invalidate page Dinh Nguyen <dinguyen(a)kernel.org> clk: socfpga: stratix10: fix rate caclulationg for cnt_clks Mikulas Patocka <mpatocka(a)redhat.com> Revert "dm bufio: fix deadlock with loop device" Jason Gerecke <jason.gerecke(a)wacom.com> HID: wacom: Correct distance scale for 2nd-gen Intuos devices Aaron Armstrong Skomra <skomra(a)gmail.com> HID: wacom: correct misreported EKR ring values Naresh Kamboju <naresh.kamboju () linaro ! org> selftests: kvm: Adding config fragments Marc Zyngier <maz(a)kernel.org> KVM: arm: Don't write junk to CP15 registers on reset Marc Zyngier <maz(a)kernel.org> KVM: arm64: Don't write junk to sysregs on reset Jin Yao <yao.jin(a)linux.intel.com> perf pmu-events: Fix missing "cpu_clk_unhalted.core" event He Zhe <zhe.he(a)windriver.com> perf cpumap: Fix writing to illegal memory in handling cpumap mask He Zhe <zhe.he(a)windriver.com> perf ftrace: Fix failure to set cpumask when only one cpu is present Paolo Valente <paolo.valente(a)linaro.org> block, bfq: handle NULL return value by bfq_init_rq() Colin Ian King <colin.king(a)canonical.com> drm/vmwgfx: fix memory leak when too many retries have occurred Valdis Kletnieks <valdis.kletnieks(a)vt.edu> x86/lib/cpu: Address missing prototypes warning Jens Axboe <axboe(a)kernel.dk> libata: add SG safety checks in SFF pio transfers Jens Axboe <axboe(a)kernel.dk> libata: have ata_scsi_rw_xlat() fail invalid passthrough requests Jiangfeng Xiao <xiaojiangfeng(a)huawei.com> net: hisilicon: Fix dma_map_single failed on arm64 Jiangfeng Xiao <xiaojiangfeng(a)huawei.com> net: hisilicon: fix hip04-xmit never return TX_BUSY Jiangfeng Xiao <xiaojiangfeng(a)huawei.com> net: hisilicon: make hip04_tx_reclaim non-reentrant Jose Abreu <Jose.Abreu(a)synopsys.com> net: stmmac: tc: Do not return a fragment entry Jose Abreu <Jose.Abreu(a)synopsys.com> net: stmmac: Fix issues when number of Queues >= 4 Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> net: cxgb3_main: Fix a resource leak in a error path in 'init_one()' Vasily Gorbik <gor(a)linux.ibm.com> s390: put _stext and _etext into .text section Sebastien Tisserant <stisserant(a)wallix.com> SMB3: Kernel oops mounting a encryptData share with CONFIG_DEBUG_VIRTUAL Pavel Shilovsky <pshilov(a)microsoft.com> SMB3: Fix potential memory leak when processing compound chain Douglas Anderson <dianders(a)chromium.org> drm/rockchip: Suspend DP late Nicolas Saenz Julienne <nsaenzjulienne(a)suse.de> HID: input: fix a4tech horizontal wheel custom usage István Váradi <ivaradi(a)varadiistvan.hu> HID: quirks: Set the INCREMENT_USAGE_ON_DUPLICATE quirk on Saitek X52 Trond Myklebust <trond.myklebust(a)hammerspace.com> NFS: Fix regression whereby fscache errors are appearing on 'nofsc' mounts Trond Myklebust <trond.myklebust(a)hammerspace.com> NFSv4: Fix a potential sleep while atomic in nfs4_do_reclaim() Wang Xiayang <xywang.sjtu(a)sjtu.edu.cn> net/ethernet/qlogic/qed: force the string buffer NULL-terminated Wang Xiayang <xywang.sjtu(a)sjtu.edu.cn> can: peak_usb: force the string buffer NULL-terminated Wang Xiayang <xywang.sjtu(a)sjtu.edu.cn> can: sja1000: force the string buffer NULL-terminated Jiri Olsa <jolsa(a)kernel.org> perf bench numa: Fix cpu0 binding Jia-Ju Bai <baijiaju1990(a)gmail.com> net: phy: phy_led_triggers: Fix a possible null-pointer dereference in phy_led_trigger_change_speed() Juliana Rodrigueiro <juliana.rodrigueiro(a)intra2net.com> isdn: hfcsusb: Fix mISDN driver crash caused by transfer buffer on the stack David Howells <dhowells(a)redhat.com> rxrpc: Fix the lack of notification when sendmsg() fails on a DATA packet David Howells <dhowells(a)redhat.com> rxrpc: Fix potential deadlock Jozsef Kadlecsik <kadlec(a)netfilter.org> netfilter: ipset: Fix rename concurrency with listing Stefano Brivio <sbrivio(a)redhat.com> netfilter: ipset: Copy the right MAC address in bitmap:ip,mac and hash:ip,mac sets Stefano Brivio <sbrivio(a)redhat.com> netfilter: ipset: Actually allow destination MAC address for hash:ip,mac sets too Jia-Ju Bai <baijiaju1990(a)gmail.com> mac80211_hwsim: Fix possible null-pointer dereferences in hwsim_dump_radio_nl() Jia-Ju Bai <baijiaju1990(a)gmail.com> isdn: mISDN: hfcsusb: Fix possible null-pointer dereferences in start_isoc_chain() Michal Kalderon <michal.kalderon(a)marvell.com> qed: RDMA - Fix the hw_ver returned in device attributes Bob Ham <bob.ham(a)puri.sm> net: usb: qmi_wwan: Add the BroadMobi BM818 card Peter Ujfalusi <peter.ujfalusi(a)ti.com> ASoC: ti: davinci-mcasp: Correct slot_width posed constraint Cheng-Yi Chiang <cychiang(a)chromium.org> ASoC: rockchip: Fix mono capture Navid Emamdoost <navid.emamdoost(a)gmail.com> st_nci_hci_connectivity_event_received: null check the allocation Navid Emamdoost <navid.emamdoost(a)gmail.com> st21nfca_connectivity_event_received: null check the allocation Ricard Wanderlof <ricard.wanderlof(a)axis.com> ASoC: Fail card instantiation if DAI format setup fails YueHaibing <yuehaibing(a)huawei.com> can: gw: Fix error path of cgw_module_init Weitao Hou <houweitaoo(a)gmail.com> can: mcp251x: add error check when wq alloc failed Rasmus Villemoes <rasmus.villemoes(a)prevas.dk> can: dev: call netif_carrier_off() in register_candev() Ido Schimmel <idosch(a)mellanox.com> selftests: forwarding: gre_multipath: Fix flower filters Ido Schimmel <idosch(a)mellanox.com> selftests: forwarding: gre_multipath: Enable IPv4 forwarding Maxime Chevallier <maxime.chevallier(a)bootlin.com> net: mvpp2: Don't check for 3 consecutive Idle frames for 10G links Thomas Falcon <tlfalcon(a)linux.ibm.com> bonding: Force slave speed check after link state recovery for 802.3ad Ilya Leoshkevich <iii(a)linux.ibm.com> selftests/bpf: fix sendmsg6_prog on s390 Charles Keepax <ckeepax(a)opensource.cirrus.com> ASoC: dapm: Fix handling of custom_stop_condition on DAPM graph walks Wenwen Wang <wenwen(a)cs.uga.edu> netfilter: ebtables: fix a memory leak bug in compat Vladimir Kondratiev <vladimir.kondratiev(a)linux.intel.com> mips: fix cacheinfo Thomas Bogendoerfer <tbogendoerfer(a)suse.de> MIPS: kernel: only use i8253 clocksource with periodic clockevent Ilya Trukhanov <lahvuun(a)gmail.com> HID: Add 044f:b320 ThrustMaster, Inc. 2 in 1 DT ------------- Diffstat: Documentation/admin-guide/kernel-parameters.txt | 7 + Makefile | 4 +- arch/arm/kvm/coproc.c | 23 +- arch/arm64/kvm/sys_regs.c | 32 +-- arch/mips/kernel/cacheinfo.c | 2 + arch/mips/kernel/i8253.c | 3 +- arch/powerpc/kernel/misc_64.S | 4 +- arch/s390/kernel/vmlinux.lds.S | 10 +- arch/x86/include/asm/bootparam_utils.h | 61 ++++-- arch/x86/include/asm/msr-index.h | 1 + arch/x86/include/asm/nospec-branch.h | 2 +- arch/x86/kernel/apic/apic.c | 68 ++++-- arch/x86/kernel/cpu/amd.c | 66 ++++++ arch/x86/lib/cpu.c | 1 + arch/x86/power/cpu.c | 86 ++++++-- block/bfq-iosched.c | 14 +- drivers/ata/libata-scsi.c | 21 ++ drivers/ata/libata-sff.c | 6 + drivers/clk/socfpga/clk-periph-s10.c | 2 +- drivers/gpio/gpiolib.c | 6 +- drivers/gpu/drm/nouveau/nvkm/subdev/i2c/aux.c | 24 ++- drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_msg.c | 4 +- drivers/hid/hid-a4tech.c | 30 ++- drivers/hid/hid-ids.h | 1 + drivers/hid/hid-quirks.c | 1 + drivers/hid/hid-tmff.c | 12 ++ drivers/hid/wacom_wac.c | 4 +- drivers/hv/channel.c | 2 +- drivers/isdn/hardware/mISDN/hfcsusb.c | 13 +- drivers/md/dm-bufio.c | 4 +- drivers/md/dm-integrity.c | 15 ++ drivers/md/dm-kcopyd.c | 5 +- drivers/md/dm-raid.c | 2 +- drivers/md/dm-table.c | 5 +- drivers/md/dm-zoned-metadata.c | 59 ++++-- drivers/md/dm-zoned-reclaim.c | 44 +++- drivers/md/dm-zoned-target.c | 67 +++++- drivers/md/dm-zoned.h | 10 + drivers/md/persistent-data/dm-btree.c | 31 +-- drivers/md/persistent-data/dm-space-map-metadata.c | 2 +- drivers/net/bonding/bond_main.c | 9 + drivers/net/can/dev.c | 2 + drivers/net/can/sja1000/peak_pcmcia.c | 2 +- drivers/net/can/spi/mcp251x.c | 49 ++--- drivers/net/can/usb/peak_usb/pcan_usb_core.c | 2 +- drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 5 +- drivers/net/ethernet/hisilicon/hip04_eth.c | 28 +-- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 6 +- drivers/net/ethernet/qlogic/qed/qed_int.c | 2 +- drivers/net/ethernet/qlogic/qed/qed_rdma.c | 2 +- drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 4 + .../net/ethernet/stmicro/stmmac/dwxgmac2_core.c | 4 + drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c | 2 +- drivers/net/phy/phy_led_triggers.c | 3 +- drivers/net/usb/qmi_wwan.c | 1 + drivers/net/wireless/mac80211_hwsim.c | 8 +- drivers/nfc/st-nci/se.c | 2 + drivers/nfc/st21nfca/se.c | 2 + fs/ceph/addr.c | 5 +- fs/ceph/locks.c | 3 +- fs/cifs/smb2ops.c | 39 ++-- fs/nfs/fscache.c | 7 +- fs/nfs/fscache.h | 2 +- fs/nfs/nfs4_fs.h | 3 +- fs/nfs/nfs4client.c | 5 +- fs/nfs/nfs4state.c | 27 ++- fs/nfs/super.c | 1 + fs/userfaultfd.c | 25 +-- fs/xfs/libxfs/xfs_attr.c | 231 ++++++++++++--------- fs/xfs/{ => libxfs}/xfs_attr.h | 2 + fs/xfs/libxfs/xfs_bmap.c | 54 +++-- fs/xfs/libxfs/xfs_bmap.h | 1 + fs/xfs/libxfs/xfs_defer.c | 14 +- fs/xfs/xfs_dquot.c | 17 +- fs/xfs/xfs_iops.c | 1 + include/trace/events/rxrpc.h | 6 +- kernel/irq/irqdesc.c | 15 +- mm/huge_memory.c | 4 + mm/zsmalloc.c | 78 ++++++- net/bridge/netfilter/ebtables.c | 4 +- net/can/gw.c | 48 +++-- net/ceph/osd_client.c | 9 +- net/netfilter/ipset/ip_set_bitmap_ipmac.c | 2 +- net/netfilter/ipset/ip_set_core.c | 2 +- net/netfilter/ipset/ip_set_hash_ipmac.c | 6 +- net/rxrpc/af_rxrpc.c | 4 +- net/rxrpc/ar-internal.h | 6 +- net/rxrpc/input.c | 16 +- net/rxrpc/local_object.c | 101 +++++---- net/rxrpc/peer_event.c | 2 +- net/rxrpc/peer_object.c | 18 ++ net/rxrpc/sendmsg.c | 1 + sound/soc/davinci/davinci-mcasp.c | 43 +++- sound/soc/rockchip/rockchip_i2s.c | 5 +- sound/soc/soc-core.c | 7 +- sound/soc/soc-dapm.c | 8 +- tools/perf/bench/numa.c | 6 +- tools/perf/builtin-ftrace.c | 2 +- tools/perf/pmu-events/jevents.c | 1 + tools/perf/util/cpumap.c | 5 +- tools/testing/selftests/bpf/sendmsg6_prog.c | 3 +- tools/testing/selftests/kvm/config | 3 + .../selftests/net/forwarding/gre_multipath.sh | 28 +-- 104 files changed, 1265 insertions(+), 494 deletions(-)

4 years, 9 months

9
117
0 0

patch "fsi: scom: Don't abort operations for minor errors" added to char-misc-linus

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled fsi: scom: Don't abort operations for minor errors to my char-misc git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git in the char-misc-linus branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will hopefully also be merged in Linus's tree for the next -rc kernel release. If you have any questions about this process, please let me know. >From 8919dfcb31161fae7d607bbef5247e5e82fd6457 Mon Sep 17 00:00:00 2001 From: Eddie James <eajames(a)linux.ibm.com> Date: Tue, 27 Aug 2019 12:12:49 +0800 Subject: fsi: scom: Don't abort operations for minor errors The scom driver currently fails out of operations if certain system errors are flagged in the status register; system checkstop, special attention, or recoverable error. These errors won't impact the ability of the scom engine to perform operations, so the driver should continue under these conditions. Also, don't do a PIB reset for these conditions, since it won't help. Fixes: 6b293258cded ("fsi: scom: Major overhaul") Signed-off-by: Eddie James <eajames(a)linux.ibm.com> Cc: stable <stable(a)vger.kernel.org> Acked-by: Jeremy Kerr <jk(a)ozlabs.org> Acked-by: Benjamin Herrenschmidt <benh(a)kernel.crashing.org> Signed-off-by: Joel Stanley <joel(a)jms.id.au> Link: https://lore.kernel.org/r/20190827041249.13381-1-jk@ozlabs.org Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/fsi/fsi-scom.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c index 343153d47e5b..004dc03ccf09 100644 --- a/drivers/fsi/fsi-scom.c +++ b/drivers/fsi/fsi-scom.c @@ -38,8 +38,7 @@ #define SCOM_STATUS_PIB_RESP_MASK 0x00007000 #define SCOM_STATUS_PIB_RESP_SHIFT 12 -#define SCOM_STATUS_ANY_ERR (SCOM_STATUS_ERR_SUMMARY | \ - SCOM_STATUS_PROTECTION | \ +#define SCOM_STATUS_ANY_ERR (SCOM_STATUS_PROTECTION | \ SCOM_STATUS_PARITY | \ SCOM_STATUS_PIB_ABORT | \ SCOM_STATUS_PIB_RESP_MASK) @@ -251,11 +250,6 @@ static int handle_fsi2pib_status(struct scom_device *scom, uint32_t status) /* Return -EBUSY on PIB abort to force a retry */ if (status & SCOM_STATUS_PIB_ABORT) return -EBUSY; - if (status & SCOM_STATUS_ERR_SUMMARY) { - fsi_device_write(scom->fsi_dev, SCOM_FSI2PIB_RESET_REG, &dummy, - sizeof(uint32_t)); - return -EIO; - } return 0; } -- 2.23.0

4 years, 9 months

1
0
0 0

patch "USB: cdc-wdm: fix race between write and disconnect due to flag abuse" added to usb-linus

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled USB: cdc-wdm: fix race between write and disconnect due to flag abuse to my usb git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git in the usb-linus branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will hopefully also be merged in Linus's tree for the next -rc kernel release. If you have any questions about this process, please let me know. >From 1426bd2c9f7e3126e2678e7469dca9fd9fc6dd3e Mon Sep 17 00:00:00 2001 From: Oliver Neukum <oneukum(a)suse.com> Date: Tue, 27 Aug 2019 12:34:36 +0200 Subject: USB: cdc-wdm: fix race between write and disconnect due to flag abuse In case of a disconnect an ongoing flush() has to be made fail. Nevertheless we cannot be sure that any pending URB has already finished, so although they will never succeed, they still must not be touched. The clean solution for this is to check for WDM_IN_USE and WDM_DISCONNECTED in flush(). There is no point in ever clearing WDM_IN_USE, as no further writes make sense. The issue is as old as the driver. Fixes: afba937e540c9 ("USB: CDC WDM driver") Reported-by: syzbot+d232cca6ec42c2edb3fc(a)syzkaller.appspotmail.com Signed-off-by: Oliver Neukum <oneukum(a)suse.com> Cc: stable <stable(a)vger.kernel.org> Link: https://lore.kernel.org/r/20190827103436.21143-1-oneukum@suse.com Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/usb/class/cdc-wdm.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-wdm.c index a7824a51f86d..70afb2ca1eab 100644 --- a/drivers/usb/class/cdc-wdm.c +++ b/drivers/usb/class/cdc-wdm.c @@ -587,10 +587,20 @@ static int wdm_flush(struct file *file, fl_owner_t id) { struct wdm_device *desc = file->private_data; - wait_event(desc->wait, !test_bit(WDM_IN_USE, &desc->flags)); + wait_event(desc->wait, + /* + * needs both flags. We cannot do with one + * because resetting it would cause a race + * with write() yet we need to signal + * a disconnect + */ + !test_bit(WDM_IN_USE, &desc->flags) || + test_bit(WDM_DISCONNECTING, &desc->flags)); /* cannot dereference desc->intf if WDM_DISCONNECTING */ - if (desc->werr < 0 && !test_bit(WDM_DISCONNECTING, &desc->flags)) + if (test_bit(WDM_DISCONNECTING, &desc->flags)) + return -ENODEV; + if (desc->werr < 0) dev_err(&desc->intf->dev, "Error in flush path: %d\n", desc->werr); @@ -974,8 +984,6 @@ static void wdm_disconnect(struct usb_interface *intf) spin_lock_irqsave(&desc->iuspin, flags); set_bit(WDM_DISCONNECTING, &desc->flags); set_bit(WDM_READ, &desc->flags); - /* to terminate pending flushes */ - clear_bit(WDM_IN_USE, &desc->flags); spin_unlock_irqrestore(&desc->iuspin, flags); wake_up_all(&desc->wait); mutex_lock(&desc->rlock); -- 2.23.0

4 years, 9 months

1
0
0 0

patch "usb: host: xhci: rcar: Fix typo in compatible string matching" added to usb-linus

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled usb: host: xhci: rcar: Fix typo in compatible string matching to my usb git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git in the usb-linus branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will hopefully also be merged in Linus's tree for the next -rc kernel release. If you have any questions about this process, please let me know. >From 636bd02a7ba9025ff851d0cfb92768c8fa865859 Mon Sep 17 00:00:00 2001 From: Geert Uytterhoeven <geert+renesas(a)glider.be> Date: Tue, 27 Aug 2019 14:51:12 +0200 Subject: usb: host: xhci: rcar: Fix typo in compatible string matching It's spelled "renesas", not "renensas". Due to this typo, RZ/G1M and RZ/G1N were not covered by the check. Fixes: 2dc240a3308b ("usb: host: xhci: rcar: retire use of xhci_plat_type_is()") Signed-off-by: Geert Uytterhoeven <geert+renesas(a)glider.be> Cc: stable <stable(a)vger.kernel.org> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh(a)renesas.com> Link: https://lore.kernel.org/r/20190827125112.12192-1-geert+renesas@glider.be Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/usb/host/xhci-rcar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-rcar.c b/drivers/usb/host/xhci-rcar.c index 8616c52849c6..2b0ccd150209 100644 --- a/drivers/usb/host/xhci-rcar.c +++ b/drivers/usb/host/xhci-rcar.c @@ -104,7 +104,7 @@ static int xhci_rcar_is_gen2(struct device *dev) return of_device_is_compatible(node, "renesas,xhci-r8a7790") || of_device_is_compatible(node, "renesas,xhci-r8a7791") || of_device_is_compatible(node, "renesas,xhci-r8a7793") || - of_device_is_compatible(node, "renensas,rcar-gen2-xhci"); + of_device_is_compatible(node, "renesas,rcar-gen2-xhci"); } static int xhci_rcar_is_gen3(struct device *dev) -- 2.23.0

4 years, 9 months

1
0
0 0

patch "USB: storage: ums-realtek: Whitelist auto-delink support" added to usb-linus

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled USB: storage: ums-realtek: Whitelist auto-delink support to my usb git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git in the usb-linus branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will hopefully also be merged in Linus's tree for the next -rc kernel release. If you have any questions about this process, please let me know. >From 1902a01e2bcc3abd7c9a18dc05e78c7ab4a53c54 Mon Sep 17 00:00:00 2001 From: Kai-Heng Feng <kai.heng.feng(a)canonical.com> Date: Wed, 28 Aug 2019 01:34:50 +0800 Subject: USB: storage: ums-realtek: Whitelist auto-delink support Auto-delink requires writing special registers to ums-realtek devices. Unconditionally enable auto-delink may break newer devices. So only enable auto-delink by default for the original three IDs, 0x0138, 0x0158 and 0x0159. Realtek is working on a patch to properly support auto-delink for other IDs. BugLink: https://bugs.launchpad.net/bugs/1838886 Signed-off-by: Kai-Heng Feng <kai.heng.feng(a)canonical.com> Acked-by: Alan Stern <stern(a)rowland.harvard.edu> Cc: stable <stable(a)vger.kernel.org> Link: https://lore.kernel.org/r/20190827173450.13572-2-kai.heng.feng@canonical.com Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/usb/storage/realtek_cr.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/usb/storage/realtek_cr.c b/drivers/usb/storage/realtek_cr.c index beaffac805af..1d9ce9cbc831 100644 --- a/drivers/usb/storage/realtek_cr.c +++ b/drivers/usb/storage/realtek_cr.c @@ -996,12 +996,15 @@ static int init_realtek_cr(struct us_data *us) goto INIT_FAIL; } - if (CHECK_FW_VER(chip, 0x5888) || CHECK_FW_VER(chip, 0x5889) || - CHECK_FW_VER(chip, 0x5901)) - SET_AUTO_DELINK(chip); - if (STATUS_LEN(chip) == 16) { - if (SUPPORT_AUTO_DELINK(chip)) + if (CHECK_PID(chip, 0x0138) || CHECK_PID(chip, 0x0158) || + CHECK_PID(chip, 0x0159)) { + if (CHECK_FW_VER(chip, 0x5888) || CHECK_FW_VER(chip, 0x5889) || + CHECK_FW_VER(chip, 0x5901)) SET_AUTO_DELINK(chip); + if (STATUS_LEN(chip) == 16) { + if (SUPPORT_AUTO_DELINK(chip)) + SET_AUTO_DELINK(chip); + } } #ifdef CONFIG_REALTEK_AUTOPM if (ss_en) -- 2.23.0

4 years, 9 months

1
0
0 0

patch "USB: storage: ums-realtek: Update module parameter description for" added to usb-linus

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled USB: storage: ums-realtek: Update module parameter description for to my usb git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git in the usb-linus branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will hopefully also be merged in Linus's tree for the next -rc kernel release. If you have any questions about this process, please let me know. >From f6445b6b2f2bb1745080af4a0926049e8bca2617 Mon Sep 17 00:00:00 2001 From: Kai-Heng Feng <kai.heng.feng(a)canonical.com> Date: Wed, 28 Aug 2019 01:34:49 +0800 Subject: USB: storage: ums-realtek: Update module parameter description for auto_delink_en The option named "auto_delink_en" is a bit misleading, as setting it to false doesn't really disable auto-delink but let auto-delink be firmware controlled. Update the description to reflect the real usage of this parameter. Signed-off-by: Kai-Heng Feng <kai.heng.feng(a)canonical.com> Cc: stable <stable(a)vger.kernel.org> Link: https://lore.kernel.org/r/20190827173450.13572-1-kai.heng.feng@canonical.com Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/usb/storage/realtek_cr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/storage/realtek_cr.c b/drivers/usb/storage/realtek_cr.c index cc794e25a0b6..beaffac805af 100644 --- a/drivers/usb/storage/realtek_cr.c +++ b/drivers/usb/storage/realtek_cr.c @@ -38,7 +38,7 @@ MODULE_LICENSE("GPL"); static int auto_delink_en = 1; module_param(auto_delink_en, int, S_IRUGO | S_IWUSR); -MODULE_PARM_DESC(auto_delink_en, "enable auto delink"); +MODULE_PARM_DESC(auto_delink_en, "auto delink mode (0=firmware, 1=software [default])"); #ifdef CONFIG_REALTEK_AUTOPM static int ss_en = 1; -- 2.23.0

4 years, 9 months

1
0
0 0

patch "usb: host: ohci: fix a race condition between shutdown and irq" added to usb-linus

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled usb: host: ohci: fix a race condition between shutdown and irq to my usb git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git in the usb-linus branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will hopefully also be merged in Linus's tree for the next -rc kernel release. If you have any questions about this process, please let me know. >From a349b95d7ca0cea71be4a7dac29830703de7eb62 Mon Sep 17 00:00:00 2001 From: Yoshihiro Shimoda <yoshihiro.shimoda.uh(a)renesas.com> Date: Tue, 27 Aug 2019 12:51:50 +0900 Subject: usb: host: ohci: fix a race condition between shutdown and irq This patch fixes an issue that the following error is possible to happen when ohci hardware causes an interruption and the system is shutting down at the same time. [ 34.851754] usb 2-1: USB disconnect, device number 2 [ 35.166658] irq 156: nobody cared (try booting with the "irqpoll" option) [ 35.173445] CPU: 0 PID: 22 Comm: kworker/0:1 Not tainted 5.3.0-rc5 #85 [ 35.179964] Hardware name: Renesas Salvator-X 2nd version board based on r8a77965 (DT) [ 35.187886] Workqueue: usb_hub_wq hub_event [ 35.192063] Call trace: [ 35.194509] dump_backtrace+0x0/0x150 [ 35.198165] show_stack+0x14/0x20 [ 35.201475] dump_stack+0xa0/0xc4 [ 35.204785] __report_bad_irq+0x34/0xe8 [ 35.208614] note_interrupt+0x2cc/0x318 [ 35.212446] handle_irq_event_percpu+0x5c/0x88 [ 35.216883] handle_irq_event+0x48/0x78 [ 35.220712] handle_fasteoi_irq+0xb4/0x188 [ 35.224802] generic_handle_irq+0x24/0x38 [ 35.228804] __handle_domain_irq+0x5c/0xb0 [ 35.232893] gic_handle_irq+0x58/0xa8 [ 35.236548] el1_irq+0xb8/0x180 [ 35.239681] __do_softirq+0x94/0x23c [ 35.243253] irq_exit+0xd0/0xd8 [ 35.246387] __handle_domain_irq+0x60/0xb0 [ 35.250475] gic_handle_irq+0x58/0xa8 [ 35.254130] el1_irq+0xb8/0x180 [ 35.257268] kernfs_find_ns+0x5c/0x120 [ 35.261010] kernfs_find_and_get_ns+0x3c/0x60 [ 35.265361] sysfs_unmerge_group+0x20/0x68 [ 35.269454] dpm_sysfs_remove+0x2c/0x68 [ 35.273284] device_del+0x80/0x370 [ 35.276683] hid_destroy_device+0x28/0x60 [ 35.280686] usbhid_disconnect+0x4c/0x80 [ 35.284602] usb_unbind_interface+0x6c/0x268 [ 35.288867] device_release_driver_internal+0xe4/0x1b0 [ 35.293998] device_release_driver+0x14/0x20 [ 35.298261] bus_remove_device+0x110/0x128 [ 35.302350] device_del+0x148/0x370 [ 35.305832] usb_disable_device+0x8c/0x1d0 [ 35.309921] usb_disconnect+0xc8/0x2d0 [ 35.313663] hub_event+0x6e0/0x1128 [ 35.317146] process_one_work+0x1e0/0x320 [ 35.321148] worker_thread+0x40/0x450 [ 35.324805] kthread+0x124/0x128 [ 35.328027] ret_from_fork+0x10/0x18 [ 35.331594] handlers: [ 35.333862] [<0000000079300c1d>] usb_hcd_irq [ 35.338126] [<0000000079300c1d>] usb_hcd_irq [ 35.342389] Disabling IRQ #156 ohci_shutdown() disables all the interrupt and rh_state is set to OHCI_RH_HALTED. In other hand, ohci_irq() is possible to enable OHCI_INTR_SF and OHCI_INTR_MIE on ohci_irq(). Note that OHCI_INTR_SF is possible to be set by start_ed_unlink() which is called: ohci_irq() -> process_done_list() -> takeback_td() -> start_ed_unlink() So, ohci_irq() has the following condition, the issue happens by &ohci->regs->intrenable = OHCI_INTR_MIE | OHCI_INTR_SF and ohci->rh_state = OHCI_RH_HALTED: /* interrupt for some other device? */ if (ints == 0 || unlikely(ohci->rh_state == OHCI_RH_HALTED)) return IRQ_NOTMINE; To fix the issue, ohci_shutdown() holds the spin lock while disabling the interruption and changing the rh_state flag to prevent reenable the OHCI_INTR_MIE unexpectedly. Note that io_watchdog_func() also calls the ohci_shutdown() and it already held the spin lock, so that the patch makes a new function as _ohci_shutdown(). This patch is inspired by a Renesas R-Car Gen3 BSP patch from Tho Vu. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh(a)renesas.com> Cc: stable <stable(a)vger.kernel.org> Acked-by: Alan Stern <stern(a)rowland.harvard.edu> Link: https://lore.kernel.org/r/1566877910-6020-1-git-send-email-yoshihiro.shimod… Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/usb/host/ohci-hcd.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c index b457fdaff297..1fe3deec35cf 100644 --- a/drivers/usb/host/ohci-hcd.c +++ b/drivers/usb/host/ohci-hcd.c @@ -419,8 +419,7 @@ static void ohci_usb_reset (struct ohci_hcd *ohci) * other cases where the next software may expect clean state from the * "firmware". this is bus-neutral, unlike shutdown() methods. */ -static void -ohci_shutdown (struct usb_hcd *hcd) +static void _ohci_shutdown(struct usb_hcd *hcd) { struct ohci_hcd *ohci; @@ -436,6 +435,16 @@ ohci_shutdown (struct usb_hcd *hcd) ohci->rh_state = OHCI_RH_HALTED; } +static void ohci_shutdown(struct usb_hcd *hcd) +{ + struct ohci_hcd *ohci = hcd_to_ohci(hcd); + unsigned long flags; + + spin_lock_irqsave(&ohci->lock, flags); + _ohci_shutdown(hcd); + spin_unlock_irqrestore(&ohci->lock, flags); +} + /*-------------------------------------------------------------------------* * HC functions *-------------------------------------------------------------------------*/ @@ -760,7 +769,7 @@ static void io_watchdog_func(struct timer_list *t) died: usb_hc_died(ohci_to_hcd(ohci)); ohci_dump(ohci); - ohci_shutdown(ohci_to_hcd(ohci)); + _ohci_shutdown(ohci_to_hcd(ohci)); goto done; } else { /* No write back because the done queue was empty */ -- 2.23.0

4 years, 9 months

1
0
0 0

patch "usb: hcd: use managed device resources" added to usb-linus

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled usb: hcd: use managed device resources to my usb git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git in the usb-linus branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will hopefully also be merged in Linus's tree for the next -rc kernel release. If you have any questions about this process, please let me know. >From 76da906ad727048a74bb8067031ee99fc070c7da Mon Sep 17 00:00:00 2001 From: "Schmid, Carsten" <Carsten_Schmid(a)mentor.com> Date: Fri, 23 Aug 2019 14:11:28 +0000 Subject: usb: hcd: use managed device resources Using managed device resources in usb_hcd_pci_probe() allows devm usage for resource subranges, such as the mmio resource for the platform device created to control host/device mode mux, which is a xhci extended capability, and sits inside the xhci mmio region. If managed device resources are not used then "parent" resource is released before subrange at driver removal as .remove callback is called before the devres list of resources for this device is walked and released. This has been observed with the xhci extended capability driver causing a use-after-free which is now fixed. An additional nice benefit is that error handling on driver initialisation is simplified much. Signed-off-by: Carsten Schmid <carsten_schmid(a)mentor.com> Tested-by: Carsten Schmid <carsten_schmid(a)mentor.com> Reviewed-by: Mathias Nyman <mathias.nyman(a)linux.intel.com> Fixes: fa31b3cb2ae1 ("xhci: Add Intel extended cap / otg phy mux handling") Cc: <stable(a)vger.kernel.org> # v4.19+ Link: https://lore.kernel.org/r/1566569488679.31808@mentor.com Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/usb/core/hcd-pci.c | 30 ++++++++---------------------- 1 file changed, 8 insertions(+), 22 deletions(-) diff --git a/drivers/usb/core/hcd-pci.c b/drivers/usb/core/hcd-pci.c index 03432467b05f..7537681355f6 100644 --- a/drivers/usb/core/hcd-pci.c +++ b/drivers/usb/core/hcd-pci.c @@ -216,17 +216,18 @@ int usb_hcd_pci_probe(struct pci_dev *dev, const struct pci_device_id *id) /* EHCI, OHCI */ hcd->rsrc_start = pci_resource_start(dev, 0); hcd->rsrc_len = pci_resource_len(dev, 0); - if (!request_mem_region(hcd->rsrc_start, hcd->rsrc_len, - driver->description)) { + if (!devm_request_mem_region(&dev->dev, hcd->rsrc_start, + hcd->rsrc_len, driver->description)) { dev_dbg(&dev->dev, "controller already in use\n"); retval = -EBUSY; goto put_hcd; } - hcd->regs = ioremap_nocache(hcd->rsrc_start, hcd->rsrc_len); + hcd->regs = devm_ioremap_nocache(&dev->dev, hcd->rsrc_start, + hcd->rsrc_len); if (hcd->regs == NULL) { dev_dbg(&dev->dev, "error mapping memory\n"); retval = -EFAULT; - goto release_mem_region; + goto put_hcd; } } else { @@ -240,8 +241,8 @@ int usb_hcd_pci_probe(struct pci_dev *dev, const struct pci_device_id *id) hcd->rsrc_start = pci_resource_start(dev, region); hcd->rsrc_len = pci_resource_len(dev, region); - if (request_region(hcd->rsrc_start, hcd->rsrc_len, - driver->description)) + if (devm_request_region(&dev->dev, hcd->rsrc_start, + hcd->rsrc_len, driver->description)) break; } if (region == PCI_ROM_RESOURCE) { @@ -275,20 +276,13 @@ int usb_hcd_pci_probe(struct pci_dev *dev, const struct pci_device_id *id) } if (retval != 0) - goto unmap_registers; + goto put_hcd; device_wakeup_enable(hcd->self.controller); if (pci_dev_run_wake(dev)) pm_runtime_put_noidle(&dev->dev); return retval; -unmap_registers: - if (driver->flags & HCD_MEMORY) { - iounmap(hcd->regs); -release_mem_region: - release_mem_region(hcd->rsrc_start, hcd->rsrc_len); - } else - release_region(hcd->rsrc_start, hcd->rsrc_len); put_hcd: usb_put_hcd(hcd); disable_pci: @@ -347,14 +341,6 @@ void usb_hcd_pci_remove(struct pci_dev *dev) dev_set_drvdata(&dev->dev, NULL); up_read(&companions_rwsem); } - - if (hcd->driver->flags & HCD_MEMORY) { - iounmap(hcd->regs); - release_mem_region(hcd->rsrc_start, hcd->rsrc_len); - } else { - release_region(hcd->rsrc_start, hcd->rsrc_len); - } - usb_put_hcd(hcd); pci_disable_device(dev); } -- 2.23.0

4 years, 9 months

1
0
0 0

patch "typec: tcpm: fix a typo in the comparison of pdo_max_voltage" added to usb-linus

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled typec: tcpm: fix a typo in the comparison of pdo_max_voltage to my usb git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git in the usb-linus branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will hopefully also be merged in Linus's tree for the next -rc kernel release. If you have any questions about this process, please let me know. >From a684d8fd87182090ee96e34519ecdf009cef093a Mon Sep 17 00:00:00 2001 From: Colin Ian King <colin.king(a)canonical.com> Date: Thu, 22 Aug 2019 14:52:12 +0100 Subject: typec: tcpm: fix a typo in the comparison of pdo_max_voltage There appears to be a typo in the comparison of pdo_max_voltage[i] with the previous value, currently it is checking against the array pdo_min_voltage rather than pdo_max_voltage. I believe this is a typo. Fix this. Addresses-Coverity: ("Copy-paste error") Fixes: 5007e1b5db73 ("typec: tcpm: Validate source and sink caps") Cc: stable <stable(a)vger.kernel.org> Signed-off-by: Colin Ian King <colin.king(a)canonical.com> Reviewed-by: Guenter Roeck <linux(a)roeck-us.net> Reviewed-by: Heikki Krogerus <heikki.krogerus(a)linux.intel.com> Link: https://lore.kernel.org/r/20190822135212.10195-1-colin.king@canonical.com Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/usb/typec/tcpm/tcpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c index 15abe1d9958f..bcfdb55fd198 100644 --- a/drivers/usb/typec/tcpm/tcpm.c +++ b/drivers/usb/typec/tcpm/tcpm.c @@ -1446,7 +1446,7 @@ static enum pdo_err tcpm_caps_err(struct tcpm_port *port, const u32 *pdo, else if ((pdo_min_voltage(pdo[i]) == pdo_min_voltage(pdo[i - 1])) && (pdo_max_voltage(pdo[i]) == - pdo_min_voltage(pdo[i - 1]))) + pdo_max_voltage(pdo[i - 1]))) return PDO_ERR_DUPE_PDO; break; /* -- 2.23.0

4 years, 9 months

1
0
0 0

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror August 2019