September 2020 - Linux-stable-mirror

[stable 5.8] rcu: INFO: rcu_sched self-detected stall on CPU - RIP: 0010:trace_graph_return

by Naresh Kamboju

While running LTP trace test case on qemu_x86_64, qemu_i386 and i386 the following kernel rcu: INFO reported. Easily reproducible on qemu_x86_64, qemu_i386 and i386 devices. steps to reproduce: # Boot qemu_x86_64 or qemu i386 or i386 with trace configs enabled. # cd /opt/ltp # ./runltp -f tracing metadata: git branch: linux-5.8.y git repo: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc git commit: f2ae9d9cdf48e015834ce21030249793bf0c44f5 git describe: v5.8.9-296-gf2ae9d9cdf48 make_kernelversion: 5.8.11-rc1 kernel-config: https://builds.tuxbuild.com/SQySbShzDnHK3CzpR1T7GA/kernel.config [ 99.868127] rcu: INFO: rcu_sched self-detected stall on CPU [ 99.868127] rcu: 3-....: (1 GPs behind) idle=d66/1/0x4000000000000000 softirq=2573/2600 fqs=3631 [ 99.868127] (t=21003 jiffies g=2909 q=4480) [ 99.868127] NMI backtrace for cpu 3 [ 99.868127] CPU: 3 PID: 781 Comm: sh Not tainted 5.8.11-rc1 #1 [ 99.868127] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014 [ 99.874535] Call Trace: [ 99.874535] <IRQ> [ 99.874535] ? ftrace_graph_caller+0xc0/0xc0 [ 99.874535] dump_stack+0x81/0xba [ 99.874535] nmi_cpu_backtrace.cold+0x14/0x54 [ 99.874535] ? lapic_can_unplug_cpu.cold+0x3b/0x3b [ 99.874535] nmi_trigger_cpumask_backtrace+0x85/0x92 [ 99.874535] arch_trigger_cpumask_backtrace+0x19/0x20 [ 99.874535] ? ftrace_graph_caller+0xc0/0xc0 [ 99.874535] rcu_dump_cpu_stacks+0xa0/0xd2 [ 99.874535] ? ftrace_graph_caller+0xc0/0xc0 [ 99.874535] rcu_sched_clock_irq.cold+0x23a/0x41c [ 99.874535] ? rcu_sched_clock_irq+0x5/0x490 [ 99.874535] ? ftrace_graph_caller+0xc0/0xc0 [ 99.874535] update_process_times+0x28/0x60 [ 99.874535] ? ftrace_graph_caller+0xc0/0xc0 [ 99.874535] tick_sched_handle.isra.0+0x34/0x50 [ 99.874535] ? ftrace_graph_caller+0xc0/0xc0 [ 99.874535] tick_sched_timer+0x40/0x80 [ 99.874535] ? ftrace_graph_caller+0xc0/0xc0 [ 99.874535] __hrtimer_run_queues+0x96/0x2b0 [ 99.874535] ? tick_sched_handle.isra.0+0x50/0x50 [ 99.874535] ? ftrace_graph_caller+0xc0/0xc0 [ 99.874535] hrtimer_interrupt+0x109/0x220 [ 99.874535] ? ftrace_graph_caller+0xc0/0xc0 [ 99.874535] __sysvec_apic_timer_interrupt+0x64/0x100 [ 99.874535] ? ftrace_graph_caller+0xc0/0xc0 [ 99.874535] asm_call_on_stack+0x12/0x20 [ 99.874535] </IRQ> [ 99.874535] sysvec_apic_timer_interrupt+0x7e/0x90 [ 99.874535] asm_sysvec_apic_timer_interrupt+0x12/0x20 [ 99.874535] RIP: 0010:__text_poke+0x367/0x3f0 [ 99.874535] Code: 14 25 80 6d 01 00 e8 b8 80 03 00 65 48 8b 05 d0 f0 76 63 a8 aa 75 58 ba 00 10 00 00 e9 d9 fe ff ff e8 3d 8f 1f 00 ff 75 c0 9d <e9> 1a ff ff ff 4c 89 e7 e8 8c 0a 29 00 48 89 c1 49 81 ff 00 10 00 [ 99.874535] RSP: 0018:ffffa932c0947c40 EFLAGS: 00000286 [ 99.874535] RAX: ffffa932c0947ca8 RBX: ffff8ce37b16deb8 RCX: 0000000000000000 [ 99.874535] RDX: 0000000000000001 RSI: ffffffff9c8d2550 RDI: ffffffff9c8a7c03 [ 99.874535] RBP: ffffa932c0947ca8 R08: ffff8ce3619cc280 R09: ffff8ce3619d7000 [ 99.874535] R10: 0000000000000668 R11: ffff8ce3619d7678 R12: ffffffff9d0a8620 [ 99.874535] R13: 0000000000000001 R14: ffffffff9e5b7de9 R15: 0000000000000621 [ 99.874535] ? dpm_suspend+0x240/0x240 [ 99.912445] ? ftrace_graph_caller+0xc0/0xc0 [ 99.912445] ? __text_poke+0x363/0x3f0 [ 99.912445] ? ftrace_graph_caller+0xc0/0xc0 [ 99.912445] text_poke_bp_batch+0x123/0x190 [ 99.912445] ? node_access_release+0x10/0x10 [ 99.912445] ? ftrace_graph_caller+0xc0/0xc0 [ 99.912445] text_poke_queue+0xa7/0xd0 [ 99.912445] ? ftrace_graph_caller+0xc0/0xc0 [ 99.912445] ftrace_replace_code+0x11f/0x170 [ 99.912445] ftrace_modify_all_code+0xc8/0x160 [ 99.912445] arch_ftrace_update_code+0x9/0x10 [ 99.912445] ftrace_run_update_code+0x1a/0x70 [ 99.912445] ftrace_startup_enable+0x2e/0x50 [ 99.912445] ftrace_startup+0xa4/0x100 [ 99.912445] register_ftrace_function+0x25/0x70 [ 99.912445] stack_trace_sysctl+0x77/0x9c [ 99.912445] proc_sys_call_handler+0x164/0x190 [ 99.912445] proc_sys_write+0x14/0x20 [ 99.912445] vfs_write+0xc9/0x200 [ 99.912445] ksys_write+0x67/0xe0 [ 99.912445] __x64_sys_write+0x1a/0x20 [ 99.912445] do_syscall_64+0x51/0x90 [ 99.912445] entry_SYSCALL_64_after_hwframe+0x44/0xa9 [ 99.912445] RIP: 0033:0x7f1163016144 [ 99.912445] Code: 89 02 48 c7 c0 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 8d 05 c1 e7 2c 00 8b 00 85 c0 75 13 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 54 c3 0f 1f 00 41 54 49 89 d4 55 48 89 f5 53 [ 99.912445] RSP: 002b:00007ffe884a34d8 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 [ 99.912445] RAX: ffffffffffffffda RBX: 0000000000000002 RCX: 00007f1163016144 [ 99.912445] RDX: 0000000000000002 RSI: 0000000001852ea0 RDI: 0000000000000001 [ 99.912445] RBP: 0000000001852ea0 R08: 000000000000000a R09: 00007f11630633e0 [ 99.912445] R10: 000000000000000a R11: 0000000000000246 R12: 00007f11632e0760 [ 99.912445] R13: 0000000000000002 R14: 00007f11632db760 R15: 0000000000000002 [ 173.329178] rcu: INFO: rcu_sched self-detected stall on CPU [ 173.329178] rcu: 2-....: (20973 ticks this GP) idle=a4a/1/0x4000000000000000 softirq=3412/3412 fqs=4832 [ 173.329178] (t=21000 jiffies g=3197 q=7683) [ 173.329178] NMI backtrace for cpu 2 [ 173.329178] CPU: 2 PID: 781 Comm: sh Not tainted 5.8.11-rc1 #1 [ 173.329178] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014 [ 173.329178] Call Trace: [ 173.329178] <IRQ> [ 173.329178] ? ftrace_graph_caller+0xc0/0xc0 [ 173.329178] dump_stack+0x81/0xba [ 173.329178] nmi_cpu_backtrace.cold+0x14/0x54 [ 173.329178] ? lapic_can_unplug_cpu.cold+0x3b/0x3b [ 173.329178] nmi_trigger_cpumask_backtrace+0x85/0x92 [ 173.329178] arch_trigger_cpumask_backtrace+0x19/0x20 [ 173.329178] ? ftrace_graph_caller+0xc0/0xc0 [ 173.329178] rcu_dump_cpu_stacks+0xa0/0xd2 [ 173.329178] ? ftrace_graph_caller+0xc0/0xc0 [ 173.329178] rcu_sched_clock_irq.cold+0x23a/0x41c [ 173.329178] ? rcu_sched_clock_irq+0x5/0x490 [ 173.329178] ? ftrace_graph_caller+0xc0/0xc0 [ 173.329178] update_process_times+0x28/0x60 [ 173.329178] ? ftrace_graph_caller+0xc0/0xc0 [ 173.329178] tick_sched_handle.isra.0+0x34/0x50 [ 173.329178] ? ftrace_graph_caller+0xc0/0xc0 [ 173.329178] tick_sched_timer+0x40/0x80 [ 173.329178] ? ftrace_graph_caller+0xc0/0xc0 [ 173.329178] __hrtimer_run_queues+0x96/0x2b0 [ 173.329178] ? tick_sched_handle.isra.0+0x50/0x50 [ 173.329178] ? ftrace_graph_caller+0xc0/0xc0 [ 173.329178] hrtimer_interrupt+0x109/0x220 [ 173.329178] ? ftrace_graph_caller+0xc0/0xc0 [ 173.329178] __sysvec_apic_timer_interrupt+0x64/0x100 [ 173.329178] ? ftrace_graph_caller+0xc0/0xc0 [ 173.329178] asm_call_on_stack+0x12/0x20 [ 173.329178] </IRQ> [ 173.329178] sysvec_apic_timer_interrupt+0x7e/0x90 [ 173.329178] asm_sysvec_apic_timer_interrupt+0x12/0x20 [ 173.329178] RIP: 0010:__text_poke+0x367/0x3f0 [ 173.329178] Code: 14 25 80 6d 01 00 e8 b8 80 03 00 65 48 8b 05 d0 f0 76 63 a8 aa 75 58 ba 00 10 00 00 e9 d9 fe ff ff e8 3d 8f 1f 00 ff 75 c0 9d <e9> 1a ff ff ff 4c 89 e7 e8 8c 0a 29 00 48 89 c1 49 81 ff 00 10 00 [ 173.372903] RSP: 0018:ffffa932c0947c40 EFLAGS: 00000282 [ 173.374214] RAX: ffffa932c0947ca8 RBX: ffff8ce37b16deb8 RCX: 0000000000000000 [ 173.374214] RDX: 0000000000000001 RSI: ffffffff9c8d2550 RDI: ffffffff9c8a7c03 [ 173.374214] RBP: ffffa932c0947ca8 R08: ffff8ce3618c8a00 R09: ffff8ce3618f1000 [ 173.374214] R10: 0000000000000f40 R11: ffff8ce3618f1f50 R12: ffffffff9caf68e1 [ 173.374214] R13: 0000000000000004 R14: ffffffff9e5b798a R15: 00000000000008e5 [ 173.374214] ? mark_page_lazyfree+0x1/0x130 [ 173.374214] ? ftrace_graph_caller+0xc0/0xc0 [ 173.374214] ? __text_poke+0x363/0x3f0 [ 173.374214] ? ftrace_graph_caller+0xc0/0xc0 [ 173.374214] text_poke_bp_batch+0xd4/0x190 [ 173.374214] ? frag_start+0x40/0x40 [ 173.374214] ? ftrace_graph_caller+0xc0/0xc0 [ 173.374214] text_poke_queue+0xa7/0xd0 [ 173.374214] ? ftrace_graph_caller+0xc0/0xc0 [ 173.374214] ftrace_replace_code+0x11f/0x170 [ 173.397011] ftrace_modify_all_code+0xc8/0x160 [ 173.397011] arch_ftrace_update_code+0x9/0x10 [ 173.397011] ftrace_run_update_code+0x1a/0x70 [ 173.397011] ftrace_startup_enable+0x2e/0x50 [ 173.397011] ftrace_startup+0xa4/0x100 [ 173.397011] register_ftrace_function+0x25/0x70 [ 173.397011] stack_trace_sysctl+0x77/0x9c [ 173.397011] proc_sys_call_handler+0x164/0x190 [ 173.397011] proc_sys_write+0x14/0x20 [ 173.397011] vfs_write+0xc9/0x200 [ 173.397011] ksys_write+0x67/0xe0 [ 173.397011] __x64_sys_write+0x1a/0x20 [ 173.397011] do_syscall_64+0x51/0x90 [ 173.397011] entry_SYSCALL_64_after_hwframe+0x44/0xa9 [ 173.397011] RIP: 0033:0x7f1163016144 [ 173.397011] Code: 89 02 48 c7 c0 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 8d 05 c1 e7 2c 00 8b 00 85 c0 75 13 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 54 c3 0f 1f 00 41 54 49 89 d4 55 48 89 f5 53 [ 173.397011] RSP: 002b:00007ffe884a34d8 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 [ 173.397011] RAX: ffffffffffffffda RBX: 0000000000000002 RCX: 00007f1163016144 [ 173.397011] RDX: 0000000000000002 RSI: 0000000001852ea0 RDI: 0000000000000001 [ 173.397011] RBP: 0000000001852ea0 R08: 000000000000000a R09: 00007f11630633e0 [ 173.397011] R10: 000000000000000a R11: 0000000000000246 R12: 00007f11632e0760 [ 173.397011] R13: 0000000000000002 R14: 00007f11632db760 R15: 0000000000000002 [ 236.332272] rcu: INFO: rcu_sched self-detected stall on CPU [ 236.332288] rcu: 2-....: (83813 ticks this GP) idle=a4a/1/0x4000000000000000 softirq=3412/3412 fqs=18275 [ 236.332288] (t=84003 jiffies g=3197 q=21302) [ 236.332288] NMI backtrace for cpu 2 [ 236.332288] CPU: 2 PID: 781 Comm: sh Not tainted 5.8.11-rc1 #1 [ 236.332288] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014 [ 236.332288] Call Trace: [ 236.332288] <IRQ> [ 236.332288] ? ftrace_graph_caller+0xc0/0xc0 [ 236.332288] dump_stack+0x81/0xba [ 236.332288] nmi_cpu_backtrace.cold+0x14/0x54 [ 236.332288] ? lapic_can_unplug_cpu.cold+0x3b/0x3b [ 236.332288] nmi_trigger_cpumask_backtrace+0x85/0x92 [ 236.332288] arch_trigger_cpumask_backtrace+0x19/0x20 [ 236.332288] ? ftrace_graph_caller+0xc0/0xc0 [ 236.332288] rcu_dump_cpu_stacks+0xa0/0xd2 [ 236.332288] ? ftrace_graph_caller+0xc0/0xc0 [ 236.332288] rcu_sched_clock_irq.cold+0x23a/0x41c [ 236.332288] ? rcu_sched_clock_irq+0x5/0x490 [ 236.332288] ? ftrace_graph_caller+0xc0/0xc0 [ 236.332288] update_process_times+0x28/0x60 [ 236.332288] ? ftrace_graph_caller+0xc0/0xc0 [ 236.332288] tick_sched_handle.isra.0+0x34/0x50 [ 236.332288] ? ftrace_graph_caller+0xc0/0xc0 [ 236.332288] tick_sched_timer+0x40/0x80 [ 236.332288] ? ftrace_graph_caller+0xc0/0xc0 [ 236.332288] __hrtimer_run_queues+0x96/0x2b0 [ 236.332288] ? tick_sched_handle.isra.0+0x50/0x50 [ 236.332288] ? ftrace_graph_caller+0xc0/0xc0 [ 236.332288] hrtimer_interrupt+0x109/0x220 [ 236.332288] ? ftrace_graph_caller+0xc0/0xc0 [ 236.332288] __sysvec_apic_timer_interrupt+0x64/0x100 [ 236.332288] ? ftrace_graph_caller+0xc0/0xc0 [ 236.332288] asm_call_on_stack+0x12/0x20 [ 236.332288] </IRQ> [ 236.332288] sysvec_apic_timer_interrupt+0x7e/0x90 [ 236.332288] asm_sysvec_apic_timer_interrupt+0x12/0x20 [ 236.332288] RIP: 0010:trace_graph_entry+0x1ce/0x200 [ 236.332288] Code: 8b 15 a6 33 57 63 81 e2 00 00 0f 00 74 24 48 81 88 c8 09 00 00 00 02 00 00 e9 c4 fe ff ff e9 bf fe ff ff e8 84 d1 ff ff 53 9d <8b> 45 dc e9 4d fe ff ff 48 81 a0 c8 09 00 00 ff fd ff ff e9 a0 fe [ 236.332288] RSP: 0018:ffffa932c0947a88 EFLAGS: 00000246 [ 236.332288] RAX: ffffa932c0947ab0 RBX: 0000000000000246 RCX: 0000000000000000 [ 236.332288] RDX: 0000000000000001 RSI: ffffffff9caa7fad RDI: ffffffff9caa39bc [ 236.332288] RBP: ffffa932c0947ab0 R08: ffff8ce361887800 R09: ffff8ce3618a8000 [ 236.332288] R10: 0000000000000cf0 R11: ffff8ce3618a8d00 R12: ffffffff9e274520 [ 236.332288] R13: ffffa932c0947adc R14: ffff8ce37bd2ca20 R15: ffffffff9e5c7e80 [ 236.332288] ? ftrace_graph_entry_test+0x2d/0x40 [ 236.332288] ? trace_graph_entry+0x1cc/0x200 [ 236.332288] ? insn_get_sib.part.0+0x60/0x60 [ 236.332288] ftrace_graph_entry_test+0x2d/0x40 [ 236.332288] ? insn_get_immediate.part.0+0x1ae/0x330 [ 236.332288] function_graph_enter+0xe8/0x140 [ 236.332288] ? insn_get_sib.part.0+0x60/0x60 [ 236.332288] ? insn_get_immediate.part.0+0x1ae/0x330 [ 236.332288] prepare_ftrace_return+0x5c/0x80 [ 236.332288] ? mipi_dsi_dcs_write+0xa0/0xa0 [ 236.332288] ftrace_graph_caller+0x81/0xc0 [ 236.332288] ? mipi_dsi_dcs_write+0xa0/0xa0 [ 236.332288] ? ftrace_graph_caller+0x81/0xc0 [ 236.332288] ? mipi_dsi_dcs_write+0xa0/0xa0 [ 236.332288] ? ftrace_graph_caller+0x81/0xc0 [ 236.332288] ? ftrace_return_to_handler+0x8d/0xf0 [ 236.332288] ? insn_get_displacement.part.0+0x5/0xd0 [ 236.332288] ? insn_get_immediate.part.0+0x5/0x330 [ 236.332288] insn_get_displacement.part.0+0x5/0xd0 [ 236.332288] insn_get_immediate.part.0+0x1ae/0x330 [ 236.332288] ? insn_get_displacement.part.0+0x5/0xd0 [ 236.332288] ? ftrace_graph_caller+0xc0/0xc0 [ 236.332288] ? insn_get_immediate.part.0+0x1ae/0x330 [ 236.332288] ? ftrace_graph_caller+0xc0/0xc0 [ 236.332288] insn_get_length+0x2c/0x40 [ 236.332288] ? ftrace_graph_caller+0xc0/0xc0 [ 236.332288] text_poke_loc_init+0x6f/0x160 [ 236.332288] ? mipi_dsi_dcs_write+0xa0/0xa0 [ 236.332288] ? ftrace_graph_caller+0xc0/0xc0 [ 236.332288] text_poke_queue+0x84/0xd0 [ 236.332288] ? ftrace_graph_caller+0xc0/0xc0 [ 236.332288] ftrace_replace_code+0x11f/0x170 [ 236.332288] ftrace_modify_all_code+0xc8/0x160 [ 236.332288] arch_ftrace_update_code+0x9/0x10 [ 236.332288] ftrace_run_update_code+0x1a/0x70 [ 236.332288] ftrace_startup_enable+0x2e/0x50 [ 236.332288] ftrace_startup+0xa4/0x100 [ 236.332288] register_ftrace_function+0x25/0x70 [ 236.332288] stack_trace_sysctl+0x77/0x9c [ 236.332288] proc_sys_call_handler+0x164/0x190 [ 236.332288] proc_sys_write+0x14/0x20 [ 236.332288] vfs_write+0xc9/0x200 [ 236.332288] ksys_write+0x67/0xe0 [ 236.332288] __x64_sys_write+0x1a/0x20 [ 236.332288] do_syscall_64+0x51/0x90 [ 236.332288] entry_SYSCALL_64_after_hwframe+0x44/0xa9 [ 236.332288] RIP: 0033:0x7f1163016144 [ 236.332288] Code: 89 02 48 c7 c0 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 8d 05 c1 e7 2c 00 8b 00 85 c0 75 13 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 54 c3 0f 1f 00 41 54 49 89 d4 55 48 89 f5 53 [ 236.332288] RSP: 002b:00007ffe884a34d8 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 [ 236.332288] RAX: ffffffffffffffda RBX: 0000000000000002 RCX: 00007f1163016144 [ 236.332288] RDX: 0000000000000002 RSI: 0000000001852ea0 RDI: 0000000000000001 [ 236.332288] RBP: 0000000001852ea0 R08: 000000000000000a R09: 00007f11630633e0 [ 236.332288] R10: 000000000000000a R11: 0000000000000246 R12: 00007f11632e0760 [ 236.332288] R13: 0000000000000002 R14: 00007f11632db760 R15: 0000000000000002 [ 299.335247] rcu: INFO: rcu_sched self-detected stall on CPU [ 299.335269] rcu: 2-....: (146579 ticks this GP) idle=a4a/1/0x4000000000000000 softirq=3412/3412 fqs=31785 [ 299.335269] (t=147006 jiffies g=3197 q=35014) [ 299.335269] NMI backtrace for cpu 2 [ 299.335269] CPU: 2 PID: 781 Comm: sh Not tainted 5.8.11-rc1 #1 [ 299.335269] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014 [ 299.335269] Call Trace: [ 299.335269] <IRQ> [ 299.335269] ? ftrace_graph_caller+0xc0/0xc0 [ 299.335269] dump_stack+0x81/0xba [ 299.335269] nmi_cpu_backtrace.cold+0x14/0x54 [ 299.335269] ? lapic_can_unplug_cpu.cold+0x3b/0x3b [ 299.335269] nmi_trigger_cpumask_backtrace+0x85/0x92 [ 299.335269] arch_trigger_cpumask_backtrace+0x19/0x20 [ 299.335269] ? ftrace_graph_caller+0xc0/0xc0 [ 299.335269] rcu_dump_cpu_stacks+0xa0/0xd2 [ 299.335269] ? ftrace_graph_caller+0xc0/0xc0 [ 299.335269] rcu_sched_clock_irq.cold+0x23a/0x41c [ 299.335269] ? rcu_sched_clock_irq+0x5/0x490 [ 299.335269] ? ftrace_graph_caller+0xc0/0xc0 [ 299.335269] update_process_times+0x28/0x60 [ 299.335269] ? ftrace_graph_caller+0xc0/0xc0 [ 299.335269] tick_sched_handle.isra.0+0x34/0x50 [ 299.335269] ? ftrace_graph_caller+0xc0/0xc0 [ 299.335269] tick_sched_timer+0x40/0x80 [ 299.335269] ? ftrace_graph_caller+0xc0/0xc0 [ 299.335269] __hrtimer_run_queues+0x96/0x2b0 [ 299.335269] ? tick_sched_handle.isra.0+0x50/0x50 [ 299.335269] ? ftrace_graph_caller+0xc0/0xc0 [ 299.335269] hrtimer_interrupt+0x109/0x220 [ 299.335269] ? ftrace_graph_caller+0xc0/0xc0 [ 299.335269] __sysvec_apic_timer_interrupt+0x64/0x100 [ 299.335269] ? ftrace_graph_caller+0xc0/0xc0 [ 299.335269] asm_call_on_stack+0x12/0x20 [ 299.335269] </IRQ> [ 299.335269] sysvec_apic_timer_interrupt+0x7e/0x90 [ 299.335269] asm_sysvec_apic_timer_interrupt+0x12/0x20 [ 299.335269] RIP: 0010:trace_graph_return+0xcf/0xf0 [ 299.335269] Code: e8 26 fe ff ff f0 ff 0b 41 f7 c5 00 02 00 00 75 11 41 55 9d e8 b2 d2 ff ff 5b 41 5c 41 5d 41 5e 5d c3 e8 54 cf ff ff 41 55 9d <5b> 41 5c 41 5d 41 5e 5d c3 48 81 a2 c8 09 00 00 ff fb ff ff e9 56 [ 299.335269] RSP: 0018:ffffa932c09479b8 EFLAGS: 00000246 [ 299.335269] RAX: ffffa932c09479d8 RBX: ffff8ce37bd2ca20 RCX: 0000000000000000 [ 299.335269] RDX: 0000000000000001 RSI: ffffffff9caa81ad RDI: ffffffff9caa3bec [ 299.335269] RBP: ffffa932c09479d8 R08: ffff8ce36198b680 R09: ffff8ce3619a6000 [ 299.335269] R10: 0000000000000148 R11: ffff8ce3619a6158 R12: ffffa932c09479ec [ 299.335269] R13: 0000000000000246 R14: ffffffff9e274520 R15: ffffffff9ce140b0 [ 299.335269] ? bad_get_user+0xd/0xd [ 299.335269] ? ftrace_return_to_handler+0x8d/0xf0 [ 299.335269] ? trace_graph_return+0xcc/0xf0 [ 299.335269] ? stack_trace_call+0x66/0x2f0 [ 299.335269] ? insn_get_opcode.part.0+0xb7/0x1a0 [ 299.335269] ftrace_return_to_handler+0x8d/0xf0 [ 299.335269] return_to_handler+0x15/0x30 [ 299.335269] ? ftrace_graph_caller+0xc0/0xc0 [ 299.335269] ? stack_trace_call+0x66/0x2f0 [ 299.335269] ? ftrace_ops_test+0x33/0x50 [ 299.335269] ? insn_get_opcode.part.0+0xb7/0x1a0 [ 299.335269] ? bad_get_user+0xd/0xd [ 299.335269] ftrace_ops_list_func+0x103/0x120 [ 299.335269] ? release_hwdep_device+0x20/0x20 [ 299.335269] ftrace_call+0x5/0x34 [ 299.335269] ? trace_hardirqs_on+0x38/0xf0 [ 299.335269] ? ftrace_return_to_handler+0x8d/0xf0 [ 299.335269] ? inat_get_opcode_attribute+0x5/0x20 [ 299.335269] inat_get_opcode_attribute+0x5/0x20 [ 299.335269] insn_get_opcode.part.0+0xb7/0x1a0 [ 299.335269] ? inat_get_opcode_attribute+0x5/0x20 [ 299.335269] ? insn_get_opcode.part.0+0xb7/0x1a0 [ 299.335269] ? ftrace_graph_caller+0xc0/0xc0 [ 299.335269] insn_get_modrm.part.0+0x62/0xf0 [ 299.335269] ? ftrace_graph_caller+0xc0/0xc0 [ 299.335269] insn_get_sib.part.0+0x40/0x60 [ 299.335269] ? ftrace_graph_caller+0xc0/0xc0 [ 299.335269] insn_get_displacement.part.0+0x84/0xd0 [ 299.335269] ? ftrace_graph_caller+0xc0/0xc0 [ 299.335269] insn_get_immediate.part.0+0x1ae/0x330 [ 299.335269] ? ftrace_graph_caller+0xc0/0xc0 [ 299.335269] insn_get_length+0x2c/0x40 [ 299.335269] ? ftrace_graph_caller+0xc0/0xc0 [ 299.335269] text_poke_loc_init+0x6f/0x160 [ 299.335269] ? release_hwdep_device+0x20/0x20 [ 299.335269] ? ftrace_graph_caller+0xc0/0xc0 [ 299.335269] text_poke_queue+0x84/0xd0 [ 299.335269] ? ftrace_graph_caller+0xc0/0xc0 [ 299.335269] ftrace_replace_code+0x11f/0x170 [ 299.335269] ftrace_modify_all_code+0xc8/0x160 [ 299.335269] arch_ftrace_update_code+0x9/0x10 [ 299.335269] ftrace_run_update_code+0x1a/0x70 [ 299.335269] ftrace_startup_enable+0x2e/0x50 [ 299.335269] ftrace_startup+0xa4/0x100 [ 299.335269] register_ftrace_function+0x25/0x70 [ 299.335269] stack_trace_sysctl+0x77/0x9c [ 299.335269] proc_sys_call_handler+0x164/0x190 [ 299.335269] proc_sys_write+0x14/0x20 [ 299.335269] vfs_write+0xc9/0x200 [ 299.335269] ksys_write+0x67/0xe0 [ 299.335269] __x64_sys_write+0x1a/0x20 [ 299.335269] do_syscall_64+0x51/0x90 [ 299.335269] entry_SYSCALL_64_after_hwframe+0x44/0xa9 [ 299.335269] RIP: 0033:0x7f1163016144 [ 299.335269] Code: 89 02 48 c7 c0 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 8d 05 c1 e7 2c 00 8b 00 85 c0 75 13 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 54 c3 0f 1f 00 41 54 49 89 d4 55 48 89 f5 53 [ 299.335269] RSP: 002b:00007ffe884a34d8 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 [ 299.335269] RAX: ffffffffffffffda RBX: 0000000000000002 RCX: 00007f1163016144 [ 299.335269] RDX: 0000000000000002 RSI: 0000000001852ea0 RDI: 0000000000000001 [ 299.335269] RBP: 0000000001852ea0 R08: 000000000000000a R09: 00007f11630633e0 [ 299.335269] R10: 000000000000000a R11: 0000000000000246 R12: 00007f11632e0760 [ 299.335269] R13: 0000000000000002 R14: 00007f11632db760 R15: 0000000000000002 full test log, https://lkft.validation.linaro.org/scheduler/job/1779500#L1155 https://lkft.validation.linaro.org/scheduler/job/1779336#L1180 https://lkft.validation.linaro.org/scheduler/job/1779359#L1774 -- Linaro LKFT https://lkft.linaro.org

3 years, 9 months

2
1
0 0

✅ PASS: Test report for kernel 5.8.11 (stable-queue)

by CKI Project

Hello, We ran automated tests on a recent commit from this kernel tree: Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Commit: 01a94ace543c - net/mlx5e: Fix endianness when calculating pedit mask first bit The results of these automated tests are provided below. Overall result: PASSED Merge: OK Compile: OK Tests: OK All kernel binaries, config files, and logs are available for download here: https://arr-cki-prod-datawarehouse-public.s3.amazonaws.com/index.html?prefi… Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Compile testing --------------- We compiled the kernel for 4 architectures: aarch64: make options: make -j30 INSTALL_MOD_STRIP=1 targz-pkg ppc64le: make options: make -j30 INSTALL_MOD_STRIP=1 targz-pkg s390x: make options: make -j30 INSTALL_MOD_STRIP=1 targz-pkg x86_64: make options: make -j30 INSTALL_MOD_STRIP=1 targz-pkg Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: Host 1: ✅ Boot test ✅ xfstests - ext4 ✅ xfstests - xfs ✅ selinux-policy: serge-testsuite ✅ storage: software RAID testing ✅ stress: stress-ng 🚧 ✅ xfstests - btrfs 🚧 ❌ IPMI driver test 🚧 ✅ IPMItool loop stress test 🚧 ✅ Storage blktests 🚧 ✅ Storage nvme - tcp Host 2: ✅ Boot test ✅ ACPI table test ✅ ACPI enabled test ✅ Podman system integration test - as root ✅ Podman system integration test - as user ✅ LTP ✅ Loopdev Sanity ✅ Memory: fork_mem ✅ Memory function: memfd_create ✅ AMTU (Abstract Machine Test Utility) ✅ Networking bridge: sanity ✅ Ethernet drivers sanity ✅ Networking socket: fuzz ✅ Networking: igmp conformance test ✅ Networking route: pmtu ✅ Networking route_func - local ✅ Networking route_func - forward ✅ Networking TCP: keepalive test ✅ Networking UDP: socket ✅ Networking tunnel: geneve basic test ✅ Networking tunnel: gre basic ✅ L2TP basic test ✅ Networking tunnel: vxlan basic ✅ Networking ipsec: basic netns - transport ✅ Networking ipsec: basic netns - tunnel ✅ Libkcapi AF_ALG test ✅ pciutils: update pci ids test ✅ ALSA PCM loopback test ✅ ALSA Control (mixer) Userspace Element test ✅ storage: SCSI VPD 🚧 ✅ CIFS Connectathon 🚧 ✅ POSIX pjd-fstest suites 🚧 ✅ Firmware test suite 🚧 ✅ jvm - jcstress tests 🚧 ✅ Memory function: kaslr 🚧 ✅ Networking firewall: basic netfilter test 🚧 ✅ audit: audit testsuite test 🚧 ✅ trace: ftrace/tracer 🚧 ✅ kdump - kexec_boot ppc64le: Host 1: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ⚡⚡⚡ Boot test ⚡⚡⚡ Podman system integration test - as root ⚡⚡⚡ Podman system integration test - as user ⚡⚡⚡ LTP ⚡⚡⚡ Loopdev Sanity ⚡⚡⚡ Memory: fork_mem ⚡⚡⚡ Memory function: memfd_create ⚡⚡⚡ AMTU (Abstract Machine Test Utility) ⚡⚡⚡ Networking bridge: sanity ⚡⚡⚡ Ethernet drivers sanity ⚡⚡⚡ Networking socket: fuzz ⚡⚡⚡ Networking route: pmtu ⚡⚡⚡ Networking route_func - local ⚡⚡⚡ Networking route_func - forward ⚡⚡⚡ Networking TCP: keepalive test ⚡⚡⚡ Networking UDP: socket ⚡⚡⚡ Networking tunnel: geneve basic test ⚡⚡⚡ Networking tunnel: gre basic ⚡⚡⚡ L2TP basic test ⚡⚡⚡ Networking tunnel: vxlan basic ⚡⚡⚡ Networking ipsec: basic netns - tunnel ⚡⚡⚡ Libkcapi AF_ALG test ⚡⚡⚡ pciutils: update pci ids test ⚡⚡⚡ ALSA PCM loopback test ⚡⚡⚡ ALSA Control (mixer) Userspace Element test 🚧 ⚡⚡⚡ CIFS Connectathon 🚧 ⚡⚡⚡ POSIX pjd-fstest suites 🚧 ⚡⚡⚡ jvm - jcstress tests 🚧 ⚡⚡⚡ Memory function: kaslr 🚧 ⚡⚡⚡ Networking firewall: basic netfilter test 🚧 ⚡⚡⚡ audit: audit testsuite test 🚧 ⚡⚡⚡ trace: ftrace/tracer Host 2: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ⚡⚡⚡ Boot test 🚧 ⚡⚡⚡ kdump - sysrq-c Host 3: ✅ Boot test ✅ xfstests - ext4 ✅ xfstests - xfs ✅ selinux-policy: serge-testsuite ✅ storage: software RAID testing 🚧 ✅ xfstests - btrfs 🚧 ✅ IPMI driver test 🚧 ✅ IPMItool loop stress test 🚧 ✅ Storage blktests 🚧 ✅ Storage nvme - tcp Host 4: ✅ Boot test ✅ Podman system integration test - as root ✅ Podman system integration test - as user ✅ LTP ✅ Loopdev Sanity ✅ Memory: fork_mem ✅ Memory function: memfd_create ✅ AMTU (Abstract Machine Test Utility) ✅ Networking bridge: sanity ✅ Ethernet drivers sanity ✅ Networking socket: fuzz ✅ Networking route: pmtu ✅ Networking route_func - local ✅ Networking route_func - forward ✅ Networking TCP: keepalive test ✅ Networking UDP: socket ✅ Networking tunnel: geneve basic test ✅ Networking tunnel: gre basic ✅ L2TP basic test ✅ Networking tunnel: vxlan basic ✅ Networking ipsec: basic netns - tunnel ✅ Libkcapi AF_ALG test ✅ pciutils: update pci ids test ✅ ALSA PCM loopback test ✅ ALSA Control (mixer) Userspace Element test 🚧 ✅ CIFS Connectathon 🚧 ✅ POSIX pjd-fstest suites 🚧 ✅ jvm - jcstress tests 🚧 ✅ Memory function: kaslr 🚧 ✅ Networking firewall: basic netfilter test 🚧 ✅ audit: audit testsuite test 🚧 ✅ trace: ftrace/tracer Host 5: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ⚡⚡⚡ Boot test 🚧 ⚡⚡⚡ kdump - sysrq-c s390x: Host 1: ✅ Boot test ✅ selinux-policy: serge-testsuite ✅ stress: stress-ng 🚧 ✅ Storage blktests 🚧 ✅ Storage nvme - tcp Host 2: ✅ Boot test ✅ Podman system integration test - as root ✅ Podman system integration test - as user ✅ LTP ✅ Loopdev Sanity ✅ Memory: fork_mem ✅ Memory function: memfd_create ✅ AMTU (Abstract Machine Test Utility) ✅ Networking bridge: sanity ✅ Ethernet drivers sanity ✅ Networking route: pmtu ✅ Networking route_func - local ✅ Networking route_func - forward ✅ Networking TCP: keepalive test ✅ Networking UDP: socket ✅ Networking tunnel: geneve basic test ✅ Networking tunnel: gre basic ✅ L2TP basic test ✅ Networking tunnel: vxlan basic ✅ Networking ipsec: basic netns - transport ✅ Networking ipsec: basic netns - tunnel ✅ Libkcapi AF_ALG test 🚧 ✅ CIFS Connectathon 🚧 ✅ POSIX pjd-fstest suites 🚧 ✅ jvm - jcstress tests 🚧 ✅ Memory function: kaslr 🚧 ✅ Networking firewall: basic netfilter test 🚧 ✅ audit: audit testsuite test 🚧 ✅ trace: ftrace/tracer x86_64: Host 1: ✅ Boot test 🚧 ✅ kdump - sysrq-c 🚧 ✅ kdump - file-load Host 2: ✅ Boot test ✅ ACPI table test ✅ Podman system integration test - as root ✅ Podman system integration test - as user ✅ LTP ✅ Loopdev Sanity ✅ Memory: fork_mem ✅ Memory function: memfd_create ✅ AMTU (Abstract Machine Test Utility) ✅ Networking bridge: sanity ✅ Ethernet drivers sanity ✅ Networking socket: fuzz ✅ Networking: igmp conformance test ✅ Networking route: pmtu ✅ Networking route_func - local ✅ Networking route_func - forward ✅ Networking TCP: keepalive test ✅ Networking UDP: socket ✅ Networking tunnel: geneve basic test ✅ Networking tunnel: gre basic ✅ L2TP basic test ✅ Networking tunnel: vxlan basic ✅ Networking ipsec: basic netns - transport ✅ Networking ipsec: basic netns - tunnel ✅ Libkcapi AF_ALG test ✅ pciutils: sanity smoke test ✅ pciutils: update pci ids test ✅ ALSA PCM loopback test ✅ ALSA Control (mixer) Userspace Element test ✅ storage: SCSI VPD 🚧 ✅ CIFS Connectathon 🚧 ✅ POSIX pjd-fstest suites 🚧 ✅ Firmware test suite 🚧 ✅ jvm - jcstress tests 🚧 ✅ Memory function: kaslr 🚧 ✅ Networking firewall: basic netfilter test 🚧 ✅ audit: audit testsuite test 🚧 ✅ trace: ftrace/tracer 🚧 ✅ kdump - kexec_boot Host 3: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ✅ Boot test ✅ xfstests - ext4 ✅ xfstests - xfs ✅ selinux-policy: serge-testsuite ✅ storage: software RAID testing ✅ stress: stress-ng 🚧 ✅ CPU: Frequency Driver Test 🚧 ✅ xfstests - btrfs 🚧 ⚡⚡⚡ IOMMU boot test 🚧 ⚡⚡⚡ IPMI driver test 🚧 ⚡⚡⚡ IPMItool loop stress test 🚧 ⚡⚡⚡ power-management: cpupower/sanity test 🚧 ⚡⚡⚡ Storage blktests 🚧 ⚡⚡⚡ Storage nvme - tcp Test sources: https://gitlab.com/cki-project/kernel-tests 💚 Pull requests are welcome for new tests or improvements to existing tests! Aborted tests ------------- Tests that didn't complete running successfully are marked with ⚡⚡⚡. If this was caused by an infrastructure issue, we try to mark that explicitly in the report. Waived tests ------------ If the test run included waived tests, they are marked with 🚧. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed. Testing timeout --------------- We aim to provide a report within reasonable timeframe. Tests that haven't finished running yet are marked with ⏱.

3 years, 9 months

1
0
0 0

✅ PASS: Test report for kernel 5.8.11 (stable-queue)

by CKI Project

Hello, We ran automated tests on a recent commit from this kernel tree: Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Commit: 8375d24eb6f6 - net/mlx5e: Fix endianness when calculating pedit mask first bit The results of these automated tests are provided below. Overall result: PASSED Merge: OK Compile: OK Tests: OK All kernel binaries, config files, and logs are available for download here: https://arr-cki-prod-datawarehouse-public.s3.amazonaws.com/index.html?prefi… Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Compile testing --------------- We compiled the kernel for 4 architectures: aarch64: make options: make -j30 INSTALL_MOD_STRIP=1 targz-pkg ppc64le: make options: make -j30 INSTALL_MOD_STRIP=1 targz-pkg s390x: make options: make -j30 INSTALL_MOD_STRIP=1 targz-pkg x86_64: make options: make -j30 INSTALL_MOD_STRIP=1 targz-pkg Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: Host 1: ✅ Boot test ✅ ACPI table test ✅ ACPI enabled test ✅ Podman system integration test - as root ✅ Podman system integration test - as user ✅ LTP ✅ Loopdev Sanity ✅ Memory: fork_mem ✅ Memory function: memfd_create ✅ AMTU (Abstract Machine Test Utility) ✅ Networking bridge: sanity ✅ Ethernet drivers sanity ✅ Networking socket: fuzz ✅ Networking: igmp conformance test ✅ Networking route: pmtu ✅ Networking route_func - local ✅ Networking route_func - forward ✅ Networking TCP: keepalive test ✅ Networking UDP: socket ✅ Networking tunnel: geneve basic test ✅ Networking tunnel: gre basic ✅ L2TP basic test ✅ Networking tunnel: vxlan basic ✅ Networking ipsec: basic netns - transport ✅ Networking ipsec: basic netns - tunnel ✅ Libkcapi AF_ALG test ✅ pciutils: update pci ids test ✅ ALSA PCM loopback test ✅ ALSA Control (mixer) Userspace Element test ✅ storage: SCSI VPD 🚧 ✅ CIFS Connectathon 🚧 ✅ POSIX pjd-fstest suites 🚧 ✅ Firmware test suite 🚧 ✅ jvm - jcstress tests 🚧 ✅ Memory function: kaslr 🚧 ✅ Networking firewall: basic netfilter test 🚧 ✅ audit: audit testsuite test 🚧 ✅ trace: ftrace/tracer 🚧 ✅ kdump - kexec_boot Host 2: ✅ Boot test ✅ xfstests - ext4 ✅ xfstests - xfs ✅ selinux-policy: serge-testsuite ✅ storage: software RAID testing ✅ stress: stress-ng 🚧 ✅ xfstests - btrfs 🚧 ❌ IPMI driver test 🚧 ✅ IPMItool loop stress test 🚧 ✅ Storage blktests 🚧 ✅ Storage nvme - tcp ppc64le: Host 1: ✅ Boot test ✅ Podman system integration test - as root ✅ Podman system integration test - as user ✅ LTP ✅ Loopdev Sanity ✅ Memory: fork_mem ✅ Memory function: memfd_create ✅ AMTU (Abstract Machine Test Utility) ✅ Networking bridge: sanity ✅ Ethernet drivers sanity ✅ Networking socket: fuzz ✅ Networking route: pmtu ✅ Networking route_func - local ✅ Networking route_func - forward ✅ Networking TCP: keepalive test ✅ Networking UDP: socket ✅ Networking tunnel: geneve basic test ✅ Networking tunnel: gre basic ✅ L2TP basic test ✅ Networking tunnel: vxlan basic ✅ Networking ipsec: basic netns - tunnel ✅ Libkcapi AF_ALG test ✅ pciutils: update pci ids test ✅ ALSA PCM loopback test ✅ ALSA Control (mixer) Userspace Element test 🚧 ✅ CIFS Connectathon 🚧 ✅ POSIX pjd-fstest suites 🚧 ✅ jvm - jcstress tests 🚧 ✅ Memory function: kaslr 🚧 ✅ Networking firewall: basic netfilter test 🚧 ✅ audit: audit testsuite test 🚧 ✅ trace: ftrace/tracer Host 2: ✅ Boot test 🚧 ✅ kdump - sysrq-c Host 3: ✅ Boot test ✅ xfstests - ext4 ✅ xfstests - xfs ✅ selinux-policy: serge-testsuite ✅ storage: software RAID testing 🚧 ✅ xfstests - btrfs 🚧 ✅ IPMI driver test 🚧 ✅ IPMItool loop stress test 🚧 ✅ Storage blktests 🚧 ✅ Storage nvme - tcp s390x: Host 1: ✅ Boot test ✅ Podman system integration test - as root ✅ Podman system integration test - as user ✅ LTP ✅ Loopdev Sanity ✅ Memory: fork_mem ✅ Memory function: memfd_create ✅ AMTU (Abstract Machine Test Utility) ✅ Networking bridge: sanity ✅ Ethernet drivers sanity ✅ Networking route: pmtu ✅ Networking route_func - local ✅ Networking route_func - forward ✅ Networking TCP: keepalive test ✅ Networking UDP: socket ✅ Networking tunnel: geneve basic test ✅ Networking tunnel: gre basic ✅ L2TP basic test ✅ Networking tunnel: vxlan basic ✅ Networking ipsec: basic netns - transport ✅ Networking ipsec: basic netns - tunnel ✅ Libkcapi AF_ALG test 🚧 ✅ CIFS Connectathon 🚧 ✅ POSIX pjd-fstest suites 🚧 ✅ jvm - jcstress tests 🚧 ✅ Memory function: kaslr 🚧 ✅ Networking firewall: basic netfilter test 🚧 ✅ audit: audit testsuite test 🚧 ✅ trace: ftrace/tracer Host 2: ✅ Boot test ✅ selinux-policy: serge-testsuite ✅ stress: stress-ng 🚧 ✅ Storage blktests 🚧 ❌ Storage nvme - tcp x86_64: Host 1: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ✅ Boot test ✅ xfstests - ext4 ✅ xfstests - xfs ✅ selinux-policy: serge-testsuite ✅ storage: software RAID testing ✅ stress: stress-ng 🚧 ✅ CPU: Frequency Driver Test 🚧 ✅ xfstests - btrfs 🚧 ⚡⚡⚡ IOMMU boot test 🚧 ⚡⚡⚡ IPMI driver test 🚧 ⚡⚡⚡ IPMItool loop stress test 🚧 ⚡⚡⚡ power-management: cpupower/sanity test 🚧 ⚡⚡⚡ Storage blktests 🚧 ⚡⚡⚡ Storage nvme - tcp Host 2: ✅ Boot test 🚧 ✅ kdump - sysrq-c 🚧 ✅ kdump - file-load Host 3: ✅ Boot test ✅ ACPI table test ✅ Podman system integration test - as root ✅ Podman system integration test - as user ✅ LTP ✅ Loopdev Sanity ✅ Memory: fork_mem ✅ Memory function: memfd_create ✅ AMTU (Abstract Machine Test Utility) ✅ Networking bridge: sanity ✅ Ethernet drivers sanity ✅ Networking socket: fuzz ✅ Networking: igmp conformance test ✅ Networking route: pmtu ✅ Networking route_func - local ✅ Networking route_func - forward ✅ Networking TCP: keepalive test ✅ Networking UDP: socket ✅ Networking tunnel: geneve basic test ✅ Networking tunnel: gre basic ✅ L2TP basic test ✅ Networking tunnel: vxlan basic ✅ Networking ipsec: basic netns - transport ✅ Networking ipsec: basic netns - tunnel ✅ Libkcapi AF_ALG test ✅ pciutils: sanity smoke test ✅ pciutils: update pci ids test ✅ ALSA PCM loopback test ✅ ALSA Control (mixer) Userspace Element test ✅ storage: SCSI VPD 🚧 ✅ CIFS Connectathon 🚧 ✅ POSIX pjd-fstest suites 🚧 ✅ Firmware test suite 🚧 ✅ jvm - jcstress tests 🚧 ✅ Memory function: kaslr 🚧 ✅ Networking firewall: basic netfilter test 🚧 ✅ audit: audit testsuite test 🚧 ✅ trace: ftrace/tracer 🚧 ✅ kdump - kexec_boot Test sources: https://gitlab.com/cki-project/kernel-tests 💚 Pull requests are welcome for new tests or improvements to existing tests! Aborted tests ------------- Tests that didn't complete running successfully are marked with ⚡⚡⚡. If this was caused by an infrastructure issue, we try to mark that explicitly in the report. Waived tests ------------ If the test run included waived tests, they are marked with 🚧. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed. Testing timeout --------------- We aim to provide a report within reasonable timeframe. Tests that haven't finished running yet are marked with ⏱.

3 years, 9 months

1
0
0 0

[PATCH] fs/affs: Fix basic permission bits to actually work

by Max Staudt

The basic permission bits (protection bits in AmigaOS) have been broken in Linux' affs - it would only set bits, but never delete them. Also, contrary to the documentation, the Archived bit was not handled. Let's fix this for good, and set the bits such that Linux and classic AmigaOS can coexist in the most peaceful manner. Also, update the documentation to represent the current state of things. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable(a)vger.kernel.org Signed-off-by: Max Staudt <max(a)enpas.org> --- Documentation/filesystems/affs.rst | 16 ++++++++++------ fs/affs/amigaffs.c | 27 +++++++++++++++++++++++++++ fs/affs/file.c | 27 ++++++++++++++++++++++++++- 3 files changed, 63 insertions(+), 7 deletions(-) diff --git a/Documentation/filesystems/affs.rst b/Documentation/filesystems/affs.rst index 7f1a40dce6d3..5776cbd5fa53 100644 --- a/Documentation/filesystems/affs.rst +++ b/Documentation/filesystems/affs.rst @@ -110,13 +110,15 @@ The Amiga protection flags RWEDRWEDHSPARWED are handled as follows: - R maps to r for user, group and others. On directories, R implies x. - - If both W and D are allowed, w will be set. + - W maps to w. - E maps to x. - - H and P are always retained and ignored under Linux. + - D is ignored. - - A is always reset when a file is written to. + - H, S and P are always retained and ignored under Linux. + + - A is cleared when a file is written to. User id and group id will be used unless set[gu]id are given as mount options. Since most of the Amiga file systems are single user systems @@ -128,11 +130,13 @@ Linux -> Amiga: The Linux rwxrwxrwx file mode is handled as follows: - - r permission will set R for user, group and others. + - r permission will allow R for user, group and others. + + - w permission will allow W for user, group and others. - - w permission will set W and D for user, group and others. + - x permission of the user will allow E for plain files. - - x permission of the user will set E for plain files. + - D will be allowed for user, group and others. - All other flags (suid, sgid, ...) are ignored and will not be retained. diff --git a/fs/affs/amigaffs.c b/fs/affs/amigaffs.c index f708c45d5f66..7952f885e6c6 100644 --- a/fs/affs/amigaffs.c +++ b/fs/affs/amigaffs.c @@ -420,24 +420,51 @@ affs_mode_to_prot(struct inode *inode) u32 prot = AFFS_I(inode)->i_protect; umode_t mode = inode->i_mode; + /* + * First, clear all RWED bits for owner, group, other. + * Then, recalculate them afresh. + * + * We'll always clear the delete-inhibit bit for the owner, + * as that is the classic single-user mode AmigaOS protection + * bit and we need to stay compatible with all scenarios. + * + * Since multi-user AmigaOS is an extension, we'll only set + * the delete-allow bit if any of the other bits in the same + * user class (group/other) are used. + */ + prot &= ~(FIBF_NOEXECUTE | FIBF_NOREAD + | FIBF_NOWRITE | FIBF_NODELETE + | FIBF_GRP_EXECUTE | FIBF_GRP_READ + | FIBF_GRP_WRITE | FIBF_GRP_DELETE + | FIBF_OTR_EXECUTE | FIBF_OTR_READ + | FIBF_OTR_WRITE | FIBF_OTR_DELETE); + + /* Classic single-user AmigaOS flags. These are inverted. */ if (!(mode & 0100)) prot |= FIBF_NOEXECUTE; if (!(mode & 0400)) prot |= FIBF_NOREAD; if (!(mode & 0200)) prot |= FIBF_NOWRITE; + + /* Multi-user extended flags. Not inverted. */ if (mode & 0010) prot |= FIBF_GRP_EXECUTE; if (mode & 0040) prot |= FIBF_GRP_READ; if (mode & 0020) prot |= FIBF_GRP_WRITE; + if (mode & 0070) + prot |= FIBF_GRP_DELETE; + if (mode & 0001) prot |= FIBF_OTR_EXECUTE; if (mode & 0004) prot |= FIBF_OTR_READ; if (mode & 0002) prot |= FIBF_OTR_WRITE; + if (mode & 0007) + prot |= FIBF_OTR_DELETE; AFFS_I(inode)->i_protect = prot; } diff --git a/fs/affs/file.c b/fs/affs/file.c index a26a0f96c119..9a137e2f1782 100644 --- a/fs/affs/file.c +++ b/fs/affs/file.c @@ -429,6 +429,25 @@ static int affs_write_begin(struct file *file, struct address_space *mapping, return ret; } +static int affs_write_end(struct file *file, struct address_space *mapping, + loff_t pos, unsigned int len, unsigned int copied, + struct page *page, void *fsdata) +{ + struct inode *inode = mapping->host; + int ret; + + ret = generic_write_end(file, mapping, pos, len, copied, + page, fsdata); + + /* Clear Archived bit on file writes, as AmigaOS would do */ + if (AFFS_I(inode)->i_protect & FIBF_ARCHIVED) { + AFFS_I(inode)->i_protect &= ~FIBF_ARCHIVED; + mark_inode_dirty(inode); + } + + return ret; +} + static sector_t _affs_bmap(struct address_space *mapping, sector_t block) { return generic_block_bmap(mapping,block,affs_get_block); @@ -438,7 +457,7 @@ const struct address_space_operations affs_aops = { .readpage = affs_readpage, .writepage = affs_writepage, .write_begin = affs_write_begin, - .write_end = generic_write_end, + .write_end = affs_write_end, .direct_IO = affs_direct_IO, .bmap = _affs_bmap }; @@ -795,6 +814,12 @@ static int affs_write_end_ofs(struct file *file, struct address_space *mapping, if (tmp > inode->i_size) inode->i_size = AFFS_I(inode)->mmu_private = tmp; + /* Clear Archived bit on file writes, as AmigaOS would do */ + if (AFFS_I(inode)->i_protect & FIBF_ARCHIVED) { + AFFS_I(inode)->i_protect &= ~FIBF_ARCHIVED; + mark_inode_dirty(inode); + } + err_first_bh: unlock_page(page); put_page(page); -- 2.20.1

3 years, 9 months

3
4
0 0

[PATCH v8 4/7] tcp: use sendpage_ok() to detect misused .sendpage

by Coly Li

commit a10674bf2406 ("tcp: detecting the misuse of .sendpage for Slab objects") adds the checks for Slab pages, but the pages don't have page_count are still missing from the check. Network layer's sendpage method is not designed to send page_count 0 pages neither, therefore both PageSlab() and page_count() should be both checked for the sending page. This is exactly what sendpage_ok() does. This patch uses sendpage_ok() in do_tcp_sendpages() to detect misused .sendpage, to make the code more robust. Fixes: a10674bf2406 ("tcp: detecting the misuse of .sendpage for Slab objects") Suggested-by: Eric Dumazet <eric.dumazet(a)gmail.com> Signed-off-by: Coly Li <colyli(a)suse.de> Cc: Vasily Averin <vvs(a)virtuozzo.com> Cc: David S. Miller <davem(a)davemloft.net> Cc: stable(a)vger.kernel.org --- net/ipv4/tcp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index 31f3b858db81..2135ee7c806d 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -970,7 +970,8 @@ ssize_t do_tcp_sendpages(struct sock *sk, struct page *page, int offset, long timeo = sock_sndtimeo(sk, flags & MSG_DONTWAIT); if (IS_ENABLED(CONFIG_DEBUG_VM) && - WARN_ONCE(PageSlab(page), "page must not be a Slab one")) + WARN_ONCE(!sendpage_ok(page), + "page must not be a Slab one and have page_count > 0")) return -EINVAL; /* Wait for a connection to finish. One exception is TCP Fast Open -- 2.26.2

3 years, 9 months

1
0
0 0

[PATCH v8 3/7] nvme-tcp: check page by sendpage_ok() before calling kernel_sendpage()

by Coly Li

Currently nvme_tcp_try_send_data() doesn't use kernel_sendpage() to send slab pages. But for pages allocated by __get_free_pages() without __GFP_COMP, which also have refcount as 0, they are still sent by kernel_sendpage() to remote end, this is problematic. The new introduced helper sendpage_ok() checks both PageSlab tag and page_count counter, and returns true if the checking page is OK to be sent by kernel_sendpage(). This patch fixes the page checking issue of nvme_tcp_try_send_data() with sendpage_ok(). If sendpage_ok() returns true, send this page by kernel_sendpage(), otherwise use sock_no_sendpage to handle this page. Signed-off-by: Coly Li <colyli(a)suse.de> Cc: Chaitanya Kulkarni <chaitanya.kulkarni(a)wdc.com> Cc: Christoph Hellwig <hch(a)lst.de> Cc: Hannes Reinecke <hare(a)suse.de> Cc: Jan Kara <jack(a)suse.com> Cc: Jens Axboe <axboe(a)kernel.dk> Cc: Mikhail Skorzhinskii <mskorzhinskiy(a)solarflare.com> Cc: Philipp Reisner <philipp.reisner(a)linbit.com> Cc: Sagi Grimberg <sagi(a)grimberg.me> Cc: Vlastimil Babka <vbabka(a)suse.com> Cc: stable(a)vger.kernel.org --- drivers/nvme/host/tcp.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c index 8f4f29f18b8c..d6a3e1487354 100644 --- a/drivers/nvme/host/tcp.c +++ b/drivers/nvme/host/tcp.c @@ -913,12 +913,11 @@ static int nvme_tcp_try_send_data(struct nvme_tcp_request *req) else flags |= MSG_MORE | MSG_SENDPAGE_NOTLAST; - /* can't zcopy slab pages */ - if (unlikely(PageSlab(page))) { - ret = sock_no_sendpage(queue->sock, page, offset, len, + if (sendpage_ok(page)) { + ret = kernel_sendpage(queue->sock, page, offset, len, flags); } else { - ret = kernel_sendpage(queue->sock, page, offset, len, + ret = sock_no_sendpage(queue->sock, page, offset, len, flags); } if (ret <= 0) -- 2.26.2

3 years, 9 months

1
0
0 0

[PATCH v2] USB: cdc-acm: add Whistler radio scanners TRX series support

by Johan Hovold

Add support for Whistler radio scanners TRX series, which have a union descriptor that designates a mass-storage interface as master. Handle that by generalising the NO_DATA_INTERFACE quirk to allow us to fall back to using the combined-interface detection. Note that the NO_DATA_INTERFACE quirk was added by commit fd5054c169d2 ("USB: cdc_acm: Fix oops when Droids MuIn LCD is connected") to handle a combined-interface-type device with a broken call-management descriptor by hardcoding the "data" interface number. Link: https://lore.kernel.org/r/5f4ca4f8.1c69fb81.a4487.0f5f@mx.google.com Reported-by: Daniel Caujolle-Bert <f1rmb.daniel(a)gmail.com> Tested-by: Daniel Caujolle-Bert <f1rmb.daniel(a)gmail.com> Cc: stable(a)vger.kernel.org Signed-off-by: Johan Hovold <johan(a)kernel.org> --- v2 - use the right class define in the device-id table (not subclass with same value) drivers/usb/class/cdc-acm.c | 36 ++++++++++++++++++++++++------------ 1 file changed, 24 insertions(+), 12 deletions(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index 7f6f3ab5b8a6..316203bab0b8 100644 --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c @@ -1220,27 +1220,26 @@ static int acm_probe(struct usb_interface *intf, if (cmgmd) call_intf_num = cmgmd->bDataInterface; - if (!union_header) { - if (call_intf_num > 0) { + combined_interfaces = (quirks & NO_DATA_INTERFACE) != 0; + + if (!union_header || combined_interfaces) { + if (call_intf_num > 0 && !combined_interfaces) { dev_dbg(&intf->dev, "No union descriptor, using call management descriptor\n"); - /* quirks for Droids MuIn LCD */ - if (quirks & NO_DATA_INTERFACE) { - data_interface = usb_ifnum_to_if(usb_dev, 0); - } else { - data_intf_num = call_intf_num; - data_interface = usb_ifnum_to_if(usb_dev, data_intf_num); - } + data_intf_num = call_intf_num; + data_interface = usb_ifnum_to_if(usb_dev, data_intf_num); control_interface = intf; } else { if (intf->cur_altsetting->desc.bNumEndpoints != 3) { dev_dbg(&intf->dev,"No union descriptor, giving up\n"); return -ENODEV; - } else { + } + + if (!combined_interfaces) { dev_warn(&intf->dev,"No union descriptor, testing for castrated device\n"); combined_interfaces = 1; - control_interface = data_interface = intf; - goto look_for_collapsed_interface; } + control_interface = data_interface = intf; + goto look_for_collapsed_interface; } } else { data_intf_num = union_header->bSlaveInterface0; @@ -1807,6 +1806,19 @@ static const struct usb_device_id acm_ids[] = { .driver_info = CLEAR_HALT_CONDITIONS, }, + { USB_DEVICE_INTERFACE_CLASS(0x2a59, 0x0010, USB_CLASS_COMM), /* Whistler TRX-1 */ + .driver_info = NO_DATA_INTERFACE, + }, + { USB_DEVICE_INTERFACE_CLASS(0x2a59, 0x0011, USB_CLASS_COMM), /* Whistler TRX-2 */ + .driver_info = NO_DATA_INTERFACE, + }, + { USB_DEVICE_INTERFACE_CLASS(0x2a59, 0x0012, USB_CLASS_COMM), /* Whistler TRX-1e */ + .driver_info = NO_DATA_INTERFACE, + }, + { USB_DEVICE_INTERFACE_CLASS(0x2a59, 0x0013, USB_CLASS_COMM), /* Whistler TRX-2e */ + .driver_info = NO_DATA_INTERFACE, + }, + /* Nokia S60 phones expose two ACM channels. The first is * a modem and is picked up by the standard AT-command * information below. The second is 'vendor-specific' but -- 2.26.2

3 years, 9 months

3
11
0 0

patch "usbcore/driver: Accommodate usbip" added to usb-linus

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled usbcore/driver: Accommodate usbip to my usb git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git in the usb-linus branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will hopefully also be merged in Linus's tree for the next -rc kernel release. If you have any questions about this process, please let me know. >From 3fce39601a1a34d940cf62858ee01ed9dac5d459 Mon Sep 17 00:00:00 2001 From: "M. Vefa Bicakci" <m.v.b(a)runbox.com> Date: Tue, 22 Sep 2020 14:07:03 +0300 Subject: usbcore/driver: Accommodate usbip Commit 88b7381a939d ("USB: Select better matching USB drivers when available") inadvertently broke usbip functionality. The commit in question allows USB device drivers to be explicitly matched with USB devices via the use of driver-provided identifier tables and match functions, which is useful for a specialised device driver to be chosen for a device that can also be handled by another, more generic, device driver. Prior, the USB device section of usb_device_match() had an unconditional "return 1" statement, which allowed user-space to bind USB devices to the usbip_host device driver, if desired. However, the aforementioned commit changed the default/fallback return value to zero. This breaks device drivers such as usbip_host, so this commit restores the legacy behaviour, but only if a device driver does not have an id_table and a match() function. In addition, if usb_device_match is called for a device driver and device pair where the device does not match the id_table of the device driver in question, then the device driver will be disqualified for the device. This allows avoiding the default case of "return 1", which prevents undesirable probe() calls to a driver even though its id_table did not match the device. Finally, this commit changes the specialised-driver-to-generic-driver transition code so that when a device driver returns -ENODEV, a more generic device driver is only considered if the current device driver does not have an id_table and a match() function. This ensures that "generic" drivers such as usbip_host will not be considered specialised device drivers and will not cause the device to be locked in to the generic device driver, when a more specialised device driver could be tried. All of these changes restore usbip functionality without regressions, ensure that the specialised/generic device driver selection logic works as expected with the usb and apple-mfi-fastcharge drivers, and do not negatively affect the use of devices provided by dummy_hcd. Fixes: 88b7381a939d ("USB: Select better matching USB drivers when available") Cc: <stable(a)vger.kernel.org> # 5.8 Cc: Bastien Nocera <hadess(a)hadess.net> Cc: Valentina Manea <valentina.manea.m(a)gmail.com> Cc: Shuah Khan <shuah(a)kernel.org> Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Cc: Alan Stern <stern(a)rowland.harvard.edu> Cc: <syzkaller(a)googlegroups.com> Tested-by: Andrey Konovalov <andreyknvl(a)google.com> Acked-by: Shuah Khan <skhan(a)linuxfoundation.org> Signed-off-by: M. Vefa Bicakci <m.v.b(a)runbox.com> Link: https://lore.kernel.org/r/20200922110703.720960-5-m.v.b@runbox.com Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/usb/core/driver.c | 37 +++++++++++++++++++++++++++++++------ 1 file changed, 31 insertions(+), 6 deletions(-) diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c index b00b7fb1aad1..b351962279e4 100644 --- a/drivers/usb/core/driver.c +++ b/drivers/usb/core/driver.c @@ -269,8 +269,30 @@ static int usb_probe_device(struct device *dev) if (error) return error; + /* Probe the USB device with the driver in hand, but only + * defer to a generic driver in case the current USB + * device driver has an id_table or a match function; i.e., + * when the device driver was explicitly matched against + * a device. + * + * If the device driver does not have either of these, + * then we assume that it can bind to any device and is + * not truly a more specialized/non-generic driver, so a + * return value of -ENODEV should not force the device + * to be handled by the generic USB driver, as there + * can still be another, more specialized, device driver. + * + * This accommodates the usbip driver. + * + * TODO: What if, in the future, there are multiple + * specialized USB device drivers for a particular device? + * In such cases, there is a need to try all matching + * specialised device drivers prior to setting the + * use_generic_driver bit. + */ error = udriver->probe(udev); - if (error == -ENODEV && udriver != &usb_generic_driver) { + if (error == -ENODEV && udriver != &usb_generic_driver && + (udriver->id_table || udriver->match)) { udev->use_generic_driver = 1; return -EPROBE_DEFER; } @@ -831,14 +853,17 @@ static int usb_device_match(struct device *dev, struct device_driver *drv) udev = to_usb_device(dev); udrv = to_usb_device_driver(drv); - if (udrv->id_table && - usb_device_match_id(udev, udrv->id_table) != NULL) { - return 1; - } + if (udrv->id_table) + return usb_device_match_id(udev, udrv->id_table) != NULL; if (udrv->match) return udrv->match(udev); - return 0; + + /* If the device driver under consideration does not have a + * id_table or a match function, then let the driver's probe + * function decide. + */ + return 1; } else if (is_usb_interface(dev)) { struct usb_interface *intf; -- 2.28.0

3 years, 9 months

1
0
0 0

patch "usbcore/driver: Fix incorrect downcast" added to usb-linus

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled usbcore/driver: Fix incorrect downcast to my usb git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git in the usb-linus branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will hopefully also be merged in Linus's tree for the next -rc kernel release. If you have any questions about this process, please let me know. >From 4df30e7603432704380b12fe40a604ee7f66746d Mon Sep 17 00:00:00 2001 From: "M. Vefa Bicakci" <m.v.b(a)runbox.com> Date: Tue, 22 Sep 2020 14:07:02 +0300 Subject: usbcore/driver: Fix incorrect downcast This commit resolves a minor bug in the selection/discovery of more specific USB device drivers for devices that are currently bound to generic USB device drivers. The bug is related to the way a candidate USB device driver is compared against the generic USB device driver. The code in is_dev_usb_generic_driver() assumes that the device driver in question is a USB device driver by calling to_usb_device_driver(dev->driver) to downcast; however I have observed that this assumption is not always true, through code instrumentation. This commit avoids the incorrect downcast altogether by comparing the USB device's driver (i.e., dev->driver) to the generic USB device driver directly. This method was suggested by Alan Stern. This bug was found while investigating Andrey Konovalov's report indicating usbip device driver misbehaviour with the recently merged generic USB device driver selection feature. The report is linked below. Fixes: d5643d2249b2 ("USB: Fix device driver race") Cc: <stable(a)vger.kernel.org> # 5.8 Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Cc: Alan Stern <stern(a)rowland.harvard.edu> Cc: Bastien Nocera <hadess(a)hadess.net> Cc: Shuah Khan <shuah(a)kernel.org> Cc: Valentina Manea <valentina.manea.m(a)gmail.com> Cc: <syzkaller(a)googlegroups.com> Tested-by: Andrey Konovalov <andreyknvl(a)google.com> Signed-off-by: M. Vefa Bicakci <m.v.b(a)runbox.com> Link: https://lore.kernel.org/r/20200922110703.720960-4-m.v.b@runbox.com Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/usb/core/driver.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c index 715782995428..b00b7fb1aad1 100644 --- a/drivers/usb/core/driver.c +++ b/drivers/usb/core/driver.c @@ -905,21 +905,14 @@ static int usb_uevent(struct device *dev, struct kobj_uevent_env *env) return 0; } -static bool is_dev_usb_generic_driver(struct device *dev) -{ - struct usb_device_driver *udd = dev->driver ? - to_usb_device_driver(dev->driver) : NULL; - - return udd == &usb_generic_driver; -} - static int __usb_bus_reprobe_drivers(struct device *dev, void *data) { struct usb_device_driver *new_udriver = data; struct usb_device *udev; int ret; - if (!is_dev_usb_generic_driver(dev)) + /* Don't reprobe if current driver isn't usb_generic_driver */ + if (dev->driver != &usb_generic_driver.drvwrap.driver) return 0; udev = to_usb_device(dev); -- 2.28.0

3 years, 9 months

1
0
0 0

patch "usbcore/driver: Fix specific driver selection" added to usb-linus

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled usbcore/driver: Fix specific driver selection to my usb git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git in the usb-linus branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will hopefully also be merged in Linus's tree for the next -rc kernel release. If you have any questions about this process, please let me know. >From aea850cd35ae3d266fe6f93fb9edb25e4a555230 Mon Sep 17 00:00:00 2001 From: "M. Vefa Bicakci" <m.v.b(a)runbox.com> Date: Tue, 22 Sep 2020 14:07:01 +0300 Subject: usbcore/driver: Fix specific driver selection This commit resolves a bug in the selection/discovery of more specific USB device drivers for devices that are currently bound to generic USB device drivers. The bug is in the logic that determines whether a device currently bound to a generic USB device driver should be re-probed by a more specific USB device driver or not. The code in __usb_bus_reprobe_drivers() used to have the following lines: if (usb_device_match_id(udev, new_udriver->id_table) == NULL && (!new_udriver->match || new_udriver->match(udev) != 0)) return 0; ret = device_reprobe(dev); As the reader will notice, the code checks whether the USB device in consideration matches the identifier table (id_table) of a specific USB device_driver (new_udriver), followed by a similar check, but this time with the USB device driver's match function. However, the match function's return value is not checked correctly. When match() returns zero, it means that the specific USB device driver is *not* applicable to the USB device in question, but the code then goes on to reprobe the device with the new USB device driver under consideration. All this to say, the logic is inverted. This bug was found by code inspection and instrumentation while investigating the root cause of the issue reported by Andrey Konovalov, where usbip took over syzkaller's virtual USB devices in an undesired manner. The report is linked below. Fixes: d5643d2249b2 ("USB: Fix device driver race") Cc: <stable(a)vger.kernel.org> # 5.8 Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Cc: Alan Stern <stern(a)rowland.harvard.edu> Cc: Bastien Nocera <hadess(a)hadess.net> Cc: Shuah Khan <shuah(a)kernel.org> Cc: Valentina Manea <valentina.manea.m(a)gmail.com> Cc: <syzkaller(a)googlegroups.com> Tested-by: Andrey Konovalov <andreyknvl(a)google.com> Signed-off-by: M. Vefa Bicakci <m.v.b(a)runbox.com> Link: https://lore.kernel.org/r/20200922110703.720960-3-m.v.b@runbox.com Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/usb/core/driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c index 7e73e989645b..715782995428 100644 --- a/drivers/usb/core/driver.c +++ b/drivers/usb/core/driver.c @@ -924,7 +924,7 @@ static int __usb_bus_reprobe_drivers(struct device *dev, void *data) udev = to_usb_device(dev); if (usb_device_match_id(udev, new_udriver->id_table) == NULL && - (!new_udriver->match || new_udriver->match(udev) != 0)) + (!new_udriver->match || new_udriver->match(udev) == 0)) return 0; ret = device_reprobe(dev); -- 2.28.0

3 years, 9 months

1
0
0 0

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror September 2020