May 2021 - Linux-stable-mirror

[PATCH for-stable-5.4] KVM: arm64: Initialize VCPU mdcr_el2 before loading it

by Alexandru Elisei

[ Upstream commit 263d6287da1433aba11c5b4046388f2cdf49675c ] When a VCPU is created, the kvm_vcpu struct is initialized to zero in kvm_vm_ioctl_create_vcpu(). On VHE systems, the first time vcpu.arch.mdcr_el2 is loaded on hardware is in vcpu_load(), before it is set to a sensible value in kvm_arm_setup_debug() later in the run loop. The result is that KVM executes for a short time with MDCR_EL2 set to zero. This has several unintended consequences: * Setting MDCR_EL2.HPMN to 0 is constrained unpredictable according to ARM DDI 0487G.a, page D13-3820. The behavior specified by the architecture in this case is for the PE to behave as if MDCR_EL2.HPMN is set to a value less than or equal to PMCR_EL0.N, which means that an unknown number of counters are now disabled by MDCR_EL2.HPME, which is zero. * The host configuration for the other debug features controlled by MDCR_EL2 is temporarily lost. This has been harmless so far, as Linux doesn't use the other fields, but that might change in the future. Let's avoid both issues by initializing the VCPU's mdcr_el2 field in kvm_vcpu_vcpu_first_run_init(), thus making sure that the MDCR_EL2 register has a consistent value after each vcpu_load(). [ v5.4 backport: added stub for KVM/arm that fixes compilation errors ] Fixes: d5a21bcc2995 ("KVM: arm64: Move common VHE/non-VHE trap config in separate functions") Signed-off-by: Alexandru Elisei <alexandru.elisei(a)arm.com> Signed-off-by: Marc Zyngier <maz(a)kernel.org> Link: https://lore.kernel.org/r/20210407144857.199746-3-alexandru.elisei@arm.com --- arch/arm/include/asm/kvm_host.h | 1 + arch/arm64/include/asm/kvm_host.h | 1 + arch/arm64/kvm/debug.c | 88 +++++++++++++++++++++---------- virt/kvm/arm/arm.c | 2 + 4 files changed, 64 insertions(+), 28 deletions(-) diff --git a/arch/arm/include/asm/kvm_host.h b/arch/arm/include/asm/kvm_host.h index dd03d5e01a94..32564b017ba0 100644 --- a/arch/arm/include/asm/kvm_host.h +++ b/arch/arm/include/asm/kvm_host.h @@ -335,6 +335,7 @@ static inline void kvm_arch_sched_in(struct kvm_vcpu *vcpu, int cpu) {} static inline void kvm_arch_vcpu_block_finish(struct kvm_vcpu *vcpu) {} static inline void kvm_arm_init_debug(void) {} +static inline void kvm_arm_vcpu_init_debug(struct kvm_vcpu *vcpu) {} static inline void kvm_arm_setup_debug(struct kvm_vcpu *vcpu) {} static inline void kvm_arm_clear_debug(struct kvm_vcpu *vcpu) {} static inline void kvm_arm_reset_debug_ptr(struct kvm_vcpu *vcpu) {} diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h index dfa6dc4575be..697702a1a1ff 100644 --- a/arch/arm64/include/asm/kvm_host.h +++ b/arch/arm64/include/asm/kvm_host.h @@ -552,6 +552,7 @@ static inline void kvm_arch_sched_in(struct kvm_vcpu *vcpu, int cpu) {} static inline void kvm_arch_vcpu_block_finish(struct kvm_vcpu *vcpu) {} void kvm_arm_init_debug(void); +void kvm_arm_vcpu_init_debug(struct kvm_vcpu *vcpu); void kvm_arm_setup_debug(struct kvm_vcpu *vcpu); void kvm_arm_clear_debug(struct kvm_vcpu *vcpu); void kvm_arm_reset_debug_ptr(struct kvm_vcpu *vcpu); diff --git a/arch/arm64/kvm/debug.c b/arch/arm64/kvm/debug.c index dbc890511631..2484b2cca74b 100644 --- a/arch/arm64/kvm/debug.c +++ b/arch/arm64/kvm/debug.c @@ -68,6 +68,64 @@ void kvm_arm_init_debug(void) __this_cpu_write(mdcr_el2, kvm_call_hyp_ret(__kvm_get_mdcr_el2)); } +/** + * kvm_arm_setup_mdcr_el2 - configure vcpu mdcr_el2 value + * + * @vcpu: the vcpu pointer + * + * This ensures we will trap access to: + * - Performance monitors (MDCR_EL2_TPM/MDCR_EL2_TPMCR) + * - Debug ROM Address (MDCR_EL2_TDRA) + * - OS related registers (MDCR_EL2_TDOSA) + * - Statistical profiler (MDCR_EL2_TPMS/MDCR_EL2_E2PB) + * - Self-hosted Trace Filter controls (MDCR_EL2_TTRF) + */ +static void kvm_arm_setup_mdcr_el2(struct kvm_vcpu *vcpu) +{ + /* + * This also clears MDCR_EL2_E2PB_MASK to disable guest access + * to the profiling buffer. + */ + vcpu->arch.mdcr_el2 = __this_cpu_read(mdcr_el2) & MDCR_EL2_HPMN_MASK; + vcpu->arch.mdcr_el2 |= (MDCR_EL2_TPM | + MDCR_EL2_TPMS | + MDCR_EL2_TTRF | + MDCR_EL2_TPMCR | + MDCR_EL2_TDRA | + MDCR_EL2_TDOSA); + + /* Is the VM being debugged by userspace? */ + if (vcpu->guest_debug) + /* Route all software debug exceptions to EL2 */ + vcpu->arch.mdcr_el2 |= MDCR_EL2_TDE; + + /* + * Trap debug register access when one of the following is true: + * - Userspace is using the hardware to debug the guest + * (KVM_GUESTDBG_USE_HW is set). + * - The guest is not using debug (KVM_ARM64_DEBUG_DIRTY is clear). + */ + if ((vcpu->guest_debug & KVM_GUESTDBG_USE_HW) || + !(vcpu->arch.flags & KVM_ARM64_DEBUG_DIRTY)) + vcpu->arch.mdcr_el2 |= MDCR_EL2_TDA; + + trace_kvm_arm_set_dreg32("MDCR_EL2", vcpu->arch.mdcr_el2); +} + +/** + * kvm_arm_vcpu_init_debug - setup vcpu debug traps + * + * @vcpu: the vcpu pointer + * + * Set vcpu initial mdcr_el2 value. + */ +void kvm_arm_vcpu_init_debug(struct kvm_vcpu *vcpu) +{ + preempt_disable(); + kvm_arm_setup_mdcr_el2(vcpu); + preempt_enable(); +} + /** * kvm_arm_reset_debug_ptr - reset the debug ptr to point to the vcpu state */ @@ -83,13 +141,7 @@ void kvm_arm_reset_debug_ptr(struct kvm_vcpu *vcpu) * @vcpu: the vcpu pointer * * This is called before each entry into the hypervisor to setup any - * debug related registers. Currently this just ensures we will trap - * access to: - * - Performance monitors (MDCR_EL2_TPM/MDCR_EL2_TPMCR) - * - Debug ROM Address (MDCR_EL2_TDRA) - * - OS related registers (MDCR_EL2_TDOSA) - * - Statistical profiler (MDCR_EL2_TPMS/MDCR_EL2_E2PB) - * - Self-hosted Trace Filter controls (MDCR_EL2_TTRF) + * debug related registers. * * Additionally, KVM only traps guest accesses to the debug registers if * the guest is not actively using them (see the KVM_ARM64_DEBUG_DIRTY @@ -101,28 +153,14 @@ void kvm_arm_reset_debug_ptr(struct kvm_vcpu *vcpu) void kvm_arm_setup_debug(struct kvm_vcpu *vcpu) { - bool trap_debug = !(vcpu->arch.flags & KVM_ARM64_DEBUG_DIRTY); unsigned long mdscr, orig_mdcr_el2 = vcpu->arch.mdcr_el2; trace_kvm_arm_setup_debug(vcpu, vcpu->guest_debug); - /* - * This also clears MDCR_EL2_E2PB_MASK to disable guest access - * to the profiling buffer. - */ - vcpu->arch.mdcr_el2 = __this_cpu_read(mdcr_el2) & MDCR_EL2_HPMN_MASK; - vcpu->arch.mdcr_el2 |= (MDCR_EL2_TPM | - MDCR_EL2_TPMS | - MDCR_EL2_TTRF | - MDCR_EL2_TPMCR | - MDCR_EL2_TDRA | - MDCR_EL2_TDOSA); + kvm_arm_setup_mdcr_el2(vcpu); /* Is Guest debugging in effect? */ if (vcpu->guest_debug) { - /* Route all software debug exceptions to EL2 */ - vcpu->arch.mdcr_el2 |= MDCR_EL2_TDE; - /* Save guest debug state */ save_guest_debug_regs(vcpu); @@ -176,7 +214,6 @@ void kvm_arm_setup_debug(struct kvm_vcpu *vcpu) vcpu->arch.debug_ptr = &vcpu->arch.external_debug_state; vcpu->arch.flags |= KVM_ARM64_DEBUG_DIRTY; - trap_debug = true; trace_kvm_arm_set_regset("BKPTS", get_num_brps(), &vcpu->arch.debug_ptr->dbg_bcr[0], @@ -191,10 +228,6 @@ void kvm_arm_setup_debug(struct kvm_vcpu *vcpu) BUG_ON(!vcpu->guest_debug && vcpu->arch.debug_ptr != &vcpu->arch.vcpu_debug_state); - /* Trap debug register access */ - if (trap_debug) - vcpu->arch.mdcr_el2 |= MDCR_EL2_TDA; - /* If KDE or MDE are set, perform a full save/restore cycle. */ if (vcpu_read_sys_reg(vcpu, MDSCR_EL1) & (DBG_MDSCR_KDE | DBG_MDSCR_MDE)) vcpu->arch.flags |= KVM_ARM64_DEBUG_DIRTY; @@ -203,7 +236,6 @@ void kvm_arm_setup_debug(struct kvm_vcpu *vcpu) if (has_vhe() && orig_mdcr_el2 != vcpu->arch.mdcr_el2) write_sysreg(vcpu->arch.mdcr_el2, mdcr_el2); - trace_kvm_arm_set_dreg32("MDCR_EL2", vcpu->arch.mdcr_el2); trace_kvm_arm_set_dreg32("MDSCR_EL1", vcpu_read_sys_reg(vcpu, MDSCR_EL1)); } diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c index 2e7d2b3f2907..4af85605730e 100644 --- a/virt/kvm/arm/arm.c +++ b/virt/kvm/arm/arm.c @@ -579,6 +579,8 @@ static int kvm_vcpu_first_run_init(struct kvm_vcpu *vcpu) vcpu->arch.has_run_once = true; + kvm_arm_vcpu_init_debug(vcpu); + if (likely(irqchip_in_kernel(kvm))) { /* * Map the VGIC hardware resources before running a vcpu the -- 2.31.1

3 years, 5 months

2
1
0 0

[PATCH 4.19] iomap: fix sub-page uptodate handling

by Matthew Wilcox (Oracle)

From: Christoph Hellwig <hch(a)lst.de> commit 1cea335d1db1ce6ab71b3d2f94a807112b738a0f upstream bio completions can race when a page spans more than one file system block. Add a spinlock to synchronize marking the page uptodate. Fixes: 9dc55f1389f9 ("iomap: add support for sub-pagesize buffered I/O without buffer heads") Reported-by: Jan Stancek <jstancek(a)redhat.com> Signed-off-by: Christoph Hellwig <hch(a)lst.de> Reviewed-by: Dave Chinner <dchinner(a)redhat.com> Reviewed-by: Darrick J. Wong <darrick.wong(a)oracle.com> Signed-off-by: Darrick J. Wong <darrick.wong(a)oracle.com> Signed-off-by: Matthew Wilcox (Oracle) <willy(a)infradead.org> --- fs/iomap.c | 34 ++++++++++++++++++++++++---------- include/linux/iomap.h | 1 + 2 files changed, 25 insertions(+), 10 deletions(-) diff --git a/fs/iomap.c b/fs/iomap.c index 03edf62633dc..ac7b2152c3ad 100644 --- a/fs/iomap.c +++ b/fs/iomap.c @@ -116,6 +116,7 @@ iomap_page_create(struct inode *inode, struct page *page) iop = kmalloc(sizeof(*iop), GFP_NOFS | __GFP_NOFAIL); atomic_set(&iop->read_count, 0); atomic_set(&iop->write_count, 0); + spin_lock_init(&iop->uptodate_lock); bitmap_zero(iop->uptodate, PAGE_SIZE / SECTOR_SIZE); /* @@ -204,25 +205,38 @@ iomap_adjust_read_range(struct inode *inode, struct iomap_page *iop, } static void -iomap_set_range_uptodate(struct page *page, unsigned off, unsigned len) +iomap_iop_set_range_uptodate(struct page *page, unsigned off, unsigned len) { struct iomap_page *iop = to_iomap_page(page); struct inode *inode = page->mapping->host; unsigned first = off >> inode->i_blkbits; unsigned last = (off + len - 1) >> inode->i_blkbits; - unsigned int i; bool uptodate = true; + unsigned long flags; + unsigned int i; - if (iop) { - for (i = 0; i < PAGE_SIZE / i_blocksize(inode); i++) { - if (i >= first && i <= last) - set_bit(i, iop->uptodate); - else if (!test_bit(i, iop->uptodate)) - uptodate = false; - } + spin_lock_irqsave(&iop->uptodate_lock, flags); + for (i = 0; i < PAGE_SIZE / i_blocksize(inode); i++) { + if (i >= first && i <= last) + set_bit(i, iop->uptodate); + else if (!test_bit(i, iop->uptodate)) + uptodate = false; } - if (uptodate && !PageError(page)) + if (uptodate) + SetPageUptodate(page); + spin_unlock_irqrestore(&iop->uptodate_lock, flags); +} + +static void +iomap_set_range_uptodate(struct page *page, unsigned off, unsigned len) +{ + if (PageError(page)) + return; + + if (page_has_private(page)) + iomap_iop_set_range_uptodate(page, off, len); + else SetPageUptodate(page); } diff --git a/include/linux/iomap.h b/include/linux/iomap.h index 3555d54bf79a..e93ecacb5eaf 100644 --- a/include/linux/iomap.h +++ b/include/linux/iomap.h @@ -108,6 +108,7 @@ struct iomap_ops { struct iomap_page { atomic_t read_count; atomic_t write_count; + spinlock_t uptodate_lock; DECLARE_BITMAP(uptodate, PAGE_SIZE / 512); }; -- 2.30.2

3 years, 5 months

2
1
0 0

[PATCH for 4.4, 4,9] iio: tsl2583: Fix division by a zero lux_val

by Nobuhiro Iwamatsu

From: Colin Ian King <colin.king(a)canonical.com> commit af0e1871d79cfbb91f732d2c6fa7558e45c31038 upstream. The lux_val returned from tsl2583_get_lux can potentially be zero, so check for this to avoid a division by zero and an overflowed gain_trim_val. Fixes clang scan-build warning: drivers/iio/light/tsl2583.c:345:40: warning: Either the condition 'lux_val<0' is redundant or there is division by zero at line 345. [zerodivcond] Fixes: ac4f6eee8fe8 ("staging: iio: TAOS tsl258x: Device driver") Signed-off-by: Colin Ian King <colin.king(a)canonical.com> Cc: <Stable(a)vger.kernel.org> Signed-off-by: Jonathan Cameron <Jonathan.Cameron(a)huawei.com> [iwamatsu: Change file path.] Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu(a)toshiba.co.jp> --- drivers/staging/iio/light/tsl2583.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c index 3100d960fe2c6d..da2a2ff4cdb998 100644 --- a/drivers/staging/iio/light/tsl2583.c +++ b/drivers/staging/iio/light/tsl2583.c @@ -378,6 +378,15 @@ static int taos_als_calibrate(struct iio_dev *indio_dev) dev_err(&chip->client->dev, "taos_als_calibrate failed to get lux\n"); return lux_val; } + + /* Avoid division by zero of lux_value later on */ + if (lux_val == 0) { + dev_err(&chip->client->dev, + "%s: lux_val of 0 will produce out of range trim_value\n", + __func__); + return -ENODATA; + } + gain_trim_val = (unsigned int) (((chip->taos_settings.als_cal_target) * chip->taos_settings.als_gain_trim) / lux_val); -- 2.30.0

3 years, 5 months

2
1
0 0

[PATCH for 4.4, 4.9 and 4.14] xhci: Do not use GFP_KERNEL in (potentially) atomic context

by Nobuhiro Iwamatsu

From: Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> commit dda32c00c9a0fa103b5d54ef72c477b7aa993679 upstream. 'xhci_urb_enqueue()' is passed a 'mem_flags' argument, because "URBs may be submitted in interrupt context" (see comment related to 'usb_submit_urb()' in 'drivers/usb/core/urb.c') So this flag should be used in all the calling chain. Up to now, 'xhci_check_maxpacket()' which is only called from 'xhci_urb_enqueue()', uses GFP_KERNEL. Be safe and pass the mem_flags to this function as well. Fixes: ddba5cd0aeff ("xhci: Use command structures when queuing commands on the command ring") Cc: <stable(a)vger.kernel.org> Signed-off-by: Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> Signed-off-by: Mathias Nyman <mathias.nyman(a)linux.intel.com> Link: https://lore.kernel.org/r/20210512080816.866037-4-mathias.nyman@linux.intel… Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> [iwamatsu: Adjust context] Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu(a)toshiba.co.jp> --- drivers/usb/host/xhci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index bd6e3555c04793..b1994b03341fe8 100644 --- a/drivers/usb/host/xhci.c +++ b/drivers/usb/host/xhci.c @@ -1302,7 +1302,7 @@ static int xhci_configure_endpoint(struct xhci_hcd *xhci, * we need to issue an evaluate context command and wait on it. */ static int xhci_check_maxpacket(struct xhci_hcd *xhci, unsigned int slot_id, - unsigned int ep_index, struct urb *urb) + unsigned int ep_index, struct urb *urb, gfp_t mem_flags) { struct xhci_container_ctx *out_ctx; struct xhci_input_control_ctx *ctrl_ctx; @@ -1333,7 +1333,7 @@ static int xhci_check_maxpacket(struct xhci_hcd *xhci, unsigned int slot_id, * changes max packet sizes. */ - command = xhci_alloc_command(xhci, false, true, GFP_KERNEL); + command = xhci_alloc_command(xhci, false, true, mem_flags); if (!command) return -ENOMEM; @@ -1440,7 +1440,7 @@ int xhci_urb_enqueue(struct usb_hcd *hcd, struct urb *urb, gfp_t mem_flags) */ if (urb->dev->speed == USB_SPEED_FULL) { ret = xhci_check_maxpacket(xhci, slot_id, - ep_index, urb); + ep_index, urb, mem_flags); if (ret < 0) { xhci_urb_free_priv(urb_priv); urb->hcpriv = NULL; -- 2.30.0

3 years, 5 months

2
1
0 0

[PATCH 5.4 v2 0/9] preserve DMA offsets when using swiotlb

by Jianxiong Gao

We observed several NVMe failures when running with SWIOTLB. The root cause of the issue is that when data is mapped via SWIOTLB, the address offset is not preserved. Several device drivers including the NVMe driver relies on this offset to function correctly. Even though we discovered the error when running using AMD SEV, we have reproduced the same error in Rhel 8 without SEV. By adding swiotlb=force option to the boot command line parameter, NVMe funcionality is impacted. For example formatting a disk into xfs format returns an error. ---- Changes in v2: Rebased patches to 5.4.115 Updated patch description to correct format. Jianxiong Gao (9): driver core: add a min_align_mask field to struct device_dma_parameters swiotlb: add a IO_TLB_SIZE define swiotlb: factor out an io_tlb_offset helper swiotlb: factor out a nr_slots helper swiotlb: clean up swiotlb_tbl_unmap_single swiotlb: refactor swiotlb_tbl_map_single swiotlb: don't modify orig_addr in swiotlb_tbl_sync_single swiotlb: respect min_align_mask nvme-pci: set min_align_mask drivers/nvme/host/pci.c | 1 + include/linux/device.h | 1 + include/linux/dma-mapping.h | 16 +++ include/linux/swiotlb.h | 1 + kernel/dma/swiotlb.c | 269 ++++++++++++++++++++---------------- 5 files changed, 169 insertions(+), 119 deletions(-) -- 2.31.1.751.gd2f1c929bd-goog

3 years, 5 months

3
16
0 0

[PATCH 5.4 000/141] 5.4.120-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.4.120 release. There are 141 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 19 May 2021 14:02:20 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.120-rc… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 5.4.120-rc1 Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> ASoC: rsnd: check all BUSIF status when error Christoph Hellwig <hch(a)lst.de> nvme: do not try to reconfigure APST when the controller is not live Paweł Chmiel <pawel.mikolaj.chmiel(a)gmail.com> clk: exynos7: Mark aclk_fsys1_200 as critical Jonathon Reinhart <jonathon.reinhart(a)gmail.com> netfilter: conntrack: Make global sysctls readonly in non-init netns Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> kobject_uevent: remove warning in init_uevent_argv() Badhri Jagan Sridharan <badhri(a)google.com> usb: typec: tcpm: Fix error while calculating PPS out values Ard Biesheuvel <ardb(a)kernel.org> ARM: 9027/1: head.S: explicitly map DT even if it lives in the first physical section Ard Biesheuvel <ardb(a)kernel.org> ARM: 9020/1: mm: use correct section size macro to describe the FDT virtual address Ard Biesheuvel <ardb(a)kernel.org> ARM: 9012/1: move device tree mapping out of linear region Ard Biesheuvel <ardb(a)kernel.org> ARM: 9011/1: centralize phys-to-virt conversion of DT/ATAGS address Eric Biggers <ebiggers(a)google.com> f2fs: fix error handling in f2fs_end_enable_verity() Lukasz Luba <lukasz.luba(a)arm.com> thermal/core/fair share: Lock the thermal zone while looping over instances Maciej W. Rozycki <macro(a)orcam.me.uk> MIPS: Avoid handcoded DIVU in `__div64_32' altogether Maciej W. Rozycki <macro(a)orcam.me.uk> MIPS: Avoid DIVU in `__div64_32' is result would be zero Maciej W. Rozycki <macro(a)orcam.me.uk> MIPS: Reinstate platform `__div64_32' handler Maciej W. Rozycki <macro(a)orcam.me.uk> FDDI: defxx: Make MMIO the configuration default except for EISA Matthew Wilcox (Oracle) <willy(a)infradead.org> mm: fix struct page layout on 32-bit systems Thomas Gleixner <tglx(a)linutronix.de> KVM: x86: Cancel pvclock_gtod_work on module removal Oliver Neukum <oneukum(a)suse.com> cdc-wdm: untangle a circular dependency between callback and softint Colin Ian King <colin.king(a)canonical.com> iio: tsl2583: Fix division by a zero lux_val Dmitry Osipenko <digetx(a)gmail.com> iio: gyro: mpu3050: Fix reported temperature value Sandeep Singh <sandeep.singh(a)amd.com> xhci: Add reset resume quirk for AMD xhci controller. Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> xhci: Do not use GFP_KERNEL in (potentially) atomic context Wesley Cheng <wcheng(a)codeaurora.org> usb: dwc3: gadget: Return success always for kick transfer in ep queue Chunfeng Yun <chunfeng.yun(a)mediatek.com> usb: core: hub: fix race condition about TRSMRCY of resume Phil Elwell <phil(a)raspberrypi.com> usb: dwc2: Fix gadget DMA unmap direction Maximilian Luz <luzmaximilian(a)gmail.com> usb: xhci: Increase timeout for HC halt Ferry Toth <ftoth(a)exalondelft.nl> usb: dwc3: pci: Enable usb2-gadget-lpm-disable for Intel Merrifield Marcel Hamer <marcel(a)solidxs.se> usb: dwc3: omap: improve extcon initialization Christoph Hellwig <hch(a)lst.de> iomap: fix sub-page uptodate handling Bart Van Assche <bvanassche(a)acm.org> blk-mq: Swap two calls in blk_mq_exit_queue() Sun Ke <sunke32(a)huawei.com> nbd: Fix NULL pointer in flush_workqueue Omar Sandoval <osandov(a)fb.com> kyber: fix out of bounds access when preempted Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> ACPI: scan: Fix a memory leak in an error handling path Eddie James <eajames(a)linux.ibm.com> hwmon: (occ) Fix poll rate limiting Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> usb: fotg210-hcd: Fix an error message Dinghao Liu <dinghao.liu(a)zju.edu.cn> iio: proximity: pulsedlight: Fix rumtime PM imbalance on error Ville Syrjälä <ville.syrjala(a)linux.intel.com> drm/i915: Avoid div-by-zero on gen2 Kai-Heng Feng <kai.heng.feng(a)canonical.com> drm/radeon/dpm: Disable sclk switching on Oland when two 4K 60Hz monitors are connected Peter Xu <peterx(a)redhat.com> mm/hugetlb: fix F_SEAL_FUTURE_WRITE Axel Rasmussen <axelrasmussen(a)google.com> userfaultfd: release page in error path to avoid BUG_ON Phillip Lougher <phillip(a)squashfs.org.uk> squashfs: fix divide error in calculate_skip() Jouni Roivas <jouni.roivas(a)tuxera.com> hfsplus: prevent corruption in shrinking truncate Michael Ellerman <mpe(a)ellerman.id.au> powerpc/64s: Fix crashes when toggling entry flush barrier Michael Ellerman <mpe(a)ellerman.id.au> powerpc/64s: Fix crashes when toggling stf barrier Vladimir Isaev <isaev(a)synopsys.com> ARC: mm: PAE: use 40-bit physical page mask Vineet Gupta <vgupta(a)synopsys.com> ARC: entry: fix off-by-one error in syscall number validation Mateusz Palczewski <mateusz.palczewski(a)intel.com> i40e: Fix PHY type identifiers for 2.5G and 5G adapters Jaroslaw Gawin <jaroslawx.gawin(a)intel.com> i40e: fix the restart auto-negotiation after FEC modified Yunjian Wang <wangyunjian(a)huawei.com> i40e: Fix use-after-free in i40e_client_subtask() Eric Dumazet <edumazet(a)google.com> netfilter: nftables: avoid overflows in nft_hash_buckets() Jia-Ju Bai <baijiaju1990(a)gmail.com> kernel: kexec_file: fix error return code of kexec_calculate_store_digests() Odin Ugedal <odin(a)uged.al> sched/fair: Fix unfairness caused by missing load decay Quentin Perret <qperret(a)google.com> sched: Fix out-of-bound access in uclamp Marc Kleine-Budde <mkl(a)pengutronix.de> can: m_can: m_can_tx_work_queue(): fix tx_skb race condition Pablo Neira Ayuso <pablo(a)netfilter.org> netfilter: nfnetlink_osf: Fix a missing skb_header_pointer() NULL check Cong Wang <cong.wang(a)bytedance.com> smc: disallow TCP_ULP in smc_setsockopt() Maciej Żenczykowski <maze(a)google.com> net: fix nla_strcmp to handle more then one trailing null character Miaohe Lin <linmiaohe(a)huawei.com> ksm: fix potential missing rmap_item for stable_node Miaohe Lin <linmiaohe(a)huawei.com> mm/migrate.c: fix potential indeterminate pte entry in migrate_vma_insert_page() Miaohe Lin <linmiaohe(a)huawei.com> mm/hugeltb: handle the error case in hugetlb_fix_reserve_counts() Miaohe Lin <linmiaohe(a)huawei.com> khugepaged: fix wrong result value for trace_mm_collapse_huge_page_isolate() Kees Cook <keescook(a)chromium.org> drm/radeon: Avoid power table parsing memory leaks Kees Cook <keescook(a)chromium.org> drm/radeon: Fix off-by-one power_state index heap overwrite Pablo Neira Ayuso <pablo(a)netfilter.org> netfilter: xt_SECMARK: add new revision to fix structure layout Xin Long <lucien.xin(a)gmail.com> sctp: fix a SCTP_MIB_CURRESTAB leak in sctp_sf_do_dupcook_b Lv Yunlong <lyl2019(a)mail.ustc.edu.cn> ethernet:enic: Fix a use after free bug in enic_hard_start_xmit Baptiste Lepers <baptiste.lepers(a)gmail.com> sunrpc: Fix misplaced barrier in call_decode Anup Patel <anup.patel(a)wdc.com> RISC-V: Fix error code returned by riscv_hartid_to_cpuid() Xin Long <lucien.xin(a)gmail.com> sctp: do asoc update earlier in sctp_sf_do_dupcook_a Yufeng Mo <moyufeng(a)huawei.com> net: hns3: disable phy loopback setting in hclge_mac_start_phy Peng Li <lipeng321(a)huawei.com> net: hns3: use netif_tx_disable to stop the transmit queue Hao Chen <chenhao288(a)hisilicon.com> net: hns3: fix for vxlan gpe tx checksum bug Jian Shen <shenjian15(a)huawei.com> net: hns3: add check for HNS3_NIC_STATE_INITED in hns3_reset_notify_up_enet() Yufeng Mo <moyufeng(a)huawei.com> net: hns3: initialize the message content in hclge_get_link_mode() Yufeng Mo <moyufeng(a)huawei.com> net: hns3: fix incorrect configuration for igu_egu_hw_err Nobuhiro Iwamatsu <nobuhiro1.iwamatsu(a)toshiba.co.jp> rtc: ds1307: Fix wday settings for rx8130 Jeff Layton <jlayton(a)kernel.org> ceph: fix inode leak on getattr error in __fh_to_dentry Michael Walle <michael(a)walle.cc> rtc: fsl-ftm-alarm: add MODULE_TABLE() Olga Kornievskaia <kolga(a)netapp.com> NFSv4.2 fix handling of sr_eof in SEEK's reply Nikola Livic <nlivic(a)gmail.com> pNFS/flexfiles: fix incorrect size check in decode_nfs_fh() Yang Yingliang <yangyingliang(a)huawei.com> PCI: endpoint: Fix missing destroy_workqueue() Trond Myklebust <trond.myklebust(a)hammerspace.com> NFS: Deal correctly with attribute generation counter overflow Trond Myklebust <trond.myklebust(a)hammerspace.com> NFSv4.2: Always flush out writes in nfs42_proc_fallocate() Jia-Ju Bai <baijiaju1990(a)gmail.com> rpmsg: qcom_glink_native: fix error return code of qcom_glink_rx_data() Zhen Lei <thunder.leizhen(a)huawei.com> ARM: 9064/1: hw_breakpoint: Do not directly check the event's overflow_handler hook Dmitry Baryshkov <dmitry.baryshkov(a)linaro.org> PCI: Release OF node in pci_scan_device()'s error path Pali Rohár <pali(a)kernel.org> PCI: iproc: Fix return value of iproc_msi_irq_domain_alloc() Colin Ian King <colin.king(a)canonical.com> f2fs: fix a redundant call to f2fs_balance_fs if an error occurs Jia-Ju Bai <baijiaju1990(a)gmail.com> thermal: thermal_of: Fix error return code of thermal_of_populate_bind_params() David Ward <david.ward(a)gatech.edu> ASoC: rt286: Make RT286_SET_GPIO_* readable and writable Sergei Trofimovich <slyfox(a)gentoo.org> ia64: module: fix symbolizer crash on fdescr Michael Chan <michael.chan(a)broadcom.com> bnxt_en: Add PCI IDs for Hyper-V VF devices. Felix Fietkau <nbd(a)nbd.name> net: ethernet: mtk_eth_soc: fix RX VLAN offload Stefan Assmann <sassmann(a)kpanic.de> iavf: remove duplicate free resources calls Alexey Kardashevskiy <aik(a)ozlabs.ru> powerpc/iommu: Annotate nested lock for lockdep Lee Gibson <leegib(a)gmail.com> qtnfmac: Fix possible buffer overflow in qtnf_event_handle_external_auth Gustavo A. R. Silva <gustavoars(a)kernel.org> wl3501_cs: Fix out-of-bounds warnings in wl3501_mgmt_join Gustavo A. R. Silva <gustavoars(a)kernel.org> wl3501_cs: Fix out-of-bounds warnings in wl3501_send_pkt Robin Singh <robin.singh(a)amd.com> drm/amd/display: fixed divide by zero kernel crash during dsc enablement Michael Ellerman <mpe(a)ellerman.id.au> powerpc/pseries: Stop calling printk in rtas_stop_self() Yaqi Chen <chendotjs(a)gmail.com> samples/bpf: Fix broken tracex1 due to kprobe argument change Du Cheng <ducheng2(a)gmail.com> net: sched: tapr: prevent cycle_time == 0 in parse_taprio_schedule Gustavo A. R. Silva <gustavoars(a)kernel.org> ethtool: ioctl: Fix out-of-bounds warning in store_link_ksettings_for_user() David Ward <david.ward(a)gatech.edu> ASoC: rt286: Generalize support for ALC3263 codec Srikar Dronamraju <srikar(a)linux.vnet.ibm.com> powerpc/smp: Set numa node before updating mask Gustavo A. R. Silva <gustavoars(a)kernel.org> flow_dissector: Fix out-of-bounds warning in __skb_flow_bpf_to_target() Gustavo A. R. Silva <gustavoars(a)kernel.org> sctp: Fix out-of-bounds warning in sctp_process_asconf_param() Kai Vehmanen <kai.vehmanen(a)linux.intel.com> ALSA: hda/hdmi: fix race in handling acomp ELD notification at resume Mihai Moldovan <ionic(a)ionic.de> kconfig: nconf: stop endless search loops Yonghong Song <yhs(a)fb.com> selftests: Set CC to clang in lib.mk if LLVM is set Anthony Wang <anthony1.wang(a)amd.com> drm/amd/display: Force vsync flip when reconfiguring MPCC Suravee Suthikulpanit <suravee.suthikulpanit(a)amd.com> iommu/amd: Remove performance counter pre-initialization test Paul Menzel <pmenzel(a)molgen.mpg.de> Revert "iommu/amd: Fix performance counter initialization" Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> ASoC: rsnd: call rsnd_ssi_master_clk_start() from rsnd_ssi_init() Miklos Szeredi <mszeredi(a)redhat.com> cuse: prevent clone David Bauer <mail(a)david-bauer.net> mt76: mt76x0: disable GTK offloading Krzysztof Kozlowski <krzysztof.kozlowski(a)canonical.com> pinctrl: samsung: use 'int' for register masks in Exynos Emmanuel Grumbach <emmanuel.grumbach(a)intel.com> mac80211: clear the beacon's CRC after channel switch Bence Csókás <bence98(a)sch.bme.hu> i2c: Add I2C_AQ_NO_REP_START adapter quirk Hans de Goede <hdegoede(a)redhat.com> ASoC: Intel: bytcr_rt5640: Add quirk for the Chuwi Hi8 tablet Eric Dumazet <edumazet(a)google.com> ip6_vti: proper dev_{hold|put} in ndo_[un]init methods Archie Pusaka <apusaka(a)chromium.org> Bluetooth: check for zapped sk before connecting Nikolay Aleksandrov <nikolay(a)nvidia.com> net: bridge: when suppression is enabled exclude RARP packets Tetsuo Handa <penguin-kernel(a)I-love.SAKURA.ne.jp> Bluetooth: initialize skb_queue_head at l2cap_chan_create() Archie Pusaka <apusaka(a)chromium.org> Bluetooth: Set CONF_NOT_COMPLETE as l2cap_chan default Takashi Sakamoto <o-takashi(a)sakamocchi.jp> ALSA: bebob: enable to deliver MIDI messages for multiple ports Tong Zhang <ztong0001(a)gmail.com> ALSA: rme9652: don't disable if not enabled Tong Zhang <ztong0001(a)gmail.com> ALSA: hdspm: don't disable if not enabled Tong Zhang <ztong0001(a)gmail.com> ALSA: hdsp: don't disable if not enabled Wolfram Sang <wsa+renesas(a)sang-engineering.com> i2c: bail out early when RDWR parameters are wrong Mikhail Durnev <mikhail_durnev(a)mentor.com> ASoC: rsnd: core: Check convert rate in rsnd_hw_params Jonathan McDowell <noodles(a)earth.li> net: stmmac: Set FIFO sizes for ipq806x Hans de Goede <hdegoede(a)redhat.com> ASoC: Intel: bytcr_rt5640: Enable jack-detect support on Asus T100TAF Hoang Le <hoang.h.le(a)dektech.com.au> tipc: convert dest node's address to network order Alexander Aring <aahringo(a)redhat.com> fs: dlm: fix debugfs dump Tony Lindgren <tony(a)atomide.com> PM: runtime: Fix unpaired parent child_count for force_resume Sean Christopherson <seanjc(a)google.com> KVM: x86/mmu: Remove the defunct update_pte() paging hook Jarkko Sakkinen <jarkko(a)kernel.org> tpm, tpm_tis: Reserve locality in tpm_tis_resume() Jarkko Sakkinen <jarkko(a)kernel.org> tpm, tpm_tis: Extend locality handling to TPM2 in tpm_tis_gen_interrupt() Zhen Lei <thunder.leizhen(a)huawei.com> tpm: fix error return code in tpm2_get_cc_attrs_tbl() ------------- Diffstat: Documentation/arm/memory.rst | 7 +- Makefile | 4 +- arch/arc/include/asm/page.h | 12 +++ arch/arc/include/asm/pgtable.h | 12 +-- arch/arc/include/uapi/asm/page.h | 1 - arch/arc/kernel/entry.S | 4 +- arch/arc/mm/ioremap.c | 5 +- arch/arc/mm/tlb.c | 2 +- arch/arm/include/asm/fixmap.h | 2 +- arch/arm/include/asm/memory.h | 5 ++ arch/arm/include/asm/prom.h | 4 +- arch/arm/kernel/atags.h | 4 +- arch/arm/kernel/atags_parse.c | 6 +- arch/arm/kernel/devtree.c | 6 +- arch/arm/kernel/head.S | 9 +-- arch/arm/kernel/hw_breakpoint.c | 2 +- arch/arm/kernel/setup.c | 19 +++-- arch/arm/mm/init.c | 1 - arch/arm/mm/mmu.c | 20 +++-- arch/arm/mm/pv-fixup-asm.S | 4 +- arch/ia64/include/asm/module.h | 6 +- arch/ia64/kernel/module.c | 29 ++++++- arch/mips/include/asm/div64.h | 55 ++++++++++---- arch/powerpc/kernel/iommu.c | 4 +- arch/powerpc/kernel/smp.c | 6 +- arch/powerpc/lib/feature-fixups.c | 35 ++++++++- arch/powerpc/platforms/pseries/hotplug-cpu.c | 3 - arch/riscv/kernel/smp.c | 2 +- arch/x86/include/asm/kvm_host.h | 3 - arch/x86/kvm/mmu.c | 33 +------- arch/x86/kvm/x86.c | 2 +- block/bfq-iosched.c | 3 +- block/blk-mq-sched.c | 8 +- block/blk-mq.c | 6 +- block/kyber-iosched.c | 5 +- block/mq-deadline.c | 3 +- drivers/acpi/scan.c | 1 + drivers/base/power/runtime.c | 10 ++- drivers/block/nbd.c | 3 +- drivers/char/tpm/tpm2-cmd.c | 1 + drivers/char/tpm/tpm_tis_core.c | 22 ++++-- drivers/clk/samsung/clk-exynos7.c | 7 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 4 + drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hubp.c | 15 ++-- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 2 +- drivers/gpu/drm/radeon/radeon.h | 1 + drivers/gpu/drm/radeon/radeon_atombios.c | 26 +++++-- drivers/gpu/drm/radeon/radeon_pm.c | 8 ++ drivers/gpu/drm/radeon/si_dpm.c | 3 + drivers/hwmon/occ/common.c | 5 +- drivers/hwmon/occ/common.h | 2 +- drivers/i2c/i2c-dev.c | 9 ++- drivers/iio/gyro/mpu3050-core.c | 13 +++- drivers/iio/light/tsl2583.c | 8 ++ drivers/iio/proximity/pulsedlight-lidar-lite-v2.c | 1 + drivers/iommu/amd_iommu_init.c | 49 +----------- drivers/net/can/m_can/m_can.c | 3 +- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 19 ++++- drivers/net/ethernet/cisco/enic/enic_main.c | 7 +- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 12 ++- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c | 3 +- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_err.h | 3 +- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c | 2 +- .../ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c | 2 + drivers/net/ethernet/intel/i40e/i40e_adminq_cmd.h | 6 +- drivers/net/ethernet/intel/i40e/i40e_client.c | 1 + drivers/net/ethernet/intel/i40e/i40e_common.c | 4 +- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 7 +- drivers/net/ethernet/intel/i40e/i40e_type.h | 7 +- drivers/net/ethernet/intel/iavf/iavf_main.c | 2 - drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +- drivers/net/ethernet/mediatek/mtk_eth_soc.h | 1 + .../net/ethernet/stmicro/stmmac/dwmac-ipq806x.c | 2 + drivers/net/fddi/Kconfig | 15 ++-- drivers/net/wireless/mediatek/mt76/mt76x02_util.c | 4 + drivers/net/wireless/quantenna/qtnfmac/event.c | 6 +- drivers/net/wireless/wl3501.h | 47 ++++++------ drivers/net/wireless/wl3501_cs.c | 54 +++++++------ drivers/nvme/host/core.c | 3 +- drivers/pci/controller/pcie-iproc-msi.c | 2 +- drivers/pci/endpoint/functions/pci-epf-test.c | 3 + drivers/pci/probe.c | 1 + drivers/pinctrl/samsung/pinctrl-exynos.c | 10 +-- drivers/rpmsg/qcom_glink_native.c | 1 + drivers/rtc/rtc-ds1307.c | 12 ++- drivers/rtc/rtc-fsl-ftm-alarm.c | 1 + drivers/thermal/fair_share.c | 4 + drivers/thermal/of-thermal.c | 7 +- drivers/usb/class/cdc-wdm.c | 30 ++++++-- drivers/usb/core/hub.c | 6 +- drivers/usb/dwc2/core.h | 2 + drivers/usb/dwc2/gadget.c | 3 +- drivers/usb/dwc3/dwc3-omap.c | 5 ++ drivers/usb/dwc3/dwc3-pci.c | 1 + drivers/usb/dwc3/gadget.c | 4 +- drivers/usb/host/fotg210-hcd.c | 4 +- drivers/usb/host/xhci-ext-caps.h | 5 +- drivers/usb/host/xhci-pci.c | 4 +- drivers/usb/host/xhci.c | 6 +- drivers/usb/typec/tcpm/tcpm.c | 6 +- fs/ceph/export.c | 4 +- fs/dlm/debug_fs.c | 1 + fs/f2fs/inline.c | 3 +- fs/f2fs/verity.c | 75 ++++++++++++------ fs/fuse/cuse.c | 2 + fs/hfsplus/extents.c | 7 +- fs/hugetlbfs/inode.c | 5 ++ fs/iomap/buffered-io.c | 34 ++++++--- fs/nfs/flexfilelayout/flexfilelayout.c | 2 +- fs/nfs/inode.c | 8 +- fs/nfs/nfs42proc.c | 21 ++++-- fs/squashfs/file.c | 6 +- include/linux/elevator.h | 2 +- include/linux/i2c.h | 2 + include/linux/iomap.h | 1 + include/linux/mm.h | 32 ++++++++ include/linux/mm_types.h | 4 +- include/linux/pm.h | 1 + include/net/page_pool.h | 12 ++- include/uapi/linux/netfilter/xt_SECMARK.h | 6 ++ kernel/kexec_file.c | 4 +- kernel/sched/core.c | 2 +- kernel/sched/fair.c | 12 ++- lib/kobject_uevent.c | 9 ++- lib/nlattr.c | 2 +- mm/hugetlb.c | 11 ++- mm/khugepaged.c | 18 ++--- mm/ksm.c | 1 + mm/migrate.c | 7 ++ mm/shmem.c | 34 ++++----- net/bluetooth/l2cap_core.c | 4 + net/bluetooth/l2cap_sock.c | 8 ++ net/bridge/br_arp_nd_proxy.c | 4 +- net/core/ethtool.c | 2 +- net/core/flow_dissector.c | 6 +- net/core/page_pool.c | 6 +- net/ipv6/ip6_vti.c | 2 +- net/mac80211/mlme.c | 5 ++ net/netfilter/nf_conntrack_standalone.c | 5 +- net/netfilter/nfnetlink_osf.c | 2 + net/netfilter/nft_set_hash.c | 10 ++- net/netfilter/xt_SECMARK.c | 88 +++++++++++++++++----- net/sched/sch_taprio.c | 6 ++ net/sctp/sm_make_chunk.c | 2 +- net/sctp/sm_statefuns.c | 28 +++++-- net/smc/af_smc.c | 4 +- net/sunrpc/clnt.c | 11 ++- net/tipc/netlink_compat.c | 2 +- samples/bpf/tracex1_kern.c | 4 +- scripts/kconfig/nconf.c | 2 +- sound/firewire/bebob/bebob_stream.c | 12 +-- sound/pci/hda/patch_hdmi.c | 4 +- sound/pci/rme9652/hdsp.c | 3 +- sound/pci/rme9652/hdspm.c | 3 +- sound/pci/rme9652/rme9652.c | 3 +- sound/soc/codecs/rt286.c | 23 +++--- sound/soc/intel/boards/bytcr_rt5640.c | 20 +++++ sound/soc/sh/rcar/core.c | 69 ++++++++++++++++- sound/soc/sh/rcar/ssi.c | 16 ++-- tools/testing/selftests/lib.mk | 4 + 160 files changed, 1035 insertions(+), 502 deletions(-)

3 years, 5 months

10
152
0 0

[PATCH 4.4] netfilter: x_tables: Use correct memory barriers.

by Pavel Machek

From: Mark Tomlinson <mark.tomlinson(a)alliedtelesis.co.nz> commit 175e476b8cdf2a4de7432583b49c871345e4f8a1 upstream. When a new table value was assigned, it was followed by a write memory barrier. This ensured that all writes before this point would complete before any writes after this point. However, to determine whether the rules are unused, the sequence counter is read. To ensure that all writes have been done before these reads, a full memory barrier is needed, not just a write memory barrier. The same argument applies when incrementing the counter, before the rules are read. Changing to using smp_mb() instead of smp_wmb() fixes the kernel panic reported in cc00bcaa5899 (which is still present), while still maintaining the same speed of replacing tables. The smb_mb() barriers potentially slow the packet path, however testing has shown no measurable change in performance on a 4-core MIPS64 platform. Fixes: 7f5c6d4f665b ("netfilter: get rid of atomic ops in fast path") Signed-off-by: Mark Tomlinson <mark.tomlinson(a)alliedtelesis.co.nz> Signed-off-by: Pablo Neira Ayuso <pablo(a)netfilter.org> [Ported to stable, affected barrier is added by d3d40f237480abf3268956daf18cdc56edd32834 in mainline] Signed-off-by: Pavel Machek (CIP) <pavel(a)denx.de> --- include/linux/netfilter/x_tables.h | 2 +- net/netfilter/x_tables.c | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/include/linux/netfilter/x_tables.h b/include/linux/netfilter/x_tables.h index 6923e4049de3..304b60b49526 100644 --- a/include/linux/netfilter/x_tables.h +++ b/include/linux/netfilter/x_tables.h @@ -327,7 +327,7 @@ static inline unsigned int xt_write_recseq_begin(void) * since addend is most likely 1 */ __this_cpu_add(xt_recseq.sequence, addend); - smp_wmb(); + smp_mb(); return addend; } diff --git a/net/netfilter/x_tables.c b/net/netfilter/x_tables.c index 8caae1c5d93d..8878f859c6de 100644 --- a/net/netfilter/x_tables.c +++ b/net/netfilter/x_tables.c @@ -1146,6 +1146,9 @@ xt_replace_table(struct xt_table *table, smp_wmb(); table->private = newinfo; + /* make sure all cpus see new ->private value */ + smp_mb(); + /* * Even though table entries have now been swapped, other CPU's * may still be using the old entries. This is okay, because -- 2.11.0 -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

3 years, 5 months

3
2
0 0

stable-rc/queue/5.12 baseline: 174 runs, 2 regressions (v5.12.5-41-g47eb87359033)

by kernelci.org bot

stable-rc/queue/5.12 baseline: 174 runs, 2 regressions (v5.12.5-41-g47eb87359033) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions -------------------------+-------+---------+----------+-----------+------------ imx8mp-evk | arm64 | lab-nxp | gcc-8 | defconfig | 1 r8a774a1-hihope-rzg2m-ex | arm64 | lab-cip | gcc-8 | defconfig | 1 Details: https://kernelci.org/test/job/stable-rc/branch/queue%2F5.12/kernel/v5.12.5-… Test: baseline Tree: stable-rc Branch: queue/5.12 Describe: v5.12.5-41-g47eb87359033 URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: 47eb8735903379c8a1d07b4093d10e9cb494b970 Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions -------------------------+-------+---------+----------+-----------+------------ imx8mp-evk | arm64 | lab-nxp | gcc-8 | defconfig | 1 Details: https://kernelci.org/test/plan/id/60a5dc0ff7a758f828b3afc5 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-8 (aarch64-linux-gnu-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-5.12/v5.12.5-41-g47eb87359033… HTML log: https://storage.kernelci.org//stable-rc/queue-5.12/v5.12.5-41-g47eb87359033… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-5-g2f114cc7… * baseline.login: https://kernelci.org/test/case/id/60a5dc0ff7a758f828b3afc6 failing since 0 day (last pass: v5.12.4-363-g893c8b1b923f, first fail: v5.12.5-5-gd7347eee5d7b) platform | arch | lab | compiler | defconfig | regressions -------------------------+-------+---------+----------+-----------+------------ r8a774a1-hihope-rzg2m-ex | arm64 | lab-cip | gcc-8 | defconfig | 1 Details: https://kernelci.org/test/plan/id/60a5dbcb8dcd00dd68b3afd4 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-8 (aarch64-linux-gnu-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-5.12/v5.12.5-41-g47eb87359033… HTML log: https://storage.kernelci.org//stable-rc/queue-5.12/v5.12.5-41-g47eb87359033… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-5-g2f114cc7… * baseline.login: https://kernelci.org/test/case/id/60a5dbcb8dcd00dd68b3afd5 new failure (last pass: v5.12.5-5-gd7347eee5d7b)

3 years, 5 months

1
0
0 0

stable-rc/queue/4.19 baseline: 155 runs, 5 regressions (v4.19.190-418-g6016ca5a2a3b)

by kernelci.org bot

stable-rc/queue/4.19 baseline: 155 runs, 5 regressions (v4.19.190-418-g6016ca5a2a3b) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions ---------------------+------+-----------------+----------+---------------------+------------ qemu_arm-versatilepb | arm | lab-baylibre | gcc-8 | versatile_defconfig | 1 qemu_arm-versatilepb | arm | lab-broonie | gcc-8 | versatile_defconfig | 1 qemu_arm-versatilepb | arm | lab-cip | gcc-8 | versatile_defconfig | 1 qemu_arm-versatilepb | arm | lab-collabora | gcc-8 | versatile_defconfig | 1 qemu_arm-versatilepb | arm | lab-linaro-lkft | gcc-8 | versatile_defconfig | 1 Details: https://kernelci.org/test/job/stable-rc/branch/queue%2F4.19/kernel/v4.19.19… Test: baseline Tree: stable-rc Branch: queue/4.19 Describe: v4.19.190-418-g6016ca5a2a3b URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: 6016ca5a2a3b9219dab73a63e85b321fc3cee847 Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions ---------------------+------+-----------------+----------+---------------------+------------ qemu_arm-versatilepb | arm | lab-baylibre | gcc-8 | versatile_defconfig | 1 Details: https://kernelci.org/test/plan/id/60a5d373ad55961709b3af99 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: versatile_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.190-418-g6016ca5a2… HTML log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.190-418-g6016ca5a2… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-5-g2f114cc7… * baseline.login: https://kernelci.org/test/case/id/60a5d373ad55961709b3af9a failing since 187 days (last pass: v4.19.157-26-gd59f3161b3a0, first fail: v4.19.157-27-g5543cc2c41d55) platform | arch | lab | compiler | defconfig | regressions ---------------------+------+-----------------+----------+---------------------+------------ qemu_arm-versatilepb | arm | lab-broonie | gcc-8 | versatile_defconfig | 1 Details: https://kernelci.org/test/plan/id/60a5d3999fc941ba44b3b021 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: versatile_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.190-418-g6016ca5a2… HTML log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.190-418-g6016ca5a2… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-5-g2f114cc7… * baseline.login: https://kernelci.org/test/case/id/60a5d3999fc941ba44b3b022 failing since 187 days (last pass: v4.19.157-26-gd59f3161b3a0, first fail: v4.19.157-27-g5543cc2c41d55) platform | arch | lab | compiler | defconfig | regressions ---------------------+------+-----------------+----------+---------------------+------------ qemu_arm-versatilepb | arm | lab-cip | gcc-8 | versatile_defconfig | 1 Details: https://kernelci.org/test/plan/id/60a5d3a04c9de7f7c8b3afa6 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: versatile_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.190-418-g6016ca5a2… HTML log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.190-418-g6016ca5a2… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-5-g2f114cc7… * baseline.login: https://kernelci.org/test/case/id/60a5d3a04c9de7f7c8b3afa7 failing since 187 days (last pass: v4.19.157-26-gd59f3161b3a0, first fail: v4.19.157-27-g5543cc2c41d55) platform | arch | lab | compiler | defconfig | regressions ---------------------+------+-----------------+----------+---------------------+------------ qemu_arm-versatilepb | arm | lab-collabora | gcc-8 | versatile_defconfig | 1 Details: https://kernelci.org/test/plan/id/60a5d3c56e5c96c6d7b3afa6 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: versatile_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.190-418-g6016ca5a2… HTML log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.190-418-g6016ca5a2… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-5-g2f114cc7… * baseline.login: https://kernelci.org/test/case/id/60a5d3c56e5c96c6d7b3afa7 failing since 187 days (last pass: v4.19.157-26-gd59f3161b3a0, first fail: v4.19.157-27-g5543cc2c41d55) platform | arch | lab | compiler | defconfig | regressions ---------------------+------+-----------------+----------+---------------------+------------ qemu_arm-versatilepb | arm | lab-linaro-lkft | gcc-8 | versatile_defconfig | 1 Details: https://kernelci.org/test/plan/id/60a5d333a745de9750b3afbf Results: 0 PASS, 1 FAIL, 0 SKIP Full config: versatile_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.190-418-g6016ca5a2… HTML log: https://storage.kernelci.org//stable-rc/queue-4.19/v4.19.190-418-g6016ca5a2… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-5-g2f114cc7… * baseline.login: https://kernelci.org/test/case/id/60a5d333a745de9750b3afc0 failing since 187 days (last pass: v4.19.157-26-gd59f3161b3a0, first fail: v4.19.157-27-g5543cc2c41d55)

3 years, 5 months

1
0
0 0

stable-rc/queue/4.9 baseline: 121 runs, 5 regressions (v4.9.268-236-g1c318f517040)

by kernelci.org bot

stable-rc/queue/4.9 baseline: 121 runs, 5 regressions (v4.9.268-236-g1c318f517040) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions ---------------------+------+-----------------+----------+---------------------+------------ qemu_arm-versatilepb | arm | lab-baylibre | gcc-8 | versatile_defconfig | 1 qemu_arm-versatilepb | arm | lab-broonie | gcc-8 | versatile_defconfig | 1 qemu_arm-versatilepb | arm | lab-cip | gcc-8 | versatile_defconfig | 1 qemu_arm-versatilepb | arm | lab-collabora | gcc-8 | versatile_defconfig | 1 qemu_arm-versatilepb | arm | lab-linaro-lkft | gcc-8 | versatile_defconfig | 1 Details: https://kernelci.org/test/job/stable-rc/branch/queue%2F4.9/kernel/v4.9.268-… Test: baseline Tree: stable-rc Branch: queue/4.9 Describe: v4.9.268-236-g1c318f517040 URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: 1c318f517040885a23b57f2e7851c79d5c5ba364 Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions ---------------------+------+-----------------+----------+---------------------+------------ qemu_arm-versatilepb | arm | lab-baylibre | gcc-8 | versatile_defconfig | 1 Details: https://kernelci.org/test/plan/id/60a5cf01835005f7f1b3afa0 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: versatile_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.268-236-g1c318f51704… HTML log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.268-236-g1c318f51704… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-5-g2f114cc7… * baseline.login: https://kernelci.org/test/case/id/60a5cf01835005f7f1b3afa1 failing since 187 days (last pass: v4.9.243-16-gd8d67e375b0a, first fail: v4.9.243-25-ga01fe8e99a22) platform | arch | lab | compiler | defconfig | regressions ---------------------+------+-----------------+----------+---------------------+------------ qemu_arm-versatilepb | arm | lab-broonie | gcc-8 | versatile_defconfig | 1 Details: https://kernelci.org/test/plan/id/60a5cefc1341b4a8f3b3afb0 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: versatile_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.268-236-g1c318f51704… HTML log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.268-236-g1c318f51704… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-5-g2f114cc7… * baseline.login: https://kernelci.org/test/case/id/60a5cefc1341b4a8f3b3afb1 failing since 187 days (last pass: v4.9.243-16-gd8d67e375b0a, first fail: v4.9.243-25-ga01fe8e99a22) platform | arch | lab | compiler | defconfig | regressions ---------------------+------+-----------------+----------+---------------------+------------ qemu_arm-versatilepb | arm | lab-cip | gcc-8 | versatile_defconfig | 1 Details: https://kernelci.org/test/plan/id/60a5cf0ee1eaeb35c5b3afaf Results: 0 PASS, 1 FAIL, 0 SKIP Full config: versatile_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.268-236-g1c318f51704… HTML log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.268-236-g1c318f51704… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-5-g2f114cc7… * baseline.login: https://kernelci.org/test/case/id/60a5cf0ee1eaeb35c5b3afb0 failing since 187 days (last pass: v4.9.243-16-gd8d67e375b0a, first fail: v4.9.243-25-ga01fe8e99a22) platform | arch | lab | compiler | defconfig | regressions ---------------------+------+-----------------+----------+---------------------+------------ qemu_arm-versatilepb | arm | lab-collabora | gcc-8 | versatile_defconfig | 1 Details: https://kernelci.org/test/plan/id/60a5cec626e6ff1f9cb3afb4 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: versatile_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.268-236-g1c318f51704… HTML log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.268-236-g1c318f51704… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-5-g2f114cc7… * baseline.login: https://kernelci.org/test/case/id/60a5cec626e6ff1f9cb3afb5 failing since 187 days (last pass: v4.9.243-16-gd8d67e375b0a, first fail: v4.9.243-25-ga01fe8e99a22) platform | arch | lab | compiler | defconfig | regressions ---------------------+------+-----------------+----------+---------------------+------------ qemu_arm-versatilepb | arm | lab-linaro-lkft | gcc-8 | versatile_defconfig | 1 Details: https://kernelci.org/test/plan/id/60a5ceab26e6ff1f9cb3af97 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: versatile_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.268-236-g1c318f51704… HTML log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.268-236-g1c318f51704… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-5-g2f114cc7… * baseline.login: https://kernelci.org/test/case/id/60a5ceab26e6ff1f9cb3af98 failing since 187 days (last pass: v4.9.243-16-gd8d67e375b0a, first fail: v4.9.243-25-ga01fe8e99a22)

3 years, 5 months

1
0
0 0

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror May 2021