Hi,
On my acer swift 3 (SF314-51), I can't boot on my device since 4.19.198 (no issue with 4.19.197) without adding "acpi=off" in the parameters. Same thing happens on 5.12.19 (didn't happened in 5.12.16), 5.13.4 and .5 and 5.10.52.
If acpi is not off issue is :
-black screen after grub
- no errors, no activity (tested by leaving the pc 10 hours), no tty, no logs whatsoever in journalctl as if the kernel didn't start. Even adding 'debug' or 'initcall_debug' doesn't show anything.
If I add acpi=off, the screen blinks one time and boots normally but after kernel 5.10 (5.12 and 5.13) I loose usage of keyboard and touchpad.
Notes:
- I'm using Manjaro KDE
- I have tested with 4.19.198 Vanilla (config file attached) and same thing happened
- setting nomodeset doesn't change anything
- tried every acpi parameters, only =off worked
- Bios was not updated, but the bug persisted after upgrading it
- Acpi issue is recurrent with this pc it seems below 4.11 (https://askubuntu.com/questions/929904/cant-pass-the-acpi-off-problem)
Thank you for your help,
Adrien
This is a note to let you know that I've just added the patch titled
usb: gadget: f_hid: idle uses the highest byte for duration
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.
The patch will show up in the next release of the linux-next tree
(usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the
next -rc kernel release.
If you have any questions about this process, please let me know.
>From fa20bada3f934e3b3e4af4c77e5b518cd5a282e5 Mon Sep 17 00:00:00 2001
From: Maxim Devaev <mdevaev(a)gmail.com>
Date: Tue, 27 Jul 2021 21:58:00 +0300
Subject: usb: gadget: f_hid: idle uses the highest byte for duration
SET_IDLE value must be shifted 8 bits to the right to get duration.
This confirmed by USBCV test.
Fixes: afcff6dc690e ("usb: gadget: f_hid: added GET_IDLE and SET_IDLE handlers")
Cc: stable <stable(a)vger.kernel.org>
Signed-off-by: Maxim Devaev <mdevaev(a)gmail.com>
Link: https://lore.kernel.org/r/20210727185800.43796-1-mdevaev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
---
drivers/usb/gadget/function/f_hid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/function/f_hid.c b/drivers/usb/gadget/function/f_hid.c
index 8d50c8b127fd..bb476e121eae 100644
--- a/drivers/usb/gadget/function/f_hid.c
+++ b/drivers/usb/gadget/function/f_hid.c
@@ -573,7 +573,7 @@ static int hidg_setup(struct usb_function *f,
| HID_REQ_SET_IDLE):
VDBG(cdev, "set_idle\n");
length = 0;
- hidg->idle = value;
+ hidg->idle = value >> 8;
goto respond;
break;
--
2.32.0
I bisected to same suspect acpi commit, though it is in 5.13.1, not 5.13.2.
commit bf155b2eaab40e7d9862ce89ffe2b8a80f86703b (HEAD -> master, refs/patches/master/acpi-resources-add-checks-for)
Author: Hui Wang <hui.wang(a)canonical.com>
Date: Wed Jun 9 10:14:42 2021 +0800
ACPI: resources: Add checks for ACPI IRQ override
[ Upstream commit 0ec4e55e9f571f08970ed115ec0addc691eda613 ]
The laptop keyboard doesn't work on many MEDION notebooks, but the
keyboard works well under Windows and Unix.
...
Thanks,
Ben
On 7/27/21 10:11 AM, pgndev wrote:
> https://lore.kernel.org/regressions/3491db05-3bb4-a2c9-2350-881a77734070@gm…
> <https://urldefense.proofpoint.com/v2/url?u=https-3A__lore.kernel.org_regres…>
>
> On Tue, Jul 27, 2021, 1:06 PM Ben Greear <greearb(a)candelatech.com <mailto:greearb@candelatech.com>> wrote:
>
> On 7/27/21 9:50 AM, pgndev wrote:
> > embedded. checking...
> >
> >
> > iiuc, it's got an i2c. possible a uart is on Irq4 thru the i2c?
> >
> >
> > if so, might wanna take a look here:
> >
> >
> > https://bugzilla.kernel.org/show_bug.cgi?id=213031
> <https://urldefense.proofpoint.com/v2/url?u=https-3A__bugzilla.kernel.org_sh…>
> >
> <https://urldefense.proofpoint.com/v2/url?u=https-3A__bugzilla.kernel.org_sh…>
> >
> >
> >
> > maybe related? at least shares symptoms...
> >
> >
> > ACPI subsystem lead sez in offlist thread re: that
> >
> >
> > "It looks like commit 96b15a0b45182f1c3da5a861196da27000da2e3c needs to
> >
> > be reverted."
>
> I don't see that commit in linus tree nor my stable tree, can you check that hash and also
> show me the commit message and other info so I can track it down?
>
> Thanks,
> Ben
>
>
> --
> Ben Greear <greearb(a)candelatech.com <mailto:greearb@candelatech.com>>
> Candela Technologies Inc http://www.candelatech.com
>
--
Ben Greear <greearb(a)candelatech.com>
Candela Technologies Inc http://www.candelatech.com
The patch titled
Subject: mm: memcontrol: fix blocking rstat function called from atomic cgroup1 thresholding code
has been added to the -mm tree. Its filename is
mm-memcontrol-fix-blocking-rstat-function-called-from-atomic-cgroup1-thresholding-code.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/mm-memcontrol-fix-blocking-rstat-…
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/mm-memcontrol-fix-blocking-rstat-…
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Johannes Weiner <hannes(a)cmpxchg.org>
Subject: mm: memcontrol: fix blocking rstat function called from atomic cgroup1 thresholding code
Dan Carpenter reports:
The patch 2d146aa3aa84: "mm: memcontrol: switch to rstat" from Apr
29, 2021, leads to the following static checker warning:
kernel/cgroup/rstat.c:200 cgroup_rstat_flush()
warn: sleeping in atomic context
mm/memcontrol.c
3572 static unsigned long mem_cgroup_usage(struct mem_cgroup *memcg, bool swap)
3573 {
3574 unsigned long val;
3575
3576 if (mem_cgroup_is_root(memcg)) {
3577 cgroup_rstat_flush(memcg->css.cgroup);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This is from static analysis and potentially a false positive. The
problem is that mem_cgroup_usage() is called from __mem_cgroup_threshold()
which holds an rcu_read_lock(). And the cgroup_rstat_flush() function
can sleep.
3578 val = memcg_page_state(memcg, NR_FILE_PAGES) +
3579 memcg_page_state(memcg, NR_ANON_MAPPED);
3580 if (swap)
3581 val += memcg_page_state(memcg, MEMCG_SWAP);
3582 } else {
3583 if (!swap)
3584 val = page_counter_read(&memcg->memory);
3585 else
3586 val = page_counter_read(&memcg->memsw);
3587 }
3588 return val;
3589 }
__mem_cgroup_threshold() indeed holds the rcu lock. In addition, the
thresholding code is invoked during stat changes, and those contexts have
irqs disabled as well. If the lock breaking occurs inside the flush
function, it will result in a sleep from an atomic context.
Use the irqsafe flushing variant in mem_cgroup_usage() to fix this.
Link: https://lkml.kernel.org/r/20210726150019.251820-1-hannes@cmpxchg.org
Fixes: 2d146aa3aa84 ("mm: memcontrol: switch to rstat")
Signed-off-by: Johannes Weiner <hannes(a)cmpxchg.org>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
Acked-by: Chris Down <chris(a)chrisdown.name>
Reviewed-by: Rik van Riel <riel(a)surriel.com>
Acked-by: Michal Hocko <mhocko(a)suse.com>
Reviewed-by: Shakeel Butt <shakeelb(a)google.com>
Cc: <stable(a)vger.kernel.org>
Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org>
---
mm/memcontrol.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/mm/memcontrol.c~mm-memcontrol-fix-blocking-rstat-function-called-from-atomic-cgroup1-thresholding-code
+++ a/mm/memcontrol.c
@@ -3574,7 +3574,8 @@ static unsigned long mem_cgroup_usage(st
unsigned long val;
if (mem_cgroup_is_root(memcg)) {
- cgroup_rstat_flush(memcg->css.cgroup);
+ /* mem_cgroup_threshold() calls here from irqsafe context */
+ cgroup_rstat_flush_irqsafe(memcg->css.cgroup);
val = memcg_page_state(memcg, NR_FILE_PAGES) +
memcg_page_state(memcg, NR_ANON_MAPPED);
if (swap)
_
Patches currently in -mm which might be from hannes(a)cmpxchg.org are
mm-memcontrol-fix-blocking-rstat-function-called-from-atomic-cgroup1-thresholding-code.patch
mm-remove-irqsave-restore-locking-from-contexts-with-irqs-enabled.patch
fs-drop_caches-fix-skipping-over-shadow-cache-inodes.patch
fs-inode-count-invalidated-shadow-pages-in-pginodesteal.patch
vfs-keep-inodes-with-page-cache-off-the-inode-shrinker-lru.patch