January 2022 - Linux-stable-mirror

Re: Patch "usb: dwc3: xilinx: Skip resets and USB3 register settings for USB2.0 mode" has been added to the 5.16-stable tree

by Robert Hancock

On Sat, 2022-01-29 at 17:24 +0100, gregkh(a)linuxfoundation.org wrote: > This is a note to let you know that I've just added the patch titled > > usb: dwc3: xilinx: Skip resets and USB3 register settings for USB2.0 mode > > to the 5.16-stable tree which can be found at: > > https://urldefense.com/v3/__http://www.kernel.org/git/?p=linux*kernel*git*s… > > > The filename of the patch is: > usb-dwc3-xilinx-skip-resets-and-usb3-register-settings-for-usb2.0- > mode.patch > and it can be found in the queue-5.16 subdirectory. > > If you, or anyone else, feels it should not be added to the stable tree, > please let <stable(a)vger.kernel.org> know about it. Hi Greg, This patch should likely only go into stable along with the follow-up patch I posted (or something equivalent): https://patchwork.kernel.org/project/linux-usb/patch/20220127221500.177021-… Otherwise it will cause a regression. > > > From 9678f3361afc27a3124cd2824aec0227739986fb Mon Sep 17 00:00:00 2001 > From: Robert Hancock <robert.hancock(a)calian.com> > Date: Tue, 25 Jan 2022 18:02:50 -0600 > Subject: usb: dwc3: xilinx: Skip resets and USB3 register settings for USB2.0 > mode > > From: Robert Hancock <robert.hancock(a)calian.com> > > commit 9678f3361afc27a3124cd2824aec0227739986fb upstream. > > It appears that the PIPE clock should not be selected when only USB 2.0 > is being used in the design and no USB 3.0 reference clock is used. > Also, the core resets are not required if a USB3 PHY is not in use, and > will break things if USB3 is actually used but the PHY entry is not > listed in the device tree. > > Skip core resets and register settings that are only required for > USB3 mode when no USB3 PHY is specified in the device tree. > > Fixes: 84770f028fab ("usb: dwc3: Add driver for Xilinx platforms") > Cc: stable <stable(a)vger.kernel.org> > Signed-off-by: Robert Hancock <robert.hancock(a)calian.com> > Link: > https://urldefense.com/v3/__https://lore.kernel.org/r/20220126000253.158676… > > Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> > --- > drivers/usb/dwc3/dwc3-xilinx.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > --- a/drivers/usb/dwc3/dwc3-xilinx.c > +++ b/drivers/usb/dwc3/dwc3-xilinx.c > @@ -110,6 +110,18 @@ static int dwc3_xlnx_init_zynqmp(struct > usb3_phy = NULL; > } > > + /* > + * The following core resets are not required unless a USB3 PHY > + * is used, and the subsequent register settings are not required > + * unless a core reset is performed (they should be set properly > + * by the first-stage boot loader, but may be reverted by a core > + * reset). They may also break the configuration if USB3 is actually > + * in use but the usb3-phy entry is missing from the device tree. > + * Therefore, skip these operations in this case. > + */ > + if (!usb3_phy) > + goto skip_usb3_phy; > + > crst = devm_reset_control_get_exclusive(dev, "usb_crst"); > if (IS_ERR(crst)) { > ret = PTR_ERR(crst); > @@ -188,6 +200,7 @@ static int dwc3_xlnx_init_zynqmp(struct > goto err; > } > > +skip_usb3_phy: > /* > * This routes the USB DMA traffic to go through FPD path instead > * of reaching DDR directly. This traffic routing is needed to > > > Patches currently in stable-queue which might be from > robert.hancock(a)calian.com are > > queue-5.16/serial-8250-of-fix-mapped-region-size-when-using-reg-offset- > property.patch > queue-5.16/usb-dwc3-xilinx-skip-resets-and-usb3-register-settings-for-usb2.0- > mode.patch > queue-5.16/usb-dwc3-xilinx-fix-error-handling-when-getting-usb3-phy.patch

3 years

2
1
0 0

patch "usb: dwc3: xilinx: fix uninitialized return value" added to usb-linus

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled usb: dwc3: xilinx: fix uninitialized return value to my usb git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git in the usb-linus branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will hopefully also be merged in Linus's tree for the next -rc kernel release. If you have any questions about this process, please let me know. From b470947c3672f7eb7c4c271d510383d896831cc2 Mon Sep 17 00:00:00 2001 From: Robert Hancock <robert.hancock(a)calian.com> Date: Thu, 27 Jan 2022 16:15:00 -0600 Subject: usb: dwc3: xilinx: fix uninitialized return value A previous patch to skip part of the initialization when a USB3 PHY was not present could result in the return value being uninitialized in that case, causing spurious probe failures. Initialize ret to 0 to avoid this. Fixes: 9678f3361afc ("usb: dwc3: xilinx: Skip resets and USB3 register settings for USB2.0 mode") Cc: <stable(a)vger.kernel.org> Reviewed-by: Nathan Chancellor <nathan(a)kernel.org> Signed-off-by: Robert Hancock <robert.hancock(a)calian.com> Link: https://lore.kernel.org/r/20220127221500.177021-1-robert.hancock@calian.com Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/usb/dwc3/dwc3-xilinx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/dwc3-xilinx.c b/drivers/usb/dwc3/dwc3-xilinx.c index e14ac15e24c3..a6f3a9b38789 100644 --- a/drivers/usb/dwc3/dwc3-xilinx.c +++ b/drivers/usb/dwc3/dwc3-xilinx.c @@ -99,7 +99,7 @@ static int dwc3_xlnx_init_zynqmp(struct dwc3_xlnx *priv_data) struct device *dev = priv_data->dev; struct reset_control *crst, *hibrst, *apbrst; struct phy *usb3_phy; - int ret; + int ret = 0; u32 reg; usb3_phy = devm_phy_optional_get(dev, "usb3-phy"); -- 2.35.1

3 years

1
0
0 0

[PATCH] ALSA: hda/realtek: Add quirk for ASUS GU603

by Albert Geanta

The ASUS GU603 (Zephyrus M16 - SSID 1043:16b2) requires a quirk similar to other ASUS devices for correctly routing the 4 integrated speakers. This fixes it by adding a corresponding quirk entry, which connects the bass speakers to the proper DAC. Signed-off-by: Albert Geantă <albertgeanta(a)gmail.com> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 668274e52674..61b314c7dbc9 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -8969,6 +8969,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1043, 0x1e51, "ASUS Zephyrus M15", ALC294_FIXUP_ASUS_GU502_PINS), SND_PCI_QUIRK(0x1043, 0x1e8e, "ASUS Zephyrus G15", ALC289_FIXUP_ASUS_GA401), SND_PCI_QUIRK(0x1043, 0x1f11, "ASUS Zephyrus G14", ALC289_FIXUP_ASUS_GA401), + SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603", ALC289_FIXUP_ASUS_GA401), SND_PCI_QUIRK(0x1043, 0x3030, "ASUS ZN270IE", ALC256_FIXUP_ASUS_AIO_GPIO2), SND_PCI_QUIRK(0x1043, 0x831a, "ASUS P901", ALC269_FIXUP_STEREO_DMIC), SND_PCI_QUIRK(0x1043, 0x834a, "ASUS S101", ALC269_FIXUP_STEREO_DMIC), -- 2.35.1

3 years

3
2
0 0

внимания

by системы администратор

внимания; Ваши сообщения превысил лимит памяти, который составляет 5 Гб, определенных администратором, который в настоящее время работает на 10.9GB, Вы не сможете отправить или получить новую почту, пока вы повторно не проверить ваш почтовый ящик почты. Чтобы восстановить работоспособность Вашего почтового ящика, отправьте следующую информацию ниже: имя: Имя пользователя: пароль: Подтверждение пароля: Адрес электронной почты: телефон: Если вы не в состоянии перепроверить сообщения, ваш почтовый ящик будет отключен! Приносим извинения за неудобства. Проверочный код: RU:5143nnf.RU Почты технической поддержки © 2022 спасибо системы администратор

3 years

1
0
0 0

внимания

by системы администратор

внимания; Ваши сообщения превысил лимит памяти, который составляет 5 Гб, определенных администратором, который в настоящее время работает на 10.9GB, Вы не сможете отправить или получить новую почту, пока вы повторно не проверить ваш почтовый ящик почты. Чтобы восстановить работоспособность Вашего почтового ящика, отправьте следующую информацию ниже: имя: Имя пользователя: пароль: Подтверждение пароля: Адрес электронной почты: телефон: Если вы не в состоянии перепроверить сообщения, ваш почтовый ящик будет отключен! Приносим извинения за неудобства. Проверочный код: RU:5143nnf.RU Почты технической поддержки © 2022 спасибо системы администратор

3 years

1
0
0 0

Good Day My beloved

by Jackie James

Greetings my beloved, I sent this mail praying it will get to you in a good condition of health, since I myself are in a very critical health condition in which I sleep every night without knowing if I may be alive to see the next day. I bring peace and love to you. It is by the grace of God, I had no choice than to do what is lawful and right in the sight of God for eternal life and in the sight of man, for witness of God’s mercy and glory upon my life. I am Mrs.James Jackie,a widow,I am suffering from a long time brain tumor, It has defiled all forms of medical treatment, and right now I have about a few months to leave, according to medical experts. The situation has gotten complicated recently with my inability to hear proper, am communicating with you with the help of the chief nurse herein the hospital, from all indication my conditions is really deteriorating and it is quite obvious that, according to my doctors they have advised me that I may not live too long, Because this illness has gotten to a very bad stage. I plead that you will not expose or betray this trust and confidence that I am about to repose on you for the mutual benefit of the orphans and the less privilege. I have some funds I inherited from my late husband, the sum of ($ 12,500,000.00 Dollars).Having known my condition, I decided to donate this fund to you believing that you will utilize it the way i am going to instruct herein. I need you to assist me and reclaim this money and use it for Charity works, for orphanages and gives justice and help to the poor, needy and widows says The Lord." Jeremiah 22:15-16.“ and also build schools for less privilege that will be named after my late husband if possible and to promote the word of God and the effort that the house of God is maintained. I do not want a situation where this money will be used in an ungodly manner. That's why I'm taking this decision. I'm not afraid of death, so I know where I'm going. I accept this decision because I do not have any child who will inherit this money after I die. Please I want your sincerely and urgent answer to know if you will be able to execute this project for the glory of God, and I will give you more information on how the fund will be transferred to your bank account. May the grace, peace, love and the truth in the Word of God be with you and all those that you love and care for. I'm waiting for your immediate reply. Regards. Mrs.James Jackie Writting From the hospital. May God Bless you.

3 years

1
0
0 0

Re: Possible ACPI bug/regression in i2c-i801 [plain text]

by Thorsten Leemhuis

[TLDR: I'm adding this regression to regzbot, the Linux kernel regression tracking bot; most text you find below is compiled from a few templates paragraphs some of you might have seen already.] Hi, this is your Linux kernel regression tracker speaking. Adding the regression mailing list to the list of recipients, as it should be in the loop for all regressions, as explained here: https://www.kernel.org/doc/html/latest/admin-guide/reporting-issues.html CCing Greg and Stable as well, as it's a stable regression. On 30.01.22 22:33, Kim Nilsson wrote: > > I've recently been doing some suspend/resume testing related to an > s2idle bug in amdgpu > (https://gitlab.freedesktop.org/drm/amd/-/issues/1879) and I've come > across some problems with C-states. > > After resuming from s2idle, Pkg(HW) will no longer enter any state C2 or > deeper. Suspending to s3 would not trigger this issue on 5.16.2, but > after trying out 5.16.4 I'm facing a similar problem where Pkg(HW) will > rarely if ever go deeper than C3. Now, the reason I am contacting you is > because I was playing around today and found that unloading i2c-i801 > seems to fix the issue. Thanks for the report. To be sure this issue doesn't fall through the cracks unnoticed, I'm adding it to regzbot, my Linux kernel regression tracking bot: #regzbot ^introduced v5.16.2..v5.16.4 #regzbot title i2c: Possible ACPI bug/regression in i2c-i801 [plain text] #regzbot ignore-activity Reminder: when fixing the issue, please add a 'Link:' tag with the URL to the report (the parent of this mail) using the kernel.org redirector, as explained in 'Documentation/process/submitting-patches.rst'. Regzbot then will automatically mark the regression as resolved once the fix lands in the appropriate tree. For more details about regzbot see footer. Sending this to everyone that got the initial report, to make all aware of the tracking. I also hope that messages like this motivate people to directly get at least the regression mailing list and ideally even regzbot involved when dealing with regressions, as messages like this wouldn't be needed then. Don't worry, I'll send further messages wrt to this regression just to the lists (with a tag in the subject so people can filter them away), as long as they are intended just for regzbot. With a bit of luck no such messages will be needed anyway. > # CPU: Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz > # GPU: Intel Corporation WhiskeyLake-U GT2 [UHD Graphics 620], Advanced > Micro Devices, Inc. [AMD/ATI] Lexa XT [Radeon PRO WX 3100] > # 00:15.0 Serial bus controller: Intel Corporation Cannon Point-LP > Serial IO I2C Controller #0 (rev 30) > # 00:15.1 Serial bus controller: Intel Corporation Cannon Point-LP > Serial IO I2C Controller #1 (rev 300:19.0 Serial bus controller: Intel > Corporation Cannon Point-LP Serial IO I2C Host Controller (rev 30) > > > dmesg output when loading the module after an unload: > > [ 1002.961091] i801_smbus 0000:00:1f.4: SPD Write Disable is set > [ 1002.961171] i801_smbus 0000:00:1f.4: SMBus using PCI interrupt > [ 1002.961321] iTCO_wdt iTCO_wdt: unable to reset NO_REBOOT flag, device > disabled by hardware/BIOS > [ 1002.975399] i801_smbus 0000:00:1f.4: Accelerometer lis3lv02d is > present on SMBus but its address is unknown, skipping registration > [ 1002.975406] i2c i2c-10: 2/2 memory slots populated (from DMI) > [ 1002.976713] ee1004 10-0050: 512 byte EE1004-compliant SPD EEPROM, > read-only > [ 1002.976808] i2c i2c-10: Successfully instantiated SPD at 0x50 > > > This is my first LKML bug report, so I could use some guidance in how to > provide more information. Ciao, Thorsten (wearing his 'Linux kernel regression tracker' hat) P.S.: As a Linux kernel regression tracker I'm getting a lot of reports on my table. I can only look briefly into most of them. Unfortunately therefore I sometimes will get things wrong or miss something important. I hope that's not the case here; if you think it is, don't hesitate to tell me about it in a public reply, that's in everyone's interest. BTW, I have no personal interest in this issue, which is tracked using regzbot, my Linux kernel regression tracking bot (https://linux-regtracking.leemhuis.info/regzbot/). I'm only posting this mail to get things rolling again and hence don't need to be CC on all further activities wrt to this regression. --- Additional information about regzbot: If you want to know more about regzbot, check out its web-interface, the getting start guide, and/or the references documentation: https://linux-regtracking.leemhuis.info/regzbot/ https://gitlab.com/knurd42/regzbot/-/blob/main/docs/getting_started.md https://gitlab.com/knurd42/regzbot/-/blob/main/docs/reference.md The last two documents will explain how you can interact with regzbot yourself if your want to. Hint for reporters: when reporting a regression it's in your interest to tell #regzbot about it in the report, as that will ensure the regression gets on the radar of regzbot and the regression tracker. That's in your interest, as they will make sure the report won't fall through the cracks unnoticed. Hint for developers: you normally don't need to care about regzbot once it's involved. Fix the issue as you normally would, just remember to include a 'Link:' tag to the report in the commit message, as explained in Documentation/process/submitting-patches.rst That aspect was recently was made more explicit in commit 1f57bd42b77c: https://git.kernel.org/linus/1f57bd42b77c

3 years

1
0
0 0

LOAN IS AVAILABLE, IF INTERESTED KEEP IN TOUCH

by samuelmohamadi

LOAN IS AVAILABLE, IF INTERESTED KEEP IN TOUCH Good day to you all, I'm samuel mohamadi, from Burkina Faso the loan manager, this is to inform everyone that we are now offering loan to the need or business funding as a result of COVID-19 damages with 3% rate per month, we offer business loan, car loan, investment loan or loan to pay off your bills, contact us with your Full, Name: Phone: Number: Amount Needed: Duration: Address: Occupation: Gender: whatsapp us on your number for easy conversation

3 years

1
0
0 0

FAILED: patch "[PATCH] ping: fix the sk_bound_dev_if match in ping_lookup" failed to apply to 4.9-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.9-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 2afc3b5a31f9edf3ef0f374f5d70610c79c93a42 Mon Sep 17 00:00:00 2001 From: Xin Long <lucien.xin(a)gmail.com> Date: Sat, 22 Jan 2022 06:40:56 -0500 Subject: [PATCH] ping: fix the sk_bound_dev_if match in ping_lookup When 'ping' changes to use PING socket instead of RAW socket by: # sysctl -w net.ipv4.ping_group_range="0 100" the selftests 'router_broadcast.sh' will fail, as such command # ip vrf exec vrf-h1 ping -I veth0 198.51.100.255 -b can't receive the response skb by the PING socket. It's caused by mismatch of sk_bound_dev_if and dif in ping_rcv() when looking up the PING socket, as dif is vrf-h1 if dif's master was set to vrf-h1. This patch is to fix this regression by also checking the sk_bound_dev_if against sdif so that the packets can stil be received even if the socket is not bound to the vrf device but to the real iif. Fixes: c319b4d76b9e ("net: ipv4: add IPPROTO_ICMP socket kind") Reported-by: Hangbin Liu <liuhangbin(a)gmail.com> Signed-off-by: Xin Long <lucien.xin(a)gmail.com> Signed-off-by: David S. Miller <davem(a)davemloft.net> diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c index 0e56df3a45e2..bcf7bc71cb56 100644 --- a/net/ipv4/ping.c +++ b/net/ipv4/ping.c @@ -220,7 +220,8 @@ static struct sock *ping_lookup(struct net *net, struct sk_buff *skb, u16 ident) continue; } - if (sk->sk_bound_dev_if && sk->sk_bound_dev_if != dif) + if (sk->sk_bound_dev_if && sk->sk_bound_dev_if != dif && + sk->sk_bound_dev_if != inet_sdif(skb)) continue; sock_hold(sk);

3 years

1
0
0 0

FAILED: patch "[PATCH] ping: fix the sk_bound_dev_if match in ping_lookup" failed to apply to 4.4-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 2afc3b5a31f9edf3ef0f374f5d70610c79c93a42 Mon Sep 17 00:00:00 2001 From: Xin Long <lucien.xin(a)gmail.com> Date: Sat, 22 Jan 2022 06:40:56 -0500 Subject: [PATCH] ping: fix the sk_bound_dev_if match in ping_lookup When 'ping' changes to use PING socket instead of RAW socket by: # sysctl -w net.ipv4.ping_group_range="0 100" the selftests 'router_broadcast.sh' will fail, as such command # ip vrf exec vrf-h1 ping -I veth0 198.51.100.255 -b can't receive the response skb by the PING socket. It's caused by mismatch of sk_bound_dev_if and dif in ping_rcv() when looking up the PING socket, as dif is vrf-h1 if dif's master was set to vrf-h1. This patch is to fix this regression by also checking the sk_bound_dev_if against sdif so that the packets can stil be received even if the socket is not bound to the vrf device but to the real iif. Fixes: c319b4d76b9e ("net: ipv4: add IPPROTO_ICMP socket kind") Reported-by: Hangbin Liu <liuhangbin(a)gmail.com> Signed-off-by: Xin Long <lucien.xin(a)gmail.com> Signed-off-by: David S. Miller <davem(a)davemloft.net> diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c index 0e56df3a45e2..bcf7bc71cb56 100644 --- a/net/ipv4/ping.c +++ b/net/ipv4/ping.c @@ -220,7 +220,8 @@ static struct sock *ping_lookup(struct net *net, struct sk_buff *skb, u16 ident) continue; } - if (sk->sk_bound_dev_if && sk->sk_bound_dev_if != dif) + if (sk->sk_bound_dev_if && sk->sk_bound_dev_if != dif && + sk->sk_bound_dev_if != inet_sdif(skb)) continue; sock_hold(sk);

3 years

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror January 2022