September 2022 - Linux-stable-mirror

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.15.69 release. There are 35 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sun, 18 Sep 2022 10:04:31 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.69-rc… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 5.15.69-rc1 Jarrah Gosbell <kernel(a)undef.tools> Input: goodix - add compatible string for GT1158 Sindhu-Devale <sindhu.devale(a)intel.com> RDMA/irdma: Use s/g array in post send only when its valid Jing Leng <jleng(a)ambarella.com> usb: gadget: f_uac2: fix superspeed transfer Colin Ian King <colin.king(a)canonical.com> usb: gadget: f_uac2: clean up some inconsistent indenting Mathew McBride <matt(a)traverse.com.au> soc: fsl: select FSL_GUTS driver for DPIO Jann Horn <jannh(a)google.com> mm: Fix TLB flush for not-first PFNMAP mappings in unmap_region() Hu Xiaoying <huxiaoying(a)kylinos.cn> usb: storage: Add ASUS <0x0b05:0x1932> to IGNORE_UAS Hans de Goede <hdegoede(a)redhat.com> platform/x86: acer-wmi: Acer Aspire One AOD270/Packard Bell Dot keymap fixes Yu Zhe <yuzhe(a)nfschina.com> perf/arm_pmu_platform: fix tests for platform_get_irq() failure Kurt Kanzenbach <kurt(a)linutronix.de> net: dsa: hellcreek: Print warning only once Chengming Gui <Jack.Gui(a)amd.com> drm/amd/amdgpu: skip ucode loading if ucode_size == 0 Maurizio Lombardi <mlombard(a)redhat.com> nvmet-tcp: fix unhandled tcp states in nvmet_tcp_state_change() Greg Tulli <greg.iforce(a)gmail.com> Input: iforce - add support for Boeder Force Feedback Wheel Li Qiong <liqiong(a)nfschina.com> ieee802154: cc2520: add rc code in cc2520_tx() Wei Yongjun <weiyongjun1(a)huawei.com> gpio: mockup: remove gpio debugfs when remove device Kai-Heng Feng <kai.heng.feng(a)canonical.com> tg3: Disable tg3 device on system reboot to avoid triggering AER Even Xu <even.xu(a)intel.com> hid: intel-ish-hid: ishtp: Fix ishtp client sending disordered message Jason Wang <wangborong(a)cdjrlc.com> HID: ishtp-hid-clientHID: ishtp-hid-client: Fix comment typo Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> dt-bindings: iio: gyroscope: bosch,bmg160: correct number of pins Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> hwmon: (pmbus) Use dev_err_probe() to filter -EPROBE_DEFER error messages Rob Clark <robdclark(a)chromium.org> drm/msm/rd: Fix FIFO-full deadlock Maximilian Luz <luzmaximilian(a)gmail.com> platform/surface: aggregator_registry: Add support for Surface Laptop Go 2 Ondrej Jirman <megi(a)xff.cz> Input: goodix - add support for GT1158 Lu Baolu <baolu.lu(a)linux.intel.com> iommu/vt-d: Fix kdump kernels boot failure with scalable mode Brian Norris <briannorris(a)chromium.org> tracefs: Only clobber mode/uid/gid on remount if asked Yipeng Zou <zouyipeng(a)huawei.com> tracing: hold caller_addr to hardirq_{enable,disable}_ip Borislav Petkov <bp(a)suse.de> task_stack, x86/cea: Force-inline stack helpers Borislav Petkov <bp(a)suse.de> x86/mm: Force-inline __phys_addr_nodebug() Nick Desaulniers <ndesaulniers(a)google.com> lockdep: Fix -Wunused-parameter for _THIS_IP_ Claudiu Beznea <claudiu.beznea(a)microchip.com> ARM: dts: at91: sama7g5ek: specify proper regulator output ranges Claudiu Beznea <claudiu.beznea(a)microchip.com> ARM: dts: at91: fix low limit for CPU regulator Marco Felsch <m.felsch(a)pengutronix.de> ARM: dts: imx6qdl-kontron-samx6i: fix spi-flash compatible Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> ARM: dts: imx: align SPI NOR node name with dtschema Chuanhong Guo <gch981213(a)gmail.com> ACPI: resource: skip IRQ override on AMD Zen platforms Dave Wysochanski <dwysocha(a)redhat.com> NFS: Fix WARN_ON due to unionization of nfs_inode.nrequests ------------- Diffstat: .../bindings/iio/gyroscope/bosch,bmg160.yaml | 2 + Documentation/input/joydev/joystick.rst | 1 + Makefile | 4 +- arch/arm/boot/dts/at91-sama7g5ek.dts | 20 ++--- arch/arm/boot/dts/imx28-evk.dts | 2 +- arch/arm/boot/dts/imx28-m28evk.dts | 2 +- arch/arm/boot/dts/imx28-sps1.dts | 2 +- arch/arm/boot/dts/imx6dl-rex-basic.dts | 2 +- arch/arm/boot/dts/imx6q-ba16.dtsi | 2 +- arch/arm/boot/dts/imx6q-bx50v3.dtsi | 2 +- arch/arm/boot/dts/imx6q-cm-fx6.dts | 2 +- arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts | 2 +- arch/arm/boot/dts/imx6q-dms-ba16.dts | 2 +- arch/arm/boot/dts/imx6q-gw5400-a.dts | 2 +- arch/arm/boot/dts/imx6q-marsboard.dts | 2 +- arch/arm/boot/dts/imx6q-rex-pro.dts | 2 +- arch/arm/boot/dts/imx6qdl-aristainetos.dtsi | 2 +- arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi | 2 +- arch/arm/boot/dts/imx6qdl-dfi-fs700-m60.dtsi | 2 +- arch/arm/boot/dts/imx6qdl-kontron-samx6i.dtsi | 4 +- arch/arm/boot/dts/imx6qdl-nit6xlite.dtsi | 2 +- arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi | 2 +- arch/arm/boot/dts/imx6qdl-nitrogen6_som2.dtsi | 2 +- arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 2 +- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 2 +- arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 2 +- arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 2 +- arch/arm/boot/dts/imx6sl-evk.dts | 2 +- arch/arm/boot/dts/imx6sx-nitrogen6sx.dts | 2 +- arch/arm/boot/dts/imx6sx-sdb-reva.dts | 4 +- arch/arm/boot/dts/imx6sx-sdb.dts | 4 +- arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 2 +- arch/arm/boot/dts/imx6ul-kontron-n6310-som.dtsi | 2 +- arch/arm/boot/dts/imx6ul-kontron-n6311-som.dtsi | 2 +- .../boot/dts/imx6ul-kontron-n6x1x-som-common.dtsi | 2 +- arch/arm/boot/dts/imx6ull-kontron-n6411-som.dtsi | 2 +- arch/arm64/kernel/entry-common.c | 8 +- arch/x86/include/asm/cpu_entry_area.h | 2 +- arch/x86/include/asm/page_64.h | 2 +- arch/x86/kvm/x86.h | 2 +- drivers/acpi/resource.c | 10 +++ drivers/gpio/gpio-mockup.c | 9 +- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +- drivers/gpu/drm/msm/msm_rd.c | 3 + drivers/hid/intel-ish-hid/ishtp-hid.h | 2 +- drivers/hid/intel-ish-hid/ishtp/client.c | 68 ++++++++------ drivers/hwmon/pmbus/pmbus_core.c | 9 +- drivers/infiniband/hw/irdma/uk.c | 3 +- drivers/input/joystick/iforce/iforce-main.c | 1 + drivers/input/touchscreen/goodix.c | 2 + drivers/iommu/intel/iommu.c | 100 +++++++++------------ drivers/net/ethernet/broadcom/tg3.c | 8 +- drivers/net/ieee802154/cc2520.c | 1 + drivers/nvme/target/tcp.c | 3 + drivers/perf/arm_pmu_platform.c | 2 +- .../platform/surface/surface_aggregator_registry.c | 3 + drivers/platform/x86/acer-wmi.c | 9 +- drivers/soc/fsl/Kconfig | 1 + drivers/usb/gadget/function/f_uac2.c | 30 +++++-- drivers/usb/storage/unusual_uas.h | 7 ++ fs/tracefs/inode.c | 31 +++++-- include/linux/intel-iommu.h | 9 +- include/linux/irqflags.h | 4 +- include/linux/kvm_host.h | 2 +- include/linux/nfs_fs.h | 4 +- include/linux/sched/task_stack.h | 2 +- kernel/entry/common.c | 6 +- kernel/locking/lockdep.c | 22 ++--- kernel/sched/idle.c | 2 +- kernel/trace/trace_preemptirq.c | 8 +- mm/mmap.c | 9 +- net/dsa/tag_hellcreek.c | 2 +- 72 files changed, 283 insertions(+), 202 deletions(-)

2 years, 1 month

7
41
0 0

[PATCH 5.4 00/14] 5.4.214-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.4.214 release. There are 14 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sun, 18 Sep 2022 10:04:31 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.214-rc… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 5.4.214-rc1 Brian Norris <briannorris(a)chromium.org> tracefs: Only clobber mode/uid/gid on remount if asked Mathew McBride <matt(a)traverse.com.au> soc: fsl: select FSL_GUTS driver for DPIO Enguerrand de Ribaucourt <enguerrand.de-ribaucourt(a)savoirfairelinux.com> net: dp83822: disable rx error interrupt Jann Horn <jannh(a)google.com> mm: Fix TLB flush for not-first PFNMAP mappings in unmap_region() Hu Xiaoying <huxiaoying(a)kylinos.cn> usb: storage: Add ASUS <0x0b05:0x1932> to IGNORE_UAS Hans de Goede <hdegoede(a)redhat.com> platform/x86: acer-wmi: Acer Aspire One AOD270/Packard Bell Dot keymap fixes Yu Zhe <yuzhe(a)nfschina.com> perf/arm_pmu_platform: fix tests for platform_get_irq() failure Maurizio Lombardi <mlombard(a)redhat.com> nvmet-tcp: fix unhandled tcp states in nvmet_tcp_state_change() Greg Tulli <greg.iforce(a)gmail.com> Input: iforce - add support for Boeder Force Feedback Wheel Li Qiong <liqiong(a)nfschina.com> ieee802154: cc2520: add rc code in cc2520_tx() Kai-Heng Feng <kai.heng.feng(a)canonical.com> tg3: Disable tg3 device on system reboot to avoid triggering AER Even Xu <even.xu(a)intel.com> hid: intel-ish-hid: ishtp: Fix ishtp client sending disordered message Jason Wang <wangborong(a)cdjrlc.com> HID: ishtp-hid-clientHID: ishtp-hid-client: Fix comment typo Rob Clark <robdclark(a)chromium.org> drm/msm/rd: Fix FIFO-full deadlock ------------- Diffstat: Documentation/input/joydev/joystick.rst | 1 + Makefile | 4 +- drivers/gpu/drm/msm/msm_rd.c | 3 ++ drivers/hid/intel-ish-hid/ishtp-hid.h | 2 +- drivers/hid/intel-ish-hid/ishtp/client.c | 68 +++++++++++++++++------------ drivers/input/joystick/iforce/iforce-main.c | 1 + drivers/net/ethernet/broadcom/tg3.c | 8 +++- drivers/net/ieee802154/cc2520.c | 1 + drivers/net/phy/dp83822.c | 3 +- drivers/nvme/target/tcp.c | 3 ++ drivers/perf/arm_pmu_platform.c | 2 +- drivers/platform/x86/acer-wmi.c | 9 +++- drivers/soc/fsl/Kconfig | 1 + drivers/usb/storage/unusual_uas.h | 7 +++ fs/tracefs/inode.c | 31 +++++++++---- mm/mmap.c | 9 +++- 16 files changed, 105 insertions(+), 48 deletions(-)

2 years, 1 month

5
18
0 0

[PATCH 01/12] efi: libstub: drop pointless get_memory_map() call

by Ard Biesheuvel

Currently, the non-x86 stub code calls get_memory_map() redundantly, given that the data it returns is never used anywhere. So drop the call. Cc: <stable(a)vger.kernel.org> # v4.14+ Fixes: 24d7c494ce46 ("efi/arm-stub: Round up FDT allocation to mapping size") Signed-off-by: Ard Biesheuvel <ardb(a)kernel.org> --- drivers/firmware/efi/libstub/fdt.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/firmware/efi/libstub/fdt.c b/drivers/firmware/efi/libstub/fdt.c index fe567be0f118..804f542be3f2 100644 --- a/drivers/firmware/efi/libstub/fdt.c +++ b/drivers/firmware/efi/libstub/fdt.c @@ -280,14 +280,6 @@ efi_status_t allocate_new_fdt_and_exit_boot(void *handle, goto fail; } - /* - * Now that we have done our final memory allocation (and free) - * we can get the memory map key needed for exit_boot_services(). - */ - status = efi_get_memory_map(&map); - if (status != EFI_SUCCESS) - goto fail_free_new_fdt; - status = update_fdt((void *)fdt_addr, fdt_size, (void *)*new_fdt_addr, MAX_FDT_SIZE, cmdline_ptr, initrd_addr, initrd_size); -- 2.35.1

2 years, 1 month

1
0
0 0

AM READY TO WORK WITH YOU!

by Hassan Said Bin Hassan

Hello Dear , I am Hassan Said Bin Hassan a financial consultant and a registered agent with Top loan and investment companies in Asia, Africa, Europe and America . I am consulting for them on commission bases and also have agreement to source for clients that need funds to finance their business or need partners or joint venture business relationship. I am sourcing for companies, individual that need investors or loan to finance their business. With my position, you can have access to a soft loan for funding your business. Soft loan usually allows time enough for repayment and also at relatively low interest rate. Kindly indicate your interest to enable me to introduce you to the company for processing of your loan within a few days with my support. More details will be sent to you as soon as you indicate your interest in your next response. Thanks, Hassan Said Bin Hassan binhassanhassansaid(a)gmail.com

2 years, 1 month

1
0
0 0

[PATCH] phy: rockchip-inno-usb2: Fix otg port initialization

by Mikhail Rudenko

There are two issues in rockchip_usb2phy_otg_port_init(): (1) even if devm_extcon_register_notifier() returns error, the code proceeds to the next if statement and (2) if no extcon is defined in of_node, the return value of property_enabled() is reused as the return value of the whole function. If the return value of property_enable() is nonzero, (2) results in an unexpected probe failure and kernel panic in delayed work: Unable to handle kernel NULL pointer dereference at virtual address 00000000 Mem abort info: ESR = 0x0000000086000006 EC = 0x21: IABT (current EL), IL = 32 bits SET = 0, FnV = 0 EA = 0, S1PTW = 0 FSC = 0x06: level 2 translation fault user pgtable: 4k pages, 48-bit VAs, pgdp=00000000019dc000 [0000000000000000] pgd=080000000131a003, p4d=080000000131a003, pud=080000000 Internal error: Oops: 86000006 [#1] PREEMPT SMP Modules linked in: ipv6 CPU: 1 PID: 0 Comm: swapper/1 Not tainted 6.0.0-rc5 #114 Hardware name: FriendlyElec NanoPi M4 (DT) pstate: 20000005 (nzCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) pc : 0x0 lr : call_timer_fn.constprop.0+0x24/0x80 sp : ffff80000a40ba40 x29: ffff80000a40ba40 x28: 0000000000000000 x27: ffff80000a40baf0 x26: ffff800009e779c0 x25: ffff00007fb28070 x24: ffff00007fb28028 x23: ffff80000a40baf0 x22: 0000000000000000 x21: 0000000000000101 x20: ffff0000006ad880 x19: 0000000000000000 x18: 0000000000000006 x17: ffff8000761af000 x16: ffff80000800c000 x15: 0000000000004000 x14: ffff0000006ad880 x13: 000000000000030a x12: 0000000000000000 x11: ffff8000761af000 x10: ffff80000800bf40 x9 : ffff00007fb2d038 x8 : 0000000000000001 x7 : 0000000000000009 x6 : 0000000000000240 x5 : 0000000000000000 x4 : 0000000000000000 x3 : 0000000000000200 x2 : 000000003fffffff x1 : 0000000000000000 x0 : ffff0000016c9710 Call trace: 0x0 __run_timers+0x220/0x264 run_timer_softirq+0x20/0x40 __do_softirq+0x10c/0x298 __irq_exit_rcu+0xec/0xf4 irq_exit_rcu+0x10/0x1c el1_interrupt+0x38/0x70 el1h_64_irq_handler+0x18/0x24 el1h_64_irq+0x64/0x68 cpuidle_enter_state+0x130/0x2fc cpuidle_enter+0x38/0x50 do_idle+0x22c/0x2c0 cpu_startup_entry+0x24/0x30 secondary_start_kernel+0x130/0x14c __secondary_switched+0xb0/0xb4 Code: bad PC value ---[ end trace 0000000000000000 ]--- Kernel panic - not syncing: Oops: Fatal exception in interrupt SMP: stopping secondary CPUs Kernel Offset: disabled CPU features: 0x4000,0820b021,00001086 Memory Limit: none ---[ end Kernel panic - not syncing: Oops: Fatal exception in interrupt ]--- Refactor the control flow to avoid both issues. Since the code below out: label does no cleanup, return error codes immediately instead of using gotos and return success at the end of the function. Cc: stable(a)vger.kernel.org Fixes: 8dc60f8da22f ("phy: rockchip-inno-usb2: Sync initial otg state") Signed-off-by: Mikhail Rudenko <mike.rudenko(a)gmail.com> --- drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c index 0b1e9337ee8e..d31b35d55927 100644 --- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c +++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c @@ -1144,8 +1144,7 @@ static int rockchip_usb2phy_otg_port_init(struct rockchip_usb2phy *rphy, rport->mode = of_usb_get_dr_mode_by_phy(child_np, -1); if (rport->mode == USB_DR_MODE_HOST || rport->mode == USB_DR_MODE_UNKNOWN) { - ret = 0; - goto out; + return 0; } INIT_DELAYED_WORK(&rport->chg_work, rockchip_chg_detect_work); @@ -1154,7 +1153,7 @@ static int rockchip_usb2phy_otg_port_init(struct rockchip_usb2phy *rphy, ret = rockchip_usb2phy_port_irq_init(rphy, rport, child_np); if (ret) { dev_err(rphy->dev, "failed to init irq for host port\n"); - goto out; + return ret; } if (!IS_ERR(rphy->edev)) { @@ -1162,8 +1161,10 @@ static int rockchip_usb2phy_otg_port_init(struct rockchip_usb2phy *rphy, ret = devm_extcon_register_notifier(rphy->dev, rphy->edev, EXTCON_USB_HOST, &rport->event_nb); - if (ret) + if (ret) { dev_err(rphy->dev, "register USB HOST notifier failed\n"); + return ret; + } if (!of_property_read_bool(rphy->dev->of_node, "extcon")) { /* do initial sync of usb state */ @@ -1172,8 +1173,7 @@ static int rockchip_usb2phy_otg_port_init(struct rockchip_usb2phy *rphy, } } -out: - return ret; + return 0; } static int rockchip_usb2phy_probe(struct platform_device *pdev) -- 2.37.3

2 years, 1 month

2
2
0 0

Hello!

by Mrs.Yu Ging

I am Mrs Yu. Ging Yunnan, and i have Covid-19 and the doctor said I will not survive it because all vaccines has been given to me but to no avian, am a China woman but I base here in France because am married here and I have no child for my late husband and now am a widow. My reason of communicating you is that i have $9.2million USD which was deposited in BNP Paribas Bank here in France by my late husband which am the next of kin to and I want you to stand as the beneficiary for the claim now that am about to end my race according to my doctor.I will want you to use the fund to build an orphanage home in my name there in country, please kindly reply to this message urgently if willing to handle this project. God bless you and i wait your swift response asap. Mrs.Yunnan Ging.

2 years, 1 month

1
0
0 0

[PATCH v8 0/2] iio: pressure: dps310: Reset chip if MEAS_CFG is corrupt

by Eddie James

The DPS310 chip has been observed to get "stuck" such that pressure and temperature measurements are never indicated as "ready" in the MEAS_CFG register. The only solution is to reset the device and try again. In order to avoid continual failures, use a boolean flag to only try the reset after timeout once if errors persist. Include a patch to move the startup procedure into a function. Changes since v7: - Condense the code a bit by dropping rc2 Changes since v6: - Use helper instead of the lengthy regmap_read_poll_timeout twice - Just return dps310_startup in dps310_reset_reinit Changes since v5: - Completely rework the second patch to reset and reinit in any timeout condition, if there haven't been previous timeouts that failed to recover the chip. Changes since v4: - Just check for rc rather than rc < 0 in some cases - Split declaration and init of rc Changes since v3: - Don't check regmap* return codes for < 0 - Fix comment spelling Changes since v2: - Add some comments - Fix the clunky control flow Changes since v1: - Separate into two patches - Rename 'dps310_verify_meas_cfg' to 'dps310_check_reset_meas_cfg' Eddie James (2): iio: pressure: dps310: Refactor startup procedure iio: pressure: dps310: Reset chip after timeout drivers/iio/pressure/dps310.c | 262 +++++++++++++++++++++------------- 1 file changed, 163 insertions(+), 99 deletions(-) -- 2.31.1

2 years, 1 month

4
5
0 0

Hi

by Emerald Johansson

I hope that you are at your best and doing well. The purpose of this letter is seeking for a pen pal like friendship and I'd love to and be honored to be friends with you if you do not mind.. If the Idea sounds OK with you, just say yes and we can take it on from there. I look forward to hear hearing from you.. My name is Emerald From Sweden 36 years , this will mean a lot to me to hear back from you. Warm Regards. Emerald * *** ***** ]+[ << Please consider the environment before printing this email >> UCHI OPTOELECTRONIC (M) SDN. BHD. Website : www.uchi.net This e-mail and any files transmitted with it contain confidential and/or privileged information and intended solely for the use of the individual or entity to whom they are addressed. If you are not the intended recipient (or have received this e-mail in error),please notify the sender immediately and destroy this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e-mail is strictly forbidden. Please note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of the organization. Finally, the recipient should check this email and any attachments for the presence of viruses. The organization accepts no liability for any damage caused by any virus transmitted by this email.

2 years, 1 month

1
0
0 0

[RESEND][PATCH v2] PCI: Sanitise firmware BAR assignments behind a PCI-PCI bridge

by Maciej W. Rozycki

Fix an issue with the Tyan Tomcat IV S1564D system, the BIOS of which does not assign PCI buses beyond #2, where our resource reallocation code preserves the reset default of an I/O BAR assignment outside its upstream PCI-to-PCI bridge's I/O forwarding range for device 06:08.0 in this log: pci_bus 0000:00: max bus depth: 4 pci_try_num: 5 [...] pci 0000:06:08.0: BAR 4: no space for [io size 0x0020] pci 0000:06:08.0: BAR 4: trying firmware assignment [io 0xfce0-0xfcff] pci 0000:06:08.0: BAR 4: assigned [io 0xfce0-0xfcff] pci 0000:06:08.1: BAR 4: no space for [io size 0x0020] pci 0000:06:08.1: BAR 4: trying firmware assignment [io 0xfce0-0xfcff] pci 0000:06:08.1: BAR 4: [io 0xfce0-0xfcff] conflicts with 0000:06:08.0 [io 0xfce0-0xfcff] pci 0000:06:08.1: BAR 4: failed to assign [io size 0x0020] pci 0000:05:00.0: PCI bridge to [bus 06] pci 0000:05:00.0: bridge window [mem 0xd8000000-0xd85fffff] [...] pci 0000:00:11.0: PCI bridge to [bus 01-06] pci 0000:00:11.0: bridge window [io 0xe000-0xefff] pci 0000:00:11.0: bridge window [mem 0xd8000000-0xdfffffff] pci 0000:00:11.0: bridge window [mem 0xa8000000-0xafffffff 64bit pref] pci_bus 0000:00: No. 2 try to assign unassigned res [...] pci 0000:06:08.1: BAR 4: no space for [io size 0x0020] pci 0000:06:08.1: BAR 4: trying firmware assignment [io 0xfce0-0xfcff] pci 0000:06:08.1: BAR 4: [io 0xfce0-0xfcff] conflicts with 0000:06:08.0 [io 0xfce0-0xfcff] pci 0000:06:08.1: BAR 4: failed to assign [io size 0x0020] pci 0000:05:00.0: PCI bridge to [bus 06] pci 0000:05:00.0: bridge window [mem 0xd8000000-0xd85fffff] [...] pci 0000:00:11.0: PCI bridge to [bus 01-06] pci 0000:00:11.0: bridge window [io 0xe000-0xefff] pci 0000:00:11.0: bridge window [mem 0xd8000000-0xdfffffff] pci 0000:00:11.0: bridge window [mem 0xa8000000-0xafffffff 64bit pref] pci_bus 0000:00: No. 3 try to assign unassigned res pci 0000:00:11.0: resource 7 [io 0xe000-0xefff] released [...] pci 0000:06:08.1: BAR 4: assigned [io 0x2000-0x201f] pci 0000:05:00.0: PCI bridge to [bus 06] pci 0000:05:00.0: bridge window [io 0x2000-0x2fff] pci 0000:05:00.0: bridge window [mem 0xd8000000-0xd85fffff] [...] pci 0000:00:11.0: PCI bridge to [bus 01-06] pci 0000:00:11.0: bridge window [io 0x1000-0x2fff] pci 0000:00:11.0: bridge window [mem 0xd8000000-0xdfffffff] pci 0000:00:11.0: bridge window [mem 0xa8000000-0xafffffff 64bit pref] pci_bus 0000:00: resource 4 [io 0x0000-0xffff] pci_bus 0000:00: resource 5 [mem 0x00000000-0xffffffff] pci_bus 0000:01: resource 0 [io 0x1000-0x2fff] pci_bus 0000:01: resource 1 [mem 0xd8000000-0xdfffffff] pci_bus 0000:01: resource 2 [mem 0xa8000000-0xafffffff 64bit pref] pci_bus 0000:02: resource 0 [io 0x1000-0x2fff] pci_bus 0000:02: resource 1 [mem 0xd8000000-0xd8bfffff] pci_bus 0000:04: resource 0 [io 0x1000-0x1fff] pci_bus 0000:04: resource 1 [mem 0xd8600000-0xd8afffff] pci_bus 0000:05: resource 0 [io 0x2000-0x2fff] pci_bus 0000:05: resource 1 [mem 0xd8000000-0xd85fffff] pci_bus 0000:06: resource 0 [io 0x2000-0x2fff] pci_bus 0000:06: resource 1 [mem 0xd8000000-0xd85fffff] -- note that the assignment of 0xfce0-0xfcff is outside the range of 0x2000-0x2fff assigned to bus #6: 05:00.0 PCI bridge: Texas Instruments XIO2000(A)/XIO2200A PCI Express-to-PCI Bridge (rev 03) (prog-if 00 [Normal decode]) Flags: bus master, fast devsel, latency 0 Bus: primary=05, secondary=06, subordinate=06, sec-latency=0 I/O behind bridge: 00002000-00002fff Memory behind bridge: d8000000-d85fffff Capabilities: [50] Power Management version 2 Capabilities: [60] Message Signalled Interrupts: 64bit+ Queue=0/4 Enable- Capabilities: [80] #0d [0000] Capabilities: [90] Express PCI/PCI-X Bridge IRQ 0 06:08.0 USB controller: VIA Technologies, Inc. VT82xx/62xx/VX700/8x0/900 UHCI USB 1.1 Controller (rev 61) (prog-if 00 [UHCI]) Subsystem: VIA Technologies, Inc. VT82xx/62xx/VX700/8x0/900 UHCI USB 1.1 Controller Flags: bus master, medium devsel, latency 22, IRQ 5 I/O ports at fce0 [size=32] Capabilities: [80] Power Management version 2 06:08.1 USB controller: VIA Technologies, Inc. VT82xx/62xx/VX700/8x0/900 UHCI USB 1.1 Controller (rev 61) (prog-if 00 [UHCI]) Subsystem: VIA Technologies, Inc. VT82xx/62xx/VX700/8x0/900 UHCI USB 1.1 Controller Flags: bus master, medium devsel, latency 22, IRQ 5 I/O ports at 2000 [size=32] Capabilities: [80] Power Management version 2 Since both 06:08.0 and 06:08.1 have the same reset defaults the latter device escapes its fate and gets a good assignment owing to an address conflict with the former device. Consequently when the device driver tries to access 06:08.0 according to its designated address range it pokes at an unassigned I/O location, likely subtractively decoded by the southbridge and forwarded to ISA, causing the driver to become confused and bail out: uhci_hcd 0000:06:08.0: host system error, PCI problems? uhci_hcd 0000:06:08.0: host controller process error, something bad happened! uhci_hcd 0000:06:08.0: host controller halted, very bad! uhci_hcd 0000:06:08.0: HCRESET not completed yet! uhci_hcd 0000:06:08.0: HC died; cleaning up if good luck happens or if bad luck does, an infinite flood of messages: uhci_hcd 0000:06:08.0: host system error, PCI problems? uhci_hcd 0000:06:08.0: host controller process error, something bad happened! uhci_hcd 0000:06:08.0: host system error, PCI problems? uhci_hcd 0000:06:08.0: host controller process error, something bad happened! uhci_hcd 0000:06:08.0: host system error, PCI problems? uhci_hcd 0000:06:08.0: host controller process error, something bad happened! [...] making the system virtually unusuable. This is because we have code to deal with a situation from PR #16263, where broken ACPI firmware reports the wrong address range for the host bridge's decoding window and trying to adjust to the window causes more breakage than leaving the BIOS assignments intact. This may work for a device directly on the root bus decoded by the host bridge only, but for a device behind one or more PCI-to-PCI (or CardBus) bridges those bridges' forwarding windows have been standardised and need to be respected, or leaving whatever has been there in a downstream device's BAR will have no effect as cycles for the addresses recorded there will have no chance to appear on the bus the device has been immediately attached to. Make sure then for a device behind a PCI-to-PCI bridge that any firmware assignment is within the bridge's relevant forwarding window or do not restore the assignment, fixing the system concerned as follows: pci_bus 0000:00: max bus depth: 4 pci_try_num: 5 [...] pci 0000:06:08.0: BAR 4: no space for [io size 0x0020] pci 0000:06:08.0: BAR 4: failed to assign [io 0xfce0-0xfcff] pci 0000:06:08.1: BAR 4: no space for [io size 0x0020] pci 0000:06:08.1: BAR 4: failed to assign [io 0xfce0-0xfcff] [...] pci_bus 0000:00: No. 2 try to assign unassigned res [...] pci 0000:06:08.0: BAR 4: no space for [io size 0x0020] pci 0000:06:08.0: BAR 4: failed to assign [io 0xfce0-0xfcff] pci 0000:06:08.1: BAR 4: no space for [io size 0x0020] pci 0000:06:08.1: BAR 4: failed to assign [io 0xfce0-0xfcff] [...] pci_bus 0000:00: No. 3 try to assign unassigned res [...] pci 0000:06:08.0: BAR 4: assigned [io 0x2000-0x201f] pci 0000:06:08.1: BAR 4: assigned [io 0x2020-0x203f] and making device 06:08.0 work correctly. Cf. <https://bugzilla.kernel.org/show_bug.cgi?id=16263> Signed-off-by: Maciej W. Rozycki <macro(a)orcam.me.uk> Fixes: 58c84eda0756 ("PCI: fall back to original BIOS BAR addresses") Cc: stable(a)vger.kernel.org # v2.6.35+ --- Hi, Resending this patch as it has gone into void. Patch re-verified against 5.17-rc2. For the record the system's bus topology is as follows: -[0000:00]-+-00.0 +-07.0 +-07.1 +-07.2 +-11.0-[0000:01-06]----00.0-[0000:02-06]--+-00.0-[0000:03]-- | +-01.0-[0000:04]--+-00.0 | | \-00.3 | \-02.0-[0000:05-06]----00.0-[0000:06]--+-05.0 | +-08.0 | +-08.1 | \-08.2 +-12.0 +-13.0 \-14.0 Maciej Changes from v1: - Do restore firmware BAR assignments behind a PCI-PCI bridge, but only if within the bridge's forwarding window. - Update the change description and heading accordingly (was: PCI: Do not restore firmware BAR assignments behind a PCI-PCI bridge). --- drivers/pci/setup-res.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) linux-pci-setup-res-fw-address-nobridge.diff Index: linux-macro/drivers/pci/setup-res.c =================================================================== --- linux-macro.orig/drivers/pci/setup-res.c +++ linux-macro/drivers/pci/setup-res.c @@ -212,9 +212,19 @@ static int pci_revert_fw_address(struct res->end = res->start + size - 1; res->flags &= ~IORESOURCE_UNSET; + /* + * If we're behind a P2P or CardBus bridge, make sure we're + * inside the relevant forwarding window, or otherwise the + * assignment must have been bogus and accesses intended for + * the range assigned would not reach the device anyway. + * On the root bus accept anything under the assumption the + * host bridge will let it through. + */ root = pci_find_parent_resource(dev, res); if (!root) { - if (res->flags & IORESOURCE_IO) + if (dev->bus->parent) + return -ENXIO; + else if (res->flags & IORESOURCE_IO) root = &ioport_resource; else root = &iomem_resource;

2 years, 1 month

2
8
0 0

[PATCH 4.9 0/7] 4.9.329-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.9.329 release. There are 7 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sun, 18 Sep 2022 10:04:31 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.329-rc… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.9.329-rc1 Brian Norris <briannorris(a)chromium.org> tracefs: Only clobber mode/uid/gid on remount if asked Jann Horn <jannh(a)google.com> mm: Fix TLB flush for not-first PFNMAP mappings in unmap_region() Hans de Goede <hdegoede(a)redhat.com> platform/x86: acer-wmi: Acer Aspire One AOD270/Packard Bell Dot keymap fixes Li Qiong <liqiong(a)nfschina.com> ieee802154: cc2520: add rc code in cc2520_tx() Kai-Heng Feng <kai.heng.feng(a)canonical.com> tg3: Disable tg3 device on system reboot to avoid triggering AER Jason Wang <wangborong(a)cdjrlc.com> HID: ishtp-hid-clientHID: ishtp-hid-client: Fix comment typo Rob Clark <robdclark(a)chromium.org> drm/msm/rd: Fix FIFO-full deadlock ------------- Diffstat: Makefile | 4 ++-- drivers/gpu/drm/msm/msm_rd.c | 3 +++ drivers/hid/intel-ish-hid/ishtp-hid.h | 2 +- drivers/net/ethernet/broadcom/tg3.c | 8 ++++++-- drivers/net/ieee802154/cc2520.c | 1 + drivers/platform/x86/acer-wmi.c | 9 ++++++++- fs/tracefs/inode.c | 31 +++++++++++++++++++++++-------- mm/mmap.c | 9 +++++++-- 8 files changed, 51 insertions(+), 16 deletions(-)

2 years, 1 month

5
11
0 0

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror September 2022