April 2023 - Linux-stable-mirror

FAILED: patch "[PATCH] btrfs: ignore fiemap path cache when there are multiple paths" failed to apply to 6.1-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.1-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.1.y git checkout FETCH_HEAD git cherry-pick -x 2280d425ba3599bdd85c41bd0ec8ba568f00c032 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2023040354-ramrod-papyrus-415b@gregkh' --subject-prefix 'PATCH 6.1.y' HEAD^.. Possible dependencies: 2280d425ba35 ("btrfs: ignore fiemap path cache when there are multiple paths for a node") 73e339e6ab74 ("btrfs: cache sharedness of the last few data extents during fiemap") b629685803bc ("btrfs: remove roots ulist when checking data extent sharedness") 84a7949d4097 ("btrfs: move ulists to data extent sharedness check context") 61dbb952f0a5 ("btrfs: turn the backref sharedness check cache into a context object") ceb707da9ad9 ("btrfs: directly pass the inode to btrfs_is_data_extent_shared()") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 2280d425ba3599bdd85c41bd0ec8ba568f00c032 Mon Sep 17 00:00:00 2001 From: Filipe Manana <fdmanana(a)suse.com> Date: Tue, 28 Mar 2023 10:45:20 +0100 Subject: [PATCH] btrfs: ignore fiemap path cache when there are multiple paths for a node During fiemap, when walking backreferences to determine if a b+tree node/leaf is shared, we may find a tree block (leaf or node) for which two parents were added to the references ulist. This happens if we get for example one direct ref (shared tree block ref) and one indirect ref (non-shared tree block ref) for the tree block at the current level, which can happen during relocation. In that case the fiemap path cache can not be used since it's meant for a single path, with one tree block at each possible level, so having multiple references for a tree block at any level may result in getting the level counter exceed BTRFS_MAX_LEVEL and eventually trigger the warning: WARN_ON_ONCE(level >= BTRFS_MAX_LEVEL) at lookup_backref_shared_cache() and at store_backref_shared_cache(). This is harmless since the code ignores any level >= BTRFS_MAX_LEVEL, the warning is there just to catch any unexpected case like the one described above. However if a user finds this it may be scary and get reported. So just ignore the path cache once we find a tree block for which there are more than one reference, which is the less common case, and update the cache with the sharedness check result for all levels below the level for which we found multiple references. Reported-by: Jarno Pelkonen <jarno.pelkonen(a)gmail.com> Link: https://lore.kernel.org/linux-btrfs/CAKv8qLmDNAGJGCtsevxx_VZ_YOvvs1L83iEJkT… Fixes: 12a824dc67a6 ("btrfs: speedup checking for extent sharedness during fiemap") CC: stable(a)vger.kernel.org # 6.1+ Signed-off-by: Filipe Manana <fdmanana(a)suse.com> Signed-off-by: David Sterba <dsterba(a)suse.com> diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c index 90e40d5ceccd..e54f0884802a 100644 --- a/fs/btrfs/backref.c +++ b/fs/btrfs/backref.c @@ -1921,8 +1921,7 @@ int btrfs_is_data_extent_shared(struct btrfs_inode *inode, u64 bytenr, level = -1; ULIST_ITER_INIT(&uiter); while (1) { - bool is_shared; - bool cached; + const unsigned long prev_ref_count = ctx->refs.nnodes; walk_ctx.bytenr = bytenr; ret = find_parent_nodes(&walk_ctx, &shared); @@ -1940,21 +1939,36 @@ int btrfs_is_data_extent_shared(struct btrfs_inode *inode, u64 bytenr, ret = 0; /* - * If our data extent was not directly shared (without multiple - * reference items), than it might have a single reference item - * with a count > 1 for the same offset, which means there are 2 - * (or more) file extent items that point to the data extent - - * this happens when a file extent item needs to be split and - * then one item gets moved to another leaf due to a b+tree leaf - * split when inserting some item. In this case the file extent - * items may be located in different leaves and therefore some - * of the leaves may be referenced through shared subtrees while - * others are not. Since our extent buffer cache only works for - * a single path (by far the most common case and simpler to - * deal with), we can not use it if we have multiple leaves - * (which implies multiple paths). + * More than one extent buffer (bytenr) may have been added to + * the ctx->refs ulist, in which case we have to check multiple + * tree paths in case the first one is not shared, so we can not + * use the path cache which is made for a single path. Multiple + * extent buffers at the current level happen when: + * + * 1) level -1, the data extent: If our data extent was not + * directly shared (without multiple reference items), then + * it might have a single reference item with a count > 1 for + * the same offset, which means there are 2 (or more) file + * extent items that point to the data extent - this happens + * when a file extent item needs to be split and then one + * item gets moved to another leaf due to a b+tree leaf split + * when inserting some item. In this case the file extent + * items may be located in different leaves and therefore + * some of the leaves may be referenced through shared + * subtrees while others are not. Since our extent buffer + * cache only works for a single path (by far the most common + * case and simpler to deal with), we can not use it if we + * have multiple leaves (which implies multiple paths). + * + * 2) level >= 0, a tree node/leaf: We can have a mix of direct + * and indirect references on a b+tree node/leaf, so we have + * to check multiple paths, and the extent buffer (the + * current bytenr) may be shared or not. One example is + * during relocation as we may get a shared tree block ref + * (direct ref) and a non-shared tree block ref (indirect + * ref) for the same node/leaf. */ - if (level == -1 && ctx->refs.nnodes > 1) + if ((ctx->refs.nnodes - prev_ref_count) > 1) ctx->use_path_cache = false; if (level >= 0) @@ -1964,18 +1978,45 @@ int btrfs_is_data_extent_shared(struct btrfs_inode *inode, u64 bytenr, if (!node) break; bytenr = node->val; - level++; - cached = lookup_backref_shared_cache(ctx, root, bytenr, level, - &is_shared); - if (cached) { - ret = (is_shared ? 1 : 0); - break; + if (ctx->use_path_cache) { + bool is_shared; + bool cached; + + level++; + cached = lookup_backref_shared_cache(ctx, root, bytenr, + level, &is_shared); + if (cached) { + ret = (is_shared ? 1 : 0); + break; + } } shared.share_count = 0; shared.have_delayed_delete_refs = false; cond_resched(); } + /* + * If the path cache is disabled, then it means at some tree level we + * got multiple parents due to a mix of direct and indirect backrefs or + * multiple leaves with file extent items pointing to the same data + * extent. We have to invalidate the cache and cache only the sharedness + * result for the levels where we got only one node/reference. + */ + if (!ctx->use_path_cache) { + int i = 0; + + level--; + if (ret >= 0 && level >= 0) { + bytenr = ctx->path_cache_entries[level].bytenr; + ctx->use_path_cache = true; + store_backref_shared_cache(ctx, root, bytenr, level, ret); + i = level + 1; + } + + for ( ; i < BTRFS_MAX_LEVEL; i++) + ctx->path_cache_entries[i].bytenr = 0; + } + /* * Cache the sharedness result for the data extent if we know our inode * has more than 1 file extent item that refers to the data extent.

1 year, 1 month

1
0
0 0

FAILED: patch "[PATCH] btrfs: scan device in non-exclusive mode" failed to apply to 5.10-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x 50d281fc434cb8e2497f5e70a309ccca6b1a09f0 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2023040340-happiest-next-a09c@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^.. Possible dependencies: 50d281fc434c ("btrfs: scan device in non-exclusive mode") 12659251ca5d ("btrfs: implement log-structured superblock for ZONED mode") 5d1ab66c56fe ("btrfs: disallow space_cache in ZONED mode") b70f509774ad ("btrfs: check and enable ZONED mode") 5b316468983d ("btrfs: get zone information of zoned block devices") bacce86ae8a7 ("btrfs: drop unused argument step from btrfs_free_extra_devids") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 50d281fc434cb8e2497f5e70a309ccca6b1a09f0 Mon Sep 17 00:00:00 2001 From: Anand Jain <anand.jain(a)oracle.com> Date: Thu, 23 Mar 2023 15:56:48 +0800 Subject: [PATCH] btrfs: scan device in non-exclusive mode This fixes mkfs/mount/check failures due to race with systemd-udevd scan. During the device scan initiated by systemd-udevd, other user space EXCL operations such as mkfs, mount, or check may get blocked and result in a "Device or resource busy" error. This is because the device scan process opens the device with the EXCL flag in the kernel. Two reports were received: - btrfs/179 test case, where the fsck command failed with the -EBUSY error - LTP pwritev03 test case, where mkfs.vfs failed with the -EBUSY error, when mkfs.vfs tried to overwrite old btrfs filesystem on the device. In both cases, fsck and mkfs (respectively) were racing with a systemd-udevd device scan, and systemd-udevd won, resulting in the -EBUSY error for fsck and mkfs. Reproducing the problem has been difficult because there is a very small window during which these userspace threads can race to acquire the exclusive device open. Even on the system where the problem was observed, the problem occurrences were anywhere between 10 to 400 iterations and chances of reproducing decreases with debug printk()s. However, an exclusive device open is unnecessary for the scan process, as there are no write operations on the device during scan. Furthermore, during the mount process, the superblock is re-read in the below function call chain: btrfs_mount_root btrfs_open_devices open_fs_devices btrfs_open_one_device btrfs_get_bdev_and_sb So, to fix this issue, removes the FMODE_EXCL flag from the scan operation, and add a comment. The case where mkfs may still write to the device and a scan is running, the btrfs signature is not written at that time so scan will not recognize such device. Reported-by: Sherry Yang <sherry.yang(a)oracle.com> Reported-by: kernel test robot <oliver.sang(a)intel.com> Link: https://lore.kernel.org/oe-lkp/202303170839.fdf23068-oliver.sang@intel.com CC: stable(a)vger.kernel.org # 5.4+ Signed-off-by: Anand Jain <anand.jain(a)oracle.com> Reviewed-by: David Sterba <dsterba(a)suse.com> Signed-off-by: David Sterba <dsterba(a)suse.com> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 6d0124b6e79e..ac0e8fb92fc8 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -1366,8 +1366,17 @@ struct btrfs_device *btrfs_scan_one_device(const char *path, fmode_t flags, * So, we need to add a special mount option to scan for * later supers, using BTRFS_SUPER_MIRROR_MAX instead */ - flags |= FMODE_EXCL; + /* + * Avoid using flag |= FMODE_EXCL here, as the systemd-udev may + * initiate the device scan which may race with the user's mount + * or mkfs command, resulting in failure. + * Since the device scan is solely for reading purposes, there is + * no need for FMODE_EXCL. Additionally, the devices are read again + * during the mount process. It is ok to get some inconsistent + * values temporarily, as the device paths of the fsid are the only + * required information for assembling the volume. + */ bdev = blkdev_get_by_path(path, flags, holder); if (IS_ERR(bdev)) return ERR_CAST(bdev);

1 year, 1 month

1
0
0 0

FAILED: patch "[PATCH] btrfs: scan device in non-exclusive mode" failed to apply to 5.4-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.4.y git checkout FETCH_HEAD git cherry-pick -x 50d281fc434cb8e2497f5e70a309ccca6b1a09f0 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2023040338-carving-ripping-8786@gregkh' --subject-prefix 'PATCH 5.4.y' HEAD^.. Possible dependencies: 50d281fc434c ("btrfs: scan device in non-exclusive mode") 12659251ca5d ("btrfs: implement log-structured superblock for ZONED mode") 5d1ab66c56fe ("btrfs: disallow space_cache in ZONED mode") b70f509774ad ("btrfs: check and enable ZONED mode") 5b316468983d ("btrfs: get zone information of zoned block devices") bacce86ae8a7 ("btrfs: drop unused argument step from btrfs_free_extra_devids") 96c2e067ed3e ("btrfs: skip devices without magic signature when mounting") c3e1f96c37d0 ("btrfs: enumerate the type of exclusive operation in progress") 944d3f9fac61 ("btrfs: switch seed device to list api") c4989c2fd0eb ("btrfs: simplify setting/clearing fs_info to btrfs_fs_devices") 54eed6ae8d8e ("btrfs: make close_fs_devices return void") 3712ccb7f1cc ("btrfs: factor out loop logic from btrfs_free_extra_devids") dc0ab488d2cb ("btrfs: factor out reada loop in __reada_start_machine") adca4d945c8d ("btrfs: qgroup: remove ASYNC_COMMIT mechanism in favor of reserve retry-after-EDQUOT") 3092c68fc58c ("btrfs: sysfs: add bdi link to the fsid directory") 998a0671961f ("btrfs: include non-missing as a qualifier for the latest_bdev") 1ed802c972c6 ("btrfs: drop useless goto in open_fs_devices") b335eab890ed ("btrfs: make btrfs_read_disk_super return struct btrfs_disk_super") c4a816c67c39 ("btrfs: introduce chunk allocation policy") 9a8658e33d8f ("btrfs: open code trivial helper btrfs_header_fsid") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 50d281fc434cb8e2497f5e70a309ccca6b1a09f0 Mon Sep 17 00:00:00 2001 From: Anand Jain <anand.jain(a)oracle.com> Date: Thu, 23 Mar 2023 15:56:48 +0800 Subject: [PATCH] btrfs: scan device in non-exclusive mode This fixes mkfs/mount/check failures due to race with systemd-udevd scan. During the device scan initiated by systemd-udevd, other user space EXCL operations such as mkfs, mount, or check may get blocked and result in a "Device or resource busy" error. This is because the device scan process opens the device with the EXCL flag in the kernel. Two reports were received: - btrfs/179 test case, where the fsck command failed with the -EBUSY error - LTP pwritev03 test case, where mkfs.vfs failed with the -EBUSY error, when mkfs.vfs tried to overwrite old btrfs filesystem on the device. In both cases, fsck and mkfs (respectively) were racing with a systemd-udevd device scan, and systemd-udevd won, resulting in the -EBUSY error for fsck and mkfs. Reproducing the problem has been difficult because there is a very small window during which these userspace threads can race to acquire the exclusive device open. Even on the system where the problem was observed, the problem occurrences were anywhere between 10 to 400 iterations and chances of reproducing decreases with debug printk()s. However, an exclusive device open is unnecessary for the scan process, as there are no write operations on the device during scan. Furthermore, during the mount process, the superblock is re-read in the below function call chain: btrfs_mount_root btrfs_open_devices open_fs_devices btrfs_open_one_device btrfs_get_bdev_and_sb So, to fix this issue, removes the FMODE_EXCL flag from the scan operation, and add a comment. The case where mkfs may still write to the device and a scan is running, the btrfs signature is not written at that time so scan will not recognize such device. Reported-by: Sherry Yang <sherry.yang(a)oracle.com> Reported-by: kernel test robot <oliver.sang(a)intel.com> Link: https://lore.kernel.org/oe-lkp/202303170839.fdf23068-oliver.sang@intel.com CC: stable(a)vger.kernel.org # 5.4+ Signed-off-by: Anand Jain <anand.jain(a)oracle.com> Reviewed-by: David Sterba <dsterba(a)suse.com> Signed-off-by: David Sterba <dsterba(a)suse.com> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 6d0124b6e79e..ac0e8fb92fc8 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -1366,8 +1366,17 @@ struct btrfs_device *btrfs_scan_one_device(const char *path, fmode_t flags, * So, we need to add a special mount option to scan for * later supers, using BTRFS_SUPER_MIRROR_MAX instead */ - flags |= FMODE_EXCL; + /* + * Avoid using flag |= FMODE_EXCL here, as the systemd-udev may + * initiate the device scan which may race with the user's mount + * or mkfs command, resulting in failure. + * Since the device scan is solely for reading purposes, there is + * no need for FMODE_EXCL. Additionally, the devices are read again + * during the mount process. It is ok to get some inconsistent + * values temporarily, as the device paths of the fsid are the only + * required information for assembling the volume. + */ bdev = blkdev_get_by_path(path, flags, holder); if (IS_ERR(bdev)) return ERR_CAST(bdev);

1 year, 1 month

1
0
0 0

FAILED: patch "[PATCH] btrfs: scan device in non-exclusive mode" failed to apply to 5.20-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.20-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.20.y git checkout FETCH_HEAD git cherry-pick -x 50d281fc434cb8e2497f5e70a309ccca6b1a09f0 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2023040334-reproduce-granola-78a1@gregkh' --subject-prefix 'PATCH 5.20.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 50d281fc434cb8e2497f5e70a309ccca6b1a09f0 Mon Sep 17 00:00:00 2001 From: Anand Jain <anand.jain(a)oracle.com> Date: Thu, 23 Mar 2023 15:56:48 +0800 Subject: [PATCH] btrfs: scan device in non-exclusive mode This fixes mkfs/mount/check failures due to race with systemd-udevd scan. During the device scan initiated by systemd-udevd, other user space EXCL operations such as mkfs, mount, or check may get blocked and result in a "Device or resource busy" error. This is because the device scan process opens the device with the EXCL flag in the kernel. Two reports were received: - btrfs/179 test case, where the fsck command failed with the -EBUSY error - LTP pwritev03 test case, where mkfs.vfs failed with the -EBUSY error, when mkfs.vfs tried to overwrite old btrfs filesystem on the device. In both cases, fsck and mkfs (respectively) were racing with a systemd-udevd device scan, and systemd-udevd won, resulting in the -EBUSY error for fsck and mkfs. Reproducing the problem has been difficult because there is a very small window during which these userspace threads can race to acquire the exclusive device open. Even on the system where the problem was observed, the problem occurrences were anywhere between 10 to 400 iterations and chances of reproducing decreases with debug printk()s. However, an exclusive device open is unnecessary for the scan process, as there are no write operations on the device during scan. Furthermore, during the mount process, the superblock is re-read in the below function call chain: btrfs_mount_root btrfs_open_devices open_fs_devices btrfs_open_one_device btrfs_get_bdev_and_sb So, to fix this issue, removes the FMODE_EXCL flag from the scan operation, and add a comment. The case where mkfs may still write to the device and a scan is running, the btrfs signature is not written at that time so scan will not recognize such device. Reported-by: Sherry Yang <sherry.yang(a)oracle.com> Reported-by: kernel test robot <oliver.sang(a)intel.com> Link: https://lore.kernel.org/oe-lkp/202303170839.fdf23068-oliver.sang@intel.com CC: stable(a)vger.kernel.org # 5.4+ Signed-off-by: Anand Jain <anand.jain(a)oracle.com> Reviewed-by: David Sterba <dsterba(a)suse.com> Signed-off-by: David Sterba <dsterba(a)suse.com> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 6d0124b6e79e..ac0e8fb92fc8 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -1366,8 +1366,17 @@ struct btrfs_device *btrfs_scan_one_device(const char *path, fmode_t flags, * So, we need to add a special mount option to scan for * later supers, using BTRFS_SUPER_MIRROR_MAX instead */ - flags |= FMODE_EXCL; + /* + * Avoid using flag |= FMODE_EXCL here, as the systemd-udev may + * initiate the device scan which may race with the user's mount + * or mkfs command, resulting in failure. + * Since the device scan is solely for reading purposes, there is + * no need for FMODE_EXCL. Additionally, the devices are read again + * during the mount process. It is ok to get some inconsistent + * values temporarily, as the device paths of the fsid are the only + * required information for assembling the volume. + */ bdev = blkdev_get_by_path(path, flags, holder); if (IS_ERR(bdev)) return ERR_CAST(bdev);

1 year, 1 month

1
0
0 0

FAILED: patch "[PATCH] btrfs: scan device in non-exclusive mode" failed to apply to 5.4-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.4.y git checkout FETCH_HEAD git cherry-pick -x 50d281fc434cb8e2497f5e70a309ccca6b1a09f0 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2023040333-vanquish-wriggle-e007@gregkh' --subject-prefix 'PATCH 5.4.y' HEAD^.. Possible dependencies: 50d281fc434c ("btrfs: scan device in non-exclusive mode") 12659251ca5d ("btrfs: implement log-structured superblock for ZONED mode") 5d1ab66c56fe ("btrfs: disallow space_cache in ZONED mode") b70f509774ad ("btrfs: check and enable ZONED mode") 5b316468983d ("btrfs: get zone information of zoned block devices") bacce86ae8a7 ("btrfs: drop unused argument step from btrfs_free_extra_devids") 96c2e067ed3e ("btrfs: skip devices without magic signature when mounting") c3e1f96c37d0 ("btrfs: enumerate the type of exclusive operation in progress") 944d3f9fac61 ("btrfs: switch seed device to list api") c4989c2fd0eb ("btrfs: simplify setting/clearing fs_info to btrfs_fs_devices") 54eed6ae8d8e ("btrfs: make close_fs_devices return void") 3712ccb7f1cc ("btrfs: factor out loop logic from btrfs_free_extra_devids") dc0ab488d2cb ("btrfs: factor out reada loop in __reada_start_machine") adca4d945c8d ("btrfs: qgroup: remove ASYNC_COMMIT mechanism in favor of reserve retry-after-EDQUOT") 3092c68fc58c ("btrfs: sysfs: add bdi link to the fsid directory") 998a0671961f ("btrfs: include non-missing as a qualifier for the latest_bdev") 1ed802c972c6 ("btrfs: drop useless goto in open_fs_devices") b335eab890ed ("btrfs: make btrfs_read_disk_super return struct btrfs_disk_super") c4a816c67c39 ("btrfs: introduce chunk allocation policy") 9a8658e33d8f ("btrfs: open code trivial helper btrfs_header_fsid") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 50d281fc434cb8e2497f5e70a309ccca6b1a09f0 Mon Sep 17 00:00:00 2001 From: Anand Jain <anand.jain(a)oracle.com> Date: Thu, 23 Mar 2023 15:56:48 +0800 Subject: [PATCH] btrfs: scan device in non-exclusive mode This fixes mkfs/mount/check failures due to race with systemd-udevd scan. During the device scan initiated by systemd-udevd, other user space EXCL operations such as mkfs, mount, or check may get blocked and result in a "Device or resource busy" error. This is because the device scan process opens the device with the EXCL flag in the kernel. Two reports were received: - btrfs/179 test case, where the fsck command failed with the -EBUSY error - LTP pwritev03 test case, where mkfs.vfs failed with the -EBUSY error, when mkfs.vfs tried to overwrite old btrfs filesystem on the device. In both cases, fsck and mkfs (respectively) were racing with a systemd-udevd device scan, and systemd-udevd won, resulting in the -EBUSY error for fsck and mkfs. Reproducing the problem has been difficult because there is a very small window during which these userspace threads can race to acquire the exclusive device open. Even on the system where the problem was observed, the problem occurrences were anywhere between 10 to 400 iterations and chances of reproducing decreases with debug printk()s. However, an exclusive device open is unnecessary for the scan process, as there are no write operations on the device during scan. Furthermore, during the mount process, the superblock is re-read in the below function call chain: btrfs_mount_root btrfs_open_devices open_fs_devices btrfs_open_one_device btrfs_get_bdev_and_sb So, to fix this issue, removes the FMODE_EXCL flag from the scan operation, and add a comment. The case where mkfs may still write to the device and a scan is running, the btrfs signature is not written at that time so scan will not recognize such device. Reported-by: Sherry Yang <sherry.yang(a)oracle.com> Reported-by: kernel test robot <oliver.sang(a)intel.com> Link: https://lore.kernel.org/oe-lkp/202303170839.fdf23068-oliver.sang@intel.com CC: stable(a)vger.kernel.org # 5.4+ Signed-off-by: Anand Jain <anand.jain(a)oracle.com> Reviewed-by: David Sterba <dsterba(a)suse.com> Signed-off-by: David Sterba <dsterba(a)suse.com> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 6d0124b6e79e..ac0e8fb92fc8 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -1366,8 +1366,17 @@ struct btrfs_device *btrfs_scan_one_device(const char *path, fmode_t flags, * So, we need to add a special mount option to scan for * later supers, using BTRFS_SUPER_MIRROR_MAX instead */ - flags |= FMODE_EXCL; + /* + * Avoid using flag |= FMODE_EXCL here, as the systemd-udev may + * initiate the device scan which may race with the user's mount + * or mkfs command, resulting in failure. + * Since the device scan is solely for reading purposes, there is + * no need for FMODE_EXCL. Additionally, the devices are read again + * during the mount process. It is ok to get some inconsistent + * values temporarily, as the device paths of the fsid are the only + * required information for assembling the volume. + */ bdev = blkdev_get_by_path(path, flags, holder); if (IS_ERR(bdev)) return ERR_CAST(bdev);

1 year, 1 month

1
0
0 0

Re: [PATCH] mm/swap: fix swap_info_struct race between swapoff and get_swap_pages()

by Rongwei Wang

On 4/3/23 12:10 PM, Matthew Wilcox wrote: > On Sun, Apr 02, 2023 at 06:19:20AM +0800, Rongwei Wang wrote: >> Without this modification, a core will wait (mostly) >> 'swap_info_struct->lock' when completing >> 'del_from_avail_list(p)'. Immediately, other cores >> soon calling 'add_to_avail_list()' to add the same >> object again when acquiring the lock that released >> by former. It's not the desired result but exists >> indeed. This case can be described as below: > This feels like a very verbose way of saying > > "The si->lock must be held when deleting the si from the > available list. Otherwise, another thread can re-add the > si to the available list, which can lead to memory corruption. > The only place we have found where this happens is in the > swapoff path." It looks better than mine. Sorry for my confusing description, it will be fixed in the next version. > >> +++ b/mm/swapfile.c >> @@ -2610,8 +2610,12 @@ SYSCALL_DEFINE1(swapoff, const char __user *, specialfile) >> spin_unlock(&swap_lock); >> goto out_dput; >> } >> - del_from_avail_list(p); >> + /* >> + * Here lock is used to protect deleting and SWP_WRITEOK clearing >> + * can be seen concurrently. >> + */ > This comment isn't necessary. But I would add a lockdep assert inside > __del_from_avail_list() that p->lock is held. Thanks. Actually, I have this line in previous test version, but delete for saving one line of code. I will update here as you said. Thanks for your time. > >> spin_lock(&p->lock); >> + del_from_avail_list(p); >> if (p->prio < 0) { >> struct swap_info_struct *si = p; >> int nid; >> -- >> 2.27.0 >> >>

1 year, 1 month

1
0
0 0

[PATCH 01/29] Revert "userfaultfd: don't fail on unrecognized features"

by Peter Xu

This is a proposal to revert commit 914eedcb9ba0ff53c33808. I found this when writting a simple UFFDIO_API test to be the first unit test in this set. Two things breaks with the commit: - UFFDIO_API check was lost and missing. According to man page, the kernel should reject ioctl(UFFDIO_API) if uffdio_api.api != 0xaa. This check is needed if the api version will be extended in the future, or user app won't be able to identify which is a new kernel. - Feature flags checks were removed, which means UFFDIO_API with a feature that does not exist will also succeed. According to the man page, we should (and it makes sense) to reject ioctl(UFFDIO_API) if unknown features passed in. Link: https://lore.kernel.org/r/20220722201513.1624158-1-axelrasmussen@google.com Cc: Axel Rasmussen <axelrasmussen(a)google.com> Cc: linux-stable <stable(a)vger.kernel.org> Signed-off-by: Peter Xu <peterx(a)redhat.com> --- fs/userfaultfd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/userfaultfd.c b/fs/userfaultfd.c index 8395605790f6..3b2a41c330e6 100644 --- a/fs/userfaultfd.c +++ b/fs/userfaultfd.c @@ -1977,8 +1977,10 @@ static int userfaultfd_api(struct userfaultfd_ctx *ctx, ret = -EFAULT; if (copy_from_user(&uffdio_api, buf, sizeof(uffdio_api))) goto out; - /* Ignore unsupported features (userspace built against newer kernel) */ - features = uffdio_api.features & UFFD_API_FEATURES; + features = uffdio_api.features; + ret = -EINVAL; + if (uffdio_api.api != UFFD_API || (features & ~UFFD_API_FEATURES)) + goto err_out; ret = -EPERM; if ((features & UFFD_FEATURE_EVENT_FORK) && !capable(CAP_SYS_PTRACE)) goto err_out; -- 2.39.1

1 year, 1 month

4
8
0 0

WAITING FOR YOUR RESPONSE FOR MORE DISCUSSION.......

by Mrs. Rabi Juanni Marcus

Hello my beloved, good morning from here, how are you doing today? My name is Mrs. Rabi Juanni Marcus, I have something very important that i want to discuss with you.

1 year, 1 month

1
0
0 0

Linux 5.15.103

by Greg Kroah-Hartman

I'm announcing the release of the 5.15.103 kernel. All users of the 5.15 kernel series must upgrade. The updated 5.15.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.15.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Documentation/admin-guide/kernel-parameters.txt | 51 +- Documentation/trace/ftrace.rst | 2 Makefile | 3 arch/alpha/kernel/module.c | 4 arch/arm64/include/asm/efi.h | 6 arch/arm64/kernel/efi.c | 2 arch/mips/include/asm/mach-rc32434/pci.h | 2 arch/powerpc/boot/dts/fsl/t1040rdb-rev-a.dts | 1 arch/powerpc/kernel/iommu.c | 4 arch/powerpc/kernel/time.c | 4 arch/powerpc/kernel/vmlinux.lds.S | 6 arch/riscv/include/asm/ftrace.h | 2 arch/riscv/include/asm/parse_asm.h | 5 arch/riscv/include/asm/patch.h | 2 arch/riscv/kernel/ftrace.c | 14 arch/riscv/kernel/patch.c | 28 + arch/riscv/kernel/stacktrace.c | 2 arch/riscv/kernel/traps.c | 14 arch/s390/kernel/ftrace.c | 86 --- arch/s390/kernel/vmlinux.lds.S | 2 arch/sh/kernel/vmlinux.lds.S | 1 arch/um/kernel/vmlinux.lds.S | 2 arch/x86/kernel/cpu/amd.c | 9 arch/x86/kvm/lapic.c | 1 arch/x86/kvm/svm/avic.c | 28 - arch/x86/kvm/vmx/evmcs.h | 11 arch/x86/kvm/vmx/vmx.c | 44 + drivers/block/brd.c | 10 drivers/block/nbd.c | 14 drivers/char/ipmi/ipmi_ssif.c | 34 + drivers/char/tpm/eventlog/acpi.c | 6 drivers/gpu/drm/amd/amdgpu/soc15.c | 5 drivers/gpu/drm/drm_atomic.c | 1 drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 6 drivers/gpu/drm/msm/adreno/a5xx_preempt.c | 4 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 6 drivers/gpu/drm/msm/msm_gem_submit.c | 5 drivers/gpu/drm/nouveau/dispnv50/disp.c | 16 drivers/gpu/drm/nouveau/dispnv50/wndw.c | 12 drivers/gpu/drm/nouveau/dispnv50/wndw.h | 7 drivers/iommu/amd/init.c | 105 +++- drivers/iommu/intel/pasid.c | 7 drivers/macintosh/windfarm_lm75_sensor.c | 4 drivers/macintosh/windfarm_smu_sensors.c | 4 drivers/media/i2c/ov5640.c | 2 drivers/media/rc/gpio-ir-recv.c | 18 drivers/net/dsa/mt7530.c | 35 - drivers/net/ethernet/broadcom/bgmac.c | 8 drivers/net/ethernet/broadcom/bgmac.h | 2 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 23 - drivers/net/ethernet/intel/ice/ice_ethtool.c | 6 drivers/net/ethernet/marvell/octeontx2/af/rvu.h | 5 drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c | 7 drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c | 16 drivers/net/ethernet/marvell/octeontx2/af/rvu_npa.c | 58 ++ drivers/net/ethernet/marvell/octeontx2/af/rvu_reg.h | 3 drivers/net/ethernet/mediatek/mtk_eth_soc.c | 3 drivers/net/ethernet/mediatek/mtk_eth_soc.h | 1 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 drivers/net/phy/microchip.c | 32 + drivers/net/phy/phy_device.c | 8 drivers/net/phy/smsc.c | 20 drivers/net/usb/lan78xx.c | 27 - drivers/nfc/fdp/i2c.c | 4 drivers/platform/x86/Kconfig | 3 drivers/regulator/core.c | 27 + drivers/scsi/hosts.c | 2 drivers/scsi/megaraid/megaraid_sas.h | 2 drivers/scsi/megaraid/megaraid_sas_fp.c | 2 drivers/staging/rtl8723bs/core/rtw_ap.c | 20 drivers/staging/rtl8723bs/core/rtw_cmd.c | 96 ++-- drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 4 drivers/staging/rtl8723bs/core/rtw_mlme.c | 6 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 56 +- drivers/staging/rtl8723bs/core/rtw_security.c | 6 drivers/staging/rtl8723bs/include/rtw_security.h | 8 drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 355 +++++----------- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 51 +- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 4 fs/attr.c | 72 +++ fs/btrfs/block-group.c | 3 fs/dlm/lockspace.c | 21 fs/dlm/lowcomms.c | 16 fs/dlm/lowcomms.h | 1 fs/dlm/main.c | 7 fs/dlm/midcomms.c | 17 fs/dlm/midcomms.h | 3 fs/ext4/block_validity.c | 26 - fs/ext4/ext4.h | 3 fs/ext4/fsmap.c | 2 fs/ext4/inline.c | 1 fs/ext4/inode.c | 7 fs/ext4/ioctl.c | 1 fs/ext4/mballoc.c | 205 +++++---- fs/ext4/namei.c | 36 + fs/ext4/page-io.c | 11 fs/ext4/xattr.c | 3 fs/f2fs/checkpoint.c | 2 fs/f2fs/compress.c | 2 fs/f2fs/data.c | 8 fs/f2fs/f2fs.h | 2 fs/f2fs/file.c | 2 fs/f2fs/gc.c | 6 fs/f2fs/inline.c | 4 fs/f2fs/inode.c | 14 fs/f2fs/node.c | 23 - fs/f2fs/recovery.c | 2 fs/f2fs/segment.c | 2 fs/file.c | 1 fs/fuse/file.c | 2 fs/inode.c | 90 ++-- fs/internal.h | 10 fs/locks.c | 3 fs/namei.c | 82 +++ fs/namespace.c | 29 - fs/ocfs2/file.c | 4 fs/ocfs2/namei.c | 1 fs/open.c | 8 fs/udf/inode.c | 2 fs/xfs/xfs_bmap_util.c | 9 fs/xfs/xfs_file.c | 24 - fs/xfs/xfs_iops.c | 56 -- fs/xfs/xfs_iops.h | 1 fs/xfs/xfs_pnfs.c | 9 include/asm-generic/vmlinux.lds.h | 5 include/linux/fs.h | 6 include/linux/pci_ids.h | 2 include/net/netfilter/nf_tproxy.h | 7 kernel/bpf/btf.c | 1 kernel/fork.c | 2 kernel/irq/irqdomain.c | 152 ++++-- kernel/watch_queue.c | 1 net/caif/caif_usb.c | 3 net/ipv4/netfilter/nf_tproxy_ipv4.c | 2 net/ipv4/tcp_bpf.c | 6 net/ipv4/udp_bpf.c | 3 net/ipv6/ila/ila_xlat.c | 1 net/ipv6/netfilter/nf_tproxy_ipv6.c | 2 net/netfilter/nf_conntrack_core.c | 4 net/netfilter/nf_conntrack_netlink.c | 14 net/nfc/netlink.c | 2 net/smc/af_smc.c | 13 net/sunrpc/svc.c | 6 net/unix/af_unix.c | 16 net/unix/unix_bpf.c | 3 scripts/checkkconfigsymbols.py | 13 scripts/clang-tools/run-clang-tools.py | 21 scripts/diffconfig | 16 tools/bpf/Makefile | 5 tools/bpf/bpf_jit_disasm.c | 5 tools/bpf/bpftool/Makefile | 5 tools/bpf/bpftool/jit_disasm.c | 42 + tools/build/Makefile.feature | 1 tools/build/feature/Makefile | 4 tools/build/feature/test-all.c | 4 tools/build/feature/test-disassembler-init-styled.c | 13 tools/include/tools/dis-asm-compat.h | 55 ++ tools/perf/Makefile.config | 8 tools/perf/builtin-inject.c | 1 tools/perf/builtin-stat.c | 15 tools/perf/util/annotate.c | 7 tools/perf/util/stat.c | 6 tools/perf/util/stat.h | 1 tools/perf/util/target.h | 12 tools/testing/selftests/netfilter/nft_nat.sh | 2 virt/kvm/kvm_main.c | 145 ++++-- 166 files changed, 1779 insertions(+), 1189 deletions(-) Alex Deucher (1): drm/amdgpu: fix error checking in amdgpu_read_mm_registers for soc15 Alexander Aring (3): fs: dlm: fix log of lowcomms vs midcomms fs: dlm: add midcomms init/start functions fs: dlm: start midcomms before scand Alexandre Ghiti (1): riscv: Use READ_ONCE_NOCHECK in imprecise unwinding stack mode Alexandru Matei (1): KVM: VMX: Fix crash due to uninitialized current_vmcs Alvaro Karsz (1): PCI: Add SolidRun vendor ID Andres Freund (5): tools build: Add feature test for init_disassemble_info API changes tools include: add dis-asm-compat.h to handle version differences tools perf: Fix compilation error with new binutils tools bpf_jit_disasm: Fix compilation error with new binutils tools bpftool: Fix compilation error with new binutils Andrew Cooper (1): x86/CPU/AMD: Disable XSAVES on AMD family 0x17 Bart Van Assche (1): scsi: core: Remove the /proc/scsi/${proc_name} directory earlier Ben Skeggs (1): drm/nouveau/kms/nv50-: remove unused functions Benjamin Coddington (1): SUNRPC: Fix a server shutdown leak Chandrakanth Patil (1): scsi: megaraid_sas: Update max supported LD IDs to 240 Changbin Du (1): perf stat: Fix counting when initial delay configured Christian Brauner (6): attr: add in_group_or_capable() fs: move should_remove_suid() attr: add setattr_should_drop_sgid() attr: use consistent sgid stripping checks fs: use consistent setgid checks in is_sxid() fs: hold writers when changing mount's idmapping Christian Kohlschütter (1): regulator: core: Fix off-on-delay-us for always-on/boot-on regulators Christoph Hellwig (1): nbd: use the correct block_device in nbd_bdev_reset Conor Dooley (1): RISC-V: Don't check text_mutex during stop_machine Corey Minyard (2): ipmi:ssif: Increase the message retry time ipmi:ssif: Add a timer between request retries D. Wythe (1): net/smc: fix fallback failed while sendmsg with fastopen Daniel Golle (1): net: ethernet: mtk_eth_soc: fix RX data corruption issue Darrick J. Wong (2): ext4: fix another off-by-one fsmap error on 1k block filesystems xfs: use setattr_copy to set vfs inode attributes Dave Chinner (3): xfs: remove XFS_PREALLOC_SYNC xfs: fallocate() should call file_modified() xfs: set prealloc flag in xfs_alloc_file_space() David Disseldorp (1): watch_queue: fix IOC_WATCH_QUEUE_SET_SIZE alloc error paths Dmitry Baryshkov (5): drm/msm/a5xx: fix setting of the CP_PREEMPT_ENABLE_LOCAL register drm/msm/a5xx: fix highest bank bit for a530 drm/msm/a5xx: fix the emptyness check in the preempt code drm/msm/a5xx: fix context faults during ring switch drm/msm/dpu: fix len of sc7180 ctl blocks Edward Humes (1): alpha: fix R_ALPHA_LITERAL reloc for large modules Eric Biggers (1): ext4: fix cgroup writeback accounting with fs-layer encryption Eric Dumazet (3): ila: do not generate empty messages in ila_xlat_nl_cmd_get_mapping() netfilter: conntrack: adopt safer max chain length af_unix: fix struct pid leaks in OOB support Eric Whitney (1): ext4: fix RENAME_WHITEOUT handling for inline directories Fedor Pchelkin (1): nfc: change order inside nfc_se_io error path Florian Westphal (1): netfilter: tproxy: fix deadlock due to missing BH disable Gaosheng Cui (1): xfs: remove xfs_setattr_time() declaration Gavrilov Ilia (1): iommu/amd: Add a length limitation for the ivrs_acpihid command-line parameter Greg Kroah-Hartman (2): powerpc/iommu: fix memory leak with using debugfs_lookup() Linux 5.15.103 Hangbin Liu (1): selftests: nft_nat: ensuring the listening side is up before starting the client Hannes Braun (1): staging: rtl8723bs: fix placement of braces Hans de Goede (2): staging: rtl8723bs: Pass correct parameters to cfg80211_get_bss() staging: rtl8723bs: Fix key-store index handling Harry Wentland (1): drm/connector: print max_requested_bpc in state debugfs Heiko Carstens (1): s390/ftrace: remove dead code Heiner Kallweit (1): net: phy: smsc: fix link up detection in forced irq mode Ivan Delalande (1): netfilter: ctnetlink: revert to dumping mark regardless of event type Jacob Pan (1): iommu/vt-d: Fix PASID directory pointer coherency Jaegeuk Kim (3): f2fs: avoid down_write on nat_tree_lock during checkpoint f2fs: do not bother checkpoint by f2fs_get_node_info f2fs: retry to update the inode page given data corruption Jagath Jog J (1): Staging: rtl8723bs: Placing opening { braces in previous line Jan Kara (3): udf: Fix off-by-one error when discarding preallocation ext4: Fix possible corruption when moving a directory ext4: Fix deadlock during directory rename Jens Axboe (1): brd: mark as nowait compatible Jiri Slaby (SUSE) (1): drm/nouveau/kms/nv50: fix nv50_wndw_new_ prototype Johan Hovold (2): irqdomain: Refactor __irq_domain_alloc_irqs() irqdomain: Fix mapping-creation race Johannes Thumshirn (1): btrfs: fix percent calculation for bg reclaim message Kang Chen (1): nfc: fdp: add null check of devm_kmalloc_array in fdp_nci_i2c_read_device_properties Kim Phillips (1): iommu/amd: Fix ill-formed ivrs_ioapic, ivrs_hpet and ivrs_acpihid options Kuniyuki Iwashima (1): af_unix: Remove unnecessary brackets around CONFIG_AF_UNIX_OOB. Li Jun (1): media: rc: gpio-ir-recv: add remove function Liao Chang (1): riscv: Add header include guards to insn.h Liu Jian (1): bpf, sockmap: Fix an infinite loop error when len is 0 in tcp_bpf_recvmsg_parser() Lorenz Bauer (1): btf: fix resolving BTF_KIND_VAR after ARRAY, STRUCT, UNION, PTR Luis Chamberlain (1): block/brd: add error handling support for add_disk() Lukas Czerner (1): ext4: block range must be validated before use in ext4_mb_clear_bb() Lukas Wunner (1): net: phy: smsc: Cache interrupt mask Mark Brown (1): regulator: Flag uncontrollable regulators as always_on Masahiro Yamada (4): scripts: handle BrokenPipeError for python scripts arch: fix broken BuildID for arm64 and riscv s390: define RUNTIME_DISCARD_EXIT to fix link error with GNU ld < 2.36 UML: define RUNTIME_DISCARD_EXIT Matthias Kaehlcke (1): regulator: core: Use ktime_get_boottime() to determine how long a regulator was off Mattias Nissler (1): riscv: Avoid enabling interrupts in die() Miaohe Lin (1): KVM: fix memoryleak in kvm_init() Michael Chan (1): bnxt_en: Avoid order-5 memory allocation for TPA data Michael Ellerman (2): powerpc/vmlinux.lds: Define RUNTIME_DISCARD_EXIT powerpc/vmlinux.lds: Don't discard .rela* for relocatable builds Michael Straube (1): staging: rtl8723bs: clean up comparsions to NULL Morten Linderud (1): tpm/eventlog: Don't abort tpm_read_log on faulty ACPI address Namhyung Kim (1): perf inject: Fix --buildid-all not to eat up MMAP2 Nathan Chancellor (1): macintosh: windfarm: Use unsigned type for 1-bit bitfields Nick Desaulniers (1): Makefile: use -gdwarf-{4|5} for assembler for DEBUG_INFO_DWARF{4|5} Palmer Dabbelt (1): RISC-V: Avoid dereferening NULL regs in die() Paul Elder (1): media: ov5640: Fix analogue gain control Petr Oros (1): ice: copy last block omitted in ice_get_module_eeprom() Pierre Gondois (1): arm64: efi: Make efi_rt_lock a raw_spinlock Rafał Miłecki (1): bgmac: fix *initial* chip reset to support BCM5358 Randy Dunlap (1): platform: x86: MLX_PLATFORM: select REGMAP instead of depending on it Ritesh Harjani (3): ext4: refactor ext4_free_blocks() to pull out ext4_mb_clear_bb() ext4: add ext4_sb_block_valid() refactored out of ext4_inode_block_valid() ext4: add strict range checks while freeing blocks Rob Clark (1): drm/msm: Fix potential invalid ptr free Rohan McLure (1): powerpc/kcsan: Exclude udelay to prevent recursive instrumentation Rongguang Wei (1): net: stmmac: add to set device wake up flag when stmmac init phy Russell King (Oracle) (1): net: phylib: get rid of unnecessary locking Sean Christopherson (3): KVM: Register /dev/kvm as the _very_ last thing during initialization KVM: SVM: Don't rewrite guest ICR on AVIC IPI virtualization failure KVM: SVM: Process ICR on AVIC IPI delivery failure due to invalid target Seth Forshee (1): filelocks: use mount idmapping for setlease permission check Shigeru Yoshida (1): net: caif: Fix use-after-free in cfusbl_device_notify() Suman Ghosh (1): octeontx2-af: Unlock contexts in the queue context cache in case of fault detection Suravee Suthikulpanit (1): iommu/amd: Add PCI segment support for ivrs_[ioapic/hpet/acpihid] commands Theodore Ts'o (1): fs: prevent out-of-bounds array speculation when closing a file descriptor Tobias Klauser (1): fork: allow CLONE_NEWTIME in clone3 flags Tom Saeger (1): sh: define RUNTIME_DISCARD_EXIT Vitaly Kuznetsov (4): KVM: Optimize kvm_make_vcpus_request_mask() a bit KVM: Pre-allocate cpumasks for kvm_make_all_cpus_request_except() KVM: nVMX: Don't use Enlightened MSR Bitmap for L3 KVM: VMX: Introduce vmx_msr_bitmap_l01_changed() helper Vladimir Oltean (2): powerpc: dts: t1040rdb: fix compatible string for Rev A boards net: dsa: mt7530: permit port 5 to work without port 6 on MT7621 SoC Yang Xu (2): fs: add mode_strip_sgid() helper fs: move S_ISGID stripping into the vfs_*() helpers Ye Bin (2): ext4: move where set the MAY_INLINE_DATA flag is set ext4: fix WARNING in ext4_update_inline_data Yuiko Oshino (1): net: lan78xx: fix accessing the LAN7800's internal phy specific registers from the MAC driver Zhihao Cheng (1): ext4: zero i_disksize when initializing the bootloader inode xurui (1): MIPS: Fix a compilation issue

1 year, 1 month

3
6
0 0

stable-rc/queue/5.15 baseline: 176 runs, 9 regressions (v5.15.105-64-gbf7736e5615d)

by kernelci.org bot

stable-rc/queue/5.15 baseline: 176 runs, 9 regressions (v5.15.105-64-gbf7736e5615d) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions -----------------------------+--------+---------------+----------+------------------------------+------------ asus-C436FA-Flip-hatch | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 asus-CM1400CXA-dalboz | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 asus-cx9400-volteer | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 beagle-xm | arm | lab-baylibre | gcc-10 | omap2plus_defconfig | 1 cubietruck | arm | lab-baylibre | gcc-10 | multi_v7_defconfig | 1 hp-x360-12b-c...4020-octopus | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 hp-x360-14-G1-sona | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 hp-x360-14a-cb0001xx-zork | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 lenovo-TPad-C13-Yoga-zork | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 Details: https://kernelci.org/test/job/stable-rc/branch/queue%2F5.15/kernel/v5.15.10… Test: baseline Tree: stable-rc Branch: queue/5.15 Describe: v5.15.105-64-gbf7736e5615d URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: bf7736e5615d72faeafea72067d89dd9eca5086f Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions -----------------------------+--------+---------------+----------+------------------------------+------------ asus-C436FA-Flip-hatch | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 Details: https://kernelci.org/test/plan/id/642a41c27dc980f1a062f7ac Results: 6 PASS, 1 FAIL, 0 SKIP Full config: x86_64_defconfig+x86-chromebook Compiler: gcc-10 (gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.15/v5.15.105-64-gbf7736e561… HTML log: https://storage.kernelci.org//stable-rc/queue-5.15/v5.15.105-64-gbf7736e561… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.deferred-probe-empty: https://kernelci.org/test/case/id/642a41c27dc980f1a062f7b1 failing since 5 days (last pass: v5.15.104-76-g9168fe5021cf1, first fail: v5.15.104-83-ga131fb06fbdb) 2023-04-03T03:02:06.341370 <8>[ 10.502603] <LAVA_SIGNAL_ENDRUN 0_dmesg 9846182_1.4.2.3.1> 2023-04-03T03:02:06.345033 + set +x 2023-04-03T03:02:06.453284 / # # 2023-04-03T03:02:06.555773 export SHELL=/bin/sh 2023-04-03T03:02:06.556627 # 2023-04-03T03:02:06.658767 / # export SHELL=/bin/sh. /lava-9846182/environment 2023-04-03T03:02:06.659577 2023-04-03T03:02:06.761520 / # . /lava-9846182/environment/lava-9846182/bin/lava-test-runner /lava-9846182/1 2023-04-03T03:02:06.761807 2023-04-03T03:02:06.767246 / # /lava-9846182/bin/lava-test-runner /lava-9846182/1 ... (12 line(s) more) platform | arch | lab | compiler | defconfig | regressions -----------------------------+--------+---------------+----------+------------------------------+------------ asus-CM1400CXA-dalboz | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 Details: https://kernelci.org/test/plan/id/642a41b7347033470162f76b Results: 6 PASS, 1 FAIL, 0 SKIP Full config: x86_64_defconfig+x86-chromebook Compiler: gcc-10 (gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.15/v5.15.105-64-gbf7736e561… HTML log: https://storage.kernelci.org//stable-rc/queue-5.15/v5.15.105-64-gbf7736e561… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.deferred-probe-empty: https://kernelci.org/test/case/id/642a41b7347033470162f770 failing since 5 days (last pass: v5.15.104-76-g9168fe5021cf1, first fail: v5.15.104-83-ga131fb06fbdb) 2023-04-03T03:01:52.320080 + set +x<8>[ 11.045115] <LAVA_SIGNAL_ENDRUN 0_dmesg 9846196_1.4.2.3.1> 2023-04-03T03:01:52.320180 2023-04-03T03:01:52.424890 / # # 2023-04-03T03:01:52.525964 export SHELL=/bin/sh 2023-04-03T03:01:52.526226 # 2023-04-03T03:01:52.627202 / # export SHELL=/bin/sh. /lava-9846196/environment 2023-04-03T03:01:52.627537 2023-04-03T03:01:52.728605 / # . /lava-9846196/environment/lava-9846196/bin/lava-test-runner /lava-9846196/1 2023-04-03T03:01:52.728952 2023-04-03T03:01:52.733815 / # /lava-9846196/bin/lava-test-runner /lava-9846196/1 ... (12 line(s) more) platform | arch | lab | compiler | defconfig | regressions -----------------------------+--------+---------------+----------+------------------------------+------------ asus-cx9400-volteer | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 Details: https://kernelci.org/test/plan/id/642a41a3fd8239904862f776 Results: 6 PASS, 1 FAIL, 0 SKIP Full config: x86_64_defconfig+x86-chromebook Compiler: gcc-10 (gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.15/v5.15.105-64-gbf7736e561… HTML log: https://storage.kernelci.org//stable-rc/queue-5.15/v5.15.105-64-gbf7736e561… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.deferred-probe-empty: https://kernelci.org/test/case/id/642a41a3fd8239904862f77b failing since 5 days (last pass: v5.15.104-76-g9168fe5021cf1, first fail: v5.15.104-83-ga131fb06fbdb) 2023-04-03T03:01:49.539642 <8>[ 8.013797] <LAVA_SIGNAL_ENDRUN 0_dmesg 9846205_1.4.2.3.1> 2023-04-03T03:01:49.542959 + set +x 2023-04-03T03:01:49.644554 # 2023-04-03T03:01:49.644835 2023-04-03T03:01:49.745776 / # #export SHELL=/bin/sh 2023-04-03T03:01:49.745981 2023-04-03T03:01:49.846872 / # export SHELL=/bin/sh. /lava-9846205/environment 2023-04-03T03:01:49.847087 2023-04-03T03:01:49.947987 / # . /lava-9846205/environment/lava-9846205/bin/lava-test-runner /lava-9846205/1 2023-04-03T03:01:49.948314 ... (13 line(s) more) platform | arch | lab | compiler | defconfig | regressions -----------------------------+--------+---------------+----------+------------------------------+------------ beagle-xm | arm | lab-baylibre | gcc-10 | omap2plus_defconfig | 1 Details: https://kernelci.org/test/plan/id/642a44c343406b17a962f778 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: omap2plus_defconfig Compiler: gcc-10 (arm-linux-gnueabihf-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.15/v5.15.105-64-gbf7736e561… HTML log: https://storage.kernelci.org//stable-rc/queue-5.15/v5.15.105-64-gbf7736e561… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.login: https://kernelci.org/test/case/id/642a44c343406b17a962f779 failing since 58 days (last pass: v5.15.91-12-g3290f78df1ab, first fail: v5.15.91-18-ga7afd81d41cb) platform | arch | lab | compiler | defconfig | regressions -----------------------------+--------+---------------+----------+------------------------------+------------ cubietruck | arm | lab-baylibre | gcc-10 | multi_v7_defconfig | 1 Details: https://kernelci.org/test/plan/id/642a44ee4c9fef0fd662f810 Results: 5 PASS, 1 FAIL, 1 SKIP Full config: multi_v7_defconfig Compiler: gcc-10 (arm-linux-gnueabihf-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.15/v5.15.105-64-gbf7736e561… HTML log: https://storage.kernelci.org//stable-rc/queue-5.15/v5.15.105-64-gbf7736e561… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.deferred-probe-empty: https://kernelci.org/test/case/id/642a44ee4c9fef0fd662f815 failing since 75 days (last pass: v5.15.82-123-gd03dbdba21ef, first fail: v5.15.87-100-ge215d5ead661) 2023-04-03T03:15:40.865566 <8>[ 9.970167] <LAVA_SIGNAL_ENDRUN 0_dmesg 3466315_1.5.2.4.1> 2023-04-03T03:15:40.973109 / # # 2023-04-03T03:15:41.075101 export SHELL=/bin/sh 2023-04-03T03:15:41.076056 # 2023-04-03T03:15:41.177914 / # export SHELL=/bin/sh. /lava-3466315/environment 2023-04-03T03:15:41.178510 2023-04-03T03:15:41.178784 <3>[ 10.193231] Bluetooth: hci0: command 0xfc18 tx timeout 2023-04-03T03:15:41.280106 / # . /lava-3466315/environment/lava-3466315/bin/lava-test-runner /lava-3466315/1 2023-04-03T03:15:41.280653 2023-04-03T03:15:41.285669 / # /lava-3466315/bin/lava-test-runner /lava-3466315/1 ... (12 line(s) more) platform | arch | lab | compiler | defconfig | regressions -----------------------------+--------+---------------+----------+------------------------------+------------ hp-x360-12b-c...4020-octopus | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 Details: https://kernelci.org/test/plan/id/642a423a98bad700a662f77f Results: 6 PASS, 1 FAIL, 0 SKIP Full config: x86_64_defconfig+x86-chromebook Compiler: gcc-10 (gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.15/v5.15.105-64-gbf7736e561… HTML log: https://storage.kernelci.org//stable-rc/queue-5.15/v5.15.105-64-gbf7736e561… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.deferred-probe-empty: https://kernelci.org/test/case/id/642a423a98bad700a662f784 failing since 5 days (last pass: v5.15.104-76-g9168fe5021cf1, first fail: v5.15.104-83-ga131fb06fbdb) 2023-04-03T03:04:10.213957 + <8>[ 10.615709] <LAVA_SIGNAL_ENDRUN 0_dmesg 9846215_1.4.2.3.1> 2023-04-03T03:04:10.214042 set +x 2023-04-03T03:04:10.315785 # 2023-04-03T03:04:10.316064 2023-04-03T03:04:10.417115 / # #export SHELL=/bin/sh 2023-04-03T03:04:10.417329 2023-04-03T03:04:10.518206 / # export SHELL=/bin/sh. /lava-9846215/environment 2023-04-03T03:04:10.518396 2023-04-03T03:04:10.619266 / # . /lava-9846215/environment/lava-9846215/bin/lava-test-runner /lava-9846215/1 2023-04-03T03:04:10.619509 ... (13 line(s) more) platform | arch | lab | compiler | defconfig | regressions -----------------------------+--------+---------------+----------+------------------------------+------------ hp-x360-14-G1-sona | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 Details: https://kernelci.org/test/plan/id/642a41f703926da7b262f7f3 Results: 6 PASS, 1 FAIL, 0 SKIP Full config: x86_64_defconfig+x86-chromebook Compiler: gcc-10 (gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.15/v5.15.105-64-gbf7736e561… HTML log: https://storage.kernelci.org//stable-rc/queue-5.15/v5.15.105-64-gbf7736e561… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.deferred-probe-empty: https://kernelci.org/test/case/id/642a41f703926da7b262f7f8 failing since 5 days (last pass: v5.15.104-76-g9168fe5021cf1, first fail: v5.15.104-83-ga131fb06fbdb) 2023-04-03T03:02:58.046883 + set +x 2023-04-03T03:02:58.053569 <8>[ 10.628159] <LAVA_SIGNAL_ENDRUN 0_dmesg 9846191_1.4.2.3.1> 2023-04-03T03:02:58.155928 2023-04-03T03:02:58.256941 / # #export SHELL=/bin/sh 2023-04-03T03:02:58.257144 2023-04-03T03:02:58.358068 / # export SHELL=/bin/sh. /lava-9846191/environment 2023-04-03T03:02:58.358286 2023-04-03T03:02:58.459213 / # . /lava-9846191/environment/lava-9846191/bin/lava-test-runner /lava-9846191/1 2023-04-03T03:02:58.459565 2023-04-03T03:02:58.464284 / # /lava-9846191/bin/lava-test-runner /lava-9846191/1 ... (12 line(s) more) platform | arch | lab | compiler | defconfig | regressions -----------------------------+--------+---------------+----------+------------------------------+------------ hp-x360-14a-cb0001xx-zork | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 Details: https://kernelci.org/test/plan/id/642a41c47dc980f1a062f7b7 Results: 6 PASS, 1 FAIL, 0 SKIP Full config: x86_64_defconfig+x86-chromebook Compiler: gcc-10 (gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.15/v5.15.105-64-gbf7736e561… HTML log: https://storage.kernelci.org//stable-rc/queue-5.15/v5.15.105-64-gbf7736e561… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.deferred-probe-empty: https://kernelci.org/test/case/id/642a41c47dc980f1a062f7bc failing since 5 days (last pass: v5.15.104-76-g9168fe5021cf1, first fail: v5.15.104-83-ga131fb06fbdb) 2023-04-03T03:02:10.333334 + set<8>[ 11.408029] <LAVA_SIGNAL_ENDRUN 0_dmesg 9846164_1.4.2.3.1> 2023-04-03T03:02:10.333444 +x 2023-04-03T03:02:10.438389 / # # 2023-04-03T03:02:10.539232 export SHELL=/bin/sh 2023-04-03T03:02:10.539467 # 2023-04-03T03:02:10.640442 / # export SHELL=/bin/sh. /lava-9846164/environment 2023-04-03T03:02:10.640697 2023-04-03T03:02:10.741532 / # . /lava-9846164/environment/lava-9846164/bin/lava-test-runner /lava-9846164/1 2023-04-03T03:02:10.741870 2023-04-03T03:02:10.746525 / # /lava-9846164/bin/lava-test-runner /lava-9846164/1 ... (12 line(s) more) platform | arch | lab | compiler | defconfig | regressions -----------------------------+--------+---------------+----------+------------------------------+------------ lenovo-TPad-C13-Yoga-zork | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 Details: https://kernelci.org/test/plan/id/642a41b07dc980f1a062f783 Results: 6 PASS, 1 FAIL, 0 SKIP Full config: x86_64_defconfig+x86-chromebook Compiler: gcc-10 (gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable-rc/queue-5.15/v5.15.105-64-gbf7736e561… HTML log: https://storage.kernelci.org//stable-rc/queue-5.15/v5.15.105-64-gbf7736e561… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.deferred-probe-empty: https://kernelci.org/test/case/id/642a41b07dc980f1a062f788 failing since 5 days (last pass: v5.15.104-76-g9168fe5021cf1, first fail: v5.15.104-83-ga131fb06fbdb) 2023-04-03T03:01:53.585800 + set +x<8>[ 12.319381] <LAVA_SIGNAL_ENDRUN 0_dmesg 9846208_1.4.2.3.1> 2023-04-03T03:01:53.585881 2023-04-03T03:01:53.690619 / # # 2023-04-03T03:01:53.791535 export SHELL=/bin/sh 2023-04-03T03:01:53.791747 # 2023-04-03T03:01:53.892683 / # export SHELL=/bin/sh. /lava-9846208/environment 2023-04-03T03:01:53.892871 2023-04-03T03:01:53.993777 / # . /lava-9846208/environment/lava-9846208/bin/lava-test-runner /lava-9846208/1 2023-04-03T03:01:53.994138 2023-04-03T03:01:53.998553 / # /lava-9846208/bin/lava-test-runner /lava-9846208/1 ... (12 line(s) more)

1 year, 1 month

1
0
0 0

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror April 2023