From: Eric Biggers <ebiggers(a)google.com>
Since commit d7e7b9af104c ("fscrypt: stop using keyrings subsystem for
fscrypt_master_key"), xfstest generic/270 causes a WARNING when run on
f2fs with test_dummy_encryption in the mount options:
$ kvm-xfstests -c f2fs/encrypt generic/270
[...]
WARNING: CPU: 1 PID: 2453 at fs/crypto/keyring.c:240 fscrypt_destroy_keyring+0x1f5/0x260
The cause of the WARNING is that not all encrypted inodes have been
evicted before fscrypt_destroy_keyring() is called, which violates an
assumption. This happens because the test uses an external quota file,
which gets automatically encrypted due to test_dummy_encryption.
Encryption of quota files has never really been supported. On ext4,
ext4_quota_read() does not decrypt the data, so encrypted quota files
are always considered invalid on ext4. On f2fs, f2fs_quota_read() uses
the pagecache, so trying to use an encrypted quota file gets farther,
resulting in the issue described above being possible. But this was
never intended to be possible, and there is no use case for it.
Therefore, make the quota support layer explicitly reject using
IS_ENCRYPTED inodes when quotaon is attempted.
Cc: stable(a)vger.kernel.org
Signed-off-by: Eric Biggers <ebiggers(a)google.com>
---
fs/quota/dquot.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
index 9e72bfe8bbad9..7e268cd2727cc 100644
--- a/fs/quota/dquot.c
+++ b/fs/quota/dquot.c
@@ -2339,6 +2339,20 @@ static int vfs_setup_quota_inode(struct inode *inode, int type)
if (sb_has_quota_loaded(sb, type))
return -EBUSY;
+ /*
+ * Quota files should never be encrypted. They should be thought of as
+ * filesystem metadata, not user data. New-style internal quota files
+ * cannot be encrypted by users anyway, but old-style external quota
+ * files could potentially be incorrectly created in an encrypted
+ * directory, hence this explicit check. Some reasons why encrypted
+ * quota files don't work include: (1) some filesystems that support
+ * encryption don't handle it in their quota_read and quota_write, and
+ * (2) cleaning up encrypted quota files at unmount would need special
+ * consideration, as quota files are cleaned up later than user files.
+ */
+ if (IS_ENCRYPTED(inode))
+ return -EINVAL;
+
dqopt->files[type] = igrab(inode);
if (!dqopt->files[type])
return -EIO;
base-commit: 708283abf896dd4853e673cc8cba70acaf9bf4ea
--
2.42.0
Sehr geehrter E-Mail-Besitzer,
Der Internationale Währungsfonds (IWF) entschädigt alle Betrugsopfer
und Ihre E-Mail-Adresse wurde auf der Liste der Betrugsopfer gefunden.
Dieses Western Union-Büro wurde vom IWF beauftragt Ihnen Ihre
Vergütung per Western Union Money Transfer zu überweisen.
Wir haben uns jedoch entschieden Ihre eigene Zahlung über Geldtransfer
der Westunion in Höhe von €5,000, pro Tag vorzunehmen bis die
Gesamtsumme von €1,500.000.00, vollständig an Sie überwiesen wurde.
Wir können die Zahlung möglicherweise nicht nur mit Ihrer
E-Mail-Adresse senden daher benötigen wir Ihre Informationen darüber
wohin wir das Geld an Sie senden wie z. B.:
Name des Adressaten ________________
Adresse________________
Land__________________
Telefonnummer________________
Angehängte Kopie Ihres Ausweises______________
Das Alter ________________________
Wir beginnen mit der Übertragung sobald wir Ihre Informationen
erhalten haben: Kontakt E-Mail: ( wuwumoneytransfer5000(a)hotmail.com)
Getreu,
Herr Anthony Duru,
Direktor von Geldtransfer der Westunion
Dobré ráno,
máte možnost sledovat stav každého stroje a výrobního procesu z kanceláře, konferenční místnosti nebo dokonce z domova či na cestách – na vašem telefonu?
Poskytujeme rychle implementovatelný a snadno použitelný nástroj, který zachytí i několikasekundový mikroprostoj a okamžitě přepočítá využití stroje v kontextu dané výrobní zakázky.
Kdykoli vidíte stav objednávky a jste informováni o případném snížení efektivity. Systém sám analyzuje data a připravuje cenné reporty, což operátorům umožňuje soustředit se na výrobní cíl.
Cíl je jednoduchý: jeden pohled – celá továrna. Čekám na odpověď, jestli vidíte možnost využití takového nástroje ve vaší firmě.
Pozdravy
Michal Rmoutil
Cc += stable(a)vger.kernel.org
On 05.09.23 07:57, Ahmad Fatoum wrote:
> On 05.09.23 00:33, Sasha Levin wrote:
>> This is a note to let you know that I've just added the patch titled
>>
>> thermal: core: constify params in thermal_zone_device_register
>>
>> to the 6.1-stable tree which can be found at:
>> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum…
>>
>> The filename of the patch is:
>> thermal-core-constify-params-in-thermal_zone_device_.patch
>> and it can be found in the queue-6.1 subdirectory.
>>
>> If you, or anyone else, feels it should not be added to the stable tree,
>> please let <stable(a)vger.kernel.org> know about it.
>
> Commit 3d439b1a2ad3 referenced in the patch description was first included
> in v6.4-rc1. So this is not v6.1 material, please drop.
>
> Thanks,
> Ahmad
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |